Commit Graph

10656 Commits

Author SHA1 Message Date
rcourtman ba69933da3 docs(patrol): record current diagnostic qualification failure
Preserve the real Assistant result separately from passing access routing
and disposable fault oracles. Correct tool evidence still produced
unsupported temporal claims, so customer outcome readiness remains open.

Refs #1928
2026-09-06 08:06:58 +01:00
rcourtman 173d74a8e4 test(patrol): exercise dependency and restart fault oracles
Validate the checked-in dependency and three service restart fault contracts
against disposable Docker resources before using them to assess model output.
Verify baseline, injected fault, refused duplicate injection, explicit fixture
recovery, and two-pass cleanup with unchanged pre-existing inventory.

These opt-in tests make no Pulse or model request. Fixture recovery is teardown
and does not count as an approval, rejection, execution or customer outcome.
Record exact live, owning-package and source-bound proof in the redesign plan.
2026-09-06 07:42:32 +01:00
rcourtman 58caeda69b fix(assistant): retain monitored targets without command access
Resolve monitored topology before checking command connections so unavailable
inspection retains the known resource and parent node. Prevent known targets
from falling through to a colliding agent ID, and preserve the single-agent
requirement when no target is supplied.

Use one failed tool envelope for diagnostic reads and file mutations. Missing
connections neither prove an installation problem nor count as successful
writes. Hypervisor lifecycle authority remains on its canonical action path.

Verify disconnected and unknown targets, collision isolation, all affected
tool handlers, token/WebSocket scope boundaries, and the linked Patrol and
Assistant failure journey at desktop and narrow widths.
2026-09-06 07:27:05 +01:00
rcourtman 1f41fa174d perf(metrics): avoid ordinal binding allocations
The 500-node dashboard query triggered repeated ordinal string conversions
in the SQLite driver while matching numbered parameters. Use alphabetic
named bindings to preserve current values and shared query branches without
that allocation cost.

Cover large cached scopes with changed resource families, identities,
metric filters and windows, including IDs that resemble SQL syntax.

Refs #1928
2026-09-06 06:54:40 +01:00
rcourtman b964eea767 fix(hostmetrics): retire disk probes before publishing results
A completed probe remained discoverable after its first caller returned,
allowing the next collection to reuse stale filesystem measurements.
Remove it and publish completion within one registry critical section.
Keep in-flight sharing, cancellation and timeout behaviour intact.

The controlled regression fails before this change. Twenty full package
runs and three race runs pass on the worker.

Refs #1928
2026-09-06 06:28:00 +01:00
rcourtman 618700db5e test(patrol): qualify bounded service storage failures
Add a disposable service-storage fault with an independent filesystem
oracle, bounded tmpfs writes, identity checks and verified recovery.
Exercise overwrite and symlink refusal without contacting a model.

Align the published schema with supported summary-term groups and validate
the complete catalogue in CI. Record the exact proof and remaining model
and missing-access qualification limits in the customer-journey plan.
2026-09-06 06:04:56 +01:00
rcourtman f26668aa6d perf(metrics): reuse retained query plans and output series
Canonical tier reconciliation rebuilt SQL and probed absent preferred tiers
for each fallback point, regressing batch reads and allocation costs. Reuse
bounded query shapes with current bindings and snapshot-scoped absence
checks, then append consecutive points directly to their output series.

Preserve coverage and ordering semantics and verify fresh bindings after
new preferred observations arrive. Integrate current main test additions.
2026-09-06 05:36:19 +01:00
pulse-triage[bot] 6c000837e2 Merge pull request #1926 from rcourtman/maintainer/20260906T030106Z
Protect alert continuity and TrueNAS investigation coverage
2026-09-06 04:52:52 +01:00
rcourtman ab9e0e4d3d fix(patrol): align qualification schema with action scenarios
The runtime and three restart scenarios use health_process_stop, but the
published schema rejected it. Accept that implemented injector and check
actual catalogue fault types against the schema to prevent recurrence.

Record the remaining missing-access and storage qualification gaps.
2026-09-06 04:33:20 +01:00
rcourtman f779bf064a Merge current main and verify diagnostic workflows
Integrate the latest alert, delivery and action-result changes with the
Patrol evidence conversation. Replace the conflicted browser receipt
with current source-bound qualification and fix shared warning-card
wrapping exposed by the intermediate-width check.

Real diagnostic and autonomous action outcome qualification stays open.
2026-09-06 04:22:09 +01:00
pulse-triage[bot] 4902a6271d Merge candidate 20260906T024756Z-core-runtime
Change-source: pulse-maintainer
2026-09-06 03:59:50 +01:00
pulse-triage[bot] df82a783fd Merge remote-tracking branch 'origin/main'
Change-source: pulse-maintainer
2026-09-06 03:59:50 +01:00
rcourtman 61607333cc fix(ai): keep Patrol decisions in one evidence conversation
Remove contextless evaluator and assessment passes, signal-count budgets,
and post-finding prompt replacement. Keep evidence tools available until
explicit run limits and retain incomplete assessments and provider errors
alongside accepted decisions. Failed file reads now preserve error status
through the model, telemetry and saved Assistant history.

Full chat, AI and tools packages, focused Patrol API and race tests pass.
Real read-only and scripted browser checks preserve failed reads and linked
uncertainty. Real-model and verified action outcome qualification remain open.
2026-09-06 03:59:37 +01:00
pulse-triage[bot] 3f74c0c273 Merge pull request #1924 from rcourtman/maintainer/20260906T021146Z
Keep persisted alerts from breaking threshold checks
2026-09-06 03:56:31 +01:00
pulse-triage[bot] 26d0af7a68 test(alerts): cover checkpoint recovery mirror write failures
SQLite remains authoritative when the JSON recovery mirror cannot be renamed. Exercise firing and resolved snapshots across restart so a failed mirror cannot silently lose or resurrect an incident. Close the event store before shutdown to prevent a second checkpoint from masking failure; also verify error reporting and temporary-file cleanup.

Change-source: pulse-maintainer
2026-09-06 03:51:04 +01:00
pulse-triage[bot] 2d63fbc25b test(web): scope TrueNAS incident count to active investigation surface
Run 34005581846 reports duplicate incident-count matches in the main page and mobile investigation sheet. Scope the existing count assertion to the active surface without selecting an arbitrary count match or changing product behaviour. Remove the unused panel locator. Browser requalification remains required; only diff whitespace validation was run locally.

Change-source: pulse-maintainer
2026-09-06 03:47:39 +01:00
pulse-triage[bot] e63704d890 test(alerts): verify PBS capacity callbacks across restart
Missing capacity and a measured empty datastore both report zero usage. Protect the existing distinction across durable manager restarts so missing observations cannot send a false recovery, while genuine recovery and subsequent high usage still dispatch callbacks. Assert incident identity and persisted lifecycle event counts as well as the callback boundary.

Change-source: pulse-maintainer
2026-09-06 03:18:43 +01:00
pulse-triage[bot] b96752a67a chore(integration): reconcile published main
Change-source: pulse-maintainer
2026-09-06 03:15:33 +01:00
pulse-triage[bot] a8ba97497f Merge pull request #1923 from rcourtman/maintainer/20260906T013333Z
Keep alert recovery visible and storage thresholds stable after outages
2026-09-06 03:05:45 +01:00
rcourtman f01db995ed perf(metrics): avoid redundant retained-read work
Execute plain retained reconciliation in one current SQLite snapshot and
reuse bounded compiled statements. Preserve per-series chronology without
a metric sort while keeping display aggregation ordering explicit.

Exact-base worker comparisons cover the prior PR benchmark failures. Full
metrics/database and focused concurrent race checks pass. Final CI and
real diagnostic outcome qualification remain open.
2026-09-06 03:02:59 +01:00
rcourtman 668af3fe6b fix(ai): preserve uncertain investigation conclusions
Tool-call totals do not establish diagnostic sufficiency. Preserve seed-only
and failed-read conclusions, remove count-based completion instructions from
evidence, and retain configured limits and authority checks.

Keep findings grouped under alerts selectable in the shared review panel so
their investigations and access limits remain available to Assistant.
2026-09-06 02:47:55 +01:00
pulse-triage[bot] bb1d177d87 test(alerts): isolate pending threshold fixtures from persisted state
Main CI job 101407611069 failed when the pending-start test restored unrelated active alerts from the shared data directory. A synthetic persisted alert reproduces the same failure locally. Give all three legacy threshold fixtures their own temporary directory and stop their workers during cleanup, retaining every threshold and pending-start assertion.

Validation: seeded-directory focused race tests pass 30 repetitions after failing before the repair. No production alert behaviour changes.
Change-source: pulse-maintainer
2026-09-06 02:46:05 +01:00
pulse-triage[bot] 2614a371ac Merge current upstream main before alert reliability publication
Change-source: pulse-maintainer
2026-09-06 02:36:34 +01:00
pulse-triage[bot] 65c7a7dbc1 Merge pull request #1918 from rcourtman/maintainer/20260905T212144Z
Keep alert delivery and release checks trustworthy
2026-09-06 02:26:53 +01:00
pulse-triage[bot] 32a0d40d2d Merge candidate 20260906T004518Z-web-product
Change-source: pulse-maintainer
2026-09-06 02:03:03 +01:00
pulse-triage[bot] 4270803e8f Merge candidate 20260906T004007Z-core-runtime
Change-source: pulse-maintainer
2026-09-06 01:58:36 +01:00
pulse-triage[bot] d04f368f6f fix(alerts): allow overview health refresh after recovery outage
Retry or Dismiss can succeed while the subsequent health request fails. Offer the existing refresh action when overview health is unavailable so users can verify recovery in place. Two regression cases fail without the fix; 24 focused tests pass with it. API mocks do not qualify installed notification delivery.

Change-source: pulse-maintainer
2026-09-06 01:55:06 +01:00
rcourtman c5d2f56dda fix(ai): preserve diagnostic evidence and proposal boundaries
Keep canonical disk risk, source freshness and retained history intact when
Assistant and Patrol gather evidence. Proposal acceptance validates an action
contract and must not rewrite uncertain conclusions as established root cause.

Preserve complete subscription tool batches without exposing routing envelopes
as answers. Keep wide answer tables readable and keyboard-scrollable on mobile.
Optimize retained tier reconciliation without discarding gaps or newer samples.

Record failed real-model diagnoses and outstanding autonomous qualification
separately from passing data-path and interface checks.
2026-09-06 01:54:28 +01:00
pulse-triage[bot] da5be2db15 fix(alerts): preserve storage override identity during config reload
Retain storage policy aliases in durable metric and forecast metadata and use them during active-alert re-evaluation. Recover exact legacy PBS aliases from the recorded instance and datastore identity. Prevent a configuration reload from fabricating recovery against global defaults after restart.

Change-source: pulse-maintainer
2026-09-06 01:47:11 +01:00
pulse-triage[bot] 4cc53d1095 Merge candidate 20260906T003510Z-web-product
Change-source: pulse-maintainer
2026-09-06 01:42:07 +01:00
pulse-triage[bot] 0641034be5 test(alerts): exercise overview delivery recovery actions
The overview only asserted that recovery buttons were present. Exercise cancellation, failure and deferred action/health completion so regressions cannot silently clear attention or allow conflicting actions while recovery is pending. APIs remain mocked; this does not qualify installed delivery.

Change-source: pulse-maintainer
2026-09-06 01:37:08 +01:00
pulse-triage[bot] 6252023fab test(notifications): preserve recovery receipts through provider outage
Successful ntfy transitions alone do not prove a rejected recovery can be retried after restart. Exercise real HTTP 503/202 responses and SQLite reopen, retaining the firing receipt on failure and clearing it only after recovery succeeds. Assert failed and successful audits remain truthful without replaying the firing notification.

Change-source: pulse-maintainer
2026-09-06 01:31:27 +01:00
pulse-triage[bot] 66de2220ee Merge candidate 20260906T000001Z-core-runtime
Change-source: pulse-maintainer
2026-09-06 01:21:23 +01:00
pulse-triage[bot] 806990af2b test(notifications): verify queued ntfy lifecycle HTTP receipts
Exercise the real queue processor alongside direct delivery for warning, critical, recovery and same-identity refiring. Require HTTP payload/header receipt and committed sent state, using an isolated temporary queue.

Change-source: pulse-maintainer
2026-09-06 01:02:48 +01:00
pulse-triage[bot] 4a68f98602 Merge commit '3413b37940add4305f7b8f16369d37320799073f'
Change-source: pulse-maintainer
2026-09-06 01:01:28 +01:00
pulse-triage[bot] 4051b7d32a Merge commit '9d1b726da9a08797c6adb6330a1d1bac6d763ac7'
Change-source: pulse-maintainer
2026-09-06 01:01:28 +01:00
pulse-triage[bot] 3413b37940 fix(ci): include release trains in build and E2E triggers
PR #1921 targets release/v6.4 but receives only docs and boundary checks because build and E2E triggers still name the historical release branch. Include versioned release trains for push and pull request events without changing job gates or path filters. A focused regression fails all four event/workflow combinations before repair and passes after it.

Change-source: pulse-maintainer
2026-09-06 00:58:57 +01:00
pulse-triage[bot] 9d1b726da9 Fix stale notification health ownership with browser regression proof
Keep overlapping success, failure and loading completion owned by the latest started read. Retain caller and queue-action controls, subsystem contracts and exact-source scripted Chromium evidence. Installed delivery and release qualification remain separate.

Change-source: pulse-maintainer
2026-09-06 00:57:10 +01:00
pulse-triage[bot] b34ca8ec3d Merge candidate 20260905T230019Z-core-runtime
Preserve the reviewed recurring-alert restart regression and its exact ancestry on current canonical main.

Change-source: pulse-maintainer
2026-09-06 00:57:00 +01:00
pulse-triage[bot] bde794de79 test(relay): serve revocation fixture over trusted TLS
The workspace-scoped managed relay proof still supplied an HTTP revocation origin after the canonical relay began enforcing HTTPS-only credential transport. Use a local TLS server and pass its certificate to the child process so the combined canonical repositories exercise the production boundary rather than failing during startup.

Change-source: pulse-maintainer
2026-09-06 00:53:30 +01:00
pulse-triage[bot] aed8b8923a test(release): require exact public Helm package receipt
The exact-byte public package check superseded metadata-only chart inspection, but the broader deployment contract still required the removed command and failed deterministically. Require the consumer-path pull and byte comparison so the contract matches the stronger workflow guarantee.

Change-source: pulse-maintainer
2026-09-06 00:17:44 +01:00
pulse-triage[bot] a61ef55d56 Protect recurring alert delivery after resolution and restart
Resolution must retire obsolete queue rows without permanently muting a resource condition. Extend the restart/retry regression to require delivery of a new incident sharing the resolved alert ID, alongside recovery and surviving grouped alerts.

Change-source: pulse-maintainer
2026-09-06 00:13:19 +01:00
pulse-triage[bot] 2a833eccdf Guard resolved notification durability across abrupt process exit
Exercise pending, interrupted, failed and dead-lettered grouped alerts without closing SQLite before restart. Verify that resolution survives and retry preserves only live members and genuine recovery. Also fix the disabled-delivery test race found by repeated race testing: queue construction already starts workers, so use the locked processor setter and await reconciliation.

Change-source: pulse-maintainer
2026-09-05 23:52:17 +01:00
pulse-triage[bot] 229d8668af Record disabled queued notifications as cancelled, not delivered
Distinguish policy skips from provider success so suppressed jobs do not create false sent rows or successful audit entries. Reconcile cancelled queue health after releasing alert gates, preserve real attempt history, and cover all three providers for firing/recovery and global/destination disablement.

Change-source: pulse-maintainer
2026-09-05 23:29:16 +01:00
pulse-triage[bot] f9b5f6254a Merge candidate 20260905T215524Z-core-runtime
Preserve the reviewed notification retry finality fix and its exact ancestry after incorporating the batch-start upstream main.

Change-source: pulse-maintainer
2026-09-05 23:15:23 +01:00
rcourtman 3a189f31d4 fix(metrics): reconcile retained history across storage tiers
Non-empty aggregate tiers hid recent raw samples and missing metric series.
Unify single and batch reads with indexed overlap resolution before
downsampling, and preserve recorded extrema through subsequent rollups.

Use canonical Proxmox storage coordinates in summaries and node history.
Discovery routing does not establish an installed Agent or agent history.

Record live evidence freshness and the remaining diagnosis qualification gaps.
2026-09-05 23:14:32 +01:00
pulse-triage[bot] fe273fc949 Prevent notification retries from replaying resolved alerts
Resolution only cancelled pending/sending rows, so retained failures could resurrect healthy incidents after operator retry and restart. Suppress terminal firing entries too, preserve unrelated grouped alerts and recovery jobs, and reconcile queue health after releasing locks. Reject stale per-item retries of cancelled or delivered rows. Regression tests reproduce both bypasses and retain failed-attempt history; focused race tests pass.

Change-source: pulse-maintainer
2026-09-05 23:11:02 +01:00
pulse-triage[bot] ce0c5a9795 Merge current upstream main before reliability proposal update
Incorporate the landed Patrol evidence-trust repair while preserving reviewed publication tip 6d6a776ef5 unchanged in ancestry.

Change-source: pulse-maintainer
2026-09-05 23:10:56 +01:00
rcourtman 4f9de86ef8 Merge pull request #1917 from rcourtman/fix/patrol-evidence-trust
fix(patrol): preserve refusals and expose measured summary evidence
2026-09-05 23:09:05 +01:00
pulse-triage[bot] 6d6a776ef5 Merge reviewed changed-data recovery qualification
Retain the exact reviewed browser regression commit and admission-clean source qualification receipts on current canonical main.\n\nChange-source: pulse-maintainer

Change-source: pulse-maintainer
2026-09-05 22:52:30 +01:00