gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-10 10:35:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge candidate 20260905T230019Z-core-runtime

Browse Source 
Preserve the reviewed recurring-alert restart regression and its exact ancestry on current canonical main.

Change-source: pulse-maintainer
This commit is contained in:
pulse-triage[bot]
2026-09-06 00:57:00 +01:00
parent bde794de79 a61ef55d56
commit b34ca8ec3d
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/notifications/queue_resolution_retry_test.go
+12 -2
View File
@@ -78,6 +78,15 @@ func TestResolvedTerminalFiringIsNotReplayedAfterRestart(t *testing.T) {
if retried != 2 {
t.Errorf("retried %d rows, want only surviving group and recovery", retried)
}
// Alert IDs identify a resource/condition and can recur. Resolution
// must suppress the old queue row, not permanently mute that ID.
if err := q.Enqueue(&QueuedNotification{
ID: "new-incident", Type: "webhook", Status: QueueStatusPending,
Config: []byte("{}"), MaxAttempts: 3,
Alerts: []*alerts.Alert{{ID: "healthy"}},
}); err != nil {
t.Fatal(err)
}
delivered := map[string][]string{}
var mu sync.Mutex
q.SetProcessor(func(n *QueuedNotification) error {
@@ -104,10 +113,11 @@ func TestResolvedTerminalFiringIsNotReplayedAfterRestart(t *testing.T) {
time.Sleep(time.Millisecond)
}
mu.Lock()
if len(delivered) != 2 || len(delivered["group"]) != 1 ||
if len(delivered) != 3 || len(delivered["new-incident"]) != 1 ||
delivered["new-incident"][0] != "healthy" || len(delivered["group"]) != 1 ||
delivered["group"][0] != "still-firing" ||
len(delivered["recovery"]) != 1 || delivered["recovery"][0] != "healthy" {
t.Errorf("replayed payloads = %v, want only still-firing and genuine recovery", delivered)
t.Errorf("replayed payloads = %v, want still-firing, genuine recovery and the new incident", delivered)
}
mu.Unlock()
var failures int