gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-10-23 20:25:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(release): give the rehearsal backend an explicit package timeout

Browse Source 
The accelerated rehearsal profile runs the backend as one serial 'go test -json -p 1 ./...', whose Go default per-package timeout is 10m. internal/api exceeded that under ordinary shared-worker load (606.9s at loadavg 5.55 on 2026-09-19) and the run failed with 'panic: test timed out after 10m0s' despite zero test assertions failing. The release profile already budgets 30m per package via run-release-backend-tests.sh. Add PULSE_RELEASE_PREFLIGHT_REHEARSAL_TIMEOUT (default 30m) and pass it as -timeout, and update the worker contract test that pins the exact rehearsal command. Change-source: pulse-maintainer

Change-source: pulse-maintainer
This commit is contained in:
pulse-triage[bot]
2026-09-19 21:24:38 +01:00
parent 95db35b6c3
commit d0f138cf26
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/release-preflight-worker.sh
+8 -1
View File
@@ -42,6 +42,13 @@ RUN_DIR="${WORKER_ROOT}/tmp/${RUN_ID}"
# argument". Set PULSE_RELEASE_PREFLIGHT_GO_TMP_DIR only for a deliberately
# isolated, equally short directory.
GO_TMP_DIR="${PULSE_RELEASE_PREFLIGHT_GO_TMP_DIR:-}"
# The rehearsal runs the backend as one serial `go test` process so its streamed
# events stay readable. Go's default per-package timeout is 10m, which the
# shared worker exceeded on internal/api under ordinary concurrent load (606.9s
# on 2026-09-19), killing an otherwise green package with "panic: test timed
# out". Match the release profile's per-package budget so host contention cannot
# turn a healthy candidate into a release-gate failure.
REHEARSAL_BACKEND_TIMEOUT="${PULSE_RELEASE_PREFLIGHT_REHEARSAL_TIMEOUT:-30m}"
TIMINGS_FILE="${RUN_DIR}/timings.tsv"
TEST_DATA_DIR="${WORKER_ROOT}/test-data/${PROFILE}"
# The smoke stacks publish the Pulse server and agent ports on the host. A
@@ -227,7 +234,7 @@ run_backend() (
# Keep readable Output and the original verdict via pipefail; instrument
# only the known stress-test window, without changing tests or thresholds.
backend_serial() {
env PULSE_DATA_DIR="$TEST_DATA_DIR" go test -json -p 1 ./... |
env PULSE_DATA_DIR="$TEST_DATA_DIR" go test -json -p 1 -timeout "$REHEARSAL_BACKEND_TIMEOUT" ./... |
python3 ./scripts/release-go-test-events.py
}
phase backend-serial backend_serial
scripts/release_control/internal/release_preflight_test.py
+2 -1
View File
@@ -320,6 +320,7 @@ echo CONTINUED
PROFILE=rehearsal
TEST_DATA_DIR=unused
ACTUAL_GO=fixture
REHEARSAL_BACKEND_TIMEOUT=30m
rm() {{ :; }}
mkdir() {{ :; }}
python3() {{
@@ -330,7 +331,7 @@ python3() {{
fi
}}
env() {{
[ "$*" = 'PULSE_DATA_DIR=unused go test -json -p 1 ./...' ] || return 42
[ "$*" = 'PULSE_DATA_DIR=unused go test -json -p 1 -timeout 30m ./...' ] || return 42
printf '%s\\n' '{{"Action":"output","Output":"synthetic verdict\\n"}}'
return {code}
}}