Keep legacy-key probe controls independent of poll success

The connected proof passed both probe/poll evidence cases but found one older fixture still expecting a successful stored-key probe to manufacture poll success. Keep its stored-secret, HTTPS and missing-ID controls while requiring untouched runtime timestamps and observations. Retain the adverse proof separately.

Change-source: pulse-maintainer
This commit is contained in:
pulse-triage[bot]
2026-10-04 00:32:36 +01:00
parent 9677b5cd60
commit afd6cf9757
+2 -2
View File
@@ -1005,8 +1005,8 @@ func TestTrueNASHandlers_HandleTestSavedConnection_UsesStoredLegacyAPIKey(t *tes
t.Fatalf("unexpected saved client config: %+v", gotConfig)
}
summary := poller.ConnectionSummaries("default", []config.TrueNASInstance{connection})[connection.ID]
if summary.Poll == nil || summary.Poll.LastSuccessAt == nil {
t.Fatalf("expected saved retest to update poll summary success state, got %+v", summary.Poll)
if summary.Poll == nil || summary.Poll.LastSuccessAt != nil || summary.Poll.LastAttemptAt != nil || summary.Observed != nil {
t.Fatalf("a successful legacy-key probe must not invent runtime polling evidence, got %+v", summary)
}
missingReq := httptest.NewRequest(http.MethodPost, "/api/truenas/connections/missing/test", nil)