From afd6cf975744836a2b5e461890563e2e1c3ce33f Mon Sep 17 00:00:00 2001
From: "pulse-triage[bot]"
 <249995291+pulse-triage[bot]@users.noreply.github.com>
Date: Sun, 4 Oct 2026 00:32:36 +0100
Subject: [PATCH] Keep legacy-key probe controls independent of poll success

The connected proof passed both probe/poll evidence cases but found one older fixture still expecting a successful stored-key probe to manufacture poll success. Keep its stored-secret, HTTPS and missing-ID controls while requiring untouched runtime timestamps and observations. Retain the adverse proof separately.

Change-source: pulse-maintainer
---
 internal/api/truenas_handlers_test.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/internal/api/truenas_handlers_test.go b/internal/api/truenas_handlers_test.go
index 79086ec57d..f1ba5961ed 100644
--- a/internal/api/truenas_handlers_test.go
+++ b/internal/api/truenas_handlers_test.go
@@ -1005,8 +1005,8 @@ func TestTrueNASHandlers_HandleTestSavedConnection_UsesStoredLegacyAPIKey(t *tes
 		t.Fatalf("unexpected saved client config: %+v", gotConfig)
 	}
 	summary := poller.ConnectionSummaries("default", []config.TrueNASInstance{connection})[connection.ID]
-	if summary.Poll == nil || summary.Poll.LastSuccessAt == nil {
-		t.Fatalf("expected saved retest to update poll summary success state, got %+v", summary.Poll)
+	if summary.Poll == nil || summary.Poll.LastSuccessAt != nil || summary.Poll.LastAttemptAt != nil || summary.Observed != nil {
+		t.Fatalf("a successful legacy-key probe must not invent runtime polling evidence, got %+v", summary)
 	}
 
 	missingReq := httptest.NewRequest(http.MethodPost, "/api/truenas/connections/missing/test", nil)