gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-24 12:13:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: preserve zero values for alert thresholds in UI

Browse Source 
addresses #480

Changed from || to ?? operator when loading alert config to properly
handle zero values. Previously, setting a threshold to 0 would revert
to defaults when navigating away due to || treating 0 as falsy.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
rcourtman
2025-10-01 06:57:09 +00:00
parent 178bb5aa34
commit a662bdb9a5
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend-modern/src/pages/Alerts.tsx
+12 -12
View File
@@ -326,27 +326,27 @@ export function Alerts() {
if (config.guestDefaults) {
// Extract trigger values from potentially hysteresis thresholds
setGuestDefaults({
cpu: getTriggerValue(config.guestDefaults.cpu) || 80,
memory: getTriggerValue(config.guestDefaults.memory) || 85,
disk: getTriggerValue(config.guestDefaults.disk) || 90,
diskRead: getTriggerValue(config.guestDefaults.diskRead) || 0,
diskWrite: getTriggerValue(config.guestDefaults.diskWrite) || 0,
networkIn: getTriggerValue(config.guestDefaults.networkIn) || 0,
networkOut: getTriggerValue(config.guestDefaults.networkOut) || 0,
cpu: getTriggerValue(config.guestDefaults.cpu) ?? 80,
memory: getTriggerValue(config.guestDefaults.memory) ?? 85,
disk: getTriggerValue(config.guestDefaults.disk) ?? 90,
diskRead: getTriggerValue(config.guestDefaults.diskRead) ?? 0,
diskWrite: getTriggerValue(config.guestDefaults.diskWrite) ?? 0,
networkIn: getTriggerValue(config.guestDefaults.networkIn) ?? 0,
networkOut: getTriggerValue(config.guestDefaults.networkOut) ?? 0,
});
}
if (config.nodeDefaults) {
setNodeDefaults({
cpu: getTriggerValue(config.nodeDefaults.cpu) || 80,
memory: getTriggerValue(config.nodeDefaults.memory) || 85,
disk: getTriggerValue(config.nodeDefaults.disk) || 90,
temperature: getTriggerValue(config.nodeDefaults.temperature) || 80,
cpu: getTriggerValue(config.nodeDefaults.cpu) ?? 80,
memory: getTriggerValue(config.nodeDefaults.memory) ?? 85,
disk: getTriggerValue(config.nodeDefaults.disk) ?? 90,
temperature: getTriggerValue(config.nodeDefaults.temperature) ?? 80,
});
}
if (config.storageDefault) {
setStorageDefault(getTriggerValue(config.storageDefault) || 85);
setStorageDefault(getTriggerValue(config.storageDefault) ?? 85);
}
if (config.timeThreshold !== undefined) {
setTimeThreshold(config.timeThreshold);