From a662bdb9a5335dd4e7baa3abb5734b523f671471 Mon Sep 17 00:00:00 2001
From: rcourtman <courtmanr@gmail.com>
Date: Wed, 1 Oct 2025 06:57:09 +0000
Subject: [PATCH] fix: preserve zero values for alert thresholds in UI
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

addresses #480

Changed from || to ?? operator when loading alert config to properly
handle zero values. Previously, setting a threshold to 0 would revert
to defaults when navigating away due to || treating 0 as falsy.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 frontend-modern/src/pages/Alerts.tsx | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/frontend-modern/src/pages/Alerts.tsx b/frontend-modern/src/pages/Alerts.tsx
index 7d6645c58..92b347bb4 100644
--- a/frontend-modern/src/pages/Alerts.tsx
+++ b/frontend-modern/src/pages/Alerts.tsx
@@ -326,27 +326,27 @@ export function Alerts() {
       if (config.guestDefaults) {
         // Extract trigger values from potentially hysteresis thresholds
         setGuestDefaults({
-          cpu: getTriggerValue(config.guestDefaults.cpu) || 80,
-          memory: getTriggerValue(config.guestDefaults.memory) || 85,
-          disk: getTriggerValue(config.guestDefaults.disk) || 90,
-          diskRead: getTriggerValue(config.guestDefaults.diskRead) || 0,
-          diskWrite: getTriggerValue(config.guestDefaults.diskWrite) || 0,
-          networkIn: getTriggerValue(config.guestDefaults.networkIn) || 0,
-          networkOut: getTriggerValue(config.guestDefaults.networkOut) || 0,
+          cpu: getTriggerValue(config.guestDefaults.cpu) ?? 80,
+          memory: getTriggerValue(config.guestDefaults.memory) ?? 85,
+          disk: getTriggerValue(config.guestDefaults.disk) ?? 90,
+          diskRead: getTriggerValue(config.guestDefaults.diskRead) ?? 0,
+          diskWrite: getTriggerValue(config.guestDefaults.diskWrite) ?? 0,
+          networkIn: getTriggerValue(config.guestDefaults.networkIn) ?? 0,
+          networkOut: getTriggerValue(config.guestDefaults.networkOut) ?? 0,
         });
       }
 
       if (config.nodeDefaults) {
         setNodeDefaults({
-          cpu: getTriggerValue(config.nodeDefaults.cpu) || 80,
-          memory: getTriggerValue(config.nodeDefaults.memory) || 85,
-          disk: getTriggerValue(config.nodeDefaults.disk) || 90,
-          temperature: getTriggerValue(config.nodeDefaults.temperature) || 80,
+          cpu: getTriggerValue(config.nodeDefaults.cpu) ?? 80,
+          memory: getTriggerValue(config.nodeDefaults.memory) ?? 85,
+          disk: getTriggerValue(config.nodeDefaults.disk) ?? 90,
+          temperature: getTriggerValue(config.nodeDefaults.temperature) ?? 80,
         });
       }
 
       if (config.storageDefault) {
-        setStorageDefault(getTriggerValue(config.storageDefault) || 85);
+        setStorageDefault(getTriggerValue(config.storageDefault) ?? 85);
       }
       if (config.timeThreshold !== undefined) {
         setTimeThreshold(config.timeThreshold);