gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-21 10:43:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Group VMs by instance instead of node for duplicate hostname support

Browse Source 
When multiple Proxmox instances share the same hostname (e.g., 'px1'),
VMs were incorrectly grouped together under a single heading.

Changed grouping key from guest.node (raw hostname) to guest.instance
(disambiguated name like 'px1 (10.0.2.224)') to properly separate VMs
from different Proxmox instances.

Related to #891
This commit is contained in:
rcourtman
2025-12-24 21:26:11 +00:00
parent 50e2e82a38
commit a1eb9cf118
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend-modern/src/components/Alerts/ThresholdsTable.tsx
+6 -5
View File
@@ -1301,14 +1301,15 @@ export function ThresholdsTable(props: ThresholdsTableProps) {
)
: guests;
// Group by node
// Group by instance (not node - node is just the hostname which may be duplicated)
// Instance is the disambiguated name like "px1" or "px1 (10.0.2.224)"
const grouped: Record<string, Resource[]> = {};
filteredGuests.forEach((guest) => {
const node = guest.node || 'Unknown';
if (!grouped[node]) {
grouped[node] = [];
const groupKey = guest.instance || guest.node || 'Unknown';
if (!grouped[groupKey]) {
grouped[groupKey] = [];
}
grouped[node].push(guest);
grouped[groupKey].push(guest);
});
// Sort guests within each group by vmid