From a1eb9cf1188e95de222a52aa272ebb29926efa77 Mon Sep 17 00:00:00 2001 From: rcourtman Date: Wed, 24 Dec 2025 21:26:11 +0000 Subject: [PATCH] fix: Group VMs by instance instead of node for duplicate hostname support When multiple Proxmox instances share the same hostname (e.g., 'px1'), VMs were incorrectly grouped together under a single heading. Changed grouping key from guest.node (raw hostname) to guest.instance (disambiguated name like 'px1 (10.0.2.224)') to properly separate VMs from different Proxmox instances. Related to #891 --- .../src/components/Alerts/ThresholdsTable.tsx | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/frontend-modern/src/components/Alerts/ThresholdsTable.tsx b/frontend-modern/src/components/Alerts/ThresholdsTable.tsx index d7b109e90..508ac992e 100644 --- a/frontend-modern/src/components/Alerts/ThresholdsTable.tsx +++ b/frontend-modern/src/components/Alerts/ThresholdsTable.tsx @@ -1301,14 +1301,15 @@ export function ThresholdsTable(props: ThresholdsTableProps) { ) : guests; - // Group by node + // Group by instance (not node - node is just the hostname which may be duplicated) + // Instance is the disambiguated name like "px1" or "px1 (10.0.2.224)" const grouped: Record = {}; filteredGuests.forEach((guest) => { - const node = guest.node || 'Unknown'; - if (!grouped[node]) { - grouped[node] = []; + const groupKey = guest.instance || guest.node || 'Unknown'; + if (!grouped[groupKey]) { + grouped[groupKey] = []; } - grouped[node].push(guest); + grouped[groupKey].push(guest); }); // Sort guests within each group by vmid