gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-10 02:25:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

style(frontend): format alert regression coverage

Browse Source 
Apply the repository formatter to the two reviewed test files that failed the existing proposal check. This changes layout only and preserves the accepted test behavior.

Change-source: pulse-maintainer
This commit is contained in:
pulse-triage[bot]
2026-09-06 22:06:45 +01:00
parent 6cbf3889aa
commit 56f8d50311
2 changed files with 42 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend-modern/src/components/__tests__/DemoBanner.test.tsx
+3 -1
View File
@@ -129,7 +129,9 @@ describe('DemoBanner', () => {
sessionStorage.clear();
await renderBanner();
expect(screen.getByRole('link', { name: 'Run Pulse on your own hardware' })).toBeInTheDocument();
expect(
screen.getByRole('link', { name: 'Run Pulse on your own hardware' }),
).toBeInTheDocument();
expect(screen.getByText('Demo instance with mock data (read-only)')).toBeInTheDocument();
});
});
frontend-modern/src/features/alerts/__tests__/OverviewTab.deliverystatus.test.tsx
+39 -36
View File
@@ -146,42 +146,45 @@ describe('OverviewTab delivery status line', () => {
expect(screen.getByText('Notifications are turned off')).toBeTruthy();
});
it.each(['success', 'failure'] as const)('does not apply a resolved incident %s to its recurrence on the same resource', async (outcome) => {
let finishOlder!: (value: AlertDeliveryDiagnosis[]) => void;
let rejectOlder!: (reason: Error) => void;
getDeliveryDiagnoses.mockReturnValueOnce(
new Promise((resolve, reject) => {
finishOlder = resolve;
rejectOlder = reject;
}),
);
getDeliveryDiagnoses.mockResolvedValueOnce([
makeDiagnosis('a2', { status: 'suppressed', reason: 'notifications_disabled' }),
]);
const original = makeAlert('a1');
const recurrence = {
...makeAlert('a2'),
resourceId: original.resourceId,
resourceName: original.resourceName,
startTime: '2026-09-06T19:00:00Z',
};
const [alerts, setAlerts] = createSignal<Record<string, Alert>>({ a1: original });
render(() => <OverviewTab {...defaultProps()} activeAlerts={alerts()} />);
await waitFor(() => expect(getDeliveryDiagnoses).toHaveBeenCalledTimes(1));
setAlerts({ a2: recurrence });
await waitFor(() => expect(screen.getByText('Notifications are turned off')).toBeTruthy());
expect(getDeliveryDiagnoses).toHaveBeenCalledTimes(2);
if (outcome === 'success') {
finishOlder([makeDiagnosis('a1', { lastNotified: '2026-08-26T10:15:00Z' })]);
} else {
rejectOlder(new Error('Previous incident diagnosis request failed'));
}
await Promise.resolve();
expect(screen.getByText('High CPU on VM a2')).toBeTruthy();
expect(screen.queryByText('High CPU on VM a1')).toBeNull();
expect(screen.queryByText(/^Dispatch requested /)).toBeNull();
expect(screen.getByText('Notifications are turned off')).toBeTruthy();
});
it.each(['success', 'failure'] as const)(
'does not apply a resolved incident %s to its recurrence on the same resource',
async (outcome) => {
let finishOlder!: (value: AlertDeliveryDiagnosis[]) => void;
let rejectOlder!: (reason: Error) => void;
getDeliveryDiagnoses.mockReturnValueOnce(
new Promise((resolve, reject) => {
finishOlder = resolve;
rejectOlder = reject;
}),
);
getDeliveryDiagnoses.mockResolvedValueOnce([
makeDiagnosis('a2', { status: 'suppressed', reason: 'notifications_disabled' }),
]);
const original = makeAlert('a1');
const recurrence = {
...makeAlert('a2'),
resourceId: original.resourceId,
resourceName: original.resourceName,
startTime: '2026-09-06T19:00:00Z',
};
const [alerts, setAlerts] = createSignal<Record<string, Alert>>({ a1: original });
render(() => <OverviewTab {...defaultProps()} activeAlerts={alerts()} />);
await waitFor(() => expect(getDeliveryDiagnoses).toHaveBeenCalledTimes(1));
setAlerts({ a2: recurrence });
await waitFor(() => expect(screen.getByText('Notifications are turned off')).toBeTruthy());
expect(getDeliveryDiagnoses).toHaveBeenCalledTimes(2);
if (outcome === 'success') {
finishOlder([makeDiagnosis('a1', { lastNotified: '2026-08-26T10:15:00Z' })]);
} else {
rejectOlder(new Error('Previous incident diagnosis request failed'));
}
await Promise.resolve();
expect(screen.getByText('High CPU on VM a2')).toBeTruthy();
expect(screen.queryByText('High CPU on VM a1')).toBeNull();
expect(screen.queryByText(/^Dispatch requested /)).toBeNull();
expect(screen.getByText('Notifications are turned off')).toBeTruthy();
},
);
it('renders no delivery line when the diagnosis fetch fails', async () => {
const activeAlerts: Record<string, Alert> = { a1: makeAlert('a1') };