From 56f8d50311aa30025e20ee8f7b0923e6b7d2a76a Mon Sep 17 00:00:00 2001 From: "pulse-triage[bot]" <249995291+pulse-triage[bot]@users.noreply.github.com> Date: Sun, 6 Sep 2026 22:06:45 +0100 Subject: [PATCH] style(frontend): format alert regression coverage Apply the repository formatter to the two reviewed test files that failed the existing proposal check. This changes layout only and preserves the accepted test behavior. Change-source: pulse-maintainer --- .../components/__tests__/DemoBanner.test.tsx | 4 +- .../OverviewTab.deliverystatus.test.tsx | 75 ++++++++++--------- 2 files changed, 42 insertions(+), 37 deletions(-) diff --git a/frontend-modern/src/components/__tests__/DemoBanner.test.tsx b/frontend-modern/src/components/__tests__/DemoBanner.test.tsx index d25d3093d..9c25e08cd 100644 --- a/frontend-modern/src/components/__tests__/DemoBanner.test.tsx +++ b/frontend-modern/src/components/__tests__/DemoBanner.test.tsx @@ -129,7 +129,9 @@ describe('DemoBanner', () => { sessionStorage.clear(); await renderBanner(); - expect(screen.getByRole('link', { name: 'Run Pulse on your own hardware' })).toBeInTheDocument(); + expect( + screen.getByRole('link', { name: 'Run Pulse on your own hardware' }), + ).toBeInTheDocument(); expect(screen.getByText('Demo instance with mock data (read-only)')).toBeInTheDocument(); }); }); diff --git a/frontend-modern/src/features/alerts/__tests__/OverviewTab.deliverystatus.test.tsx b/frontend-modern/src/features/alerts/__tests__/OverviewTab.deliverystatus.test.tsx index e017f3341..8e1886af9 100644 --- a/frontend-modern/src/features/alerts/__tests__/OverviewTab.deliverystatus.test.tsx +++ b/frontend-modern/src/features/alerts/__tests__/OverviewTab.deliverystatus.test.tsx @@ -146,42 +146,45 @@ describe('OverviewTab delivery status line', () => { expect(screen.getByText('Notifications are turned off')).toBeTruthy(); }); - it.each(['success', 'failure'] as const)('does not apply a resolved incident %s to its recurrence on the same resource', async (outcome) => { - let finishOlder!: (value: AlertDeliveryDiagnosis[]) => void; - let rejectOlder!: (reason: Error) => void; - getDeliveryDiagnoses.mockReturnValueOnce( - new Promise((resolve, reject) => { - finishOlder = resolve; - rejectOlder = reject; - }), - ); - getDeliveryDiagnoses.mockResolvedValueOnce([ - makeDiagnosis('a2', { status: 'suppressed', reason: 'notifications_disabled' }), - ]); - const original = makeAlert('a1'); - const recurrence = { - ...makeAlert('a2'), - resourceId: original.resourceId, - resourceName: original.resourceName, - startTime: '2026-09-06T19:00:00Z', - }; - const [alerts, setAlerts] = createSignal>({ a1: original }); - render(() => ); - await waitFor(() => expect(getDeliveryDiagnoses).toHaveBeenCalledTimes(1)); - setAlerts({ a2: recurrence }); - await waitFor(() => expect(screen.getByText('Notifications are turned off')).toBeTruthy()); - expect(getDeliveryDiagnoses).toHaveBeenCalledTimes(2); - if (outcome === 'success') { - finishOlder([makeDiagnosis('a1', { lastNotified: '2026-08-26T10:15:00Z' })]); - } else { - rejectOlder(new Error('Previous incident diagnosis request failed')); - } - await Promise.resolve(); - expect(screen.getByText('High CPU on VM a2')).toBeTruthy(); - expect(screen.queryByText('High CPU on VM a1')).toBeNull(); - expect(screen.queryByText(/^Dispatch requested /)).toBeNull(); - expect(screen.getByText('Notifications are turned off')).toBeTruthy(); - }); + it.each(['success', 'failure'] as const)( + 'does not apply a resolved incident %s to its recurrence on the same resource', + async (outcome) => { + let finishOlder!: (value: AlertDeliveryDiagnosis[]) => void; + let rejectOlder!: (reason: Error) => void; + getDeliveryDiagnoses.mockReturnValueOnce( + new Promise((resolve, reject) => { + finishOlder = resolve; + rejectOlder = reject; + }), + ); + getDeliveryDiagnoses.mockResolvedValueOnce([ + makeDiagnosis('a2', { status: 'suppressed', reason: 'notifications_disabled' }), + ]); + const original = makeAlert('a1'); + const recurrence = { + ...makeAlert('a2'), + resourceId: original.resourceId, + resourceName: original.resourceName, + startTime: '2026-09-06T19:00:00Z', + }; + const [alerts, setAlerts] = createSignal>({ a1: original }); + render(() => ); + await waitFor(() => expect(getDeliveryDiagnoses).toHaveBeenCalledTimes(1)); + setAlerts({ a2: recurrence }); + await waitFor(() => expect(screen.getByText('Notifications are turned off')).toBeTruthy()); + expect(getDeliveryDiagnoses).toHaveBeenCalledTimes(2); + if (outcome === 'success') { + finishOlder([makeDiagnosis('a1', { lastNotified: '2026-08-26T10:15:00Z' })]); + } else { + rejectOlder(new Error('Previous incident diagnosis request failed')); + } + await Promise.resolve(); + expect(screen.getByText('High CPU on VM a2')).toBeTruthy(); + expect(screen.queryByText('High CPU on VM a1')).toBeNull(); + expect(screen.queryByText(/^Dispatch requested /)).toBeNull(); + expect(screen.getByText('Notifications are turned off')).toBeTruthy(); + }, + ); it('renders no delivery line when the diagnosis fetch fails', async () => { const activeAlerts: Record = { a1: makeAlert('a1') };