mirror of
https://github.com/taylanbakircioglu/haproxy-openmanager.git
synced 2026-09-12 05:48:58 +00:00
taylanbakircioglu
4c84596215
Applies PR #59 by Mustafa Ulukaya (github.com/taylanbakircioglu/haproxy-openmanager/pull/59,
head ef26860) as authored, with only the merge conflicts resolved. Behavioural
gaps found in review are closed by the follow-up commits on this branch rather
than by rewriting the contribution.
One queryable timeline covering both directions: every inbound API call
(including GETs and 4xx/5xx) with user, client IP, status, duration and
redacted, size-capped bodies; and every outbound HTTP call the backend makes,
tagged with who it went to. Outbound rows inherit the inbound request's id, so
one operator action and the CA/DNS calls it triggered read as a single trace.
Conflict resolution (the branch was cut at v1.10.3, this tree is v1.10.14):
* SCHEMA_VERSION: 11 -> 12, NOT the 11 the branch proposed. 11 was taken in the
meantime by v1.10.4 (vip_discoveries). Landing this as 11 would be silently
inert: run_all_migrations() returns early on `applied_version >=
SCHEMA_VERSION`, so every database already at 11 skips the whole sequence and
gets neither request_logs nor the requestlog.* permissions, while a fresh
install gets both. The branch's own test asserts `>= 11`, so it still holds.
* services/acme_diagnostics.py: the branch instrumented a `session.head(...)`
probe, which is what that function did when it was cut. It has since become a
GET that classifies the response body, because a status code alone cannot
tell a working challenge endpoint from a SPA catch-all answering 200 with
index.html. Taking the branch's side would reintroduce that bug, so the GET
probe is kept and the span wraps it. The span records the classification, not
the body: `_PROBE_BODY_LIMIT` is 64 KB of a third party's page and storing it
would put an arbitrary remote document in the audit table per probed domain.
* backend/version.json, frontend/package.json: 1.11.0, release date moved to
the date this actually ships.
* README.md, UPGRADE_GUIDE.md: the v1.11.0 sections are added above the
existing entries; every note from v1.10.4 through v1.10.14 is preserved.
Schema: one new table (request_logs) plus its settings seed. No existing table
altered, no agent or rendered-config change. As with every SCHEMA_VERSION bump,
the four built-in roles are re-seeded to their defaults - export role
customizations before upgrading.
Kill switches: REQUEST_LOG_ENABLED=false (middleware never registered) or the
`enabled` toggle in Settings -> Request Log.