mirror of
https://github.com/taylanbakircioglu/haproxy-openmanager.git
synced 2026-09-16 15:45:11 +00:00
02b1cb2bca
Closes #13, Closes #14. This release squashes the v1.4.0 → v1.5.0 development line. v1.4.0 shipped the ACME stability & enterprise audit (Issues #10/#11/#12). v1.5.0 builds on that foundation with two co-equal headline features plus a 22-round audit campaign hardening the prior configuration surface. License remains MIT for v1.5.0 (relicense to AGPL-3.0 lands in v1.5.2). ------------------------------------------------------------------ HEADLINE FEATURE A — ACME Diagnostic Panel (Issue #13) ------------------------------------------------------------------ A live pre-flight + post-failure diagnostic surface for every ACME order, reachable from the ACME Automation page. The panel exists to make ACME failures legible to operators who do NOT have shell access to the API host. Endpoints (`backend/routers/acme_diagnostics.py`): POST /api/letsencrypt/orders/{order_id}/diagnostics Run the full 5-check suite (DNS / port-80 / routing / account / agents) and humanize the order's `error_detail` (>=11 RFC-8555 problem types, backwards compatible with legacy plain-string failures). POST /api/letsencrypt/orders/{order_id}/diagnostics/ {check_id}/rerun Re-run a single check in place — used by the "Re-run" button on every row of the modal's pre-flight table. GET /api/letsencrypt/orders/{order_id}/events Merged event timeline combining the typed `acme_order_events` rows with correlated `user_activity_logs` entries (resource_type = 'letsencrypt_order' AND resource_id = order_id). The diagnostic modal auto-tails this timeline every 5 seconds while open. Service-level checks (`backend/services/acme_diagnostics.py`): * DNS resolution via stdlib socket.gethostbyname_ex through run_in_executor (intentionally avoiding an aiodns runtime dep for v1.5.0). * Port-80 HEAD probe, target locked to the order's domains, success on HTTP 200 OR 404, warns on egress timeout (corp egress policies routinely blackhole outbound 80 — fail-hard would be too noisy). * SSRF guard: probe refuses non-public IPs and surfaces the skip in the diagnostic result; IPv4-mapped IPv6 normalisation closes the `::ffff:169.254.169.254` cloud-metadata vector. * HAProxy routing presence check: matches the order's cluster_ids to a port-80 HTTP frontend. * ACME account validity check against `letsencrypt_accounts`. * Agent presence check (>=1 active agent in target cluster). * Every sub-check wrapped in a wall-clock timeout to bound impact on the API event loop. RBAC: ssl.read for run, ssl.read for events. Per-user 5/min rate limit on both run and rerun, backed by the (user_id, action, created_at DESC) composite index. Frontend (`frontend/src/components/ACMEAutomation.js`): * "Diagnose" button on every order row + the existing "stuck order" warning row. * Modal with two tabs: - Pre-flight Checks (Antd Table with status pills + Re-run buttons + humanized error banner) - Event Log (Antd Timeline with auto-tail polling, scroll- to-bottom, pause-on-hover) * Correlation IDs surfaced in error banners and individual check fail details for backend-log lookup. ------------------------------------------------------------------ HEADLINE FEATURE B — Site Setup Wizard (Issue #14) ------------------------------------------------------------------ A single guided flow that creates a Backend + Servers + HTTP Frontend (and optional HTTPS Frontend) in one atomic transaction. Endpoints (`backend/routers/site_wizard.py`): POST /api/site-wizard/preview — diff-preview the changeset POST /api/site-wizard/create — atomic execute POST /api/site-wizard/reject — clean rollback (including any wizard_staged ACME orders) GET /api/site-wizard/drafts — draft persistence PUT /api/site-wizard/drafts/{id} — save/update DELETE /api/site-wizard/drafts/{id} Feature surface: * One screen captures both backend (mode + servers) AND frontend (http + optional https + SSL mode) inputs. * SSL modes: ACME (new order, HTTP-01 only for v1.5.0), Upload (existing PEM), Existing (link to a stored cert), or None. * ACME-staged path: wizard_staged_until watermark on the `letsencrypt_orders` row defers finalisation until agent confirmation; per-mode reject cleanly cancels and rolls back the staged order. * Live diff preview against the cluster's current generated config (renderer-evolution noise stripped — track-sc<N> dedup, per-server cookie strip, defaults-cookie inheritance, listen-block flattening). * Draft persistence with PEM stripped at save time (private keys never round-trip through the drafts table). * Per-cluster multi-tenancy: drafts and wizard_staged orders are isolated to the creating user's cluster scope. Frontend (`frontend/src/components/SiteWizard.js`): * 4-step Antd Steps flow: Backend → Frontend → SSL → Review. * Render the live diff preview inline before commit. * Antd Form-level validation mirrors backend Pydantic validators (numeric bounds, HAProxy reserved keywords, ALPN consistency, IPv6 scope-id, domain regex, server name dedup). ------------------------------------------------------------------ AUDIT CAMPAIGN — Rounds 1 → 22 (Bulgu #1 → #82) ------------------------------------------------------------------ v1.5.0 includes 22 adversarial review passes. Each round produced its own commit set in the corporate development line; this squash collapses those into the v1.5.0 release artefact. Highlights: Round 1-4 Site Wizard core: dry-run parity, single-line value injection guard, ACL -f pattern-file block, SSL parity, timeout regex, form-state pin. Round 5-7 defaults-cookie inheritance, server-named-cookie guard, fe/be mode mismatch, duplicate server names, health_check_uri + server_address validators. Round 8-10 cookie_name / cookie_options newline-injection guard, dry-run parity (round 9), TCP-mode HTTP-only feature blockers. Round 11 SSL name path traversal + health-check >= 1. Round 12-13 SSL & ACME deep dive (Bulgu #23-#32). Round 14 single-line value injection (Bulgu #33). Round 15-17 ACME multi-tenant UX, numeric bounds, HAProxy reserved keywords, ALPN/TLS consistency, all-backup, multi-domain & multi-user enterprise edges, drain/HSTS/post-completion (Bulgu #34-#53). Round 18-21 concurrency, agent state, TCP-mode HTTP-only, list size caps, IPv6 scope-id, preview account validation, TCP backend + balance uri reject (Bulgu #54-#61). Round 22 FE error visibility + 3x stale-data lockouts, referential integrity + cascade safety, authentication & authorization, multi-cluster isolation, apply_pending_changes concurrency, script injection + bulk import multi-tenancy, prefix-stripped signature comparison (Bulgu #62-#82). ------------------------------------------------------------------ NO CORPORATE-SPECIFIC ARTIFACTS ------------------------------------------------------------------ This squash deliberately sanitises corporate hostnames, container registry references, and TLS secret names into generic placeholders (`your-registry.example.com/your-org`, `haproxy-openmanager*.example.com`, `wildcard-tls`, `taylanbakircioglu/haproxy-openmanager-*`) so the public artefact contains no internal infrastructure detail. Pilot / development history that retained those values stays in the corporate fork and is NOT part of this commit.
129 lines
4.0 KiB
Python
129 lines
4.0 KiB
Python
"""
|
|
letsencrypt_service: thin extraction layer for ACME order creation paths.
|
|
|
|
Two flavors needed by v1.5.0 wizard (Section 4.4):
|
|
|
|
1) create_order_staged(conn, ...) — INSERTs a letsencrypt_orders row with
|
|
status='wizard_staged', NO LE API call yet. The background task
|
|
complete_pending_acme_orders will later detect agent confirmation and
|
|
transition this to a real ACME order via create_order_via_api.
|
|
|
|
2) create_order_via_api(conn, ...) — thin wrapper around the existing
|
|
acme_service.AcmeService.create_order() routine, used both by the
|
|
/api/letsencrypt/orders endpoint and the staged-promotion flow. Caller
|
|
may pass `expected_account_id` so we can update existing letsencrypt_orders
|
|
row in place (UPDATE order_url + status='pending') instead of inserting a
|
|
new one.
|
|
|
|
Notes:
|
|
- Staged orders have order_url IS NULL — the wizard's create flow never
|
|
contacts the CA, so failure modes here are purely DB-bound. R58/M37
|
|
(`order_url IS NULL` idempotency check) lives in main.py background task.
|
|
- post_completion_actions JSONB carries the *deferred* HTTPS frontend create
|
|
request that fires once the certificate is downloaded — see
|
|
letsencrypt.py _complete_certificate.
|
|
"""
|
|
|
|
import json
|
|
import logging
|
|
from typing import Any, List, Optional
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
async def create_order_staged(
|
|
conn,
|
|
*,
|
|
account_id: int,
|
|
domains: List[str],
|
|
cluster_ids: List[int],
|
|
post_completion_actions: List[dict],
|
|
pending_apply_version_name: Optional[str] = None,
|
|
created_by: Optional[int] = None,
|
|
) -> int:
|
|
"""Insert a wizard-staged ACME order row with status='wizard_staged'.
|
|
|
|
No LE API call. Returns new order id.
|
|
|
|
The background task complete_pending_acme_orders will later detect agent
|
|
confirmation (via pending_apply_version_name match) and call
|
|
create_order_via_api to promote to status='pending'.
|
|
"""
|
|
order_id = await conn.fetchval(
|
|
"""
|
|
INSERT INTO letsencrypt_orders (
|
|
account_id, order_url, status, domains, finalize_url, expires_at,
|
|
cluster_ids, post_completion_actions, pending_apply_version_name,
|
|
created_by, wizard_staged_until
|
|
) VALUES (
|
|
$1, NULL, 'wizard_staged', $2::jsonb, '', NULL,
|
|
$3::jsonb, $4::jsonb, $5,
|
|
$6, NOW() + INTERVAL '24 hours'
|
|
)
|
|
RETURNING id
|
|
""",
|
|
account_id,
|
|
json.dumps(domains),
|
|
json.dumps(cluster_ids),
|
|
json.dumps(post_completion_actions or []),
|
|
pending_apply_version_name,
|
|
created_by,
|
|
)
|
|
logger.info(
|
|
"ACME WIZARD: staged order id=%s domains=%s pending_apply_version_name=%s",
|
|
order_id,
|
|
domains,
|
|
pending_apply_version_name,
|
|
)
|
|
return order_id
|
|
|
|
|
|
async def promote_staged_order_to_pending(
|
|
conn,
|
|
*,
|
|
order_id: int,
|
|
order_url: str,
|
|
finalize_url: str,
|
|
status: str = "pending",
|
|
expires_at: Any = None,
|
|
) -> None:
|
|
"""In-place update of a wizard_staged order row after the LE newOrder call
|
|
has succeeded. status -> 'pending' (or whatever LE returned).
|
|
"""
|
|
await conn.execute(
|
|
"""
|
|
UPDATE letsencrypt_orders
|
|
SET order_url = $2,
|
|
finalize_url = $3,
|
|
status = $4,
|
|
expires_at = $5,
|
|
updated_at = NOW()
|
|
WHERE id = $1
|
|
""",
|
|
order_id,
|
|
order_url,
|
|
finalize_url,
|
|
status,
|
|
expires_at,
|
|
)
|
|
|
|
|
|
async def create_order_via_api(
|
|
acme_service_instance,
|
|
*,
|
|
account_id: int,
|
|
domains: List[str],
|
|
cluster_ids: Optional[List[int]] = None,
|
|
) -> dict:
|
|
"""Thin wrapper around AcmeService.create_order() — used by both the public
|
|
POST /api/letsencrypt/orders endpoint and the staged promotion path.
|
|
|
|
Returns the same dict the upstream method returns (id, order_url,
|
|
status, domains, ...).
|
|
"""
|
|
return await acme_service_instance.create_order(
|
|
account_id=account_id,
|
|
domains=domains,
|
|
cluster_ids=cluster_ids,
|
|
)
|