Compare commits

..

98 Commits

Author SHA1 Message Date
Oliver Kieselbach a1433141ce bump pointer: internal (D-435 follow-up: counting needs certainty, plan step B1 taken back)
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 19:19:11 +01:00
Oliver Kieselbach a7e76f0584 Console detection: a running process that cannot be read is reported, and every console warning is uploaded at once
The probe answered "gone" whenever it had no row, also when the query
itself failed. A console that still ran was then counted as script
activity instead of being reported. A start is now counted only on
certainty: the process list no longer has the id, it has another image
under it, or a fact that was read contradicts the start trace. A failed
or empty query, or a fact that could not be read, is reported at low
confidence, as before the counting was introduced.

The immediate upload is back for every oobe_console_spawned. The
confidence follows the command line, which whoever opens the console
chooses, so it labels the warning and never delays it. With short-lived
starts counted there is no burst left that the limit would have spared.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 19:18:38 +01:00
Oliver Kieselbach 3829b6ce92 bump pointer: internal (D-435 console detection: decision, plan)
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 18:57:02 +01:00
Oliver Kieselbach dabd0d5b7e Console detection: short-lived cmd.exe are counted per window instead of reported one by one
The watcher learns of a process start about a second late, because WMI
delivers the start trace in batches. A scripted cmd /c has exited by
then, and its unreadable command line was reported as a low-confidence
console. A script that starts many of them produced one Warning with an
immediate upload each.

A start whose process is gone, or whose id now belongs to another process
(other image name, session 0, other parent), is now counted. The host
reports the count as one Info console_script_activity per 60 s window,
with the owner SIDs and the parent processes by image name, at most 20
windows per agent run and the rest when it stops. The type does not
count as activity, neither for the agent's idle and stall clocks nor for
the backend's stall heal.

oobe_console_spawned stays for a console that is still running when
probed. It carries parentProcessName and is uploaded immediately only at
high confidence.

Fixed in the same code: a reused process id could be reported with the
command line of another program; the owner of a console found at agent
start was never read, because the query lacked the key property; a later
console that was given an id seen before was dropped; the WMI
subscription was cancelled on the stop thread.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 18:56:29 +01:00
Oliver Kieselbach 68dab1e154 Office watcher: a traced process id is tracked only while it still carries the worker's name
WMI delivers the process start trace with a delay. By then the id can
belong to another process. The watcher took whatever ran under the id as
an Office worker, and a foreign process held the install window open
until it exited.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 18:56:16 +01:00
Oliver Kieselbach a1590579f9 Agent: the image path of another process comes from one shared helper
ImeProcessIdentity carried a private wrapper around
QueryFullProcessImageName. It moves unchanged to
Monitoring/Interop/ProcessImagePath, so a second caller can read a
process's image name without a copy of the P/Invoke.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 18:56:15 +01:00
Oliver Kieselbach a558ca5510 bump pointer: internal, .claude/commands (D-434 released: backend 1.5.1330, agent 2.0.1503, web and MCP 1.6.596 on e01e7ab)
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 17:39:32 +01:00
Oliver Kieselbach e01e7abc2b bump pointer: internal, .claude/commands (D-434 registration 410: decision, concept doc, plan, backlog, health markers)
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 17:06:11 +01:00
Oliver Kieselbach 512b145484 Backend: the comment on register-session's 410 sits on its method
The summary of the 410 response stood above ClampStartedAt and promised
that the agent treats registration and telemetry alike. It now sits on
WriteSessionLockedAsync and says what the agent does.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 17:05:40 +01:00
Oliver Kieselbach 8ece30631a Agent: a registration answered with 410 ends monitoring; a WhiteGlove Part 2 start registers a new session
register-session answers 410 while a deleted session's tombstone is fresh.
The agent treated that like a network failure: six attempts, exit 7,
everything kept for the next boot. A WhiteGlove resume never left that
loop, because the 48-hour break is skipped for it.

A 410 that echoes the request's correlation id is now its own signal. The
start sends one report (RegistrationRejectedSessionGone) and ends
monitoring with a forced cleanup, as the telemetry path already does on
410. A WhiteGlove Part 2 start rotates its session id and registers again
instead, so the user phase is observed; agent_started names the reason in
sessionRotationReason. A 410 without the echo stays a retried failure.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 17:05:39 +01:00
Oliver Kieselbach c9078d00b6 bump pointer: internal, .claude/commands (D-433 released: backend 1.5.1329, web and MCP 1.6.595 on 1ff68dc)
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 15:30:25 +01:00
Oliver Kieselbach 1ff68dc0af bump pointer: internal, .claude/commands (D-433 script-name lookups: decision, plan, backlog, health marker)
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 15:08:01 +01:00
Oliver Kieselbach 7c8204357b Web: the session page starts fresh for every session
A link from one session to another only changes ?id=, so the route stays
mounted, and the append-only event list kept the previous session's
events: both sessions ended up in one timeline. The page content is now
keyed by the session id.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 15:07:48 +01:00
Oliver Kieselbach dfcf7ad8ba Web: one script-name lookup per session view, one follow-up after a time limit
The session page loads events page by page, and the hook fired a lookup
for every page that added a script. It now waits for the complete event
walk and asks once, with every script of the session.

When the backend reports that a time limit cut the lookup short, the hook
asks once more after 5 s. The follow-up never takes away a name the first
answer had, and a session switch drops a pending one.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 15:07:35 +01:00
Oliver Kieselbach 54d4c0bd4c Script names: an incomplete lookup leaves a trace and reports its time limit
A lookup that ends without an answer for every ref, because one of the
resolver's time limits fired or Graph or the token context failed, writes
one Warning with the reasons. These paths logged at Information or not at
all, and nothing collects worker logs below Warning.

The response carries timedOut when a time limit cut the lookup short, the
request may carry retry, and the request row gets ScriptNameLookup
(timedOut / retry / retryTimedOut), so a follow-up lookup can be told from
a first one.

Also:
- The token cap is 3 s instead of 1.5 s: the first mint on a cold instance
  often needs longer, and a lookup without a token returns no name at all.
- A not-found id is kept as long as a name (7 days) instead of being asked
  again after every cleanup run.
- A list pull whose budget ends between two pages is no longer stored as
  the tenant's complete list.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 15:07:10 +01:00
Oliver Kieselbach 11bc0ec2ab bump pointer: internal, .claude/commands (D-432 released: backend 1.5.1328, web and MCP on 7e9b0ce)
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 13:06:27 +01:00
Oliver Kieselbach 7e9b0cea54 bump pointer: internal, .claude/commands (D-432 configuration read after a write: decision, concept doc, plan, backlog, health markers)
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 12:29:14 +01:00
Oliver Kieselbach c115cb354e MCP: get_tenant_config reads the stored configuration
The tool sends X-Tenant-Config: stored, so the read that checks an
update_tenant_config does not come from a backend instance's cached copy.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 12:28:58 +01:00
Oliver Kieselbach 9cfe3fb74d Backend: a saved tenant configuration reaches the next request that needs it
The tenant configuration stays cached per instance for five minutes, and a
write clears only the cache of the instance that served it. Two readers no
longer act on a copy another instance's write has outdated:

- A signed-in request carrying X-Tenant-Config: stored (the portal sends it for
  a few minutes after a configuration write, the MCP on get_tenant_config)
  reads the stored row of the acting tenant, and of the target tenant once the
  cross-tenant check has passed, into the instance cache before authorization
  and the function read it. A storage failure keeps the cached copy. The
  header grants nothing: it costs the caller's own request one read.
- The agent gate confirms a refusal the configuration decides (tenant
  suspended, no validation switched on, manufacturer or model not allowed,
  bootstrap not enabled) against the stored row first, at most once per 15 s
  per tenant and instance, and runs the device chain once more when the stored
  row switches on a validation it had not asked. A device enrolled right after
  an admin allowed it is no longer turned away for up to five minutes.
  Requests that pass read nothing extra. The bootstrap routes check their
  feature switch through one helper that confirms the same way.

GET config/{tenantId} and the feature flags answer a storage failure with an
error instead of a synthesized default configuration.

Request-row dimensions: ConfigRefresh (stored row read on the caller's hint),
ConfigConfirm (averted / confirmed / rerun on agent requests) and
ConfigPatchUnchanged on the field patch (sent fields the row already held).

A guard test keeps every function that writes the tenant row on a route the
portal recognizes as a configuration write.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 12:28:55 +01:00
Oliver Kieselbach 892ff4c1e1 Portal: saved settings show at once, a card saves only its edits, setup guide replay
After a successful write of the tenant configuration the browser asks for the
stored configuration on its API calls for six minutes (X-Tenant-Config: stored,
lib/storedConfigHint.ts). The backend caches a configuration per instance, so a
page loaded right after a save, for example on the way back from the admin
consent, could show the values from before it. The mark lives in localStorage:
it survives the redirect and holds in other tabs. The header leaves the fetch
cache mode alone, and a backend that does not know it ignores it.

A settings card sends exactly the fields that were edited. The first save of a
card used to send every field the configuration had never stored, with the
form's default; a page showing an older configuration could write such a
default over a value saved elsewhere. What a card sends and what counts as
unsaved is one computation now (sectionSavePayload). A switch that saves on
change always sends the value that was clicked. The form's defaults are pinned
against the model's and the agent's defaults in the generated manifest.

Setup guide: "Go through the steps again" on the completion screen starts it at
step 1, and ?setup-guide=settings|hardware|validation|deploy opens it at that
step for tenant admins. It works on the tenant's current configuration and
resets nothing. The dialog shows its own writes ("Back" after "Apply" shows
"Already on"), recording a step drops the cached feature flags, the hardware
step asks for at least one manufacturer instead of claiming an empty list
rejects every device, and "The approval was not completed" needs a loaded
configuration.

The duplicate baseline loses one entry.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-11 12:28:44 +01:00
Oliver Kieselbach 2cb181734a bump pointer: internal (D-431 released with agent 2.0.1502)
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-10 20:33:53 +01:00
Oliver Kieselbach 7055a6f0fc bump pointer: internal, .claude/commands (D-431 bounded collector stop: decision, plan, backlog, health marker)
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-10 20:11:26 +01:00
Oliver Kieselbach 587de860dd Agent: termination no longer waits on a collector
Stopping the collector hosts is bounded per host (30 s), and so is their final
dispose. A host that does not return is left behind and reported once as
agent_trace (decision=collector_host_stop_timeout); the remaining hosts are
still stopped, and the diagnostics upload, the completion marker and the
cleanup follow as before. Until now a single host that hung in Stop kept the
agent process alive until the next reboot, without upload and without cleanup.

Removes the lock cycles that could cause such a hang. The Office registry,
binary and process watchers and their host, the IME process watcher and the
RealmJoin watcher's Stop raised events or disposed a child while holding a
lock the other thread needed. A watcher now raises its events with its lock
released, and an owner never disposes a child under a lock the child's
callbacks take.

Office process watcher: the WMI subscription is set up and cancelled off the
caller's thread (cancelling it could delay the stop by tens of seconds), and a
worker that had already exited when the watcher subscribed now closes the
install window instead of keeping the Delivery Optimization collector polling.
The Office registry watch is no longer tied to the thread that armed it.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-10 20:10:47 +01:00
Oliver Kieselbach 409794c037 bump pointer: internal (IME 1.109.102.0 diff note, B-acx update)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-10 17:47:54 +01:00
Oliver Kieselbach 337b3b012a bump pointer: internal (promo videos as one project, Ignite 2026 social plan, D-429 marketing pages, D-430 setup guide manufacturers)
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-10 11:42:27 +01:00
Oliver Kieselbach c2ae5ddd83 Merge pull request #215 from okieselbach/dependabot/npm_and_yarn/src/Web/autopilot-monitor-web/web-30eaf40955
Bump the web group in /src/Web/autopilot-monitor-web with 4 updates
2026-11-10 11:35:40 +01:00
Oliver Kieselbach 60baf5317c Merge pull request #214 from okieselbach/dependabot/npm_and_yarn/src/McpServer/autopilot-monitor-mcp/mcp-3237aae3e3
Bump the mcp group in /src/McpServer/autopilot-monitor-mcp with 2 updates
2026-11-10 11:34:51 +01:00
Oliver Kieselbach a5d5a37dc1 Setup guide: Samsung instead of Getac among the one-click manufacturers
The hardware step offers well-known manufacturers outside the default
list; the comment no longer claims an order by rejected devices.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-10 11:07:09 +01:00
Oliver Kieselbach d4b56c417d Notifications: Teams channel hint names the current Workflows path
The hint for the Teams (Workflow Webhook) provider now points to
More options (...) next to the channel -> Workflows -> "Send webhook alerts
from anyone to Teams" instead of the old Manage channel path and template.
It also says that the variants limited to specific people or the org reject
the alerts, because the backend posts without an Entra sign-in.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-10 10:34:45 +01:00
Oliver Kieselbach a5bbdf9f80 Marketing pages: setup in four short steps, one script, a few minutes
/get-started tells the flow in four steps with one sentence each: sign in,
follow the setup guide, add one script in Intune, watch live. The separate
consent step, the "same day" line and the statements about the tenant that
no longer match the product are gone.

The landing page's "How it works" and story say "one script in Intune"
instead of "bootstrapper"; About and its FAQ name the loader script, the
one customers assign. The setup checklist says "A few minutes, Intune
included".

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-10 10:18:07 +01:00
dependabot[bot] 389d4f27dc Bump the web group in /src/Web/autopilot-monitor-web with 4 updates
Bumps the web group in /src/Web/autopilot-monitor-web with 4 updates: [next](https://github.com/vercel/next.js), [@next/bundle-analyzer](https://github.com/vercel/next.js/tree/HEAD/packages/next-bundle-analyzer), [eslint-config-next](https://github.com/vercel/next.js/tree/HEAD/packages/eslint-config-next) and [knip](https://github.com/webpro-nl/knip/tree/HEAD/packages/knip).


Updates `next` from 16.4.3 to 16.4.4
- [Release notes](https://github.com/vercel/next.js/releases)
- [Commits](https://github.com/vercel/next.js/compare/v16.4.3...v16.4.4)

Updates `@next/bundle-analyzer` from 16.4.3 to 16.4.4
- [Release notes](https://github.com/vercel/next.js/releases)
- [Commits](https://github.com/vercel/next.js/commits/v16.4.4/packages/next-bundle-analyzer)

Updates `eslint-config-next` from 16.4.3 to 16.4.4
- [Release notes](https://github.com/vercel/next.js/releases)
- [Commits](https://github.com/vercel/next.js/commits/v16.4.4/packages/eslint-config-next)

Updates `knip` from 6.44.0 to 6.44.1
- [Release notes](https://github.com/webpro-nl/knip/releases)
- [Commits](https://github.com/webpro-nl/knip/commits/knip@6.44.1/packages/knip)

---
updated-dependencies:
- dependency-name: next
  dependency-version: 16.4.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: web
- dependency-name: "@next/bundle-analyzer"
  dependency-version: 16.4.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: web
- dependency-name: eslint-config-next
  dependency-version: 16.4.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: web
- dependency-name: knip
  dependency-version: 6.44.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: web
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-11-10 01:06:19 +00:00
dependabot[bot] ce5f22bd19 Bump the mcp group
Bumps the mcp group in /src/McpServer/autopilot-monitor-mcp with 2 updates: [jose](https://github.com/panva/jose) and [knip](https://github.com/webpro-nl/knip/tree/HEAD/packages/knip).


Updates `jose` from 6.2.14 to 6.2.15
- [Release notes](https://github.com/panva/jose/releases)
- [Changelog](https://github.com/panva/jose/blob/main/CHANGELOG.md)
- [Commits](https://github.com/panva/jose/compare/v6.2.14...v6.2.15)

Updates `knip` from 6.44.0 to 6.44.1
- [Release notes](https://github.com/webpro-nl/knip/releases)
- [Commits](https://github.com/webpro-nl/knip/commits/knip@6.44.1/packages/knip)

---
updated-dependencies:
- dependency-name: jose
  dependency-version: 6.2.15
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: mcp
- dependency-name: knip
  dependency-version: 6.44.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: mcp
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-11-10 01:05:56 +00:00
Oliver Kieselbach 85fadc8ac4 bump pointer: internal (D-428 local admin allowlist roles released and verified live)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 20:57:43 +01:00
Oliver Kieselbach 7633c02a1c bump pointers: internal, .claude/commands (D-428 local admin allowlist roles: plan, decision, concept doc, backlog; import_session scrub)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 20:30:01 +01:00
Oliver Kieselbach bd66ad7097 Local Admin Analyzer: allowed accounts carry a role; WsiAccount allowed as standard user
An allowed-list entry is now `name` (any role, meaning unchanged) or
`name|user`: the account is allowed only while it is not a member of the
local Administrators group. Of all entries matching an account, a
standard-user entry wins over one that allows more, so no entry lifts a
built-in restriction. '|' cannot occur in a Windows account name; an older
agent matches such an entry against no account and keeps flagging it.

Built-ins move to Shared (LocalAdminAllowList), one source for agent,
backend and portal: the built-in Administrator (RID 500) in any role;
Guest, DefaultAccount, WDAGUtilityAccount (by RID, any language),
kioskUser0 and the Web sign-in account WsiAccount only as standard users,
like any other account that only carries one of these names;
defaultuser0-2 in any role; Public, Default, Default User and All Users as
profile folders only. The four built-in accounts are decided by RID alone.

Gaps closed on the way:
- Guest-type accounts and accounts named like profile folders were
  allowed as administrators.
- A logged-in user at shutdown allowed a local administrator of that name
  when the WMI inventory failed; the dynamic entry now allows only the
  profile folder.
- Administrators missing from the WMI inventory scored 40 with an empty
  rule summary; they now count as unexpected accounts too (80).
- Glob matching was culture-sensitive (i/I under a Turkish culture).

Event: checks.role_violations, account_details[].rid, allowed_accounts in
canonical form ("Guest|user"). The backend validates entries that are new
against the stored list (grammar, length, forbidden characters, SID, too
broad, duplicate pattern); the too-broad check existed only in the portal.
The portal renders the built-ins from the shared manifest (the hand copy
lacked kioskUser0), offers "Standard user only" per entry and marks
entries the built-ins already cover. ANALYZE-ID-002 1.5.0 explains the
role rule and names the card correctly. Shared grammar cases:
tests/fixtures/local-admin-allow-list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 20:28:51 +01:00
Oliver Kieselbach be13d8f5ef bump pointer: internal (onboarding setup guide released and verified live)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 19:58:23 +01:00
Oliver Kieselbach 8296fa7291 bump pointer: internal (onboarding setup guide: D-425..D-427, concept docs, backlog), .claude/commands (setup guide telemetry in growth, ux-insights, platform-health)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 19:35:29 +01:00
Oliver Kieselbach 4faca8692b Web: setup checklist shows turned-away devices once validation is on
Agents can connect as soon as a device validation is on, so the list of
devices the backend turned away and the "no device after an hour" checks
now show from then on, not only once the recommended steps are done.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 19:26:37 +01:00
Oliver Kieselbach ba715d5aa7 Web: setup tour never turns on Autopilot validation for device preparation
With "I use device preparation" selected, the tour's own "Detect existing
access" checked access for Autopilot Device Validation and turned that on.
The bubble now points to the access check under each of the two
device-preparation options in the highlighted block. The approve button
only exists for Windows Autopilot, so it starts that consent directly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 19:22:52 +01:00
Oliver Kieselbach ed73dc3a87 Web: reported hardware values never become wildcard entries
Manufacturer and model strings from device reports reach the backend
unauthenticated, and the whitelist matcher has no escape for '*' and '?'.
reportedValueEntry turns such a value into one literal entry, or into
nothing when it holds a wildcard (no real SMBIOS value does). The setup
checklist's one-click accept and the hardware rejection insights in
Settings only offer an addition for that entry and name the pattern they
add. The settings insights had the same gap before the guide.

Also drops the docs path of the removed welcome card.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 19:20:10 +01:00
Oliver Kieselbach 1e88d1db4b Web: setup guide for new tenants
A tenant without enrollments gets a "Get started" checklist on the dashboard
instead of the welcome card, plus a sidebar entry while it is open. Four
steps: recommended settings (timezone, diagnostics package with hosted
storage and upload mode "on failure", software inventory), hardware
whitelist, device validation, agent deployment. Done states come from the
tenant's flags; local marks bridge the backend's configuration cache.

- Guide dialog mounted once in the root layout, opened from the card, the
  sidebar, the help menu and the empty-dashboard note.
- Device validation runs as a spotlight tour on the real settings page; the
  tour sits in sessionStorage and survives the consent redirect. Plan B
  copies the approval link for a Global Administrator.
- "Show me where" spotlights the three settings on their pages.
- While waiting for the first enrollment the card lists devices the backend
  turned away (hardware whitelist, not registered) with a one-click accept.
- The first session to arrive replaces the card with a success card.
- The red "no device validation" banner only shows while the checklist
  does not, and waits for the checklist's flags so it never flashes.
- Writes go through the field PATCH and POST config/{tenantId}/setup-guide;
  an open settings page receives guide writes through a patch signal.
- Company name in the navbar on wide screens when the tenant set one.
- Hardware whitelist helpers move to lib/; a typed "VMware, Inc." stays
  one entry.
- Privacy page: hosted diagnostics upload wording made general.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 19:12:06 +01:00
Oliver Kieselbach f3778fbad6 auth/me: company name only for callers with a tenant role
The navbar label went to every signed-in user of the tenant, including members
without a role, who see only the Progress Portal and whom the config GET
refuses. It now follows the config GET: a tenant role or a Global Admin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 18:22:45 +01:00
Oliver Kieselbach 1a85a75af1 Setup guide state: markers on the tenant, checklist flags, company name in auth/me
The setup guide has to know which of its steps a tenant finished and whether an
admin hid it, and the navbar shows the tenant's company name.

- TenantConfiguration: SetupGuideSettingsReviewedAt, SetupGuideHardwareReviewedAt,
  SetupGuideDismissedAt/By. System-owned: denied in the field patch, kept on
  revert, not counted as a backup-worthy change.
- POST config/{tenantId}/setup-guide (tenant admin or global admin, refused in
  view-as) records a finished step, hides the guide for the tenant or brings it
  back, with server time, the caller's UPN and an audit entry.
- Feature flags: setupGuideSettingsDone and setupGuideHardwareDone (finished in the
  guide, or already true in the configuration), setupGuideDismissed, and
  hasEnrollmentSessions from the tenant's enrollment counter (strict read, omitted
  when unknown, remembered per instance once true).
- auth/me: companyName when one is set.
- PlanManagement's update-outcome responses move to a shared helper.
- The software inventory analyzer's null default is documented as off, which is
  how the agent config and the flags already read it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 18:16:26 +01:00
Oliver Kieselbach 5f13c71f1d bump pointer: internal (D-424 start push urgency and credential URL redaction released and verified live)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 18:04:40 +01:00
Oliver Kieselbach 041803e55c Backend: hardware whitelist rejections reach the tenant
The agent reports every backend 403 as DeviceNotRegistered, but the hardware
whitelist is checked before the registration lookup. A device outside the whitelist
was stored as not registered: the bell, the hardware-rejection webhook and the
rejected-hardware list never saw it, and the not-registered list showed hardware
rejections instead.

- ReportDistress resolves the type on the server: a DeviceNotRegistered 403 whose
  manufacturer or model fails the tenant's whitelist becomes HardwareNotAllowed,
  unless the validator refuses or admits the request before the hardware check
  (suspended tenant, no validation, bootstrap auth). The agent's own claim stays in
  the log and in the AgentDistressReport event as ReportedErrorType.
- The per-tenant distress lists read one type on the server instead of filtering the
  newest 200 rows of all types.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 17:56:42 +01:00
Oliver Kieselbach eff89fd09f Backend: paged table reads never ask Azure for more than 1000 rows
A fan-out reader asks each partition for pageSize + 1 rows. At pageSize 1000 that
became $top=1001, which Azure Tables refuses with 400; the reader caught the error
and returned an empty page, so the global audit log and the cross-category ops
events answered pageSize=1000 with success and zero rows.

- AzureTablesPaginator.ServerPageSize caps a computed maxPerPage at 1000; the
  readers keep enumerating server pages until they have their rows.
- Every computed maxPerPage goes through it, including the per-tenant distress read
  and three session-event reads that had no cap.
- The paged audit-log and ops-event readers no longer turn a storage error into an
  empty page; the function answers 500 instead.
- TableServerPageSizeGuardTests: ratchet over every maxPerPage argument.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 17:56:32 +01:00
Oliver Kieselbach 0cc35d2bae bump pointers: internal, .claude/commands (D-424 start push urgency, credential URL redaction: plan, decision, docs, health marker)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 17:33:24 +01:00
Oliver Kieselbach 27cb286118 Push: start alerts go out at high urgency; webhook URLs stay out of dependency telemetry (D-424)
A start alert is Info and was sent with Urgency low. Push services hold anything below
high while a phone dozes, and the session's verdict shares the start's Topic, so the
verdict could replace a start that was still waiting. Start alerts (enrollment started,
pre-provisioning resumed) now go out at high urgency; every other alert keeps the urgency
of its severity.

The webhook client's dependency rows carried the full webhook URL, which is a credential
(token in the path, signature in the query). CredentialUrlRedactionProcessor replaces the
push-only processor: the webhook and push HttpClients carry its MarkingHandler, which marks
each request's async flow, and every dependency row tracked inside a marked flow keeps
scheme + host and the method only, whatever the host. A test drives the real dependency
collector over a loopback socket to prove the mark reaches the processor.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 17:33:03 +01:00
Oliver Kieselbach c88e5411a8 bump pointer: internal (D-423 settings unsaved changes released and verified live)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 15:22:22 +01:00
Oliver Kieselbach 5eba39f658 bump pointers: internal, .claude/commands (D-423 settings unsaved changes: plan, decision, docs, health marker)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 15:02:06 +01:00
Oliver Kieselbach 5f95648c73 Settings: unsaved edits are marked, Save stays in reach, leaving asks first (D-423)
A settings card with unsaved edits says so next to Save, and its Save bar sticks to
the bottom of the viewport while the card reaches below it; without edits Save is
greyed out. The sidebar marks every page with unsaved edits, also on a collapsed
group, an icon or a collapsed category.

Moving between settings pages keeps the edits. Leaving the settings area asks first
(Stay / Leave without saving): links of any kind, the global search, a notification,
sign-out and the admin-consent redirect. Closing or reloading the tab gets the
browser's prompt, never while a sign-in redirect is in flight. Discarding stays tied
to leaving; there is still no discard button next to Save.

The edited values live in one SettingsForm with two pure projections (formFromConfig,
configFromForm); loading, the save payload and the unsaved check share them, so model
defaults, trimming and the synthesized legacy channel never count as edits. The
section map names each section's sidebar page and marks the sections that save on
change. The scroll-to-top and feedback buttons rise above a pinned bar.
settings_unsaved_prompt reports the prompt's outcome.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 15:00:37 +01:00
Oliver Kieselbach e4d527b6d5 bump pointer: internal (push device rename released and verified live)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 13:41:53 +01:00
Oliver Kieselbach 258d7cd5f4 Push devices: the platform card manages its own devices again
The home-tenant view (D-334) marks a platform device as managed elsewhere;
the check compared against "platform" instead of the panel's own scope, so on
the platform card every device lost Send test, Remove and now Rename.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 13:36:17 +01:00
Oliver Kieselbach 668ae14657 bump pointers: internal, .claude/commands (push device rename: plan, backlog, health marker)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 13:24:53 +01:00
Oliver Kieselbach 16bd82b148 Push devices: rename at confirm and in the list, panel always visible, desktop permission hint
- Backend: confirm takes an optional { label } (an empty body keeps the name
  the device sent); new PATCH push/devices/{id} and PATCH global/push/devices/{id}
  rename a device under the remove rule (owner or scope admin), 400 for a blank
  name, audit UPDATE with previousLabel, PushPairing action "renamed".
  Both routes in the policy catalog; push route pin 22 -> 24.
- Portal: the pairing dialog has a Device name field prefilled with the sent
  name and pauses its poll while confirming; Push devices rows get Rename
  (Enter saves, Esc cancels). The panel shows without a Push channel and says
  which channel to add (Operator wording when the channel list is read-only);
  showPushDevicesPanel gives way to hasScopeDevice.
- Receiver: the pair page tells computer users that the browser may ask only
  through an address-bar icon; opening the app stores a name changed in the
  portal for offline display.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-09 13:24:52 +01:00
Oliver Kieselbach 225d0feca9 Merge pull request #213 from okieselbach/fix/view-as-bar-layout
View as: keep the navbar and sidebar clear of the view-as bar
2026-11-06 18:47:05 +01:00
Oliver Kieselbach 6b06edb222 View as: keep the navbar and sidebar clear of the view-as bar
The bar sat in the normal flow above the sticky navbar and scrolled away,
while the desktop sidebar is fixed at the navbar's height. In a view-as tab
the navbar therefore covered the top of the sidebar (its first entry) by up
to the bar's height, depending on the scroll position.

The bar now sticks above the navbar at a fixed height: one line, a long
tenant name truncates. globals.css derives --view-as-offset from its
presence (:root:has([data-view-as-bar])): the bar's height while it is
shown, 0 otherwise. Everything positioned against the top of the viewport
adds it: the navbar's sticky top, the desktop sidebar, the mobile
notification panel, the sticky severity card, the push app's header, and
anchor scrolling (scroll-padding-top on the root). The sidebar's section
jump and scroll-spy margin add the bar's measured height
(viewAsBarHeight in lib/viewAs.ts). Ordinary tabs keep offset 0, so their
layout is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 18:37:49 +01:00
Oliver Kieselbach 12b29c2e08 bump pointer: internal (D-422 tenant activity released and verified live)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 18:32:11 +01:00
Oliver Kieselbach 5a37721d24 bump pointers: internal, .claude/commands (D-422 tenant activity: plan, decision, docs, health marker)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 18:12:29 +01:00
Oliver Kieselbach 884f8495b2 Tenant Activity: per-tenant usage for platform readers, MCP get_tenant_activity (D-422)
New route GET global/metrics/tenant-activity (GlobalReadOrAdmin, no tenant
scope): every signed-up tenant's enrollments, successes and active days over
the last N full UTC days (1-90) against the N days before, a lifecycle stage
(never enrolled, dormant, new, declining, active, quiet), the lifetime
counters, the last counter move and its portal users, plus totals and a daily
series. Built from the daily UsageMetrics rows, the per-tenant counters and
the UserActivity sign-in history; the sign-in read is the only fail-soft input.

- TenantLifecycleFacts: one set of per-tenant facts (enrolled, last active
  day, first day with sessions, the 30-day dormant check) for the growth
  figures and the new route. The window ends at the last aggregated day, so
  shortly after midnight UTC a tenant active only yesterday no longer counts
  as dormant in the growth figures either.
- Shared: GetTenantActivityResponse DTOs, TenantActivityStages and
  TenantEditionNames as manifest vocabularies, PortalVisit; the daily rows
  carry SessionsSucceeded and SessionsFailed. Parity facts, regenerated
  manifest and wire types.
- Web: GA -> Metrics -> Tenant Activity (above MCP Usage) with tiles,
  enrollments per day, a sortable ranking and the lifecycle lists. The
  generic list parts leave the MCP usage folder (lib/useListState, lib/format,
  sections/listParts with TenantNameCell); formatDayKey reads both day-key
  forms and replaces the Customers page's copy; PlanEdition derives from the
  backend's edition names.
- MCP: get_tenant_activity for Global Admins and Global Readers with the views
  summary, ranking and lifecycle; slim rows with fixed caps keep every answer
  below the tool limit. Catalog ceilings raised by the measured size.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 18:12:06 +01:00
Oliver Kieselbach cc674b26ad bump pointer: internal, .claude/commands (D-421 released and verified live; platform-health view-as marker query fixed)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 16:55:39 +01:00
Oliver Kieselbach 7139374681 bump pointer: internal, .claude/commands (D-421 view as tenant: decision, concept doc, plan; marker rows and KQL hints)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 16:41:24 +01:00
Oliver Kieselbach e6d92c6005 Merge pull request #212 from okieselbach/feat/view-as-tenant
View as tenant: a Global Admin reads one tenant's portal as its member, read-only
2026-11-06 16:38:58 +01:00
Oliver Kieselbach 46880b58e7 Portal: view a tenant as its member (Global Admin, read-only)
?viewAs=<tenant id> (optional &viewAsRole=Operator|Viewer) arms a view-as
tab. The selection lives in sessionStorage, outlives the sign-in redirect
of a new tab, and every API call carries the view-as headers, the SignalR
negotiate included. A purple bar names the viewed tenant and leaves the
mode; Tenant Management gets a "View as" link per tenant.

The tab stays isolated from the caller's other tabs and from the viewed
tenant's numbers:
- the dashboard seed is skipped, because a seed is matched by URL alone
- API calls bypass the browser's shared HTTP cache
- the Global-Admin view is forced off without writing localStorage, so
  other tabs keep it
- web telemetry counts the tab at the Global Admin's home tenant and names
  the viewed one as viewAsTenantId
- a refused view-as reloads the tab as an ordinary one and says why once

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 15:39:34 +01:00
Oliver Kieselbach ee96ff2d23 Backend: read-only "view as tenant" for Global Admins
A Global Admin can send X-View-As-Tenant (optional X-View-As-Role) to read
one tenant's portal exactly as a member of that tenant sees it. The policy
middleware admits the headers only for a Global Admin in person (never an
MCP call or a foreign client app), refuses every write with ViewAsReadOnly,
and decides everything else with the same evaluators over an emulated
member, so the emulation cannot drift from the real rules: a parity test
compares every read route and tenant role against a real member.

- RequestContext.ViewAs: TenantId and TargetTenantId become the viewed
  tenant and TenantHelper.GetTenantId follows them; identity uses keep the
  caller's home tenant (IdentityTenantId)
- Route catalog: ViewAsAccess, GET reads and everything else writes, with
  each exception listed in a test
- auth/me answers as the emulated member without any sign-in side effect
- GET actions stay closed under view-as: re-analyze, re-scan, the consent
  flow and the homing auto-flip
- SignalR binding, presence and the request row stay with the real caller;
  every telemetry item of such a request carries ViewAsTenantId
- Ratchet: functions take the data tenant from the request context, never
  from the token

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 15:39:12 +01:00
Oliver Kieselbach 4275c13dfc bump pointer: internal (D-420 released: Newtonsoft guard, Graph/Entra parsers on System.Text.Json, follow-ups)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 13:04:18 +01:00
Oliver Kieselbach 1616e33c14 Merge pull request #211 from okieselbach/feat/newtonsoft-guard-upstream-stj
Newtonsoft.Json contained by a guard; Graph/Entra response parsers on System.Text.Json (D-420)
2026-11-06 12:18:10 +01:00
Oliver Kieselbach 0b39455d4e Graph/Entra response parsers: permanent invariant fuzz (D-420)
UpstreamJsonInvariantTests drive the nine production parsers with 500 bodies
each, generated with every value kind, the inputs of the deliberate
differences D1 to D7 included, and check without a reference:
- a parser throws only what its callers expect (JsonException for an
  unreadable body or link, InvalidOperationException for a non-object list
  entry, nothing for the Entra rejection and the managed device), and every
  listed kind still occurs;
- a body reads the same in another layout: compact, or spread out with
  comments and trailing commas, members in another order;
- every text in a result is text the body sent, trimmed or cut at most;
- ParseObjectOrNull yields an object, null or a JsonException for any text,
  edited bodies included.

The body generator and the result descriptions move out of the temporary
differential test into UpstreamResponseCases and UpstreamParserReadings, so
they stay when the Newtonsoft reference goes. The generator's default mode
draws the same random sequence as before, so the differential test still
compares the same 20,000 cases per parser. Value pools and serialized
literals are built once; layers 1, 3 and 4 together run in under a second.

Mutation-checked locally: reading non-text values as their raw JSON fails
18 of the 28 fuzz tests, dropping the element clone fails all of them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 11:59:45 +01:00
Oliver Kieselbach 48baffe753 Graph/Entra response parsers on System.Text.Json (D-420)
The eight parsers for Microsoft Graph and Entra token-endpoint responses read
through a new helper, Helpers/UpstreamJson, instead of Newtonsoft.Json:
GraphTokenService, EntraTokenRejection, the Autopilot, corporate-identifier,
device-association, Cloud PC and Intune-binding validators, and the script
display-name resolver. Every call site keeps its flow; the existing
catch (JsonException) blocks now bind to System.Text.Json.

Unchanged and pinned by the characterization tests: empty and null bodies,
malformed bodies and their outcome per validator, non-object list entries
(transient), paging, duplicate keys (last wins), case-sensitive names,
comments and trailing commas, the token lifetime.

Deliberate differences, each pinned by a test named _D1 to _D7:
- D1 JSON null in a text field reads as null instead of "".
- D2 dates keep their fraction and are culture-independent UTC.
- D3 date-shaped text is kept as sent.
- D4 non-text values, and text whose escapes are no valid UTF-16, read as
  null (fail-closed).
- D5 an expires_in that is not a whole number falls back to the default
  token lifetime instead of throwing or being coerced.
- D6 an error code beyond Int64 is skipped instead of throwing.
- D7 a body cut off mid-object is unreadable; Newtonsoft's DeserializeObject
  read the part before the cut as if it were complete.

Also:
- The script resolver caches a per-ID 200 without a name, as the full pull
  already does, so a nameless script costs no Graph call on every view.
- The token cache caps expires_in before the TimeSpan conversion; a value
  near Int64.MaxValue overflowed instead of hitting the 55-minute cap.
- New UpstreamJsonTests cover every helper member and a culture matrix;
  a TTL test records the cache lifetime per expires_in variant.
- The differential test compares a cut-off body with the parser's answer to
  an unreadable body (D7) and stays green on 20,000 cases per parser.
- The Newtonsoft guard baseline loses the eight parser files and the dead
  using in MaintenanceService.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 11:40:25 +01:00
Oliver Kieselbach f6f88161f9 Graph/Entra response parsers: differential test against a Newtonsoft reference
LegacyUpstreamParsers keeps a verbatim copy of the eight Newtonsoft parsers in the test project.
UpstreamJsonDifferentialTests generates 20,000 bodies per parser from a fixed seed and requires the
production parser to yield exactly what the reference yields, or to throw where it throws.
The bodies vary:
- root kind, empty and broken bodies, trailing content
- comments, trailing commas, whitespace, property order, unknown and duplicate properties
- value lists of mixed entries, escaped and Unicode text
- paging links, lifetimes as number or numeric text, error-code variants

They leave out the inputs that the move to System.Text.Json changes on purpose; those are pinned in
GraphResponseParsingTests. Each parser must also reach a real result in at least 2 % of the cases,
so the comparison cannot pass on misses alone.

Today production and reference are identical, so the test is green. Altering two parsers in the
reference turned exactly those two tests red. The two files are temporary and go once the System.Text.Json
parsers have run cleanly in production (D-420).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 11:05:20 +01:00
Oliver Kieselbach d0a525ecbd Graph/Entra response parsers: characterization tests
GraphResponseParsingTests pins what the eight Graph and Entra token-endpoint parsers yield for
every realistic body and every malformed one: empty, null, array and broken bodies, missing or
non-array value lists, non-object entries before and after the match, paging links, lifetimes as
number or text, error-code variants, comments and trailing commas. Written against the current
Newtonsoft code and green on it. The tests ending in _D1 to _D6 pin the behaviour that the move
to System.Text.Json changes on purpose; the rest is the parsers' contract (D-420).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 10:51:07 +01:00
Oliver Kieselbach 257f403949 Graph/Entra responses: read through pure functions, behaviour unchanged
GraphTokenService, AutopilotDeviceValidator, CorporateIdentifierValidator and
ScriptDisplayNameResolver parsed their response bodies inline in the HTTP methods. The parsing
now sits in internal static functions (ReadTokenResponse, FindRegistration, ReadIdentityPage,
ReadScriptPage, ReadScriptDisplayName) with the same Newtonsoft calls, so every body yields the
same result and every exception still reaches the same catch block. This gives the response
parsers one testable shape ahead of their move to System.Text.Json (D-420).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 10:43:13 +01:00
Oliver Kieselbach 7cbcb6bc4c Guard: Newtonsoft.Json frozen per file and per project
NewtonsoftUsageGuardTests scans every shipped source file under src/; test projects are excluded, and
bin, obj, node_modules and .next are not entered. A code line that names the Newtonsoft.Json namespace
counts as a use, a comment line does not. The 104 files that use it today form a baseline with the
reason each group still needs it, and only the five projects that reference the package today may
keep the reference. A new use, a new package reference or a stale entry fails the test, so the
baseline can only shrink. New code reads and writes JSON with System.Text.Json (D-420).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 10:38:58 +01:00
Oliver Kieselbach f43462567e bump pointer: internal (D-419: #209 and the CI race fix)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 00:21:12 +01:00
Oliver Kieselbach b5ac4651a0 Session deletion maintenance test waits for both watchdog events
The severe-watchdog test blocked only until the severe OpsEvent and then asserted the warning as
well. The two delays are independent timers: under load the severe one can complete first, and the
cancel in the finally then drops a warning delay whose callback has not run yet (seen once in CI on
3bc8b87a). The fanout body now waits for both events.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 00:12:08 +01:00
Oliver Kieselbach 3bc8b87a19 Bump xunit.runner.visualstudio from 2.8.2 to 4.0.1
Applied on main for #209: after the dotnet group update changed the neighbouring xunit lines, the
PR conflicted and Dependabot did not act on the rebase request. The change is the PR's own five
lines. All five test suites keep their counts (8532 / 3891 / 648 / 44 / 125).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 00:01:16 +01:00
Oliver Kieselbach 950b3cc679 bump pointer: internal (D-419 Dependabot wave: decision, plan, backlog)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 23:40:25 +01:00
dependabot[bot] 0559919a9e Bump Azure.Data.Tables and 15 others (#210)
Bumps Azure.Data.Tables from 12.11.0 to 12.13.0
Bumps Azure.Monitor.Query from 1.5.0 to 1.7.1
Bumps Azure.Storage.Blobs from 12.27.0 to 12.30.1
Bumps Azure.Storage.Queues from 12.25.0 to 12.28.1
Bumps Microsoft.AspNetCore.Authentication.JwtBearer from 10.0.10 to 10.0.14
Bumps Microsoft.Azure.Functions.Worker from 2.51.0 to 2.52.0
Bumps Microsoft.Azure.Functions.Worker.ApplicationInsights from 2.50.0 to 2.51.0
Bumps Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore from 2.1.0 to 2.1.1
Bumps Microsoft.Azure.Functions.Worker.Extensions.SignalRService from 2.0.1 to 2.1.0
Bumps Microsoft.Azure.Functions.Worker.Extensions.Storage.Queues from 5.5.4 to 5.5.5
Bumps Microsoft.Azure.Functions.Worker.Sdk from 2.0.7 to 2.1.0
Bumps Microsoft.Azure.SignalR.Management from 1.33.0 to 1.33.1
Bumps Microsoft.Identity.Web from 4.3.0 to 4.16.1
Bumps Moq from 4.20.72 to 4.21.0
Bumps Newtonsoft.Json from 13.0.3 to 13.0.4
Bumps xunit from 2.9.2 to 2.9.3

---
updated-dependencies:
- dependency-name: Newtonsoft.Json
  dependency-version: 13.0.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
- dependency-name: Newtonsoft.Json
  dependency-version: 13.0.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
- dependency-name: xunit
  dependency-version: 2.9.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
- dependency-name: xunit
  dependency-version: 2.9.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
- dependency-name: Newtonsoft.Json
  dependency-version: 13.0.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
- dependency-name: xunit
  dependency-version: 2.9.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
- dependency-name: Azure.Data.Tables
  dependency-version: 12.13.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
- dependency-name: Azure.Monitor.Query
  dependency-version: 1.7.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
- dependency-name: Azure.Storage.Blobs
  dependency-version: 12.30.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
- dependency-name: Azure.Storage.Queues
  dependency-version: 12.28.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
- dependency-name: Microsoft.AspNetCore.Authentication.JwtBearer
  dependency-version: 10.0.14
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
- dependency-name: Microsoft.Azure.Functions.Worker
  dependency-version: 2.52.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
- dependency-name: Microsoft.Azure.Functions.Worker.ApplicationInsights
  dependency-version: 2.51.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
- dependency-name: Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore
  dependency-version: 2.1.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
- dependency-name: Microsoft.Azure.Functions.Worker.Extensions.SignalRService
  dependency-version: 2.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
- dependency-name: Microsoft.Azure.Functions.Worker.Extensions.Storage.Queues
  dependency-version: 5.5.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
- dependency-name: Microsoft.Azure.Functions.Worker.Sdk
  dependency-version: 2.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
- dependency-name: Microsoft.Azure.SignalR.Management
  dependency-version: 1.33.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
- dependency-name: Microsoft.Identity.Web
  dependency-version: 4.16.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
- dependency-name: Moq
  dependency-version: 4.21.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dotnet
- dependency-name: xunit
  dependency-version: 2.9.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
- dependency-name: xunit
  dependency-version: 2.9.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dotnet
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-11-05 23:26:42 +01:00
dependabot[bot] e8f8b876e3 chore(deps-dev): bump the web group across 1 directory with 2 updates (#202)
Bumps the web group with 2 updates in the /src/Web/autopilot-monitor-web directory: [knip](https://github.com/webpro-nl/knip/tree/HEAD/packages/knip) and [postcss](https://github.com/postcss/postcss).


Updates `knip` from 6.43.0 to 6.44.0
- [Release notes](https://github.com/webpro-nl/knip/releases)
- [Commits](https://github.com/webpro-nl/knip/commits/knip@6.44.0/packages/knip)

Updates `postcss` from 8.5.25 to 8.5.32
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/8.5.25...8.5.32)

---
updated-dependencies:
- dependency-name: knip
  dependency-version: 6.44.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: web
- dependency-name: postcss
  dependency-version: 8.5.32
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: web
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-11-05 23:15:54 +01:00
dependabot[bot] 83afd4f1c9 chore(deps-dev): bump @azure/static-web-apps-cli (#200)
Bumps the swa-cli group with 1 update in the /tools/swa-cli directory: [@azure/static-web-apps-cli](https://github.com/azure/static-web-apps-cli).


Updates `@azure/static-web-apps-cli` from 2.0.10 to 2.1.0
- [Release notes](https://github.com/azure/static-web-apps-cli/releases)
- [Commits](https://github.com/azure/static-web-apps-cli/compare/v2.0.10...v2.1.0)

---
updated-dependencies:
- dependency-name: "@azure/static-web-apps-cli"
  dependency-version: 2.1.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: swa-cli
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-11-05 23:11:36 +01:00
dependabot[bot] d695c9b8c4 chore(deps-dev): bump knip (#201)
Bumps the mcp group with 1 update in the /src/McpServer/autopilot-monitor-mcp directory: [knip](https://github.com/webpro-nl/knip/tree/HEAD/packages/knip).


Updates `knip` from 6.43.0 to 6.44.0
- [Release notes](https://github.com/webpro-nl/knip/releases)
- [Commits](https://github.com/webpro-nl/knip/commits/knip@6.44.0/packages/knip)

---
updated-dependencies:
- dependency-name: knip
  dependency-version: 6.44.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: mcp
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-11-05 22:58:41 +01:00
dependabot[bot] 1ee7c48c92 Bump System.Text.Json from 9.0.1 to 10.0.14 (#207)
---
updated-dependencies:
- dependency-name: System.Text.Json
  dependency-version: 10.0.14
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-11-05 22:47:41 +01:00
dependabot[bot] 98ac414208 Bump Microsoft.NET.Test.Sdk from 17.11.1 to 18.11.0 (#206)
---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-version: 18.11.0
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-version: 18.11.0
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-version: 18.11.0
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-version: 18.11.0
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-version: 18.11.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-11-05 22:47:35 +01:00
dependabot[bot] 5153e90e7c Bump Microsoft.Extensions.Http.Polly from 8.0.25 to 10.0.14 (#205)
---
updated-dependencies:
- dependency-name: Microsoft.Extensions.Http.Polly
  dependency-version: 10.0.14
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-11-05 22:47:29 +01:00
Oliver Kieselbach 5b139f90e7 Backend: Pkcs past two .NET DoS advisories, Moq 4.21-safe log assertion, no Dependabot major for Application Insights 3
- Microsoft.Identity.Web 4.3.0 brings System.Security.Cryptography.Pkcs 10.0.0 through its token
  cache, affected by GHSA-846f-f764-76mx and GHSA-2fmv-rv2c-59x7 (fixed in 10.0.13). A direct
  reference lifts it to 10.0.14 until Microsoft.Identity.Web 4.17.0 or later is in.
- Moq 4.21 annotates the It.IsAnyType match parameter as nullable. The GraphTokenService log
  assertion checks for null first, so the pending dotnet group update compiles.
- Dependabot no longer proposes Microsoft.ApplicationInsights.WorkerService 3: the OpenTelemetry
  rewrite drops telemetry processors and the Functions worker integration still builds on 2.x.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:45:55 +01:00
Oliver Kieselbach 05d21cb240 bump pointer: internal (D-418 released: plan review)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:26:12 +01:00
Oliver Kieselbach 5cc69a696a bump pointer: internal, .claude/commands (D-418 get_api_usage)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:10:24 +01:00
Oliver Kieselbach fd3ce44c0c get_api_usage reads the MCP usage overview; totals, minute shares and tenant names come from the backend
The MCP tool get_api_usage (Global Admin and Global Reader) shows what the
admin MCP Usage page shows: view=summary (totals, top tools and tenants,
newest quota refusals, accounts closest to a per-minute limit, each list
cut with its full length stated), view=tools|tenants|quotaHits|
minuteLimits|daily (one list in full), view=organization (one tenant's
budget by account and day) and view=account (one account's requests by
tool, path and day). tenantId and userId must be GUIDs. The overview call
outlasts the route's telemetry budget.

The overview response gains totals, a sharePercent per minute row and the
tenant's domainName, computed once in McpUsageOverviewService; the page
reads them instead of computing its own. The tenant configuration is read
once per tenant and a failed read only drops the name and the per-minute
override.

Removed: GET global/metrics/mcp-usage and /daily with their DTOs and the
repository reads behind them; nothing reads the per-user usage log as a
whole any more. Also removed: the unused web URL helper for the per-user
route and the MCP usage pager.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:10:23 +01:00
Oliver Kieselbach 0b48b1ce63 bump pointer: internal (work files)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 20:54:47 +01:00
Oliver Kieselbach 5cb536c46e bump pointer: internal (D-416 MCP usage overview: plan, review, backlog)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 19:11:32 +01:00
Oliver Kieselbach 3f97a418d4 MCP Usage page (GA): tenants, tools and limits at a glance
The Global Admin MCP Usage page reads the overview route. The header has
the window, a switch for platform admins and Refresh; tiles count tool
calls, charged requests, tenants, accounts and the accounts at a limit;
a chart stacks the calls per day by usage plan. Three tabs in ?view=:
- Tenants & accounts: grouped by tenant with domain, edition and the
  quota bars for today and the month, expandable to accounts and service
  principals, with search and a near-a-limit filter
- Tools: ranked by calls with reach, requests per call, error rate, p95,
  answer size and over-cap calls; the backend routes on expand
- Limits: the plan legend, the quota refusals, and each account's
  busiest 60 seconds against the MCP server's and the backend's
  per-minute limits

QuotaBar moves to components (the reporting page uses it unchanged), the
stacked bar chart takes a custom tooltip like the bar chart, and the
global and daily usage URLs leave the web API client (the routes stay
for the MCP tool).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 19:00:49 +01:00
Oliver Kieselbach cdd44d152a bump pointer: internal (D-417 Dependabot after D-415)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 18:57:45 +01:00
Oliver Kieselbach d26d877989 Dependabot: SWA CLI lockfile in tools/, overrides for adm-zip and tmp, private submodules skipped, postcss override follows its devDependency
The SWA CLI lockfile moves from .github/tools/swa-cli to tools/swa-cli:
Dependabot's update PR for the old folder was refused. deploy-web and the
Dependabot entry follow. Its package.json overrides adm-zip (^0.6.1) and tmp
(^0.2.7), which the CLI still pins below the versions that fix their
advisories. The CLI's own extract call works on adm-zip 0.6.1, and
swa --version and swa deploy --help load.

.gitmodules sets update = none for the three private submodules, so
recursive clones skip them. Public clones no longer fail on them, and
Dependabot's NuGet updater, which clones with --recurse-submodules and aborts
on any failure, can run again. A clone with access sets
submodule.<name>.update = checkout once.

The web postcss override becomes "$postcss": it follows the devDependency
that Dependabot bumps instead of conflicting with it. The lockfile is
unchanged.

zizmor.yml moves to .github/zizmor.yml, where zizmor finds it on its own;
CI, CodeQL and the workflow gates watch the new path.

Decision D-417.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 18:55:55 +01:00
Oliver Kieselbach 59959c663e MCP usage overview route: tenants, accounts, tools, refusals, peaks
GET global/metrics/mcp-usage/overview (GlobalReadOrAdmin) builds the
all-tenant MCP usage view the Global Admin metrics page will read. Calls
are counted from the request telemetry as one correlation id per tool
call; requests and quota windows come from the quota counters (one RowKey
range over McpTenantUsage, each account's state through ReadStateAsync).
Seven fixed queries cover calls, routes, quota and per-minute refusals,
peaks over sliding 60-second windows, tool quality and the MCP server's
own refusals and limit. A store that does not answer empties only its
parts and is named in the response.

The query call moves from the log proxy into LogQueryExecutor, shared by
both; the proxy answers as before. The request-row dimension names become
constants used by writer and queries, the access probe names its function,
and the organization quota node moves into McpQuotaNodes. A fixture under
tests/fixtures/mcp-log-lines pins the MCP log fields the queries read, on
both sides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 18:44:50 +01:00
Oliver Kieselbach ed2e3fd96c MCP quota: a quota view reads without counting
Since the previous commit an allowed quota check counts the request on the
instance's counters. The usage page (GET metrics/mcp-usage/me) also ran
that check to show the quota, so every page view counted as an MCP request
until the next storage read. The service now has two entries: AdmitAsync
decides and counts and is called only by the enforcement middleware;
ReadStateAsync returns the same decision without counting, for views.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 17:48:46 +01:00
Oliver Kieselbach d35edeaf9f MCP quota: count admitted requests at once, McpQuotaExceeded ops event
The daily and monthly MCP quota now decides and counts in one step on the
instance's cached counters, so one instance blocks at the limit, also for
the parallel requests of one tool call. Concurrent first checks share one
counter (single-flight), and the UTC day is part of the counter key, so a
reading from before midnight never answers a check after it. Only what
other instances admitted inside their 60-second reading stays soft.

The first refusal per instance, account or organization, window and period
raises the new ops event McpQuotaExceeded (Tenant, Info), selectable in the
alert rules. The Warning lines of quota and per-minute refusals start with
shared prefix constants.

The MCP server writes its per-account message budget into the boot line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 17:42:27 +01:00
Oliver Kieselbach 21b802a028 bump pointer: internal (keep-awake D-413/D-414 released)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 17:39:58 +01:00
dependabot[bot] ae258cd9a7 chore(deps): bump jose (#199)
Bumps the mcp group in /src/McpServer/autopilot-monitor-mcp with 1 update: [jose](https://github.com/panva/jose).


Updates `jose` from 6.2.13 to 6.2.14
- [Release notes](https://github.com/panva/jose/releases)
- [Changelog](https://github.com/panva/jose/blob/main/CHANGELOG.md)
- [Commits](https://github.com/panva/jose/compare/v6.2.13...v6.2.14)

---
updated-dependencies:
- dependency-name: jose
  dependency-version: 6.2.14
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: mcp
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-11-05 17:22:50 +01:00
422 changed files with 28664 additions and 3584 deletions
+1 -1
View File
@@ -30,7 +30,7 @@
- Stage explicit file lists; never `git add -A` or a directory. Pushing is the user's call.
- New API responses need a typed DTO plus the parity fact. MCP vocabularies are generated from the wire types, never retyped.
- Every route belongs in the route policy catalog; every new event type goes into the MCP resource catalog.
- Workflow files under `.github/` go through zizmor before they are committed (`zizmor .` from the repository root, findings from severity low on): fix every finding or ignore it in `zizmor.yml` with a reason. The `zizmor` job in `action-pins.yml` runs the same check on every push.
- Workflow files under `.github/` go through zizmor before they are committed (`zizmor .` from the repository root, findings from severity low on): fix every finding or ignore it in `.github/zizmor.yml` with a reason. The `zizmor` job in `action-pins.yml` runs the same check on every push.
- The about, terms and privacy pages under `src/Web/autopilot-monitor-web/app/` state facts customers rely on: verify every claim against the code before writing it and update them in the same change as the fact they describe.
## Code Quality
+7 -1
View File
@@ -24,6 +24,11 @@ updates:
dotnet-security:
applies-to: security-updates
patterns: ['*']
# Application Insights 3 is the OpenTelemetry rewrite (no telemetry processors, another sampling
# model) and the Functions worker integration still builds on 2.x: a planned migration, not a bump.
ignore:
- dependency-name: 'Microsoft.ApplicationInsights.WorkerService'
update-types: ['version-update:semver-major']
- package-ecosystem: npm
directory: /src/Web/autopilot-monitor-web
@@ -101,8 +106,9 @@ updates:
# SWA CLI for the deploy job of deploy-web.yml, which installs it from this lockfile next to
# the production deploy token: a version reaches that job only through a reviewed bump here.
# deploy-web watches this folder, so a merged bump redeploys and proves the new CLI at once.
# Not under .github/: there Dependabot's update PR was refused as an unauthorized change.
- package-ecosystem: npm
directory: /.github/tools/swa-cli
directory: /tools/swa-cli
schedule:
interval: weekly
cooldown:
-8
View File
@@ -1,8 +0,0 @@
{
"name": "autopilot-monitor-swa-cli",
"private": true,
"description": "Azure Static Web Apps CLI for the deploy job of deploy-web.yml - installed from this lockfile with --ignore-scripts, because that job holds the production deploy token.",
"devDependencies": {
"@azure/static-web-apps-cli": "2.0.10"
}
}
+5 -4
View File
@@ -5,8 +5,9 @@ name: Workflow gates
# version comment (stricter than zizmor's unpinned-uses audit).
# * zizmor -- static analysis of every workflow (permissions, credential
# persistence, template injection, ...). Configuration and the
# reasoned ignores live in zizmor.yml at the repository root; the
# same run is expected locally before a workflow change is committed.
# reasoned ignores live in .github/zizmor.yml, which zizmor finds on
# its own; the same run is expected locally before a workflow change
# is committed.
# * hosts -- no workflow or .github/scripts helper spells out a host; every one
# comes from .github/scripts/Get-Endpoints.ps1, CI's member of the URL
# registry (the C#, web and MCP registries have guard tests of their own).
@@ -39,10 +40,10 @@ name: Workflow gates
on:
push:
branches: [main]
paths: ['.github/workflows/**', '.github/scripts/**', '.github/dependabot.yml', 'zizmor.yml']
paths: ['.github/workflows/**', '.github/scripts/**', '.github/dependabot.yml', '.github/zizmor.yml']
pull_request:
branches: [main]
paths: ['.github/workflows/**', '.github/scripts/**', '.github/dependabot.yml', 'zizmor.yml']
paths: ['.github/workflows/**', '.github/scripts/**', '.github/dependabot.yml', '.github/zizmor.yml']
workflow_dispatch:
permissions:
+2 -2
View File
@@ -24,7 +24,7 @@ on:
- 'infra/**'
- '.claude/**'
- '.gitmodules'
- 'zizmor.yml'
- '.github/zizmor.yml'
- '**/*.md'
- 'LICENSE'
- '.github/ISSUE_TEMPLATE/**'
@@ -56,7 +56,7 @@ on:
- 'infra/**'
- '.claude/**'
- '.gitmodules'
- 'zizmor.yml'
- '.github/zizmor.yml'
- '**/*.md'
- 'LICENSE'
- '.github/ISSUE_TEMPLATE/**'
+2 -2
View File
@@ -17,7 +17,7 @@ on:
- 'infra/**'
- '.claude/**'
- '.gitmodules'
- 'zizmor.yml'
- '.github/zizmor.yml'
- '**/*.md'
- 'LICENSE'
- '.github/ISSUE_TEMPLATE/**'
@@ -48,7 +48,7 @@ on:
- 'infra/**'
- '.claude/**'
- '.gitmodules'
- 'zizmor.yml'
- '.github/zizmor.yml'
- '**/*.md'
- 'LICENSE'
- '.github/ISSUE_TEMPLATE/**'
+4 -4
View File
@@ -1,6 +1,6 @@
name: Deploy Web (Static Web App)
# Build here, upload with the SWA CLI from its own lockfile (.github/tools/swa-cli). No
# Build here, upload with the SWA CLI from its own lockfile (tools/swa-cli). No
# third-party action sees the deploy token, the build runs on the same path ci.yml tests
# (setup-node 22 + npm ci + next build) instead of Oryx guessing inside the action's container,
# and the exported site is attested like the agent ZIP and the MSI.
@@ -19,7 +19,7 @@ on:
- main
paths:
- 'src/Web/autopilot-monitor-web/**'
- '.github/tools/swa-cli/**'
- 'tools/swa-cli/**'
- '.github/workflows/deploy-web.yml'
workflow_dispatch:
@@ -173,7 +173,7 @@ jobs:
# --no-use-keychain keeps unloaded. Before the artifact arrives, so nothing from the
# build zone can touch the install.
- name: Install the SWA CLI from its lockfile
working-directory: .github/tools/swa-cli
working-directory: tools/swa-cli
run: npm ci --ignore-scripts
- name: Download build artifact
@@ -193,7 +193,7 @@ jobs:
env:
SWA_CLI_DEPLOYMENT_TOKEN: ${{ secrets.AZURE_SWA_DEPLOY_TOKEN }}
run: |
.github/tools/swa-cli/node_modules/.bin/swa deploy \
tools/swa-cli/node_modules/.bin/swa deploy \
--app-location "$WEB_DIR" \
--output-location out \
--swa-config-location "$WEB_DIR" \
View File
+6
View File
@@ -1,9 +1,15 @@
# The three submodules are private. "update = none" makes recursive clones skip them (the
# public, Dependabot's NuGet updater); a clone with access sets
# submodule.<name>.update = checkout once, or runs git submodule update --init --checkout.
[submodule ".claude/commands"]
path = .claude/commands
url = https://github.com/okieselbach/Autopilot-Monitor-dotclaude.git
update = none
[submodule "docs"]
path = internal
url = https://github.com/okieselbach/Autopilot-Monitor-internal.git
update = none
[submodule "infra"]
path = infra
url = https://github.com/okieselbach/Autopilot-Monitor-infra.git
update = none
+23 -4
View File
@@ -2,10 +2,10 @@
"$schema": "../schema/analyze-rule.schema.json",
"ruleId": "ANALYZE-ID-002",
"title": "Unexpected Local Admin Accounts Detected",
"description": "Detects when the LocalAdminAnalyzer flags unexpected local user accounts or profile directories on the device. This is a known Autopilot bypass technique where admin accounts are created before or during enrollment to gain persistent local admin access.",
"description": "Detects when the LocalAdminAnalyzer flags unexpected local user accounts on the device, including accounts allowed only as standard users that hold local admin rights. This is a known Autopilot bypass technique where admin accounts are created before or during enrollment to gain persistent local admin access.",
"severity": "high",
"category": "identity",
"version": "1.4.0",
"version": "1.5.0",
"author": "Autopilot Monitor",
"enabled": true,
"evaluateOn": [
@@ -65,6 +65,18 @@
"filterOperator": "equals",
"filterValue": "unexpected_local_admins_detected",
"required": false
},
{
"signal": "role_violations",
"source": "event_data",
"eventType": "local_admin_analysis",
"dataField": "checks.role_violations",
"operator": "not_equals",
"value": "",
"filterField": "finding",
"filterOperator": "equals",
"filterValue": "unexpected_local_admins_detected",
"required": false
}
],
"confidenceFactors": [
@@ -80,7 +92,7 @@
}
],
"confidenceThreshold": 50,
"explanation": "The agent detected unexpected local user accounts or profile directories on this device that are not in the built-in or tenant-configured allowed list.\n\nThis is a security-relevant finding. Creating local admin accounts before or during Autopilot enrollment is a known bypass technique (e.g. via BypassNRO or Shift+F10 during OOBE) that grants persistent local administrator access.\n\nClick the event link below to jump to the local_admin_analysis event and check: unexpected_accounts (local user accounts not on the allowed list — disabled accounts included, a dormant account can be re-enabled later), unexpected_admin_members (unexpected accounts that are members of the local Administrators group — the actual backdoor), account_details (per account: disabled state and Administrators membership), unexpected_profiles (C:\\Users profile directories not on the allowed list), logged_in_local_accounts (local accounts that were signed in when the shutdown scan ran — a signed-in local account is never exempted, only Entra/domain users are), bypass_nro (whether the BypassNRO registry flag was set), and confidence_score (the agent's confidence in the finding, 0-100).\n\nIf these accounts are expected for your environment (e.g. a service account or helpdesk account), add them to the allowed list in Tenant Settings.",
"explanation": "The agent detected unexpected local user accounts on this device: accounts the built-in or tenant-configured allowed list does not allow, or accounts it allows only as standard users that are members of the local Administrators group.\n\nThis is a security-relevant finding. Creating local admin accounts before or during Autopilot enrollment is a known bypass technique (e.g. via BypassNRO or Shift+F10 during OOBE) that grants persistent local administrator access.\n\nClick the event link below to jump to the local_admin_analysis event and check: unexpected_accounts (local user accounts not allowed by the list — disabled accounts included, a dormant account can be re-enabled later), unexpected_admin_members (unexpected accounts that are members of the local Administrators group — the actual backdoor), role_violations (accounts allowed only as standard users that are members of Administrators — Windows never puts Guest, kioskUser0 or WsiAccount there), account_details (per account: disabled state, Administrators membership and RID — 500 is the built-in Administrator), unexpected_profiles (C:\\Users profile directories not on the allowed list), logged_in_local_accounts (local accounts that were signed in when the shutdown scan ran — a signed-in local account is never exempted, only Entra/domain users are), bypass_nro (whether the BypassNRO registry flag was set), and confidence_score (the agent's confidence in the finding, 0-100).\n\nIf these accounts are expected for your environment (e.g. a service account or helpdesk account), add them to the allowed list under Settings → Agent Analyzers. Choose Standard user only for an account that must never be a local administrator.",
"remediation": [
{
"title": "Review the unexpected accounts",
@@ -94,7 +106,8 @@
"title": "Add expected accounts to the allowed list (false positive)",
"steps": [
"Go to Settings → Agent Analyzers section",
"Under 'Allowed Admin Accounts', add the account names that are expected in your environment",
"Under 'Allowed Local Accounts', add the account names that are expected in your environment",
"Choose 'Standard user only' for an account that must not be a local administrator — it is still reported if it ever joins the Administrators group",
"Save the settings — future enrollments will no longer flag these accounts"
]
},
@@ -104,6 +117,7 @@
"Check if the BypassNRO registry flag was set (indicates OOBE was bypassed)",
"Review the enrollment timeline for Shift+F10 or other OOBE escape indicators",
"Check 'unexpected_admin_members' and 'account_details' — an unexpected account with Administrators membership is a backdoor even while it is disabled (it can be re-enabled by a scheduled task after enrollment)",
"Check 'role_violations' — a built-in Windows account or an account you allowed as standard user that sits in Administrators was put there on purpose",
"Consider re-imaging the device if unauthorized admin access is confirmed"
]
}
@@ -126,6 +140,11 @@
"label": "In Administrators",
"value": "{{unexpected_admin_members.value}}",
"format": "code"
},
{
"label": "Allowed only as standard user",
"value": "{{role_violations.value}}",
"format": "code"
}
]
},
+23 -4
View File
@@ -4103,10 +4103,10 @@
{
"ruleId": "ANALYZE-ID-002",
"title": "Unexpected Local Admin Accounts Detected",
"description": "Detects when the LocalAdminAnalyzer flags unexpected local user accounts or profile directories on the device. This is a known Autopilot bypass technique where admin accounts are created before or during enrollment to gain persistent local admin access.",
"description": "Detects when the LocalAdminAnalyzer flags unexpected local user accounts on the device, including accounts allowed only as standard users that hold local admin rights. This is a known Autopilot bypass technique where admin accounts are created before or during enrollment to gain persistent local admin access.",
"severity": "high",
"category": "identity",
"version": "1.4.0",
"version": "1.5.0",
"author": "Autopilot Monitor",
"enabled": true,
"evaluateOn": [
@@ -4166,6 +4166,18 @@
"filterOperator": "equals",
"filterValue": "unexpected_local_admins_detected",
"required": false
},
{
"signal": "role_violations",
"source": "event_data",
"eventType": "local_admin_analysis",
"dataField": "checks.role_violations",
"operator": "not_equals",
"value": "",
"filterField": "finding",
"filterOperator": "equals",
"filterValue": "unexpected_local_admins_detected",
"required": false
}
],
"confidenceFactors": [
@@ -4181,7 +4193,7 @@
}
],
"confidenceThreshold": 50,
"explanation": "The agent detected unexpected local user accounts or profile directories on this device that are not in the built-in or tenant-configured allowed list.\n\nThis is a security-relevant finding. Creating local admin accounts before or during Autopilot enrollment is a known bypass technique (e.g. via BypassNRO or Shift+F10 during OOBE) that grants persistent local administrator access.\n\nClick the event link below to jump to the local_admin_analysis event and check: unexpected_accounts (local user accounts not on the allowed list — disabled accounts included, a dormant account can be re-enabled later), unexpected_admin_members (unexpected accounts that are members of the local Administrators group — the actual backdoor), account_details (per account: disabled state and Administrators membership), unexpected_profiles (C:\\Users profile directories not on the allowed list), logged_in_local_accounts (local accounts that were signed in when the shutdown scan ran — a signed-in local account is never exempted, only Entra/domain users are), bypass_nro (whether the BypassNRO registry flag was set), and confidence_score (the agent's confidence in the finding, 0-100).\n\nIf these accounts are expected for your environment (e.g. a service account or helpdesk account), add them to the allowed list in Tenant Settings.",
"explanation": "The agent detected unexpected local user accounts on this device: accounts the built-in or tenant-configured allowed list does not allow, or accounts it allows only as standard users that are members of the local Administrators group.\n\nThis is a security-relevant finding. Creating local admin accounts before or during Autopilot enrollment is a known bypass technique (e.g. via BypassNRO or Shift+F10 during OOBE) that grants persistent local administrator access.\n\nClick the event link below to jump to the local_admin_analysis event and check: unexpected_accounts (local user accounts not allowed by the list — disabled accounts included, a dormant account can be re-enabled later), unexpected_admin_members (unexpected accounts that are members of the local Administrators group — the actual backdoor), role_violations (accounts allowed only as standard users that are members of Administrators — Windows never puts Guest, kioskUser0 or WsiAccount there), account_details (per account: disabled state, Administrators membership and RID — 500 is the built-in Administrator), unexpected_profiles (C:\\Users profile directories not on the allowed list), logged_in_local_accounts (local accounts that were signed in when the shutdown scan ran — a signed-in local account is never exempted, only Entra/domain users are), bypass_nro (whether the BypassNRO registry flag was set), and confidence_score (the agent's confidence in the finding, 0-100).\n\nIf these accounts are expected for your environment (e.g. a service account or helpdesk account), add them to the allowed list under Settings → Agent Analyzers. Choose Standard user only for an account that must never be a local administrator.",
"remediation": [
{
"title": "Review the unexpected accounts",
@@ -4195,7 +4207,8 @@
"title": "Add expected accounts to the allowed list (false positive)",
"steps": [
"Go to Settings → Agent Analyzers section",
"Under 'Allowed Admin Accounts', add the account names that are expected in your environment",
"Under 'Allowed Local Accounts', add the account names that are expected in your environment",
"Choose 'Standard user only' for an account that must not be a local administrator — it is still reported if it ever joins the Administrators group",
"Save the settings — future enrollments will no longer flag these accounts"
]
},
@@ -4205,6 +4218,7 @@
"Check if the BypassNRO registry flag was set (indicates OOBE was bypassed)",
"Review the enrollment timeline for Shift+F10 or other OOBE escape indicators",
"Check 'unexpected_admin_members' and 'account_details' — an unexpected account with Administrators membership is a backdoor even while it is disabled (it can be re-enabled by a scheduled task after enrollment)",
"Check 'role_violations' — a built-in Windows account or an account you allowed as standard user that sits in Administrators was put there on purpose",
"Consider re-imaging the device if unauthorized admin access is confirmed"
]
}
@@ -4227,6 +4241,11 @@
"label": "In Administrators",
"value": "{{unexpected_admin_members.value}}",
"format": "code"
},
{
"label": "Allowed only as standard user",
"value": "{{role_violations.value}}",
"format": "code"
}
]
},
@@ -18,9 +18,9 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
<PackageReference Include="xunit" Version="2.9.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.11.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="4.0.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
@@ -44,7 +44,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Harness
IReadOnlyCollection<string>? whiteGloveSealingPatternIds = null,
TimeSpan? drainInterval = null,
TimeSpan? terminalDrainTimeout = null,
TimeSpan? agentMaxLifetime = null) =>
TimeSpan? agentMaxLifetime = null,
TimeSpan? collectorHostStopTimeout = null) =>
new EnrollmentOrchestrator(
sessionId: "S1",
tenantId: "T1",
@@ -58,7 +59,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Harness
whiteGloveSealingPatternIds: whiteGloveSealingPatternIds,
drainInterval: drainInterval ?? TimeSpan.FromDays(1),
terminalDrainTimeout: terminalDrainTimeout ?? TimeSpan.FromSeconds(2),
agentMaxLifetime: agentMaxLifetime);
agentMaxLifetime: agentMaxLifetime,
collectorHostStopTimeout: collectorHostStopTimeout);
public void Dispose() => Tmp.Dispose();
}
@@ -0,0 +1,45 @@
#nullable enable
using System.Collections.Generic;
using System.IO;
using System.Linq;
using AutopilotMonitor.Agent.V2.Core.Tests.Harness;
using AutopilotMonitor.Shared.Models;
using Newtonsoft.Json.Linq;
using Xunit;
namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Analyzers
{
/// <summary>
/// <c>tests/fixtures/local-admin-allow-list/cases.json</c> run against the netstandard2.0 build of
/// <see cref="LocalAdminAllowList"/> — the one the agent ships. The backend runs the same file against
/// its net10.0 build, the portal against <c>allowedAccounts.ts</c>.
/// </summary>
public sealed class LocalAdminAllowListFixtureTests
{
private static IEnumerable<JToken> ParseCases()
{
var path = Path.Combine(RepoPaths.Fixtures("local-admin-allow-list"), "cases.json");
return JObject.Parse(File.ReadAllText(path))["parse"]!;
}
public static IEnumerable<object[]> ParseEntries() => ParseCases().Select(c => new object[] { c.Value<string>("entry")! });
[Theory]
[MemberData(nameof(ParseEntries))]
public void Agent_parses_the_entry_as_the_shared_case_says(string entry)
{
var c = ParseCases().First(x => x.Value<string>("entry") == entry);
var parsed = LocalAdminAllowList.TryParseEntry(entry, out var pattern, out var role);
if (c.Value<bool?>("ignored") == true)
{
Assert.False(parsed);
return;
}
Assert.True(parsed);
Assert.Equal(c.Value<string>("pattern"), pattern);
Assert.Equal(c.Value<string>("role") == "user" ? LocalAccountRole.StandardUser : LocalAccountRole.Any, role);
}
}
}
@@ -18,10 +18,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Analyzers
private const string Machine = "DESKTOP-TEST01";
private const string MachineSidPrefix = "S-1-5-21-111-222-333-";
private static readonly List<string> Allowed = new List<string>
{
"Administrator", "Guest", "DefaultAccount", "WDAGUtilityAccount", "defaultuser0", "defaultuser1", "adm-*"
};
// The real built-in catalog plus one tenant glob.
private static readonly List<LocalAdminAnalyzer.AllowedEntry> Allowed =
LocalAdminAnalyzer.BuildAllowedEntries(new[] { "adm-*" }, new List<string>());
private static LocalAdminAnalyzer.LocalAccountInfo Account(string name, bool disabled, int rid) =>
new LocalAdminAnalyzer.LocalAccountInfo { Name = name, Disabled = disabled, Sid = MachineSidPrefix + rid };
@@ -126,7 +125,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Analyzers
[Fact]
public void Local_admin_member_missing_from_the_wmi_inventory_is_still_flagged()
{
// WMI failed or did not list the account — the SAM group membership alone is enough.
// WMI failed or did not list the account — the SAM group membership alone is enough,
// and the account counts as unexpected too, like any unknown administrator (score 80).
var members = new List<LocalGroupMember>
{
LocalMember("Administrator", 500),
@@ -136,8 +136,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Analyzers
var result = LocalAdminAnalyzer.EvaluateAccounts(
new List<LocalAdminAnalyzer.LocalAccountInfo>(), members, true, Machine, Allowed);
Assert.Empty(result.Unexpected);
Assert.Equal(new[] { "backdoor" }, result.Unexpected);
Assert.Equal(new[] { "backdoor" }, result.UnexpectedAdminMembers);
Assert.Empty(result.RoleViolations);
}
[Fact]
@@ -191,26 +192,24 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Analyzers
}
[Fact]
public void Well_known_rid_does_not_cover_ordinary_accounts_or_foreign_sids()
public void Machine_account_rid_is_read_only_from_local_machine_sids()
{
Assert.True(LocalAdminAnalyzer.IsWellKnownBuiltInRid(MachineSidPrefix + "500"));
Assert.True(LocalAdminAnalyzer.IsWellKnownBuiltInRid(MachineSidPrefix + "501"));
Assert.True(LocalAdminAnalyzer.IsWellKnownBuiltInRid(MachineSidPrefix + "503"));
Assert.True(LocalAdminAnalyzer.IsWellKnownBuiltInRid(MachineSidPrefix + "504"));
Assert.False(LocalAdminAnalyzer.IsWellKnownBuiltInRid(MachineSidPrefix + "502"));
Assert.False(LocalAdminAnalyzer.IsWellKnownBuiltInRid(MachineSidPrefix + "1500"));
Assert.False(LocalAdminAnalyzer.IsWellKnownBuiltInRid(MachineSidPrefix + "1001"));
Assert.False(LocalAdminAnalyzer.IsWellKnownBuiltInRid("S-1-12-1-1-2-3-500"));
Assert.False(LocalAdminAnalyzer.IsWellKnownBuiltInRid("S-1-5-32-544"));
Assert.False(LocalAdminAnalyzer.IsWellKnownBuiltInRid(MachineSidPrefix));
Assert.False(LocalAdminAnalyzer.IsWellKnownBuiltInRid(null));
Assert.False(LocalAdminAnalyzer.IsWellKnownBuiltInRid(""));
Assert.Equal(500, LocalAdminAnalyzer.MachineAccountRid(MachineSidPrefix + "500"));
Assert.Equal(501, LocalAdminAnalyzer.MachineAccountRid(MachineSidPrefix + "501"));
Assert.Equal(1001, LocalAdminAnalyzer.MachineAccountRid(MachineSidPrefix + "1001"));
Assert.Null(LocalAdminAnalyzer.MachineAccountRid("S-1-12-1-1-2-3-500"));
Assert.Null(LocalAdminAnalyzer.MachineAccountRid("S-1-5-32-544"));
Assert.Null(LocalAdminAnalyzer.MachineAccountRid(MachineSidPrefix));
Assert.Null(LocalAdminAnalyzer.MachineAccountRid(MachineSidPrefix + "x1"));
Assert.Null(LocalAdminAnalyzer.MachineAccountRid(null!));
Assert.Null(LocalAdminAnalyzer.MachineAccountRid(""));
}
[Fact]
public void Account_named_like_a_builtin_but_with_an_ordinary_rid_is_still_matched_by_name_only()
public void Localized_builtin_name_on_an_ordinary_rid_is_not_allowed()
{
// Name-based allowance is unchanged: the RID match only ADDS coverage.
// Only the RID makes a built-in: an ordinary account merely named like a localized
// built-in is no entry at all.
var accounts = new List<LocalAdminAnalyzer.LocalAccountInfo>
{
Account("Gast", disabled: false, rid: 1001)
@@ -0,0 +1,349 @@
#nullable enable
using System.Collections.Generic;
using System.Linq;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Interop;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers;
using AutopilotMonitor.Shared.Models;
using Xunit;
namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Analyzers
{
/// <summary>
/// Roles on the allowed list: <c>name|user</c> and the standard-user built-ins (Guest,
/// DefaultAccount, WDAGUtilityAccount by RID; kioskUser0, WsiAccount and other accounts carrying a
/// built-in name by name) allow an account only while it is not an Administrators member. A
/// restriction always wins; the four built-in accounts are decided by RID alone; profile folders
/// have no role; a login allows a profile folder, never an account. All names are synthetic.
/// </summary>
public sealed class LocalAdminAnalyzerRoleTests
{
private const string Machine = "DESKTOP-TEST01";
private const string MachineSidPrefix = "S-1-5-21-111-222-333-";
private static List<LocalAdminAnalyzer.AllowedEntry> Entries(params string[] tenantEntries)
=> LocalAdminAnalyzer.BuildAllowedEntries(tenantEntries, new List<string>());
private static LocalAdminAnalyzer.LocalAccountInfo Account(string name, int rid, bool disabled = false) =>
new LocalAdminAnalyzer.LocalAccountInfo { Name = name, Disabled = disabled, Sid = MachineSidPrefix + rid };
private static LocalGroupMember Member(string name, int rid) =>
new LocalGroupMember { DomainAndName = Machine + "\\" + name, Sid = MachineSidPrefix + rid, SidUsage = 1 };
private static LocalAdminAnalyzer.LocalAccountCheckResult Evaluate(
IList<LocalAdminAnalyzer.LocalAccountInfo> accounts, IList<LocalGroupMember> admins, List<LocalAdminAnalyzer.AllowedEntry> entries,
bool enumerated = true)
=> LocalAdminAnalyzer.EvaluateAccounts(accounts, admins, enumerated, Machine, entries);
// -------------------------------------------------------------- WsiAccount (the field case)
[Fact]
public void WsiAccount_as_standard_user_with_its_profile_folder_scores_zero()
{
// The field case: web sign-in enabled the account for the sign-in, it holds no admin
// membership and has C:\Users\WsiAccount — before roles existed this scored 80 (Error).
var accounts = new[]
{
Account("Administrator", 500, disabled: true),
Account("DefaultAccount", 503, disabled: true),
Account("defaultuser0", 1000, disabled: true),
Account("Gast", 501, disabled: true),
Account("WDAGUtilityAccount", 504, disabled: true),
Account("WsiAccount", 1001, disabled: true),
Account("ADM-0A1B2C3D", 1002),
};
var admins = new List<LocalGroupMember>
{
Member("Administrator", 500),
new LocalGroupMember { DomainAndName = "S-1-12-1-11-22-33-44", Sid = "S-1-12-1-11-22-33-44", SidUsage = 8 },
Member("ADM-0A1B2C3D", 1002),
};
var result = Evaluate(accounts, admins, Entries("ADM-*"));
var score = LocalAdminAnalyzer.ComputeConfidenceScore(
bypassNro: false, result.Unexpected, result.UnexpectedAdminMembers, new List<string> { "jane.doe" });
Assert.Empty(result.Unexpected);
Assert.Empty(result.UnexpectedAdminMembers);
Assert.Empty(result.RoleViolations);
Assert.Equal(0, score);
}
[Fact]
public void WsiAccount_in_administrators_is_a_role_violation_even_while_disabled()
{
var result = Evaluate(
new[] { Account("WsiAccount", 1001, disabled: true) },
new List<LocalGroupMember> { Member("WsiAccount", 1001) },
Entries());
Assert.Equal(new[] { "WsiAccount" }, result.Unexpected);
Assert.Equal(new[] { "WsiAccount" }, result.UnexpectedAdminMembers);
Assert.Equal(new[] { "WsiAccount" }, result.RoleViolations);
Assert.Equal(80, LocalAdminAnalyzer.ComputeConfidenceScore(
false, result.Unexpected, result.UnexpectedAdminMembers, new List<string>()));
}
[Theory]
[InlineData("WsiAccount")]
[InlineData("wsiaccount")]
[InlineData("Wsi*")]
[InlineData("*")]
public void Tenant_entries_cannot_lift_a_builtin_restriction(string tenantEntry)
{
var result = Evaluate(
new[] { Account("WsiAccount", 1001) },
new List<LocalGroupMember> { Member("WsiAccount", 1001) },
Entries(tenantEntry));
Assert.Equal(new[] { "WsiAccount" }, result.RoleViolations);
}
[Fact]
public void KioskUser0_in_administrators_is_a_role_violation()
{
var result = Evaluate(
new[] { Account("kioskUser0", 1003) },
new List<LocalGroupMember> { Member("kioskUser0", 1003) },
Entries());
Assert.Equal(new[] { "kioskUser0" }, result.RoleViolations);
}
// -------------------------------------------------------------- built-ins by RID
[Theory]
[InlineData("Guest", 501)]
[InlineData("Gast", 501)]
[InlineData("Invité", 501)]
[InlineData("DefaultAccount", 503)]
[InlineData("WDAGUtilityAccount", 504)]
public void Builtin_accounts_that_are_never_administrators_are_flagged_as_one(string name, int rid)
{
// A tenant entry naming the localized account (or even "*") cannot lift it either.
var result = Evaluate(
new[] { Account(name, rid, disabled: true) },
new List<LocalGroupMember> { Member(name, rid) },
Entries(name, "*"));
Assert.Equal(new[] { name }, result.Unexpected);
Assert.Equal(new[] { name }, result.UnexpectedAdminMembers);
Assert.Equal(new[] { name }, result.RoleViolations);
}
[Theory]
[InlineData("Administrator")]
[InlineData("Administrateur")]
[InlineData("Renamed_Admin")]
public void The_builtin_administrator_is_allowed_by_rid_under_any_name(string name)
{
// "Admin*|user" must not turn the real Administrator into a finding: name entries never
// decide the RID accounts — and the built-in name entry "Administrator|user" neither.
var result = Evaluate(
new[] { Account(name, 500) },
new List<LocalGroupMember> { Member(name, 500) },
Entries("Admin*|user", "Renamed*|user"));
Assert.Empty(result.Unexpected);
Assert.Empty(result.RoleViolations);
Assert.True(result.BuiltInAdministratorEnabled);
}
[Fact]
public void An_ordinary_account_named_administrator_is_allowed_only_as_a_decoy()
{
// French device: the RID-500 account is "Administrateur", so "Administrator" is free.
var accounts = new[]
{
Account("Administrateur", 500, disabled: true),
Account("Administrator", 1004),
};
var decoy = Evaluate(accounts, new List<LocalGroupMember> { Member("Administrateur", 500) }, Entries());
Assert.Empty(decoy.Unexpected);
var impostor = Evaluate(accounts,
new List<LocalGroupMember> { Member("Administrateur", 500), Member("Administrator", 1004) }, Entries());
Assert.Equal(new[] { "Administrator" }, impostor.RoleViolations);
Assert.Equal(new[] { "Administrator" }, impostor.UnexpectedAdminMembers);
}
[Fact]
public void The_oobe_account_may_be_an_administrator()
{
var result = Evaluate(
new[] { Account("defaultuser0", 1000) },
new List<LocalGroupMember> { Member("defaultuser0", 1000) },
Entries());
Assert.Empty(result.Unexpected);
}
[Fact]
public void A_missing_sid_lets_the_english_builtin_name_stand_in_for_the_rid()
{
var accounts = new List<LocalAdminAnalyzer.LocalAccountInfo>
{
new LocalAdminAnalyzer.LocalAccountInfo { Name = "Administrator", Disabled = false, Sid = null! },
new LocalAdminAnalyzer.LocalAccountInfo { Name = "Guest", Disabled = false, Sid = null! },
};
var admins = new List<LocalGroupMember>
{
new LocalGroupMember { DomainAndName = Machine + "\\Administrator", Sid = null!, SidUsage = 1 },
new LocalGroupMember { DomainAndName = Machine + "\\Guest", Sid = null!, SidUsage = 1 },
};
var result = Evaluate(accounts, admins, Entries());
Assert.Equal(new[] { "Guest" }, result.RoleViolations);
Assert.DoesNotContain("Administrator", result.Unexpected);
}
// -------------------------------------------------------------- tenant roles
[Fact]
public void A_standard_user_entry_allows_the_account_until_it_is_an_administrator()
{
var accounts = new[] { Account("frontdesk", 1005) };
Assert.Empty(Evaluate(accounts, new List<LocalGroupMember>(), Entries("frontdesk|user")).Unexpected);
var admin = Evaluate(accounts, new List<LocalGroupMember> { Member("frontdesk", 1005) }, Entries("frontdesk|user"));
Assert.Equal(new[] { "frontdesk" }, admin.RoleViolations);
}
[Fact]
public void A_standard_user_glob_restricts_each_matching_account()
{
var accounts = new[] { Account("svc-print", 1006), Account("svc-scan", 1007) };
var result = Evaluate(accounts, new List<LocalGroupMember> { Member("svc-scan", 1007) }, Entries("svc-*|user"));
Assert.Equal(new[] { "svc-scan" }, result.Unexpected);
Assert.Equal(new[] { "svc-scan" }, result.RoleViolations);
}
[Fact]
public void A_restriction_wins_over_a_broader_entry_that_allows_more()
{
var accounts = new[] { Account("adm-kiosk", 1008), Account("adm-4711", 1009) };
var admins = new List<LocalGroupMember> { Member("adm-kiosk", 1008), Member("adm-4711", 1009) };
var result = Evaluate(accounts, admins, Entries("adm-*", "adm-kiosk|user"));
Assert.Equal(new[] { "adm-kiosk" }, result.RoleViolations);
Assert.DoesNotContain("adm-4711", result.Unexpected);
}
[Fact]
public void Membership_unknown_lets_a_standard_user_entry_act_like_a_plain_one()
{
// Enumeration failed: nobody is known to be an administrator, so nothing is a violation.
var result = Evaluate(new[] { Account("WsiAccount", 1001) }, new List<LocalGroupMember>(), Entries(), enumerated: false);
Assert.Empty(result.Unexpected);
Assert.False(result.AdministratorsGroupEnumerated);
}
// -------------------------------------------------------------- folders are no accounts
[Fact]
public void An_account_named_like_a_profile_folder_is_unexpected_while_the_folder_is_allowed()
{
var entries = Entries();
var result = Evaluate(new[] { Account("Public", 1010) }, new List<LocalGroupMember> { Member("Public", 1010) }, entries);
Assert.Equal(new[] { "Public" }, result.Unexpected);
Assert.Equal(new[] { "Public" }, result.UnexpectedAdminMembers);
Assert.Empty(result.RoleViolations);
Assert.Equal(LocalAdminAnalyzer.AccountDecision.Unlisted,
LocalAdminAnalyzer.Decide("Public", MachineSidPrefix + "1010", isAdmin: false, entries));
Assert.Contains(entries, e => e.Pattern == "Public" && e.ProfileFolderOnly);
}
// -------------------------------------------------------------- accounts WMI did not return
[Fact]
public void Administrators_members_missing_from_wmi_are_judged_as_administrators()
{
var members = new List<LocalGroupMember>
{
Member("Administrator", 500),
Member("WsiAccount", 1001),
Member("Gast", 501),
Member("adm-4711", 1009),
};
var result = Evaluate(new List<LocalAdminAnalyzer.LocalAccountInfo>(), members, Entries("adm-*"));
Assert.Equal(new[] { "WsiAccount", "Gast" }, result.RoleViolations);
Assert.Equal(new[] { "WsiAccount", "Gast" }, result.Unexpected);
Assert.Equal(new[] { "WsiAccount", "Gast" }, result.UnexpectedAdminMembers);
}
[Fact]
public void A_member_wmi_already_returned_is_not_judged_twice()
{
var result = Evaluate(
new[] { Account("backdoor", 1011) },
new List<LocalGroupMember> { Member("backdoor", 1011) },
Entries());
Assert.Equal(new[] { "backdoor" }, result.Unexpected);
Assert.Equal(new[] { "backdoor" }, result.UnexpectedAdminMembers);
}
[Fact]
public void A_login_never_allows_an_account_not_even_when_wmi_failed()
{
// WMI failed: the split cannot recognise "backdoor" as local and allows it dynamically.
// The dynamic entry is folder-only, so the signed-in backdoor administrator is still found.
var split = LocalAdminAnalyzer.SplitLoggedInUsers(new[] { "backdoor" }, null!);
var entries = Entries();
entries.AddRange(split.Allowed.Select(u => new LocalAdminAnalyzer.AllowedEntry(u, LocalAccountRole.Any, profileFolderOnly: true)));
var result = Evaluate(new List<LocalAdminAnalyzer.LocalAccountInfo>(), new List<LocalGroupMember> { Member("backdoor", 1011) }, entries);
Assert.Equal(new[] { "backdoor" }, result.UnexpectedAdminMembers);
Assert.Equal(new[] { "backdoor" }, result.Unexpected);
}
// -------------------------------------------------------------- the entry list
[Fact]
public void Entries_carry_the_builtins_and_skip_invalid_tenant_entries()
{
var ignored = new List<string>();
var entries = LocalAdminAnalyzer.BuildAllowedEntries(
new[] { "kiosk|user", "x|admin", "|user", "legacy*", "CONTOSO\\admin", " ", "Guest|user" }, ignored);
Assert.Equal(new[] { "x|admin", "|user" }, ignored);
var accounts = entries.Where(e => !e.ProfileFolderOnly).Select(e => e.Display).ToList();
Assert.Contains("WsiAccount|user", accounts);
Assert.Contains("kioskUser0|user", accounts);
Assert.Contains("defaultuser0", accounts);
Assert.Contains("kiosk|user", accounts);
Assert.Contains("legacy*", accounts);
Assert.Contains("CONTOSO\\admin", accounts);
Assert.Single(accounts, a => a == "Guest|user");
Assert.DoesNotContain("Public", accounts);
Assert.Contains(entries, e => e.Pattern == "All Users" && e.ProfileFolderOnly);
}
// -------------------------------------------------------------- scoring
[Fact]
public void Score_follows_the_signals()
{
var none = new List<string>();
var backdoor = new List<string> { "backdoor" };
Assert.Equal(0, LocalAdminAnalyzer.ComputeConfidenceScore(false, none, none, backdoor));
Assert.Equal(20, LocalAdminAnalyzer.ComputeConfidenceScore(true, none, none, none));
Assert.Equal(40, LocalAdminAnalyzer.ComputeConfidenceScore(false, backdoor, none, none));
Assert.Equal(80, LocalAdminAnalyzer.ComputeConfidenceScore(false, backdoor, backdoor, none));
Assert.Equal(80, LocalAdminAnalyzer.ComputeConfidenceScore(false, backdoor, none, new List<string> { "BACKDOOR" }));
Assert.Equal(100, LocalAdminAnalyzer.ComputeConfidenceScore(true, backdoor, backdoor, backdoor));
}
}
}
@@ -3,6 +3,7 @@ using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime;
using AutopilotMonitor.Agent.V2.Core.Orchestration;
@@ -13,6 +14,8 @@ using AutopilotMonitor.DecisionCore.Signals;
using Xunit;
using SharedEventTypes = AutopilotMonitor.Shared.Constants.EventTypes;
#pragma warning disable xUnit1031 // one test waits on a task on purpose: a blocked call is the failure it looks for
namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Ime
{
/// <summary>
@@ -137,6 +140,12 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Ime
public void Dispose()
{
Watcher.Dispose();
ReleaseProcessesAndFiles();
}
/// <summary>Teardown that leaves the watcher alone — for a test that found its Dispose blocked.</summary>
public void ReleaseProcessesAndFiles()
{
foreach (var p in Running)
{
try { if (!p.HasExited) p.Kill(); } catch { }
@@ -210,6 +219,48 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Ime
Assert.Equal(new object[] { first.Id, second.Id }, pids);
}
[Fact]
public void Dispose_returns_while_the_exit_of_the_attached_process_is_being_delivered()
{
var f = new Fixture();
var child = f.Spawn(trusted: true);
// The watcher gets a Process object that already carries a handler. .NET runs that one
// first and holds its own lock on the Process object for as long as it delivers Exited.
var delivering = new ManualResetEventSlim(false);
var release = new ManualResetEventSlim(false);
f.Watcher.ProcessSource = () =>
{
var handle = Process.GetProcessById(child.Id);
handle.EnableRaisingEvents = true;
handle.Exited += (_, __) => { delivering.Set(); release.Wait(TimeSpan.FromSeconds(10)); };
return new[] { handle };
};
f.Watcher.TryAttachNow();
Assert.Equal(child.Id, f.Watcher.AttachedProcessId);
Task dispose;
try
{
child.Kill();
Assert.True(delivering.Wait(TimeSpan.FromSeconds(10)), "the exit was not delivered");
dispose = Task.Run(() => f.Watcher.Dispose());
Thread.Sleep(300); // let Dispose reach the Process object
}
finally
{
release.Set();
}
var returned = dispose.Wait(TimeSpan.FromSeconds(10));
// A blocked Dispose holds the watcher's lock for good; disposing the watcher again would
// hang the test run instead of failing this test.
f.ReleaseProcessesAndFiles();
Assert.True(returned,
"Dispose and the exit delivery blocked each other: the Process is disposed under the watcher's lock");
}
[Fact]
public void With_spoof_and_service_both_running_the_service_wins_regardless_of_order()
{
@@ -2,11 +2,14 @@
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office;
using AutopilotMonitor.Agent.V2.Core.Tests.Harness;
using Xunit;
#pragma warning disable xUnit1031 // one test waits on tasks on purpose: a blocked call is the failure it looks for
namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Office
{
/// <summary>
@@ -148,6 +151,35 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Office
Assert.Equal(afterDispose, Volatile.Read(ref raises)); // no raises after dispose
}
[Fact]
public void Dispose_from_another_thread_returns_while_the_initial_scan_handler_is_running()
{
using var tmp = new TempDirectory();
LayDownCoreBinary(tmp.Path); // the initial scan in Start() finds it and raises
var watcher = new OfficeBinaryWatcher(tmp.Path, CoreBinaries, NewLogger(tmp.Path));
using var entered = new ManualResetEventSlim(false);
using var release = new ManualResetEventSlim(false);
watcher.BinaryAppeared += (_, __) => { entered.Set(); release.Wait(TimeSpan.FromSeconds(10)); };
var start = Task.Run(() => watcher.Start());
try
{
Assert.True(entered.Wait(TimeSpan.FromSeconds(5)), "initial scan did not raise");
var dispose = Task.Run(() => watcher.Dispose());
Assert.True(dispose.Wait(TimeSpan.FromSeconds(5)),
"Dispose waited for the running handler: the watcher's lock is held while BinaryAppeared is raised");
}
finally
{
release.Set();
start.Wait(TimeSpan.FromSeconds(10));
watcher.Dispose();
}
}
private static bool SpinUntil(Func<bool> condition, int timeoutMs)
{
var deadline = Environment.TickCount + timeoutMs;
@@ -0,0 +1,179 @@
#nullable enable
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Threading;
using System.Threading.Tasks;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office;
using AutopilotMonitor.Agent.V2.Core.Tests.Harness;
using Xunit;
#pragma warning disable xUnit1031 // the tests wait on tasks on purpose: a blocked call is the failure they look for
namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Office
{
/// <summary>
/// <see cref="OfficeProcessWatcher"/> with stand-in worker processes handed in through the
/// startup probe (the WMI start trace is never armed here, as in the sibling watchers' tests).
/// Covers the worker window (started / stopped) and the two ways a worker's exit used to go
/// wrong: disposing the watcher while the exit is being delivered, and a worker that was
/// already gone when the watcher subscribed.
/// </summary>
[Collection("SerialThreading")] // Process.Exited is delivered on the shared ThreadPool
public sealed class OfficeProcessWatcherTests : IDisposable
{
private static readonly TimeSpan Timeout = TimeSpan.FromSeconds(10);
private readonly TempDirectory _tmp = new TempDirectory();
private readonly AgentLogger _logger;
private readonly List<Process> _spawned = new List<Process>();
public OfficeProcessWatcherTests()
{
_logger = new AgentLogger(_tmp.Path, AgentLogLevel.Info);
}
public void Dispose()
{
foreach (var p in _spawned)
{
try { if (!p.HasExited) p.Kill(); } catch { }
try { p.Dispose(); } catch { }
}
_tmp.Dispose();
}
/// <summary>A stand-in worker that blocks on stdin until killed.</summary>
private Process Spawn()
{
var p = Process.Start(new ProcessStartInfo("cmd.exe", "/c pause")
{
UseShellExecute = false,
RedirectStandardInput = true,
RedirectStandardOutput = true,
CreateNoWindow = true,
});
Assert.NotNull(p);
_spawned.Add(p!);
return p!;
}
/// <summary>A second handle on the same process — what the watcher would have opened itself.</summary>
private static Process HandleOn(Process child)
{
var handle = Process.GetProcessById(child.Id);
handle.EnableRaisingEvents = true;
return handle;
}
/// <summary>Starts the watcher with <paramref name="handle"/> as the one running worker.</summary>
private static void StartWith(OfficeProcessWatcher watcher, Process handle)
{
watcher.WorkerSource = () => new[] { handle };
watcher.Start(armWmi: false);
}
[Fact]
public void A_running_worker_is_reported_before_Start_returns_and_its_exit_closes_the_window()
{
using var watcher = new OfficeProcessWatcher(_logger, settleSeconds: 0);
using var started = new ManualResetEventSlim(false);
using var stopped = new ManualResetEventSlim(false);
watcher.Started += (_, __) => started.Set();
watcher.Stopped += (_, __) => stopped.Set();
var child = Spawn();
StartWith(watcher, HandleOn(child));
Assert.True(started.IsSet, "Started was not raised by the startup probe");
Assert.True(watcher.IsActive);
child.Kill();
Assert.True(stopped.Wait(Timeout), "Stopped was not raised after the last worker exited");
Assert.False(watcher.IsActive);
}
[Fact]
public void Dispose_returns_while_the_exit_of_a_tracked_worker_is_being_delivered()
{
var watcher = new OfficeProcessWatcher(_logger, settleSeconds: 0);
var child = Spawn();
var handle = HandleOn(child);
// Subscribed before the watcher, so .NET runs it first — and .NET holds its own lock on
// the Process object for as long as it delivers Exited.
using var delivering = new ManualResetEventSlim(false);
using var release = new ManualResetEventSlim(false);
handle.Exited += (_, __) => { delivering.Set(); release.Wait(Timeout); };
StartWith(watcher, handle);
Task dispose;
try
{
child.Kill();
Assert.True(delivering.Wait(Timeout), "the worker's exit was not delivered");
dispose = Task.Run(() => watcher.Dispose());
Thread.Sleep(300); // let Dispose reach the Process object
}
finally
{
release.Set();
}
Assert.True(dispose.Wait(Timeout),
"Dispose and the exit delivery blocked each other: the Process is disposed under the watcher's lock");
}
[Fact]
public void A_worker_that_was_already_gone_when_the_watcher_subscribed_still_closes_the_window()
{
using var watcher = new OfficeProcessWatcher(_logger, settleSeconds: 0);
using var stopped = new ManualResetEventSlim(false);
watcher.Stopped += (_, __) => stopped.Set();
var child = Spawn();
var handle = HandleOn(child);
using var exitDelivered = new ManualResetEventSlim(false);
handle.Exited += (_, __) => exitDelivered.Set();
child.Kill();
// .NET raises Exited once per Process object. After this, a later subscriber never hears it.
Assert.True(exitDelivered.Wait(Timeout), "the stand-in's exit was not delivered");
StartWith(watcher, handle);
Assert.True(stopped.Wait(Timeout),
"the window never closed: the worker exited before the watcher subscribed to Exited");
Assert.False(watcher.IsActive);
}
[Fact]
public void A_traced_id_that_belongs_to_another_program_is_not_tracked()
{
// The start trace arrives late: by then the id can belong to an unrelated process.
using var watcher = new OfficeProcessWatcher(_logger, settleSeconds: 0);
watcher.WorkerSource = () => Array.Empty<Process>();
watcher.Start(armWmi: false);
var child = Spawn();
watcher.TrackTracedProcess(child.Id, "OfficeC2RClient");
Assert.False(watcher.IsActive);
}
[Fact]
public void A_traced_id_that_still_carries_the_expected_name_is_tracked()
{
using var watcher = new OfficeProcessWatcher(_logger, settleSeconds: 0);
watcher.WorkerSource = () => Array.Empty<Process>();
watcher.Start(armWmi: false);
var child = Spawn();
watcher.TrackTracedProcess(child.Id, "cmd");
Assert.True(watcher.IsActive);
}
}
}
@@ -0,0 +1,199 @@
#nullable enable
using System;
using System.Threading;
using System.Threading.Tasks;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office;
using AutopilotMonitor.Agent.V2.Core.Tests.Harness;
using Microsoft.Win32;
using Xunit;
#pragma warning disable xUnit1031 // the tests wait on tasks on purpose: a blocked call is the failure they look for
namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Office
{
/// <summary>
/// <see cref="RegistryChangeWatcher"/> against a real key under HKCU (no elevation needed).
/// The watcher's lock is a leaf lock: <c>Changed</c> is raised with the lock free, so a
/// handler can take other locks or dispose the watcher, and <c>Dispose</c> never waits for a
/// handler. One handler runs at a time, and a change that arrives while it runs is reported
/// after it returns.
/// </summary>
[Collection("SerialThreading")] // callbacks arrive on the shared ThreadPool
public sealed class RegistryChangeWatcherTests : IDisposable
{
private const string RootSubKey = @"SOFTWARE\AutopilotMonitor.Tests\OfficeRegistryChangeWatcher";
private const string TargetSubKey = RootSubKey + @"\Target";
private const uint RegNotifyThreadAgnostic = 0x10000000;
private static readonly TimeSpan Timeout = TimeSpan.FromSeconds(10);
private readonly TempDirectory _tmp = new TempDirectory();
private readonly AgentLogger _logger;
public RegistryChangeWatcherTests()
{
_logger = new AgentLogger(_tmp.Path, AgentLogLevel.Info);
DeleteTestKeys();
using (var root = Registry.CurrentUser.CreateSubKey(RootSubKey)) Assert.NotNull(root);
}
public void Dispose()
{
DeleteTestKeys();
_tmp.Dispose();
}
private static void DeleteTestKeys()
{
try { Registry.CurrentUser.DeleteSubKeyTree(RootSubKey, throwOnMissingSubKey: false); }
catch { /* teardown noise must not fail a test */ }
}
private static void CreateTarget()
{
using (var key = Registry.CurrentUser.CreateSubKey(TargetSubKey)) Assert.NotNull(key);
}
private static void WriteValue(string name)
{
using (var key = Registry.CurrentUser.OpenSubKey(TargetSubKey, writable: true))
{
Assert.NotNull(key);
key!.SetValue(name, Guid.NewGuid().ToString("N"));
}
}
private RegistryChangeWatcher NewWatcher() =>
new RegistryChangeWatcher(RegistryHive.CurrentUser, TargetSubKey, _logger);
[Fact]
public void Changed_fires_when_a_value_is_written_under_the_target()
{
CreateTarget();
using var watcher = NewWatcher();
using var fired = new ManualResetEventSlim(false);
watcher.Changed += (_, __) => fired.Set();
watcher.Start();
WriteValue("Probe");
Assert.True(fired.Wait(Timeout), "Changed did not fire for a value write under the target key");
}
[Fact]
public void Changed_fires_once_a_missing_target_key_appears()
{
using var watcher = NewWatcher();
using var fired = new ManualResetEventSlim(false);
watcher.Changed += (_, __) => fired.Set();
watcher.Start(); // target absent: watches the parent for a new child key
CreateTarget();
Assert.True(fired.Wait(Timeout), "Changed did not fire when the target key appeared");
}
[Fact]
public void Dispose_from_another_thread_returns_while_a_handler_is_running()
{
CreateTarget();
var watcher = NewWatcher();
using var entered = new ManualResetEventSlim(false);
using var release = new ManualResetEventSlim(false);
watcher.Changed += (_, __) => { entered.Set(); release.Wait(Timeout); };
try
{
watcher.Start();
WriteValue("Probe");
Assert.True(entered.Wait(Timeout), "handler was not invoked");
var dispose = Task.Run(() => watcher.Dispose());
Assert.True(dispose.Wait(TimeSpan.FromSeconds(5)),
"Dispose waited for the running handler: the watcher's lock is held while Changed is raised");
}
finally
{
release.Set();
watcher.Dispose();
}
}
[Fact]
public void A_handler_may_dispose_its_own_watcher()
{
CreateTarget();
var watcher = NewWatcher();
using var disposedInHandler = new ManualResetEventSlim(false);
int calls = 0;
watcher.Changed += (_, __) =>
{
Interlocked.Increment(ref calls);
watcher.Dispose();
disposedInHandler.Set();
};
watcher.Start();
WriteValue("First");
Assert.True(disposedInHandler.Wait(Timeout), "handler did not return from disposing its watcher");
WriteValue("Second");
Thread.Sleep(300);
Assert.Equal(1, Volatile.Read(ref calls)); // a disposed watcher stays quiet
}
[Fact]
public void Handlers_never_overlap_and_a_change_during_a_handler_is_reported_after_it()
{
CreateTarget();
using var watcher = NewWatcher();
using var firstEntered = new ManualResetEventSlim(false);
using var release = new ManualResetEventSlim(false);
using var second = new ManualResetEventSlim(false);
int calls = 0, running = 0, maxRunning = 0;
watcher.Changed += (_, __) =>
{
var now = Interlocked.Increment(ref running);
int seen;
while (now > (seen = Volatile.Read(ref maxRunning)))
Interlocked.CompareExchange(ref maxRunning, now, seen);
if (Interlocked.Increment(ref calls) == 1)
{
firstEntered.Set();
release.Wait(Timeout);
}
else
{
second.Set();
}
Interlocked.Decrement(ref running);
};
watcher.Start();
WriteValue("First");
Assert.True(firstEntered.Wait(Timeout), "handler was not invoked");
WriteValue("DuringHandler");
Thread.Sleep(300);
Assert.Equal(1, Volatile.Read(ref calls)); // no second handler while the first runs
release.Set();
Assert.True(second.Wait(Timeout), "the change that arrived during the handler was never reported");
Assert.Equal(1, Volatile.Read(ref maxRunning));
}
[Fact]
public void Target_watch_is_not_tied_to_the_arming_thread()
{
using var watcher = NewWatcher();
// Re-arming happens on rotating ThreadPool threads. Without this flag Windows signals
// the event when such a thread ends, which looks like a change that never happened.
Assert.True((watcher.EffectivePrimaryFilter & RegNotifyThreadAgnostic) != 0,
"the target watch must carry REG_NOTIFY_THREAD_AGNOSTIC");
}
}
}
@@ -1,6 +1,7 @@
#nullable enable
using System;
using System.Collections.Generic;
using System.Linq;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security;
using AutopilotMonitor.Agent.V2.Core.Tests.Harness;
@@ -10,14 +11,20 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Security
{
/// <summary>
/// ConsoleBypassWatcher classification — driven via the internal <c>HandleStart</c>/<c>Classify</c>
/// with an injected process probe (no real WMI / processes). Asserts the parent-free discriminator:
/// an interactive-session cmd with a bare command line is flagged (high confidence); a scripted
/// <c>cmd /c</c> and a session-0 (service) cmd are ignored; an interactive-session cmd whose command
/// line cannot be read (instant-close race) is still surfaced at low confidence.
/// with injected probes (no real WMI / processes). A console that is still running when probed is
/// reported: bare command line (high confidence), <c>/k</c> or unreadable (low). A scripted
/// <c>cmd /c</c> and a session-0 cmd are ignored. A start whose process is gone, or whose id now
/// belongs to another process, is counted as script activity and never reported as a console.
/// </summary>
public sealed class ConsoleBypassWatcherTests
{
private const string Cmd = "cmd.exe";
private const string BareCmd = @"C:\WINDOWS\system32\cmd.exe";
private const string OobeAccount = "S-1-5-21-1-2-3-1000";
private const string Created = "20261111143453.119277+060";
private const int Pid = 9636;
private const int Parent = 9016;
private static readonly DateTime At = new DateTime(2026, 11, 11, 14, 34, 53, DateTimeKind.Utc);
private static AgentLogger NewLogger(string dir) => new AgentLogger(dir, AgentLogLevel.Info);
@@ -25,59 +32,67 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Security
{
private readonly TempDirectory _tmp = new TempDirectory();
public List<ConsoleSpawnInfo> Detected { get; } = new List<ConsoleSpawnInfo>();
public List<int> ParentLookups { get; } = new List<int>();
public int WindowsOpened { get; private set; }
public ConsoleBypassWatcher Sut { get; }
public Rig(Func<int, ProcessProbe?> probe)
public Rig(Func<int, string, ProcessProbe?> probe, bool alive = true, Func<int, string?>? parentName = null)
{
Sut = new ConsoleBypassWatcher(NewLogger(_tmp.Path), probe);
Sut = new ConsoleBypassWatcher(
NewLogger(_tmp.Path),
probe,
isAlive: _ => alive,
parentName: pid => { ParentLookups.Add(pid); return parentName?.Invoke(pid); },
utcNow: () => At);
Sut.BypassConsoleDetected += (_, info) => Detected.Add(info);
Sut.ScriptActivityStarted += (_, __) => WindowsOpened++;
}
public void Trace(int pid = Pid, int parentPid = Parent, int sessionId = 1, string? ownerSid = OobeAccount) =>
Sut.HandleStart(pid, parentPid, sessionId, ownerSid, "process_start_trace", Cmd);
public void Dispose() { Sut.Dispose(); _tmp.Dispose(); }
}
private static Func<int, ProcessProbe?> Probe(string? commandLine, string? owner = @"PC\defaultuser0")
=> _ => new ProcessProbe(commandLine, owner);
/// <summary>A running process that is the traced one, with the given command line.</summary>
private static Func<int, string, ProcessProbe?> Running(
string? commandLine, string name = Cmd, int sessionId = 1, int parentPid = Parent, string creationDate = Created)
=> (_, __) => new ProcessProbe(name, sessionId, parentPid, commandLine, creationDate);
private static readonly Func<int, ProcessProbe?> GoneProbe = _ => null;
/// <summary>The process has exited before it could be read.</summary>
private static readonly Func<int, string, ProcessProbe?> Gone = (_, __) => null;
// ---------------------------------------------------------------- HandleStart end-to-end
// ---------------------------------------------------------------- consoles that are reported
[Fact]
public void Interactive_session_bare_cmd_raises_high_confidence_with_signature()
{
using var rig = new Rig(Probe(BareCmd, owner: @"PC\defaultuser0"));
using var rig = new Rig(Running(BareCmd), parentName: _ => "explorer.exe");
rig.Sut.HandleStart(pid: 9636, parentPid: 9016, sessionId: 1, ownerSidHint: null, detectedVia: "process_start_trace");
rig.Trace();
var info = Assert.Single(rig.Detected);
Assert.Equal("cmd.exe", info.ProcessName);
Assert.Equal(9636, info.ProcessId);
Assert.Equal(9016, info.ParentProcessId);
Assert.Equal(Cmd, info.ProcessName);
Assert.Equal(Pid, info.ProcessId);
Assert.Equal(Parent, info.ParentProcessId);
Assert.Equal("explorer.exe", info.ParentProcessName);
Assert.Equal(1, info.SessionId);
Assert.Equal("high", info.Confidence);
Assert.Equal("interactive_console", info.Classification);
Assert.Equal(@"PC\defaultuser0", info.Owner);
Assert.Equal(OobeAccount, info.Owner);
Assert.Equal(BareCmd, info.CommandLine);
Assert.Null(rig.Sut.TakeScriptActivity());
}
[Fact]
public void Session_zero_cmd_is_ignored_even_when_bare()
public void A_console_whose_launcher_is_gone_has_no_parent_name()
{
// IME / Intune install cmd run as SYSTEM in session 0 — never an interactive console.
using var rig = new Rig(Probe(BareCmd));
rig.Sut.HandleStart(1234, 1, sessionId: 0, ownerSidHint: null, detectedVia: "process_start_trace");
Assert.Empty(rig.Detected);
}
// The launcher behind Shift+F10 exits within milliseconds.
using var rig = new Rig(Running(BareCmd));
[Theory]
[InlineData(@"C:\WINDOWS\system32\cmd.exe /c ""install.bat""")]
[InlineData(@"cmd.exe /C ping")]
public void Scripted_cmd_is_ignored(string commandLine)
{
using var rig = new Rig(Probe(commandLine));
rig.Sut.HandleStart(2222, 1, sessionId: 1, ownerSidHint: null, detectedVia: "process_start_trace");
Assert.Empty(rig.Detected);
rig.Trace();
Assert.Null(Assert.Single(rig.Detected).ParentProcessName);
}
[Fact]
@@ -85,9 +100,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Security
{
// L12: /k runs its command and then leaves a fully interactive shell — a deliberate
// false-negative seam if ignored (e.g. a technician-planted `cmd /k whoami`).
using var rig = new Rig(Probe(@"cmd.exe /k whoami"));
using var rig = new Rig(Running(@"cmd.exe /k whoami"));
rig.Sut.HandleStart(2222, 1, sessionId: 1, ownerSidHint: null, detectedVia: "process_start_trace");
rig.Trace();
var info = Assert.Single(rig.Detected);
Assert.Equal("low", info.Confidence);
@@ -101,9 +116,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Security
{
// cmd.exe honors only the FIRST /c-or-/k switch; a '/c' inside the /k payload is inert, so
// the console is a persistent human-usable shell and must still be surfaced (low confidence).
using var rig = new Rig(Probe(commandLine));
using var rig = new Rig(Running(commandLine));
rig.Sut.HandleStart(2223, 1, sessionId: 1, ownerSidHint: null, detectedVia: "process_start_trace");
rig.Trace();
var info = Assert.Single(rig.Detected);
Assert.Equal("low", info.Confidence);
@@ -111,88 +126,317 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Security
}
[Fact]
public void Instant_close_unreadable_commandline_raises_low_confidence()
public void A_running_process_without_a_readable_command_line_raises_low_confidence()
{
// Win32_Process query loses the race (process already exited). SessionID from the trace is
// still known, so the console is surfaced — low confidence, owner from the trace SID hint.
using var rig = new Rig(GoneProbe);
using var rig = new Rig(Running(commandLine: null), alive: true);
rig.Sut.HandleStart(9636, 9016, sessionId: 1, ownerSidHint: "S-1-5-18", detectedVia: "process_start_trace");
rig.Trace();
var info = Assert.Single(rig.Detected);
Assert.Equal("low", info.Confidence);
Assert.Equal("interactive_session_unclassified", info.Classification);
Assert.Equal("S-1-5-18", info.Owner);
Assert.Null(info.CommandLine);
Assert.Null(rig.Sut.TakeScriptActivity());
}
[Fact]
public void Owner_prefers_probe_over_trace_hint()
public void A_running_process_that_could_not_be_read_at_all_raises_low_confidence()
{
using var rig = new Rig(Probe(BareCmd, owner: @"PC\defaultuser0"));
rig.Sut.HandleStart(9636, 9016, sessionId: 1, ownerSidHint: "S-1-5-18", detectedVia: "process_start_trace");
Assert.Equal(@"PC\defaultuser0", Assert.Single(rig.Detected).Owner);
// The query failed. That says nothing about the process: it is reported, never counted away.
using var rig = new Rig((_, __) => ProcessProbe.Unreadable, alive: true);
rig.Trace();
var info = Assert.Single(rig.Detected);
Assert.Equal("low", info.Confidence);
Assert.Equal("interactive_session_unclassified", info.Classification);
Assert.Equal(OobeAccount, info.Owner);
Assert.Null(rig.Sut.TakeScriptActivity());
}
// ---------------------------------------------------------------- starts that are ignored
[Fact]
public void Same_pid_seen_twice_raises_only_once()
public void Session_zero_cmd_is_ignored_even_when_bare()
{
// The startup probe and the live trace can both observe the same still-open console.
using var rig = new Rig(Probe(BareCmd));
rig.Sut.HandleStart(9636, 9016, 1, null, "startup_probe");
rig.Sut.HandleStart(9636, 9016, 1, null, "process_start_trace");
Assert.Single(rig.Detected);
// IME / Intune install cmd run as SYSTEM in session 0 — never an interactive console.
using var rig = new Rig(Running(BareCmd));
rig.Trace(sessionId: 0);
Assert.Empty(rig.Detected);
Assert.Null(rig.Sut.TakeScriptActivity());
}
[Theory]
[InlineData(@"C:\WINDOWS\system32\cmd.exe /c ""install.bat""")]
[InlineData(@"cmd.exe /C ping")]
public void A_running_scripted_cmd_is_neither_reported_nor_counted(string commandLine)
{
using var rig = new Rig(Running(commandLine));
rig.Trace();
Assert.Empty(rig.Detected);
Assert.Null(rig.Sut.TakeScriptActivity());
}
[Fact]
public void Invalid_pid_is_ignored()
{
using var rig = new Rig(Probe(BareCmd));
rig.Sut.HandleStart(0, 9016, 1, null, "process_start_trace");
using var rig = new Rig(Running(BareCmd));
rig.Trace(pid: 0);
Assert.Empty(rig.Detected);
Assert.Null(rig.Sut.TakeScriptActivity());
}
// ---------------------------------------------------------------- starts that are counted
[Fact]
public void A_process_that_has_exited_is_counted_and_not_reported()
{
// WMI delivers the start about a second late; a scripted cmd /c is gone by then. That is
// script activity, not a console someone types into.
using var rig = new Rig(Gone, parentName: _ => "powershell.exe");
rig.Trace();
Assert.Empty(rig.Detected);
var activity = rig.Sut.TakeScriptActivity()!;
Assert.Equal(1, activity.Count);
Assert.Equal(Cmd, activity.ProcessName);
Assert.Equal(At, activity.FirstSeenUtc);
Assert.Equal(new[] { 1 }, activity.WindowsSessions);
Assert.Equal(new[] { OobeAccount }, activity.Owners);
var parent = Assert.Single(activity.Parents);
Assert.Equal(Parent, parent.ProcessId);
Assert.Equal("powershell.exe", parent.Name);
}
[Theory]
[InlineData("SearchFilterHost.exe", 1, Parent)] // another program was given the id
[InlineData(Cmd, 0, Parent)] // a service-session cmd was given the id
[InlineData(Cmd, 1, 4242)] // a cmd of another parent was given the id
public void An_id_that_now_belongs_to_another_process_is_counted_and_not_reported(string name, int sessionId, int parentPid)
{
// Its command line has no /c, which used to read as a bare interactive console.
using var rig = new Rig(Running(@"C:\Windows\System32\other.exe -Embedding", name, sessionId, parentPid));
rig.Trace();
Assert.Empty(rig.Detected);
Assert.Equal(1, rig.Sut.TakeScriptActivity()!.Count);
}
[Fact]
public void A_row_without_a_command_line_whose_process_has_ended_is_counted()
{
using var rig = new Rig(Running(commandLine: null), alive: false);
rig.Trace();
Assert.Empty(rig.Detected);
Assert.Equal(1, rig.Sut.TakeScriptActivity()!.Count);
}
[Fact]
public void A_process_that_could_not_be_read_and_is_gone_at_the_second_look_is_counted()
{
using var rig = new Rig((_, __) => ProcessProbe.Unreadable, alive: false);
rig.Trace();
Assert.Empty(rig.Detected);
Assert.Equal(1, rig.Sut.TakeScriptActivity()!.Count);
}
[Fact]
public void A_burst_opens_one_window_and_asks_for_each_parent_once()
{
using var rig = new Rig(Gone, parentName: _ => "python.exe");
for (var i = 0; i < 25; i++) rig.Trace(pid: 5000 + i, parentPid: 2688);
for (var i = 0; i < 21; i++) rig.Trace(pid: 6000 + i, parentPid: 9296);
Assert.Empty(rig.Detected);
Assert.Equal(1, rig.WindowsOpened);
Assert.Equal(new[] { 2688, 9296 }, rig.ParentLookups);
var activity = rig.Sut.TakeScriptActivity()!;
Assert.Equal(46, activity.Count);
Assert.Equal(new[] { 25, 21 }, activity.Parents.Select(p => p.Children));
}
[Fact]
public void The_next_start_after_the_content_was_taken_opens_a_new_window()
{
using var rig = new Rig(Gone);
rig.Trace(pid: 1);
rig.Trace(pid: 2);
rig.Sut.TakeScriptActivity();
rig.Trace(pid: 3);
Assert.Equal(2, rig.WindowsOpened);
Assert.Equal(1, rig.Sut.TakeScriptActivity()!.Count);
}
[Fact]
public void Nothing_is_reported_or_counted_after_dispose()
{
var rig = new Rig(Gone);
rig.Sut.Dispose();
rig.Trace();
Assert.Empty(rig.Detected);
Assert.Null(rig.Sut.TakeScriptActivity());
rig.Dispose();
}
// ---------------------------------------------------------------- de-duplication
[Fact]
public void The_same_process_seen_by_startup_probe_and_trace_raises_only_once()
{
// The startup probe and the live trace can both observe the same still-open console.
using var rig = new Rig(Running(BareCmd));
rig.Sut.HandleProbed(Pid, Parent, 1, OobeAccount, "startup_probe", Cmd, new ProcessProbe(Cmd, 1, Parent, BareCmd, Created));
rig.Trace();
Assert.Equal("startup_probe", Assert.Single(rig.Detected).DetectedVia);
}
[Fact]
public void A_later_console_that_was_given_an_id_seen_before_is_reported_again()
{
var created = Created;
using var rig = new Rig((_, __) => new ProcessProbe(Cmd, 1, Parent, BareCmd, created));
rig.Trace();
created = "20261111150324.504661+060";
rig.Trace();
Assert.Equal(2, rig.Detected.Count);
}
// ---------------------------------------------------------------- the probe's decision
private static readonly ProcessProbe Row = new ProcessProbe(Cmd, 1, Parent, BareCmd, Created);
[Theory]
[InlineData("NotRunning")]
[InlineData("OtherImage")]
public void The_probe_says_gone_only_when_the_process_list_is_certain(string listed)
{
var asked = false;
var state = (ConsoleBypassWatcher.ListedAs)Enum.Parse(typeof(ConsoleBypassWatcher.ListedAs), listed);
var probe = ConsoleBypassWatcher.Probe(Pid, state, _ => { asked = true; return Row; });
Assert.Null(probe);
Assert.False(asked, "a process that is certainly gone costs no query");
}
[Theory]
[InlineData("Expected")]
[InlineData("Unknown")]
public void The_probe_returns_the_row_of_a_process_that_may_still_run(string listed)
{
var state = (ConsoleBypassWatcher.ListedAs)Enum.Parse(typeof(ConsoleBypassWatcher.ListedAs), listed);
Assert.Same(Row, ConsoleBypassWatcher.Probe(Pid, state, _ => Row));
}
[Fact]
public void A_failed_query_is_unreadable_and_never_gone()
{
var probe = ConsoleBypassWatcher.Probe(
Pid, ConsoleBypassWatcher.ListedAs.Expected, _ => throw new InvalidOperationException("WinMgmt did not answer"));
Assert.Same(ProcessProbe.Unreadable, probe);
}
[Fact]
public void A_query_without_a_row_is_unreadable_and_never_gone()
{
var probe = ConsoleBypassWatcher.Probe(Pid, ConsoleBypassWatcher.ListedAs.Expected, _ => null);
Assert.Same(ProcessProbe.Unreadable, probe);
}
[Fact]
public void The_process_list_tells_running_other_image_and_not_running_apart()
{
using var me = System.Diagnostics.Process.GetCurrentProcess();
const int neverAProcessId = int.MaxValue;
Assert.Equal(ConsoleBypassWatcher.ListedAs.Expected, ConsoleBypassWatcher.ProcessListState(me.Id, me.ProcessName + ".exe"));
Assert.Equal(ConsoleBypassWatcher.ListedAs.OtherImage, ConsoleBypassWatcher.ProcessListState(me.Id, "not-" + me.ProcessName + ".exe"));
Assert.Equal(ConsoleBypassWatcher.ListedAs.NotRunning, ConsoleBypassWatcher.ProcessListState(neverAProcessId, Cmd));
Assert.True(ConsoleBypassWatcher.IsRunning(me.Id));
Assert.False(ConsoleBypassWatcher.IsRunning(neverAProcessId));
}
// ---------------------------------------------------------------- IsTracedProcess (pure)
[Theory]
[InlineData("cmd.exe", 1, Parent, true)]
[InlineData("CMD.EXE", 2, Parent, true)] // image name compares without case
[InlineData("cmd.exe", 1, 0, true)] // the row does not know its parent
// A fact that could not be read contradicts nothing — the process stays the traced one.
[InlineData(null, null, null, true)]
[InlineData(null, 1, Parent, true)]
[InlineData("cmd.exe", null, Parent, true)]
[InlineData("cmd.exe", 1, null, true)]
// A fact that was read and differs makes it another process.
[InlineData("conhost.exe", 1, Parent, false)]
[InlineData("cmd.exe", 0, Parent, false)]
[InlineData("cmd.exe", 1, 77, false)]
public void IsTracedProcess_compares_name_session_and_parent(string? name, int? sessionId, int? rowParent, bool expected)
{
var probe = new ProcessProbe(name, sessionId, rowParent, BareCmd, Created);
Assert.Equal(expected, ConsoleBypassWatcher.IsTracedProcess(probe, Cmd, Parent));
}
[Fact]
public void IsTracedProcess_accepts_any_parent_when_the_trace_has_none()
{
var probe = new ProcessProbe(Cmd, 1, 77, BareCmd, Created);
Assert.True(ConsoleBypassWatcher.IsTracedProcess(probe, Cmd, parentPid: 0));
}
// ---------------------------------------------------------------- Classify (pure)
[Theory]
[InlineData(0, BareCmd, "Ignore")] // service session
[InlineData(1, null, "UnclassifiedInteractive")] // instant-close
[InlineData(1, null, "UnclassifiedInteractive")] // running, command line not readable
[InlineData(1, BareCmd, "InteractiveConsole")] // bare shell
[InlineData(1, @"""C:\WINDOWS\system32\cmd.exe""", "InteractiveConsole")]
[InlineData(1, "", "InteractiveConsole")]
[InlineData(1, @"cmd.exe /d", "InteractiveConsole")] // /d skips AutoRun — still interactive
[InlineData(1, @"C:\cmd\cmd.exe", "InteractiveConsole")] // folder named 'cmd', not a switch
[InlineData(1, @"""C:/k/cmd.exe""", "InteractiveConsole")] // forward-slash path stripped before scan
[InlineData(1, @"cmd.exe /c foo", "Ignore")] // scripted, run-and-exit
[InlineData(1, @"cmd.exe /C whoami", "Ignore")]
[InlineData(1, @"""C:\WINDOWS\system32\cmd.exe"" /c ""x.bat""", "Ignore")]
[InlineData(2, @"C:\x\cmd.exe /K bar", "InteractiveWithCommand")] // L12: /k stays interactive
[InlineData(1, @"cmd.exe /k whoami", "InteractiveWithCommand")] // technician-planted shell
[InlineData(1, @"cmd.exe /k", "InteractiveWithCommand")]
[InlineData(1, @"cmd.exe /D/Q/K stay", "InteractiveWithCommand")] // combined run-and-stay
[InlineData(1, @"cmd.exe /d/q/c exit 9", "Ignore")] // combined run-and-exit wins
[InlineData(1, @"cmd /k rem /c", "InteractiveWithCommand")] // cmd.exe honors the FIRST switch: /k stays interactive
[InlineData(1, @"cmd.exe /k ""title /c""", "InteractiveWithCommand")] // /c inside the /k payload is not a switch
[InlineData(1, @"cmd /k /c", "InteractiveWithCommand")] // /c after /k is just the /k payload
[InlineData(1, @"cmd.exe /c cmd /k", "Ignore")] // first switch /c wins the other way round
[InlineData(1, @"cmd.exe /c rem /k", "Ignore")]
public void Classify_maps_session_and_commandline(int sessionId, string? commandLine, string expected)
{
Assert.Equal(expected, ConsoleBypassWatcher.Classify(sessionId, commandLine).ToString());
}
// ---------------------------------------------------------------- HasScriptArgument (pure)
[Theory]
[InlineData(@"C:\WINDOWS\system32\cmd.exe", false)]
[InlineData(@"""C:\WINDOWS\system32\cmd.exe""", false)]
[InlineData(@"cmd.exe /d", false)] // /d skips AutoRun — still interactive
[InlineData(@"C:\cmd\cmd.exe", false)] // folder named 'cmd', not a switch
[InlineData(@"""C:/k/cmd.exe""", false)] // forward-slash path stripped before scan
[InlineData("", false)]
[InlineData(@"cmd.exe /c whoami", true)]
[InlineData(@"cmd.exe /C whoami", true)]
[InlineData(@"cmd.exe /k", false)] // L12: /k leaves an interactive shell
[InlineData(@"cmd.exe /d/q/c exit 9", true)] // combined switches — the field case
[InlineData(@"cmd.exe /D/Q/K stay", false)] // L12: run-and-stay is not scripted
[InlineData(@"cmd.exe /k rem /c", false)] // first switch /k wins — payload /c is inert
[InlineData(@"cmd.exe /c rem /k", true)] // first switch /c wins
[InlineData(@"""C:\WINDOWS\system32\cmd.exe"" /c ""x.bat""", true)]
public void HasScriptArgument_detects_run_command_switch(string commandLine, bool expected)
{
Assert.Equal(expected, ConsoleBypassWatcher.HasScriptArgument(commandLine));
}
[Theory]
[InlineData(@"C:\WINDOWS\system32\cmd.exe", "")]
[InlineData(@"cmd.exe /d/q/c exit 9", "/d/q/c exit 9")]
@@ -0,0 +1,152 @@
#nullable enable
using System;
using System.Collections.Generic;
using System.Linq;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security;
using Xunit;
namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Security
{
/// <summary>
/// The tally behind <c>console_script_activity</c>: what it counts, what it lists and caps, and
/// that taking the content empties it.
/// </summary>
public sealed class ConsoleScriptActivityTallyTests
{
private static readonly DateTime At = new DateTime(2026, 11, 11, 14, 41, 35, DateTimeKind.Utc);
private const string Cmd = "cmd.exe";
private const string OobeAccount = "S-1-5-21-1-2-3-1000";
private static string? NoName(int pid) => null;
[Fact]
public void An_empty_tally_has_nothing_to_take()
{
Assert.Null(new ConsoleScriptActivityTally().Take());
}
[Fact]
public void Starts_are_counted_with_time_span_sessions_owners_and_parents()
{
var sut = new ConsoleScriptActivityTally();
sut.Add(Cmd, 101, 50, sessionId: 2, OobeAccount, At, _ => "powershell.exe");
sut.Add(Cmd, 102, 50, sessionId: 1, OobeAccount, At.AddSeconds(1), _ => "powershell.exe");
sut.Add(Cmd, 103, 60, sessionId: 1, "S-1-5-18", At.AddSeconds(9), _ => "setup.exe");
var a = sut.Take()!;
Assert.Equal(Cmd, a.ProcessName);
Assert.Equal(3, a.Count);
Assert.Equal(At, a.FirstSeenUtc);
Assert.Equal(At.AddSeconds(9), a.LastSeenUtc);
Assert.Equal(new[] { 1, 2 }, a.WindowsSessions);
Assert.Equal(new[] { OobeAccount, "S-1-5-18" }, a.Owners);
Assert.Equal(2, a.OwnersTotal);
Assert.Equal(2, a.ParentsTotal);
Assert.Equal(new[] { 50, 60 }, a.Parents.Select(p => p.ProcessId));
Assert.Equal(new[] { 2, 1 }, a.Parents.Select(p => p.Children));
Assert.Equal(new[] { "powershell.exe", "setup.exe" }, a.Parents.Select(p => p.Name));
}
[Fact]
public void Taking_empties_the_tally_and_the_next_start_opens_it_again()
{
var sut = new ConsoleScriptActivityTally();
Assert.True(sut.Add(Cmd, 101, 50, 1, OobeAccount, At, NoName));
Assert.False(sut.Add(Cmd, 102, 50, 1, OobeAccount, At, NoName));
Assert.Equal(2, sut.Take()!.Count);
Assert.Null(sut.Take());
Assert.True(sut.Add(Cmd, 103, 50, 1, OobeAccount, At, NoName));
Assert.Equal(1, sut.Take()!.Count);
}
[Fact]
public void A_parent_is_looked_up_once_even_when_the_lookup_finds_nothing()
{
var sut = new ConsoleScriptActivityTally();
var asked = new List<int>();
string? Lookup(int pid) { asked.Add(pid); return null; }
for (var i = 0; i < 5; i++) sut.Add(Cmd, 100 + i, 50, 1, OobeAccount, At, Lookup);
Assert.Equal(new[] { 50 }, asked);
var parent = Assert.Single(sut.Take()!.Parents);
Assert.Null(parent.Name);
Assert.Equal(5, parent.Children);
}
[Fact]
public void A_parent_that_was_counted_itself_is_named_without_a_lookup()
{
// A script shell that is already gone, and the children it started.
var sut = new ConsoleScriptActivityTally();
var asked = new List<int>();
string? Lookup(int pid) { asked.Add(pid); return "AgentExecutor.exe"; }
sut.Add(Cmd, 100, 50, 2, OobeAccount, At, Lookup);
for (var i = 1; i <= 6; i++) sut.Add(Cmd, 100 + i, 100, 2, OobeAccount, At, Lookup);
Assert.Equal(new[] { 50 }, asked);
var a = sut.Take()!;
Assert.Equal(7, a.Count);
Assert.Equal(new[] { 100, 50 }, a.Parents.Select(p => p.ProcessId));
Assert.Equal(new[] { Cmd, "AgentExecutor.exe" }, a.Parents.Select(p => p.Name));
}
[Fact]
public void Lookups_are_limited_per_window_and_allowed_again_after_taking()
{
var sut = new ConsoleScriptActivityTally();
var lookups = 0;
string? Lookup(int pid) { lookups++; return "p" + pid + ".exe"; }
for (var i = 0; i < ConsoleScriptActivityTally.MaxParentLookups + 3; i++)
sut.Add(Cmd, 1000 + i, 10 + i, 1, OobeAccount, At, Lookup);
Assert.Equal(ConsoleScriptActivityTally.MaxParentLookups, lookups);
sut.Take();
sut.Add(Cmd, 2000, 99, 1, OobeAccount, At, Lookup);
Assert.Equal(ConsoleScriptActivityTally.MaxParentLookups + 1, lookups);
}
[Fact]
public void Lists_are_capped_and_the_totals_tell_how_much_there_was()
{
var sut = new ConsoleScriptActivityTally();
const int parents = ConsoleScriptActivityTally.MaxParentsListed + 3;
const int owners = ConsoleScriptActivityTally.MaxOwnersListed + 2;
for (var p = 0; p < parents; p++)
{
// Parent p gets p+1 children, so the busiest parents are the last ones added.
for (var c = 0; c <= p; c++)
sut.Add(Cmd, 10_000 + p * 100 + c, 500 + p, 1, "S-1-5-21-9-9-9-" + (p % owners), At, NoName);
}
var a = sut.Take()!;
Assert.Equal(parents, a.ParentsTotal);
Assert.Equal(ConsoleScriptActivityTally.MaxParentsListed, a.Parents.Count);
Assert.Equal(500 + parents - 1, a.Parents[0].ProcessId);
Assert.Equal(parents, a.Parents[0].Children);
Assert.Equal(owners, a.OwnersTotal);
Assert.Equal(ConsoleScriptActivityTally.MaxOwnersListed, a.Owners.Count);
}
[Fact]
public void A_start_without_a_parent_id_or_owner_still_counts()
{
var sut = new ConsoleScriptActivityTally();
sut.Add(Cmd, 101, 0, 1, null, At, _ => throw new InvalidOperationException("no parent to look up"));
var a = sut.Take()!;
Assert.Equal(1, a.Count);
Assert.Empty(a.Parents);
Assert.Equal(0, a.ParentsTotal);
Assert.Empty(a.Owners);
}
}
}
@@ -0,0 +1,97 @@
#nullable enable
using System;
using System.Security.Principal;
using System.Threading;
using System.Threading.Tasks;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals;
using AutopilotMonitor.Agent.V2.Core.Tests.Harness;
using Microsoft.Win32;
using Xunit;
#pragma warning disable xUnit1031 // the test waits on a task on purpose: a blocked call is the failure it looks for
namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.SystemSignals
{
/// <summary>
/// <see cref="RealmJoinWatcher.Stop"/> while the "RealmJoin key appeared" callback is in
/// flight. The callback runs on a real registry watcher over the signed-in user's
/// <c>HKU\&lt;sid&gt;\SOFTWARE</c> (writable without elevation); the key probes are injected.
/// </summary>
[Collection("SerialThreading")] // registry callbacks arrive on the shared ThreadPool
public sealed class RealmJoinWatcherStopTests : IDisposable
{
private static readonly TimeSpan Timeout = TimeSpan.FromSeconds(10);
private readonly TempDirectory _tmp = new TempDirectory();
// A new direct child of HKCU\SOFTWARE is what the parent watch reacts to.
private readonly string _probeKey = @"SOFTWARE\AutopilotMonitor.Tests.RealmJoinStop." + Guid.NewGuid().ToString("N");
public void Dispose()
{
try { Registry.CurrentUser.DeleteSubKeyTree(_probeKey, throwOnMissingSubKey: false); }
catch { /* teardown noise must not fail a test */ }
_tmp.Dispose();
}
[Fact]
public void Stop_returns_while_the_key_appeared_callback_is_running()
{
var sid = WindowsIdentity.GetCurrent().User!.Value;
var userRealmJoinPath = sid + "\\" + RealmJoinInfo.UserRealmJoinSubPath;
var appearedProbe = new ManualResetEventSlim(false);
var release = new ManualResetEventSlim(false);
int armed = 0;
bool KeyExists(RegistryHive hive, string subPath)
{
// Everything is "absent" while the watcher arms. Afterwards the user-scope
// RealmJoin key "exists": the callback sees it and goes on to switch watchers.
if (hive != RegistryHive.Users || subPath != userRealmJoinPath || Volatile.Read(ref armed) == 0)
return false;
appearedProbe.Set();
release.Wait(Timeout);
return true;
}
var watcher = new RealmJoinWatcher(
new AgentLogger(_tmp.Path, AgentLogLevel.Info),
enumeratePackageIds: (_, __) => Array.Empty<string>(),
tryReadPackage: (RegistryHive _, string __, string ___, out RealmJoinPackageSnapshot snapshot) =>
{
snapshot = default!;
return false;
},
keyExists: KeyExists,
readVersionInfo: () => default,
readUninstallDisplayVersion: () => null,
readDeploymentPhase: () => null);
// Production order: the SID is recorded, then RealmJoin reaches the running phase and
// the watcher arms its parent watch on HKU\<sid>\SOFTWARE.
watcher.ArmHku(sid);
watcher.TriggerNotifyRealmJoinPresenceFromTest(RealmJoinInfo.PhaseRunningThresholdMin);
Volatile.Write(ref armed, 1);
Task stop;
try
{
using (var key = Registry.CurrentUser.CreateSubKey(_probeKey)) Assert.NotNull(key);
Assert.True(appearedProbe.Wait(Timeout), "the parent watch did not report the new key");
stop = Task.Run(() => watcher.Stop());
Thread.Sleep(300); // let Stop reach the registry watcher whose callback is parked
}
finally
{
release.Set();
}
var returned = stop.Wait(Timeout);
// A blocked Stop holds the watcher's lock for good; disposing it would hang the run.
if (returned) watcher.Dispose();
Assert.True(returned,
"Stop and the key-appeared callback blocked each other: watchers are disposed under the state lock");
}
}
}
@@ -80,6 +80,29 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Transport
Assert.Equal(2, client.Calls);
}
[Fact]
public async Task Registration_session_gone_report_is_exempt_from_the_cooldown_like_the_telemetry_one()
{
// The integrity report goes out post-config, seconds before the registration is refused.
var clock = Clock();
var client = new FakeApiClient();
client.Results.Enqueue(true);
client.Results.Enqueue(true);
var reporter = Reporter(client, clock);
await reporter.TrySendAsync(AgentErrorType.IntegrityCheckFailed, "m");
clock.Advance(TimeSpan.FromSeconds(5));
await reporter.TrySendAsync(AgentErrorType.RegistrationRejectedSessionGone, "m", httpStatusCode: 410);
Assert.Equal(2, client.Calls);
Assert.Equal(AgentErrorType.RegistrationRejectedSessionGone, client.Reports[1].ErrorType);
Assert.Equal(410, client.Reports[1].HttpStatusCode);
// Key dedup still applies: a second one is held back.
await reporter.TrySendAsync(AgentErrorType.RegistrationRejectedSessionGone, "m", httpStatusCode: 410);
Assert.Equal(2, client.Calls);
}
[Fact]
public async Task Second_session_unknown_report_within_the_window_is_still_suppressed()
{
@@ -0,0 +1,325 @@
#nullable enable
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security;
using AutopilotMonitor.Agent.V2.Core.Orchestration;
using AutopilotMonitor.Agent.V2.Core.Persistence;
using AutopilotMonitor.Agent.V2.Core.Tests.Harness;
using AutopilotMonitor.DecisionCore.Engine;
using AutopilotMonitor.DecisionCore.Signals;
using AutopilotMonitor.Shared;
using Xunit;
namespace AutopilotMonitor.Agent.V2.Core.Tests.Orchestration
{
/// <summary>
/// ConsoleBypassHost — what goes onto the single rail: a console the watcher reports becomes a
/// Warning <c>oobe_console_spawned</c>; starts the watcher only counts become one Info
/// <c>console_script_activity</c> per window, capped per run, and whatever is still counted goes
/// out on every way the host stops. The watcher is driven through its internal entry points with
/// injected probes; no WMI subscription and no window timer runs here.
/// </summary>
[Collection("SerialThreading")] // one test runs a real SignalIngress worker
public sealed class ConsoleBypassHostTests : IDisposable
{
private static readonly DateTime At = new DateTime(2026, 11, 11, 14, 41, 35, DateTimeKind.Utc);
private const string Cmd = "cmd.exe";
private const string BareCmd = @"C:\WINDOWS\system32\cmd.exe";
private const string OobeAccount = "S-1-5-21-1-2-3-1000";
private const int ScriptHost = 2688;
private const int GoneLauncher = 9016;
private readonly TempDirectory _tmp = new TempDirectory();
private readonly FakeSignalIngressSink _sink = new FakeSignalIngressSink();
private readonly AgentLogger _logger;
private string? _runningCommandLine; // null = every probed process has exited
private DateTime _now = At;
public ConsoleBypassHostTests()
{
_logger = new AgentLogger(_tmp.Path, AgentLogLevel.Info);
}
public void Dispose() => _tmp.Dispose();
private ConsoleBypassWatcher NewWatcher() => new ConsoleBypassWatcher(
_logger,
processProbe: (pid, name) => _runningCommandLine == null
? null
: new ProcessProbe(name, 1, 0, _runningCommandLine, "20261111144135.000000+060"),
isAlive: _ => true,
parentName: pid => pid == ScriptHost ? "powershell.exe" : null,
utcNow: () => _now);
private ConsoleBypassHost Build(ConsoleBypassWatcher watcher, ISignalIngressSink? ingress = null) =>
new ConsoleBypassHost("sess-console", "tenant-console", ingress ?? _sink, new VirtualClock(At), _logger, watcher);
private static void Trace(ConsoleBypassWatcher watcher, int pid, int parentPid = ScriptHost) =>
watcher.HandleStart(pid, parentPid, 1, OobeAccount, "process_start_trace", Cmd);
private IReadOnlyList<FakeSignalIngressSink.PostedSignal> Events(string eventType) =>
_sink.Posted.Where(p =>
p.Kind == DecisionSignalKind.InformationalEvent
&& p.Payload != null
&& p.Payload.TryGetValue(SignalPayloadKeys.EventType, out var et)
&& et == eventType).ToList();
private static IReadOnlyDictionary<string, object> Data(FakeSignalIngressSink.PostedSignal s) =>
(IReadOnlyDictionary<string, object>)s.TypedPayload!;
// ---------------------------------------------------------------- consoles
[Fact]
public void A_console_is_a_warning_with_immediate_upload_and_the_name_of_its_parent()
{
_runningCommandLine = BareCmd;
var watcher = NewWatcher();
using var host = Build(watcher);
Trace(watcher, pid: 9636);
var s = Assert.Single(Events(Constants.EventTypes.OobeConsoleSpawned));
Assert.Equal("Warning", s.Payload![SignalPayloadKeys.Severity]);
Assert.Equal("true", s.Payload![SignalPayloadKeys.ImmediateUpload]);
var data = Data(s);
Assert.Equal("high", data["confidence"]);
Assert.Equal("powershell.exe", data["parentProcessName"]);
Assert.Equal(ScriptHost, data["parentProcessId"]);
Assert.Equal(OobeAccount, data["owner"]);
Assert.Equal(BareCmd, data["commandLine"]);
Assert.Empty(Events(Constants.EventTypes.ConsoleScriptActivity));
}
[Fact]
public void A_low_confidence_console_is_uploaded_at_once_too_and_names_a_gone_parent_unknown()
{
// The confidence follows the command line, which whoever opens the console chooses:
// it labels the warning, it never delays it.
_runningCommandLine = "cmd.exe /k whoami";
var watcher = NewWatcher();
using var host = Build(watcher);
Trace(watcher, pid: 9636, parentPid: GoneLauncher);
var s = Assert.Single(Events(Constants.EventTypes.OobeConsoleSpawned));
Assert.Equal("Warning", s.Payload![SignalPayloadKeys.Severity]);
Assert.Equal("true", s.Payload![SignalPayloadKeys.ImmediateUpload]);
Assert.Equal("low", Data(s)["confidence"]);
Assert.Equal("unknown", Data(s)["parentProcessName"]);
}
// ---------------------------------------------------------------- script activity
[Fact]
public void Counted_starts_become_one_info_line_when_the_window_ends()
{
var watcher = NewWatcher();
using var host = Build(watcher);
Trace(watcher, pid: 5001);
_now = At.AddSeconds(1);
Trace(watcher, pid: 5002);
_now = At.AddSeconds(2);
Trace(watcher, pid: 5003);
Assert.Empty(_sink.Posted);
host.WindowElapsedForTest();
Assert.Empty(Events(Constants.EventTypes.OobeConsoleSpawned));
var s = Assert.Single(Events(Constants.EventTypes.ConsoleScriptActivity));
Assert.Equal("Info", s.Payload![SignalPayloadKeys.Severity]);
Assert.Equal("false", s.Payload![SignalPayloadKeys.ImmediateUpload]);
Assert.Equal(At.AddSeconds(2), s.OccurredAtUtc);
Assert.Equal(
"Script activity: 3 short-lived cmd.exe processes in session 1, started by powershell.exe — counted, not an interactive console",
s.Payload![SignalPayloadKeys.Message]);
var data = Data(s);
Assert.Equal(3, data["count"]);
Assert.Equal(Cmd, data["processName"]);
Assert.Equal(At.ToString("o"), data["firstSeenUtc"]);
Assert.Equal(At.AddSeconds(2).ToString("o"), data["lastSeenUtc"]);
Assert.Equal(new[] { 1 }, (List<int>)data["windowsSessions"]);
Assert.Equal(new[] { OobeAccount }, (List<string>)data["owners"]);
Assert.Equal(1, data["ownersTotal"]);
Assert.Equal(1, data["parentsTotal"]);
var parent = Assert.Single((List<Dictionary<string, object>>)data["parents"]);
Assert.Equal(ScriptHost, parent["pid"]);
Assert.Equal("powershell.exe", parent["name"]);
Assert.Equal(3, parent["children"]);
Assert.False(data.ContainsKey("capped"));
}
[Fact]
public void A_window_without_counted_starts_reports_nothing()
{
using var host = Build(NewWatcher());
host.WindowElapsedForTest();
Assert.Empty(_sink.Posted);
}
[Fact]
public void Each_window_reports_only_its_own_starts()
{
var watcher = NewWatcher();
using var host = Build(watcher);
Trace(watcher, pid: 5001);
host.WindowElapsedForTest();
Trace(watcher, pid: 5002);
Trace(watcher, pid: 5003);
host.WindowElapsedForTest();
Assert.Equal(new object[] { 1, 2 }, Events(Constants.EventTypes.ConsoleScriptActivity).Select(s => Data(s)["count"]));
}
[Fact]
public void After_the_cap_no_window_reports_and_the_line_at_stop_says_so()
{
var watcher = NewWatcher();
var host = Build(watcher);
for (var i = 0; i < ConsoleBypassHost.MaxScriptActivitySummaries; i++)
{
Trace(watcher, pid: 5000 + i);
host.WindowElapsedForTest();
}
Assert.Equal(ConsoleBypassHost.MaxScriptActivitySummaries, Events(Constants.EventTypes.ConsoleScriptActivity).Count);
Trace(watcher, pid: 7001);
Trace(watcher, pid: 7002);
host.WindowElapsedForTest();
Assert.Equal(ConsoleBypassHost.MaxScriptActivitySummaries, Events(Constants.EventTypes.ConsoleScriptActivity).Count);
host.Stop();
var all = Events(Constants.EventTypes.ConsoleScriptActivity);
Assert.Equal(ConsoleBypassHost.MaxScriptActivitySummaries + 1, all.Count);
Assert.All(all.Take(ConsoleBypassHost.MaxScriptActivitySummaries), s => Assert.False(Data(s).ContainsKey("capped")));
var last = Data(all[all.Count - 1]);
Assert.Equal(2, last["count"]);
Assert.Equal(true, last["capped"]);
}
// ---------------------------------------------------------------- stopping
[Fact]
public void Stopping_reports_what_was_counted_exactly_once()
{
var watcher = NewWatcher();
var host = Build(watcher);
Trace(watcher, pid: 5001);
Trace(watcher, pid: 5002);
host.Stop();
host.Stop();
host.Dispose();
Assert.Equal(2, Data(Assert.Single(Events(Constants.EventTypes.ConsoleScriptActivity)))["count"]);
}
[Fact]
public void Desktop_arrival_reports_what_was_counted()
{
var watcher = NewWatcher();
var host = Build(watcher);
Trace(watcher, pid: 5001);
host.StopForDesktopArrival();
Assert.Single(Events(Constants.EventTypes.ConsoleScriptActivity));
}
[Fact]
public void The_stop_signal_on_the_decision_rail_reports_what_was_counted()
{
var clock = new VirtualClock(At);
using var ingress = new SignalIngress(
engine: new DecisionEngine(),
signalLog: new SignalLogWriter(_tmp.File("signal-log.jsonl")),
traceCounter: new SessionTraceOrdinalProvider(),
processor: new FakeDecisionStepProcessor(),
clock: clock);
var postedEventTypes = new List<string>();
ingress.SignalPosted += (kind, payload) =>
{
if (kind == DecisionSignalKind.InformationalEvent && payload != null
&& payload.TryGetValue(SignalPayloadKeys.EventType, out var et))
{
lock (postedEventTypes) postedEventTypes.Add(et);
}
};
var watcher = NewWatcher();
var host = Build(watcher, ingress);
ingress.Start();
host.StartCore(armWatcher: false);
Trace(watcher, pid: 5001);
ingress.Post(
DecisionSignalKind.DesktopArrived, At, "DesktopArrivalDetector",
new Evidence(EvidenceKind.Raw, "desktop", "evidence-desktop"));
Assert.True(SpinWait.SpinUntil(() => { lock (postedEventTypes) return postedEventTypes.Contains(Constants.EventTypes.ConsoleScriptActivity); }, 5000),
"the host stopped on the rail signal without reporting what was counted");
Trace(watcher, pid: 5002); // the watcher is disposed: nothing is counted any more
Assert.Null(watcher.TakeScriptActivity());
}
[Fact]
public void A_stopped_ingress_does_not_break_the_stop()
{
var watcher = NewWatcher();
var host = Build(watcher);
Trace(watcher, pid: 5001);
_sink.ThrowOnPost = new InvalidOperationException("SignalIngress has been stopped.");
Assert.Null(Record.Exception(() => host.Dispose()));
}
// ---------------------------------------------------------------- timeline text
private static ConsoleScriptActivity Activity(int count, int[] sessions, int parentsTotal, params (int pid, string? name, int children)[] parents) =>
new ConsoleScriptActivity(
Cmd, count, At, At, sessions,
new[] { OobeAccount }, 1,
parents.Select(p => new ConsoleScriptParent(p.pid, p.name, p.children)).ToList(), parentsTotal);
[Fact]
public void One_process_from_a_parent_that_is_gone()
{
Assert.Equal(
"Script activity: 1 short-lived cmd.exe process in session 1, started by an unknown program — counted, not an interactive console",
ConsoleBypassHost.DescribeScriptActivity(Activity(1, new[] { 1 }, 1, (6688, null, 1))));
}
[Fact]
public void Several_named_parents_in_two_sessions()
{
Assert.Equal(
"Script activity: 46 short-lived cmd.exe processes in sessions 1, 2, started by 2 parent processes (powershell.exe, cmd.exe) — counted, not an interactive console",
ConsoleBypassHost.DescribeScriptActivity(Activity(46, new[] { 1, 2 }, 2, (2688, "powershell.exe", 25), (9296, "cmd.exe", 21))));
}
[Fact]
public void More_parents_than_names_end_in_an_ellipsis()
{
Assert.Equal(
"Script activity: 9 short-lived cmd.exe processes in session 2, started by 4 parent processes (python.exe, …) — counted, not an interactive console",
ConsoleBypassHost.DescribeScriptActivity(Activity(9, new[] { 2 }, 4, (10, "python.exe", 5), (11, null, 4))));
}
[Fact]
public void Parents_without_any_name_are_only_counted()
{
Assert.Equal(
"Script activity: 3 short-lived cmd.exe processes in session 1, started by 3 parent processes — counted, not an interactive console",
ConsoleBypassHost.DescribeScriptActivity(Activity(3, new[] { 1 }, 3, (10, null, 1), (11, null, 1), (12, null, 1))));
}
}
}
@@ -0,0 +1,158 @@
#nullable enable
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Orchestration;
using AutopilotMonitor.Agent.V2.Core.Tests.Harness;
using AutopilotMonitor.Agent.V2.Core.Transport.Telemetry;
using AutopilotMonitor.DecisionCore.Engine;
using AutopilotMonitor.DecisionCore.State;
using AutopilotMonitor.Shared.Models;
using Newtonsoft.Json.Linq;
using Xunit;
#pragma warning disable xUnit1031 // the tests wait on tasks on purpose: a call that never returns is the failure they look for
namespace AutopilotMonitor.Agent.V2.Core.Tests.Orchestration
{
/// <summary>
/// Stopping the collector hosts is bounded per host: termination reaches the diagnostics
/// upload and the cleanup whatever a collector does. A host that hangs is left behind, named
/// in one <c>agent_trace</c>, and never called again; every other host is stopped and disposed
/// as before.
/// </summary>
[Collection("SerialThreading")]
public sealed class EnrollmentOrchestratorCollectorStopTests
{
private static readonly TimeSpan Bound = TimeSpan.FromMilliseconds(400);
private static readonly TimeSpan Wait = TimeSpan.FromSeconds(10);
private sealed class Host : ICollectorHost
{
private readonly List<string> _order;
private readonly ManualResetEventSlim? _hangUntil;
private readonly Exception? _throwOnStop;
private int _stopCalls;
private int _disposeCalls;
public Host(string name, List<string> order, ManualResetEventSlim? hangUntil = null, Exception? throwOnStop = null)
{
Name = name;
_order = order;
_hangUntil = hangUntil;
_throwOnStop = throwOnStop;
}
public string Name { get; }
public int StopCalls => Volatile.Read(ref _stopCalls);
public int DisposeCalls => Volatile.Read(ref _disposeCalls);
public void Start() { }
public void Stop()
{
Interlocked.Increment(ref _stopCalls);
lock (_order) _order.Add(Name);
if (_throwOnStop != null) throw _throwOnStop;
_hangUntil?.Wait();
}
public void Dispose() => Interlocked.Increment(ref _disposeCalls);
}
private sealed class Factory : IComponentFactory
{
private readonly IReadOnlyList<ICollectorHost> _hosts;
public Factory(IReadOnlyList<ICollectorHost> hosts) { _hosts = hosts; }
public CollectorSurfaces CreateCollectorHosts(
string sessionId,
string tenantId,
AgentLogger logger,
IReadOnlyCollection<string> whiteGloveSealingPatternIds,
ISignalIngressSink ingress,
IClock clock,
ITelemetrySpool? telemetrySpool,
TimelineEventStream? timelineEvents = null,
Func<DecisionState?>? decisionStateProbe = null) => new CollectorSurfaces(_hosts);
}
private static JObject? StopTimeoutEvent(EnrollmentOrchestrator sut) =>
sut.SpoolForTests!.Peek(1000)
.Where(i => i.Kind == TelemetryItemKind.Event && i.PayloadJson.Contains("collector_host_stop_timeout"))
.Select(i => JObject.Parse(i.PayloadJson))
.FirstOrDefault();
[Fact]
public void A_host_that_hangs_in_Stop_is_left_behind_and_the_others_are_still_stopped()
{
using var rig = new EnrollmentOrchestratorRig();
using var release = new ManualResetEventSlim(false);
var order = new List<string>();
var before = new Host("Before", order);
var hanging = new Host("Hanging", order, hangUntil: release);
var after = new Host("After", order);
var sut = rig.Build(
componentFactory: new Factory(new ICollectorHost[] { before, hanging, after }),
collectorHostStopTimeout: Bound);
sut.Start();
try
{
var stop = Task.Run(() => sut.StopCollectorHosts());
Assert.True(stop.Wait(Wait), "StopCollectorHosts never returned although one host hangs");
Assert.Equal(new[] { "Before", "Hanging", "After" }, order.ToArray());
JObject? evt = null;
Assert.True(SpinWait.SpinUntil(() => (evt = StopTimeoutEvent(sut)) != null, Wait),
"the hanging host was not reported");
Assert.Equal("agent_trace", (string?)evt!["EventType"]);
var data = (JObject)evt["Data"]!;
Assert.Equal("collector_host_stop_timeout", (string?)data["decision"]);
Assert.Equal("Hanging", (string?)data["host"]);
Assert.Equal(1, (int)data["timeoutSeconds"]!);
// Stop() afterwards: the stuck host is not touched again, the others are disposed.
var fullStop = Task.Run(() => sut.Stop());
Assert.True(fullStop.Wait(Wait), "Stop never returned");
Assert.Equal(1, before.DisposeCalls);
Assert.Equal(0, hanging.DisposeCalls);
Assert.Equal(1, after.DisposeCalls);
Assert.Equal(1, hanging.StopCalls);
}
finally
{
release.Set();
}
}
[Fact]
public void Healthy_hosts_are_stopped_and_disposed_in_order_without_a_report()
{
using var rig = new EnrollmentOrchestratorRig();
var order = new List<string>();
var first = new Host("First", order);
var throwing = new Host("Throwing", order, throwOnStop: new InvalidOperationException("boom"));
var last = new Host("Last", order);
var hosts = new[] { first, throwing, last };
var sut = rig.Build(componentFactory: new Factory(hosts)); // default bound: nothing here comes near it
sut.Start();
sut.StopCollectorHosts();
sut.StopCollectorHosts(); // idempotent
Assert.Equal(new[] { "First", "Throwing", "Last" }, order.ToArray());
Assert.All(hosts, h => Assert.Equal(1, h.StopCalls));
Thread.Sleep(200);
Assert.Null(StopTimeoutEvent(sut));
sut.Stop();
Assert.All(hosts, h => Assert.Equal(1, h.DisposeCalls));
}
}
}
@@ -0,0 +1,174 @@
#nullable enable
using System;
using System.IO;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office;
using AutopilotMonitor.Agent.V2.Core.Orchestration;
using AutopilotMonitor.Agent.V2.Core.Tests.Harness;
using AutopilotMonitor.DecisionCore.Engine;
using AutopilotMonitor.Shared;
using Microsoft.Win32;
using Xunit;
#pragma warning disable xUnit1031 // the tests wait on tasks on purpose: a blocked call is the failure they look for
namespace AutopilotMonitor.Agent.V2.Core.Tests.Orchestration
{
/// <summary>
/// <see cref="OfficeInstallDetectorHost"/> with its real watchers: the registry watcher on a
/// key under HKCU, the binary watcher on a temp folder, snapshots injected. Stopping the host
/// must never wait for a watcher callback, and a completion that coincides with a registry
/// callback must not leave the host unable to stop.
/// </summary>
[Collection("SerialThreading")] // registry + filesystem callbacks arrive on the shared ThreadPool
public sealed class OfficeInstallDetectorHostTests : IDisposable
{
private const string RegistrySubKey = @"SOFTWARE\AutopilotMonitor.Tests\OfficeInstallDetectorHost";
private static readonly DateTime At = new DateTime(2026, 11, 10, 9, 0, 0, DateTimeKind.Utc);
private static readonly TimeSpan Timeout = TimeSpan.FromSeconds(10);
private readonly TempDirectory _tmp = new TempDirectory();
private readonly FakeSignalIngressSink _sink = new FakeSignalIngressSink();
private readonly string _installPath;
private Func<OfficeC2RSnapshot> _snapshot;
public OfficeInstallDetectorHostTests()
{
DeleteTestKey();
using (var key = Registry.CurrentUser.CreateSubKey(RegistrySubKey)) Assert.NotNull(key);
_installPath = Path.Combine(_tmp.Path, "Office");
Directory.CreateDirectory(_installPath);
_snapshot = Idle;
}
public void Dispose()
{
DeleteTestKey();
_tmp.Dispose();
}
private static void DeleteTestKey()
{
try { Registry.CurrentUser.DeleteSubKeyTree(RegistrySubKey, throwOnMissingSubKey: false); }
catch { /* teardown noise must not fail a test */ }
}
private static void TouchRegistry()
{
using (var key = Registry.CurrentUser.OpenSubKey(RegistrySubKey, writable: true))
{
Assert.NotNull(key);
key!.SetValue("Probe", Guid.NewGuid().ToString("N"));
}
}
private OfficeInstallDetectorHost NewHost() =>
new OfficeInstallDetectorHost(
sessionId: "S1",
tenantId: "T1",
ingress: _sink,
clock: new VirtualClock(At),
logger: new AgentLogger(_tmp.Path, AgentLogLevel.Info),
settleSeconds: 0,
statePersistence: null,
resumeState: null,
registryHive: RegistryHive.CurrentUser,
registrySubKey: RegistrySubKey,
snapshotProvider: () => _snapshot());
// No install scenario, no install path: the detector stays idle and the host keeps
// raising OfficeExpected on registry changes.
private static OfficeC2RSnapshot Idle() => new OfficeC2RSnapshot { ConfigurationKeyPresent = true };
private OfficeC2RSnapshot Installing()
{
var s = new OfficeC2RSnapshot
{
ConfigurationKeyPresent = true,
ActiveScenarioPresent = true,
ActiveScenarioName = "INSTALL",
InstallScenarioPresent = true,
InstallScenarioName = "INSTALL",
InstallationPath = _installPath,
VersionToReport = "16.0.1.1",
};
s.Products.Add("O365ProPlusRetail");
return s;
}
private int OfficeEvents(string eventType) => _sink.Posted.Count(p =>
p.Payload != null
&& p.Payload.TryGetValue(SignalPayloadKeys.EventType, out var et)
&& et == eventType);
[Fact]
public void Stop_returns_while_a_registry_handler_is_running()
{
var host = NewHost();
using var entered = new ManualResetEventSlim(false);
using var release = new ManualResetEventSlim(false);
host.OfficeExpected += (_, __) => { entered.Set(); release.Wait(Timeout); };
try
{
host.Start();
TouchRegistry();
Assert.True(entered.Wait(Timeout), "the registry change did not reach the host");
var stop = Task.Run(() => host.Stop());
Assert.True(stop.Wait(TimeSpan.FromSeconds(5)),
"Stop waited for the running registry handler");
}
finally
{
release.Set();
}
}
[Fact]
public void A_completion_during_a_running_registry_handler_does_not_block_Stop()
{
var host = NewHost();
using var entered = new ManualResetEventSlim(false);
using var release = new ManualResetEventSlim(false);
host.OfficeExpected += (_, __) => { entered.Set(); release.Wait(Timeout); };
try
{
// 1) A registry callback is in flight (parked in the host's OfficeExpected handler).
host.Start();
TouchRegistry();
Assert.True(entered.Wait(Timeout), "the registry change did not reach the host");
// 2) The install starts and completes meanwhile: the binary watcher sees the core
// binary, the detector reports completed, the host tears its watchers down.
_snapshot = Installing;
host.SubmitDoSample(new OfficeDoSample { JobCount = 1, FileSize = 100, TotalBytesDownloaded = 10 });
Assert.Equal(1, OfficeEvents(Constants.EventTypes.OfficeInstallStarted));
var versionDir = Path.Combine(_installPath, "root", "Office16");
Directory.CreateDirectory(versionDir);
File.WriteAllText(Path.Combine(versionDir, "EXCEL.EXE"), "stub");
Assert.True(
SpinWait.SpinUntil(() => OfficeEvents(Constants.EventTypes.OfficeInstallCompleted) == 1, Timeout),
"the install was not reported as completed");
// 3) The agent stops while that registry callback is still running.
var stop = Task.Run(() => host.Stop());
Assert.True(stop.Wait(TimeSpan.FromSeconds(5)),
"Stop waited behind the completion's teardown, which waited for the running registry handler");
}
finally
{
release.Set();
}
Assert.Equal(1, OfficeEvents(Constants.EventTypes.OfficeInstallCompleted));
}
}
}
@@ -43,6 +43,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Orchestration
[InlineData("network_connectivity_check")]
// Bookkeeping of health-script runs that were deliberately not reported.
[InlineData("script_recurrence_summary")]
// Counted short-lived console processes — a spawning script is not enrollment progress.
[InlineData("console_script_activity")]
// Agent health / control / transport — not device/enrollment progress (P2).
[InlineData("collector_degraded")]
[InlineData("telemetry_upload_poisoned")]
@@ -0,0 +1,167 @@
#nullable enable
using System;
using System.Collections.Generic;
using System.IO;
using System.Threading.Tasks;
using AutopilotMonitor.Agent.V2.Core.Configuration;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Runtime;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Transport;
using AutopilotMonitor.Agent.V2.Core.Orchestration;
using AutopilotMonitor.Agent.V2.Core.Security;
using AutopilotMonitor.Agent.V2.Core.Tests.Harness;
using AutopilotMonitor.Agent.V2.Core.Tests.Orchestration;
using AutopilotMonitor.Agent.V2.Runtime;
using AutopilotMonitor.DecisionCore.Engine;
using AutopilotMonitor.Shared.Models;
using Xunit;
using ProgramAlias = AutopilotMonitor.Agent.V2.Program;
namespace AutopilotMonitor.Agent.V2.Core.Tests.Program
{
/// <summary>
/// A registration the backend answered with HTTP 410 at process start: the session was deleted.
/// Exactly one <see cref="AgentErrorType.RegistrationRejectedSessionGone"/> report, then the
/// start-time end of monitoring with a forced cleanup — the same end state as the emergency
/// break and the kill signal. The WhiteGlove Part 2 start that registers a new session instead
/// is covered by <c>SessionRegistrationHelperTests</c>; here only its trace on <c>agent_started</c>.
/// </summary>
public sealed class SessionGoneAtRegistrationTests : IDisposable
{
private readonly TempDirectory _tmp = new TempDirectory();
private readonly AgentLogger _logger;
private readonly SessionIdPersistence _persistence;
private readonly string _stateDir;
private readonly List<string> _sequence = new List<string>();
public SessionGoneAtRegistrationTests()
{
_logger = new AgentLogger(Path.Combine(_tmp.Path, "logs"), AgentLogLevel.Info);
_persistence = new SessionIdPersistence(_tmp.Path);
_persistence.GetOrCreate(_logger);
_stateDir = Path.Combine(_tmp.Path, "State");
}
public void Dispose() => _tmp.Dispose();
private sealed class RecordingEmergencyReporter : EmergencyReporter
{
private readonly List<string> _sequence;
public List<(AgentErrorType ErrorType, string Message, int? HttpStatusCode, int Attempts)> Reports { get; } =
new List<(AgentErrorType, string, int?, int)>();
public RecordingEmergencyReporter(List<string> sequence)
: base(apiClient: null!, sessionId: "S1", tenantId: "T1", agentVersion: "0.0.0", logger: null!)
{
_sequence = sequence;
}
public override Task TrySendAsync(
AgentErrorType errorType,
string message,
int? httpStatusCode = null,
long? sequenceNumber = null,
int attempts = 1,
TimeSpan? perAttemptTimeout = null,
TimeSpan? retryDelay = null,
double? sessionAgeHours = null,
RegistrationFailureSummary? priorRegistrationFailure = null)
{
Reports.Add((errorType, message, httpStatusCode, attempts));
_sequence.Add("report");
return Task.CompletedTask;
}
}
private CleanupService CleanupFactory()
{
_sequence.Add("cleanup");
// The real factory spawns a PowerShell cleanup script; throwing makes the cleanup retry
// swallow and log it, so the call is counted without a side effect (as in ProgramGuardsTests).
throw new InvalidOperationException("test-harness: cleanup factory must not spawn real PowerShell in unit tests");
}
private bool MarkerExists => File.Exists(Path.Combine(_stateDir, "enrollment-complete.marker"));
[Theory]
[InlineData(true)]
[InlineData(false)] // forced like the kill signal: SelfDestructOnComplete does not gate it
public void Reports_once_then_ends_monitoring_with_a_forced_cleanup(bool selfDestructOnComplete)
{
_persistence.SaveWhiteGloveComplete(_logger);
var config = new AgentConfiguration { SessionId = "S1", TenantId = "T1", SelfDestructOnComplete = selfDestructOnComplete };
var reporter = new RecordingEmergencyReporter(_sequence);
var exitCode = BackendSessionRegistration.ConcludeSessionGone(
config, reporter, _persistence, _stateDir, CleanupFactory, consoleMode: false, _logger);
Assert.Equal(0, exitCode);
// The report leaves before the cleanup deletes the agent.
Assert.Equal(new[] { "report", "cleanup" }, _sequence);
var report = Assert.Single(reporter.Reports);
Assert.Equal(AgentErrorType.RegistrationRejectedSessionGone, report.ErrorType);
Assert.Equal(410, report.HttpStatusCode);
Assert.Contains("410", report.Message);
Assert.True(report.Attempts > 1, "the process ends right after: the one report gets a retry");
Assert.True(MarkerExists);
Assert.False(_persistence.SessionExists());
Assert.False(_persistence.IsWhiteGloveResume());
Assert.Null(_persistence.LoadSessionCreatedAt());
// The next start ends at the bootstrap guard, exactly as after the emergency break.
Assert.True(ProgramAlias.CheckEnrollmentCompleteMarker(
_stateDir, selfDestructOnComplete: false, cleanupServiceFactory: null, _logger, consoleMode: false));
}
[Fact]
public void Ends_monitoring_without_a_reporter()
{
var config = new AgentConfiguration { SessionId = "S1", TenantId = "T1" };
var exitCode = BackendSessionRegistration.ConcludeSessionGone(
config, emergencyReporter: null!, _persistence, _stateDir, CleanupFactory, consoleMode: false, _logger);
Assert.Equal(0, exitCode);
Assert.Equal(new[] { "cleanup" }, _sequence);
Assert.True(MarkerExists);
Assert.False(_persistence.SessionExists());
}
[Theory]
[InlineData(SessionRotationReasons.SessionGone)]
[InlineData(SessionRotationReasons.OwnerMismatch)]
public void Agent_started_names_why_the_session_was_rotated(string reason)
{
var data = EmitAgentStarted(rotatedFromSessionId: "11111111-1111-1111-1111-111111111111", reason);
Assert.Equal(true, data["sessionRotated"]);
Assert.Equal("11111111-1111-1111-1111-111111111111", data["previousSessionId"]);
Assert.Equal(reason, data["sessionRotationReason"]);
}
[Fact]
public void Agent_started_carries_no_rotation_reason_on_the_normal_path()
{
var data = EmitAgentStarted(rotatedFromSessionId: null, sessionRotationReason: null);
Assert.Equal(false, data["sessionRotated"]);
Assert.False(data.ContainsKey("sessionRotationReason"));
}
private Dictionary<string, object> EmitAgentStarted(string? rotatedFromSessionId, string? sessionRotationReason)
{
var sink = new FakeSignalIngressSink();
LifecycleEmitters.EmitAgentStarted(
new InformationalEventPost(sink, SystemClock.Instance, _logger),
new AgentConfiguration { SessionId = "S1", TenantId = "00000000-0000-0000-0000-000000000001", CommandLineArgs = string.Empty },
new ProgramAlias.PreviousExitSummary { ExitType = "reboot_kill" },
"2.0.test",
remoteConfigService: null,
_logger,
rotatedFromSessionId: rotatedFromSessionId,
sessionRotationReason: sessionRotationReason);
return (Dictionary<string, object>)Assert.Single(sink.Posted).TypedPayload!;
}
}
}
@@ -166,6 +166,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Security
Assert.Equal(0, tracker.ConsecutiveFailures);
Assert.Equal(new[] { originalSessionId, rotatedTo }, seenSessionIds);
Assert.Equal(originalSessionId, result.RotatedFromSessionId);
Assert.Equal(SessionRotationReasons.OwnerMismatch, result.RotationReason);
}
private static BackendRefusalException TenantConflict()
@@ -313,6 +314,136 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Security
Assert.Equal(1, tracker.ConsecutiveFailures);
}
// ── 410 at registration: the backend deleted the session ────────────
private static BackendSessionGoneException SessionGone()
=> new BackendSessionGoneException("Backend returned 410 Gone: the session was deleted or is being deleted.", 410);
[Fact]
public async Task Session_gone_ends_the_run_at_once_without_retry_rotation_or_auth_failure()
{
using var tmp = new TempDirectory();
var logger = NewLogger(tmp);
var config = NewConfig();
var rotations = 0;
var apiClient = new FakeApiClient(_ => throw SessionGone());
var tracker = new AuthFailureTracker(maxFailures: 5, timeoutMinutes: 0,
clock: SystemClock.Instance, logger: logger);
// The rotation hook is wired on every start; without the Part 2 flag it must stay unused.
var result = await SessionRegistrationHelper.RegisterWithRetryAsync(
apiClient, config, agentVersion: "0.0.0", logger: logger,
authFailureTracker: tracker,
backoffDelay: _ => throw new InvalidOperationException("a 410 must not be retried"),
networkLinkWait: _ => Task.CompletedTask,
rotateSession: () => { rotations++; return Guid.NewGuid().ToString(); });
Assert.Equal(SessionRegistrationOutcome.SessionGone, result.Outcome);
Assert.Equal(410, result.HttpStatusCode);
Assert.Equal(1, apiClient.CallCount);
Assert.Equal(0, rotations);
Assert.Equal(0, tracker.ConsecutiveFailures);
Assert.Null(result.RotatedFromSessionId);
Assert.Null(result.RotationReason);
}
[Fact]
public async Task Session_gone_at_a_whiteglove_part2_start_rotates_once_and_registers_the_new_session()
{
using var tmp = new TempDirectory();
var logger = NewLogger(tmp);
var config = NewConfig();
var originalSessionId = config.SessionId;
var rotatedTo = Guid.NewGuid().ToString();
var seenSessionIds = new System.Collections.Generic.List<string>();
var rotations = 0;
var apiClient = new FakeApiClient(
attempt => attempt == 1
? throw SessionGone()
: new RegisterSessionResponse { Success = true, SessionId = rotatedTo, ValidatedBy = ValidatorType.AutopilotV1 },
onRegister: r => seenSessionIds.Add(r.SessionId));
var tracker = new AuthFailureTracker(maxFailures: 5, timeoutMinutes: 0,
clock: SystemClock.Instance, logger: logger);
var result = await SessionRegistrationHelper.RegisterWithRetryAsync(
apiClient, config, agentVersion: "0.0.0", logger: logger,
authFailureTracker: tracker,
backoffDelay: _ => throw new InvalidOperationException("rotation must retry without backoff"),
networkLinkWait: _ => Task.CompletedTask,
rotateSession: () => { rotations++; config.SessionId = rotatedTo; return rotatedTo; },
rotateOnSessionGone: true);
Assert.Equal(SessionRegistrationOutcome.Succeeded, result.Outcome);
Assert.Equal(2, apiClient.CallCount);
Assert.Equal(1, rotations);
Assert.Equal(0, tracker.ConsecutiveFailures);
Assert.Equal(new[] { originalSessionId, rotatedTo }, seenSessionIds);
Assert.Equal(originalSessionId, result.RotatedFromSessionId);
Assert.Equal(SessionRotationReasons.SessionGone, result.RotationReason);
}
[Fact]
public async Task Second_session_gone_after_rotation_ends_the_run()
{
using var tmp = new TempDirectory();
var logger = NewLogger(tmp);
var config = NewConfig();
var rotations = 0;
var apiClient = new FakeApiClient(_ => throw SessionGone());
var result = await SessionRegistrationHelper.RegisterWithRetryAsync(
apiClient, config, agentVersion: "0.0.0", logger: logger,
backoffDelay: _ => throw new InvalidOperationException("a 410 must not be retried"),
networkLinkWait: _ => Task.CompletedTask,
rotateSession: () => { rotations++; config.SessionId = Guid.NewGuid().ToString(); return config.SessionId; },
rotateOnSessionGone: true);
Assert.Equal(SessionRegistrationOutcome.SessionGone, result.Outcome);
Assert.Equal(2, apiClient.CallCount);
Assert.Equal(1, rotations);
}
[Fact]
public async Task Session_gone_with_a_failing_rotation_ends_the_run()
{
using var tmp = new TempDirectory();
var logger = NewLogger(tmp);
var config = NewConfig();
var apiClient = new FakeApiClient(_ => throw SessionGone());
var result = await SessionRegistrationHelper.RegisterWithRetryAsync(
apiClient, config, agentVersion: "0.0.0", logger: logger,
networkLinkWait: _ => Task.CompletedTask,
rotateSession: () => throw new IOException("disk full"),
rotateOnSessionGone: true);
Assert.Equal(SessionRegistrationOutcome.SessionGone, result.Outcome);
Assert.Equal(1, apiClient.CallCount);
Assert.Null(result.RotatedFromSessionId);
}
[Fact]
public async Task Session_gone_at_a_whiteglove_part2_start_without_rotation_hook_ends_the_run()
{
using var tmp = new TempDirectory();
var logger = NewLogger(tmp);
var config = NewConfig();
var apiClient = new FakeApiClient(_ => throw SessionGone());
var result = await SessionRegistrationHelper.RegisterWithRetryAsync(
apiClient, config, agentVersion: "0.0.0", logger: logger,
networkLinkWait: _ => Task.CompletedTask,
rotateOnSessionGone: true);
Assert.Equal(SessionRegistrationOutcome.SessionGone, result.Outcome);
Assert.Equal(1, apiClient.CallCount);
}
[Fact]
public async Task Fails_after_six_exceptions_without_auth_error()
{
@@ -138,6 +138,37 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Transport
() => client.GetDiagnosticsUploadUrlAsync("tenant-1", "session-1", "package.zip"));
}
// ── 410: session gone, only when the backend said so ────────────────
[Fact]
public async Task Backend_410_on_registration_is_session_gone()
{
using var client = BuildClient(
HttpStatusCode.Gone,
"{\"success\":false,\"message\":\"Session is being deleted by an administrator (state=Tombstoned); registration is rejected.\"}",
"application/json");
var ex = await Assert.ThrowsAsync<BackendSessionGoneException>(
() => client.RegisterSessionAsync(new AutopilotMonitor.Shared.Models.SessionRegistration()));
Assert.Equal(410, ex.StatusCode);
}
[Fact]
public async Task A_410_without_the_backends_echo_stays_a_plain_http_error()
{
// Answered on the network path: the caller would end monitoring on a session-gone
// signal, so it must stay an ordinary, retried failure.
using var client = BuildClient(
HttpStatusCode.Gone,
"<html><head><title>Gone</title></head><body>Gone</body></html>",
"text/html",
fromBackend: false);
await Assert.ThrowsAsync<HttpRequestException>(
() => client.RegisterSessionAsync(new AutopilotMonitor.Shared.Models.SessionRegistration()));
}
[Theory]
[InlineData(null, null)]
[InlineData("", null)]
@@ -44,7 +44,7 @@
<Import Project="V2Isolation.targets" />
<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
</ItemGroup>
<ItemGroup>
@@ -3,8 +3,7 @@ using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
using System.Linq;
using System.Runtime.InteropServices;
using System.Text;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Interop;
namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
{
@@ -130,7 +129,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
try { pid = process.Id; } catch { }
try { session = process.SessionId; } catch { }
try { start = process.StartTime.ToUniversalTime(); } catch { }
try { path = QueryImagePath(pid); } catch { }
try { path = ProcessImagePath.Query(pid); } catch { }
if (path == null)
{
try { path = process.MainModule?.FileName; } catch { }
@@ -138,35 +137,5 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
return new ImeProcessCandidate(pid, session, path, start);
}
private const int PROCESS_QUERY_LIMITED_INFORMATION = 0x1000;
[DllImport("kernel32.dll", SetLastError = true)]
private static extern IntPtr OpenProcess(int desiredAccess, bool inheritHandle, int processId);
[DllImport("kernel32.dll", SetLastError = true)]
[return: MarshalAs(UnmanagedType.Bool)]
private static extern bool CloseHandle(IntPtr handle);
[DllImport("kernel32.dll", CharSet = CharSet.Unicode, SetLastError = true)]
[return: MarshalAs(UnmanagedType.Bool)]
private static extern bool QueryFullProcessImageName(IntPtr process, int flags, StringBuilder exeName, ref int size);
private static string QueryImagePath(int pid)
{
if (pid <= 0) return null;
var handle = OpenProcess(PROCESS_QUERY_LIMITED_INFORMATION, false, pid);
if (handle == IntPtr.Zero) return null;
try
{
var sb = new StringBuilder(1024);
int size = sb.Capacity;
return QueryFullProcessImageName(handle, 0, sb, ref size) && size > 0 ? sb.ToString(0, size) : null;
}
finally
{
CloseHandle(handle);
}
}
}
}
@@ -200,6 +200,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
public void Dispose()
{
Process attached;
lock (_lock)
{
if (_disposed) return;
@@ -208,12 +209,16 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
_discoveryTimer?.Dispose();
_discoveryTimer = null;
if (_imeProcess != null)
{
try { _imeProcess.Exited -= OnImeExited; } catch { }
_imeProcess.Dispose();
_imeProcess = null;
}
attached = _imeProcess;
_imeProcess = null;
}
// Not under the lock: .NET holds its own lock on the Process while it delivers Exited,
// OnImeExited takes _lock, and Process.Dispose waits for that delivery to finish.
if (attached != null)
{
try { attached.Exited -= OnImeExited; } catch { }
try { attached.Dispose(); } catch { }
}
}
}
@@ -194,6 +194,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
// subtree) into RJ's lifecycle.
private bool _packageWatchersArmed;
private bool _disposed;
// Set by Stop under _stateLock: a registry callback that is still running then must not
// arm or attach another watcher.
private bool _stopped;
public event EventHandler<RealmJoinDetectedEventArgs>? RealmJoinDetected;
public event EventHandler<RealmJoinResolvedEventArgs>? RealmJoinResolved;
@@ -228,6 +231,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
public void Start()
{
if (_disposed) throw new ObjectDisposedException(nameof(RealmJoinWatcher));
lock (_stateLock) { _stopped = false; }
// The Services\realmjoin gate is the SOLE entry point. HKLM\SOFTWARE\RealmJoin and
// the HKU watcher do not run until this fires — RJ presence is the prerequisite for
@@ -277,27 +281,37 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
{
try
{
var stoppedAny = false;
var watchers = new List<RegistryWatcher>(8);
lock (_stateLock)
{
stoppedAny |= DisposeAndNull(ref _servicesAppearanceWatcher);
stoppedAny |= DisposeAndNull(ref _machineSoftwareAppearanceWatcher);
stoppedAny |= DisposeAndNull(ref _userSoftwareAppearanceWatcher);
stoppedAny |= DisposeAndNull(ref _uninstallAppearanceWatcher);
_stopped = true;
Take(ref _servicesAppearanceWatcher, watchers);
Take(ref _machineSoftwareAppearanceWatcher, watchers);
Take(ref _userSoftwareAppearanceWatcher, watchers);
Take(ref _uninstallAppearanceWatcher, watchers);
_serviceRealmjoinDebounce?.Dispose(); _serviceRealmjoinDebounce = null;
_machineRealmJoinDebounce?.Dispose(); _machineRealmJoinDebounce = null;
_userRealmJoinDebounce?.Dispose(); _userRealmJoinDebounce = null;
_uninstallDebounce?.Dispose(); _uninstallDebounce = null;
stoppedAny |= DisposeAndNull(ref _serviceRealmjoinWatcher);
stoppedAny |= DisposeAndNull(ref _machineRealmJoinWatcher);
stoppedAny |= DisposeAndNull(ref _userRealmJoinWatcher);
stoppedAny |= DisposeAndNull(ref _uninstallWatcher);
Take(ref _serviceRealmjoinWatcher, watchers);
Take(ref _machineRealmJoinWatcher, watchers);
Take(ref _userRealmJoinWatcher, watchers);
Take(ref _uninstallWatcher, watchers);
}
// Disposed outside the lock: RegistryWatcher.Dispose waits for a callback that is
// still running, and the appearance callback takes _stateLock.
foreach (var watcher in watchers)
{
try { watcher.Dispose(); } catch { }
}
// Hosts call Stop and then Dispose, which stops again; only the pass that
// stopped a watcher logs.
if (stoppedAny) _logger.Info($"RealmJoinWatcher: stopped ({reason})");
if (watchers.Count > 0) _logger.Info($"RealmJoinWatcher: stopped ({reason})");
}
catch (Exception ex)
{
@@ -391,6 +405,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
Action clearSlot,
Action onAppeared)
{
lock (_stateLock) { if (_stopped) return; }
try
{
var watcher = new RegistryWatcher(
@@ -440,7 +455,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
{
lock (_stateLock)
{
if (_serviceRealmjoinWatcher != null) return;
if (_stopped || _serviceRealmjoinWatcher != null) return;
try
{
_serviceRealmjoinDebounce = new Timer(_ => CheckParameters(), null, Timeout.Infinite, Timeout.Infinite);
@@ -486,7 +501,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
{
lock (_stateLock)
{
if (_machineRealmJoinWatcher != null) return;
if (_stopped || _machineRealmJoinWatcher != null) return;
try
{
// Seed dedup sets with every package sub-key already present at arming time.
@@ -529,7 +544,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
{
lock (_stateLock)
{
if (_userRealmJoinWatcher != null) return;
if (_stopped || _userRealmJoinWatcher != null) return;
try
{
// Seed dedup sets — see AttachMachineRealmJoinSubtreeWatcher for rationale.
@@ -711,7 +726,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
{
lock (_stateLock)
{
if (_disposed || _uninstallWatcher != null) return;
if (_disposed || _stopped || _uninstallWatcher != null) return;
try
{
_uninstallDebounce = new Timer(_ => CheckAutoUpdate(), null, Timeout.Infinite, Timeout.Infinite);
@@ -941,12 +956,12 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
}
}
private static bool DisposeAndNull(ref RegistryWatcher? w)
// Caller holds _stateLock; the taken watchers are disposed after it is released.
private static void Take(ref RegistryWatcher? slot, List<RegistryWatcher> taken)
{
if (w == null) return false;
try { w.Dispose(); } catch { }
w = null;
return true;
if (slot == null) return;
taken.Add(slot);
slot = null;
}
// Test seams — drive the read paths deterministically without touching the real registry.
@@ -0,0 +1,45 @@
using System;
using System.Runtime.InteropServices;
using System.Text;
namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Interop
{
/// <summary>
/// Full image path of another process through <c>QueryFullProcessImageName</c>. It needs only
/// <c>PROCESS_QUERY_LIMITED_INFORMATION</c> and resolves across bitness, where
/// <c>Process.MainModule</c> throws.
/// </summary>
internal static class ProcessImagePath
{
private const int PROCESS_QUERY_LIMITED_INFORMATION = 0x1000;
[DllImport("kernel32.dll", SetLastError = true)]
private static extern IntPtr OpenProcess(int desiredAccess, bool inheritHandle, int processId);
[DllImport("kernel32.dll", SetLastError = true)]
[return: MarshalAs(UnmanagedType.Bool)]
private static extern bool CloseHandle(IntPtr handle);
[DllImport("kernel32.dll", CharSet = CharSet.Unicode, SetLastError = true)]
[return: MarshalAs(UnmanagedType.Bool)]
private static extern bool QueryFullProcessImageName(IntPtr process, int flags, StringBuilder exeName, ref int size);
/// <summary>The path, or <c>null</c> when the process cannot be opened or queried.</summary>
public static string Query(int pid)
{
if (pid <= 0) return null;
var handle = OpenProcess(PROCESS_QUERY_LIMITED_INFORMATION, false, pid);
if (handle == IntPtr.Zero) return null;
try
{
var sb = new StringBuilder(1024);
int size = sb.Capacity;
return QueryFullProcessImageName(handle, 0, sb, ref size) && size > 0 ? sb.ToString(0, size) : null;
}
finally
{
CloseHandle(handle);
}
}
}
}
@@ -1,3 +1,4 @@
using System;
using System.Management;
namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Interop
@@ -121,5 +122,28 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Interop
return null;
}
/// <summary>
/// Owner SID of a <c>Win32_Process</c> row via <c>GetOwnerSid</c>, or <c>null</c> on failure.
/// The row must have been selected with <c>Handle</c>: without its key property WMI cannot
/// invoke a method on the object and throws.
/// </summary>
public static string OwnerSid(ManagementObject process)
{
try
{
using (var result = process.InvokeMethod("GetOwnerSid", null, null))
{
if (result != null && Convert.ToUInt32(result["ReturnValue"]) == 0)
return result["Sid"]?.ToString();
}
}
catch
{
// Process gone or owner not readable.
}
return null;
}
}
}
@@ -1,5 +1,6 @@
using System;
using System.Collections.Generic;
using System.Globalization;
using System.IO;
using System.Linq;
using System.Management;
@@ -36,21 +37,21 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
/// (<c>builtin_administrator_enabled</c>) but not scored: whether OOBE enables it
/// transiently is not established, so the field first collects evidence.
///
/// Built-in accounts are recognised by well-known RID (500/501/503/504 on the machine SID)
/// in addition to their English names, so localized installs (Gast, Invité, Administrateur)
/// do not flag their own disabled Guest/Administrator.
/// Allowed list (<see cref="LocalAdminAllowList"/> built-ins plus the tenant's entries): an entry
/// allows an account in any role, or — <c>name|user</c> — only while it is not an
/// Administrators member. A restriction always wins over an entry that allows more. The four
/// built-in accounts are decided by their well-known RID alone (500 any role; 501/503/504 never
/// an administrator), so localized names (Gast, Administrateur) are recognised and no name entry
/// can lift or impose a role on them. Profile folders have no role.
///
/// At shutdown the logged-in users are allowed dynamically — but only identities that are
/// NOT local SAM accounts (Entra / domain users, whose profile folder is the only artifact
/// they leave). A logged-in local account is exactly the delta this analyzer exists to
/// catch and is never exempted by its own login (CWE-807: the login state is under the
/// At shutdown the logged-in users are allowed dynamically — as profile folders only, and only
/// identities that are NOT local SAM accounts (Entra / domain users, whose profile folder is the
/// only artifact they leave). A logged-in local account is exactly the delta this analyzer exists
/// to catch and is never exempted by its own login (CWE-807: the login state is under the
/// adversary's control); it is reported as <c>logged_in_local_accounts</c>.
///
/// Emits a single "local_admin_analysis" event at startup and at shutdown,
/// enabling delta detection between pre- and post-enrollment state.
///
/// Tenant-supplied allowed accounts may contain glob wildcards (e.g. "adm-*");
/// see <see cref="MatchesAllowedEntry"/>.
/// </summary>
public class LocalAdminAnalyzer : IAgentAnalyzer
{
@@ -58,26 +59,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
private readonly string _tenantId;
private readonly InformationalEventPost _post;
private readonly AgentLogger _logger;
private readonly List<string> _allowedAccounts;
// Built-in accounts and profile folders always present on a freshly imaged Windows device.
// "Public", "Default", "Default User", "All Users" are folders/junctions in C:\Users, not user accounts.
// "defaultuser0" is a temporary OOBE/Autopilot system account created during enrollment.
private static readonly List<string> BuiltInAllowedAccounts = new List<string>
{
"Administrator",
"Guest",
"DefaultAccount",
"WDAGUtilityAccount",
"defaultuser0", // Temporary OOBE/Autopilot system account, present during enrollment
"defaultuser1", // Sometimes seen in OOBE, but not always present
"defaultuser2", // Sometimes seen in OOBE, but not always present
"kioskUser0", // Assigned Access (kiosk profile) autologon account, created by Windows
"Public", // Profile folder (not a user account)
"Default", // Default user profile template
"Default User", // Symlink to Default in some Windows versions
"All Users" // Junction pointing to C:\ProgramData, always present
};
private readonly List<AllowedEntry> _allowedEntries;
public string Name => "LocalAdminAnalyzer";
@@ -97,19 +79,10 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
_logger = logger ?? throw new ArgumentNullException(nameof(logger));
_startupGate = startupGate;
// Tenant-supplied accounts are additive (union with built-ins, not replacement)
_allowedAccounts = new List<string>(BuiltInAllowedAccounts);
if (allowedAccounts != null)
{
foreach (var account in allowedAccounts)
{
if (!string.IsNullOrWhiteSpace(account) &&
!_allowedAccounts.Any(a => string.Equals(a, account, StringComparison.OrdinalIgnoreCase)))
{
_allowedAccounts.Add(account);
}
}
}
var ignored = new List<string>();
_allowedEntries = BuildAllowedEntries(allowedAccounts, ignored);
foreach (var entry in ignored)
_logger.Warning($"{Name}: Allowed-list entry '{entry}' is not valid (expected 'name' or 'name|user') — ignored, it allows nothing");
}
public void AnalyzeAtStartup()
@@ -149,46 +122,29 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
foreach (var user in loggedIn.LocalAccounts)
_logger.Warning($"{Name}: Logged-in user '{user}' is a local account — not allowed dynamically");
// Build effective allowed list: static + dynamic (non-local logged-in users at shutdown)
var effectiveAllowed = _allowedAccounts;
// Effective list: static entries + the profile folders of non-local logged-in users at
// shutdown. Folder-only: a login never allows a local ACCOUNT — not even when the WMI
// inventory failed and the split above could not recognise a local name.
var effectiveEntries = _allowedEntries;
if (loggedIn.Allowed.Count > 0)
{
effectiveAllowed = new List<string>(_allowedAccounts);
effectiveEntries = new List<AllowedEntry>(_allowedEntries);
foreach (var user in loggedIn.Allowed)
{
if (!effectiveAllowed.Any(a => string.Equals(a, user, StringComparison.OrdinalIgnoreCase)))
if (!effectiveEntries.Any(e => string.Equals(e.Pattern, user, StringComparison.OrdinalIgnoreCase)))
{
effectiveAllowed.Add(user);
_logger.Info($"{Name}: Dynamically allowing logged-in user: {user}");
effectiveEntries.Add(new AllowedEntry(user, LocalAccountRole.Any, profileFolderOnly: true));
_logger.Info($"{Name}: Dynamically allowing profile folder of logged-in user: {user}");
}
}
}
var bypassNroResult = CheckBypassNroRegistry();
var accountsResult = CheckLocalAdminAccounts(localAccounts, effectiveAllowed);
var profilesResult = CheckUserProfiles(effectiveAllowed);
var accountsResult = CheckLocalAdminAccounts(localAccounts, effectiveEntries);
var profilesResult = CheckUserProfiles(effectiveEntries);
int confidenceScore = 0;
if (bypassNroResult.Value == 1)
confidenceScore += 20;
if (accountsResult.Unexpected.Count > 0)
confidenceScore += 40;
// An unexpected account that is also a member of Administrators is the
// actual backdoor (enabled or dormant) — high indicator on its own.
if (accountsResult.UnexpectedAdminMembers.Count > 0)
confidenceScore += 40;
// Profile overlap: unexpected account AND matching C:\Users folder
bool profileOverlap = accountsResult.Unexpected.Any(a =>
profilesResult.Unexpected.Any(p =>
string.Equals(a, p, StringComparison.OrdinalIgnoreCase)));
if (profileOverlap)
confidenceScore += 40;
confidenceScore = Math.Min(confidenceScore, 100);
var confidenceScore = ComputeConfidenceScore(
bypassNroResult.Value == 1, accountsResult.Unexpected, accountsResult.UnexpectedAdminMembers, profilesResult.Unexpected);
EventSeverity severity;
string findingLabel;
@@ -219,6 +175,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
$"bypassNro={bypassNroResult.Value}, " +
$"unexpectedAccounts={accountsResult.Unexpected.Count}, " +
$"unexpectedAdminMembers={accountsResult.UnexpectedAdminMembers.Count}, " +
$"roleViolations={accountsResult.RoleViolations.Count}, " +
$"adminGroupEnumerated={accountsResult.AdministratorsGroupEnumerated}, " +
$"builtinAdministratorEnabled={accountsResult.BuiltInAdministratorEnabled?.ToString() ?? "unknown"}, " +
$"unexpectedProfiles={profilesResult.Unexpected.Count}");
@@ -230,7 +187,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
{ "finding", findingLabel },
{ "triggered_at", trigger },
{ "enrollment_phase_at_check", phase.ToString() },
{ "allowed_accounts", effectiveAllowed },
// Account entries in canonical form ("Guest|user"); the folder-only entries are
// constant or listed in dynamically_allowed_users.
{ "allowed_accounts", _allowedEntries.Where(e => !e.ProfileFolderOnly).Select(e => e.Display).ToList() },
{ "dynamically_allowed_users", loggedIn.Allowed },
{ "logged_in_local_accounts", loggedIn.LocalAccounts },
{ "checks", new Dictionary<string, object>
@@ -243,6 +202,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
},
{ "unexpected_accounts", accountsResult.Unexpected },
{ "unexpected_admin_members", accountsResult.UnexpectedAdminMembers },
{ "role_violations", accountsResult.RoleViolations },
{ "unexpected_profiles", profilesResult.Unexpected },
{ "accounts_checked", accountsResult.AllChecked },
{ "account_details", accountsResult.AccountDetails },
@@ -299,31 +259,53 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
}
}
/// <summary>
/// Confidence 0-100: BypassNRO +20, any unexpected account +40, any unexpected Administrators
/// member +40 (the actual backdoor, enabled or dormant; a role violation is one), an unexpected
/// account with a C:\Users folder of the same name +40. Pure; internal for unit-testing.
/// </summary>
internal static int ComputeConfidenceScore(
bool bypassNro, IList<string> unexpectedAccounts, IList<string> unexpectedAdminMembers, IList<string> unexpectedProfiles)
{
var score = 0;
if (bypassNro)
score += 20;
if (unexpectedAccounts.Count > 0)
score += 40;
if (unexpectedAdminMembers.Count > 0)
score += 40;
if (unexpectedAccounts.Any(a => unexpectedProfiles.Any(p => string.Equals(a, p, StringComparison.OrdinalIgnoreCase))))
score += 40;
return Math.Min(score, 100);
}
// -----------------------------------------------------------------------
// Allowed-list matching
// -----------------------------------------------------------------------
/// <summary>
/// Matches an account or profile-folder name against one allowed-list entry.
/// Entries containing <c>*</c> or <c>?</c> are glob patterns (same semantics as the
/// Matches an account or profile-folder name against one allowed-list pattern.
/// Patterns containing <c>*</c> or <c>?</c> are globs (same semantics as the
/// hardware whitelist: <c>*</c> = any run, <c>?</c> = one char, case-insensitive);
/// all other entries match exactly. No ambiguity with literal names — <c>*</c> and
/// all other patterns match exactly. No ambiguity with literal names — <c>*</c> and
/// <c>?</c> are invalid characters in Windows account names.
/// Internal for direct unit-testing via InternalsVisibleTo.
/// </summary>
internal static bool MatchesAllowedEntry(string name, string entry)
internal static bool MatchesAllowedEntry(string name, string pattern)
{
if (entry.IndexOf('*') < 0 && entry.IndexOf('?') < 0)
return string.Equals(entry, name, StringComparison.OrdinalIgnoreCase);
if (pattern.IndexOf('*') < 0 && pattern.IndexOf('?') < 0)
return string.Equals(pattern, name, StringComparison.OrdinalIgnoreCase);
var regexPattern = "^" + Regex.Escape(entry)
var regexPattern = "^" + Regex.Escape(pattern)
.Replace("\\*", ".*")
.Replace("\\?", ".") + "$";
try
{
// Timeout guards against pathological patterns (ReDoS)
return Regex.IsMatch(name, regexPattern, RegexOptions.IgnoreCase, TimeSpan.FromMilliseconds(100));
// Timeout guards against pathological patterns (ReDoS). CultureInvariant: under a
// Turkish culture "i" and "I" are no case pair, so "WLapsAdmin*" missed "WLAPSADMIN01".
return Regex.IsMatch(name, regexPattern, RegexOptions.IgnoreCase | RegexOptions.CultureInvariant,
TimeSpan.FromMilliseconds(100));
}
catch (RegexMatchTimeoutException)
{
@@ -331,39 +313,107 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
}
}
private static bool IsAllowed(string name, List<string> allowedAccounts)
/// <summary>
/// The effective static list: the built-in account-name and profile-folder entries of
/// <see cref="LocalAdminAllowList.BuiltIns"/> (RID entries are decided by RID, see
/// <see cref="Decide"/>) plus the tenant's entries. An entry that does not parse is added to
/// <paramref name="ignored"/> and allows nothing. Pure; internal for unit-testing.
/// </summary>
internal static List<AllowedEntry> BuildAllowedEntries(IEnumerable<string> tenantEntries, List<string> ignored)
{
return allowedAccounts.Any(a => MatchesAllowedEntry(name, a));
var entries = new List<AllowedEntry>();
foreach (var builtIn in LocalAdminAllowList.BuiltIns)
{
if (builtIn.Match == LocalAdminBuiltInMatch.AccountName)
AddDistinct(entries, new AllowedEntry(builtIn.Name, builtIn.Role, profileFolderOnly: false));
else if (builtIn.Match == LocalAdminBuiltInMatch.ProfileFolder)
AddDistinct(entries, new AllowedEntry(builtIn.Name, LocalAccountRole.Any, profileFolderOnly: true));
}
foreach (var raw in tenantEntries ?? Enumerable.Empty<string>())
{
if (LocalAdminAllowList.TryParseEntry(raw, out var pattern, out var role))
AddDistinct(entries, new AllowedEntry(pattern, role, profileFolderOnly: false));
else if (!string.IsNullOrWhiteSpace(raw))
ignored.Add(raw);
}
return entries;
}
private static void AddDistinct(List<AllowedEntry> entries, AllowedEntry entry)
{
if (!entries.Any(e => e.ProfileFolderOnly == entry.ProfileFolderOnly
&& string.Equals(e.Display, entry.Display, StringComparison.OrdinalIgnoreCase)))
entries.Add(entry);
}
/// <summary>
/// Well-known built-in accounts of the local machine domain, recognised by RID so that
/// localized names (Gast, Invité, Administrateur, …) are not flagged:
/// 500 Administrator, 501 Guest, 503 DefaultAccount, 504 WDAGUtilityAccount.
/// Only S-1-5-21-… SIDs qualify (the WMI query is already restricted to local accounts).
/// Decides one local account. The built-in accounts are decided by their RID alone: 500 in any
/// role, 501/503/504 never as an administrator — no name entry, built-in or tenant, lifts or
/// imposes a role on them. Without a SID (a WMI corner case) the English name stands in for the
/// RID. Every other account is allowed when an account entry matches it, unless it is an
/// administrator and ANY matching entry is standard-user only: a restriction always wins.
/// Pure; internal for unit-testing.
/// </summary>
internal static AccountDecision Decide(string name, string sid, bool isAdmin, IReadOnlyList<AllowedEntry> allowed)
{
var builtIn = FindBuiltInRidEntry(name, sid);
if (builtIn != null)
return isAdmin && builtIn.Role == LocalAccountRole.StandardUser ? AccountDecision.RoleViolation : AccountDecision.Allowed;
var covered = false;
var restricted = false;
foreach (var entry in allowed)
{
if (entry.ProfileFolderOnly || !MatchesAllowedEntry(name, entry.Pattern))
continue;
covered = true;
if (entry.Role == LocalAccountRole.StandardUser)
restricted = true;
}
if (!covered)
return AccountDecision.Unlisted;
return isAdmin && restricted ? AccountDecision.RoleViolation : AccountDecision.Allowed;
}
private static LocalAdminBuiltInEntry FindBuiltInRidEntry(string name, string sid)
{
var rid = MachineAccountRid(sid);
foreach (var builtIn in LocalAdminAllowList.BuiltIns)
{
if (builtIn.Match != LocalAdminBuiltInMatch.Rid)
continue;
var matches = rid.HasValue
? builtIn.Rid == rid.Value
: string.IsNullOrEmpty(sid) && string.Equals(builtIn.Name, name, StringComparison.OrdinalIgnoreCase);
if (matches)
return builtIn;
}
return null;
}
/// <summary>
/// RID (the last sub-authority) of a local-machine account SID (<c>S-1-5-21-…</c>; the WMI query
/// and the member filter already restrict to local accounts), else null.
/// Internal for direct unit-testing via InternalsVisibleTo.
/// </summary>
internal static bool IsWellKnownBuiltInRid(string sid)
internal static int? MachineAccountRid(string sid)
{
if (string.IsNullOrEmpty(sid) || !sid.StartsWith("S-1-5-21-", StringComparison.Ordinal))
return false;
return null;
var dash = sid.LastIndexOf('-');
if (dash < 0 || dash == sid.Length - 1)
return false;
switch (sid.Substring(dash + 1))
{
case "500":
case "501":
case "503":
case "504":
return true;
default:
return false;
}
return int.TryParse(sid.Substring(dash + 1), NumberStyles.None, CultureInfo.InvariantCulture, out var rid)
? rid
: (int?)null;
}
/// <summary>A profile folder has no role: any entry of the same name allows it.</summary>
private static bool IsAllowedFolder(string folderName, IReadOnlyList<AllowedEntry> allowed)
=> allowed.Any(e => MatchesAllowedEntry(folderName, e.Pattern));
/// <summary>
/// Splits the logged-in user names into those that may be allowed dynamically (not a
/// local SAM account — Entra / domain identities whose only artifact is a profile
@@ -481,7 +531,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
return accounts;
}
private LocalAccountCheckResult CheckLocalAdminAccounts(List<LocalAccountInfo> accounts, List<string> allowedAccounts)
private LocalAccountCheckResult CheckLocalAdminAccounts(List<LocalAccountInfo> accounts, IReadOnlyList<AllowedEntry> allowed)
{
// Administrators-group membership is read from the SAM, independent of WMI and of
// the enabled state — a dormant backdoor with admin rights is still a member.
@@ -489,13 +539,15 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
if (!group.Succeeded)
_logger.Warning($"{Name}: Failed to enumerate members of '{group.GroupName}': NET_API_STATUS={group.ErrorCode}");
var result = EvaluateAccounts(accounts, group.Members, group.Succeeded, Environment.MachineName, allowedAccounts);
var result = EvaluateAccounts(accounts, group.Members, group.Succeeded, Environment.MachineName, allowed);
result.AdministratorsGroupErrorCode = group.ErrorCode;
foreach (var name in result.Unexpected)
_logger.Debug($"{Name}: Unexpected local account: {name}");
foreach (var name in result.UnexpectedAdminMembers)
_logger.Debug($"{Name}: Unexpected Administrators member: {name}");
foreach (var name in result.RoleViolations)
_logger.Debug($"{Name}: Allowed only as a standard user but an Administrators member: {name}");
return result;
}
@@ -508,10 +560,13 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
/// - every local account is checked, disabled ones included (state is reported);
/// - a local account is an Administrators member when its SID matches a group member,
/// or (SID unavailable) its name matches a member of the local machine domain;
/// - an account is allowed by name (allowed list, globs) or by well-known RID
/// (<see cref="IsWellKnownBuiltInRid"/>) — localized built-ins are never flagged;
/// - <c>UnexpectedAdminMembers</c> = unexpected accounts holding membership, plus local
/// members not on the allowed list that the WMI inventory did not return at all;
/// - each account is decided by <see cref="Decide"/>; an account no entry allows, or one
/// that breaks a standard-user entry, is unexpected (and an unexpected admin when it
/// holds membership; the latter also a role violation);
/// - local members the WMI inventory did not return at all are decided as administrators
/// and land in both unexpected lists, like any unknown administrator;
/// - with membership unknown (enumeration failed) nobody counts as an administrator, so a
/// standard-user entry acts like a plain one;
/// - members outside the local machine domain (Entra role SIDs, domain groups) are
/// listed for delta comparison but never flagged — they are expected on joined devices.
/// </summary>
@@ -520,7 +575,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
IList<LocalGroupMember> adminMembers,
bool adminGroupEnumerated,
string machineName,
List<string> allowedAccounts)
IReadOnlyList<AllowedEntry> allowed)
{
var result = new LocalAccountCheckResult { AdministratorsGroupEnumerated = adminGroupEnumerated };
@@ -539,45 +594,65 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
}
}
var inventorySids = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
var inventoryNames = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
foreach (var account in accounts ?? new List<LocalAccountInfo>())
{
var isAdmin = (!string.IsNullOrEmpty(account.Sid) && adminSids.Contains(account.Sid))
|| adminLocalNames.Contains(account.Name);
var rid = MachineAccountRid(account.Sid);
if (!string.IsNullOrEmpty(account.Sid))
inventorySids.Add(account.Sid);
inventoryNames.Add(account.Name);
result.AllChecked.Add(account.Name);
result.AccountDetails.Add(new Dictionary<string, object>
{
{ "name", account.Name },
{ "disabled", account.Disabled },
{ "administrators_member", isAdmin }
{ "administrators_member", isAdmin },
{ "rid", rid }
});
if (account.Sid != null && account.Sid.EndsWith("-500", StringComparison.Ordinal))
if (rid == 500)
result.BuiltInAdministratorEnabled = !account.Disabled;
if (IsWellKnownBuiltInRid(account.Sid) || IsAllowed(account.Name, allowedAccounts))
continue;
result.Unexpected.Add(account.Name);
if (isAdmin)
result.UnexpectedAdminMembers.Add(account.Name);
Record(result, account.Name, Decide(account.Name, account.Sid, isAdmin, allowed), isAdmin);
}
// Local members the WMI inventory did not surface (WMI failure, or an account the
// provider does not list) — still an unexpected admin when not on the allowed list.
// provider does not list): the SAM is authoritative for membership.
foreach (var member in adminLocalMembers)
{
var name = member.Name;
if (IsWellKnownBuiltInRid(member.Sid) || IsAllowed(name, allowedAccounts))
var returnedByWmi = !string.IsNullOrEmpty(member.Sid)
? inventorySids.Contains(member.Sid)
: inventoryNames.Contains(member.Name);
if (returnedByWmi)
continue;
if (result.UnexpectedAdminMembers.Any(u => string.Equals(u, name, StringComparison.OrdinalIgnoreCase)))
continue;
result.UnexpectedAdminMembers.Add(name);
Record(result, member.Name, Decide(member.Name, member.Sid, isAdmin: true, allowed), isAdmin: true);
}
return result;
}
private static void Record(LocalAccountCheckResult result, string name, AccountDecision decision, bool isAdmin)
{
if (decision == AccountDecision.Allowed)
return;
AddOnce(result.Unexpected, name);
if (isAdmin)
AddOnce(result.UnexpectedAdminMembers, name);
if (decision == AccountDecision.RoleViolation)
AddOnce(result.RoleViolations, name);
}
private static void AddOnce(List<string> names, string name)
{
if (!names.Any(n => string.Equals(n, name, StringComparison.OrdinalIgnoreCase)))
names.Add(name);
}
private static bool IsLocalMember(LocalGroupMember member, string machineName)
{
var domain = member.Domain;
@@ -586,7 +661,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
return string.Equals(domain, machineName, StringComparison.OrdinalIgnoreCase);
}
private UserProfileCheckResult CheckUserProfiles(List<string> allowedAccounts)
private UserProfileCheckResult CheckUserProfiles(IReadOnlyList<AllowedEntry> allowed)
{
var allFound = new List<string>();
var unexpected = new List<string>();
@@ -616,7 +691,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
allFound.Add(folderName);
if (!IsAllowed(folderName, allowedAccounts))
if (!IsAllowedFolder(folderName, allowed))
{
unexpected.Add(folderName);
_logger.Debug($"{Name}: Unexpected profile folder: {folderName}");
@@ -740,7 +815,10 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
/// <summary>Unexpected accounts that are members of the Administrators group.</summary>
public List<string> UnexpectedAdminMembers { get; set; } = new List<string>();
/// <summary>Per-account state: name, disabled, administrators_member.</summary>
/// <summary>Administrators members that an entry allows only as a standard user (subset of <see cref="UnexpectedAdminMembers"/>).</summary>
public List<string> RoleViolations { get; set; } = new List<string>();
/// <summary>Per-account state: name, disabled, administrators_member, rid.</summary>
public List<Dictionary<string, object>> AccountDetails { get; set; } = new List<Dictionary<string, object>>();
/// <summary>Every Administrators member (DOMAIN\name or SID), local or not — for delta comparison.</summary>
@@ -753,6 +831,38 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Analyzers
public bool? BuiltInAdministratorEnabled { get; set; }
}
/// <summary>One effective allowed-list entry: a name or glob and what it may allow.</summary>
internal sealed class AllowedEntry
{
public AllowedEntry(string pattern, LocalAccountRole role, bool profileFolderOnly)
{
Pattern = pattern;
Role = role;
ProfileFolderOnly = profileFolderOnly;
}
public string Pattern { get; }
public LocalAccountRole Role { get; }
/// <summary>Allows the C:\Users folder of this name, never a local account.</summary>
public bool ProfileFolderOnly { get; }
/// <summary>Canonical entry text as the event lists it ("Guest|user").</summary>
public string Display => LocalAdminAllowList.Format(Pattern, Role);
}
internal enum AccountDecision
{
Allowed,
/// <summary>No entry allows the account.</summary>
Unlisted,
/// <summary>An administrator that a standard-user entry (or a built-in RID) allows only as a standard user.</summary>
RoleViolation,
}
/// <summary>Logged-in users at shutdown, split by whether the name is a local SAM account.</summary>
internal sealed class LoggedInUserSplit
{
@@ -79,11 +79,14 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
public void Start()
{
bool raise;
lock (_lock)
{
if (_disposed) return;
TryArm();
raise = TryArm();
}
if (raise) Raise();
}
/// <summary>
@@ -129,17 +132,14 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
}
}
// Caller holds _lock.
private void TryArm()
// Caller holds _lock. Returns true when BinaryAppeared is due; the caller raises it after
// releasing the lock, like OnRecheck does — the handler probes and may dispose this watcher.
private bool TryArm()
{
if (_disposed || _fsw != null) return;
if (_disposed || _fsw != null) return false;
// Initial scan — the binaries may already be present (armed late / update over existing).
if (CoreBinariesPresent())
{
Raise();
return;
}
if (CoreBinariesPresent()) return true;
if (!Directory.Exists(_installationPath))
{
@@ -154,7 +154,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
{
_logger.Debug($"[OfficeBinaryWatcher] install path '{_installationPath}' never appeared — giving up (no completion proof)");
}
return;
return false;
}
try
@@ -172,17 +172,21 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
_logger.Info($"[OfficeBinaryWatcher] watching '{_installationPath}' for core Office binaries");
// Race: a binary may have appeared between the scan above and arming — re-scan once.
if (CoreBinariesPresent()) Raise();
return CoreBinariesPresent();
}
catch (Exception ex)
{
_logger.Warning($"[OfficeBinaryWatcher] could not watch '{_installationPath}': {ex.Message}");
return false;
}
}
private void OnArmRetry(object? state)
{
lock (_lock) { TryArm(); }
bool raise;
lock (_lock) { raise = TryArm(); }
if (raise) Raise();
}
private void OnFileEvent(object sender, FileSystemEventArgs e) => CheckCandidate(e.Name);
@@ -4,6 +4,7 @@ using System.Collections.Generic;
using System.Diagnostics;
using System.Management;
using System.Threading;
using System.Threading.Tasks;
using AutopilotMonitor.Agent.V2.Core.Logging;
namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
@@ -15,7 +16,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
/// idle polling:
/// <list type="bullet">
/// <item><b>Start</b> — a true ETW-backed push via WMI <c>Win32_ProcessStartTrace</c>
/// (<see cref="ManagementEventWatcher"/>), plus a one-shot startup probe so an install already
/// (<see cref="ManagementEventWatcher"/>), plus a startup probe so an install already
/// in flight when the agent boots (realistic during OOBE) is still caught.</item>
/// <item><b>Stop</b> — <see cref="Process.Exited"/> on each tracked worker (clean OS event, same
/// pattern as <c>ImeProcessWatcher</c>).</item>
@@ -26,6 +27,12 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
/// a single active window). Fail-soft: if the WMI watcher cannot start, it is logged and the
/// startup probe still covers the already-running case — no polling fallback by design.
/// </para>
/// <para>
/// <b>Locking</b>: the lock guards this watcher's own state. No event is raised and no
/// <see cref="Process"/> is disposed while it is held: .NET holds its own lock on a
/// <see cref="Process"/> for as long as it delivers <see cref="Process.Exited"/>, that handler
/// takes this lock, and <see cref="Process.Dispose()"/> waits for the delivery to finish.
/// </para>
/// </summary>
public sealed class OfficeProcessWatcher : IDisposable
{
@@ -53,6 +60,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
/// </summary>
public event EventHandler? Stopped;
/// <summary>Test seam: enumerates the running workers (default: Process.GetProcessesByName).</summary>
internal Func<Process[]> WorkerSource { get; set; } = () => Process.GetProcessesByName(WorkerProcessNameNoExt);
/// <param name="settleSeconds">Grace period after the last worker exits before the window is
/// declared closed; a new worker within it keeps the window open. &lt;=0 closes immediately.</param>
public OfficeProcessWatcher(AgentLogger logger, int settleSeconds = 10)
@@ -67,7 +77,10 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
get { lock (_lock) { return _active; } }
}
public void Start()
public void Start() => Start(armWmi: true);
/// <summary>Test seam: <paramref name="armWmi"/> = false leaves out the WMI subscription.</summary>
internal void Start(bool armWmi)
{
lock (_lock)
{
@@ -75,10 +88,22 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
_started = true;
}
// 1) Startup probe — catch a worker already running before the watcher armed.
// 1) Startup probe — catch a worker already running before the subscription exists. It
// stays on the caller's thread: it needs no WMI, so a worker that is already running is
// reported even when the subscription below never completes.
ProbeRunningWorkers();
// 2) ETW-backed push on worker creation — no polling. WinMgmt can hang during OOBE, so the
// subscription never runs on the caller's thread (the orchestrator starts its hosts one
// after another on it).
if (armWmi) Task.Run(() => ArmStartTrace());
}
private void ProbeRunningWorkers()
{
try
{
foreach (var proc in Process.GetProcessesByName(WorkerProcessNameNoExt))
foreach (var proc in WorkerSource())
{
TrackWorker(proc);
}
@@ -87,24 +112,52 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
{
_logger.Warning($"[OfficeProcessWatcher] startup probe failed: {ex.Message}");
}
}
// 2) ETW-backed push on worker creation — no polling.
private void ArmStartTrace()
{
ManagementEventWatcher? watcher = null;
try
{
var query = new WqlEventQuery(
$"SELECT * FROM Win32_ProcessStartTrace WHERE ProcessName = '{WorkerProcessName}'");
_startWatcher = new ManagementEventWatcher(query);
_startWatcher.EventArrived += OnProcessStartTrace;
_startWatcher.Start();
_logger.Info($"[OfficeProcessWatcher] watching Win32_ProcessStartTrace for {WorkerProcessName}");
watcher = new ManagementEventWatcher(new WqlEventQuery(
$"SELECT * FROM Win32_ProcessStartTrace WHERE ProcessName = '{WorkerProcessName}'"));
watcher.EventArrived += OnProcessStartTrace;
watcher.Start();
}
catch (Exception ex)
{
// No polling fallback by design — the startup probe already covers the in-flight case.
_logger.Warning($"[OfficeProcessWatcher] could not start WMI process-start watcher " +
$"({ex.GetType().Name}: {ex.Message}); relying on the startup probe only.");
_startWatcher = null;
if (watcher != null) TearDownStartTrace(watcher);
return;
}
// Published only once it is armed, so Dispose never meets a half-started subscription; one
// that completes after Dispose is taken down right here.
bool keep;
lock (_lock)
{
keep = !_disposed;
if (keep) _startWatcher = watcher;
}
if (!keep)
{
TearDownStartTrace(watcher);
return;
}
_logger.Info($"[OfficeProcessWatcher] watching Win32_ProcessStartTrace for {WorkerProcessName}");
// A worker may have started between the probe in Start and the subscription.
ProbeRunningWorkers();
}
private void TearDownStartTrace(ManagementEventWatcher watcher)
{
try { watcher.EventArrived -= OnProcessStartTrace; } catch { }
try { watcher.Stop(); } catch { }
try { watcher.Dispose(); } catch { }
}
private void OnProcessStartTrace(object sender, EventArrivedEventArgs e)
@@ -113,12 +166,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
{
var pidObj = e.NewEvent?["ProcessID"];
if (pidObj == null) return;
var pid = Convert.ToInt32(pidObj);
Process? proc = null;
try { proc = Process.GetProcessById(pid); }
catch { /* already gone — ignore */ }
if (proc != null) TrackWorker(proc);
TrackTracedProcess(Convert.ToInt32(pidObj), WorkerProcessNameNoExt);
}
catch (Exception ex)
{
@@ -126,41 +174,76 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
}
}
/// <summary>
/// Tracks the process a start trace announced (internal for tests). WMI delivers the trace
/// with a delay, so the id may already belong to another process: only a process that still
/// carries the worker's name is tracked. A foreign process would hold the install window
/// open until it exits.
/// </summary>
internal void TrackTracedProcess(int pid, string processNameNoExt)
{
Process? proc = null;
try { proc = Process.GetProcessById(pid); }
catch { /* already gone — ignore */ }
if (proc == null) return;
bool isWorker;
try { isWorker = string.Equals(proc.ProcessName, processNameNoExt, StringComparison.OrdinalIgnoreCase); }
catch { isWorker = false; /* exited between the lookup and the name read */ }
if (isWorker)
{
TrackWorker(proc);
return;
}
try { proc.Dispose(); } catch { }
}
private void TrackWorker(Process proc)
{
bool tracked = false;
bool raiseStarted = false;
try
{
lock (_lock)
{
if (_disposed) { try { proc.Dispose(); } catch { } return; }
if (_workers.ContainsKey(proc.Id)) { try { proc.Dispose(); } catch { } return; }
if (!_disposed && !_workers.ContainsKey(proc.Id))
{
try
{
proc.EnableRaisingEvents = true;
proc.Exited += OnWorkerExited;
tracked = true;
}
catch
{
// Process exited between discovery and Exited-hookup — drop it.
}
try
{
proc.EnableRaisingEvents = true;
proc.Exited += OnWorkerExited;
}
catch
{
// Process exited between discovery and Exited-hookup — drop it.
try { proc.Dispose(); } catch { }
return;
}
_workers[proc.Id] = proc;
// A worker is back — cancel any pending settle (the window must stay open).
CancelSettleTimer();
if (!_active)
{
_active = true;
raiseStarted = true;
if (tracked)
{
_workers[proc.Id] = proc;
// A worker is back — cancel any pending settle (the window must stay open).
CancelSettleTimer();
if (!_active)
{
_active = true;
raiseStarted = true;
}
}
}
}
}
catch (Exception ex)
{
_logger.Debug($"[OfficeProcessWatcher] TrackWorker error: {ex.Message}");
}
if (!tracked)
{
// Disposed, already tracked under another handle, or gone before the hookup.
try { proc.Dispose(); } catch { }
return;
}
@@ -169,6 +252,11 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
_logger.Info($"[OfficeProcessWatcher] Office worker started (PID={SafePid(proc)}) — install active");
RaiseStarted();
}
// .NET raises Exited once per Process object. A worker that exited before the hookup
// above was subscribed would stay tracked forever and the window would never close.
if (HasExitedSafe(proc))
ThreadPool.QueueUserWorkItem(_ => OnWorkerExited(proc, EventArgs.Empty));
}
private void OnWorkerExited(object? sender, EventArgs e)
@@ -178,11 +266,12 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
lock (_lock)
{
if (_workers.Remove(SafePid(proc)))
{
try { proc.Exited -= OnWorkerExited; } catch { }
try { proc.Dispose(); } catch { }
}
// Only the call that still finds this worker acts: after Dispose nothing is tracked,
// and TrackWorker's own re-check can deliver the same exit a second time.
if (_disposed || !_workers.TryGetValue(SafePid(proc), out var tracked) || !ReferenceEquals(tracked, proc))
return;
_workers.Remove(SafePid(proc));
if (_active && _workers.Count == 0)
{
if (_settleSeconds <= 0)
@@ -200,6 +289,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
}
}
try { proc.Exited -= OnWorkerExited; } catch { }
try { proc.Dispose(); } catch { }
if (raiseStoppedNow)
{
_logger.Info("[OfficeProcessWatcher] last Office worker exited — install window closed");
@@ -260,31 +352,40 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
try { return proc.Id; } catch { return -1; }
}
private static bool HasExitedSafe(Process proc)
{
try { return proc.HasExited; } catch { return false; }
}
public void Dispose()
{
ManagementEventWatcher? startWatcher;
Process[] workers;
lock (_lock)
{
if (_disposed) return;
_disposed = true;
}
if (_startWatcher != null)
{
try { _startWatcher.EventArrived -= OnProcessStartTrace; } catch { }
try { _startWatcher.Stop(); } catch { }
try { _startWatcher.Dispose(); } catch { }
startWatcher = _startWatcher;
_startWatcher = null;
CancelSettleTimer();
workers = new Process[_workers.Count];
_workers.Values.CopyTo(workers, 0);
_workers.Clear();
}
lock (_lock)
if (startWatcher != null)
{
CancelSettleTimer();
foreach (var kv in _workers)
{
try { kv.Value.Exited -= OnWorkerExited; } catch { }
try { kv.Value.Dispose(); } catch { }
}
_workers.Clear();
// Cancelling a WMI subscription can take tens of seconds on a busy WinMgmt. The caller
// is the agent's stop path, so it never waits for it.
var armed = startWatcher;
Task.Run(() => TearDownStartTrace(armed));
}
foreach (var worker in workers)
{
try { worker.Exited -= OnWorkerExited; } catch { }
try { worker.Dispose(); } catch { }
}
}
}
@@ -26,6 +26,12 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
/// </para>
/// One-shot per OS contract, so it re-arms after each fire. Fail-soft: any failure is logged and
/// the watcher stays quiet (the detector still gets the process Started/Stopped boundary events).
/// <para>
/// <b>Locking</b>: the lock guards this watcher's own state and is never held while
/// <see cref="Changed"/> is raised. A handler may dispose the watcher or take locks of its own,
/// and <see cref="Dispose"/> never waits for a handler. Raising under the lock deadlocks against
/// an owner that disposes this watcher under a lock its handler also takes.
/// </para>
/// </summary>
public sealed class RegistryChangeWatcher : IDisposable
{
@@ -34,10 +40,16 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
{
ChangeName = 0x00000001, // subkey added/removed (ClickToRun appearing; Scenario\* churn)
ChangeLastSet = 0x00000004, // value set (Configuration: VersionToReport / StreamingFinished)
// The registration must outlive the thread that issued it: re-arming happens on rotating
// ThreadPool threads, and without this flag Windows signals the event when such a thread
// ends — reported here as a change that never happened.
ThreadAgnostic = 0x10000000,
}
private const RegNotifyFilter PrimaryFilter = RegNotifyFilter.ChangeName | RegNotifyFilter.ChangeLastSet;
private const RegNotifyFilter BootstrapFilter = RegNotifyFilter.ChangeName; // cheap: direct-child create/delete only
private const RegNotifyFilter PrimaryFilter =
RegNotifyFilter.ChangeName | RegNotifyFilter.ChangeLastSet | RegNotifyFilter.ThreadAgnostic;
// Cheap: direct-child create/delete only.
private const RegNotifyFilter BootstrapFilter = RegNotifyFilter.ChangeName | RegNotifyFilter.ThreadAgnostic;
[DllImport("advapi32.dll", SetLastError = true)]
private static extern int RegNotifyChangeKeyValue(
@@ -49,6 +61,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
private enum WatchMode { None, Primary, Bootstrap }
private readonly RegistryHive _hive;
private readonly string _hiveLabel;
private readonly string _targetSubKey;
private readonly AgentLogger _logger;
private readonly object _lock = new object();
@@ -66,13 +80,25 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
/// <param name="targetSubKey">HKLM-relative key, e.g. <c>SOFTWARE\Microsoft\Office\ClickToRun</c>.</param>
public RegistryChangeWatcher(string targetSubKey, AgentLogger logger)
: this(RegistryHive.LocalMachine, targetSubKey, logger)
{
}
/// <summary>Test seam: production always watches HKLM; tests use a hive they may write to.</summary>
internal RegistryChangeWatcher(RegistryHive hive, string targetSubKey, AgentLogger logger)
{
_hive = hive;
_hiveLabel = hive == RegistryHive.LocalMachine ? "HKLM" : hive.ToString();
_targetSubKey = targetSubKey ?? throw new ArgumentNullException(nameof(targetSubKey));
_logger = logger ?? throw new ArgumentNullException(nameof(logger));
}
/// <summary>The filter the full target watch is armed with (tests).</summary>
internal uint EffectivePrimaryFilter => (uint)PrimaryFilter;
public void Start()
{
bool raise = false;
lock (_lock)
{
if (_started || _disposed) return;
@@ -81,24 +107,30 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
{
// Forced Registry64 view — consistent with the C2R reads (AnyCPU net48 may otherwise
// resolve the stale WOW6432Node mirror).
_baseKey = RegistryKey.OpenBaseKey(RegistryHive.LocalMachine, RegistryView.Registry64);
_baseKey = RegistryKey.OpenBaseKey(_hive, RegistryView.Registry64);
_signal = new AutoResetEvent(false);
ArmBestEffort(raiseOnPromote: false);
raise = ArmBestEffort(targetIsNews: false);
}
catch (Exception ex)
{
_logger.Warning($"[RegistryChangeWatcher] failed to start on HKLM\\{_targetSubKey}: {ex.Message}");
_logger.Warning($"[RegistryChangeWatcher] failed to start on {_hiveLabel}\\{_targetSubKey}: {ex.Message}");
}
}
if (raise) RaiseChanged();
}
/// <summary>
/// Arms the best available watch: the target key (full, subtree) if it exists, otherwise a cheap
/// name-only watch on the nearest existing ancestor until the target appears. Must hold <see cref="_lock"/>.
/// Returns true when the target key appeared and the caller has to raise <see cref="Changed"/>
/// for it — after releasing the lock.
/// </summary>
private void ArmBestEffort(bool raiseOnPromote)
/// <param name="targetIsNews">False when finding the target right away is the expected start
/// state; true when the watch was waiting for it.</param>
private bool ArmBestEffort(bool targetIsNews)
{
if (_disposed || _baseKey == null) return;
if (_disposed || _baseKey == null) return false;
CloseWatchedKey();
@@ -107,27 +139,25 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
{
_watchedKey = target;
_mode = WatchMode.Primary;
if (!ArmNotify(subtree: true, PrimaryFilter)) return;
if (raiseOnPromote) RaiseChanged();
return;
return ArmNotify(subtree: true, PrimaryFilter) && targetIsNews;
}
// Target absent — watch the nearest existing ancestor (non-recursive, name-only = cheap).
var ancestor = OpenNearestExistingAncestor(out var ancestorPath);
if (ancestor == null)
{
_logger.Debug($"[RegistryChangeWatcher] no existing ancestor for HKLM\\{_targetSubKey}; not arming");
return;
_logger.Debug($"[RegistryChangeWatcher] no existing ancestor for {_hiveLabel}\\{_targetSubKey}; not arming");
return false;
}
_watchedKey = ancestor;
_mode = WatchMode.Bootstrap;
_logger.Debug($"[RegistryChangeWatcher] target HKLM\\{_targetSubKey} absent — bootstrap-watching HKLM\\{ancestorPath} (name-only)", repeatKey: "RegistryChangeWatcher.bootstrap:" + _targetSubKey);
if (!ArmNotify(subtree: false, BootstrapFilter)) return;
_logger.Debug($"[RegistryChangeWatcher] target {_hiveLabel}\\{_targetSubKey} absent — bootstrap-watching {_hiveLabel}\\{ancestorPath} (name-only)", repeatKey: "RegistryChangeWatcher.bootstrap:" + _targetSubKey);
if (!ArmNotify(subtree: false, BootstrapFilter)) return false;
// TOCTOU: the target may have been created between TryOpen and arming the ancestor watch.
using (var recheck = TryOpen(_targetSubKey))
{
if (recheck != null) ArmBestEffort(raiseOnPromote: true);
return recheck != null && ArmBestEffort(targetIsNews: true);
}
}
@@ -139,7 +169,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
int rc = RegNotifyChangeKeyValue(_watchedKey.Handle, subtree, filter, _signal.SafeWaitHandle, fAsynchronous: true);
if (rc != 0)
{
_logger.Warning($"[RegistryChangeWatcher] RegNotifyChangeKeyValue failed rc={rc} (HKLM\\{_targetSubKey})");
_logger.Warning($"[RegistryChangeWatcher] RegNotifyChangeKeyValue failed rc={rc} ({_hiveLabel}\\{_targetSubKey})");
return false;
}
UnregisterWait();
@@ -149,29 +179,35 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
}
catch (Exception ex)
{
_logger.Warning($"[RegistryChangeWatcher] arm failed (HKLM\\{_targetSubKey}): {ex.Message}");
_logger.Warning($"[RegistryChangeWatcher] arm failed ({_hiveLabel}\\{_targetSubKey}): {ex.Message}");
return false;
}
}
private void OnSignalled(object? state, bool timedOut)
{
bool raise;
bool rearmAfterHandler;
lock (_lock)
{
UnregisterWait();
if (_disposed || timedOut) return;
if (_mode == WatchMode.Primary)
{
RaiseChanged();
ArmNotify(subtree: true, PrimaryFilter); // re-arm on the same target key
}
else
{
// A direct child changed under the ancestor — promote to the target watch if it now
// exists (raises Changed on promotion), else keep the cheap bootstrap watch.
ArmBestEffort(raiseOnPromote: true);
}
rearmAfterHandler = _mode == WatchMode.Primary;
// Bootstrap: a direct child changed under the ancestor — promote to the target watch if
// it now exists (then Changed is due), else keep the cheap bootstrap watch.
raise = rearmAfterHandler || ArmBestEffort(targetIsNews: true);
}
if (raise) RaiseChanged();
if (!rearmAfterHandler) return;
lock (_lock)
{
// Re-arm on the same target key, and only now: no wait was registered while the handler
// ran, so handlers never overlap, and a change that arrived meanwhile completes this
// registration at once.
ArmNotify(subtree: true, PrimaryFilter);
}
}
@@ -200,6 +236,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office
}
}
// Never called with _lock held.
private void RaiseChanged()
{
var handler = Changed;
@@ -1,10 +1,14 @@
#nullable enable
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
using System.Management;
using System.Security.Principal;
using System.Text.RegularExpressions;
using System.Threading.Tasks;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Interop;
namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
{
@@ -26,10 +30,18 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
/// </list>
/// </para>
/// <para>
/// <b>Instant-close fallback.</b> Reading the command line still races if the process exits before
/// the probe. In that case (<c>SessionID ≠ 0</c> but command line unreadable) the console is still
/// surfaced, tagged <c>confidence:"low"</c> — better than missing it. A truly race-free capture of
/// the command line would require the ETW Kernel-Process provider (deferred).
/// <b>A process id is not an identity.</b> WMI delivers the start trace in batches about once a
/// second, so the probe runs up to a second after the start. By then a scripted <c>cmd /c</c> has
/// usually exited, and Windows may have given its id to another process. A start whose process is
/// gone, or whose id now belongs to a different process (other image name, session 0, other
/// parent), is not a console someone types into: it is counted in
/// <see cref="ConsoleScriptActivityTally"/> and reported as one summary, never as a console.
/// The comparison uses no clock on purpose — trace time and process start time need not follow
/// the same clock corrections during OOBE, and a wrong tolerance would count real consoles away.
/// Counting needs certainty: the process list no longer has the id, or a fact that was read
/// contradicts the trace. A query that fails, or a fact that cannot be read, proves nothing —
/// such a process is reported at low confidence, exactly as a running console nobody could
/// classify.
/// </para>
/// <para>
/// <b>Lifecycle.</b> The host stops this watcher once the real-user desktop has arrived (wired in
@@ -69,9 +81,13 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
}
private readonly AgentLogger _logger;
private readonly Func<int, ProcessProbe?> _processProbe;
private readonly Func<int, string, ProcessProbe?> _processProbe;
private readonly Func<int, bool> _isAlive;
private readonly Func<int, string?> _parentName;
private readonly Func<DateTime> _utcNow;
private readonly ConsoleScriptActivityTally _tally = new ConsoleScriptActivityTally();
private readonly object _lock = new object();
private readonly HashSet<int> _seen = new HashSet<int>();
private readonly HashSet<string> _seen = new HashSet<string>(StringComparer.Ordinal);
private ManagementEventWatcher? _startWatcher;
private bool _started;
@@ -79,11 +95,17 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
/// <summary>
/// Raised once per process when a watched console is classified as an interactive console
/// (high confidence) or an unclassifiable interactive-session console (low confidence). The
/// (high confidence) or as one that stays open or cannot be classified (low confidence). The
/// host translates this into a Warning <c>oobe_console_spawned</c> event.
/// </summary>
public event EventHandler<ConsoleSpawnInfo>? BypassConsoleDetected;
/// <summary>
/// Raised when a short-lived start is counted into an empty tally. The host opens its
/// reporting window on it and collects the content with <see cref="TakeScriptActivity"/>.
/// </summary>
internal event EventHandler? ScriptActivityStarted;
/// <summary>
/// Raised when the WMI <c>Win32_ProcessStartTrace</c> watcher fails to arm — the LIVE detector
/// is dead and only the one-shot startup probe ran. The host surfaces this as a
@@ -92,12 +114,26 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
/// </summary>
public event EventHandler<Exception>? WatcherArmFailed;
/// <param name="processProbe">Resolves the command line + owner for a live PID; returns null
/// when the process has already exited (the instant-close race). Defaults to a WMI query.</param>
public ConsoleBypassWatcher(AgentLogger logger, Func<int, ProcessProbe?>? processProbe = null)
/// <param name="processProbe">Reads a live process by id; the second argument is the image
/// name the trace announced. Returns null only when the process has certainly exited or
/// the id certainly runs another image, and <see cref="ProcessProbe.Unreadable"/> when it
/// could not be read. Defaults to a process-list check followed by one WMI row.</param>
/// <param name="isAlive">False only when a process id certainly no longer runs. Defaults to
/// the process list.</param>
/// <param name="parentName">Image file name of a process, or null when it cannot be read.</param>
/// <param name="utcNow">Clock for the timestamps of counted starts.</param>
public ConsoleBypassWatcher(
AgentLogger logger,
Func<int, string, ProcessProbe?>? processProbe = null,
Func<int, bool>? isAlive = null,
Func<int, string?>? parentName = null,
Func<DateTime>? utcNow = null)
{
_logger = logger ?? throw new ArgumentNullException(nameof(logger));
_processProbe = processProbe ?? DefaultProbe;
_isAlive = isAlive ?? IsRunning;
_parentName = parentName ?? ImageFileName;
_utcNow = utcNow ?? (() => DateTime.UtcNow);
}
public void Start()
@@ -114,7 +150,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
// delayed every host after this one — so they run on a background thread. Exceptions
// are contained in StartCore; a disposal racing the background start is handled by
// the _disposed re-checks inside.
System.Threading.Tasks.Task.Run(() => StartCore());
Task.Run(() => StartCore());
}
private void StartCore()
@@ -147,7 +183,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
watcher.Start();
// Re-check after arming: Dispose() may have run between the lock release above and
// Start() — it then stopped a not-yet-armed watcher and this thread armed it right
// Start() — it then tore down a not-yet-armed watcher and this thread armed it right
// back, leaving a WMI subscription no code path could ever reach again. If disposal
// won that race, tear the watcher down here.
bool disposedDuringArm;
@@ -158,9 +194,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
}
if (disposedDuringArm)
{
try { watcher.EventArrived -= OnProcessStartTrace; } catch { }
try { watcher.Stop(); } catch { }
try { watcher.Dispose(); } catch { }
TearDownStartTrace(watcher);
return;
}
@@ -182,27 +216,32 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
}
}
// 2) Startup probe — catch a console already open before the watcher armed. Win32_Process
// exposes SessionId directly, so the same classification path is reused. Runs AFTER the
// arm so there is no gap; overlap with the live trace is deduped by _seen.
// 2) Startup probe — catch a console already open before the watcher armed. One query
// carries everything the classification needs; Handle is selected because the owner
// is a WMI method call on the row. Runs AFTER the arm so there is no gap; overlap
// with the live trace is deduped by _seen.
try
{
var nameFilter = string.Join(" OR ",
Array.ConvertAll(WatchedProcessNames, n => $"Name = '{n}'"));
using var searcher = new ManagementObjectSearcher(
$"SELECT Name, ProcessId, ParentProcessId, SessionId FROM Win32_Process WHERE {nameFilter}");
"SELECT Handle, Name, ProcessId, ParentProcessId, SessionId, CommandLine, CreationDate " +
$"FROM Win32_Process WHERE {nameFilter}");
using var results = searcher.Get();
foreach (var mo in results)
foreach (ManagementObject mo in results)
{
using (mo)
{
HandleStart(
ToInt(mo["ProcessId"]),
ToInt(mo["ParentProcessId"]),
ToInt(mo["SessionId"]),
ownerSidHint: null,
detectedVia: "startup_probe",
processName: mo["Name"]?.ToString() ?? WatchedProcessNames[0]);
var sessionId = ToInt(mo["SessionId"]);
var commandLine = mo["CommandLine"]?.ToString();
// The owner costs a method call: only for a row that will be reported.
if (Classify(sessionId, commandLine) == ConsoleVerdict.Ignore) continue;
var name = mo["Name"]?.ToString() ?? WatchedProcessNames[0];
var parentPid = ToInt(mo["ParentProcessId"]);
HandleProbed(
ToInt(mo["ProcessId"]), parentPid, sessionId, ProcessOwnerLookup.OwnerSid(mo), "startup_probe", name,
new ProcessProbe(name, sessionId, parentPid, commandLine, mo["CreationDate"]?.ToString()));
}
}
}
@@ -230,13 +269,11 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
}
/// <summary>
/// Classification core (internal for tests). Gates race-free on <paramref name="sessionId"/>,
/// then probes the live process for its command line; raises <see cref="BypassConsoleDetected"/>
/// once per PID for an interactive console (bare command line → high confidence) or an
/// unreadable interactive-session console (instant-close → low confidence). Scripted
/// invocations (<c>cmd /c</c>) and session-0 (service) cmd are ignored.
/// One traced start (internal for tests). Gates race-free on <paramref name="sessionId"/>,
/// then probes the process: a start that is gone or whose id belongs to another process is
/// counted, everything else goes through <see cref="HandleProbed"/>.
/// </summary>
internal void HandleStart(int pid, int parentPid, int sessionId, string? ownerSidHint, string detectedVia, string? processName = null)
internal void HandleStart(int pid, int parentPid, int sessionId, string? ownerSid, string detectedVia, string? processName = null)
{
if (pid <= 0) return;
lock (_lock) { if (_disposed) return; }
@@ -245,16 +282,46 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
// bulk of legitimate IME/Intune install cmd (SYSTEM, session 0) without even probing.
if (sessionId == 0) return;
var probe = _processProbe(pid); // null when the process already exited (instant-close)
var verdict = Classify(sessionId, probe?.CommandLine);
var name = processName ?? WatchedProcessNames[0];
var probe = _processProbe(pid, name);
if (probe == null || !IsTracedProcess(probe, name, parentPid))
{
CountShortLived(name, pid, parentPid, sessionId, ownerSid);
return;
}
HandleProbed(pid, parentPid, sessionId, ownerSid, detectedVia, name, probe);
}
/// <summary>
/// Classification of a process that was read while it ran (internal for tests). Raises
/// <see cref="BypassConsoleDetected"/> once per process for an interactive console (bare
/// command line → high confidence), one that stays open after its command (<c>/k</c> → low)
/// or a running one whose command line WMI does not return (low). A scripted <c>cmd /c</c>
/// is ignored.
/// </summary>
internal void HandleProbed(int pid, int parentPid, int sessionId, string? ownerSid, string detectedVia, string processName, ProcessProbe probe)
{
lock (_lock) { if (_disposed) return; }
// A row without a command line is only a console nobody could classify while the
// process still runs; one that ended in the meantime is a short-lived start.
if (probe.CommandLine == null && !_isAlive(pid))
{
CountShortLived(processName, pid, parentPid, sessionId, ownerSid);
return;
}
var verdict = Classify(sessionId, probe.CommandLine);
if (verdict == ConsoleVerdict.Ignore) return; // scripted invocation (cmd /c ...)
// Dedup only on a flagged hit, so the startup probe + live trace observing the same console
// collapse to one detection, and an ignored start never pre-empts a later real one.
// collapse to one detection, and an ignored start never pre-empts a later real one. The
// creation time is part of the key: a later console may be given an id seen before.
lock (_lock)
{
if (_disposed) return;
if (!_seen.Add(pid)) return;
if (!_seen.Add(pid + "|" + probe.CreationDate)) return;
}
bool high = verdict == ConsoleVerdict.InteractiveConsole;
@@ -266,15 +333,16 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
default: classification = "interactive_session_unclassified"; break;
}
var info = new ConsoleSpawnInfo(
processName: processName ?? WatchedProcessNames[0],
processName: processName,
processId: pid,
parentProcessId: parentPid,
sessionId: sessionId,
owner: probe?.Owner ?? ownerSidHint,
commandLine: probe?.CommandLine,
owner: ownerSid,
commandLine: probe.CommandLine,
confidence: high ? "high" : "low",
classification: classification,
detectedVia: detectedVia);
detectedVia: detectedVia,
parentProcessName: SafeParentName(parentPid));
_logger.Warning($"[ConsoleBypassWatcher] interactive console detected: {info.ProcessName} (PID={pid}) " +
$"session={sessionId}, confidence={info.Confidence}, via={detectedVia} — possible Shift+F10");
@@ -283,14 +351,37 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
catch (Exception ex) { _logger.Warning($"[ConsoleBypassWatcher] handler threw: {ex.Message}"); }
}
/// <summary>
/// The counted short-lived starts since the last call, or null when there were none. The
/// host calls it when its window ends and when it stops.
/// </summary>
internal ConsoleScriptActivity? TakeScriptActivity() => _tally.Take();
private void CountShortLived(string processName, int pid, int parentPid, int sessionId, string? ownerSid)
{
var opened = _tally.Add(processName, pid, parentPid, sessionId, ownerSid, _utcNow(), SafeParentName);
_logger.Trace($"[ConsoleBypassWatcher] short-lived {processName} counted (PID={pid}, parent={parentPid}, session={sessionId})");
if (!opened) return;
try { ScriptActivityStarted?.Invoke(this, EventArgs.Empty); }
catch (Exception ex) { _logger.Debug($"[ConsoleBypassWatcher] script-activity handler threw: {ex.Message}"); }
}
private string? SafeParentName(int parentPid)
{
if (parentPid <= 0) return null;
try { return _parentName(parentPid); }
catch (Exception) { return null; }
}
internal enum ConsoleVerdict { Ignore, InteractiveConsole, UnclassifiedInteractive, InteractiveWithCommand }
/// <summary>
/// Pure classification (internal for tests): session-0 → Ignore; a scripted <c>cmd /c</c> →
/// Ignore; <c>cmd /k</c> (runs its command, then STAYS interactive — L12) →
/// InteractiveWithCommand (low); a bare command line → InteractiveConsole (high); an
/// unreadable command line in an interactive session → UnclassifiedInteractive (low, the
/// instant-close fallback).
/// InteractiveWithCommand (low); a bare command line → InteractiveConsole (high); a running
/// process without a readable command line in an interactive session →
/// UnclassifiedInteractive (low).
/// </summary>
internal static ConsoleVerdict Classify(int sessionId, string? commandLine)
{
@@ -304,15 +395,17 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
}
}
/// <summary>True when the FIRST <c>/c</c>-or-<c>/k</c> switch on the command line is <c>/c</c>
/// (a scripted run-and-exit invocation, mirroring cmd.exe precedence), false for a bare
/// interactive shell or a <c>/k</c> run-and-stay shell — even one whose payload contains a
/// later <c>/c</c>. The executable token is stripped first so a path can never spoof a
/// switch, and switches may be combined (e.g. <c>cmd /d/q/c exit 9</c>).</summary>
internal static bool HasScriptArgument(string commandLine)
/// <summary>
/// Whether a probed process is still the one the trace announced (internal for tests). Only
/// a fact that contradicts the trace makes it another process — another image name, the
/// service session, another parent. A fact that could not be read contradicts nothing: the
/// process is then reported, never counted away.
/// </summary>
internal static bool IsTracedProcess(ProcessProbe probe, string processName, int parentPid)
{
if (string.IsNullOrEmpty(commandLine)) return false;
return FirstRunSwitch(StripExecutable(commandLine)) == RunSwitch.RunAndExit;
if (probe.Name != null && !string.Equals(probe.Name, processName, StringComparison.OrdinalIgnoreCase)) return false;
if (probe.SessionId == 0) return false;
return parentPid <= 0 || probe.ParentProcessId == null || probe.ParentProcessId <= 0 || probe.ParentProcessId == parentPid;
}
/// <summary>Returns the command line with the leading executable token (quoted or
@@ -330,44 +423,100 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
return space >= 0 ? s.Substring(space + 1) : string.Empty;
}
private static ProcessProbe? DefaultProbe(int pid)
// The process list first: a WMI query takes a few hundred milliseconds, and in a burst
// almost every traced process has already exited. Queried one after the other on the
// delivery thread they would pile up, and a real console closed during the backlog would
// be counted as a script.
private static ProcessProbe? DefaultProbe(int pid, string processName) =>
Probe(pid, ProcessListState(pid, processName), ReadRow);
/// <summary>
/// The probe's decision (internal for tests). Null only when the process list says so for
/// certain: the id no longer runs, or it runs another image. Everything else comes back as
/// a probe — with the row's facts, or <see cref="ProcessProbe.Unreadable"/> when the query
/// failed or returned nothing. A failed query says nothing about the process, so it must
/// never read as "exited".
/// </summary>
internal static ProcessProbe? Probe(int pid, ListedAs listed, Func<int, ProcessProbe?> readRow)
{
if (listed == ListedAs.NotRunning || listed == ListedAs.OtherImage) return null;
try
{
using var searcher = new ManagementObjectSearcher(
$"SELECT CommandLine FROM Win32_Process WHERE ProcessId = {pid}");
using var results = searcher.Get();
foreach (ManagementObject mo in results)
{
using (mo)
{
var commandLine = mo["CommandLine"]?.ToString();
return new ProcessProbe(commandLine, TryGetOwner(mo));
}
}
return readRow(pid) ?? ProcessProbe.Unreadable;
}
catch (Exception)
{
// Process gone or query failed — treated as the instant-close fallback (low confidence).
return ProcessProbe.Unreadable; // WinMgmt can fail or hang during OOBE
}
}
private static ProcessProbe? ReadRow(int pid)
{
using var searcher = new ManagementObjectSearcher(
$"SELECT Name, SessionId, ParentProcessId, CommandLine, CreationDate FROM Win32_Process WHERE ProcessId = {pid}");
using var results = searcher.Get();
foreach (ManagementObject mo in results)
{
using (mo)
{
return new ProcessProbe(
mo["Name"]?.ToString(),
ToNullableInt(mo["SessionId"]),
ToNullableInt(mo["ParentProcessId"]),
mo["CommandLine"]?.ToString(),
mo["CreationDate"]?.ToString());
}
}
return null;
}
private static string? TryGetOwner(ManagementObject process)
/// <summary>What the process list says about an id and the image name expected under it.</summary>
internal enum ListedAs { NotRunning, OtherImage, Expected, Unknown }
/// <summary>Internal for tests.</summary>
internal static ListedAs ProcessListState(int pid, string processName)
{
try
{
var outParams = process.InvokeMethod("GetOwner", null, null);
if (outParams != null && Convert.ToInt32(outParams["ReturnValue"]) == 0)
{
var domain = outParams["Domain"]?.ToString();
var user = outParams["User"]?.ToString();
if (!string.IsNullOrEmpty(user))
return string.IsNullOrEmpty(domain) ? user : $"{domain}\\{user}";
}
using var process = Process.GetProcessById(pid);
return string.Equals(process.ProcessName, Path.GetFileNameWithoutExtension(processName), StringComparison.OrdinalIgnoreCase)
? ListedAs.Expected
: ListedAs.OtherImage;
}
catch { /* best-effort enrichment */ }
return null;
catch (ArgumentException)
{
return ListedAs.NotRunning; // what GetProcessById throws for an id that does not run
}
catch (Exception)
{
return ListedAs.Unknown;
}
}
/// <summary>False only when the id certainly does not run; when that cannot be told, true.
/// Internal for tests.</summary>
internal static bool IsRunning(int pid)
{
try
{
using var process = Process.GetProcessById(pid);
return !process.HasExited;
}
catch (ArgumentException)
{
return false;
}
catch (Exception)
{
return true;
}
}
private static string? ImageFileName(int pid)
{
var path = ProcessImagePath.Query(pid);
return string.IsNullOrEmpty(path) ? null : Path.GetFileName(path);
}
private static string? TryReadSid(object? sidValue)
@@ -388,42 +537,77 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
catch { return 0; }
}
private static int? ToNullableInt(object? value)
{
if (value == null) return null;
try { return Convert.ToInt32(value); }
catch { return null; }
}
private void TearDownStartTrace(ManagementEventWatcher watcher)
{
try { watcher.EventArrived -= OnProcessStartTrace; } catch { }
try { watcher.Stop(); } catch { }
try { watcher.Dispose(); } catch { }
}
public void Dispose()
{
ManagementEventWatcher? startWatcher;
lock (_lock)
{
if (_disposed) return;
_disposed = true;
startWatcher = _startWatcher;
_startWatcher = null;
}
if (_startWatcher != null)
if (startWatcher != null)
{
try { _startWatcher.EventArrived -= OnProcessStartTrace; } catch { }
try { _startWatcher.Stop(); } catch { }
try { _startWatcher.Dispose(); } catch { }
_startWatcher = null;
// Cancelling a WMI subscription can take tens of seconds on a busy WinMgmt. The caller
// is the agent's stop path, so it never waits for it.
var armed = startWatcher;
Task.Run(() => TearDownStartTrace(armed));
}
}
}
/// <summary>Command line + owner for a probed PID; either may be null (best-effort).</summary>
/// <summary>
/// What was read about a running process: the facts that tell whether it is still the process
/// a start trace announced, and its command line. Every field is null when it could not be
/// read; null never means "no" or "zero".
/// </summary>
public sealed class ProcessProbe
{
public ProcessProbe(string? commandLine, string? owner)
/// <summary>
/// A process that runs but about which nothing could be read (the query failed or returned
/// no row). It goes on as the traced process without a command line, so it is reported.
/// </summary>
internal static readonly ProcessProbe Unreadable = new ProcessProbe(null, null, null, null, null);
public ProcessProbe(string? name, int? sessionId, int? parentProcessId, string? commandLine, string? creationDate)
{
Name = name;
SessionId = sessionId;
ParentProcessId = parentProcessId;
CommandLine = commandLine;
Owner = owner;
CreationDate = creationDate;
}
public string? Name { get; }
public int? SessionId { get; }
public int? ParentProcessId { get; }
public string? CommandLine { get; }
public string? Owner { get; }
/// <summary>The raw WMI creation time; only compared for equality.</summary>
public string? CreationDate { get; }
}
/// <summary>Immutable detail record for a detected interactive console spawn.</summary>
public sealed class ConsoleSpawnInfo
{
public ConsoleSpawnInfo(string processName, int processId, int parentProcessId, int sessionId,
string? owner, string? commandLine, string confidence, string classification, string detectedVia)
string? owner, string? commandLine, string confidence, string classification, string detectedVia,
string? parentProcessName)
{
ProcessName = processName;
ProcessId = processId;
@@ -434,17 +618,24 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
Confidence = confidence;
Classification = classification;
DetectedVia = detectedVia;
ParentProcessName = parentProcessName;
}
public string ProcessName { get; }
public int ProcessId { get; }
public int ParentProcessId { get; }
public int SessionId { get; }
/// <summary>Owner SID, or null when it could not be read.</summary>
public string? Owner { get; }
public string? CommandLine { get; }
/// <summary>"high" (bare interactive shell) or "low" (interactive session, command line unreadable).</summary>
/// <summary>"high" (bare interactive shell) or "low" (stays open after a command, or not classifiable).</summary>
public string Confidence { get; }
public string Classification { get; }
public string DetectedVia { get; }
/// <summary>
/// Image name of the parent while it still ran, else null. The launcher behind Shift+F10
/// exits within milliseconds, so null is the expected value for that case.
/// </summary>
public string? ParentProcessName { get; }
}
}
@@ -0,0 +1,182 @@
#nullable enable
using System;
using System.Collections.Generic;
using System.Linq;
namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Security
{
/// <summary>
/// Counts console processes that were gone before they could be inspected — script children,
/// reported as one summary per window instead of one event each. Thread-safe. The content
/// leaves through <see cref="Take"/>, which hands out copies and leaves an empty tally behind,
/// so a start is never counted in two summaries.
/// </summary>
internal sealed class ConsoleScriptActivityTally
{
internal const int MaxOwnersListed = 5;
internal const int MaxParentsListed = 10;
internal const int MaxParentLookups = 10;
// A spawner can keep running for hours after the host has stopped opening windows. The
// count grows with it; what is remembered per start does not.
private const int MaxTrackedParents = 256;
private const int MaxTrackedProcessIds = 2048;
private const int MaxTrackedOwners = 64;
private sealed class Parent
{
public string? Name;
public int Children;
}
private readonly object _lock = new object();
private readonly SortedSet<int> _sessions = new SortedSet<int>();
private readonly List<string> _owners = new List<string>();
private readonly Dictionary<int, Parent> _parents = new Dictionary<int, Parent>();
private readonly HashSet<int> _processIds = new HashSet<int>();
private string _processName = string.Empty;
private int _count;
private int _parentLookups;
private DateTime _firstSeenUtc;
private DateTime _lastSeenUtc;
/// <summary>
/// Counts one start. <paramref name="parentName"/> is asked at most once per parent and at
/// most <see cref="MaxParentLookups"/> times per window, outside the lock; a parent that is
/// itself one of the counted processes is named without asking.
/// </summary>
/// <returns><c>true</c> when this start opened an empty tally.</returns>
public bool Add(
string processName, int processId, int parentProcessId, int sessionId, string? ownerSid,
DateTime seenUtc, Func<int, string?> parentName)
{
bool opened;
Parent? toResolve = null;
lock (_lock)
{
opened = _count == 0;
if (opened)
{
_processName = processName;
_firstSeenUtc = seenUtc;
}
_count++;
_lastSeenUtc = seenUtc;
_sessions.Add(sessionId);
if (!string.IsNullOrEmpty(ownerSid) && _owners.Count < MaxTrackedOwners && !_owners.Contains(ownerSid!))
_owners.Add(ownerSid!);
if (parentProcessId > 0)
{
if (_parents.TryGetValue(parentProcessId, out var parent))
{
parent.Children++;
}
else if (_parents.Count < MaxTrackedParents)
{
parent = new Parent { Children = 1 };
_parents[parentProcessId] = parent;
if (_processIds.Contains(parentProcessId))
{
parent.Name = processName;
}
else if (_parentLookups < MaxParentLookups)
{
_parentLookups++;
toResolve = parent;
}
}
}
if (_processIds.Count < MaxTrackedProcessIds) _processIds.Add(processId);
}
if (toResolve != null)
{
var name = parentName(parentProcessId);
lock (_lock) { toResolve.Name = name; }
}
return opened;
}
/// <summary>The counted content, or <c>null</c> when nothing was counted. Empties the tally.</summary>
public ConsoleScriptActivity? Take()
{
lock (_lock)
{
if (_count == 0) return null;
var parents = _parents
.Select(kv => new ConsoleScriptParent(kv.Key, kv.Value.Name, kv.Value.Children))
.OrderByDescending(p => p.Children)
.ThenBy(p => p.ProcessId)
.ToList();
var activity = new ConsoleScriptActivity(
_processName, _count, _firstSeenUtc, _lastSeenUtc,
_sessions.ToList(),
_owners.Take(MaxOwnersListed).ToList(), _owners.Count,
parents.Take(MaxParentsListed).ToList(), parents.Count);
_count = 0;
_parentLookups = 0;
_processName = string.Empty;
_sessions.Clear();
_owners.Clear();
_parents.Clear();
_processIds.Clear();
return activity;
}
}
}
/// <summary>One window of counted console processes. Lists are capped; the totals are not.</summary>
internal sealed class ConsoleScriptActivity
{
public ConsoleScriptActivity(
string processName, int count, DateTime firstSeenUtc, DateTime lastSeenUtc,
IReadOnlyList<int> windowsSessions,
IReadOnlyList<string> owners, int ownersTotal,
IReadOnlyList<ConsoleScriptParent> parents, int parentsTotal)
{
ProcessName = processName;
Count = count;
FirstSeenUtc = firstSeenUtc;
LastSeenUtc = lastSeenUtc;
WindowsSessions = windowsSessions;
Owners = owners;
OwnersTotal = ownersTotal;
Parents = parents;
ParentsTotal = parentsTotal;
}
public string ProcessName { get; }
public int Count { get; }
public DateTime FirstSeenUtc { get; }
public DateTime LastSeenUtc { get; }
public IReadOnlyList<int> WindowsSessions { get; }
public IReadOnlyList<string> Owners { get; }
public int OwnersTotal { get; }
/// <summary>Parents by number of children, most first.</summary>
public IReadOnlyList<ConsoleScriptParent> Parents { get; }
public int ParentsTotal { get; }
}
/// <summary>A parent process of counted console processes. Only its image name is kept, never its command line.</summary>
internal sealed class ConsoleScriptParent
{
public ConsoleScriptParent(int processId, string? name, int children)
{
ProcessId = processId;
Name = name;
Children = children;
}
public int ProcessId { get; }
/// <summary><c>null</c> when the parent had exited or was not looked up.</summary>
public string? Name { get; }
public int Children { get; }
}
}
@@ -260,6 +260,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Transport
{
await ThrowOnAuthFailureAsync(response, correlationId).ConfigureAwait(false);
await ThrowOnCodedConflictAsync(response).ConfigureAwait(false);
ThrowOnSessionGone(response, correlationId);
response.EnsureSuccessStatusCode();
var responseJson = await response.Content.ReadAsStringAsync().ConfigureAwait(false);
@@ -412,6 +413,24 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Transport
errorCode);
}
/// <summary>
/// Throws <see cref="BackendSessionGoneException"/> for a 410 the backend answered: the
/// session was deleted or is being deleted. Only a response that echoes this request's
/// <c>X-Correlation-ID</c> counts — the caller ends monitoring on it, so a 410 from the
/// network path stays an ordinary failure (<c>EnsureSuccessStatusCode</c>) and is retried.
/// </summary>
private static void ThrowOnSessionGone(HttpResponseMessage response, string correlationId)
{
if (response.StatusCode != HttpStatusCode.Gone)
return;
if (!ResponseOriginClassifier.EchoesCorrelationId(response, correlationId))
return;
throw new BackendSessionGoneException(
"Backend returned 410 Gone: the session was deleted or is being deleted.",
(int)response.StatusCode);
}
/// <summary>
/// Pulls <c>errorCode</c> out of a backend JSON error body. Tolerant: any parse failure
/// or a non-string value yields null, never an exception.
@@ -537,4 +556,19 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Transport
ErrorCode = errorCode;
}
}
/// <summary>
/// Thrown for a 410 Gone the backend answered: the session named in the request was deleted or
/// is being deleted. No retry can clear it and it says nothing about the device's authorization.
/// </summary>
public class BackendSessionGoneException : Exception
{
/// <summary>HTTP status code returned by the backend (410).</summary>
public int StatusCode { get; }
public BackendSessionGoneException(string message, int statusCode) : base(message)
{
StatusCode = statusCode;
}
}
}
@@ -15,7 +15,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Transport
/// - Same error key (ErrorType + HTTP status code) is only ever sent once per session
/// - At most <see cref="MaxReportsPerSession"/> emergency reports total per session
/// - At most one report every <see cref="MinIntervalMinutes"/> minutes regardless of error type
/// (the terminal <see cref="AgentErrorType.TelemetryRejectedSessionUnknown"/> report is exempt)
/// (the terminal session-gone reports <see cref="AgentErrorType.TelemetryRejectedSessionUnknown"/>
/// and <see cref="AgentErrorType.RegistrationRejectedSessionGone"/> are exempt)
///
/// A failure in this reporter is silently swallowed — it must never cascade into the main loop.
/// </summary>
@@ -123,11 +124,12 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Transport
return;
}
// The session-unknown report is terminal and sent at most once per process (the
// A session-gone report is terminal and sent at most once per process (the
// termination follows immediately): a routine report minutes earlier must not cost
// the last word about the session. Only the cooldown is waived; key dedup and the
// per-session maximum still apply.
var exemptFromCooldown = errorType == AgentErrorType.TelemetryRejectedSessionUnknown;
var exemptFromCooldown = errorType == AgentErrorType.TelemetryRejectedSessionUnknown
|| errorType == AgentErrorType.RegistrationRejectedSessionGone;
if (!exemptFromCooldown && _lastReportTime != null &&
(now - _lastReportTime.Value).TotalMinutes < MinIntervalMinutes)
{
@@ -67,6 +67,13 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
/// <summary>Default Timeout für den Terminal-Drain beim Stop.</summary>
public static readonly TimeSpan DefaultTerminalDrainTimeout = TimeSpan.FromSeconds(30);
/// <summary>
/// How long termination waits for ONE collector host to stop (and later to dispose). A whole
/// healthy stop pass takes about 0.2 s and the slowest single host seen in the field 7 s, so
/// this only ever ends the wait for a host that hangs.
/// </summary>
public static readonly TimeSpan DefaultCollectorHostStopTimeout = TimeSpan.FromSeconds(30);
private readonly string _sessionId;
private readonly string _tenantId;
private readonly string _stateDirectory;
@@ -81,6 +88,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
private readonly int _quarantineThreshold;
private readonly TimeSpan _drainInterval;
private readonly TimeSpan _terminalDrainTimeout;
private readonly TimeSpan _collectorHostStopTimeout;
private readonly TimeSpan? _agentMaxLifetime;
private readonly int _uploadBatchSize;
@@ -124,6 +132,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
private SessionTraceOrdinalProvider? _traceCounter;
private SignalIngress? _ingress;
private IReadOnlyList<ICollectorHost>? _collectorHosts;
// Hosts that did not come back from Stop or Dispose in time. A thread is still inside them,
// so nothing calls into them again. Locked on itself.
private readonly HashSet<ICollectorHost> _unresponsiveHosts = new HashSet<ICollectorHost>();
private EventHandler<DeadlineFiredEventArgs>? _deadlineBridge;
@@ -181,7 +192,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
int uploadBatchSize = 100,
IDeadlineScheduler? schedulerOverride = null,
Func<bool>? traceEventsEnabled = null,
Func<bool>? espContinueAnywayObservationEnabled = null)
Func<bool>? espContinueAnywayObservationEnabled = null,
TimeSpan? collectorHostStopTimeout = null)
{
if (string.IsNullOrEmpty(sessionId)) throw new ArgumentException("SessionId is mandatory.", nameof(sessionId));
if (string.IsNullOrEmpty(tenantId)) throw new ArgumentException("TenantId is mandatory.", nameof(tenantId));
@@ -211,6 +223,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
_quarantineThreshold = quarantineThreshold;
_drainInterval = drainInterval ?? DefaultDrainInterval;
_terminalDrainTimeout = terminalDrainTimeout ?? DefaultTerminalDrainTimeout;
_collectorHostStopTimeout = collectorHostStopTimeout ?? DefaultCollectorHostStopTimeout;
if (agentMaxLifetime.HasValue && agentMaxLifetime.Value <= TimeSpan.Zero)
throw new ArgumentOutOfRangeException(nameof(agentMaxLifetime), "AgentMaxLifetime must be positive when set.");
@@ -947,6 +960,11 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
/// diagnostics ZIP is built so periodic collectors (PerformanceCollector,
/// AgentSelfMetricsCollector, …) don't keep emitting <c>performance_snapshot</c> /
/// <c>agent_metrics_snapshot</c> events while the package is being assembled.
/// <para>
/// Bounded per host (<see cref="DefaultCollectorHostStopTimeout"/>): a host that hangs is
/// left behind and the remaining hosts are still stopped. The diagnostics upload and the
/// self-destruct come after this call, so it has to return whatever a collector does.
/// </para>
/// </summary>
public void StopCollectorHosts()
{
@@ -955,8 +973,94 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
foreach (var host in _collectorHosts)
{
try { host.Stop(); }
catch (Exception ex) { _logger.Warning($"EnrollmentOrchestrator: host '{host.Name}' stop failed: {ex.Message}"); }
RunHostStepBounded(host, "stop", h => h.Stop());
}
}
/// <summary>
/// Runs one host's Stop or Dispose on a thread of its own and waits at most
/// <see cref="_collectorHostStopTimeout"/> for it.
/// </summary>
private void RunHostStepBounded(ICollectorHost host, string step, Action<ICollectorHost> action)
{
lock (_unresponsiveHosts)
{
if (_unresponsiveHosts.Contains(host)) return;
}
Exception? failure = null;
var worker = new Thread(() =>
{
try { action(host); }
catch (Exception ex) { failure = ex; }
})
{
// Not a ThreadPool thread: a host that hangs would keep one for good, and the pool may
// be the very thing that is stuck. Background, so it cannot keep the process alive.
IsBackground = true,
Name = $"CollectorHost.{step}:{host.Name}",
};
try { worker.Start(); }
catch (Exception ex)
{
_logger.Warning($"EnrollmentOrchestrator: host '{host.Name}' {step} could not be started: {ex.Message}");
return;
}
if (worker.Join(_collectorHostStopTimeout))
{
if (failure == null) return;
if (step == "stop")
_logger.Warning($"EnrollmentOrchestrator: host '{host.Name}' stop failed: {failure.Message}");
else
_logger.Debug($"EnrollmentOrchestrator: host '{host.Name}' {step} failed: {failure.Message}");
return;
}
lock (_unresponsiveHosts)
{
_unresponsiveHosts.Add(host);
}
var seconds = (int)Math.Ceiling(_collectorHostStopTimeout.TotalSeconds);
_logger.Warning(
$"EnrollmentOrchestrator: host '{host.Name}' did not return from {step} within {seconds}s — " +
"termination continues without it.");
if (step == "stop") EmitCollectorHostStopTimeout(host.Name, seconds);
}
/// <summary>
/// One <c>agent_trace</c> per host that hung in Stop, so the fleet can count it. Deliberately
/// not <c>collector_degraded</c>: that one says the collector's signals are missing and gates
/// analyze rules, while a host that will not stop has missed nothing. (A host that hangs in
/// Dispose is logged only — the ingress is already down by then.)
/// </summary>
private void EmitCollectorHostStopTimeout(string hostName, int timeoutSeconds)
{
var ingress = _ingress;
if (ingress == null) return;
try
{
new InformationalEventPost(ingress, _clock).Emit(new Shared.Models.EnrollmentEvent
{
SessionId = _sessionId,
TenantId = _tenantId,
EventType = Constants.EventTypes.AgentTrace,
Severity = Shared.Models.EventSeverity.Warning,
Source = "EnrollmentOrchestrator",
Phase = Shared.Models.EnrollmentPhase.Unknown,
Message = $"Collector host '{hostName}' did not stop within {timeoutSeconds}s; termination continued without it.",
Timestamp = _clock.UtcNow,
Data = new Dictionary<string, object>(StringComparer.Ordinal)
{
["decision"] = "collector_host_stop_timeout",
["host"] = hostName,
["timeoutSeconds"] = timeoutSeconds,
},
});
}
catch (Exception ex)
{
_logger.Debug($"EnrollmentOrchestrator: failed to post collector_host_stop_timeout: {ex.Message}");
}
}
@@ -1043,12 +1147,13 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
}
catch (Exception ex) { _logger.Warning($"EnrollmentOrchestrator: final snapshot save failed: {ex.Message}"); }
// 7) Dispose aller Disposables.
// 7) Dispose all disposables. Hosts go through the same bound as in StopCollectorHosts;
// one that is still stuck in Stop is skipped (its Dispose would wait on the same thing).
if (_collectorHosts != null)
{
foreach (var host in _collectorHosts)
{
try { host.Dispose(); } catch { /* best-effort */ }
RunHostStepBounded(host, "dispose", h => h.Dispose());
}
}
try { _transport?.Dispose(); } catch { /* best-effort */ }
@@ -1,6 +1,7 @@
#nullable enable
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals;
@@ -21,6 +22,13 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
/// only sees consoles spawned after the agent started; the pre-agent OOBE window is covered
/// (coarsely) by the ConsolePrefetchScanner. The composition root calls <see cref="Stop"/> once the
/// real-user desktop arrives (Shift+F10 no longer possible) to avoid post-enrollment false positives.
/// <para>
/// Short-lived console processes (script children) are not events of their own: the watcher
/// counts them and this host reports one Info <c>console_script_activity</c> per window. The
/// first counted start opens a window of <see cref="ScriptActivityWindow"/>; at most
/// <see cref="MaxScriptActivitySummaries"/> windows are reported per agent run, whatever comes
/// after goes into the one line written when the host stops.
/// </para>
/// </summary>
internal sealed class ConsoleBypassHost : ICollectorHost
{
@@ -28,6 +36,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
"best-effort: only consoles spawned after the agent started are observable; a Shift+F10 " +
"pressed earlier in OOBE (before agent install) is covered coarsely by console_prefetch_detected";
internal const int MaxScriptActivitySummaries = 20;
private static readonly TimeSpan ScriptActivityWindow = TimeSpan.FromSeconds(60);
public string Name => "ConsoleBypassWatcher";
private readonly string _sessionId;
@@ -36,7 +47,10 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
private readonly AgentLogger _logger;
private readonly ConsoleBypassWatcher _watcher;
private readonly SignalIngress? _observableIngress;
private readonly object _summaryLock = new object();
private Action<AutopilotMonitor.DecisionCore.Signals.DecisionSignalKind, IReadOnlyDictionary<string, string>?>? _signalPostedHandler;
private Timer? _windowTimer;
private int _summariesEmitted;
private int _disposed;
public ConsoleBypassHost(
@@ -55,11 +69,16 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
_post = new InformationalEventPost(ingress, clock, logger);
_watcher = watcher ?? new ConsoleBypassWatcher(logger);
_watcher.BypassConsoleDetected += OnBypassConsoleDetected;
_watcher.ScriptActivityStarted += OnScriptActivityStarted;
_watcher.WatcherArmFailed += OnWatcherArmFailed;
_observableIngress = ingress as SignalIngress;
}
public void Start()
public void Start() => StartCore(armWatcher: true);
/// <summary>Internal for tests: <paramref name="armWatcher"/> = false leaves the WMI
/// subscription and the startup probe out; everything else is the real start.</summary>
internal void StartCore(bool armWatcher)
{
// L14 fallback: the primary stop path is the DesktopArrivalDetector's real-user-owner
// callback (StopForDesktopArrival). If the DAD misses the owner (no-candidate timeout,
@@ -73,7 +92,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
_observableIngress.SignalPosted += _signalPostedHandler;
}
_watcher.Start();
if (armWatcher) _watcher.Start();
}
private void OnSignalPosted(AutopilotMonitor.DecisionCore.Signals.DecisionSignalKind kind, IReadOnlyDictionary<string, string>? payload)
@@ -117,6 +136,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
Phase = EnrollmentPhase.Unknown,
Message = $"Interactive console spawned during enrollment: {info.ProcessName} " +
$"(session {info.SessionId}, {info.Confidence} confidence) — possible Shift+F10",
// At once, whatever the confidence: the confidence follows the command line,
// and that is chosen by whoever opens the console.
ImmediateUpload = true,
Data = new Dictionary<string, object>
{
@@ -124,6 +145,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
{ "processName", info.ProcessName },
{ "processId", info.ProcessId },
{ "parentProcessId", info.ParentProcessId },
{ "parentProcessName", info.ParentProcessName ?? "unknown" },
{ "sessionId", info.SessionId },
{ "owner", info.Owner ?? "unknown" },
{ "commandLine", info.CommandLine ?? "unavailable" },
@@ -141,6 +163,132 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
}
}
private void OnScriptActivityStarted(object? sender, EventArgs e)
{
lock (_summaryLock)
{
// Checked under the lock Dispose takes for the timer, so no timer is created behind it.
if (Interlocked.CompareExchange(ref _disposed, 0, 0) == 1) return;
// Past the cap no window opens any more; the watcher keeps counting for the stop line.
if (_summariesEmitted >= MaxScriptActivitySummaries) return;
try
{
if (_windowTimer == null)
_windowTimer = new Timer(_ => WindowElapsed(), null, ScriptActivityWindow, Timeout.InfiniteTimeSpan);
else
_windowTimer.Change(ScriptActivityWindow, Timeout.InfiniteTimeSpan);
}
catch (ObjectDisposedException)
{
// stopping
}
}
}
/// <summary>Internal for tests: what the window timer runs when it elapses.</summary>
internal void WindowElapsedForTest() => WindowElapsed();
private void WindowElapsed()
{
if (Interlocked.CompareExchange(ref _disposed, 0, 0) == 1) return;
ReportScriptActivity(stopping: false);
}
private void ReportScriptActivity(bool stopping)
{
ConsoleScriptActivity? activity;
bool capped;
lock (_summaryLock)
{
capped = _summariesEmitted >= MaxScriptActivitySummaries;
if (capped && !stopping) return;
activity = _watcher.TakeScriptActivity();
if (activity == null) return;
_summariesEmitted++;
}
// Outside the lock: a post blocks while the ingress is full.
try
{
var data = new Dictionary<string, object>
{
{ "count", activity.Count },
{ "processName", activity.ProcessName },
{ "firstSeenUtc", activity.FirstSeenUtc.ToString("o") },
{ "lastSeenUtc", activity.LastSeenUtc.ToString("o") },
{ "windowsSessions", activity.WindowsSessions.ToList() },
{ "owners", activity.Owners.ToList() },
{ "ownersTotal", activity.OwnersTotal },
{
"parents", activity.Parents.Select(p => new Dictionary<string, object>
{
{ "pid", p.ProcessId },
{ "name", p.Name ?? "unknown" },
{ "children", p.Children },
}).ToList()
},
{ "parentsTotal", activity.ParentsTotal },
};
if (capped) data["capped"] = true;
_post.Emit(new EnrollmentEvent
{
SessionId = _sessionId,
TenantId = _tenantId,
EventType = Constants.EventTypes.ConsoleScriptActivity,
Severity = EventSeverity.Info,
Source = Name,
Phase = EnrollmentPhase.Unknown,
Timestamp = activity.LastSeenUtc,
Message = DescribeScriptActivity(activity),
ImmediateUpload = false,
Data = data,
});
_logger.Debug($"[ConsoleBypassHost] script activity reported: {activity.Count} short-lived {activity.ProcessName} " +
$"from {activity.ParentsTotal} parent(s){(capped ? " (summary cap reached)" : string.Empty)}");
}
catch (Exception ex)
{
_logger.Warning($"[ConsoleBypassHost] failed to emit console_script_activity: {ex.Message}");
}
}
/// <summary>The timeline text of one summary (internal for tests).</summary>
internal static string DescribeScriptActivity(ConsoleScriptActivity activity)
{
var processes = activity.Count == 1
? $"1 short-lived {activity.ProcessName} process"
: $"{activity.Count} short-lived {activity.ProcessName} processes";
var sessions = activity.WindowsSessions.Count == 1
? $"session {activity.WindowsSessions[0]}"
: $"sessions {string.Join(", ", activity.WindowsSessions)}";
string startedBy;
if (activity.ParentsTotal == 1 && activity.Parents.Count == 1)
{
startedBy = activity.Parents[0].Name ?? "an unknown program";
}
else
{
var names = activity.Parents
.Select(p => p.Name)
.Where(n => !string.IsNullOrEmpty(n))
.Distinct(StringComparer.OrdinalIgnoreCase)
.ToList();
var shown = names.Take(3).ToList();
var more = names.Count > shown.Count || activity.Parents.Any(p => p.Name == null) || activity.ParentsTotal > activity.Parents.Count;
startedBy = $"{activity.ParentsTotal} parent processes";
if (shown.Count > 0)
startedBy += $" ({string.Join(", ", shown)}{(more ? ", …" : string.Empty)})";
}
return $"Script activity: {processes} in {sessions}, started by {startedBy} — counted, not an interactive console";
}
// The WMI live watcher could not arm — surface it as collector_degraded so the backend can
// tell "no console detected" from "live detector never started" (MON-D1 pattern).
private void OnWatcherArmFailed(object? sender, Exception ex)
@@ -151,12 +299,25 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
public void Dispose()
{
if (Interlocked.Exchange(ref _disposed, 1) == 1) return;
// What was counted goes out first. It has to happen here, in the host's stop: the
// handlers below go away, and once the orchestrator has stopped the ingress a post throws.
ReportScriptActivity(stopping: true);
if (_observableIngress != null && _signalPostedHandler != null)
{
try { _observableIngress.SignalPosted -= _signalPostedHandler; } catch { }
}
try { _watcher.BypassConsoleDetected -= OnBypassConsoleDetected; } catch { }
try { _watcher.ScriptActivityStarted -= OnScriptActivityStarted; } catch { }
try { _watcher.WatcherArmFailed -= OnWatcherArmFailed; } catch { }
lock (_summaryLock)
{
try { _windowTimer?.Dispose(); } catch { }
_windowTimer = null;
}
try { _watcher.Dispose(); } catch { }
}
@@ -4,6 +4,7 @@ using System.Threading;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Office;
using AutopilotMonitor.DecisionCore.Engine;
using Microsoft.Win32;
namespace AutopilotMonitor.Agent.V2.Core.Orchestration
{
@@ -49,9 +50,13 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
private readonly OfficeInstallDetector _detector;
private readonly OfficeProcessWatcher _processWatcher;
private readonly AgentLogger _logger;
// Guards the fields below, nothing else. Never held across a call into a watcher or the
// detector: their callbacks come back into this host and take it.
private readonly object _lock = new object();
private readonly OfficeInstallStateData? _resumeState;
private readonly RegistryHive _registryHive;
private readonly string _registrySubKey;
private RegistryChangeWatcher? _registryWatcher;
private OfficeBinaryWatcher? _binaryWatcher;
private bool _pathObserved; // InstallationPath known → stop poking the DO collector
@@ -74,16 +79,42 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
int settleSeconds,
OfficeInstallStatePersistence? statePersistence = null,
OfficeInstallStateData? resumeState = null)
: this(sessionId, tenantId, ingress, clock, logger, settleSeconds, statePersistence, resumeState,
RegistryHive.LocalMachine, ClickToRunSubKey, snapshotProvider: null)
{
}
/// <summary>
/// Test seam: points the registry watcher at a key a test may write to and feeds the
/// detector synthetic snapshots. Production uses the constructor above.
/// </summary>
internal OfficeInstallDetectorHost(
string sessionId,
string tenantId,
ISignalIngressSink ingress,
IClock clock,
AgentLogger logger,
int settleSeconds,
OfficeInstallStatePersistence? statePersistence,
OfficeInstallStateData? resumeState,
RegistryHive registryHive,
string registrySubKey,
Func<OfficeC2RSnapshot>? snapshotProvider)
{
if (ingress == null) throw new ArgumentNullException(nameof(ingress));
if (clock == null) throw new ArgumentNullException(nameof(clock));
_logger = logger ?? throw new ArgumentNullException(nameof(logger));
_resumeState = resumeState;
_registryHive = registryHive;
_registrySubKey = registrySubKey ?? throw new ArgumentNullException(nameof(registrySubKey));
var post = new InformationalEventPost(ingress, clock);
_detector = new OfficeInstallDetector(sessionId, tenantId, post, logger, clock,
onInstallationPathObserved: OnInstallationPathObserved,
statePersistence: statePersistence);
statePersistence: statePersistence)
{
SnapshotProvider = snapshotProvider,
};
_processWatcher = new OfficeProcessWatcher(logger, settleSeconds);
_processWatcher.Started += OnWorkerStarted;
}
@@ -108,12 +139,10 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
// Arm the registry watcher up front (not at worker-start) so the early Scenario\INSTALL key
// is caught before the (late) worker process. The watcher's bootstrap fallback handles the
// case where the ClickToRun key does not exist yet on a clean first install.
lock (_lock)
{
_registryWatcher = new RegistryChangeWatcher(ClickToRunSubKey, _logger);
_registryWatcher.Changed += OnRegistryChanged;
_registryWatcher.Start();
}
var registryWatcher = new RegistryChangeWatcher(_registryHive, _registrySubKey, _logger);
registryWatcher.Changed += OnRegistryChanged;
lock (_lock) { _registryWatcher = registryWatcher; }
registryWatcher.Start();
_processWatcher.Start();
// Resume a persisted *Active* lifecycle (enrollments span reboots) AFTER the watchers are
@@ -134,7 +163,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
// re-poking it on every registry value churn is pure log noise (field session 7da7dead).
bool raise;
lock (_lock) { raise = !_pathObserved && !_lifecycleEnded; }
if (raise)
// A callback can still be running after Dispose returned — Dispose never waits for one.
if (raise && Volatile.Read(ref _disposed) == 0)
{
try { OfficeExpected?.Invoke(this, EventArgs.Empty); }
catch (Exception ex) { _logger.Warning($"[OfficeInstallDetectorHost] OfficeExpected handler threw: {ex.Message}"); }
@@ -147,15 +177,21 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
private void OnInstallationPathObserved(string? installationPath)
{
OfficeBinaryWatcher watcher;
lock (_lock)
{
_pathObserved = true; // stop raising OfficeExpected (lifecycle has started)
if (_lifecycleEnded || _binaryWatcher != null || string.IsNullOrEmpty(installationPath)) return;
if (Volatile.Read(ref _disposed) == 1) return;
_binaryWatcher = new OfficeBinaryWatcher(installationPath!, OfficeInstallDetector.CoreBinaries, _logger);
_binaryWatcher.BinaryAppeared += OnBinaryAppeared;
_binaryWatcher.Start();
watcher = new OfficeBinaryWatcher(installationPath!, OfficeInstallDetector.CoreBinaries, _logger);
watcher.BinaryAppeared += OnBinaryAppeared;
_binaryWatcher = watcher;
}
// Start can raise BinaryAppeared right away (Office already on disk), and that handler
// ends in DisposeWatchers.
watcher.Start();
}
private void OnBinaryAppeared(object? sender, EventArgs e)
@@ -191,20 +227,25 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
private void DisposeWatchers()
{
RegistryChangeWatcher? registryWatcher;
OfficeBinaryWatcher? binaryWatcher;
lock (_lock)
{
if (_registryWatcher != null)
{
try { _registryWatcher.Changed -= OnRegistryChanged; } catch { }
try { _registryWatcher.Dispose(); } catch { }
_registryWatcher = null;
}
if (_binaryWatcher != null)
{
try { _binaryWatcher.BinaryAppeared -= OnBinaryAppeared; } catch { }
try { _binaryWatcher.Dispose(); } catch { }
_binaryWatcher = null;
}
registryWatcher = _registryWatcher;
_registryWatcher = null;
binaryWatcher = _binaryWatcher;
_binaryWatcher = null;
}
if (registryWatcher != null)
{
try { registryWatcher.Changed -= OnRegistryChanged; } catch { }
try { registryWatcher.Dispose(); } catch { }
}
if (binaryWatcher != null)
{
try { binaryWatcher.BinaryAppeared -= OnBinaryAppeared; } catch { }
try { binaryWatcher.Dispose(); } catch { }
}
}
}
@@ -101,6 +101,10 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
// The OOBE update registry snapshot (D-310) is observation at agent start/stop and at
// the update page — the page's own records (oobe_update_page) stay activity.
SharedConstants.EventTypes.OobeUpdateState,
// The count of short-lived console processes: a script that keeps spawning them for
// hours would otherwise hold the periodic collectors awake and reset the stall clock.
// The work those scripts do arrives as its own app, script or phase event.
SharedConstants.EventTypes.ConsoleScriptActivity,
};
/// <summary>
@@ -46,6 +46,12 @@ namespace AutopilotMonitor.Agent.V2.Core.Security
/// authorized agent.</item>
/// <item>Any other coded 409 (<see cref="BackendRefusalException"/>) → <see cref="SessionRegistrationOutcome.Failed"/>
/// without retrying — a refusal with a code does not clear by waiting.</item>
/// <item>410 from the backend (<see cref="BackendSessionGoneException"/>): the persisted
/// session was deleted. With <c>rotateOnSessionGone</c> (a WhiteGlove Part 2 start, whose
/// enrollment is only now continuing) the session is rotated like above and registered
/// once more. Every other start returns <see cref="SessionRegistrationOutcome.SessionGone"/>
/// without retrying — the caller ends monitoring. So does a second 410 or a failed rotation:
/// the 48-hour break skips a WhiteGlove resume, so no path here may leave it retrying.</item>
/// <item>Any other exception on the last attempt → <see cref="EmergencyReporter.TrySendAsync"/>
/// with <c>AgentErrorType.RegisterSessionFailed</c> so operators see the final cause.</item>
/// </list>
@@ -75,6 +81,10 @@ namespace AutopilotMonitor.Agent.V2.Core.Security
/// Optional pre-registration link wait used by tests. Production callers pass
/// <c>null</c> → <see cref="WaitForNetworkLinkAsync"/> (bounded by <see cref="NetworkLinkWaitMax"/>).
/// </param>
/// <param name="rotateOnSessionGone">
/// True at a WhiteGlove Part 2 start: a 410 for the persisted session then becomes a new
/// session through <paramref name="rotateSession"/> instead of ending monitoring.
/// </param>
public static async Task<SessionRegistrationResult> RegisterWithRetryAsync(
BackendApiClient apiClient,
AgentConfiguration agentConfig,
@@ -86,7 +96,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Security
Func<Exception, Task> onTerminalTransportFailure = null,
(string Manufacturer, string Model, string SerialNumber)? deviceHardware = null,
Func<AgentLogger, Task> networkLinkWait = null,
Func<string> rotateSession = null)
Func<string> rotateSession = null,
bool rotateOnSessionGone = false)
{
if (apiClient == null) throw new ArgumentNullException(nameof(apiClient));
if (agentConfig == null) throw new ArgumentNullException(nameof(agentConfig));
@@ -101,6 +112,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Security
string lastError = null;
Exception lastException = null;
string rotatedFromSessionId = null;
string rotationReason = null;
for (int attempt = 1; attempt <= MaxAttempts; attempt++)
{
@@ -112,7 +124,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Security
if (response != null && response.Success)
{
logger.Info($"Session registered successfully: {response.SessionId} (validatedBy={response.ValidatedBy}, adminAction={response.AdminAction ?? "(none)"})");
return SessionRegistrationResult.Succeeded(response, rotatedFromSessionId);
return SessionRegistrationResult.Succeeded(response, rotatedFromSessionId, rotationReason);
}
lastError = response?.Message ?? "(null response)";
@@ -149,9 +161,40 @@ namespace AutopilotMonitor.Agent.V2.Core.Security
$"Backend refused registration with {Constants.AgentErrorCodes.SessionOwnerMismatch}: session {rotatedFromSessionId} " +
$"is not this device's (bound to another device identity after a re-enrollment without wipe, or claimed by another tenant). " +
$"Rotated to {newSessionId}; re-registering.");
rotationReason = SessionRotationReasons.OwnerMismatch;
registration = BuildRegistration(agentConfig, agentVersion, deviceHardware);
continue;
}
catch (BackendSessionGoneException ex)
{
if (rotateOnSessionGone && rotateSession != null && rotatedFromSessionId == null)
{
var goneSessionId = registration.SessionId;
string newSessionId = null;
try
{
newSessionId = rotateSession();
}
catch (Exception rotateEx)
{
logger.Error($"Backend answered 410 for session {goneSessionId} but session rotation failed: {rotateEx.Message}", rotateEx);
}
if (newSessionId != null)
{
rotatedFromSessionId = goneSessionId;
rotationReason = SessionRotationReasons.SessionGone;
logger.Warning(
$"Backend answered 410 for session {goneSessionId} at the start of a WhiteGlove Part 2: " +
$"the session was deleted. Rotated to {newSessionId}; re-registering.");
registration = BuildRegistration(agentConfig, agentVersion, deviceHardware);
continue;
}
}
logger.Error($"Session registration refused with 410 Gone — the backend deleted session {registration.SessionId}.");
return SessionRegistrationResult.SessionGone(ex.StatusCode, ex.Message);
}
catch (BackendRefusalException ex)
{
logger.Error($"Session registration refused ({ex.StatusCode}, {ex.ErrorCode}): {ex.Message}");
@@ -294,6 +337,22 @@ namespace AutopilotMonitor.Agent.V2.Core.Security
/// <summary>All attempts failed with non-auth errors (network, 5xx, malformed response).</summary>
Failed = 2,
/// <summary>
/// 410 from the backend: the persisted session was deleted. No retry was attempted; the
/// caller ends monitoring and cleans up.
/// </summary>
SessionGone = 3,
}
/// <summary>Why a run registered under a new SessionId (<see cref="SessionRegistrationResult.RotationReason"/>).</summary>
public static class SessionRotationReasons
{
/// <summary>The backend refused the persisted id with <c>session_owner_mismatch</c>.</summary>
public const string OwnerMismatch = "owner_mismatch";
/// <summary>The backend answered 410 for the persisted id at a WhiteGlove Part 2 start.</summary>
public const string SessionGone = "session_gone";
}
/// <summary>Result of <see cref="SessionRegistrationHelper.RegisterWithRetryAsync"/>.</summary>
@@ -308,12 +367,15 @@ namespace AutopilotMonitor.Agent.V2.Core.Security
public ValidatorType ValidatedBy => Response?.ValidatedBy ?? ValidatorType.Unknown;
/// <summary>
/// SESSION-OWNER-BINDING: the SessionId this run started with when the backend refused it
/// with <c>session_owner_mismatch</c> and the session was rotated before the successful
/// The SessionId this run started with when the backend refused it (<c>session_owner_mismatch</c>,
/// or 410 at a WhiteGlove Part 2 start) and the session was rotated before the successful
/// registration. Null on the normal path.
/// </summary>
public string RotatedFromSessionId { get; }
/// <summary>One of <see cref="SessionRotationReasons"/> when <see cref="RotatedFromSessionId"/> is set, else null.</summary>
public string RotationReason { get; }
/// <summary>
/// True when the run ended on a 401/403 that something on the network path answered (TLS
/// inspection, a proxy page — <see cref="BackendAuthException.IsForeignResponse"/>), not
@@ -327,7 +389,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Security
int httpStatusCode,
string errorMessage,
string rotatedFromSessionId = null,
bool isIntercepted = false)
bool isIntercepted = false,
string rotationReason = null)
{
Outcome = outcome;
Response = response;
@@ -335,10 +398,16 @@ namespace AutopilotMonitor.Agent.V2.Core.Security
ErrorMessage = errorMessage;
RotatedFromSessionId = rotatedFromSessionId;
IsIntercepted = isIntercepted;
RotationReason = rotatedFromSessionId != null ? rotationReason : null;
}
public static SessionRegistrationResult Succeeded(RegisterSessionResponse response, string rotatedFromSessionId = null)
=> new SessionRegistrationResult(SessionRegistrationOutcome.Succeeded, response, 200, null, rotatedFromSessionId);
public static SessionRegistrationResult Succeeded(
RegisterSessionResponse response, string rotatedFromSessionId = null, string rotationReason = null)
=> new SessionRegistrationResult(
SessionRegistrationOutcome.Succeeded, response, 200, null, rotatedFromSessionId, rotationReason: rotationReason);
public static SessionRegistrationResult SessionGone(int statusCode, string message)
=> new SessionRegistrationResult(SessionRegistrationOutcome.SessionGone, null, statusCode, message);
public static SessionRegistrationResult AuthFailed(int statusCode, string message, bool intercepted = false)
=> new SessionRegistrationResult(SessionRegistrationOutcome.AuthFailed, null, statusCode, message, isIntercepted: intercepted);
@@ -324,7 +324,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Termination
// DeliveryOptimizationCollector, …) before the diagnostics ZIP is built so
// late `performance_snapshot` / `agent_metrics_snapshot` events don't slip in
// after `diagnostics_collecting` and the snapshot captured in the package
// matches the timeline. Best-effort — never blocks termination.
// matches the timeline. Best-effort, and bounded per host by the orchestrator:
// a collector that hangs is left behind, so the upload and the cleanup below
// still run.
StopPeripheralCollectorsBestEffort();
RunUploadDiagnosticsWithEvents(args);
@@ -78,7 +78,7 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
</ItemGroup>
<!-- Plan §2.16 strict separation rule — build-time enforcement. -->
@@ -257,7 +257,7 @@ namespace AutopilotMonitor.Agent.V2
/// <c>true</c> when the file-based <c>enrollment-complete.marker</c> signals that a
/// previous session already completed enrollment — written by
/// <see cref="EndMonitoringAtStart"/> (emergency break, intercepted-registration give-up,
/// config kill signal) right before it fires the cleanup retry, so that a next-boot observing the marker exits
/// session gone at registration, config kill signal) right before it fires the cleanup retry, so that a next-boot observing the marker exits
/// cleanly even if the cleanup retry failed to remove the Scheduled Task. Triggers another
/// self-destruct attempt when <paramref name="selfDestructOnComplete"/> is set.
/// <para>
@@ -369,10 +369,11 @@ namespace AutopilotMonitor.Agent.V2
/// next start exits cleanly even if the cleanup retry fails (Scheduled Task still alive,
/// files locked, …), runs the cleanup retry when <paramref name="runSelfDestruct"/> is set
/// (the emergency break and the give-up pass <c>SelfDestructOnComplete</c>, the kill signal
/// forces it), and deletes the persisted session files. Shared by the session-age emergency
/// break, the intercepted-registration give-up
/// (<c>BackendSessionRegistration.ConcludeFailedRun</c>) and the config-channel kill signal
/// so all three leave the device in the same state. Never throws.
/// and the session-gone end force it), and deletes the persisted session files. Shared by
/// the session-age emergency break, the intercepted-registration give-up
/// (<c>BackendSessionRegistration.ConcludeFailedRun</c>), the registration answered with 410
/// (<c>BackendSessionRegistration.ConcludeSessionGone</c>) and the config-channel kill signal
/// so all four leave the device in the same state. Never throws.
/// </summary>
internal static void EndMonitoringAtStart(
string stateDirectory,
@@ -275,7 +275,9 @@ namespace AutopilotMonitor.Agent.V2
// mapping + on-failure client disposal) is encapsulated in BackendSessionRegistration.
// Exit codes: 6 = AuthFailed, 7 = anything else. A registration intercepted on more
// starts than the buffer allows cleans up like the emergency break (state folder +
// cleanup factory) and still exits 6. See Runtime/BackendSessionRegistration.cs.
// cleanup factory) and still exits 6. A registration the backend answers with 410
// (session deleted) cleans up the same way and exits 0; a WhiteGlove Part 2 start
// registers a new session instead. See Runtime/BackendSessionRegistration.cs.
var registration = Runtime.BackendSessionRegistration.Register(
bootstrap.AgentConfig, auth, telemetry.MtlsHttpClient, GetAgentVersion(), consoleMode, logger,
rotateSession: () => Runtime.BackendSessionRegistration.RotateSession(
@@ -283,7 +285,8 @@ namespace AutopilotMonitor.Agent.V2
sessionPersistence: bootstrap.SessionPersistence,
configFetchOutcome: runtimeConfig.RemoteConfigService.LastFetchOutcome.ToString(),
stateDirectory: stateSubdir,
cleanupServiceFactory: bootstrap.CleanupServiceFactory);
cleanupServiceFactory: bootstrap.CleanupServiceFactory,
isWhiteGloveResume: bootstrap.IsWhiteGloveResume);
if (registration.ShouldExit)
{
return registration.ExitCode;
@@ -347,7 +347,8 @@ namespace AutopilotMonitor.Agent.V2.Runtime
lifecyclePost = new InformationalEventPost(ingress, SystemClock.Instance, logger);
LifecycleEmitters.EmitAgentStarted(lifecyclePost, agentConfig, previousExit, agentVersion, remoteConfigService, logger,
rotatedFromSessionId: registrationResult?.RotatedFromSessionId,
priorRegistrationFailures: registration.PriorFailures);
priorRegistrationFailures: registration.PriorFailures,
sessionRotationReason: registrationResult?.RotationReason);
// Wire-visible signal that the agent is running on defaults/cache
// rather than the live tenant config — closes the cold-start
// blind spot observed in session 8f2bef72 (2026-05-19).
@@ -26,6 +26,9 @@ namespace AutopilotMonitor.Agent.V2.Runtime
/// the next boot. The failed run is recorded for the emergency break report. A registration
/// that something on the network path answered gets <c>InterceptedRegistrationRetryBoots</c>
/// further boots, then the agent cleans up like the emergency break (<see cref="ConcludeFailedRun"/>).
/// A registration the backend answers with 410 — the session was deleted — ends monitoring at
/// once (<see cref="ConcludeSessionGone"/>); only a WhiteGlove Part 2 start registers a new
/// session instead, because its enrollment is only now continuing.
/// A successful registration after failed starts reports them on <c>agent_started</c>
/// (<see cref="ClearAfterSuccess"/>).
/// </summary>
@@ -37,8 +40,9 @@ namespace AutopilotMonitor.Agent.V2.Runtime
/// </summary>
internal static readonly TimeSpan PendingDistressBound = TimeSpan.FromSeconds(5);
/// <param name="stateDirectory">State folder for <c>enrollment-complete.marker</c> on the intercepted-registration give-up.</param>
/// <param name="cleanupServiceFactory">Self-destruct for the give-up (run when <c>SelfDestructOnComplete</c>).</param>
/// <param name="stateDirectory">State folder for <c>enrollment-complete.marker</c> on the intercepted-registration give-up and the session-gone end.</param>
/// <param name="cleanupServiceFactory">Self-destruct for the give-up (run when <c>SelfDestructOnComplete</c>) and the session-gone end (always run).</param>
/// <param name="isWhiteGloveResume">This start is a WhiteGlove Part 2: a 410 for the persisted session becomes a new session.</param>
public static SessionRegistrationOutcomeResult Register(
AgentConfiguration agentConfig,
BackendAuthBundle auth,
@@ -50,7 +54,8 @@ namespace AutopilotMonitor.Agent.V2.Runtime
SessionIdPersistence sessionPersistence = null,
string configFetchOutcome = null,
string stateDirectory = null,
Func<CleanupService> cleanupServiceFactory = null)
Func<CleanupService> cleanupServiceFactory = null,
bool isWhiteGloveResume = false)
{
if (agentConfig == null) throw new ArgumentNullException(nameof(agentConfig));
if (auth == null) throw new ArgumentNullException(nameof(auth));
@@ -86,7 +91,8 @@ namespace AutopilotMonitor.Agent.V2.Runtime
// Reuse the single hardened hardware read from the auth bundle so the session row
// matches the security headers the backend validated against (no second WMI query).
deviceHardware: (auth.Manufacturer, auth.Model, auth.SerialNumber),
rotateSession: rotateSession)
rotateSession: rotateSession,
rotateOnSessionGone: isWhiteGloveResume)
.GetAwaiter().GetResult();
if (registrationResult.Outcome == SessionRegistrationOutcome.Succeeded)
@@ -97,6 +103,17 @@ namespace AutopilotMonitor.Agent.V2.Runtime
startContext.DeviceBootUtc, auth.ClientCertificateThumbprint));
}
if (registrationResult.Outcome == SessionRegistrationOutcome.SessionGone)
{
// The report goes out through the auth bundle's client: dispose only afterwards.
var exitCode = ConcludeSessionGone(
agentConfig, auth.EmergencyReporter, sessionPersistence, stateDirectory,
cleanupServiceFactory, consoleMode, logger);
try { mtlsHttpClient?.Dispose(); } catch { }
try { auth.BackendApiClient?.Dispose(); } catch { }
return SessionRegistrationOutcomeResult.Exit(exitCode);
}
var record = RecordFailedRun(
sessionPersistence, registrationResult, startedUtc, DateTime.UtcNow,
linkUpAtStart, TryIsNetworkLinkUp(), configFetchOutcome, NetworkFingerprint.TryCapture(), logger,
@@ -264,6 +281,41 @@ namespace AutopilotMonitor.Agent.V2.Runtime
return registrationResult.Outcome == SessionRegistrationOutcome.AuthFailed ? 6 : 7;
}
/// <summary>
/// The end of a start whose registration the backend answered with 410: the session was
/// deleted. One report over the emergency channel (a deleted session has no timeline to
/// carry an event), then monitoring ends like on the telemetry-channel 410 — marker first,
/// self-destruct regardless of <c>SelfDestructOnComplete</c>, session files deleted
/// (<see cref="Program.EndMonitoringAtStart"/>). Returns exit code 0: an intended end.
/// </summary>
internal static int ConcludeSessionGone(
AgentConfiguration agentConfig,
EmergencyReporter emergencyReporter,
SessionIdPersistence sessionPersistence,
string stateDirectory,
Func<CleanupService> cleanupServiceFactory,
bool consoleMode,
AgentLogger logger)
{
logger.Error(
$"=== SESSION GONE (HTTP 410): the backend deleted session {agentConfig.SessionId} — " +
"reporting once over the emergency channel, then cleaning up with self-destruct. ===");
if (consoleMode)
Console.Error.WriteLine("Session was deleted in the backend. Cleaning up and exiting.");
SessionGoneReport.SendBlocking(
emergencyReporter,
AgentErrorType.RegistrationRejectedSessionGone,
"Session registration rejected with HTTP 410 — the backend deleted this session. Agent cleaning up with self-destruct.",
logger);
Program.EndMonitoringAtStart(
stateDirectory, sessionPersistence, runSelfDestruct: true, cleanupServiceFactory, logger,
markerText: $"Session gone at {DateTime.UtcNow:O} (registration refused with HTTP 410)",
cleanupReason: "session_gone");
return 0;
}
/// <summary>
/// Boot times derived from the uptime counter jitter by milliseconds to seconds between two
/// reads of the same boot (NTP corrections shift them further), so only a gap above this
@@ -47,7 +47,8 @@ namespace AutopilotMonitor.Agent.V2.Runtime
RemoteConfigService remoteConfigService,
AgentLogger logger,
string rotatedFromSessionId = null,
PriorRegistrationFailures priorRegistrationFailures = null)
PriorRegistrationFailures priorRegistrationFailures = null,
string sessionRotationReason = null)
{
try
{
@@ -72,9 +73,10 @@ namespace AutopilotMonitor.Agent.V2.Runtime
{ "diagnosticsUploadMode", agentConfig.DiagnosticsUploadMode ?? "Off" },
{ "previousExitType", previousExit?.ExitType ?? "unknown" },
{ "unrestrictedMode", agentConfig.UnrestrictedMode },
// SESSION-OWNER-BINDING: true when the backend refused the persisted session
// id (session_owner_mismatch) and this run rotated to a new session before
// registering — the re-enroll-without-wipe shape, made visible on the timeline.
// True when the backend refused the persisted session id and this run rotated
// to a new session before registering: session_owner_mismatch (re-enroll
// without wipe) or 410 at a WhiteGlove Part 2 start (session deleted).
// sessionRotationReason below names which.
{ "sessionRotated", rotatedFromSessionId != null },
{ "previousSessionId", rotatedFromSessionId ?? string.Empty },
// remoteConfigFetched answers "is the agent running on a live-fetched
@@ -96,6 +98,9 @@ namespace AutopilotMonitor.Agent.V2.Runtime
if (recovered)
data["remoteConfigRecovered"] = true;
if (rotatedFromSessionId != null && !string.IsNullOrEmpty(sessionRotationReason))
data["sessionRotationReason"] = sessionRotationReason;
// Which bootstrap installed this agent (installer and loader versions, MSI or
// Intune loader, OOBE go-script), read from the scripts' own logs: makes the
// fleet's share of old or directly assigned installers countable.
@@ -1,6 +1,5 @@
using System;
using System.Collections.Generic;
using System.Net;
using System.Threading;
using System.Threading.Tasks;
using AutopilotMonitor.Agent.V2.Core.Configuration;
@@ -193,14 +192,6 @@ namespace AutopilotMonitor.Agent.V2.Runtime
};
}
// Bounded blocking send for the one session-gone report: the terminate that follows ends
// the process and the cleanup script deletes the agent, so a fire-and-forget send would
// be abandoned mid-flight. Retries stay inside one anti-flood reservation (ONE report).
private const int SessionGoneReportAttempts = 2;
private static readonly TimeSpan SessionGoneReportTimeout = TimeSpan.FromSeconds(15);
private static readonly TimeSpan SessionGoneReportRetryDelay = TimeSpan.FromSeconds(3);
private static readonly TimeSpan SessionGoneReportBudget = TimeSpan.FromSeconds(40);
/// <summary>
/// The backend answered HTTP 410 for the current session's telemetry: the session is over
/// server-side. (a) Send ONE <see cref="AgentErrorType.TelemetryRejectedSessionUnknown"/>
@@ -227,25 +218,11 @@ namespace AutopilotMonitor.Agent.V2.Runtime
logger.Error($"Backend no longer knows this session (HTTP 410: {reason}) — reporting once over the emergency channel, then terminating with self-destruct.");
if (emergencyReporter != null)
{
try
{
emergencyReporter
.TrySendAsync(
AgentErrorType.TelemetryRejectedSessionUnknown,
$"Telemetry upload rejected with HTTP 410 — backend no longer knows this session ({reason}). Agent terminating with self-destruct.",
httpStatusCode: (int)HttpStatusCode.Gone,
attempts: SessionGoneReportAttempts,
perAttemptTimeout: SessionGoneReportTimeout,
retryDelay: SessionGoneReportRetryDelay)
.Wait(SessionGoneReportBudget);
}
catch (Exception ex)
{
logger.Debug($"Session-gone report send failed (best-effort): {ex.Message}");
}
}
SessionGoneReport.SendBlocking(
emergencyReporter,
AgentErrorType.TelemetryRejectedSessionUnknown,
$"Telemetry upload rejected with HTTP 410 — backend no longer knows this session ({reason}). Agent terminating with self-destruct.",
logger);
var terminateAction = new ServerAction
{
@@ -0,0 +1,50 @@
using System;
using System.Net;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Transport;
using AutopilotMonitor.Shared.Models;
namespace AutopilotMonitor.Agent.V2.Runtime
{
/// <summary>
/// The one emergency report an agent sends when the backend answered HTTP 410 for its own
/// session — on a telemetry upload (<see cref="ServerControlPlane.HandleSessionGone"/>) or at
/// registration (<see cref="BackendSessionRegistration"/>). The send blocks within a bound:
/// the caller ends the process right after and the cleanup deletes the agent, so a
/// fire-and-forget send would be abandoned mid-flight. Retries stay inside one anti-flood
/// reservation (ONE report). Never throws.
/// </summary>
internal static class SessionGoneReport
{
private const int Attempts = 2;
private static readonly TimeSpan PerAttemptTimeout = TimeSpan.FromSeconds(15);
private static readonly TimeSpan RetryDelay = TimeSpan.FromSeconds(3);
private static readonly TimeSpan Budget = TimeSpan.FromSeconds(40);
public static void SendBlocking(
EmergencyReporter emergencyReporter,
AgentErrorType errorType,
string message,
AgentLogger logger)
{
if (emergencyReporter == null) return;
try
{
emergencyReporter
.TrySendAsync(
errorType,
message,
httpStatusCode: (int)HttpStatusCode.Gone,
attempts: Attempts,
perAttemptTimeout: PerAttemptTimeout,
retryDelay: RetryDelay)
.Wait(Budget);
}
catch (Exception ex)
{
logger.Debug($"Session-gone report send failed (best-effort): {ex.Message}");
}
}
}
}
@@ -13,9 +13,9 @@
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
<PackageReference Include="xunit" Version="2.9.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.11.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="4.0.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
@@ -15,9 +15,9 @@
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
<PackageReference Include="xunit" Version="2.9.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.11.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="4.0.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
@@ -15,7 +15,7 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
</ItemGroup>
<ItemGroup>
@@ -2,6 +2,7 @@ using System.Text.Json;
using AutopilotMonitor.Functions.Functions.Raw;
using AutopilotMonitor.Functions.Middleware;
using AutopilotMonitor.Functions.Security;
using AutopilotMonitor.Functions.Services;
using Xunit;
namespace AutopilotMonitor.Functions.Tests;
@@ -71,7 +72,7 @@ public class AppInsightsQueryFunctionTests
"rows":[["2026-09-04T10:00:00Z",42,"{\"TenantId\":\"t1\"}",null]]}]}
""";
var (tables, partial) = AppInsightsQueryFunction.ParseKustoBody(body);
var (tables, partial) = LogQueryExecutor.ParseKustoBody(body);
Assert.Null(partial);
var table = Assert.Single(tables);
@@ -97,7 +98,7 @@ public class AppInsightsQueryFunctionTests
"error":{"code":"PartialError","message":"There were some errors when processing your query.","innererror":{"code":"E_QUERY_RESULT_SET_TOO_LARGE","message":"Query result set has exceeded the internal record count limit 500000."}}}
""";
var (tables, partial) = AppInsightsQueryFunction.ParseKustoBody(body);
var (tables, partial) = LogQueryExecutor.ParseKustoBody(body);
Assert.Single(tables);
Assert.Equal("E_QUERY_RESULT_SET_TOO_LARGE: Query result set has exceeded the internal record count limit 500000.", partial);
@@ -106,7 +107,7 @@ public class AppInsightsQueryFunctionTests
[Fact]
public void Empty_or_shapeless_body_yields_no_tables_and_no_partial()
{
var (tables, partial) = AppInsightsQueryFunction.ParseKustoBody("{}");
var (tables, partial) = LogQueryExecutor.ParseKustoBody("{}");
Assert.Empty(tables);
Assert.Null(partial);
}
@@ -115,16 +116,16 @@ public class AppInsightsQueryFunctionTests
[Fact]
public void Error_extraction_prefers_innererror_and_tolerates_non_json()
{
var (msg, code) = AppInsightsQueryFunction.ExtractError(
var (msg, code) = LogQueryExecutor.ExtractError(
"""{"error":{"message":"The request had some invalid properties","code":"BadArgumentError","innererror":{"code":"SyntaxError","message":"Query could not be parsed at 'foo'"}}}""");
Assert.Equal("SyntaxError", code);
Assert.Equal("Query could not be parsed at 'foo'", msg);
var (outerMsg, outerCode) = AppInsightsQueryFunction.ExtractError("""{"error":{"message":"Forbidden","code":"InsufficientAccessError"}}""");
var (outerMsg, outerCode) = LogQueryExecutor.ExtractError("""{"error":{"message":"Forbidden","code":"InsufficientAccessError"}}""");
Assert.Equal("InsufficientAccessError", outerCode);
Assert.Equal("Forbidden", outerMsg);
var (plainMsg, plainCode) = AppInsightsQueryFunction.ExtractError("<html>502 Bad Gateway</html>");
var (plainMsg, plainCode) = LogQueryExecutor.ExtractError("<html>502 Bad Gateway</html>");
Assert.Null(plainCode);
Assert.Equal("Telemetry store query failed", plainMsg);
}
@@ -181,7 +181,7 @@ public class AuthFunctionSideEffectTests
return BuildRequest(new ClaimsPrincipal(new ClaimsIdentity(claims, "test")));
}
private static (HttpRequestData Req, FunctionContext Ctx) BuildRequest(ClaimsPrincipal principal)
private static (HttpRequestData Req, FunctionContext Ctx) BuildRequest(ClaimsPrincipal principal, RequestContext? requestContext = null)
{
var services = new ServiceCollection();
services.AddOptions();
@@ -190,9 +190,11 @@ public class AuthFunctionSideEffectTests
new System.Text.Json.JsonSerializerOptions(System.Text.Json.JsonSerializerDefaults.Web)));
var provider = services.BuildServiceProvider();
var items = new Dictionary<object, object> { ["ClaimsPrincipal"] = principal };
if (requestContext != null)
items[RequestContext.ItemsKey] = requestContext;
var context = new Mock<FunctionContext>();
context.SetupGet(c => c.Items).Returns(
new Dictionary<object, object> { ["ClaimsPrincipal"] = principal });
context.SetupGet(c => c.Items).Returns(items);
context.SetupGet(c => c.InstanceServices).Returns(provider);
var req = new Mock<HttpRequestData>(context.Object);
@@ -1093,4 +1095,96 @@ public class AuthFunctionSideEffectTests
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
Assert.Equal(Constants.Push.DeviceStatus.Active, push.Repo.Devices[(Constants.Push.PlatformScope, "ga-phone")].Status);
}
// -------------------------------------------------------------------------
// GetCurrentUser under view-as: a Global Admin reads another tenant as its member
// -------------------------------------------------------------------------
private const string ViewedTenantId = "cccccccc-1111-2222-3333-444444444444";
/// <summary>The context PolicyEnforcementMiddleware builds for an admitted view-as request.</summary>
private static RequestContext ViewingAs(string role) => new()
{
TenantId = ViewedTenantId,
TargetTenantId = ViewedTenantId,
UserPrincipalName = Upn,
UserRole = role,
IsTenantAdmin = role == Constants.TenantRoles.Admin,
ViewAs = new ViewAsContext(TenantId, role),
};
[Fact]
public async Task GetCurrentUser_ViewAs_AnswersAsTheViewedTenantsMember_WithoutAnySignInSideEffect()
{
// The viewed tenant asks for the Terms + DPA; the caller's home row still lacks its domain — exactly the
// state in which an ordinary sign-in would seed it, onboard, and record a login.
var viewed = TenantConfiguration.CreateDefault(ViewedTenantId);
viewed.DomainName = "fabrikam.example";
viewed.CompanyName = "Fabrikam";
viewed.DpaAcceptancePending = true;
var home = DefaultConfig();
home.DomainName = null!;
_tenantConfigMock.Setup(x => x.TryGetConfigurationAsync(ViewedTenantId)).ReturnsAsync((viewed, true));
_tenantConfigMock.Setup(x => x.TryGetConfigurationAsync(TenantId)).ReturnsAsync((home, true));
var viewedStore = _tenantConfigMock.StubWrites(ViewedTenantId, row: viewed);
_previewMock.Setup(x => x.IsApprovedAsync(ViewedTenantId)).ReturnsAsync(true);
_mcpUserMock
.Setup(x => x.IsAllowedAsync(It.IsAny<string?>(), It.IsAny<string?>(), It.IsAny<string?>(),
It.IsAny<IReadOnlyList<string>?>(), It.IsAny<bool>()))
.ReturnsAsync(McpAccessCheckResult.Denied("not allowed"));
var seen = new DateTime(2026, 11, 1, 0, 0, 0, DateTimeKind.Utc);
_metricsRepoMock.Setup(x => x.GetUserWhatsNewSeenAsync(TenantId, Upn)).ReturnsAsync(new UserWhatsNewSeen(platformUtc: seen));
var (req, ctx) = BuildRequest(SignedIn(external: false), ViewingAs(Constants.TenantRoles.Viewer));
var response = await _sut.GetCurrentUser(req, ctx);
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
var body = await ReadBodyAsync(response);
Assert.Contains($"\"tenantId\":\"{ViewedTenantId}\"", body);
Assert.Contains("\"isGlobalAdmin\":false", body);
Assert.Contains("\"isGlobalReader\":false", body);
Assert.Contains("\"isDelegated\":false", body);
Assert.Contains("\"role\":\"Viewer\"", body);
Assert.Contains("\"isTenantAdmin\":false", body);
Assert.Contains("\"dpaAcceptancePending\":true", body);
Assert.Contains("\"whatsNewSeenPlatformUtc\":\"2026-11-01T00:00:00Z\"", body);
Assert.Contains(
$"\"viewAs\":{{\"tenantId\":\"{ViewedTenantId}\",\"tenantName\":\"Fabrikam\",\"role\":\"Viewer\",\"homeTenantId\":\"{TenantId}\"}}",
body);
// No sign-in side effect in either tenant, and no role lookup of the caller at all.
Assert.Empty(_store.Writes);
Assert.Empty(viewedStore.Writes);
_opsEventsMock.Verify(x => x.RecordTenantSignupAsync(It.IsAny<string>(), It.IsAny<string>()), Times.Never);
_autoApproveEnqueuerMock.Verify(x => x.EnqueueAsync(
It.IsAny<AutopilotMonitor.Functions.Services.Activation.TenantAutoApproveEnvelope>(),
It.IsAny<TimeSpan?>(), It.IsAny<CancellationToken>()), Times.Never);
_tenantAdminsMock.Verify(x => x.TryAddTenantAdminAsync(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>()), Times.Never);
_tenantAdminsMock.Verify(x => x.GetMembershipSnapshotAsync(It.IsAny<string>(), It.IsAny<string>()), Times.Never);
_metricsRepoMock.Verify(x => x.RecordUserLoginAsync(
It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string?>(), It.IsAny<string?>()), Times.Never);
_globalAdminMock.Verify(x => x.GetGlobalRoleAsync(It.IsAny<AdminIdentity?>()), Times.Never);
}
[Fact]
public async Task GetCurrentUser_ViewAs_AnInactiveTenant_ShowsItsActivationGate()
{
var viewed = TenantConfiguration.CreateDefault(ViewedTenantId);
viewed.DomainName = "fabrikam.example";
_tenantConfigMock.Setup(x => x.TryGetConfigurationAsync(ViewedTenantId)).ReturnsAsync((viewed, true));
_tenantConfigMock.Setup(x => x.TryGetConfigurationAsync(TenantId)).ReturnsAsync((DefaultConfig(), true));
_previewMock.Setup(x => x.IsApprovedAsync(ViewedTenantId)).ReturnsAsync(false);
_mcpUserMock
.Setup(x => x.IsAllowedAsync(It.IsAny<string?>(), It.IsAny<string?>(), It.IsAny<string?>(),
It.IsAny<IReadOnlyList<string>?>(), It.IsAny<bool>()))
.ReturnsAsync(McpAccessCheckResult.Denied("not allowed"));
_metricsRepoMock.Setup(x => x.GetUserWhatsNewSeenAsync(TenantId, Upn)).ReturnsAsync(new UserWhatsNewSeen());
var (req, ctx) = BuildRequest(SignedIn(external: false), ViewingAs(Constants.TenantRoles.Admin));
var response = await _sut.GetCurrentUser(req, ctx);
// What the tenant's own admin gets while the tenant waits for activation — the Global Admin bypass is gone.
Assert.Equal(HttpStatusCode.Forbidden, response.StatusCode);
Assert.Contains("PendingActivation", await ReadBodyAsync(response));
}
}
@@ -93,6 +93,39 @@ public class AuthFunctionTests
Assert.Equal(pending, (bool)ToDynamic(result.Body).dpaAcceptancePending);
}
[Fact]
public void HappyPath_MemberWithARoleGetsTheCompanyName()
{
var config = DefaultConfig();
config.CompanyName = " Contoso Ltd. ";
var result = AuthFunction.BuildAuthResult(
config, isGlobalAdmin: false, isGlobalReader: false, isPreviewApproved: true,
memberRole: ViewerRole(), mcpCheck: McpAllowed(),
hasTenantAdmins: true,
TenantId, Upn, DisplayName, ObjectId);
Assert.True(result.IsSuccess);
Assert.Equal("Contoso Ltd.", (string)ToDynamic(result.Body).companyName);
}
[Fact]
public void HappyPath_RolelessMemberGetsNoCompanyName()
{
// Without a role the caller sees only the Progress Portal; the config GET would refuse them.
var config = DefaultConfig();
config.CompanyName = "Contoso Ltd.";
var result = AuthFunction.BuildAuthResult(
config, isGlobalAdmin: false, isGlobalReader: false, isPreviewApproved: true,
memberRole: null, mcpCheck: McpAllowed(),
hasTenantAdmins: true,
TenantId, Upn, DisplayName, ObjectId);
Assert.True(result.IsSuccess);
Assert.Null((string?)ToDynamic(result.Body).companyName);
}
[Theory]
[InlineData("platform", "platform")]
[InlineData("Platform", "platform")]
@@ -1,4 +1,5 @@
using System.Net;
using System.Text.Json;
using AutopilotMonitor.Functions.Security;
using AutopilotMonitor.Shared.DataAccess;
using AutopilotMonitor.Functions.Services;
@@ -218,10 +219,12 @@ public class AutopilotDeviceValidatorTests
private const string Upn = "first.last@example.invalid";
private static JsonElement Device(string json) => JsonSerializer.Deserialize<JsonElement>(json);
[Fact]
public void ReadRegistration_MapsTheKeptFields_AndKeepsOnlyWhetherAUserIsAssigned()
{
var device = Newtonsoft.Json.Linq.JObject.Parse(
var device = Device(
"{\"id\":\"ap-1\",\"groupTag\":\" TEST \",\"purchaseOrderIdentifier\":\"PO-7\",\"displayName\":\"LAB-01\"," +
$"\"userPrincipalName\":\"{Upn}\",\"addressableUserName\":\"First Last\",\"productKey\":\"AAAAA-BBBBB\"}}");
@@ -241,7 +244,7 @@ public class AutopilotDeviceValidatorTests
[Fact]
public void ReadRegistration_TreatsBlankMissingAndNonTextValuesAsAbsent()
{
var device = Newtonsoft.Json.Linq.JObject.Parse(
var device = Device(
"{\"id\":\"ap-1\",\"groupTag\":\" \",\"purchaseOrderIdentifier\":null,\"displayName\":42,\"userPrincipalName\":\"\"}");
var registration = AutopilotDeviceValidator.ReadRegistration(device);
@@ -256,7 +259,7 @@ public class AutopilotDeviceValidatorTests
public void ReadRegistration_CutsOverlongText()
{
var longTag = new string('x', AutopilotDeviceValidator.MaxRegistrationFieldLength + 50);
var device = Newtonsoft.Json.Linq.JObject.Parse($"{{\"id\":\"ap-1\",\"groupTag\":\"{longTag}\"}}");
var device = Device($"{{\"id\":\"ap-1\",\"groupTag\":\"{longTag}\"}}");
Assert.Equal(AutopilotDeviceValidator.MaxRegistrationFieldLength, AutopilotDeviceValidator.ReadRegistration(device).GroupTag!.Length);
}
@@ -13,10 +13,10 @@
DataProtection/Cryptography.Xml 10.0.0 pulled in via Microsoft.Identity.Web),
which would otherwise surface NU1903/NU1904 advisories here. -->
<FrameworkReference Include="Microsoft.AspNetCore.App" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
<PackageReference Include="Moq" Version="4.20.72" />
<PackageReference Include="xunit" Version="2.9.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.11.0" />
<PackageReference Include="Moq" Version="4.21.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="4.0.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
@@ -202,6 +202,28 @@ public class ConfigBackupHookTests
b => b.UpsertAsync(It.IsAny<ConfigBackupEntry>(), It.IsAny<CancellationToken>()), Times.Never);
}
[Fact]
public async Task NoiseOnlyChange_SetupGuideMarkers_NoSnapshot()
{
// The setup guide's markers would otherwise push real settings out of the two backup slots.
var stored = StoredConfig();
var harness = new Harness(TableConfigRepository.ConvertToTenantTableEntity(stored));
var incoming = RoundtripClone(stored);
incoming.SetupGuideSettingsReviewedAt = DateTime.UtcNow;
incoming.SetupGuideHardwareReviewedAt = DateTime.UtcNow;
incoming.SetupGuideDismissedAt = DateTime.UtcNow;
incoming.SetupGuideDismissedBy = "admin@contoso.com";
incoming.LastUpdated = DateTime.UtcNow;
var saved = await harness.Sut.TryReplaceTenantConfigurationAsync(incoming, "\"etag\"", "setup-guide", null);
Assert.True(saved);
Assert.Single(harness.Upserts);
harness.Backup.Verify(
b => b.UpsertAsync(It.IsAny<ConfigBackupEntry>(), It.IsAny<CancellationToken>()), Times.Never);
}
[Fact]
public async Task NoiseOnlyChange_AddOnPermissionState_NoSnapshot()
{
@@ -0,0 +1,228 @@
using System.Net;
using AutopilotMonitor.Functions.Functions.Config;
using AutopilotMonitor.Functions.Security;
using AutopilotMonitor.Functions.Services;
using AutopilotMonitor.Shared.DataAccess;
using AutopilotMonitor.Shared.Models;
using Microsoft.Extensions.Caching.Memory;
using Microsoft.Extensions.Logging;
using Moq;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// The agent gate never refuses on a cached configuration another instance's write has outdated:
/// before a refusal the configuration decides, it reads the stored row and decides on that. An admin
/// allows a manufacturer or switches a validation on, and the next device is admitted at once, on
/// every instance. A request the cached copy admits must not cost a read — that is the hot path.
/// The request comes from <see cref="CertTenantBindingTests"/>: a valid certificate of the sample
/// tenant, manufacturer "Contoso", model "TestBook".
/// </summary>
public sealed class ConfigConfirmBeforeRefusalTests
{
private static readonly string TenantId = CertTenantBindingTests.SampleCertTenantId.ToString();
private sealed record Gate(SecurityValidator Validator, Mock<TenantConfigurationService> Config, Dictionary<object, object> Items);
/// <summary>A permissive tenant: no device validator needed, every hardware allowed.</summary>
private static TenantConfiguration Admitting(Action<TenantConfiguration>? change = null)
{
var config = new TenantConfiguration
{
TenantId = TenantId,
AllowInsecureAgentRequests = true,
ManufacturerWhitelist = "*",
ModelWhitelist = "*",
};
change?.Invoke(config);
return config;
}
/// <summary>
/// <paramref name="cached"/> is what this instance holds; <paramref name="stored"/> is what a read
/// before a refusal returns (null: nothing to read, as inside the confirm interval). Like the real
/// service, a confirming read makes the stored row the cached one.
/// </summary>
private static Gate Build(TenantConfiguration cached, TenantConfiguration? stored)
{
var configRepo = Mock.Of<IConfigRepository>();
var cache = new MemoryCache(new MemoryCacheOptions());
var current = cached;
var config = new Mock<TenantConfigurationService>(configRepo, Mock.Of<ILogger<TenantConfigurationService>>(), cache)
{ CallBase = false };
config.Setup(x => x.TryGetConfigurationAsync(It.IsAny<string>())).ReturnsAsync(() => (current, true));
config.Setup(x => x.ConfirmBeforeRefusalAsync(It.IsAny<string>())).ReturnsAsync(() =>
{
if (stored != null) current = stored;
return stored;
});
var adminConfig = new Mock<AdminConfigurationService>(configRepo, Mock.Of<ILogger<AdminConfigurationService>>(), cache)
{ CallBase = false };
adminConfig.Setup(x => x.GetConfigurationAsync()).ReturnsAsync(new AdminConfiguration());
var validator = new SecurityValidator(
configService: config.Object,
adminConfigService: adminConfig.Object,
rateLimitService: new RateLimitService(cache, Mock.Of<ILogger<RateLimitService>>()),
autopilotDeviceValidator: null!,
corporateIdentifierValidator: null!,
logger: Mock.Of<ILogger>(),
bootstrapSessionService: null,
deviceAssociationValidator: null);
return new Gate(validator, config, new Dictionary<object, object>());
}
private static Task<SecurityValidationResult> Validate(Gate gate)
=> gate.Validator.ValidateRequestAsync(
CertTenantBindingTests.BuildRequestWithCert(CertTenantBindingTests.SampleCertBase64(), gate.Items), TenantId);
private static string? Stamp(Gate gate)
=> gate.Items.TryGetValue(RequestRowMarkers.ConfigConfirmKey, out var value) ? value as string : null;
// ---------------------------------------------------------------- a refusal is confirmed first
public static TheoryData<string, TenantConfiguration, string> OutdatedCopies() => new()
{
{ "manufacturer just allowed", Admitting(c => c.ManufacturerWhitelist = "Dell*"), "Hardware not authorized" },
{ "model just allowed", Admitting(c => c.ModelWhitelist = "Latitude*"), "Hardware not authorized" },
{ "validation requirement just met", Admitting(c => c.AllowInsecureAgentRequests = false), "Device validation is required" },
{ "tenant just re-enabled", Admitting(c => { c.Disabled = true; c.DisabledReason = "paused"; }), "Tenant is suspended" },
};
[Theory]
[MemberData(nameof(OutdatedCopies))]
public async Task The_stored_row_admits_what_the_outdated_copy_would_refuse(string _, TenantConfiguration outdated, string refusal)
{
var gate = Build(cached: outdated, stored: Admitting());
var result = await Validate(gate);
Assert.True(result.IsValid, $"refused with '{result.ErrorMessage}' although the stored row admits (outdated copy would say '{refusal}')");
Assert.Equal(RequestRowMarkers.ConfigConfirm.Averted, Stamp(gate));
gate.Config.Verify(x => x.ConfirmBeforeRefusalAsync(TenantId), Times.Once);
}
[Theory]
[MemberData(nameof(OutdatedCopies))]
public async Task The_refusal_stands_when_the_stored_row_says_the_same(string _, TenantConfiguration refusing, string refusal)
{
var gate = Build(cached: refusing, stored: ConfigRepoMockExtensions.Clone(refusing));
var result = await Validate(gate);
Assert.False(result.IsValid);
Assert.Equal(HttpStatusCode.Forbidden, result.StatusCode);
Assert.Equal(refusal, result.ErrorMessage);
Assert.Equal(RequestRowMarkers.ConfigConfirm.Confirmed, Stamp(gate));
gate.Config.Verify(x => x.ConfirmBeforeRefusalAsync(TenantId), Times.Once);
}
[Theory]
[MemberData(nameof(OutdatedCopies))]
public async Task Without_a_read_the_cached_copy_decides(string _, TenantConfiguration refusing, string refusal)
{
// Inside the confirm interval, or storage failed: nothing newer to decide on.
var gate = Build(cached: refusing, stored: null);
var result = await Validate(gate);
Assert.False(result.IsValid);
Assert.Equal(refusal, result.ErrorMessage);
Assert.Null(Stamp(gate));
}
// ---------------------------------------------------------------- the hot path stays untouched
[Fact]
public async Task A_request_the_cached_copy_admits_reads_nothing()
{
var gate = Build(cached: Admitting(), stored: Admitting());
var result = await Validate(gate);
Assert.True(result.IsValid);
Assert.Null(Stamp(gate));
gate.Config.Verify(x => x.ConfirmBeforeRefusalAsync(It.IsAny<string>()), Times.Never);
gate.Config.Verify(x => x.TryGetConfigurationAsync(TenantId), Times.Once);
}
[Fact]
public async Task A_refusal_the_configuration_does_not_decide_reads_nothing()
{
// A certificate of another tenant: the configuration admits, the certificate does not.
var gate = Build(cached: Admitting(), stored: Admitting());
var result = await gate.Validator.ValidateRequestAsync(
CertTenantBindingTests.BuildRequestWithCert(CertTenantBindingTests.SampleCertBase64(), gate.Items),
"aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee");
Assert.False(result.IsValid);
Assert.Null(Stamp(gate));
gate.Config.Verify(x => x.ConfirmBeforeRefusalAsync(It.IsAny<string>()), Times.Never);
}
// ---------------------------------------------------------------- the device validation chain
[Fact]
public async Task A_validation_switched_on_since_runs_the_chain_once_more_and_no_further()
{
// The Cloud PC validation is on in both rows, but this gate has no Cloud PC validator wired:
// nothing admits the device, on either pass. What counts here is the control flow.
var cached = Admitting(c => { c.AllowInsecureAgentRequests = false; c.ValidateCloudPcDevice = true; });
var stored = Admitting(c => { c.AllowInsecureAgentRequests = false; c.ValidateCloudPcDevice = true; c.ValidateIntuneDeviceBinding = true; });
var gate = Build(cached, stored);
var result = await Validate(gate);
Assert.False(result.IsValid);
Assert.Equal("Device not registered", result.ErrorMessage);
Assert.Equal(RequestRowMarkers.ConfigConfirm.Rerun, Stamp(gate));
gate.Config.Verify(x => x.TryGetConfigurationAsync(TenantId), Times.Exactly(2));
gate.Config.Verify(x => x.ConfirmBeforeRefusalAsync(TenantId), Times.Once);
}
[Fact]
public async Task The_chain_does_not_run_again_when_the_stored_row_asks_nothing_new()
{
var cached = Admitting(c => { c.AllowInsecureAgentRequests = false; c.ValidateCloudPcDevice = true; });
var gate = Build(cached, stored: ConfigRepoMockExtensions.Clone(cached));
var result = await Validate(gate);
Assert.Equal("Device not registered", result.ErrorMessage);
Assert.Equal(RequestRowMarkers.ConfigConfirm.Confirmed, Stamp(gate));
gate.Config.Verify(x => x.TryGetConfigurationAsync(TenantId), Times.Once);
}
[Fact]
public void Only_a_validation_that_was_off_and_is_now_on_asks_for_another_pass()
{
var used = new TenantConfiguration { ValidateAutopilotDevice = true };
Assert.False(SecurityValidator.SwitchesOnUnaskedValidation(used, new TenantConfiguration { ValidateAutopilotDevice = true }));
Assert.False(SecurityValidator.SwitchesOnUnaskedValidation(used, new TenantConfiguration()));
Assert.True(SecurityValidator.SwitchesOnUnaskedValidation(used, new TenantConfiguration { ValidateAutopilotDevice = true, ValidateCorporateIdentifier = true }));
Assert.True(SecurityValidator.SwitchesOnUnaskedValidation(used, new TenantConfiguration { ValidateDeviceAssociation = true }));
Assert.True(SecurityValidator.SwitchesOnUnaskedValidation(used, new TenantConfiguration { ValidateCloudPcDevice = true }));
Assert.True(SecurityValidator.SwitchesOnUnaskedValidation(used, new TenantConfiguration { ValidateIntuneDeviceBinding = true }));
}
// ---------------------------------------------------------------- the patch marker
[Fact]
public void A_field_patch_counts_the_sent_fields_the_stored_row_already_held()
{
static PatchOutcome Applied(params string[] changed)
=> new(true, PatchFailure.None, null, null, changed, new Dictionary<string, string>(), null);
// Wire names are camelCase, applied names are the model's property names.
Assert.Equal(0, PatchTenantConfigurationFieldsFunction.UnchangedFieldCount(new[] { "logLevel" }, Applied("LogLevel")));
Assert.Equal(1, PatchTenantConfigurationFieldsFunction.UnchangedFieldCount(
new[] { "enableTimezoneAutoSet", "rebootOnComplete" }, Applied("RebootOnComplete")));
Assert.Equal(1, PatchTenantConfigurationFieldsFunction.UnchangedFieldCount(new[] { "diagnosticsUploadMode" }, Applied()));
Assert.Equal(0, PatchTenantConfigurationFieldsFunction.UnchangedFieldCount(
new[] { "logLevel" }, PatchOutcome.Fail(PatchFailure.ValidationFailed, "invalid")));
}
}
@@ -772,6 +772,35 @@ public class ConfigWireParityTests
// ---- UpdateTenantConfiguration -------------------------------------------------------
// ---- RecordSetupGuideStep ------------------------------------------------------------
[Fact]
public void SetupGuideStateResponse_matches_the_marker_shape()
{
DateTime? settingsReviewedAt = new DateTime(2026, 11, 9, 8, 0, 0, DateTimeKind.Utc);
DateTime? hardwareReviewedAt = settingsReviewedAt.Value.AddMinutes(3);
DateTime? dismissedAt = null;
string? dismissedBy = null;
AssertParity(
new
{
success = true,
settingsReviewedAt,
hardwareReviewedAt,
dismissedAt,
dismissedBy
},
new SetupGuideStateResponse
{
Success = true,
SettingsReviewedAt = settingsReviewedAt,
HardwareReviewedAt = hardwareReviewedAt,
DismissedAt = null,
DismissedBy = null
});
}
private static void AssertParity(object anonymousLiteral, IApiResponse typed)
=> ApiResponseWireParityTests.AssertWireIdentical(anonymousLiteral, typed);
}
@@ -0,0 +1,50 @@
using System;
using System.Collections.Generic;
using AutopilotMonitor.Functions.Services;
using AutopilotMonitor.Shared;
using AutopilotMonitor.Shared.Models;
using Xunit;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// The agent counts short-lived console processes and reports them as one console_script_activity
/// per window. A script that keeps spawning them is not enrollment progress: the count never heals
/// a Stalled session. A console the agent reports as such stays real activity.
/// </summary>
public class ConsoleScriptActivityClassificationTests
{
private static readonly DateTime At = new(2026, 11, 11, 14, 41, 35, DateTimeKind.Utc);
[Fact]
public void A_count_of_script_processes_alone_is_no_real_activity()
{
var classification = EventIngestProcessor.ClassifyEvents(new List<EnrollmentEvent>
{
Event(Constants.EventTypes.ConsoleScriptActivity),
});
Assert.False(classification.HasNonPeriodicRealEvent);
}
[Fact]
public void A_reported_console_is_real_activity()
{
var classification = EventIngestProcessor.ClassifyEvents(new List<EnrollmentEvent>
{
Event(Constants.EventTypes.ConsoleScriptActivity),
Event(Constants.EventTypes.OobeConsoleSpawned),
});
Assert.True(classification.HasNonPeriodicRealEvent);
}
private static EnrollmentEvent Event(string eventType) => new()
{
EventId = Guid.NewGuid().ToString(),
Timestamp = At,
EventType = eventType,
Source = "ConsoleBypassWatcher",
Data = new Dictionary<string, object> { ["count"] = 3 },
};
}
@@ -0,0 +1,198 @@
using System.Net;
using System.Net.Http;
using System.Net.Sockets;
using System.Text;
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Functions.Services.Notifications;
using AutopilotMonitor.Functions.Services.Push;
using AutopilotMonitor.Functions.Telemetry;
using Microsoft.ApplicationInsights.Channel;
using Microsoft.ApplicationInsights.DataContracts;
using Microsoft.ApplicationInsights.DependencyCollector;
using Microsoft.ApplicationInsights.Extensibility;
using Microsoft.Extensions.DependencyInjection;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// Credential URLs never reach a dependency row (K20, D-424): inside a request of a marked client the row
/// keeps scheme + host and the method, whatever host the URL names; outside it nothing changes; the mark
/// does not leak into the caller's flow; the real collector pipeline carries the mark to the processor;
/// and both credential clients (webhooks, push) carry the mark.
/// </summary>
public class CredentialUrlRedactionProcessorTests
{
private sealed class CapturingProcessor : ITelemetryProcessor
{
public List<ITelemetry> Received { get; } = new();
public void Process(ITelemetry item) => Received.Add(item);
}
private sealed class CapturingChannel : ITelemetryChannel
{
private readonly List<ITelemetry> _items = new();
public IReadOnlyList<ITelemetry> Items { get { lock (_items) return _items.ToList(); } }
public bool? DeveloperMode { get; set; }
public string? EndpointAddress { get; set; }
public void Send(ITelemetry item) { lock (_items) _items.Add(item); }
public void Flush() { }
public void Dispose() { }
}
/// <summary>Stands in for the collector: tracks a dependency row from inside the request's flow.</summary>
private sealed class TrackingInnerHandler(ITelemetryProcessor processor, DependencyTelemetry row) : HttpMessageHandler
{
protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
{
processor.Process(row);
return Task.FromResult(new HttpResponseMessage(HttpStatusCode.NoContent));
}
}
private static DependencyTelemetry Row(string url, string method = "POST")
=> new() { Type = "Http", Data = url, Name = $"{method} {new Uri(url).AbsolutePath}", Target = new Uri(url).Authority };
[Theory]
[InlineData("https://web.push.apple.com/QF3abc/device-token-123", "https://web.push.apple.com")]
[InlineData("https://fcm.googleapis.com/fcm/send/abc:APA91", "https://fcm.googleapis.com")]
[InlineData("https://updates.push.services.mozilla.com/wpush/v2/gAAAA", "https://updates.push.services.mozilla.com")]
[InlineData("https://wns2-db5p.notify.windows.com/w/?token=abc", "https://wns2-db5p.notify.windows.com")]
[InlineData("https://discord.com/api/webhooks/123456/discord-token", "https://discord.com")]
[InlineData("https://hooks.slack.com/services/T000/B000/slack-secret", "https://hooks.slack.com")]
[InlineData("https://default00000000.00.environment.api.powerplatform.com:443/powerautomate/automations/direct/workflows/abc/triggers/manual/paths/invoke?api-version=1&sp=%2Ftriggers&sv=1.0&sig=signature", "https://default00000000.00.environment.api.powerplatform.com")]
[InlineData("https://tickets.example.test/hooks/intake?apikey=generic-secret", "https://tickets.example.test")]
public void Redact_keeps_scheme_host_and_method_only(string url, string expected)
{
var dependency = Row(url);
CredentialUrlRedactionProcessor.Redact(dependency);
Assert.Equal(expected, dependency.Data);
Assert.Equal("POST " + expected, dependency.Name);
}
[Fact]
public void Redact_of_an_unparseable_url_keeps_only_the_target_host()
{
var dependency = new DependencyTelemetry { Data = "not a url /api/webhooks/1/token", Name = "POST /api/webhooks/1/token", Target = "discord.com" };
CredentialUrlRedactionProcessor.Redact(dependency);
Assert.Equal("discord.com", dependency.Data);
Assert.Equal("POST discord.com", dependency.Name);
}
[Fact]
public void Rows_outside_a_marked_request_are_untouched()
{
var next = new CapturingProcessor();
var processor = new CredentialUrlRedactionProcessor(next);
var dependency = Row("https://graph.microsoft.com/v1.0/devices?$filter=x", "GET");
processor.Process(dependency);
Assert.Same(dependency, Assert.Single(next.Received));
Assert.Equal("https://graph.microsoft.com/v1.0/devices?$filter=x", dependency.Data);
Assert.Equal("GET /v1.0/devices", dependency.Name);
}
[Fact]
public async Task The_mark_covers_the_request_and_ends_with_it()
{
var next = new CapturingProcessor();
var processor = new CredentialUrlRedactionProcessor(next);
var inside = Row("https://discord.com/api/webhooks/123456/discord-token");
using var client = new HttpClient(new CredentialUrlRedactionProcessor.MarkingHandler
{
InnerHandler = new TrackingInnerHandler(processor, inside),
});
await client.PostAsync("https://discord.com/api/webhooks/123456/discord-token", new StringContent("{}"));
var after = Row("https://graph.microsoft.com/v1.0/devices", "GET");
processor.Process(after);
Assert.Equal("https://discord.com", inside.Data);
Assert.Equal("https://graph.microsoft.com/v1.0/devices", after.Data);
}
[Fact]
public async Task The_real_collector_pipeline_carries_the_mark_to_the_processor()
{
var channel = new CapturingChannel();
using var configuration = new TelemetryConfiguration
{
TelemetryChannel = channel,
ConnectionString = "InstrumentationKey=00000000-0000-0000-0000-000000000000",
};
configuration.TelemetryProcessorChainBuilder.Use(next => new CredentialUrlRedactionProcessor(next)).Build();
using var collector = new DependencyTrackingTelemetryModule();
collector.Initialize(configuration);
var listener = new TcpListener(IPAddress.Loopback, 0);
listener.Start();
try
{
var port = ((IPEndPoint)listener.LocalEndpoint).Port;
var server = AnswerNoContentAsync(listener, connections: 2);
var secretPath = $"http://127.0.0.1:{port}/api/webhooks/123456/discord-token";
using (var marked = new HttpClient(new CredentialUrlRedactionProcessor.MarkingHandler { InnerHandler = new SocketsHttpHandler() }))
(await marked.PostAsync(secretPath, new StringContent("{}"))).Dispose();
using (var plain = new HttpClient(new SocketsHttpHandler()))
(await plain.PostAsync(secretPath + "?unmarked=1", new StringContent("{}"))).Dispose();
await server;
var rows = channel.Items.OfType<DependencyTelemetry>().Where(d => d.Target?.EndsWith(":" + port) == true).ToList();
Assert.Equal(2, rows.Count);
Assert.Contains(rows, d => d.Data == "http://127.0.0.1" && d.Name == "POST http://127.0.0.1");
Assert.Contains(rows, d => d.Data == secretPath + "?unmarked=1");
}
finally
{
listener.Stop();
}
}
[Theory]
[InlineData(nameof(WebhookNotificationService))]
[InlineData(PushHttpClientRegistration.ClientName)]
public void Both_credential_clients_carry_the_mark(string clientName)
{
var services = new ServiceCollection();
services.AddLogging();
services.AddSingleton<ResiliencePolicies>();
services.AddWebhookNotificationHttpClient();
services.AddPushSender();
using var provider = services.BuildServiceProvider();
var handlers = new List<HttpMessageHandler>();
for (HttpMessageHandler? handler = provider.GetRequiredService<IHttpMessageHandlerFactory>().CreateHandler(clientName);
handler != null;
handler = (handler as DelegatingHandler)?.InnerHandler)
{
handlers.Add(handler);
}
Assert.Single(handlers.OfType<CredentialUrlRedactionProcessor.MarkingHandler>());
}
/// <summary>Answers each of <paramref name="connections"/> requests with 204 and closes the connection.</summary>
private static async Task AnswerNoContentAsync(TcpListener listener, int connections)
{
for (var i = 0; i < connections; i++)
{
using var socket = await listener.AcceptTcpClientAsync();
var stream = socket.GetStream();
var buffer = new byte[8192];
var received = new StringBuilder();
while (!received.ToString().Contains("\r\n\r\n", StringComparison.Ordinal))
{
var read = await stream.ReadAsync(buffer);
if (read == 0) break;
received.Append(Encoding.ASCII.GetString(buffer, 0, read));
}
// The request body ("{}") follows the headers; the 204 does not wait for it.
await stream.WriteAsync(Encoding.ASCII.GetBytes("HTTP/1.1 204 No Content\r\nContent-Length: 0\r\nConnection: close\r\n\r\n"));
}
}
}
@@ -101,9 +101,8 @@ public class DeviceAssociationValidatorTests
Assert.Equal("preassociated", result.AssociationState);
Assert.Equal("00000000-0000-0000-0000-000000000000", result.DevicePreparationPolicyId);
Assert.Equal("admin@contoso.com", result.PreAssociatedByUserPrincipalName);
// Newtonsoft.Json yields "" for JSON null when calling .ToString() on the JToken;
// downstream telemetry uses IsNullOrEmpty so both null and "" surface as "absent".
Assert.True(string.IsNullOrEmpty(result.AssignedToUserPrincipalName));
// JSON null is absence (D-420); the former Newtonsoft reader turned it into "".
Assert.Null(result.AssignedToUserPrincipalName);
Assert.NotNull(result.PreAssociationDateTime);
Assert.Null(result.AssociationDateTime); // Graph "0001-01-01" → null (unset DateTimeOffset sentinel)
}
@@ -640,4 +640,116 @@ public class DistressValidationTests
{
Assert.Equal(TimeSpan.FromMinutes(5), ReportDistressFunction.MaxTimestampFuture);
}
// =========================================================================
// ResolveErrorType — the agent reports every backend 403 as DeviceNotRegistered; the
// hardware whitelist runs before the registration lookup, so a 403 for hardware outside
// the whitelist is stored as HardwareNotAllowed.
// =========================================================================
private const string ResolveTenant = "11111111-2222-3333-4444-555555555555";
private static TenantConfiguration ValidatingTenant(Action<TenantConfiguration>? change = null)
{
var config = TenantConfiguration.CreateDefault(ResolveTenant);
config.ValidateAutopilotDevice = true; // CreateDefault starts with every validation off
change?.Invoke(config);
return config;
}
private static DistressErrorType Resolve(
TenantConfiguration config, string? manufacturer = "VMware, Inc.", string? model = "VMware20,1",
DistressErrorType reported = DistressErrorType.DeviceNotRegistered, int? http = 403,
DistressCertSourceState? certState = null)
=> ReportDistressFunction.ResolveErrorType(reported, http, manufacturer, model, certState, config);
[Fact]
public void ResolveErrorType_ManufacturerOutsideTheWhitelist_IsHardwareNotAllowed()
{
Assert.Equal(DistressErrorType.HardwareNotAllowed, Resolve(ValidatingTenant()));
}
[Fact]
public void ResolveErrorType_ModelOutsideTheWhitelist_IsHardwareNotAllowed()
{
var config = ValidatingTenant(c => c.ModelWhitelist = "Latitude*");
Assert.Equal(DistressErrorType.HardwareNotAllowed, Resolve(config, "Dell Inc.", "OptiPlex 7090"));
}
[Theory]
[InlineData("Dell Inc.", "Latitude 5440")]
[InlineData("LENOVO", "21HD")] // wildcards match case-insensitively
[InlineData("HP", "EliteBook 840 G10")]
[InlineData("Microsoft Corporation", "Surface Laptop 5")]
public void ResolveErrorType_WhitelistedHardware_StaysDeviceNotRegistered(string manufacturer, string model)
{
Assert.Equal(DistressErrorType.DeviceNotRegistered, Resolve(ValidatingTenant(), manufacturer, model));
}
[Fact]
public void ResolveErrorType_ManufacturerAddedToTheWhitelist_StaysDeviceNotRegistered()
{
var config = ValidatingTenant(c => c.ManufacturerWhitelist += ",VMware*");
Assert.Equal(DistressErrorType.DeviceNotRegistered, Resolve(config));
}
[Theory]
[InlineData(null, "VMware20,1")]
[InlineData("VMware, Inc.", null)]
[InlineData("", "")]
public void ResolveErrorType_WithoutManufacturerOrModel_StaysAsReported(string? manufacturer, string? model)
{
Assert.Equal(DistressErrorType.DeviceNotRegistered, Resolve(ValidatingTenant(), manufacturer, model));
}
[Fact]
public void ResolveErrorType_SuspendedTenant_StaysAsReported()
{
// The validator refuses a suspended tenant before it looks at the hardware.
var config = ValidatingTenant(c => c.Disabled = true);
Assert.Equal(DistressErrorType.DeviceNotRegistered, Resolve(config));
}
[Fact]
public void ResolveErrorType_TenantWithoutValidation_StaysAsReported()
{
var config = ValidatingTenant(c => c.ValidateAutopilotDevice = false);
Assert.Equal(DistressErrorType.DeviceNotRegistered, Resolve(config));
}
[Fact]
public void ResolveErrorType_TestTenantWithoutValidationButInsecureRequests_IsHardwareNotAllowed()
{
var config = ValidatingTenant(c =>
{
c.ValidateAutopilotDevice = false;
c.AllowInsecureAgentRequests = true;
});
Assert.Equal(DistressErrorType.HardwareNotAllowed, Resolve(config));
}
[Fact]
public void ResolveErrorType_NoCertificateInStore_StaysAsReported()
{
// Without a certificate the agent authenticates with a bootstrap token, which skips the
// hardware check.
Assert.Equal(DistressErrorType.DeviceNotRegistered,
Resolve(ValidatingTenant(), certState: DistressCertSourceState.NoCertInStore));
}
[Theory]
[InlineData(DistressErrorType.AuthCertificateRejected, 401)]
[InlineData(DistressErrorType.TpmPssUnsupported, 403)]
[InlineData(DistressErrorType.ClientCertificateNotReceived, 403)]
[InlineData(DistressErrorType.DeviceNotRegistered, 401)]
[InlineData(DistressErrorType.DeviceNotRegistered, null)]
public void ResolveErrorType_OtherTypesAndStatusCodes_StayAsReported(DistressErrorType reported, int? http)
{
Assert.Equal(reported, Resolve(ValidatingTenant(), reported: reported, http: http));
}
}
@@ -30,8 +30,8 @@ public class GetHardwareRejectedFunctionTests
var reports = new List<DistressReportEntry>
{
MakeEntry("HardwareNotAllowed", "Dell", "Latitude", "SN1", T0),
MakeEntry("CertificateExpired", "Dell", "Latitude", "SN2", T0.AddMinutes(1)),
MakeEntry("Timeout", "HP", "EliteBook", "SN3", T0.AddMinutes(2)),
MakeEntry("DeviceNotRegistered", "Dell", "Latitude", "SN2", T0.AddMinutes(1)),
MakeEntry("TpmPssUnsupported", "HP", "EliteBook", "SN3", T0.AddMinutes(2)),
};
var (aggregated, totalRawReports) = GetHardwareRejectedFunction.BuildAggregatedResult(reports);
@@ -0,0 +1,55 @@
using System.Net;
using System.Text.Json;
using AutopilotMonitor.Functions.Functions.Graph;
using AutopilotMonitor.Functions.Security;
using AutopilotMonitor.Functions.Services.GraphResolution;
using AutopilotMonitor.Shared.Models.Graph;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// POST tenants/{tenantId}/scripts/display-names: a lookup that ran into a time limit says so in
/// its answer, so the portal asks once more, and the request row tells a cut first lookup, a
/// follow-up and a follow-up that was cut again apart. A first lookup within its limits is the
/// normal case and carries neither the flag nor a marker.
/// </summary>
public class GetScriptDisplayNamesFunctionTests
{
private const string TenantId = "00000000-0000-4000-8000-000000000002";
private const string Ref = "Platform:1f9d3a52-4c1e-4b7a-9a01-52f3aaaa1001";
[Theory]
[InlineData(false, false, null)]
[InlineData(true, false, "timedOut")]
[InlineData(false, true, "retry")]
[InlineData(true, true, "retryTimedOut")]
public async Task A_cut_lookup_is_flagged_in_the_answer_and_marked_on_the_request_row(
bool timedOut, bool isFollowUp, string? expectedMarker)
{
var resolver = new Mock<IScriptDisplayNameResolver>();
resolver
.Setup(r => r.ResolveAsync(TenantId, It.IsAny<IReadOnlyCollection<ScriptRef>>(), It.IsAny<CancellationToken>()))
.ReturnsAsync((string _, IReadOnlyCollection<ScriptRef> refs, CancellationToken _) =>
new ScriptDisplayNameLookup(refs.ToDictionary(r => r, _ => (string?)null), timedOut));
var function = new GetScriptDisplayNamesFunction(NullLogger<GetScriptDisplayNamesFunction>.Instance, resolver.Object);
var body = "{\"refs\":[\"" + Ref + "\"]" + (isFollowUp ? ",\"retry\":true" : "") + "}";
var (req, context) = EndpointHarness.Request(TenantId, jsonBody: body);
var response = await function.Run(req, TenantId);
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
response.Body.Position = 0;
using var doc = JsonDocument.Parse(response.Body);
Assert.True(doc.RootElement.GetProperty("refs").TryGetProperty(Ref, out _));
// The key is left out, not false, when no time limit fired.
Assert.Equal(timedOut, doc.RootElement.TryGetProperty("timedOut", out var flag));
if (timedOut) Assert.True(flag.GetBoolean());
if (expectedMarker == null)
Assert.False(context.Items.ContainsKey(RequestRowMarkers.ScriptNameLookupKey));
else
Assert.Equal(expectedMarker, context.Items[RequestRowMarkers.ScriptNameLookupKey]);
}
}
@@ -64,6 +64,11 @@ public class GetTenantFeatureFlagsPayloadTests
"graphAccessRejected",
"intuneDeviceBindingPermissionMissing",
"isTrial",
// Non-sensitive by review: booleans only; who hid the guide and when stays in the
// admin-gated config. hasEnrollmentSessions is absent here: unknown → omitted.
"setupGuideDismissed",
"setupGuideHardwareDone",
"setupGuideSettingsDone",
"showScriptOutput",
"trialAvailable",
// trialExpiresUtc is absent here: the default tenant is not on a trial and the
@@ -520,4 +525,53 @@ public class GetTenantFeatureFlagsPayloadTests
Assert.DoesNotContain("Secret Holdings", json);
}
// ── setup guide ──
[Fact]
public void Payload_SetupGuide_NewTenantHasEveryStepOpen()
{
var payload = GetTenantFeatureFlagsFunction.BuildPayload(TenantConfiguration.CreateDefault("t"), Now, hasEnrollmentSessions: false);
Assert.False(payload.SetupGuideSettingsDone);
Assert.False(payload.SetupGuideHardwareDone);
Assert.False(payload.SetupGuideDismissed);
Assert.False(payload.HasEnrollmentSessions);
}
[Fact]
public void Payload_SetupGuide_ReflectsMarkersAndDismissal()
{
var config = TenantConfiguration.CreateDefault("t");
config.SetupGuideSettingsReviewedAt = Now;
config.SetupGuideHardwareReviewedAt = Now;
config.SetupGuideDismissedAt = Now;
config.SetupGuideDismissedBy = "admin@contoso.com";
var payload = GetTenantFeatureFlagsFunction.BuildPayload(config, Now);
Assert.True(payload.SetupGuideSettingsDone);
Assert.True(payload.SetupGuideHardwareDone);
Assert.True(payload.SetupGuideDismissed);
}
[Fact]
public void Payload_SetupGuide_UnknownEnrollmentHistoryIsOmitted()
{
var element = Serialize(TenantConfiguration.CreateDefault("t"));
Assert.False(element.TryGetProperty("hasEnrollmentSessions", out _));
}
[Fact]
public void Payload_SetupGuide_NeverLeaksWhoDismissedIt()
{
var config = TenantConfiguration.CreateDefault("t");
config.SetupGuideDismissedAt = Now;
config.SetupGuideDismissedBy = "hidden.admin@contoso.com";
var json = TestWire.Serialize(GetTenantFeatureFlagsFunction.BuildPayload(config, Now));
Assert.DoesNotContain("hidden.admin", json);
}
}
@@ -25,10 +25,21 @@ internal sealed class FakeGraphFeatureDetector : IGraphFeatureDetector
ctx?.GrantedRoles ?? (IReadOnlySet<string>)new HashSet<string>());
}
public Task<GraphTenantTokenContext?> TryGetTokenContextAsync(string tenantId, CancellationToken ct = default)
/// <summary>Tenants whose token never arrives: the call waits until the caller's budget cancels it.</summary>
public HashSet<string> HangingTenants { get; } = new();
/// <summary>When set, <see cref="TryGetTokenContextAsync"/> throws it.</summary>
public Exception? TokenContextThrows { get; set; }
public async Task<GraphTenantTokenContext?> TryGetTokenContextAsync(string tenantId, CancellationToken ct = default)
{
if (TokenContextThrows != null) throw TokenContextThrows;
if (HangingTenants.Contains(tenantId))
{
await Task.Delay(Timeout.InfiniteTimeSpan, ct).ConfigureAwait(false);
}
ContextByTenant.TryGetValue(tenantId, out var ctx);
return Task.FromResult(ctx);
return ctx;
}
/// <summary>When set for a tenant, <see cref="GetSnapshotAsync"/> reports it as transient.</summary>
@@ -1,12 +1,15 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Threading;
using System.Threading.Tasks;
using AutopilotMonitor.Functions.Services.GraphResolution;
using AutopilotMonitor.Shared.Models.Graph;
using Microsoft.ApplicationInsights;
using Microsoft.ApplicationInsights.Extensibility;
using Microsoft.Extensions.Logging.Abstractions;
using Microsoft.Extensions.Logging;
using Moq;
using Xunit;
namespace AutopilotMonitor.Functions.Tests.GraphResolution;
@@ -28,9 +31,43 @@ public class ScriptDisplayNameResolverTests
var result = await fix.Sut.ResolveAsync(TenantId, refs);
Assert.Single(result);
Assert.Null(result[refs[0]]);
Assert.Single(result.Names);
Assert.Null(result.Names[refs[0]]);
Assert.Empty(fix.Http.Requests); // Graph never called when permission gate fails
Assert.Empty(fix.IncompleteLines); // "no token or no role" is an answer, not a cut
Assert.False(result.TimedOut);
}
[Fact]
public async Task Token_that_outlasts_its_budget_is_reported_as_an_incomplete_lookup()
{
var fix = new Fixture(tokenAcquireBudget: TimeSpan.FromMilliseconds(50));
fix.Detector.HangingTenants.Add(TenantId);
var r = new ScriptRef(ScriptKind.Platform, "abc");
var result = await fix.Sut.ResolveAsync(TenantId, new[] { r });
Assert.Null(result.Names[r]);
Assert.Empty(fix.Http.Requests);
var line = Assert.Single(fix.IncompleteLines);
Assert.Contains($"tenant={TenantId} ", line);
Assert.Contains("reasons=TokenTimeout ", line);
Assert.Contains("requested=1 ", line);
Assert.True(result.TimedOut);
}
[Fact]
public async Task Failing_token_context_is_reported_as_an_incomplete_lookup()
{
var fix = new Fixture();
fix.Detector.TokenContextThrows = new InvalidOperationException("simulated");
var r = new ScriptRef(ScriptKind.Platform, "abc");
var result = await fix.Sut.ResolveAsync(TenantId, new[] { r });
Assert.Null(result.Names[r]);
Assert.Contains("reasons=TokenError ", Assert.Single(fix.IncompleteLines));
Assert.False(result.TimedOut); // a failure is not a time limit: asking again is not suggested
}
[Fact]
@@ -58,7 +95,7 @@ public class ScriptDisplayNameResolverTests
var result = await fix.Sut.ResolveAsync(TenantId, new[] { r });
Assert.Equal("MyScript.ps1", result[r]);
Assert.Equal("MyScript.ps1", result.Names[r]);
Assert.Empty(fix.Http.Requests);
}
@@ -77,11 +114,78 @@ public class ScriptDisplayNameResolverTests
var result = await fix.Sut.ResolveAsync(TenantId, new[] { r });
Assert.Equal("Bootstrap", result[r]);
Assert.Equal("Bootstrap", result.Names[r]);
Assert.Single(fix.Http.Requests);
// Both list entries cached for future calls.
Assert.Equal(2, fix.Repo.Entries.Count);
Assert.True(fix.Repo.Meta.ContainsKey((TenantId, ScriptKind.Platform)));
Assert.Empty(fix.IncompleteLines);
}
[Fact]
public async Task Script_missing_from_the_list_is_still_resolved_by_id()
{
// The list leaves out some scripts that a single GET returns. Treating "not in the list"
// as "not found" would drop their names.
var fix = new Fixture();
fix.GivenPermission();
fix.Http.When("deviceHealthScripts?", HttpStatusCode.OK,
"{\"value\":[{\"id\":\"listed\",\"displayName\":\"Listed\"}]}");
fix.Http.When("deviceHealthScripts/unlisted", HttpStatusCode.OK,
"{\"id\":\"unlisted\",\"displayName\":\"Unlisted\"}");
var listed = new ScriptRef(ScriptKind.Remediation, "listed");
var unlisted = new ScriptRef(ScriptKind.Remediation, "unlisted");
var result = await fix.Sut.ResolveAsync(TenantId, new[] { listed, unlisted });
Assert.Equal("Listed", result.Names[listed]);
Assert.Equal("Unlisted", result.Names[unlisted]);
Assert.Equal(2, fix.Http.Requests.Count);
Assert.False(fix.Repo.Entries[(TenantId, ScriptKind.Remediation, "unlisted")].IsNotFound);
Assert.Empty(fix.IncompleteLines);
Assert.False(result.TimedOut);
}
[Fact]
public async Task Timed_out_list_pull_is_reported_and_skips_the_single_lookups()
{
var fix = new Fixture();
fix.GivenPermission();
fix.Http.WhenTimedOut("deviceManagementScripts?");
fix.Http.When("deviceManagementScripts/abc", HttpStatusCode.OK,
"{\"id\":\"abc\",\"displayName\":\"SHOULD-NOT-BE-RETURNED\"}");
var r = new ScriptRef(ScriptKind.Platform, "abc");
var result = await fix.Sut.ResolveAsync(TenantId, new[] { r });
Assert.Null(result.Names[r]);
Assert.Single(fix.Http.Requests);
Assert.False(fix.Repo.Meta.ContainsKey((TenantId, ScriptKind.Platform)));
Assert.Contains("reasons=ListTimeout:Platform ", Assert.Single(fix.IncompleteLines));
Assert.True(result.TimedOut);
}
[Fact]
public async Task Budget_ending_between_list_pages_stores_nothing_and_leaves_the_kind_unfetched()
{
// A list cut after its first page is incomplete. Stored together with the meta row it
// would count as the tenant's whole list for a week.
var fix = new Fixture();
fix.GivenPermission();
using var caller = new CancellationTokenSource();
fix.Http.OnRequest = _ => caller.Cancel();
fix.Http.When("deviceManagementScripts?", HttpStatusCode.OK,
"{\"value\":[{\"id\":\"id-1\",\"displayName\":\"Bootstrap\"}]," +
"\"@odata.nextLink\":\"https://graph.microsoft.com/beta/deviceManagement/deviceManagementScripts?$skiptoken=2\"}");
var r = new ScriptRef(ScriptKind.Platform, "id-1");
var result = await fix.Sut.ResolveAsync(TenantId, new[] { r }, caller.Token);
Assert.Equal("Bootstrap", result.Names[r]); // page one was read before the cut
Assert.Single(fix.Http.Requests);
Assert.Empty(fix.Repo.Entries);
Assert.False(fix.Repo.Meta.ContainsKey((TenantId, ScriptKind.Platform)));
Assert.True(result.TimedOut);
}
[Fact]
@@ -102,7 +206,7 @@ public class ScriptDisplayNameResolverTests
var result = await fix.Sut.ResolveAsync(TenantId, new[] { r });
Assert.Equal("Net-New", result[r]);
Assert.Equal("Net-New", result.Names[r]);
Assert.Single(fix.Http.Requests);
Assert.Contains("deviceHealthScripts/net-new-id", fix.Http.Requests[0]);
// Per-ID fetch also writes to cache.
@@ -125,9 +229,70 @@ public class ScriptDisplayNameResolverTests
var result = await fix.Sut.ResolveAsync(TenantId, new[] { r });
Assert.Null(result[r]);
Assert.Null(result.Names[r]);
Assert.True(fix.Repo.Entries.ContainsKey((TenantId, ScriptKind.Platform, "deleted-id")));
Assert.True(fix.Repo.Entries[(TenantId, ScriptKind.Platform, "deleted-id")].IsNotFound);
Assert.Empty(fix.IncompleteLines); // a 404 is an answer
Assert.False(result.TimedOut);
}
[Fact]
public async Task Timed_out_single_lookup_is_reported_and_ends_the_loop()
{
var fix = new Fixture();
fix.GivenPermission();
fix.Repo.Meta[(TenantId, ScriptKind.Remediation)] = new ScriptNameCacheMeta
{
TenantId = TenantId,
Kind = ScriptKind.Remediation,
LastFullRefreshAt = fix.FixedNow - TimeSpan.FromDays(1),
};
fix.Http.WhenTimedOut("deviceHealthScripts/first");
fix.Http.When("deviceHealthScripts/second", HttpStatusCode.OK,
"{\"id\":\"second\",\"displayName\":\"SHOULD-NOT-BE-RETURNED\"}");
var refs = new[]
{
new ScriptRef(ScriptKind.Remediation, "first"),
new ScriptRef(ScriptKind.Remediation, "second"),
};
var result = await fix.Sut.ResolveAsync(TenantId, refs);
Assert.All(refs, r => Assert.Null(result.Names[r]));
Assert.Single(fix.Http.Requests);
Assert.Empty(fix.Repo.Entries); // a cut is not an answer: nothing is cached as not found
Assert.Contains("reasons=LookupTimeout ", Assert.Single(fix.IncompleteLines));
Assert.True(result.TimedOut);
}
[Theory]
[InlineData("{\"id\":\"nameless\",\"displayName\":null}")]
[InlineData("{\"id\":\"nameless\",\"displayName\":42}")]
[InlineData("{\"id\":\"nameless\"}")]
public async Task PerId_script_without_a_name_is_cached_and_not_fetched_again(string body)
{
// JSON null and a non-text name read as absent (D-420); the answer is still final, so the second view
// is a cache hit instead of another Graph call.
var fix = new Fixture();
fix.GivenPermission();
fix.Repo.Meta[(TenantId, ScriptKind.Platform)] = new ScriptNameCacheMeta
{
TenantId = TenantId,
Kind = ScriptKind.Platform,
LastFullRefreshAt = fix.FixedNow - TimeSpan.FromDays(1),
};
var r = new ScriptRef(ScriptKind.Platform, "nameless");
fix.Http.When("deviceManagementScripts/nameless", HttpStatusCode.OK, body);
var first = await fix.Sut.ResolveAsync(TenantId, new[] { r });
var second = await fix.Sut.ResolveAsync(TenantId, new[] { r });
Assert.Null(first.Names[r]);
Assert.Null(second.Names[r]);
Assert.Single(fix.Http.Requests);
var entry = fix.Repo.Entries[(TenantId, ScriptKind.Platform, "nameless")];
Assert.False(entry.IsNotFound);
Assert.Null(entry.DisplayName);
}
[Fact]
@@ -138,7 +303,7 @@ public class ScriptDisplayNameResolverTests
var result = await fix.Sut.ResolveAsync(TenantId, Array.Empty<ScriptRef>());
Assert.Empty(result);
Assert.Empty(result.Names);
Assert.Empty(fix.Http.Requests);
}
@@ -152,7 +317,7 @@ public class ScriptDisplayNameResolverTests
var result = await fix.Sut.ResolveAsync(TenantId, new[] { r });
Assert.Null(result[r]);
Assert.Null(result.Names[r]);
}
[Fact]
@@ -170,9 +335,11 @@ public class ScriptDisplayNameResolverTests
var result = await fix.Sut.ResolveAsync(TenantId, new[] { r });
Assert.Null(result[r]); // per-ID never ran
Assert.Null(result.Names[r]); // per-ID never ran
Assert.Single(fix.Http.Requests); // only the failed full-pull
Assert.Contains("deviceManagementScripts?", fix.Http.Requests[0]);
Assert.Contains("reasons=ListError:Platform ", Assert.Single(fix.IncompleteLines));
Assert.False(result.TimedOut); // Graph refused: an immediate second lookup would add to the throttle
}
[Fact]
@@ -204,9 +371,11 @@ public class ScriptDisplayNameResolverTests
var result = await fix.Sut.ResolveAsync(TenantId, refs);
Assert.All(refs, r => Assert.Null(result[r]));
Assert.All(refs, r => Assert.Null(result.Names[r]));
Assert.Single(fix.Http.Requests); // second call never issued
Assert.Contains("deviceHealthScripts/first", fix.Http.Requests[0]);
Assert.Contains("reasons=LookupError ", Assert.Single(fix.IncompleteLines));
Assert.False(result.TimedOut);
}
[Fact]
@@ -227,7 +396,7 @@ public class ScriptDisplayNameResolverTests
var result = await fix.Sut.ResolveAsync(TenantId, new[] { r });
Assert.Null(result[r]);
Assert.Null(result.Names[r]);
Assert.Empty(fix.Http.Requests);
}
@@ -239,19 +408,28 @@ public class ScriptDisplayNameResolverTests
public FakeScriptNameCacheRepository Repo { get; } = new();
public StubHttpMessageHandler Http { get; } = new();
public StubHttpClientFactory HttpFactory { get; }
public Mock<ILogger<ScriptDisplayNameResolver>> Logger { get; } = new();
public ScriptDisplayNameResolver Sut { get; }
public DateTimeOffset FixedNow { get; } = new(2026, 5, 18, 12, 0, 0, TimeSpan.Zero);
public Fixture()
public Fixture(TimeSpan? tokenAcquireBudget = null)
{
HttpFactory = new StubHttpClientFactory(Http);
Sut = new ScriptDisplayNameResolver(
Detector, Repo, HttpFactory,
NullLogger<ScriptDisplayNameResolver>.Instance,
Logger.Object,
new TelemetryClient(new TelemetryConfiguration()),
new FakeTimeProvider(FixedNow));
new FakeTimeProvider(FixedNow),
tokenAcquireBudget);
}
/// <summary>The summary lines written for lookups that ended without every answer.</summary>
public List<string> IncompleteLines => Logger.Invocations
.Where(i => i.Method.Name == nameof(ILogger.Log) && i.Arguments[0] is LogLevel.Warning)
.Select(i => i.Arguments[2]?.ToString() ?? string.Empty)
.Where(m => m.StartsWith("Script-name lookup incomplete:", StringComparison.Ordinal))
.ToList();
public void GivenPermission()
{
Detector.ContextByTenant[TenantId] = new GraphTenantTokenContext
@@ -12,8 +12,7 @@ namespace AutopilotMonitor.Functions.Tests.GraphResolution;
/// <list type="bullet">
/// <item>Positive rows older than 7 days are removed.</item>
/// <item>Positive rows younger than 7 days are kept.</item>
/// <item>NotFound rows older than 1 hour are removed.</item>
/// <item>NotFound rows younger than 1 hour are kept.</item>
/// <item>NotFound rows follow the same 7 days: older ones are removed, younger ones are kept.</item>
/// <item>A failed delete on one row doesn't poison the run — others still get processed.</item>
/// </list>
/// </summary>
@@ -55,18 +54,20 @@ public class ScriptNameCacheCleanupFunctionTests
}
[Fact]
public async Task Deletes_notfound_rows_older_than_1_hour()
public async Task Deletes_notfound_rows_only_after_the_same_7_days()
{
// A not-found row that goes after hours instead of days sends one Graph lookup per
// unknown ID on the first view after every cleanup run.
var fix = new Fixture();
var deletedId = "deleted-1h-ago";
var recentId = "recent-30min";
var deletedId = "not-found-8-days-ago";
var recentId = "not-found-2-hours-ago";
fix.Repo.Entries[(TenantId, ScriptKind.Remediation, deletedId)] = new ScriptDisplayNameEntry
{
TenantId = TenantId,
Kind = ScriptKind.Remediation,
ScriptId = deletedId,
DisplayName = null,
FetchedAt = fix.FixedNow - TimeSpan.FromHours(2),
FetchedAt = fix.FixedNow - TimeSpan.FromDays(8),
IsNotFound = true,
};
fix.Repo.Entries[(TenantId, ScriptKind.Remediation, recentId)] = new ScriptDisplayNameEntry
@@ -75,7 +76,7 @@ public class ScriptNameCacheCleanupFunctionTests
Kind = ScriptKind.Remediation,
ScriptId = recentId,
DisplayName = null,
FetchedAt = fix.FixedNow - TimeSpan.FromMinutes(30),
FetchedAt = fix.FixedNow - TimeSpan.FromHours(2),
IsNotFound = true,
};
@@ -16,18 +16,34 @@ namespace AutopilotMonitor.Functions.Tests.GraphResolution;
internal sealed class StubHttpMessageHandler : HttpMessageHandler
{
private readonly List<(string UrlSubstring, HttpStatusCode Status, string Body)> _scripted = new();
private readonly List<string> _timedOut = new();
public List<string> Requests { get; } = new();
/// <summary>Runs when a request arrives, before it is answered (e.g. to cancel the caller mid-flight).</summary>
public Action<string>? OnRequest { get; set; }
public StubHttpMessageHandler When(string urlSubstring, HttpStatusCode status, string body)
{
_scripted.Add((urlSubstring, status, body));
return this;
}
/// <summary>Scripts a request that ends the way a per-request timeout does, without waiting.</summary>
public StubHttpMessageHandler WhenTimedOut(string urlSubstring)
{
_timedOut.Add(urlSubstring);
return this;
}
protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
{
var url = request.RequestUri!.ToString();
Requests.Add(url);
OnRequest?.Invoke(url);
if (_timedOut.Any(s => url.Contains(s, StringComparison.OrdinalIgnoreCase)))
{
throw new TaskCanceledException($"StubHttpMessageHandler: scripted timeout for {url}");
}
var match = _scripted.FirstOrDefault(s => url.Contains(s.UrlSubstring, StringComparison.OrdinalIgnoreCase));
if (match.Equals(default((string, HttpStatusCode, string))))
{
@@ -0,0 +1,658 @@
using System;
using System.Globalization;
using AutopilotMonitor.Functions.Security;
using AutopilotMonitor.Functions.Services.GraphResolution;
using Xunit;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// The contract of the Graph and Entra token-endpoint response parsers (D-420): what every realistic body,
/// and every malformed one, yields. Written against the Newtonsoft parsers before their move to
/// System.Text.Json and kept as their specification. Tests whose name ends in _D1 to _D7 pin a
/// deliberate difference of that move (listed in D-420).
/// </summary>
public class GraphResponseParsingTests
{
private const string Serial = "PF3XKQ7";
private const string IntuneId = "6f1c4d2a-0b3e-4c5d-8e9f-1a2b3c4d5e6f";
// ── GraphTokenService.ReadTokenResponse ─────────────────────────────────────
[Theory]
[InlineData("""{"access_token":"t","expires_in":3599}""", 3599L)]
[InlineData("""{"access_token":"t","expires_in":"3599"}""", 3599L)]
[InlineData("""{"access_token":"t","expires_in":" 3599 "}""", 3599L)]
[InlineData("""{"access_token":"t","expires_in":"+3599"}""", 3599L)]
[InlineData("""{"access_token":"t",/*c*/"expires_in":3599,}""", 3599L)]
[InlineData("""{"access_token":"t"}""", null)]
[InlineData("""{"access_token":"t","expires_in":null}""", null)]
public void Token_response_reads_the_token_and_its_lifetime(string body, long? expiresIn)
{
var (token, lifetime) = GraphTokenService.ReadTokenResponse(body);
Assert.Equal("t", token);
Assert.Equal(expiresIn, lifetime);
}
[Theory]
[InlineData("")]
[InlineData(" ")]
[InlineData("null")]
[InlineData("{}")]
[InlineData("""{"access_token":""}""")]
[InlineData("""{"access_token":null,"expires_in":"abc"}""")]
public void Token_response_without_a_token_yields_none_and_ignores_the_lifetime(string body)
{
var (token, lifetime) = GraphTokenService.ReadTokenResponse(body);
Assert.True(string.IsNullOrEmpty(token));
Assert.Null(lifetime);
}
[Theory]
[InlineData("<html>busy</html>")]
[InlineData("[]")]
[InlineData("42")]
[InlineData("""{"access_token":"t"} x""")]
public void Token_response_that_is_not_one_object_throws(string body)
=> Assert.ThrowsAny<Exception>(() => GraphTokenService.ReadTokenResponse(body));
// D5: an expires_in that is not a whole number counts as absent; the token stays usable with the
// default lifetime. Newtonsoft threw on the first five and coerced the last two (3600, 1).
[Theory]
[InlineData("\"abc\"")]
[InlineData("\"\"")]
[InlineData("{}")]
[InlineData("[]")]
[InlineData("99999999999999999999")]
[InlineData("3599.5")]
[InlineData("true")]
public void Token_response_with_an_unusable_lifetime_keeps_the_token_D5(string expiresIn)
{
var (token, lifetime) = GraphTokenService.ReadTokenResponse($$"""{"access_token":"t","expires_in":{{expiresIn}}}""");
Assert.Equal("t", token);
Assert.Null(lifetime);
}
// ── EntraTokenRejection.Parse ───────────────────────────────────────────────
[Theory]
[InlineData("""{"error_codes":[7000229],"error_description":"AADSTS7000229: missing"}""", "AADSTS7000229")]
[InlineData("""{"error_codes":["7000229",53003]}""", "AADSTS53003")]
[InlineData("""{"error_codes":[7000229.0],"error_description":"AADSTS50000: x"}""", "AADSTS50000")]
[InlineData("""{"error_codes":7000229,"error_description":"AADSTS50000: x"}""", "AADSTS50000")]
[InlineData("""{"error_codes":[],"error_description":"AADSTS50000: x"}""", "AADSTS50000")]
[InlineData("""{"error_codes":[1],"error_codes":[7000229]}""", "AADSTS7000229")]
[InlineData("""{"error_codes":[7000229,],/*c*/}""", "AADSTS7000229")]
public void Entra_rejection_reads_the_first_integer_code_then_the_description(string body, string code)
=> Assert.Equal(code, EntraTokenRejection.Parse(400, body).ErrorCode);
[Theory]
[InlineData(null)]
[InlineData("")]
[InlineData(" ")]
[InlineData("null")]
[InlineData("\"AADSTS7000229\"")]
[InlineData("42")]
[InlineData("[1,2]")]
[InlineData("<html>busy</html>")]
[InlineData("""{"error_description":null}""")]
[InlineData("""{"error_description":42}""")]
[InlineData("""{"error_codes":[7000229]} x""")]
public void Entra_rejection_without_a_readable_object_keeps_only_the_status(string? body)
{
var rejection = EntraTokenRejection.Parse(400, body);
Assert.Equal(400, rejection.StatusCode);
Assert.Null(rejection.ErrorCode);
Assert.Null(rejection.Description);
}
// D3: a description is kept as sent, even when it looks like a date (Newtonsoft dropped it).
[Fact]
public void Entra_rejection_keeps_a_date_shaped_description_D3()
=> Assert.Equal("2026-11-01T08:00:00Z", EntraTokenRejection.Parse(400, """{"error_description":"2026-11-01T08:00:00Z"}""").Description);
// D6: an error code beyond Int64 is skipped like any other unusable entry (Newtonsoft threw).
[Fact]
public void Entra_rejection_skips_an_out_of_range_code_D6()
=> Assert.Equal("AADSTS53003", EntraTokenRejection.Parse(400, """{"error_codes":[99999999999999999999,53003]}""").ErrorCode);
// ── AutopilotDeviceValidator.FindRegistration ───────────────────────────────
[Theory]
[InlineData("")]
[InlineData("null")]
[InlineData("{}")]
[InlineData("""{"value":"oops"}""")]
[InlineData("""{"value":[]}""")]
[InlineData("""{"value":[{"serialNumber":null}]}""")]
[InlineData("""{"value":[{"serialNumber":"OTHER"}]}""")]
public void Autopilot_list_without_the_serial_is_not_registered(string body)
=> Assert.Null(AutopilotDeviceValidator.FindRegistration(body, Serial));
[Theory]
[InlineData("not json")]
[InlineData("[]")]
[InlineData("""{"value":[]} x""")]
public void Autopilot_list_that_is_not_one_object_throws(string body)
=> Assert.ThrowsAny<Exception>(() => AutopilotDeviceValidator.FindRegistration(body, Serial));
[Fact]
public void Autopilot_list_with_a_null_entry_before_the_match_throws()
=> Assert.Throws<InvalidOperationException>(() => AutopilotDeviceValidator.FindRegistration(
"""{"value":[null,{"id":"ap-1","serialNumber":"PF3XKQ7"}]}""", Serial));
[Fact]
public void Autopilot_list_matches_the_trimmed_serial_case_insensitively_and_stops_there()
{
var registration = AutopilotDeviceValidator.FindRegistration(
"""{"value":[{"id":"ap-1","serialNumber":" pf3xkq7 ","groupTag":" Sales ","purchaseOrderIdentifier":"PO-7","displayName":"KIOSK-1","userPrincipalName":"u@contoso.com"},null]}""",
Serial);
Assert.NotNull(registration);
Assert.Equal("ap-1", registration!.DeviceId);
Assert.Equal("Sales", registration.GroupTag);
Assert.Equal("PO-7", registration.PurchaseOrderId);
Assert.Equal("KIOSK-1", registration.DisplayName);
Assert.True(registration.UserAssigned);
}
[Fact]
public void Autopilot_registration_drops_blank_and_non_text_values_and_cuts_long_text()
{
var longText = new string('x', AutopilotDeviceValidator.MaxRegistrationFieldLength + 10);
var registration = AutopilotDeviceValidator.FindRegistration(
$$"""{"value":[{"id":" ","serialNumber":"PF3XKQ7","groupTag":true,"purchaseOrderIdentifier":{},"displayName":"{{longText}}","userPrincipalName":null}]}""",
Serial);
Assert.NotNull(registration);
Assert.Null(registration!.DeviceId);
Assert.Null(registration.GroupTag);
Assert.Null(registration.PurchaseOrderId);
Assert.Equal(AutopilotDeviceValidator.MaxRegistrationFieldLength, registration.DisplayName!.Length);
Assert.False(registration.UserAssigned);
}
// D4: a serial that is not text never matches (Newtonsoft matched through its text).
[Fact]
public void Autopilot_list_with_a_numeric_serial_does_not_match_D4()
=> Assert.Null(AutopilotDeviceValidator.FindRegistration("""{"value":[{"id":"ap-1","serialNumber":12345}]}""", "12345"));
// D3: registration text is kept as sent, even when it looks like a date (Newtonsoft dropped it).
[Fact]
public void Autopilot_registration_keeps_date_shaped_text_D3()
{
var registration = AutopilotDeviceValidator.FindRegistration(
"""{"value":[{"id":"ap-1","serialNumber":"PF3XKQ7","groupTag":"2026-01-01T00:00:00Z","displayName":"/Date(1713096021000)/"}]}""",
Serial);
Assert.Equal("2026-01-01T00:00:00Z", registration!.GroupTag);
Assert.Equal("/Date(1713096021000)/", registration.DisplayName);
}
// ── CorporateIdentifierValidator.ReadIdentityPage ───────────────────────────
private static readonly string CorporateId =
CorporateIdentifierValidator.BuildNormalizedIdentifier("Microsoft Corporation", "Virtual Machine", "1234-5678");
[Theory]
[InlineData("", "")]
[InlineData("null", "")]
[InlineData("{}", "")]
[InlineData("""{"value":null}""", "")]
[InlineData("""{"value":[],"@odata.nextLink":""}""", "")]
[InlineData("""{"value":[],"@odata.nextLink":null}""", "")]
[InlineData("""{"value":{},"@odata.nextLink":"https://graph.microsoft.com/beta/next"}""", "https://graph.microsoft.com/beta/next")]
[InlineData("""{"value":[{"importedDeviceIdentityType":"serialNumber","importedDeviceIdentifier":"1234-5678"}]}""", "")]
public void Corporate_page_without_the_identifier_yields_the_next_url(string body, string nextUrl)
=> Assert.Equal((false, nextUrl), CorporateIdentifierValidator.ReadIdentityPage(body, CorporateId));
[Theory]
[InlineData("""{"value":[{"importedDeviceIdentityType":"manufacturerModelSerial","importedDeviceIdentifier":"Microsoft Corporation,Virtual Machine,1234-5678"}],"@odata.nextLink":"https://graph.microsoft.com/beta/next"}""")]
[InlineData("""{"value":[{"importedDeviceIdentityType":"MANUFACTURERMODELSERIAL","importedDeviceIdentifier":"MICROSOFTCORPORATION,VIRTUALMACHINE,12345678"}]}""")]
[InlineData("""{"value":[{"importedDeviceIdentityType":"manufacturerModelSerial","importedDeviceIdentifier":null},{"importedDeviceIdentityType":"manufacturerModelSerial","importedDeviceIdentifier":"Microsoft Corporation,Virtual Machine,1234-5678"}]}""")]
public void Corporate_page_with_the_identifier_is_found(string body)
=> Assert.Equal((true, string.Empty), CorporateIdentifierValidator.ReadIdentityPage(body, CorporateId));
[Theory]
[InlineData("not json")]
[InlineData("[]")]
public void Corporate_page_that_is_not_one_object_throws(string body)
=> Assert.ThrowsAny<Exception>(() => CorporateIdentifierValidator.ReadIdentityPage(body, CorporateId));
[Fact]
public void Corporate_page_with_a_null_entry_before_the_match_throws()
=> Assert.Throws<InvalidOperationException>(() => CorporateIdentifierValidator.ReadIdentityPage(
"""{"value":[null,{"importedDeviceIdentityType":"manufacturerModelSerial","importedDeviceIdentifier":"Microsoft Corporation,Virtual Machine,1234-5678"}]}""",
CorporateId));
[Theory]
[InlineData("5")]
[InlineData("true")]
[InlineData("{}")]
public void Corporate_page_with_a_non_text_next_link_never_yields_a_page_to_follow(string nextLink)
{
// The scan must stop as a failure: either the read throws or the url cannot be requested.
try
{
var (found, nextUrl) = CorporateIdentifierValidator.ReadIdentityPage($$"""{"value":[],"@odata.nextLink":{{nextLink}}}""", CorporateId);
Assert.False(found);
Assert.False(string.IsNullOrEmpty(nextUrl));
Assert.False(Uri.IsWellFormedUriString(nextUrl, UriKind.Absolute));
}
catch (Exception ex) when (ex is not Xunit.Sdk.XunitException)
{
// Throwing ends the scan as transient, like an unusable url does.
}
}
// D4: an identifier that is not text never matches (Newtonsoft matched an array through its text).
[Fact]
public void Corporate_page_with_an_array_identifier_does_not_match_D4()
=> Assert.False(CorporateIdentifierValidator.ReadIdentityPage(
"""{"value":[{"importedDeviceIdentityType":"manufacturerModelSerial","importedDeviceIdentifier":["Microsoft Corporation,Virtual Machine,1234-5678"]}]}""",
CorporateId).Found);
// ── DeviceAssociationValidator.ParseTenantAssociatedDevicesResponse ─────────
[Theory]
[InlineData("")]
[InlineData("null")]
[InlineData("[]")]
[InlineData("42")]
[InlineData("not json")]
[InlineData("{} x")]
[InlineData("""{"value":null}""")]
[InlineData("""{"value":{}}""")]
[InlineData("""{"value":[{"serialNumber":"OTHER"}]}""")]
public void Association_list_without_the_serial_is_not_found(string body)
{
var result = DeviceAssociationValidator.ParseTenantAssociatedDevicesResponse(body, Serial);
Assert.False(result.IsValid);
Assert.False(result.IsTransient);
}
[Fact]
public void Association_list_with_a_null_entry_before_the_match_throws()
=> Assert.Throws<InvalidOperationException>(() => DeviceAssociationValidator.ParseTenantAssociatedDevicesResponse(
"""{"value":[null,{"serialNumber":"PF3XKQ7"}]}""", Serial));
[Fact]
public void Association_list_reads_the_matching_device_and_stops_there()
{
var result = DeviceAssociationValidator.ParseTenantAssociatedDevicesResponse(
"""{"value":[{"serialNumber":" pf3xkq7 ","associationState":"associated","devicePreparationPolicyId":"pol-1","preassociatedByUserPrincipalName":"a@contoso.com","assignedToUserPrincipalName":"u@contoso.com","managedDeviceId":"md-1","preassociationDateTime":"2026-05-08T12:16:49Z"},null]}""",
Serial);
Assert.True(result.IsValid);
Assert.Equal("associated", result.AssociationState);
Assert.Equal("pol-1", result.DevicePreparationPolicyId);
Assert.Equal("a@contoso.com", result.PreAssociatedByUserPrincipalName);
Assert.Equal("u@contoso.com", result.AssignedToUserPrincipalName);
Assert.Equal("md-1", result.ManagedDeviceId);
Assert.Equal(new DateTime(2026, 5, 8, 12, 16, 49, DateTimeKind.Utc), result.PreAssociationDateTime);
Assert.Equal(DateTimeKind.Utc, result.PreAssociationDateTime!.Value.Kind);
}
[Theory]
[InlineData("""{"value":[{"serialNumber":"PF3XKQ7"}]}""")]
[InlineData("""{"value":[{"serialNumber":"PF3XKQ7","associationDateTime":null}]}""")]
[InlineData("""{"value":[{"serialNumber":"PF3XKQ7","associationDateTime":""}]}""")]
[InlineData("""{"value":[{"serialNumber":"PF3XKQ7","associationDateTime":"0001-01-01T00:00:00Z"}]}""")]
[InlineData("""{"value":[{"serialNumber":"PF3XKQ7","associationDateTime":"not-a-date"}]}""")]
public void Association_date_that_is_unset_reads_as_null(string body)
=> Assert.Null(DeviceAssociationValidator.ParseTenantAssociatedDevicesResponse(body, Serial).AssociationDateTime);
// D1: JSON null in a text field is absent (Newtonsoft read it as an empty string).
[Fact]
public void Association_fields_that_are_json_null_read_as_null_D1()
{
var result = DeviceAssociationValidator.ParseTenantAssociatedDevicesResponse(
"""{"value":[{"serialNumber":"PF3XKQ7","associationState":null,"assignedToUserPrincipalName":null,"managedDeviceId":null}]}""",
Serial);
Assert.Null(result.AssociationState);
Assert.Null(result.AssignedToUserPrincipalName);
Assert.Null(result.ManagedDeviceId);
}
// D4: text whose escapes are no valid UTF-16 reads as absent, in the serial of another entry and in a field
// of the match, instead of failing the whole lookup (Newtonsoft read it into a broken string).
[Fact]
public void Association_text_with_a_broken_escape_reads_as_null_D4()
{
var result = DeviceAssociationValidator.ParseTenantAssociatedDevicesResponse(
"""{"value":[{"serialNumber":"\ud800"},{"serialNumber":"PF3XKQ7","assignedToUserPrincipalName":"u\ud800"}]}""", Serial);
Assert.True(result.IsValid);
Assert.Null(result.AssignedToUserPrincipalName);
}
// D2: the date keeps its fraction, in any culture (Newtonsoft cut it to whole seconds).
[Theory]
[InlineData("en-US")]
[InlineData("de-DE")]
[InlineData("en-GB")]
[InlineData("th-TH")]
public void Association_date_keeps_its_fraction_in_any_culture_D2(string culture)
{
var date = InCulture(culture, () => DeviceAssociationValidator.ParseTenantAssociatedDevicesResponse(
"""{"value":[{"serialNumber":"PF3XKQ7","preassociationDateTime":"2026-05-08T12:16:49.1234567Z"}]}""",
Serial).PreAssociationDateTime);
Assert.Equal(new DateTime(2026, 5, 8, 12, 16, 49, DateTimeKind.Utc).AddTicks(1234567), date);
Assert.Equal(DateTimeKind.Utc, date!.Value.Kind);
}
// ── CloudPcDeviceValidator.ParseCloudPcResponse ─────────────────────────────
[Theory]
[InlineData("")]
[InlineData("null")]
[InlineData("[]")]
[InlineData("not json")]
[InlineData("""{"value":[]} x""")]
[InlineData("""{"value":null}""")]
[InlineData("""{"value":[{"managedDeviceId":"other"}]}""")]
public void CloudPc_list_without_the_device_is_not_found(string body)
{
var result = CloudPcDeviceValidator.ParseCloudPcResponse(body, IntuneId);
Assert.False(result.IsValid);
Assert.False(result.IsTransient);
}
[Fact]
public void CloudPc_list_with_a_null_entry_before_the_match_throws()
=> Assert.Throws<InvalidOperationException>(() => CloudPcDeviceValidator.ParseCloudPcResponse(
$$"""{"value":[null,{"managedDeviceId":"{{IntuneId}}"}]}""", IntuneId));
[Fact]
public void CloudPc_list_reads_the_matching_cloud_pc()
{
var result = CloudPcDeviceValidator.ParseCloudPcResponse(
$$"""{"value":[{"id":"cpc-1","managedDeviceId":" {{IntuneId.ToUpperInvariant()}} ","managedDeviceName":"CPC-ADM-1","servicePlanName":"Cloud PC Enterprise"},null]}""",
IntuneId);
Assert.True(result.IsValid);
Assert.Equal("cpc-1", result.CloudPcId);
Assert.Equal("CPC-ADM-1", result.ManagedDeviceName);
Assert.Equal("Cloud PC Enterprise", result.ServicePlanName);
}
// D1: JSON null in a text field is absent (Newtonsoft read it as an empty string).
[Fact]
public void CloudPc_fields_that_are_json_null_read_as_null_D1()
{
var result = CloudPcDeviceValidator.ParseCloudPcResponse(
$$"""{"value":[{"managedDeviceId":"{{IntuneId}}","id":null,"managedDeviceName":null,"servicePlanName":null}]}""", IntuneId);
Assert.True(result.IsValid);
Assert.Null(result.CloudPcId);
Assert.Null(result.ManagedDeviceName);
Assert.Null(result.ServicePlanName);
}
// ── IntuneDeviceBindingValidator.ParseManagedDeviceResponse ─────────────────
[Theory]
[InlineData("")]
[InlineData(" ")]
[InlineData("null")]
[InlineData("[]")]
[InlineData("42")]
[InlineData("not json")]
[InlineData("""[{"id":"6f1c4d2a-0b3e-4c5d-8e9f-1a2b3c4d5e6f"}]""")]
[InlineData("""{"id":"6f1c4d2a-0b3e-4c5d-8e9f-1a2b3c4d5e6f"} x""")]
[InlineData("""{"id":null}""")]
[InlineData("""{"id":42}""")]
[InlineData("""{"id":"other"}""")]
public void Managed_device_that_is_not_the_requested_one_is_not_found(string body)
=> Assert.Equal(IntuneDeviceBindingOutcome.NotFound, IntuneDeviceBindingValidator.ParseManagedDeviceResponse(body, IntuneId).Outcome);
[Theory]
[InlineData("\"managed\"", IntuneDeviceBindingOutcome.Match)]
[InlineData("null", IntuneDeviceBindingOutcome.Match)]
[InlineData("\"retirePending\"", IntuneDeviceBindingOutcome.NotManaged)]
[InlineData("\"WIPEISSUED\"", IntuneDeviceBindingOutcome.NotManaged)]
[InlineData("\"deletePending\"", IntuneDeviceBindingOutcome.NotManaged)]
public void Managed_device_on_its_way_out_is_not_managed(string managementState, IntuneDeviceBindingOutcome outcome)
=> Assert.Equal(outcome, IntuneDeviceBindingValidator.ParseManagedDeviceResponse(
$$"""{"id":" {{IntuneId.ToUpperInvariant()}} ","managementState":{{managementState}}}""", IntuneId).Outcome);
[Theory]
[InlineData("true", true)]
[InlineData("false", false)]
[InlineData("null", null)]
[InlineData("\"true\"", null)]
[InlineData("1", null)]
public void Managed_device_registration_flag_is_strictly_boolean(string value, bool? expected)
=> Assert.Equal(expected, IntuneDeviceBindingValidator.ParseManagedDeviceResponse(
$$"""{"id":"{{IntuneId}}","azureADRegistered":{{value}}}""", IntuneId).AzureAdRegistered);
[Theory]
[InlineData("null")]
[InlineData("\"\"")]
[InlineData("\" \"")]
public void Managed_device_telemetry_fields_that_are_blank_read_as_null(string value)
{
var result = IntuneDeviceBindingValidator.ParseManagedDeviceResponse(
$$"""{"id":"{{IntuneId}}","serialNumber":{{value}},"managedDeviceOwnerType":{{value}},"deviceEnrollmentType":{{value}},"enrolledDateTime":{{value}}}""",
IntuneId);
Assert.Null(result.SerialNumber);
Assert.Null(result.OwnerType);
Assert.Null(result.EnrollmentType);
Assert.Null(result.EnrolledDateTime);
}
[Fact]
public void Managed_device_reads_its_fields()
{
var result = IntuneDeviceBindingValidator.ParseManagedDeviceResponse(
$$"""{"id":"{{IntuneId}}","deviceName":"DESKTOP-1","azureADDeviceId":"aad-1","managementState":"managed","serialNumber":"PF3XKQ7","managedDeviceOwnerType":"company","deviceEnrollmentType":"windowsAzureADJoin","enrolledDateTime":"2026-05-08T12:16:49Z"}""",
IntuneId);
Assert.Equal(IntuneDeviceBindingOutcome.Match, result.Outcome);
Assert.Equal("DESKTOP-1", result.DeviceName);
Assert.Equal("aad-1", result.AzureAdDeviceId);
Assert.Equal("PF3XKQ7", result.SerialNumber);
Assert.Equal("company", result.OwnerType);
Assert.Equal("windowsAzureADJoin", result.EnrollmentType);
Assert.Equal(new DateTimeOffset(2026, 5, 8, 12, 16, 49, TimeSpan.Zero), result.EnrolledDateTime);
}
[Fact]
public void Managed_device_unset_enrollment_date_reads_as_null()
=> Assert.Null(IntuneDeviceBindingValidator.ParseManagedDeviceResponse(
$$"""{"id":"{{IntuneId}}","enrolledDateTime":"0001-01-01T00:00:00Z"}""", IntuneId).EnrolledDateTime);
// D1: JSON null in a text field is absent (Newtonsoft read it as an empty string).
[Fact]
public void Managed_device_fields_that_are_json_null_read_as_null_D1()
{
var result = IntuneDeviceBindingValidator.ParseManagedDeviceResponse(
$$"""{"id":"{{IntuneId}}","deviceName":null,"azureADDeviceId":null,"managementState":null}""", IntuneId);
Assert.Equal(IntuneDeviceBindingOutcome.Match, result.Outcome);
Assert.Null(result.DeviceName);
Assert.Null(result.AzureAdDeviceId);
Assert.Null(result.ManagementState);
}
// D2: the enrollment date keeps its fraction and its day and month in any culture (Newtonsoft cut the
// fraction and swapped day and month on day-first cultures).
[Theory]
[InlineData("en-US")]
[InlineData("de-DE")]
[InlineData("en-GB")]
[InlineData("th-TH")]
public void Managed_device_enrollment_date_is_the_same_in_any_culture_D2(string culture)
{
var date = InCulture(culture, () => IntuneDeviceBindingValidator.ParseManagedDeviceResponse(
$$"""{"id":"{{IntuneId}}","enrolledDateTime":"2026-05-08T12:16:49.1234567Z"}""", IntuneId).EnrolledDateTime);
Assert.Equal(new DateTimeOffset(2026, 5, 8, 12, 16, 49, TimeSpan.Zero).AddTicks(1234567), date);
Assert.Equal(TimeSpan.Zero, date!.Value.Offset);
}
// D4: an id that is not text never matches (Newtonsoft matched through its text).
[Fact]
public void Managed_device_with_a_numeric_id_is_not_found_D4()
=> Assert.Equal(IntuneDeviceBindingOutcome.NotFound,
IntuneDeviceBindingValidator.ParseManagedDeviceResponse("""{"id":12345}""", "12345").Outcome);
// ── Dates in any offset (new with System.Text.Json) ─────────────────────────
// Newtonsoft turned an offset date into machine-local time and read that back as UTC, so the instant
// depended on the host's time zone; it was only right on a UTC host.
[Theory]
[InlineData("2026-05-08T14:16:49+02:00")]
[InlineData("2026-05-08T07:16:49-05:00")]
[InlineData("2026-05-08T12:16:49Z")]
[InlineData("2026-05-08T12:16:49")]
public void Dates_in_any_offset_read_as_the_same_utc_instant(string value)
{
var expected = new DateTime(2026, 5, 8, 12, 16, 49, DateTimeKind.Utc);
var association = DeviceAssociationValidator.ParseTenantAssociatedDevicesResponse(
$$"""{"value":[{"serialNumber":"PF3XKQ7","preassociationDateTime":"{{value}}"}]}""", Serial).PreAssociationDateTime;
var enrolled = IntuneDeviceBindingValidator.ParseManagedDeviceResponse(
$$"""{"id":"{{IntuneId}}","enrolledDateTime":"{{value}}"}""", IntuneId).EnrolledDateTime;
Assert.Equal(expected, association);
Assert.Equal(DateTimeKind.Utc, association!.Value.Kind);
Assert.Equal(new DateTimeOffset(expected), enrolled);
Assert.Equal(TimeSpan.Zero, enrolled!.Value.Offset);
}
// ── ScriptDisplayNameResolver.ReadScriptPage / ReadScriptDisplayName ────────
[Fact]
public void Script_page_keeps_object_entries_with_an_id_and_the_next_url()
{
var (scripts, next) = ScriptDisplayNameResolver.ReadScriptPage(
"""{"value":[1,"x",null,[],{"displayName":"no id"},{"id":null},{"id":""},{"id":"s1","displayName":"A","fileName":"a.ps1"},{"id":"s2","displayName":"B"}],"@odata.nextLink":"https://graph.microsoft.com/beta/p2"}""",
withFileName: true);
Assert.Equal(new[]
{
new ScriptDisplayNameResolver.ScriptListItem("s1", "A", "a.ps1"),
new ScriptDisplayNameResolver.ScriptListItem("s2", "B", null),
}, scripts);
Assert.Equal("https://graph.microsoft.com/beta/p2", next);
}
[Theory]
[InlineData("""{"value":[{"id":"s1"}]}""")]
[InlineData("""{"value":[],"@odata.nextLink":null}""")]
[InlineData("""{"value":[],"@odata.nextLink":""}""")]
[InlineData("""{"value":"oops"}""")]
[InlineData("{}")]
public void Script_page_without_a_next_link_ends_the_pull(string body)
=> Assert.True(string.IsNullOrEmpty(ScriptDisplayNameResolver.ReadScriptPage(body, withFileName: false).NextUrl));
[Fact]
public void Script_page_of_health_scripts_reads_no_file_name()
=> Assert.Null(Assert.Single(ScriptDisplayNameResolver.ReadScriptPage(
"""{"value":[{"id":"s1","displayName":"A","fileName":"a.ps1"}]}""", withFileName: false).Scripts).FileName);
[Theory]
[InlineData("")]
[InlineData(" ")]
[InlineData("null")]
[InlineData("[]")]
[InlineData("not json")]
public void Script_page_or_name_that_is_not_one_object_throws(string body)
{
Assert.ThrowsAny<Exception>(() => ScriptDisplayNameResolver.ReadScriptPage(body, withFileName: false));
Assert.ThrowsAny<Exception>(() => ScriptDisplayNameResolver.ReadScriptDisplayName(body));
}
[Theory]
[InlineData("""{"displayName":"Install agent"}""", "Install agent")]
[InlineData("""{"id":"s1"}""", null)]
public void Script_name_reads_the_display_name(string body, string? name)
=> Assert.Equal(name, ScriptDisplayNameResolver.ReadScriptDisplayName(body));
// D1: a display name that is JSON null is absent (Newtonsoft read it as an empty string).
[Fact]
public void Script_name_that_is_json_null_reads_as_null_D1()
{
Assert.Null(ScriptDisplayNameResolver.ReadScriptDisplayName("""{"displayName":null}"""));
Assert.Null(Assert.Single(ScriptDisplayNameResolver.ReadScriptPage(
"""{"value":[{"id":"s1","displayName":null}]}""", withFileName: false).Scripts).DisplayName);
}
// D3: a display name is kept as sent in any culture, even when it looks like a date (Newtonsoft
// rewrote it in the current culture, "1/1/2026 12:00:00 AM" in en-US).
[Theory]
[InlineData("en-US")]
[InlineData("de-DE")]
[InlineData("th-TH")]
public void Script_name_shaped_like_a_date_is_kept_as_sent_D3(string culture)
=> Assert.Equal("2026-01-01T00:00:00Z", InCulture(culture, () =>
ScriptDisplayNameResolver.ReadScriptDisplayName("""{"displayName":"2026-01-01T00:00:00Z"}""")));
// D4: a display name that is not text is absent (Newtonsoft read a number as its text).
[Fact]
public void Script_name_that_is_a_number_reads_as_null_D4()
=> Assert.Null(ScriptDisplayNameResolver.ReadScriptDisplayName("""{"displayName":42}"""));
// ── D7: a body cut off mid-object is unreadable ─────────────────────────────
// Newtonsoft's DeserializeObject read the part before the cut as if the open containers were closed, so a
// cut-off list could still match. Every parser now answers it like any other unreadable body. HttpClient
// throws on a premature end before a parser sees the body, so only a server-side cut can get here.
[Fact]
public void Token_response_cut_off_throws_D7()
=> Assert.ThrowsAny<Exception>(() => GraphTokenService.ReadTokenResponse("""{"access_token":"t","expires_in":3599"""));
[Fact]
public void Entra_rejection_cut_off_keeps_only_the_status_D7()
{
var rejection = EntraTokenRejection.Parse(400, """{"error_codes":[53003""");
Assert.Null(rejection.ErrorCode);
Assert.Null(rejection.Description);
}
[Fact]
public void Autopilot_list_cut_off_throws_D7()
=> Assert.ThrowsAny<Exception>(() => AutopilotDeviceValidator.FindRegistration(
"""{"value":[{"id":"ap-1","serialNumber":"PF3XKQ7"}""", Serial));
[Fact]
public void Corporate_page_cut_off_throws_D7()
=> Assert.ThrowsAny<Exception>(() => CorporateIdentifierValidator.ReadIdentityPage(
"""{"value":[{"importedDeviceIdentityType":"manufacturerModelSerial","importedDeviceIdentifier":"Microsoft Corporation,Virtual Machine,1234-5678"}""",
CorporateId));
[Fact]
public void Association_list_cut_off_is_not_found_D7()
{
var result = DeviceAssociationValidator.ParseTenantAssociatedDevicesResponse("""{"value":[{"serialNumber":"PF3XKQ7"}""", Serial);
Assert.False(result.IsValid);
Assert.False(result.IsTransient);
}
[Fact]
public void CloudPc_list_cut_off_is_not_found_D7()
{
var result = CloudPcDeviceValidator.ParseCloudPcResponse($$"""{"value":[{"managedDeviceId":"{{IntuneId}}"}""", IntuneId);
Assert.False(result.IsValid);
Assert.False(result.IsTransient);
}
[Fact]
public void Managed_device_cut_off_is_not_found_D7()
=> Assert.Equal(IntuneDeviceBindingOutcome.NotFound, IntuneDeviceBindingValidator.ParseManagedDeviceResponse(
$$"""{"id":"{{IntuneId}}","azureADRegistered":true""", IntuneId).Outcome);
private static T InCulture<T>(string culture, Func<T> read)
{
var saved = CultureInfo.CurrentCulture;
try
{
CultureInfo.CurrentCulture = new CultureInfo(culture);
return read();
}
finally
{
CultureInfo.CurrentCulture = saved;
}
}
}
@@ -23,7 +23,7 @@ public class GraphTokenServiceTests
private const string TenantA = "11111111-1111-1111-1111-111111111111";
private const string TenantB = "22222222-2222-2222-2222-222222222222";
private static (GraphTokenService svc, StubHttpMessageHandler handler) Create(StubHttpMessageHandler handler)
private static (GraphTokenService svc, StubHttpMessageHandler handler) Create(StubHttpMessageHandler handler, IMemoryCache? cache = null)
{
var config = new ConfigurationBuilder()
.AddInMemoryCollection(new Dictionary<string, string?>
@@ -33,7 +33,7 @@ public class GraphTokenServiceTests
})
.Build();
var svc = NewService(config, new StubHttpClientFactory(handler));
var svc = NewService(config, new StubHttpClientFactory(handler), cache: cache);
return (svc, handler);
}
@@ -47,11 +47,12 @@ public class GraphTokenServiceTests
IConfiguration config,
System.Net.Http.IHttpClientFactory factory,
IGraphAccessHealthRecorder? accessHealth = null,
Microsoft.Extensions.Logging.ILogger<GraphTokenService>? logger = null) =>
Microsoft.Extensions.Logging.ILogger<GraphTokenService>? logger = null,
IMemoryCache? cache = null) =>
new GraphTokenService(
logger ?? NullLogger<GraphTokenService>.Instance,
factory,
new MemoryCache(new MemoryCacheOptions()),
cache ?? new MemoryCache(new MemoryCacheOptions()),
new EntraAppRegistry(config, NullLogger<EntraAppRegistry>.Instance),
new AutopilotMonitor.Functions.Services.TenantConfigurationService(
Moq.Mock.Of<AutopilotMonitor.Shared.DataAccess.IConfigRepository>(),
@@ -131,6 +132,53 @@ public class GraphTokenServiceTests
Assert.Equal(1, TokenPosts(handler, TenantA));
}
// The token stays cached for expires_in minus the 5-minute skew, clamped to 60 s .. 55 min. An absent
// or unusable expires_in (D5 in D-420: text, a fraction, zero or less) falls back to the 35-minute
// default, so 30 minutes; a value far beyond the cap is capped instead of overflowing.
[Theory]
[InlineData("3599", 3299)]
[InlineData("\"3599\"", 3299)]
[InlineData("7200", 3300)]
[InlineData("120", 60)]
[InlineData("null", 1800)]
[InlineData("\"abc\"", 1800)]
[InlineData("3599.5", 1800)]
[InlineData("0", 1800)]
[InlineData("-5", 1800)]
[InlineData("9223372036854775807", 3300)]
public async Task Token_cache_lifetime_follows_expires_in(string expiresIn, int seconds)
{
var cache = new RecordingMemoryCache();
var (svc, _) = Create(new StubHttpMessageHandler()
.When($"/{TenantA}/oauth2", HttpStatusCode.OK, $$"""{"access_token":"tok-A","expires_in":{{expiresIn}}}"""), cache);
Assert.Equal("tok-A", (await svc.GetAccessTokenAsync(TenantA)).AccessToken);
var entry = Assert.Single(cache.Entries, e => e.Key is string key && key.StartsWith($"graph-token:{TenantA}:", StringComparison.Ordinal));
Assert.Equal(TimeSpan.FromSeconds(seconds), entry.AbsoluteExpirationRelativeToNow);
}
/// <summary>A memory cache that keeps every entry it creates, so a test can read the lifetime the service chose.</summary>
private sealed class RecordingMemoryCache : IMemoryCache
{
private readonly MemoryCache _inner = new(new MemoryCacheOptions());
public List<ICacheEntry> Entries { get; } = new();
public ICacheEntry CreateEntry(object key)
{
var entry = _inner.CreateEntry(key);
Entries.Add(entry);
return entry;
}
public bool TryGetValue(object key, out object? value) => _inner.TryGetValue(key, out value);
public void Remove(object key) => _inner.Remove(key);
public void Dispose() => _inner.Dispose();
}
[Fact]
public async Task InvalidateTenant_forces_fresh_token_on_next_call()
{
@@ -451,7 +499,7 @@ public class GraphTokenServiceTests
logger.Verify(l => l.Log(
Microsoft.Extensions.Logging.LogLevel.Warning,
Moq.It.IsAny<Microsoft.Extensions.Logging.EventId>(),
Moq.It.Is<Moq.It.IsAnyType>((state, _) => state.ToString()!.Contains("rejected by Entra") && state.ToString()!.Contains("AADSTS53003")),
Moq.It.Is<Moq.It.IsAnyType>((state, _) => state != null && state.ToString()!.Contains("rejected by Entra") && state.ToString()!.Contains("AADSTS53003")),
Moq.It.IsAny<Exception?>(),
Moq.It.IsAny<Func<Moq.It.IsAnyType, Exception?, string>>()), Moq.Times.Once);
}
@@ -76,6 +76,34 @@ public class GraphWireParityTests
new GetScriptDisplayNamesResponse { Refs = new Dictionary<string, string?>() });
}
[Fact]
public void GetScriptDisplayNamesResponse_carries_timedOut_only_when_a_time_limit_fired()
{
// The portal asks once more when it sees timedOut. Null leaves the key out, so an
// answer within the limits keeps the shapes pinned above.
var payload = new Dictionary<string, string?>
{
["Platform:6cef8fa7-9163-40cf-8f56-52f3aaaa1006"] = null,
};
AssertParity(
new { refs = payload, timedOut = true },
new GetScriptDisplayNamesResponse { Refs = payload, TimedOut = true });
}
[Fact]
public void ScriptDisplayNamesRequest_reads_the_retry_flag_and_tolerates_its_absence()
{
var options = ApiJsonOptions.Create();
const string Ref = "\"Platform:7df090b8-a274-41d0-9067-52f3aaaa1007\"";
var followUp = JsonSerializer.Deserialize<ScriptDisplayNamesRequest>("{\"refs\":[" + Ref + "],\"retry\":true}", options);
var first = JsonSerializer.Deserialize<ScriptDisplayNamesRequest>("{\"refs\":[" + Ref + "]}", options);
Assert.True(followUp!.Retry);
Assert.Null(first!.Retry);
}
[Fact]
public void GetScriptDisplayNamesResponse_dictionary_keys_are_not_camel_cased()
{
@@ -235,6 +235,26 @@ public class GrowthMetricsBuilderTests
Assert.Null(a.MedianDaysToFirstEnrollment);
}
[Fact]
public void Before_yesterday_is_aggregated_yesterdays_counters_count_as_activity_and_the_rows_end_the_day_before()
{
// Sessions yesterday after a 40-day pause; the first maintenance run after midnight has not written them yet.
var configs = new[] { Config('a', Utc(6, 1, 9)) };
var stats = new[] { Stats('a', 6, 5, Utc(10, 27, 22)) };
var rows = new[] { Active('a', 2026, 9, 17) };
var early = GrowthMetricsBuilder.Build(configs, stats, rows, Now, 30, TimeZoneInfo.Utc, false, NoExclusions, yesterdayAggregated: false);
Assert.Equal("2026-10-26", early.UsageDaysThrough);
Assert.Equal(0, early.AllTenants.Dormant);
Assert.Equal(1, early.AllTenants.Active7Days);
// Aggregated, yesterday has no row: the counters moved for an old session, which is no activity.
var later = GrowthMetricsBuilder.Build(configs, stats, rows, Now, 30, TimeZoneInfo.Utc, false, NoExclusions);
Assert.Equal("2026-10-27", later.UsageDaysThrough);
Assert.Equal(1, later.AllTenants.Dormant);
}
[Fact]
public void A_peak_needs_three_signups_and_twice_the_median_of_the_two_weeks_before()
{
@@ -52,7 +52,8 @@ public class InfrastructureWireParityTests
mcpClientRegistrationEnabled = true,
whatsNewSeenPlatformUtc = platformSeen,
whatsNewSeenAgentUtc = agentSeen,
dpaAcceptancePending = true
dpaAcceptancePending = true,
companyName = "Contoso Ltd."
},
new AuthMeResponse
{
@@ -74,7 +75,8 @@ public class InfrastructureWireParityTests
McpClientRegistrationEnabled = true,
WhatsNewSeenPlatformUtc = platformSeen,
WhatsNewSeenAgentUtc = agentSeen,
DpaAcceptancePending = true
DpaAcceptancePending = true,
CompanyName = "Contoso Ltd."
});
}
@@ -124,32 +124,38 @@ public class IntuneDeviceBindingValidatorTests
Assert.Null(result.EnrolledDateTime);
}
// -- ParseEnrolledDateTime --
// -- enrolledDateTime --
private static DateTimeOffset? EnrolledDateTime(string jsonValue)
=> IntuneDeviceBindingValidator.ParseManagedDeviceResponse(
$$"""{ "id": "{{DeviceId}}", "enrolledDateTime": {{jsonValue}} }""", DeviceId).EnrolledDateTime;
[Fact]
public void ParseEnrolledDateTime_IntuneZeroDate_IsAbsenceNotADate()
public void EnrolledDateTime_IntuneZeroDate_IsAbsenceNotADate()
{
// Intune returns 0001-01-01T00:00:00Z when it has no enrollment timestamp. Treating that
// as a real date would report an object age of ~2000 years and poison the race analysis.
Assert.Null(IntuneDeviceBindingValidator.ParseEnrolledDateTime("0001-01-01T00:00:00Z"));
Assert.Null(EnrolledDateTime("\"0001-01-01T00:00:00Z\""));
}
[Theory]
[InlineData(null)]
[InlineData("")]
[InlineData(" ")]
[InlineData("not-a-date")]
public void ParseEnrolledDateTime_UnusableInput_IsNull(string? raw)
[InlineData("null")]
[InlineData("\"\"")]
[InlineData("\" \"")]
[InlineData("\"not-a-date\"")]
[InlineData("20260824")]
[InlineData("true")]
public void EnrolledDateTime_UnusableValue_IsNull(string jsonValue)
{
Assert.Null(IntuneDeviceBindingValidator.ParseEnrolledDateTime(raw));
Assert.Null(EnrolledDateTime(jsonValue));
}
[Fact]
public void ParseEnrolledDateTime_NormalizesToUtc()
public void EnrolledDateTime_NormalizesToUtc()
{
// A device object created minutes ago is the signature of an enrollment race, so the
// instant has to be comparable regardless of the offset Graph reports it in.
var parsed = IntuneDeviceBindingValidator.ParseEnrolledDateTime("2026-08-24T17:20:00+02:00");
var parsed = EnrolledDateTime("\"2026-08-24T17:20:00+02:00\"");
Assert.NotNull(parsed);
Assert.Equal(TimeSpan.Zero, parsed!.Value.Offset);
@@ -0,0 +1,261 @@
using System;
using System.Collections.Generic;
using System.Linq;
using AutopilotMonitor.Functions.Security;
using AutopilotMonitor.Functions.Services.GraphResolution;
using AutopilotMonitor.Shared.Models;
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// The Graph and Entra token-endpoint response parsers as they read with Newtonsoft before D-420, copied
/// verbatim as the reference for <see cref="UpstreamJsonDifferentialTests"/>. Temporary: removed together
/// with that test once the System.Text.Json parsers have run cleanly in production (backlog).
/// </summary>
internal static class LegacyUpstreamParsers
{
public static (string? AccessToken, long? ExpiresInSeconds) ReadTokenResponse(string responseBody)
{
var tokenJson = JsonConvert.DeserializeObject<JObject>(responseBody);
var accessToken = tokenJson?["access_token"]?.ToString();
return string.IsNullOrEmpty(accessToken) ? (accessToken, null) : (accessToken, (long?)tokenJson?["expires_in"]);
}
public static EntraTokenRejection ParseEntraRejection(int statusCode, string? body)
{
JObject? json = null;
if (!string.IsNullOrWhiteSpace(body))
{
try { json = JsonConvert.DeserializeObject<JToken>(body) as JObject; }
catch (JsonException) { json = null; }
}
var description = (json?["error_description"] as JValue)?.Value as string;
string? code = null;
var first = (json?["error_codes"] as JArray)?.FirstOrDefault(t => t.Type == JTokenType.Integer);
if (first != null)
{
code = "AADSTS" + first.Value<long>();
}
else
{
var start = description?.IndexOf("AADSTS", StringComparison.Ordinal) ?? -1;
if (start >= 0)
{
var digits = new string(description!.Skip(start + "AADSTS".Length).TakeWhile(char.IsDigit).ToArray());
code = digits.Length == 0 ? null : "AADSTS" + digits;
}
}
string? shortened = null;
if (!string.IsNullOrWhiteSpace(description))
{
var line = description.Split('\n')[0].Trim();
shortened = line.Length <= 300 ? line : line.Substring(0, 300);
}
return new EntraTokenRejection(statusCode, code, shortened);
}
public static AutopilotRegistration? FindRegistration(string responseBody, string normalizedSerial)
{
var data = JsonConvert.DeserializeObject<JObject>(responseBody);
if (data?["value"] is not JArray devices || devices.Count == 0)
return null;
var exactDevice = devices.FirstOrDefault(d => string.Equals(
d?["serialNumber"]?.ToString()?.Trim(), normalizedSerial, StringComparison.OrdinalIgnoreCase));
if (exactDevice == null)
return null;
return new AutopilotRegistration
{
DeviceId = RegistrationText(exactDevice["id"]),
GroupTag = RegistrationText(exactDevice["groupTag"]),
PurchaseOrderId = RegistrationText(exactDevice["purchaseOrderIdentifier"]),
DisplayName = RegistrationText(exactDevice["displayName"]),
UserAssigned = RegistrationText(exactDevice["userPrincipalName"]) != null,
};
}
private static string? RegistrationText(JToken? token)
{
var value = token?.Type == JTokenType.String ? ((string?)token)?.Trim() : null;
if (string.IsNullOrEmpty(value))
return null;
return value!.Length > AutopilotDeviceValidator.MaxRegistrationFieldLength
? value.Substring(0, AutopilotDeviceValidator.MaxRegistrationFieldLength)
: value;
}
public static (bool Found, string NextUrl) ReadIdentityPage(string responseBody, string normalizedIdentifier)
{
var data = JsonConvert.DeserializeObject<JObject>(responseBody);
if (data?["value"] is JArray identities)
{
foreach (var identity in identities)
{
var type = identity?["importedDeviceIdentityType"]?.ToString();
var value = identity?["importedDeviceIdentifier"]?.ToString();
if (string.Equals(type, "manufacturerModelSerial", StringComparison.OrdinalIgnoreCase)
&& value != null
&& string.Equals(CorporateIdentifierValidator.NormalizeStoredIdentifier(value), normalizedIdentifier, StringComparison.Ordinal))
{
return (true, string.Empty);
}
}
}
return (false, data?["@odata.nextLink"]?.ToString() ?? string.Empty);
}
public static DeviceAssociationResult ParseAssociation(string responseBody, string normalizedSerial)
{
var notFound = new DeviceAssociationResult
{
IsValid = false,
SerialNumber = normalizedSerial,
ErrorMessage = $"Device with serial '{normalizedSerial}' is not associated with this tenant (device association)"
};
JObject? data;
try { data = JsonConvert.DeserializeObject<JObject>(responseBody); }
catch (JsonException) { return notFound; }
var devices = data?["value"] as JArray;
if (devices == null || devices.Count == 0)
return notFound;
var match = devices.FirstOrDefault(d => string.Equals(
d?["serialNumber"]?.ToString()?.Trim(), normalizedSerial, StringComparison.OrdinalIgnoreCase));
if (match == null)
return notFound;
return new DeviceAssociationResult
{
IsValid = true,
SerialNumber = normalizedSerial,
AssociationState = match["associationState"]?.ToString(),
DevicePreparationPolicyId = match["devicePreparationPolicyId"]?.ToString(),
PreAssociatedByUserPrincipalName = match["preassociatedByUserPrincipalName"]?.ToString(),
AssignedToUserPrincipalName = match["assignedToUserPrincipalName"]?.ToString(),
PreAssociationDateTime = ParseAssociationDate(match["preassociationDateTime"]),
AssociationDateTime = ParseAssociationDate(match["associationDateTime"]),
ManagedDeviceId = match["managedDeviceId"]?.ToString()
};
}
private static DateTime? ParseAssociationDate(JToken? token)
{
if (token == null || token.Type == JTokenType.Null) return null;
var s = token.ToString();
if (string.IsNullOrEmpty(s)) return null;
if (DateTime.TryParse(s, null, System.Globalization.DateTimeStyles.AdjustToUniversal | System.Globalization.DateTimeStyles.AssumeUniversal, out var dt))
return dt.Year <= 1 ? null : dt;
return null;
}
public static CloudPcValidationResult ParseCloudPc(string responseBody, string normalizedId)
{
var notFound = new CloudPcValidationResult
{
IsValid = false,
IntuneDeviceId = normalizedId,
ErrorMessage = $"Device '{normalizedId}' is not a Windows 365 Cloud PC in this tenant"
};
JObject? data;
try { data = JsonConvert.DeserializeObject<JObject>(responseBody); }
catch (JsonException) { return notFound; }
var cloudPcs = data?["value"] as JArray;
if (cloudPcs == null || cloudPcs.Count == 0)
return notFound;
var match = cloudPcs.FirstOrDefault(c => string.Equals(
c?["managedDeviceId"]?.ToString()?.Trim(), normalizedId, StringComparison.OrdinalIgnoreCase));
if (match == null)
return notFound;
return new CloudPcValidationResult
{
IsValid = true,
IntuneDeviceId = normalizedId,
CloudPcId = match["id"]?.ToString(),
ManagedDeviceName = match["managedDeviceName"]?.ToString(),
ServicePlanName = match["servicePlanName"]?.ToString()
};
}
private static readonly HashSet<string> LeavingManagementStates = new(StringComparer.OrdinalIgnoreCase)
{
"retirePending", "retireIssued", "wipePending", "wipeIssued", "deletePending",
};
public static IntuneDeviceBindingResult ParseManagedDevice(string responseBody, string normalizedId)
{
var notFound = new IntuneDeviceBindingResult
{
Outcome = IntuneDeviceBindingOutcome.NotFound,
IntuneDeviceId = normalizedId,
ErrorMessage = $"Device '{normalizedId}' is not an enrolled Intune device in this tenant"
};
JObject? device;
try { device = JsonConvert.DeserializeObject<JObject>(responseBody); }
catch (JsonException) { return notFound; }
var returnedId = device?["id"]?.ToString()?.Trim();
if (string.IsNullOrEmpty(returnedId) || !string.Equals(returnedId, normalizedId, StringComparison.OrdinalIgnoreCase))
return notFound;
var managementState = device?["managementState"]?.ToString();
var leaving = managementState != null && LeavingManagementStates.Contains(managementState);
return new IntuneDeviceBindingResult
{
Outcome = leaving ? IntuneDeviceBindingOutcome.NotManaged : IntuneDeviceBindingOutcome.Match,
IntuneDeviceId = normalizedId,
DeviceName = device?["deviceName"]?.ToString(),
AzureAdDeviceId = device?["azureADDeviceId"]?.ToString(),
ManagementState = managementState,
SerialNumber = NullIfEmpty(device?["serialNumber"]?.ToString()),
OwnerType = NullIfEmpty(device?["managedDeviceOwnerType"]?.ToString()),
EnrollmentType = NullIfEmpty(device?["deviceEnrollmentType"]?.ToString()),
AzureAdRegistered = device?["azureADRegistered"]?.Type == JTokenType.Boolean
? device["azureADRegistered"]!.Value<bool>()
: null,
EnrolledDateTime = ParseEnrolledDateTime(device?["enrolledDateTime"]?.ToString()),
ErrorMessage = leaving
? $"Device '{normalizedId}' is being removed from Intune management (state {managementState})"
: null
};
}
private static DateTimeOffset? ParseEnrolledDateTime(string? raw)
{
if (string.IsNullOrWhiteSpace(raw)) return null;
if (!DateTimeOffset.TryParse(raw, System.Globalization.CultureInfo.InvariantCulture,
System.Globalization.DateTimeStyles.AdjustToUniversal | System.Globalization.DateTimeStyles.AssumeUniversal, out var parsed))
return null;
return parsed.Year <= 1 ? null : parsed;
}
private static string? NullIfEmpty(string? value) => string.IsNullOrWhiteSpace(value) ? null : value;
public static (List<ScriptDisplayNameResolver.ScriptListItem> Scripts, string? NextUrl) ReadScriptPage(string body, bool withFileName)
{
var json = JObject.Parse(body);
var values = json["value"] as JArray ?? new JArray();
var scripts = new List<ScriptDisplayNameResolver.ScriptListItem>();
foreach (var item in values.OfType<JObject>())
{
var id = item["id"]?.ToString();
if (string.IsNullOrEmpty(id)) continue;
scripts.Add(new ScriptDisplayNameResolver.ScriptListItem(id!, item["displayName"]?.ToString(), withFileName ? item["fileName"]?.ToString() : null));
}
return (scripts, json["@odata.nextLink"]?.ToString());
}
public static string? ReadScriptDisplayName(string body) => JObject.Parse(body)["displayName"]?.ToString();
}
@@ -45,6 +45,24 @@ public class LiveStreamPrincipalTests
Assert.Equal(new string?[] { SignalRGroupHelper.UserId(TenantId, Upn) }, signalR.NegotiatedUserIds);
}
[Fact]
public async Task Negotiate_under_view_as_binds_the_sign_in_tenant_not_the_viewed_one()
{
// Removing a Global Admin cuts the connections bound to their sign-in tenant; a view-as tab must be among them.
var signalR = new FakeSignalRNotificationService();
var req = BuildRequest(new RequestContext
{
TenantId = OtherTenantId,
UserPrincipalName = OperatorUpn,
ViewAs = new ViewAsContext(TenantId, AutopilotMonitor.Shared.Constants.TenantRoles.Admin),
});
var response = await new SignalRNegotiateFunction(NullLogger<SignalRNegotiateFunction>.Instance, signalR).Negotiate(req);
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
Assert.Equal(new string?[] { SignalRGroupHelper.UserId(TenantId, OperatorUpn) }, signalR.NegotiatedUserIds);
}
[Fact]
public async Task Negotiate_without_a_principal_key_binds_no_user_id()
{
@@ -0,0 +1,144 @@
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Shared.Models;
using Newtonsoft.Json.Linq;
using Xunit;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// <c>tests/fixtures/local-admin-allow-list/cases.json</c> is the one definition of the allowed-list entry
/// grammar; the agent tests run its parse cases against the netstandard2.0 build, the portal runs the file
/// against <c>allowedAccounts.ts</c>. Plus the list-level write rules of
/// <see cref="TenantConfigValidation.ValidateLocalAdminAllowedAccounts"/>.
/// </summary>
public class LocalAdminAllowListParityTests
{
private static readonly Lazy<JObject> Fixture = new(() =>
JObject.Parse(File.ReadAllText(Path.Combine(FindRepoRoot(), "tests", "fixtures", "local-admin-allow-list", "cases.json"))));
public static IEnumerable<object[]> ParseEntries() => Fixture.Value["parse"]!.Select(c => new object[] { c.Value<string>("entry")! });
public static IEnumerable<object[]> WriteEntries() => Fixture.Value["write"]!.Select(c => new object[] { c.Value<string>("entry")! });
[Theory]
[MemberData(nameof(ParseEntries))]
public void Parse_matches_the_shared_case(string entry)
{
var c = Fixture.Value["parse"]!.First(x => x.Value<string>("entry") == entry);
var parsed = LocalAdminAllowList.TryParseEntry(entry, out var pattern, out var role);
if (c.Value<bool?>("ignored") == true)
{
Assert.False(parsed);
return;
}
Assert.True(parsed);
Assert.Equal(c.Value<string>("pattern"), pattern);
Assert.Equal(c.Value<string>("role") == "user" ? LocalAccountRole.StandardUser : LocalAccountRole.Any, role);
}
[Theory]
[MemberData(nameof(WriteEntries))]
public void New_entry_validation_matches_the_shared_case(string entry)
{
var c = Fixture.Value["write"]!.First(x => x.Value<string>("entry") == entry);
var error = LocalAdminAllowList.ValidateNewEntry(entry);
if (c.Value<bool>("valid"))
Assert.Null(error);
else
Assert.NotNull(error);
}
[Fact]
public void Shared_cases_are_present()
{
Assert.True(Fixture.Value["parse"]!.Count() >= 15, "cases.json lost parse cases.");
Assert.True(Fixture.Value["write"]!.Count() >= 25, "cases.json lost write cases.");
}
[Fact]
public void Builtin_catalog_keeps_the_four_rid_accounts_and_the_standard_user_system_accounts()
{
var rid = LocalAdminAllowList.BuiltIns.Where(b => b.Match == LocalAdminBuiltInMatch.Rid).ToDictionary(b => b.Rid!.Value, b => b.Role);
Assert.Equal(LocalAccountRole.Any, rid[500]);
Assert.Equal(LocalAccountRole.StandardUser, rid[501]);
Assert.Equal(LocalAccountRole.StandardUser, rid[503]);
Assert.Equal(LocalAccountRole.StandardUser, rid[504]);
string RoleOf(string name) => LocalAdminAllowList.BuiltIns
.Single(b => b.Match == LocalAdminBuiltInMatch.AccountName && b.Name == name).Role.ToString();
Assert.Equal("StandardUser", RoleOf("WsiAccount"));
Assert.Equal("StandardUser", RoleOf("kioskUser0"));
Assert.Equal("StandardUser", RoleOf("Administrator"));
Assert.Equal("Any", RoleOf("defaultuser0"));
}
// ── list-level write rules ───────────────────────────────────────────────
[Theory]
[InlineData(null, "[\"adm-*\",\"kiosk|user\"]")]
[InlineData("[\"adm-*\"]", "[\"adm-*\",\"kiosk|user\"]")]
[InlineData("[\"adm-*\"]", "[]")]
[InlineData("[\"adm-*\"]", "")]
[InlineData("[\"*\"]", "[\"*\"]")]
public void Valid_or_unchanged_lists_pass(string? stored, string candidate)
{
Assert.Null(TenantConfigValidation.ValidateLocalAdminAllowedAccounts(candidate, stored));
}
[Fact]
public void A_stored_entry_is_never_rechecked_when_another_entry_is_added()
{
// Lists written before the grammar existed (a bare "*", an Entra SID) stay saveable.
Assert.Null(TenantConfigValidation.ValidateLocalAdminAllowedAccounts(
"[\"*\",\"S-1-12-1-1-2-3-4\",\"WsiAccount\",\"kiosk|user\"]",
"[\"*\",\"S-1-12-1-1-2-3-4\",\"WsiAccount\"]"));
}
[Theory]
[InlineData("{\"a\":1}", "JSON array")]
[InlineData("[1,2]", "JSON array")]
[InlineData("not json", "JSON array")]
[InlineData("[\"*\"]", "too broad")]
[InlineData("[\"kiosk|admin\"]", "is not valid")]
[InlineData("[\"kiosk\",\"kiosk|user\"]", "listed twice")]
[InlineData("[\"Kiosk\",\"kiosk\"]", "listed twice")]
public void Invalid_new_entries_are_rejected(string candidate, string expected)
{
var error = TenantConfigValidation.ValidateLocalAdminAllowedAccounts(candidate, null);
Assert.NotNull(error);
Assert.Contains(expected, error);
}
[Fact]
public void A_new_entry_repeating_a_stored_pattern_is_rejected()
{
var error = TenantConfigValidation.ValidateLocalAdminAllowedAccounts("[\"WsiAccount\",\"WsiAccount|user\"]", "[\"WsiAccount\"]");
Assert.NotNull(error);
Assert.Contains("listed twice", error);
}
[Fact]
public void The_entry_count_is_capped()
{
var entries = Enumerable.Range(0, LocalAdminAllowList.MaxEntries + 1).Select(i => $"\"svc{i:D3}\"");
var error = TenantConfigValidation.ValidateLocalAdminAllowedAccounts("[" + string.Join(",", entries) + "]", null);
Assert.NotNull(error);
Assert.Contains($"at most {LocalAdminAllowList.MaxEntries}", error);
}
private static string FindRepoRoot()
{
var dir = AppContext.BaseDirectory;
while (dir != null && !File.Exists(Path.Combine(dir, "AutopilotMonitor.sln")))
dir = Directory.GetParent(dir)?.FullName;
return dir ?? throw new DirectoryNotFoundException("Could not locate repo root (AutopilotMonitor.sln).");
}
}
@@ -96,7 +96,7 @@ public class McpOrganizationUsageAggregationTests
Row(Member, "20260903", 7), // read window past today (range only)
};
var quota = McpUsageMetricsFunction.BuildOrganizationQuota(
var quota = McpQuotaNodes.BuildOrganizationQuota(
rows, new McpQuotaService.TenantPlanLimits("pro", 1500, 15000), "20260902", "20260901");
Assert.Equal("pro", quota.TenantPlan);
@@ -114,7 +114,7 @@ public class McpOrganizationUsageAggregationTests
public void OrganizationQuota_PurchasedSlots_CarryTheBreakdown()
{
// 3 000 + 3 × 900 = 5 700 — the limits arrive grown; the slot fields let the page show the sum.
var quota = McpUsageMetricsFunction.BuildOrganizationQuota(
var quota = McpQuotaNodes.BuildOrganizationQuota(
new[] { Row(Member, "20260902", 3) },
new McpQuotaService.TenantPlanLimits("pro", 5700, 114000, PurchasedDelegatedSlots: 3, SlotTenantDailyLimit: 900, SlotTenantMonthlyLimit: 18000),
"20260902", "20260901");
@@ -145,7 +145,7 @@ public class McpOrganizationUsageAggregationTests
[Fact]
public void OrganizationQuota_LiftedWindows_StillReportTheCounters()
{
var quota = McpUsageMetricsFunction.BuildOrganizationQuota(
var quota = McpQuotaNodes.BuildOrganizationQuota(
new[] { Row(Member, "20260902", 3) }, new McpQuotaService.TenantPlanLimits("pro", 0, 0), "20260902", "20260901");
Assert.Equal(0, quota.DailyLimit);
@@ -96,6 +96,47 @@ public class McpQuotaEnforcementMiddlewareTests
Assert.EndsWith("Resets at 2026-09-03T00:00:00Z.", body.Error);
}
// ── ExceededAlertKey — one McpQuotaExceeded per account or organization, window and period ──
private const string OidA = "00000000-0000-0000-0000-00000000000a";
private const string OidB = "00000000-0000-0000-0000-00000000000b";
private static McpQuotaDecision UserDailyBlock(DateTime now)
=> McpQuotaService.BuildDecision(new McpPlanLimits("community", 50, 250, "community", 100, 250),
dailyUsed: 50, monthlyUsed: 60, tenantDailyUsed: 60, tenantMonthlyUsed: 60, now);
[Fact]
public void AlertKey_AccountWindow_IsPerAccountAndDay()
{
var key = McpQuotaEnforcementMiddleware.ExceededAlertKey(OidA, Home, UserDailyBlock(Now));
Assert.Equal($"user:daily:{OidA}:20260903", key); // the period is the reset date
Assert.NotEqual(key, McpQuotaEnforcementMiddleware.ExceededAlertKey(OidB, Home, UserDailyBlock(Now)));
Assert.NotEqual(key, McpQuotaEnforcementMiddleware.ExceededAlertKey(OidA, Home, UserDailyBlock(Now.AddDays(1))));
}
[Fact]
public void AlertKey_OrganizationWindow_IsSharedByAllMembers()
{
// The organization's window is one budget: the refusal of any member raises one event for it.
var tenantBlock = Blocked("community");
var a = McpQuotaEnforcementMiddleware.ExceededAlertKey(OidA, Home.ToUpperInvariant(), tenantBlock);
var b = McpQuotaEnforcementMiddleware.ExceededAlertKey(OidB, Home, tenantBlock);
Assert.Equal(a, b);
Assert.Equal($"tenant:daily:{Home}:20260903", a);
}
[Fact]
public void AlertKey_MonthlyWindow_IsItsOwnKey()
{
var monthly = McpQuotaService.BuildDecision(new McpPlanLimits("community", 50, 250, "community", 100, 250),
dailyUsed: 10, monthlyUsed: 250, tenantDailyUsed: 10, tenantMonthlyUsed: 10, Now);
Assert.Equal($"user:monthly:{OidA}:20261001", McpQuotaEnforcementMiddleware.ExceededAlertKey(OidA, Home, monthly));
}
[Fact]
public void UserLevelBlock_ReportsTheUserWindow()
{
@@ -130,7 +130,8 @@ public class McpQuotaServiceTests
Func<string?, TenantEdition>? editionResolver = null,
Func<string?, string?>? tenantPlanOverrideResolver = null,
Func<string?, int>? purchasedSlotsResolver = null,
Func<string?, EditionResolution>? resolutionResolver = null)
Func<string?, EditionResolution>? resolutionResolver = null,
TestTimeProvider? time = null)
{
var adminRepo = new Mock<IAdminRepository>();
adminRepo.Setup(r => r.GetMcpUserAsync(It.IsAny<string>()))
@@ -162,9 +163,8 @@ public class McpQuotaServiceTests
mcpUserService,
adminConfigService,
entitlements,
cache,
NullLogger<McpQuotaService>.Instance,
new TestTimeProvider(Now));
time ?? new TestTimeProvider(Now));
}
private static Mock<IUserUsageRepository> UsageRepo(params (string Date, long Count)[] rows)
@@ -197,7 +197,7 @@ public class McpQuotaServiceTests
// 100 requests today (catalog Community fallback: 100/day) → blocked.
var svc = Build(UsageRepo(("20260707", 100)));
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.False(d.Allowed);
Assert.Equal("community", d.Plan);
@@ -210,7 +210,7 @@ public class McpQuotaServiceTests
{
var svc = Build(UsageRepo(("20260707", 100)), edition: TenantEdition.Pro);
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.True(d.Allowed);
Assert.Equal("pro", d.Plan);
@@ -224,7 +224,7 @@ public class McpQuotaServiceTests
// 2990 across the month + 20 today = 3010 ≥ 3000 monthly Community limit.
var svc = Build(UsageRepo(("20260701", 1500), ("20260703", 1490), ("20260707", 20)));
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.False(d.Allowed);
Assert.Equal("monthly", d.Scope);
@@ -238,7 +238,7 @@ public class McpQuotaServiceTests
var json = """[{"name":"community","dailyRequestLimit":5,"monthlyRequestLimit":50,"description":""}]""";
var svc = Build(UsageRepo(("20260707", 5)), planDefinitionsJson: json);
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.False(d.Allowed);
Assert.Equal(5, d.DailyLimit);
@@ -251,7 +251,7 @@ public class McpQuotaServiceTests
var json = """[{"name":"power","dailyRequestLimit":10000,"monthlyRequestLimit":100000,"description":""}]""";
var svc = Build(UsageRepo(("20260707", 500)), planDefinitionsJson: json, mcpUserPlanOverride: "power");
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.True(d.Allowed);
Assert.Equal("power", d.Plan);
@@ -266,7 +266,7 @@ public class McpQuotaServiceTests
var json = """[{"name":"power","dailyRequestLimit":10000,"monthlyRequestLimit":100000,"description":""}]""";
var svc = Build(UsageRepo(("20260707", 500)), planDefinitionsJson: json, mcpUserPlanOverride: "power", bound: false);
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.False(d.Allowed);
Assert.Equal("community", d.Plan);
@@ -279,7 +279,7 @@ public class McpQuotaServiceTests
// Override names a plan that exists nowhere → Community fallback limits.
var svc = Build(UsageRepo(("20260707", 100)), mcpUserPlanOverride: "no-such-plan");
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.False(d.Allowed);
Assert.Equal("no-such-plan", d.Plan);
@@ -300,7 +300,7 @@ public class McpQuotaServiceTests
var svc = Build(UsageRepo(("20260707", 1200)), planDefinitionsJson: MspPlanJson,
edition: TenantEdition.Pro, tenantPlanOverrideResolver: _ => "msp");
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.True(d.Allowed);
Assert.Equal("msp", d.Plan);
@@ -318,7 +318,7 @@ public class McpQuotaServiceTests
var svc = Build(UsageRepo(("20260707", 2000)), planDefinitionsJson: json,
edition: TenantEdition.Pro, mcpUserPlanOverride: "power", tenantPlanOverrideResolver: _ => "msp");
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.True(d.Allowed);
Assert.Equal("power", d.Plan);
@@ -335,7 +335,7 @@ public class McpQuotaServiceTests
// falls back fail-closed (user: Community catalog; tenant: the EDITION's catalog windows).
var svc = Build(UsageRepo(("20260707", 100)), edition: TenantEdition.Pro, tenantPlanOverrideResolver: _ => "msp");
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.False(d.Allowed);
Assert.Equal("msp", d.Plan);
@@ -351,7 +351,7 @@ public class McpQuotaServiceTests
var svc = Build(UsageRepo(("20260707", 1)), planDefinitionsJson: MspPlanJson,
edition: TenantEdition.Pro, tenantPlanOverrideResolver: _ => "msp", purchasedSlotsResolver: _ => 2);
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.Equal("msp", d.Plan);
Assert.Equal(2100, d.DailyLimit); // 1500 + 2 × 300
@@ -367,8 +367,8 @@ public class McpQuotaServiceTests
.ThrowsAsync(new InvalidOperationException("storage down"));
var svc = Build(repo);
var first = await svc.CheckAsync(Oid, Upn, TenantId);
var second = await svc.CheckAsync(Oid, Upn, TenantId);
var first = await svc.AdmitAsync(Oid, Upn, TenantId);
var second = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.True(first.Allowed);
Assert.True(second.Allowed);
@@ -383,69 +383,144 @@ public class McpQuotaServiceTests
var repo = UsageRepo(("20260707", 1));
var svc = Build(repo);
await svc.CheckAsync(Oid, Upn, TenantId);
await svc.CheckAsync(Oid, Upn, TenantId);
await svc.AdmitAsync(Oid, Upn, TenantId);
await svc.AdmitAsync(Oid, Upn, TenantId);
repo.Verify(r => r.GetUsageByUserAsync(It.IsAny<string>(), It.IsAny<string?>(), It.IsAny<string?>()),
Times.Once);
}
// ── Soft-boundary contract (Codex finding 2026-07-07) ─────────────────────────
// The quota is DELIBERATELY soft: the per-user decision is cached for 60s, so an allowed
// decision keeps admitting requests inside that window even after the fire-and-forget
// increments push the stored counters past the limit. Overshoot is bounded (~TTL × request
// rate per instance) — the same posture as the sliding-window rate limiter. These tests PIN
// that contract; if strict limit+1 blocking is ever wanted, the decision cache must be
// reworked and these tests consciously rewritten.
// ── Boundary: exact per instance, soft across instances ──────────────────────
// The counters are read from storage at most every 60 s, and every request the instance admits is
// counted on them at once — so one instance blocks exactly at the limit, also when a tool call fans out
// into parallel requests. What stays soft is the part of OTHER instances: they learn of these requests
// only with their own next read.
[Fact]
public async Task Check_SoftBoundary_CachedAllowedDecision_KeepsAdmitting_WithinTtl()
public async Task Check_SequentialRequests_BlockExactlyAtTheLimit_WithoutRereading()
{
// First read: one request below the daily limit → allowed, decision cached.
var repo = UsageRepo(("20260707", 99));
// Community catalog: 100/day. 98 served before → the 99th and 100th pass, the 101st is refused.
var repo = UsageRepo(("20260707", 98));
var svc = Build(repo);
var first = await svc.CheckAsync(Oid, Upn, TenantId);
Assert.True(first.Allowed);
var ninetyNinth = await svc.AdmitAsync(Oid, Upn, TenantId);
var hundredth = await svc.AdmitAsync(Oid, Upn, TenantId);
var hundredFirst = await svc.AdmitAsync(Oid, Upn, TenantId);
// The async increments land: stored counters are now OVER the limit — but the cached
// allowed decision keeps admitting within the TTL, without re-reading storage.
repo.Setup(r => r.GetUsageByUserAsync(Oid, It.IsAny<string?>(), It.IsAny<string?>()))
.ReturnsAsync(new List<UserUsageRecord>
{
new() { UserId = Oid, Date = "20260707", RequestCount = 150 }
});
var second = await svc.CheckAsync(Oid, Upn, TenantId);
Assert.True(second.Allowed, "soft boundary: cached allowed decision persists within the TTL");
repo.Verify(r => r.GetUsageByUserAsync(It.IsAny<string>(), It.IsAny<string?>(), It.IsAny<string?>()),
Times.Once);
Assert.True(ninetyNinth.Allowed);
Assert.Equal(98, ninetyNinth.DailyUsed); // the decision reports the count BEFORE this request
Assert.True(hundredth.Allowed);
Assert.False(hundredFirst.Allowed);
Assert.Equal("daily", hundredFirst.Scope);
Assert.Equal(100, hundredFirst.DailyUsed);
repo.Verify(r => r.GetUsageByUserAsync(It.IsAny<string>(), It.IsAny<string?>(), It.IsAny<string?>()), Times.Once);
}
[Fact]
public async Task Check_SoftBoundary_AfterCacheEviction_OverLimitCounters_Block()
public async Task ReadState_NeverCounts_OnlyAdmitDoes()
{
// Same scenario as above, but once the cached decision is gone (TTL expiry — simulated
// via eviction), the next check reads the over-limit counters and blocks.
var cache = new MemoryCache(new MemoryCacheOptions());
// The usage page shows the quota; viewing it is not an MCP request. Three reads leave the count at 99,
// so the next real request still passes and only the one after it is refused.
var svc = Build(UsageRepo(("20260707", 99)));
for (var i = 0; i < 3; i++)
{
var view = await svc.ReadStateAsync(Oid, Upn, TenantId);
Assert.True(view.Allowed);
Assert.Equal(99, view.DailyUsed);
}
Assert.True((await svc.AdmitAsync(Oid, Upn, TenantId)).Allowed);
Assert.False((await svc.AdmitAsync(Oid, Upn, TenantId)).Allowed);
Assert.Equal(100, (await svc.ReadStateAsync(Oid, Upn, TenantId)).DailyUsed);
}
[Fact]
public async Task Check_ParallelBurst_AdmitsExactlyUpToTheLimit()
{
// A tool call's parallel requests must not all pass on the same reading: 95 used, 20 at once → 5 pass.
var repo = UsageRepo(("20260707", 95));
var svc = Build(repo);
var decisions = await Task.WhenAll(Enumerable.Range(0, 20).Select(_ => Task.Run(() => svc.AdmitAsync(Oid, Upn, TenantId))));
Assert.Equal(5, decisions.Count(d => d.Allowed));
// Single-flight: concurrent first checks share one counter, so storage was read once.
repo.Verify(r => r.GetUsageByUserAsync(It.IsAny<string>(), It.IsAny<string?>(), It.IsAny<string?>()), Times.Once);
}
[Fact]
public async Task Check_TenantWindow_CountsEveryMemberOnThisInstance()
{
// Community organization window 300/day, 298 used by the organization. Member A and member B each get one
// request through; the next one of A is refused at the organization level although A's own window is wide.
var repo = UsageRepo(new[] { ("20260707", 1L) }, tenantRows: new[] { ("20260707", 298L) });
repo.Setup(r => r.GetUsageByUserAsync(OtherOid, It.IsAny<string?>(), It.IsAny<string?>()))
.ReturnsAsync(new List<UserUsageRecord> { new() { UserId = OtherOid, Date = "20260707", RequestCount = 1 } });
var svc = Build(repo);
Assert.True((await svc.AdmitAsync(Oid, Upn, TenantId)).Allowed);
Assert.True((await svc.AdmitAsync(OtherOid, "bob@contoso.com", TenantId)).Allowed);
var third = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.False(third.Allowed);
Assert.Equal("tenant", third.Level);
Assert.Equal(300, third.TenantDailyUsed);
repo.Verify(r => r.GetTenantUsageAsync(TenantId, It.IsAny<string?>(), It.IsAny<string?>()), Times.Once);
}
[Fact]
public async Task Check_SecondInstance_LearnsOfTheFirstOnlyWithItsOwnRead()
{
// The part that stays soft, pinned: two instances share storage, not memory. Storage still says 99 (the
// increments of instance A are on their way), so instance B admits one more on its own fresh reading.
var repo = UsageRepo(("20260707", 99));
var svc = Build(repo, cache: cache);
var instanceA = Build(repo);
var instanceB = Build(repo);
Assert.True((await svc.CheckAsync(Oid, Upn, TenantId)).Allowed);
Assert.True((await instanceA.AdmitAsync(Oid, Upn, TenantId)).Allowed);
Assert.False((await instanceA.AdmitAsync(Oid, Upn, TenantId)).Allowed);
Assert.True((await instanceB.AdmitAsync(Oid, Upn, TenantId)).Allowed);
Assert.False((await instanceB.AdmitAsync(Oid, Upn, TenantId)).Allowed);
}
[Fact]
public async Task Check_CounterExpiry_RereadsStorage()
{
// After 60 s the counter is read again, so increments of other instances count from then on.
var time = new TestTimeProvider(Now);
var repo = UsageRepo(("20260707", 10));
var svc = Build(repo, time: time);
Assert.True((await svc.AdmitAsync(Oid, Upn, TenantId)).Allowed);
repo.Setup(r => r.GetUsageByUserAsync(Oid, It.IsAny<string?>(), It.IsAny<string?>()))
.ReturnsAsync(new List<UserUsageRecord>
{
new() { UserId = Oid, Date = "20260707", RequestCount = 150 }
});
cache.Remove(McpQuotaService.UserCacheKey(Oid)); // stands in for the 60s TTL elapsing
.ReturnsAsync(new List<UserUsageRecord> { new() { UserId = Oid, Date = "20260707", RequestCount = 150 } });
time.SetUtcNow(Now.AddSeconds(61));
var decision = await svc.CheckAsync(Oid, Upn, TenantId);
var decision = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.False(decision.Allowed);
Assert.Equal("daily", decision.Scope);
Assert.Equal(150, decision.DailyUsed);
repo.Verify(r => r.GetUsageByUserAsync(It.IsAny<string>(), It.IsAny<string?>(), It.IsAny<string?>()), Times.Exactly(2));
}
[Fact]
public async Task Check_Midnight_StartsAFreshCounter_InsideTheSixtySeconds()
{
// A counter read at 23:59:50 never answers a check at 00:00:05: the day is part of the key.
var lateEvening = new DateTime(2026, 7, 7, 23, 59, 50, DateTimeKind.Utc);
var time = new TestTimeProvider(lateEvening);
var repo = UsageRepo(("20260707", 100));
var svc = Build(repo, time: time);
Assert.False((await svc.AdmitAsync(Oid, Upn, TenantId)).Allowed);
time.SetUtcNow(lateEvening.AddSeconds(15));
var afterMidnight = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.True(afterMidnight.Allowed);
Assert.Equal(0, afterMidnight.DailyUsed);
Assert.Equal(new DateTime(2026, 7, 9, 0, 0, 0, DateTimeKind.Utc), afterMidnight.ResetUtc);
}
// ── Tenant (organization-wide) quota ─────────────────────────────────────────
@@ -456,7 +531,7 @@ public class McpQuotaServiceTests
// Community catalog tenant window = 300/day; other members burned it, this caller made 5 requests.
var svc = Build(UsageRepo(new[] { ("20260707", 5L) }, tenantRows: new[] { ("20260707", 300L) }));
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.False(d.Allowed);
Assert.Equal("tenant", d.Level);
@@ -474,7 +549,7 @@ public class McpQuotaServiceTests
new[] { ("20260707", 1L) },
tenantRows: new[] { ("20260701", 4000L), ("20260703", 4990L), ("20260707", 10L) }));
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.False(d.Allowed);
Assert.Equal("tenant", d.Level);
@@ -492,7 +567,7 @@ public class McpQuotaServiceTests
var svc = Build(UsageRepo(new[] { ("20260707", 1L) }, tenantRows: new[] { ("20260707", 10L) }),
planDefinitionsJson: json, mcpUserPlanOverride: "power");
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.False(d.Allowed);
Assert.Equal("power", d.Plan);
@@ -509,7 +584,7 @@ public class McpQuotaServiceTests
var json = """[{"name":"pro","dailyRequestLimit":5,"monthlyRequestLimit":50,"description":""}]""";
var svc = Build(UsageRepo(("20260707", 1)), planDefinitionsJson: json, edition: TenantEdition.Pro);
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.True(d.Allowed);
Assert.Equal(5, d.DailyLimit);
@@ -524,7 +599,7 @@ public class McpQuotaServiceTests
var repo = UsageRepo(new[] { ("20260707", 1L) }, tenantRows: new[] { ("20260707", 999999L) });
var svc = Build(repo, planDefinitionsJson: json);
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.True(d.Allowed);
Assert.Equal(0, d.TenantDailyLimit);
@@ -537,7 +612,7 @@ public class McpQuotaServiceTests
var repo = UsageRepo(("20260707", 1));
var svc = Build(repo);
var d = await svc.CheckAsync(Oid, Upn, tenantId: null);
var d = await svc.AdmitAsync(Oid, Upn, tenantId: null);
Assert.True(d.Allowed);
repo.Verify(r => r.GetTenantUsageAsync(It.IsAny<string>(), It.IsAny<string?>(), It.IsAny<string?>()), Times.Never);
@@ -551,8 +626,8 @@ public class McpQuotaServiceTests
.ThrowsAsync(new InvalidOperationException("storage down"));
var svc = Build(repo);
var first = await svc.CheckAsync(Oid, Upn, TenantId);
var second = await svc.CheckAsync(Oid, Upn, TenantId);
var first = await svc.AdmitAsync(Oid, Upn, TenantId);
var second = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.True(first.Allowed);
Assert.True(second.Allowed);
@@ -573,7 +648,7 @@ public class McpQuotaServiceTests
// Pro home with 3 purchased slots: 1000 + 3 × 300 per account, 3000 + 3 × 900 for the organization.
var svc = Build(UsageRepo(("20260707", 1)), edition: TenantEdition.Pro, purchasedSlotsResolver: _ => 3);
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.Equal(1900, d.DailyLimit);
Assert.Equal(38000, d.MonthlyLimit);
@@ -592,7 +667,7 @@ public class McpQuotaServiceTests
// A Pro tenant on its two included slots (purchased = 0) keeps the plain Pro windows.
var svc = Build(UsageRepo(("20260707", 1)), edition: TenantEdition.Pro, purchasedSlotsResolver: _ => 0);
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.Equal(1000, d.DailyLimit);
Assert.Equal(3000, d.TenantDailyLimit);
@@ -607,7 +682,7 @@ public class McpQuotaServiceTests
var conferred = new EditionResolution(TenantEdition.Pro, EditionSource.Msp, OwnPro: false);
var svc = Build(UsageRepo(("20260707", 1)), resolutionResolver: _ => conferred, purchasedSlotsResolver: _ => 3);
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.Equal("pro", d.Plan);
Assert.Equal(1000, d.DailyLimit);
@@ -625,7 +700,7 @@ public class McpQuotaServiceTests
var svc = Build(UsageRepo(("20260707", 1)), planDefinitionsJson: json, edition: TenantEdition.Pro,
mcpUserPlanOverride: "power", purchasedSlotsResolver: _ => 2);
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.Equal("power", d.Plan);
Assert.Equal(10600, d.DailyLimit);
@@ -639,7 +714,7 @@ public class McpQuotaServiceTests
var json = """[{"name":"pro","dailyRequestLimit":1000,"monthlyRequestLimit":20000,"slotDailyRequestLimit":0,"slotMonthlyRequestLimit":0,"slotTenantDailyRequestLimit":0,"slotTenantMonthlyRequestLimit":0,"description":""}]""";
var svc = Build(UsageRepo(("20260707", 1)), planDefinitionsJson: json, edition: TenantEdition.Pro, purchasedSlotsResolver: _ => 5);
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.Equal(1000, d.DailyLimit);
Assert.Equal(3000, d.TenantDailyLimit);
@@ -653,7 +728,7 @@ public class McpQuotaServiceTests
var json = """[{"name":"pro","dailyRequestLimit":1000,"monthlyRequestLimit":20000,"slotDailyRequestLimit":50,"slotMonthlyRequestLimit":500,"slotTenantDailyRequestLimit":100,"slotTenantMonthlyRequestLimit":1000,"description":""}]""";
var svc = Build(UsageRepo(("20260707", 1)), planDefinitionsJson: json, edition: TenantEdition.Pro, purchasedSlotsResolver: _ => 2);
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.Equal(1100, d.DailyLimit);
Assert.Equal(21000, d.MonthlyLimit);
@@ -668,7 +743,7 @@ public class McpQuotaServiceTests
var json = """[{"name":"pro","dailyRequestLimit":1000,"monthlyRequestLimit":20000,"description":""}]""";
var svc = Build(UsageRepo(("20260707", 1)), planDefinitionsJson: json, edition: TenantEdition.Pro, purchasedSlotsResolver: _ => 1);
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.Equal(1300, d.DailyLimit);
Assert.Equal(3900, d.TenantDailyLimit);
@@ -682,7 +757,7 @@ public class McpQuotaServiceTests
var json = """[{"name":"pro","dailyRequestLimit":0,"monthlyRequestLimit":20000,"tenantDailyRequestLimit":0,"tenantMonthlyRequestLimit":60000,"description":""}]""";
var svc = Build(UsageRepo(("20260707", 30000)), planDefinitionsJson: json, edition: TenantEdition.Pro, purchasedSlotsResolver: _ => 4);
var d = await svc.CheckAsync(Oid, Upn, TenantId);
var d = await svc.AdmitAsync(Oid, Upn, TenantId);
Assert.True(d.Allowed);
Assert.Equal(0, d.DailyLimit);
@@ -705,10 +780,10 @@ public class McpQuotaServiceTests
{
// Pro 1000 + 1 × 300 = 1300: the 1300th request of the day is the first blocked one.
var below = Build(UsageRepo(("20260707", 1299)), edition: TenantEdition.Pro, purchasedSlotsResolver: _ => 1);
Assert.True((await below.CheckAsync(Oid, Upn, TenantId)).Allowed);
Assert.True((await below.AdmitAsync(Oid, Upn, TenantId)).Allowed);
var at = Build(UsageRepo(("20260707", 1300)), edition: TenantEdition.Pro, purchasedSlotsResolver: _ => 1);
var d = await at.CheckAsync(Oid, Upn, TenantId);
var d = await at.AdmitAsync(Oid, Upn, TenantId);
Assert.False(d.Allowed);
Assert.Equal("daily", d.Scope);
Assert.Equal("user", d.Level);
@@ -726,8 +801,8 @@ public class McpQuotaServiceTests
.ReturnsAsync(new List<UserUsageRecord>());
var svc = Build(repo);
await svc.CheckAsync(Oid, Upn, TenantId);
await svc.CheckAsync(OtherOid, "bob@contoso.com", TenantId);
await svc.AdmitAsync(Oid, Upn, TenantId);
await svc.AdmitAsync(OtherOid, "bob@contoso.com", TenantId);
repo.Verify(r => r.GetTenantUsageAsync(TenantId, It.IsAny<string?>(), It.IsAny<string?>()), Times.Once);
repo.Verify(r => r.GetUsageByUserAsync(It.IsAny<string>(), It.IsAny<string?>(), It.IsAny<string?>()), Times.Exactly(2));
@@ -0,0 +1,323 @@
using AutopilotMonitor.Functions.Services;
using AutopilotMonitor.Shared.DataAccess;
using AutopilotMonitor.Shared.Models;
using Microsoft.Extensions.Caching.Memory;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
using Xunit;
using static AutopilotMonitor.Functions.Services.McpUsageOverviewService;
using static AutopilotMonitor.Functions.Services.McpUsageTelemetryQueries;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// The pure fold behind GET global/metrics/mcp-usage/overview: which numbers come from the quota counters and
/// which from the telemetry, how platform admins drop out (but never out of a tenant's real organization
/// windows), what a call costs, MCP-only tools, the daily trend and the per-minute ranking.
/// </summary>
public class McpUsageOverviewAssemblyTests
{
private const string TenantA = "aaaaaaaa-0000-0000-0000-00000000000a";
private const string TenantB = "bbbbbbbb-0000-0000-0000-00000000000b";
private const string Alice = "alice@contoso.com";
private const string App = "app:11111111-2222-3333-4444-555555555555";
private const string Operator = "ops@fabrikam.com";
private const string Bob = "bob@fabrikam.com";
private const string Carol = "carol@contoso.com";
// Window 3 days (Nov 3–5); the month started Nov 1, so Nov 1 rows count for the quota, not for the window.
private static readonly Dates ThreeDays = new("20261103", "20261105", "20261101");
private static readonly DateTime At = new(2026, 11, 5, 10, 0, 0, DateTimeKind.Utc);
private static TenantUsageRecord Counter(string tenant, string oid, string upn, string day, long requests)
=> new() { TenantId = tenant, UserId = oid, UserPrincipalName = upn, Date = day, RequestCount = requests, LastRequestAt = At };
private static readonly TenantUsageRecord[] Counters =
{
Counter(TenantA, "oid-alice", Alice, "20261101", 10),
Counter(TenantA, "oid-alice", Alice, "20261104", 20),
Counter(TenantA, "oid-alice", Alice, "20261105", 30),
Counter(TenantA, "oid-app", App, "20261105", 5),
Counter(TenantA, "oid-ops", Operator, "20261105", 100),
Counter(TenantB, "oid-bob", Bob, "20261103", 7),
};
private static CallRow Call(string day, string tool, string tenant, string principal, long calls, long served, long requests, string role)
=> new(day, tool, tenant, principal, calls, served, requests, At, role);
private static readonly CallRow[] Calls =
{
Call("20261104", "get_session_summary", TenantA, Alice, 2, 2, 10, "Admin"),
Call("20261105", "search_events", TenantA, Alice, 1, 1, 14, "Admin"),
Call("20261105", "get_session_events", TenantA, Alice, 3, 3, 3, "Admin"),
Call("20261105", "list_tenants", TenantA, Alice, 1, 1, 1, "Admin"),
Call("20261105", "get_session_summary", TenantA, App, 1, 1, 5, "Viewer"),
Call("20261105", "query_table", TenantA, Operator, 50, 50, 50, "GlobalAdmin"),
Call("20261103", "search_sessions", TenantB, Bob, 2, 2, 7, "Admin"),
Call("20261105", "get_time_attribution", TenantA, Carol, 4, 0, 0, "Admin"),
};
private static McpQuotaDecision State(string plan, int daily, int monthly, long dailyUsed, long monthlyUsed)
=> new() { Allowed = true, Plan = plan, DailyLimit = daily, MonthlyLimit = monthly, DailyUsed = dailyUsed, MonthlyUsed = monthlyUsed };
private static TelemetryResult Telemetry(bool available = true) => !available
? new TelemetryResult(false, false, false, new(), new(), new(), new(), new(), new(), new ServerFacts(null, null))
: new TelemetryResult(
RequestsAvailable: true, McpLogAvailable: true, Partial: false,
Calls: Calls.ToList(),
Routes: new()
{
new("get_session_summary", "GET sessions/{id}/events", 3),
new("get_session_summary", "GET sessions/{id}", 3),
},
Refusals: new()
{
new(RefusalQuota, "20261105", TenantA, Alice, "user", "daily", "community", 3, At, At.AddSeconds(9), 50, 50),
new(RefusalMinute, "20261103", TenantB, Bob, "", "", "", 2, At, At, 120, 120),
},
Peaks: new()
{
new(PeakCalls, TenantA, Alice, 12, At),
new(PeakRequests, TenantA, Alice, 40, At),
new(PeakRequests, TenantB, Bob, 120, At),
new(PeakCalls, TenantB, Bob, 5, At),
},
ToolQuality: new()
{
new("get_session_summary", 3, 0, 0, 0, 600, 19000.4),
new("search_docs", 4, 1, 0, 0, 80, 5000),
},
McpRefusals: new() { new(Alice, 7, At) },
ServerFacts: new ServerFacts(new DateTime(2026, 11, 4, 1, 0, 0, DateTimeKind.Utc), 60));
private static GetGlobalMcpUsageOverviewResponse Overview(bool includePlatformAdmins = false, bool telemetry = true)
{
var result = Telemetry(telemetry);
var facts = new Dictionary<(string Tenant, string Principal), AccountFacts>
{
[(TenantA, Alice)] = new("oid-alice", null, State("community", 50, 250, 30, 60)),
[(TenantA, App)] = new("oid-app", null, State("community", 50, 250, 5, 5)),
[(TenantA, Operator)] = new("oid-ops", "GlobalAdmin", State("community", 50, 250, 100, 100)),
[(TenantB, Bob)] = new("oid-bob", null, State("pro", 500, 6000, 0, 7)),
};
var limits = new Dictionary<string, McpQuotaService.TenantPlanLimits>
{
[TenantA] = new("community", 100, 250),
[TenantB] = new("pro", 1500, 15000),
};
// TenantB has no readable configuration: no name.
var names = new Dictionary<string, string> { [TenantA] = "contoso.com" };
var minute = new Dictionary<(string Tenant, string Principal), int> { [(TenantA, Alice)] = 120, [(TenantB, Bob)] = 150 };
return Assemble(new OverviewInputs(ThreeDays, includePlatformAdmins, Counters, facts, limits, names, LatestRoles(result.Calls), minute, result));
}
[Fact]
public void PlatformAdmins_DropOutOfEveryNumber_ButNotOutOfTheOrganizationWindows()
{
var overview = Overview();
var tenantA = overview.Tenants.Single(t => t.TenantId == TenantA);
Assert.DoesNotContain(tenantA.Accounts, a => a.Principal == Operator);
Assert.DoesNotContain(overview.Tools, t => t.Tool == "query_table");
Assert.Equal(55, tenantA.Requests); // alice 20 + 30, app 5 — the operator's 100 left out
// The organization windows stay the tenant's real counters: today 30 + 5 + 100, the month 10 + 20 + 30 + 5 + 100.
Assert.Equal(135, tenantA.Quota.DailyUsed);
Assert.Equal(165, tenantA.Quota.MonthlyUsed);
Assert.Equal("community", tenantA.Quota.TenantPlan);
}
[Fact]
public void PlatformAdmins_WhenIncluded_AreMarked()
{
var tenantA = Overview(includePlatformAdmins: true).Tenants.Single(t => t.TenantId == TenantA);
var op = tenantA.Accounts.Single(a => a.Principal == Operator);
Assert.True(op.IsPlatformAdmin);
Assert.Equal("GlobalAdmin", op.Role);
Assert.Equal(155, tenantA.Requests);
}
[Fact]
public void Accounts_RequestsComeFromTheCounters_CallsFromTheTelemetry()
{
var tenants = Overview().Tenants;
Assert.Equal(new[] { TenantA, TenantB }, tenants.Select(t => t.TenantId)); // most calls first
var accounts = tenants[0].Accounts;
Assert.Equal(new[] { Alice, Carol, App }, accounts.Select(a => a.Principal));
var alice = accounts[0];
Assert.Equal("oid-alice", alice.UserId);
Assert.Equal(7, alice.Calls);
Assert.Equal(50, alice.Requests); // Nov 1 lies before the window
Assert.Equal("20261105", alice.PeakDay);
Assert.Equal(30, alice.PeakDayRequests);
Assert.Equal(1, alice.QuotaHits);
Assert.Equal("Admin", alice.Role);
Assert.Equal(new[] { ("get_session_events", 3L), ("get_session_summary", 2L), ("list_tenants", 1L) },
alice.TopTools.Select(t => (t.Tool, t.Calls)));
Assert.Equal(("community", 50, 250, 30L, 60L),
(alice.Quota!.Plan, alice.Quota.DailyLimit, alice.Quota.MonthlyLimit, alice.Quota.DailyUsed, alice.Quota.MonthlyUsed));
}
[Fact]
public void AnAccountKnownOnlyFromTheTelemetry_HasNoObjectIdAndNoQuota()
{
// Every request refused: no counter row, but the calls happened.
var carol = Overview().Tenants.Single(t => t.TenantId == TenantA).Accounts.Single(a => a.Principal == Carol);
Assert.Null(carol.UserId);
Assert.Null(carol.Quota);
Assert.Equal(4, carol.Calls);
Assert.Equal(0, carol.Requests);
Assert.Null(carol.PeakDay);
}
[Fact]
public void Tools_RankByCalls_CostPerServedCall_AndMcpOnlyToolsFromTheLog()
{
var tools = Overview().Tools;
Assert.Equal(
new[] { "get_time_attribution", "search_docs", "get_session_events", "get_session_summary", "search_sessions", "list_tenants", "search_events" },
tools.Select(t => t.Tool));
var summary = tools.Single(t => t.Tool == "get_session_summary");
Assert.Equal(3, summary.Calls);
Assert.Equal(2, summary.Accounts);
Assert.Equal(1, summary.Tenants);
Assert.Equal(5.0, summary.RequestsPerCall); // (10 + 5) requests over 3 served calls
Assert.Equal(0.0, summary.ErrorRate);
Assert.Equal(600, summary.P95DurationMs);
Assert.Equal(19000, summary.AvgResultChars);
Assert.Equal(new[] { "GET sessions/{id}", "GET sessions/{id}/events" }, summary.Routes.Select(r => r.Route));
var docs = tools.Single(t => t.Tool == "search_docs");
Assert.Equal(4, docs.Calls);
Assert.Null(docs.Accounts);
Assert.Null(docs.Tenants);
Assert.Equal(0, docs.RequestsPerCall);
Assert.Equal(0.25, docs.ErrorRate);
// Every call refused: no served call, no cost to report.
Assert.Equal(0, tools.Single(t => t.Tool == "get_time_attribution").RequestsPerCall);
}
[Fact]
public void Daily_HasEveryDayOfTheWindow_WithCallsByPlan()
{
var daily = Overview().Daily;
Assert.Equal(new[] { "20261103", "20261104", "20261105" }, daily.Select(d => d.Date));
var today = daily[2];
Assert.Equal(10, today.Calls); // alice 5, app 1, carol 4 — the operator's 50 left out
Assert.Equal(35, today.Requests); // alice 30, app 5
Assert.Equal(3, today.Accounts);
Assert.Equal(new[] { ("community", 10L) }, today.CallsByPlan.Select(p => (p.Plan, p.Calls)));
Assert.Equal(new[] { ("pro", 2L) }, daily[0].CallsByPlan.Select(p => (p.Plan, p.Calls)));
}
[Fact]
public void QuotaHits_AndMinuteLimits_RankTheAccountsClosestToALimit()
{
var overview = Overview();
var hit = Assert.Single(overview.QuotaHits);
Assert.Equal((Alice, "user", "daily", 50L, 50L, 3L), (hit.Principal, hit.Level, hit.Scope, hit.Limit, hit.Used, hit.Refused));
Assert.Equal(60, overview.MinuteLimits.McpServerLimit);
var minute = overview.MinuteLimits.Accounts;
Assert.Equal(new[] { Bob, Alice }, minute.Select(m => m.Principal)); // 120/150 before 40/120 and 12/60
Assert.Equal((120L, 150, 2L), (minute[0].PeakRequests, minute[0].BackendLimit, minute[0].BackendRefused));
Assert.Equal((TenantA, 12L, 7L, 0L), (minute[1].TenantId, minute[1].PeakCalls, minute[1].McpRefused, minute[1].BackendRefused));
// The share the list ranks by, in whole percent: the higher of calls/MCP limit and requests/backend limit.
Assert.Equal(new[] { 80, 33 }, minute.Select(m => m.SharePercent)); // 120/150; max(12/60, 40/120)
}
[Fact]
public void Totals_SumTheLists_OnceForEveryConsumer()
{
var totals = Overview().Totals;
Assert.Equal(18, totals.Calls); // every tool of the ranking, search_docs' 4 MCP-only calls included
Assert.Equal(4, totals.McpOnlyCalls);
Assert.Equal(7, totals.Tools);
Assert.Equal(62, totals.Requests); // tenant A 55, tenant B 7 — the operator's 100 left out
Assert.Equal(2, totals.Tenants);
Assert.Equal(4, totals.Accounts); // alice, carol, the app, bob
Assert.Equal(1, totals.ServicePrincipals);
Assert.Equal(1, totals.QuotaHitAccounts); // alice's daily window
Assert.Equal(2, totals.MinuteRefusedAccounts); // alice at the MCP server, bob at the backend
Assert.Equal(2, totals.LimitAccounts);
}
[Fact]
public void Totals_WithoutTheirStore_AreAbsent_NotAPartialSum()
{
var totals = Overview(telemetry: false).Totals;
Assert.Null(totals.Calls);
Assert.Null(totals.McpOnlyCalls);
Assert.Equal(0, totals.Tools);
Assert.Equal(62, totals.Requests); // the counters still answer
Assert.Equal(3, totals.Accounts);
}
[Fact]
public void Tenants_CarryTheirDomain_WhenTheConfigurationNamesOne()
{
var tenants = Overview().Tenants;
Assert.Equal("contoso.com", tenants.Single(t => t.TenantId == TenantA).DomainName);
Assert.Null(tenants.Single(t => t.TenantId == TenantB).DomainName);
}
[Fact]
public async Task AnUnreadableTenantConfiguration_LeavesOnlyTheNameOut()
{
var config = new Mock<TenantConfigurationService>(
Mock.Of<IConfigRepository>(), NullLogger<TenantConfigurationService>.Instance, new MemoryCache(new MemoryCacheOptions()))
{ CallBase = false };
config.Setup(c => c.GetConfigurationIfExistsAsync(TenantA)).ThrowsAsync(new InvalidOperationException("storage down"));
config.Setup(c => c.GetConfigurationIfExistsAsync(TenantB)).ReturnsAsync(new TenantConfiguration { TenantId = TenantB, DomainName = "fabrikam.com" });
// Only the configuration read is exercised; the other collaborators stay unused.
var service = new McpUsageOverviewService(
null!, null!, null!, null!, config.Object, null!, null!, null!, NullLogger<McpUsageOverviewService>.Instance, TimeProvider.System);
Assert.Null(await service.ReadTenantConfigurationAsync(TenantA));
Assert.Equal("fabrikam.com", (await service.ReadTenantConfigurationAsync(TenantB))?.DomainName);
}
[Theory]
[InlineData(null, null, 30, false, null)]
[InlineData("7", "include", 7, true, null)]
[InlineData("90", "exclude", 90, false, null)]
[InlineData("91", null, 0, false, "days must be between 1 and 90")]
[InlineData("0", null, 0, false, "days must be between 1 and 90")]
[InlineData("-5", null, 0, false, "days must be between 1 and 90")]
[InlineData("7.5", null, 0, false, "days must be an integer")]
[InlineData("30", "all", 0, false, "platformAdmins must be include or exclude")]
public void OverviewQuery_DefaultsAndBounds(string? days, string? platformAdmins, int expectedDays, bool expectedInclude, string? expectedError)
{
var parsed = AutopilotMonitor.Functions.Functions.Metrics.McpUsageMetricsFunction.ParseOverviewQuery(days, platformAdmins);
Assert.Equal((expectedDays, expectedInclude, expectedError), parsed);
}
[Fact]
public void Status_NamesTheMcpLogCoverage_AndATelemetryOutageEmptiesOnlyItsParts()
{
Assert.Equal("20261104", Overview().Telemetry.McpLogFrom);
var dark = Overview(telemetry: false);
Assert.False(dark.Telemetry.RequestsAvailable);
Assert.False(dark.Telemetry.McpLogAvailable);
Assert.Empty(dark.Tools);
Assert.Empty(dark.QuotaHits);
// The counters still carry tenants, accounts, requests and the quota.
var tenantA = dark.Tenants.Single(t => t.TenantId == TenantA);
Assert.Equal(new[] { Alice, App }, tenantA.Accounts.Select(a => a.Principal).OrderBy(p => p, StringComparer.Ordinal));
Assert.Equal(0, tenantA.Calls);
Assert.Equal(55, tenantA.Requests);
}
}
@@ -0,0 +1,203 @@
using System.Text.Json;
using System.Text.RegularExpressions;
using AutopilotMonitor.Functions.Middleware;
using AutopilotMonitor.Functions.Services;
using AutopilotMonitor.Shared.Models;
using Xunit;
using static AutopilotMonitor.Functions.Services.McpUsageTelemetryQueries;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// The fixed KQL of the MCP usage overview: which rows it reads (the worker's request row, MCP only, no access
/// probe), that it counts calls exactly, leaves platform admins out unless asked, matches log lines by their
/// start, reads only fields the MCP server writes (tests/fixtures/mcp-log-lines, proven on the MCP side by
/// usage-log-fields.test.ts) — and that the parsers read the result tables by column name.
/// </summary>
public class McpUsageTelemetryQueriesTests
{
private static readonly Window Customers = new(new DateTime(2026, 10, 7, 0, 0, 0, DateTimeKind.Utc), new DateTime(2026, 11, 6, 0, 0, 0, DateTimeKind.Utc), IncludePlatformAdmins: false);
private static readonly Window Everyone = Customers with { IncludePlatformAdmins = true };
private static IEnumerable<string> RequestQueries(Window w) => new[] { Calls(w), Routes(w), Refusals(w), Peaks(w) };
private static IEnumerable<string> McpLogQueries(Window w) => new[] { ToolQuality(w), McpRefusals(w), McpServerFacts(w) };
[Fact]
public void Window_CoversWholeUtcDays()
{
Assert.Equal("datetime(2026-10-07T00:00:00Z)", Customers.From);
Assert.Equal("datetime(2026-11-06T00:00:00Z)", Customers.To);
Assert.Equal("P31D", Customers.Timespan); // the where clauses bound the window; the timespan only has to cover it
foreach (var query in RequestQueries(Customers).Concat(McpLogQueries(Customers)))
{
Assert.Contains(">= datetime(2026-10-07T00:00:00Z)", query);
Assert.Contains("< datetime(2026-11-06T00:00:00Z)", query);
}
}
[Fact]
public void RequestQueries_ReadTheWorkerRow_McpOnly_WithoutTheAccessProbe()
{
foreach (var query in RequestQueries(Customers))
{
Assert.Contains("customDimensions.Source) == 'WorkerMiddleware'", query);
Assert.Contains("customDimensions.ClientSource) =~ 'mcp'", query);
Assert.Contains("customDimensions.FunctionName) != 'GlobalAccessProbe'", query);
Assert.Contains("customDimensions.McpToolName", query);
Assert.Contains("customDimensions.CorrelationId", query);
Assert.Contains("tolower(tostring(customDimensions.TenantId))", query);
Assert.Contains("tolower(tostring(customDimensions.UserId))", query);
}
}
[Fact]
public void Calls_AreCountedOncePerCorrelationId_NeverEstimated()
{
var query = Calls(Customers);
Assert.Contains("by corr, tool, tenant, principal", query);
Assert.Contains("calls = count()", query);
foreach (var q in RequestQueries(Customers).Concat(McpLogQueries(Customers)))
Assert.DoesNotContain("dcount(", q);
}
[Fact]
public void PlatformAdmins_AreLeftOut_UnlessIncluded()
{
foreach (var query in RequestQueries(Customers))
Assert.Contains("role !in ('GlobalAdmin', 'GlobalReader')", query);
Assert.Contains("tostring(d.scope) != 'ga'", ToolQuality(Customers));
foreach (var query in RequestQueries(Everyone).Concat(McpLogQueries(Everyone)))
{
Assert.DoesNotContain("'GlobalAdmin'", query);
Assert.DoesNotContain("!= 'ga'", query);
}
}
[Fact]
public void Refusals_AreClassifiedByTheLinesTheMiddlewaresWrite()
{
var query = Refusals(Customers);
Assert.Contains($"startswith '{McpQuotaEnforcementMiddleware.BlockedLogPrefix}'", query);
Assert.Contains($"startswith '{UserRateLimitMiddleware.ThrottledLogPrefix}'", query);
Assert.Equal("[McpQuota] BLOCKED", McpQuotaEnforcementMiddleware.BlockedLogPrefix);
Assert.Equal("[UserRateLimit] THROTTLED", UserRateLimitMiddleware.ThrottledLogPrefix);
Assert.Contains("join kind=inner lines on operation_Id", query);
}
[Fact]
public void Peaks_SlideASixtySecondWindowInTenSecondSteps()
{
var query = Peaks(Customers);
Assert.Contains("bin(timestamp, 10s)", query);
Assert.Contains("bin(at, 10s)", query);
Assert.Equal(2, Regex.Matches(query, Regex.Escape("mv-expand k = range(0, 5, 1)")).Count);
}
[Fact]
public void McpLogLines_AreMatchedByTheirStart_NeverByHas()
{
Assert.Contains($"Log_s startswith '{ToolCallLinePrefix}'", ToolQuality(Customers));
Assert.Contains($"Log_s startswith '{McpRefusalLinePrefix}'", McpRefusals(Customers));
Assert.Contains($"Log_s startswith '{BootLinePrefix}'", McpServerFacts(Customers));
foreach (var query in McpLogQueries(Customers))
Assert.DoesNotContain("Log_s has", query);
}
[Fact]
public void McpLogQueries_ReadOnlyWhatTheServerWrites()
{
using var contract = JsonDocument.Parse(File.ReadAllText(Path.Combine(FindRepoRoot(), "tests", "fixtures", "mcp-log-lines", "fields.json")));
var prefixes = contract.RootElement.GetProperty("prefixes");
var fields = contract.RootElement.GetProperty("fields");
Assert.Equal(ToolCallLinePrefix, prefixes.GetProperty("tool_call").GetString());
Assert.Equal(BootLinePrefix, prefixes.GetProperty("boot").GetString());
Assert.Equal(McpRefusalLinePrefix, prefixes.GetProperty("mcp_refusal").GetString());
var toolCallFields = fields.GetProperty("tool_call").EnumerateArray().Select(f => f.GetString()!).ToHashSet();
var readFromToolCall = Regex.Matches(ToolQuality(Everyone), @"\bd\.(\w+)").Select(m => m.Groups[1].Value).ToHashSet();
Assert.NotEmpty(readFromToolCall);
Assert.Subset(toolCallFields, readFromToolCall);
var bootFields = fields.GetProperty("boot").EnumerateArray().Select(f => f.GetString()!).ToHashSet();
var readFromBoot = Regex.Matches(McpServerFacts(Everyone), @"parse_json\(Log_s\)\.(\w+)").Select(m => m.Groups[1].Value).ToHashSet();
Assert.Equal(new[] { "rateLimitPerMinute" }, readFromBoot);
Assert.Subset(bootFields, readFromBoot);
}
// ── Parsers ──
private static KqlTable Table(string[] columns, params object?[][] rows)
=> new()
{
Name = "PrimaryResult",
Columns = columns.Select(c => new KqlColumn { Name = c, Type = "dynamic" }).ToList(),
Rows = rows.Select(r => (IReadOnlyList<JsonElement>)r.Select(cell => JsonSerializer.SerializeToElement(cell)).ToList()).ToList(),
};
[Fact]
public void ParseCalls_ReadsByColumnName_WhateverTheOrder()
{
var table = Table(
new[] { "role", "charged", "day", "principal", "tool", "calls", "tenant", "servedCalls", "firstAt" },
new object?[] { "Admin", 59L, "20261028", "user@contoso.com", "get_time_attribution", 64L, "t1", 59L, "2026-10-28T16:12:30.4442709Z" });
var row = Assert.Single(ParseCalls(table));
Assert.Equal(new CallRow("20261028", "get_time_attribution", "t1", "user@contoso.com", 64, 59, 59,
new DateTime(2026, 10, 28, 16, 12, 30, 444, DateTimeKind.Utc).AddTicks(2709), "Admin"), row);
Assert.Equal(DateTimeKind.Utc, row.LastAt!.Value.Kind);
}
[Fact]
public void ParseRefusals_KeepsMissingCountsMissing()
{
var table = Table(
new[] { "gate", "day", "tenant", "principal", "level", "scope", "plan", "refused", "firstAt", "lastAt", "usedCount", "limitValue" },
new object?[] { "minute", "20261026", "t1", "user@contoso.com", "", "", "", 2L, "2026-10-26T07:55:42Z", "2026-10-26T07:55:43Z", null, null });
var row = Assert.Single(ParseRefusals(table));
Assert.Equal("minute", row.Gate);
Assert.Equal(2, row.Refused);
Assert.Null(row.Used);
Assert.Null(row.Limit);
}
[Fact]
public void ParseToolQuality_RoundsAFractionalCount_AndKeepsTheMean()
{
var table = Table(
new[] { "tool", "calls", "errors", "cancelled", "overCap", "p95Ms", "avgChars" },
new object?[] { "search_events", 26L, 1L, 0L, 0L, 1029.6, 10602.5 });
var row = Assert.Single(ParseToolQuality(table));
Assert.Equal(26, row.Calls);
Assert.Equal(1030, row.P95Ms);
Assert.Equal(10602.5, row.AvgChars);
}
[Fact]
public void ParseServerFacts_WithoutABootLine_HasNoLimit()
{
var facts = ParseServerFacts(Table(new[] { "oldest", "rateLimitPerMinute" }, new object?[] { "2026-10-07T01:52:43.167992Z", null }));
Assert.Equal(new DateTime(2026, 10, 7, 1, 52, 43, DateTimeKind.Utc).AddTicks(1_679_920), facts.Oldest);
Assert.Null(facts.RateLimitPerMinute);
Assert.Equal(new ServerFacts(null, null), ParseServerFacts(Table(new[] { "oldest", "rateLimitPerMinute" })));
}
private static string FindRepoRoot()
{
var dir = new DirectoryInfo(AppContext.BaseDirectory);
while (dir != null && !File.Exists(Path.Combine(dir.FullName, "AutopilotMonitor.sln")))
dir = dir.Parent;
Assert.NotNull(dir);
return dir!.FullName;
}
}
@@ -108,16 +108,10 @@ public class MetricsFilterInjectionTests
}
[Fact]
public void BuildTenantUsageFilter_TenantInjection_StaysInsideLiteral()
public void BuildUserUsageFilter_BothDates_NormalizeTheShapeAndBoundTheRange()
{
var filter = TableUserUsageRepository.BuildTenantUsageFilter("' or TenantId ne '", null, null);
var filter = TableUserUsageRepository.BuildUserUsageFilter("user1", "2026-11-01", "2026-11-05");
Assert.Equal("TenantId eq ''' or TenantId ne '''", filter);
}
[Fact]
public void BuildTenantUsageFilter_NoScope_ReturnsNull()
{
Assert.Null(TableUserUsageRepository.BuildTenantUsageFilter(null, null, null));
Assert.Equal("PartitionKey eq 'user1' and Date ge '20261101' and Date le '20261105'", filter);
}
}
@@ -548,64 +548,6 @@ public class MetricsWireParityTests
new GetMcpUserUsageResponse { UserId = userId, Records = records });
}
// ---- GetGlobalMcpUsage ---------------------------------------------------------------
[Fact]
public void GetGlobalMcpUsageResponse_matches_the_tenant_usage_shape()
{
string? tenantId = "6a6a35a2-30b2-4f2f-9a1b-6d9f1a2b3c4d";
var records = SampleUsageRecords("9cc42e33-0004-4b7c-a1d2-52f3aaaa0010");
AssertParity(
new { tenantId, records },
new GetGlobalMcpUsageResponse { TenantId = tenantId, Records = records });
}
[Fact]
public void GetGlobalMcpUsageResponse_omits_a_null_tenantId()
{
string? tenantId = null;
var records = new List<UserUsageRecord>();
AssertParity(
new { tenantId, records },
new GetGlobalMcpUsageResponse { TenantId = null, Records = records });
}
// ---- GetGlobalMcpUsageDaily ----------------------------------------------------------
[Fact]
public void GetGlobalMcpUsageDailyResponse_matches_the_daily_summary_shape()
{
string? tenantId = "6a6a35a2-30b2-4f2f-9a1b-6d9f1a2b3c4d";
var summaries = new List<UserUsageDailySummary>
{
new UserUsageDailySummary
{
Date = "20260830",
TenantId = tenantId,
TotalRequests = 321,
UniqueUsers = 4,
UniqueEndpoints = 11,
},
};
AssertParity(
new { tenantId, summaries },
new GetGlobalMcpUsageDailyResponse { TenantId = tenantId, Summaries = summaries });
}
[Fact]
public void GetGlobalMcpUsageDailyResponse_omits_a_null_tenantId()
{
string? tenantId = null;
var summaries = new List<UserUsageDailySummary>();
AssertParity(
new { tenantId, summaries },
new GetGlobalMcpUsageDailyResponse { TenantId = null, Summaries = summaries });
}
// ---- MetricsSummary / MetricsSummaryGlobal -------------------------------------------
[Fact]
@@ -832,6 +774,250 @@ public class MetricsWireParityTests
});
}
// ---- GetGlobalMcpUsageOverview ------------------------------------------------------
[Fact]
public void GetGlobalMcpUsageOverviewResponse_matches_the_overview_shape()
{
// One tenant with one account, one tool with one route, one quota refusal, one per-minute row — every
// optional slot filled, so every key is pinned in its wire position.
var at = new DateTime(2026, 11, 5, 10, 0, 0, DateTimeKind.Utc);
var tenantId = "7aa20c11-0002-4b7c-a1d2-52f3aaaa0001";
var quota = new McpOrganizationQuotaNode { TenantPlan = "community", DailyLimit = 100, MonthlyLimit = 250, DailyUsed = 35, MonthlyUsed = 60 };
AssertParity(
new
{
dateFrom = "20261103",
dateTo = "20261105",
includesPlatformAdmins = false,
telemetry = new { requestsAvailable = true, mcpLogAvailable = true, mcpLogFrom = "20261104", partial = true },
totals = new
{
calls = 10L, mcpOnlyCalls = 4L, tools = 2, requests = 50L, tenants = 1, accounts = 1, servicePrincipals = 0,
quotaHitAccounts = 1, minuteRefusedAccounts = 1, limitAccounts = 1,
},
daily = new[] { new { date = "20261105", calls = 10L, requests = 35L, accounts = 3, callsByPlan = new[] { new { plan = "community", calls = 10L } } } },
tenants = new[]
{
new
{
tenantId,
domainName = "contoso.com",
quota,
calls = 7L,
requests = 50L,
quotaHits = 1,
lastRequestAt = at,
accounts = new[]
{
new
{
userId = "oid-1",
principal = "admin@contoso.com",
role = "Admin",
isPlatformAdmin = false,
quota = new { plan = "community", dailyLimit = 50, monthlyLimit = 250, dailyUsed = 30L, monthlyUsed = 60L },
calls = 7L,
requests = 50L,
peakDay = "20261105",
peakDayRequests = 30L,
quotaHits = 1,
topTools = new[] { new { tool = "get_session_events", calls = 3L } },
lastRequestAt = at,
},
},
},
},
tools = new[]
{
new
{
tool = "get_session_summary",
calls = 3L,
accounts = 2,
tenants = 1,
requestsPerCall = 5.0,
errorRate = 0.0,
p95DurationMs = 600L,
avgResultChars = 19000L,
overCapCalls = 0L,
routes = new[] { new { route = "GET sessions/{id}", requests = 3L } },
},
},
quotaHits = new[]
{
new
{
date = "20261105", tenantId, principal = "admin@contoso.com", level = "user", scope = "daily", plan = "community",
limit = 50L, used = 50L, refused = 3L, firstAt = at, lastAt = at,
},
},
minuteLimits = new
{
mcpServerLimit = 60,
accounts = new[]
{
new
{
tenantId, principal = "admin@contoso.com", sharePercent = 33,
peakCalls = 12L, peakCallsAt = at, mcpRefused = 7L, mcpLastRefusedAt = at,
peakRequests = 40L, peakRequestsAt = at, backendLimit = 120, backendRefused = 2L, backendLastRefusedAt = at,
},
},
},
},
new GetGlobalMcpUsageOverviewResponse
{
DateFrom = "20261103",
DateTo = "20261105",
IncludesPlatformAdmins = false,
Telemetry = new McpUsageTelemetryStatus { RequestsAvailable = true, McpLogAvailable = true, McpLogFrom = "20261104", Partial = true },
Totals = new McpUsageTotalsNode
{
Calls = 10, McpOnlyCalls = 4, Tools = 2, Requests = 50, Tenants = 1, Accounts = 1, ServicePrincipals = 0,
QuotaHitAccounts = 1, MinuteRefusedAccounts = 1, LimitAccounts = 1,
},
Daily = new List<McpUsageDayItem>
{
new() { Date = "20261105", Calls = 10, Requests = 35, Accounts = 3, CallsByPlan = new List<McpUsagePlanCallsItem> { new() { Plan = "community", Calls = 10 } } },
},
Tenants = new List<McpUsageTenantItem>
{
new()
{
TenantId = tenantId,
DomainName = "contoso.com",
Quota = quota,
Calls = 7,
Requests = 50,
QuotaHits = 1,
LastRequestAt = at,
Accounts = new List<McpUsageAccountItem>
{
new()
{
UserId = "oid-1",
Principal = "admin@contoso.com",
Role = "Admin",
IsPlatformAdmin = false,
Quota = new McpUsageAccountQuotaNode { Plan = "community", DailyLimit = 50, MonthlyLimit = 250, DailyUsed = 30, MonthlyUsed = 60 },
Calls = 7,
Requests = 50,
PeakDay = "20261105",
PeakDayRequests = 30,
QuotaHits = 1,
TopTools = new List<McpUsageToolCallsItem> { new() { Tool = "get_session_events", Calls = 3 } },
LastRequestAt = at,
},
},
},
},
Tools = new List<McpUsageToolItem>
{
new()
{
Tool = "get_session_summary",
Calls = 3,
Accounts = 2,
Tenants = 1,
RequestsPerCall = 5.0,
ErrorRate = 0.0,
P95DurationMs = 600,
AvgResultChars = 19000,
OverCapCalls = 0,
Routes = new List<McpUsageRouteItem> { new() { Route = "GET sessions/{id}", Requests = 3 } },
},
},
QuotaHits = new List<McpUsageQuotaHitItem>
{
new()
{
Date = "20261105", TenantId = tenantId, Principal = "admin@contoso.com", Level = "user", Scope = "daily", Plan = "community",
Limit = 50, Used = 50, Refused = 3, FirstAt = at, LastAt = at,
},
},
MinuteLimits = new McpUsageMinuteLimits
{
McpServerLimit = 60,
Accounts = new List<McpUsageMinuteItem>
{
new()
{
TenantId = tenantId, Principal = "admin@contoso.com", SharePercent = 33,
PeakCalls = 12, PeakCallsAt = at, McpRefused = 7, McpLastRefusedAt = at,
PeakRequests = 40, PeakRequestsAt = at, BackendLimit = 120, BackendRefused = 2, BackendLastRefusedAt = at,
},
},
},
});
}
[Fact]
public void GetGlobalMcpUsageOverviewResponse_omits_what_a_store_did_not_answer()
{
// Telemetry down, an account known only from the telemetry shape (no object id, no quota), an MCP-only
// tool (no reach, no quality), no MCP limit reported yet: every nullable key vanishes.
var tenantId = "7aa20c11-0002-4b7c-a1d2-52f3aaaa0001";
var quota = new McpOrganizationQuotaNode { TenantPlan = "community", DailyLimit = 100, MonthlyLimit = 250, DailyUsed = 0, MonthlyUsed = 0 };
AssertParity(
new
{
dateFrom = "20261105",
dateTo = "20261105",
includesPlatformAdmins = true,
telemetry = new { requestsAvailable = false, mcpLogAvailable = false },
totals = new { tools = 1, requests = 0L, tenants = 1, accounts = 1, servicePrincipals = 1, quotaHitAccounts = 0, minuteRefusedAccounts = 0, limitAccounts = 0 },
daily = Array.Empty<object>(),
tenants = new[]
{
new
{
tenantId,
quota,
calls = 4L,
requests = 0L,
quotaHits = 0,
accounts = new[]
{
new { principal = "app:11111111-2222-3333-4444-555555555555", isPlatformAdmin = false, calls = 4L, requests = 0L, quotaHits = 0, topTools = Array.Empty<object>() },
},
},
},
tools = new[] { new { tool = "search_docs", calls = 4L, requestsPerCall = 0.0, routes = Array.Empty<object>() } },
quotaHits = Array.Empty<object>(),
minuteLimits = new { accounts = Array.Empty<object>() },
},
new GetGlobalMcpUsageOverviewResponse
{
DateFrom = "20261105",
DateTo = "20261105",
IncludesPlatformAdmins = true,
Telemetry = new McpUsageTelemetryStatus { RequestsAvailable = false, McpLogAvailable = false },
Totals = new McpUsageTotalsNode { Tools = 1, Requests = 0, Tenants = 1, Accounts = 1, ServicePrincipals = 1 },
Daily = new List<McpUsageDayItem>(),
Tenants = new List<McpUsageTenantItem>
{
new()
{
TenantId = tenantId,
Quota = quota,
Calls = 4,
Requests = 0,
QuotaHits = 0,
Accounts = new List<McpUsageAccountItem>
{
new() { Principal = "app:11111111-2222-3333-4444-555555555555", Calls = 4, TopTools = new List<McpUsageToolCallsItem>() },
},
},
},
Tools = new List<McpUsageToolItem> { new() { Tool = "search_docs", Calls = 4, RequestsPerCall = 0, Routes = new List<McpUsageRouteItem>() } },
QuotaHits = new List<McpUsageQuotaHitItem>(),
MinuteLimits = new McpUsageMinuteLimits { Accounts = new List<McpUsageMinuteItem>() },
});
}
// ---- GetGrowthMetrics ---------------------------------------------------------------
private static GrowthMetricsResponse GrowthResponse(double? median, IReadOnlyList<GrowthTenantRow>? tenants) => new()
@@ -962,6 +1148,177 @@ public class MetricsWireParityTests
AssertParity(GrowthLiteral(null, null), GrowthResponse(null, null));
}
// ---------- GET global/metrics/tenant-activity ----------
private const string ActivityTenantId = "8bb31d22-0004-4c8d-b2e3-63f4bbbb0001";
private static readonly DateTime ActivityOnboardedAt = new(2026, 6, 30, 9, 0, 0, DateTimeKind.Utc);
private static readonly DateTime ActivityCounterAt = new(2026, 11, 6, 7, 30, 0, DateTimeKind.Utc);
private static readonly DateTime ActivityVisitAt = new(2026, 11, 6, 8, 15, 0, DateTimeKind.Utc);
private static GetTenantActivityResponse TenantActivityResponse(bool full) => new()
{
WindowDays = 30,
WindowStart = "2026-10-07",
UsageDaysThrough = "2026-11-05",
PreviousWindowStart = "2026-09-07",
RowsFrom = "2026-05-10",
PortalActivityAvailable = full,
Totals = new TenantActivityTotals
{
SignedUpTenants = 2,
ActiveTenants = 1,
ActiveTenantsPrevious = 1,
ActiveTenantsTrendPercent = full ? 0 : null,
Enrollments = 6,
EnrollmentsPrevious = 4,
EnrollmentsTrendPercent = full ? 50 : null,
Succeeded = 5,
Failed = 1,
SuccessPercent = full ? 83 : null,
Top10SharePercent = full ? 100 : null,
Stages = new TenantActivityStageCounts { NeverEnrolled = 1, Active = 1 },
PortalUsers = full ? 3 : null,
PortalTenants = full ? 1 : null,
},
Daily = new List<TenantActivityDailyItem>
{
new() { Day = "2026-11-05", Enrollments = 6, Succeeded = 5, Failed = 1, ActiveTenants = 1 },
},
Tenants = new List<TenantActivityTenantItem>
{
new()
{
TenantId = ActivityTenantId,
DomainName = "contoso.example",
CompanyName = full ? "Contoso" : null,
Edition = TenantEditionNames.ProTrial,
Stage = TenantActivityStages.Active,
OnboardedAt = full ? ActivityOnboardedAt : null,
Enrollments = 6,
EnrollmentsPrevious = 4,
TrendPercent = full ? 50 : null,
Succeeded = 5,
Failed = 1,
SuccessPercent = full ? 83 : null,
ActiveDays = 1,
DailyEnrollments = full ? new[] { 6 } : null,
FirstEnrollmentDay = full ? "2026-07-01" : null,
LastActiveDay = full ? "2026-11-05" : null,
LastCounterUpdateAt = full ? ActivityCounterAt : null,
LifetimeEnrollments = 120,
LifetimeSucceeded = 100,
LifetimeEvents = 50_000,
PortalUsers = full ? 3 : null,
LastPortalVisitAt = full ? ActivityVisitAt : null,
},
},
};
[Fact]
public void GetTenantActivityResponse_matches_the_shape_with_every_optional_key()
{
AssertParity(new
{
windowDays = 30,
windowStart = "2026-10-07",
usageDaysThrough = "2026-11-05",
previousWindowStart = "2026-09-07",
rowsFrom = "2026-05-10",
portalActivityAvailable = true,
totals = new
{
signedUpTenants = 2,
activeTenants = 1,
activeTenantsPrevious = 1,
activeTenantsTrendPercent = 0,
enrollments = 6,
enrollmentsPrevious = 4,
enrollmentsTrendPercent = 50,
succeeded = 5,
failed = 1,
successPercent = 83,
top10SharePercent = 100,
stages = new { neverEnrolled = 1, dormant = 0, @new = 0, declining = 0, active = 1, quiet = 0 },
portalUsers = 3,
portalTenants = 1,
},
daily = new[] { new { day = "2026-11-05", enrollments = 6, succeeded = 5, failed = 1, activeTenants = 1 } },
tenants = new[]
{
new
{
tenantId = ActivityTenantId,
domainName = "contoso.example",
companyName = "Contoso",
edition = "pro-trial",
stage = "active",
onboardedAt = ActivityOnboardedAt,
enrollments = 6,
enrollmentsPrevious = 4,
trendPercent = 50,
succeeded = 5,
failed = 1,
successPercent = 83,
activeDays = 1,
dailyEnrollments = new[] { 6 },
firstEnrollmentDay = "2026-07-01",
lastActiveDay = "2026-11-05",
lastCounterUpdateAt = ActivityCounterAt,
lifetimeEnrollments = 120L,
lifetimeSucceeded = 100L,
lifetimeEvents = 50_000L,
portalUsers = 3,
lastPortalVisitAt = ActivityVisitAt,
},
},
}, TenantActivityResponse(full: true));
}
[Fact]
public void GetTenantActivityResponse_omits_every_absent_figure()
{
// No sign-in history, no previous window, no finished session, no names beyond the domain.
AssertParity(new
{
windowDays = 30,
windowStart = "2026-10-07",
usageDaysThrough = "2026-11-05",
previousWindowStart = "2026-09-07",
rowsFrom = "2026-05-10",
portalActivityAvailable = false,
totals = new
{
signedUpTenants = 2,
activeTenants = 1,
activeTenantsPrevious = 1,
enrollments = 6,
enrollmentsPrevious = 4,
succeeded = 5,
failed = 1,
stages = new { neverEnrolled = 1, dormant = 0, @new = 0, declining = 0, active = 1, quiet = 0 },
},
daily = new[] { new { day = "2026-11-05", enrollments = 6, succeeded = 5, failed = 1, activeTenants = 1 } },
tenants = new[]
{
new
{
tenantId = ActivityTenantId,
domainName = "contoso.example",
edition = "pro-trial",
stage = "active",
enrollments = 6,
enrollmentsPrevious = 4,
succeeded = 5,
failed = 1,
activeDays = 1,
lifetimeEnrollments = 120L,
lifetimeSucceeded = 100L,
lifetimeEvents = 50_000L,
},
},
}, TenantActivityResponse(full: false));
}
private static void AssertParity(object anonymousLiteral, IApiResponse typed)
=> ApiResponseWireParityTests.AssertWireIdentical(anonymousLiteral, typed);
}
@@ -0,0 +1,271 @@
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Text.RegularExpressions;
using Xunit;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// Contains Newtonsoft.Json (D-420): new code reads and writes JSON with System.Text.Json. Every shipped
/// source file under <c>src/</c> that uses Newtonsoft today is on a frozen baseline that may only shrink,
/// and only the projects in <see cref="ProjectsWithPackage"/> may reference the package. Test projects are
/// out of scope: they exercise Newtonsoft-bound code and never ship.
/// A file uses Newtonsoft when a code line names the <c>Newtonsoft.Json</c> namespace (using, alias,
/// fully qualified name, or the DLL name); comment lines do not count.
/// </summary>
public class NewtonsoftUsageGuardTests
{
private const string AgentWireAndState = "agent (net48): wire format and on-device state, which move only with an agent release";
private const string DecisionCore = "DecisionCore serialization shared by the agent and its tests";
private const string SummaryDialog = "summary dialog (net48): reads the agent's final status and checks the DLL ships beside it";
private const string Ingest = "agent ingest wire (D-200)";
private const string ConfigRules = "Newtonsoft-bound configuration and rule documents (PopulateObject)";
private const string QueueEnvelope = "queue envelope contract shared by producers and consumers";
private const string StoredJson = "stored JSON (table columns, blobs, report files) that existing rows must keep reading";
private const string OutgoingPayload = "outgoing notification payloads";
private const string RuleTemplates = "rule template interpolation over Newtonsoft tokens";
/// <summary>Path relative to <c>src/</c> → why it may still use Newtonsoft. Only shrinks.</summary>
private static readonly Dictionary<string, string> Baseline = new(StringComparer.OrdinalIgnoreCase)
{
["Agent/AutopilotMonitor.Agent.V2.Core/Configuration/BuiltInConfigCatalog.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Configuration/RemoteConfigService.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Diagnostics/CrashDumpCapture.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Diagnostics/CrashRecord.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Diagnostics/PendingCrashReporter.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Enrollment/Ime/ImeLogTracker.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Enrollment/Ime/ImeLogTracker.Handlers.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Enrollment/Ime/ImeTrackerStatePersistence.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Enrollment/SystemSignals/EventRecordWatermark.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Enrollment/SystemSignals/MdmRebootPolicyTracker.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Enrollment/SystemSignals/ModernDeploymentTracker.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Enrollment/SystemSignals/SystemTimelineTracker.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Runtime/SelfUpdater.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Runtime/VersionCheckEventBuilder.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Telemetry/Gather/Collectors/JsonCollector.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Telemetry/Gather/GatherRuleGuards.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Telemetry/Gather/GatherRuleStatePersistence.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Telemetry/Office/OfficeInstallStatePersistence.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Telemetry/Periodic/BandwidthStatePersistence.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Telemetry/Periodic/DeliveryOptimizationCollector.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Telemetry/Provisioning/ProvisioningPackageCollector.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Transport/BackendApiClient.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Transport/DistressReporter.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Monitoring/Transport/GeoLocationService.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Orchestration/Hosts/OsBuildChangeHost.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Persistence/StartupEventGate.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Security/SessionIdPersistence.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Telemetry/Events/EventSequencePersistence.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Telemetry/Events/TelemetryEventEmitter.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Telemetry/Signals/TelemetrySignalEmitter.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Telemetry/Transitions/TelemetryTransitionEmitter.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Termination/FinalStatus.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Termination/SummaryDialogLauncher.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Transport/Telemetry/BackendTelemetryUploader.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Transport/Telemetry/TelemetryItemSerializer.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2.Core/Transport/Telemetry/UploadCursorPersistence.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2/Program.GatherRulesMode.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2/Program.Guards.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2/Program.ImeMatchingMode.cs"] = AgentWireAndState,
["Agent/AutopilotMonitor.Agent.V2/Program.InstallMode.cs"] = AgentWireAndState,
["Shared/AutopilotMonitor.DecisionCore/Serialization/DecisionCoreJsonSettings.cs"] = DecisionCore,
["Shared/AutopilotMonitor.DecisionCore/Serialization/SignalSerializer.cs"] = DecisionCore,
["Shared/AutopilotMonitor.DecisionCore/Serialization/StateSerializer.cs"] = DecisionCore,
["Shared/AutopilotMonitor.DecisionCore/Serialization/TransitionSerializer.cs"] = DecisionCore,
["Shared/AutopilotMonitor.DecisionCore/Serialization/UnknownFallbackEnumConverter.cs"] = DecisionCore,
["Agent/AutopilotMonitor.SummaryDialog/App.xaml.cs"] = SummaryDialog,
["Agent/AutopilotMonitor.SummaryDialog/MainWindow.xaml.cs"] = SummaryDialog,
["Agent/AutopilotMonitor.SummaryDialog/Models/FinalStatus.cs"] = SummaryDialog,
["Backend/AutopilotMonitor.Functions/Functions/Bootstrap/BootstrapRegisterSessionFunction.cs"] = Ingest,
["Backend/AutopilotMonitor.Functions/Functions/Ingest/EventDataNormalizer.cs"] = Ingest,
["Backend/AutopilotMonitor.Functions/Functions/Ingest/IngestTelemetryFunction.cs"] = Ingest,
["Backend/AutopilotMonitor.Functions/Functions/Ingest/TelemetryPayloadParser.cs"] = Ingest,
["Backend/AutopilotMonitor.Functions/Functions/Sessions/RegisterSessionFunction.cs"] = Ingest,
["Backend/AutopilotMonitor.Functions/Services/Ime/ImePatternHealthService.cs"] = Ingest,
["Backend/AutopilotMonitor.Functions/Services/Vulnerability/VulnerabilityInventoryLoader.cs"] = Ingest,
["Backend/AutopilotMonitor.Functions/Functions/Config/PatchAdminConfigurationFunction.cs"] = ConfigRules,
["Backend/AutopilotMonitor.Functions/Functions/Config/PatchTenantConfigurationFieldsFunction.cs"] = ConfigRules,
["Backend/AutopilotMonitor.Functions/Helpers/RequestBody.cs"] = ConfigRules,
["Backend/AutopilotMonitor.Functions/Services/BuiltInAnalyzeRules.cs"] = ConfigRules,
["Backend/AutopilotMonitor.Functions/Services/BuiltInGatherRules.cs"] = ConfigRules,
["Backend/AutopilotMonitor.Functions/Services/BuiltInImeLogPatterns.cs"] = ConfigRules,
["Backend/AutopilotMonitor.Functions/Services/GitHubRuleRepository.cs"] = ConfigRules,
["Backend/AutopilotMonitor.Functions/Services/RulesWrapper.cs"] = ConfigRules,
["Backend/AutopilotMonitor.Functions/Services/TenantConfigPatchService.cs"] = ConfigRules,
["Backend/AutopilotMonitor.Functions/Services/Activation/AzureQueueTenantAutoApproveEnqueuer.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/Analyze/AzureQueueAnalyzeOnEnrollmentEndProducer.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/Backup/Queue/AzureQueueCriticalTableBackupProducer.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/Backup/Queue/CriticalTableBackupQueueWorker.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/Deletion/AzureQueueSessionDeletionMaintenanceTriggerProducer.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/Deletion/SessionDeletionProducer.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/Deletion/SessionDeletionWorker.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/Ime/AzureQueueImeMsiArchiveProducer.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/Maintenance/AzureQueueMaintenanceTriggerProducer.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/Notifications/AzureQueueNotificationDispatchProducer.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/Offboarding/AzureQueueTenantOffboardingEnqueuer.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/Offboarding/TenantOffboardingWorker.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/Queueing/QueueEnvelopeReader.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/Queueing/QueuePollingWorker.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/Vulnerability/AzureQueueVulnerabilityCorrelateProducer.cs"] = QueueEnvelope,
["Backend/AutopilotMonitor.Functions/Services/AnalyzeRuleService.cs"] = StoredJson,
["Backend/AutopilotMonitor.Functions/Services/FailureSnapshotBuilder.cs"] = StoredJson,
["Backend/AutopilotMonitor.Functions/Services/MaintenanceService.Aggregation.cs"] = StoredJson,
["Backend/AutopilotMonitor.Functions/Services/SessionReportService.cs"] = StoredJson,
["Backend/AutopilotMonitor.Functions/Services/TableStorageService.cs"] = StoredJson,
["Backend/AutopilotMonitor.Functions/Services/TableStorageService.Maintenance.cs"] = StoredJson,
["Backend/AutopilotMonitor.Functions/Services/TableStorageService.Rules.cs"] = StoredJson,
["Backend/AutopilotMonitor.Functions/Services/TableStorageService.ServerActions.cs"] = StoredJson,
["Backend/AutopilotMonitor.Functions/Services/TableStorageService.Sessions.cs"] = StoredJson,
["Backend/AutopilotMonitor.Functions/Services/Vulnerability/VulnerabilityCorrelateHandler.cs"] = StoredJson,
["Backend/AutopilotMonitor.Functions/Services/Vulnerability/VulnerabilityCorrelationService.cs"] = StoredJson,
["Backend/AutopilotMonitor.Functions/Services/Notifications/DiscordRenderer.cs"] = OutgoingPayload,
["Backend/AutopilotMonitor.Functions/Services/Notifications/GenericJsonRenderer.cs"] = OutgoingPayload,
["Backend/AutopilotMonitor.Functions/Services/Notifications/SlackRenderer.cs"] = OutgoingPayload,
["Backend/AutopilotMonitor.Functions/Services/Notifications/TeamsWorkflowAdaptiveCardRenderer.cs"] = OutgoingPayload,
["Backend/AutopilotMonitor.Functions/Services/RuleTemplateInterpolator.cs"] = RuleTemplates,
};
/// <summary>The projects that may reference the Newtonsoft.Json package directly.</summary>
private static readonly string[] ProjectsWithPackage =
{
"Agent/AutopilotMonitor.Agent.V2/AutopilotMonitor.Agent.V2.csproj",
"Agent/AutopilotMonitor.Agent.V2.Core/AutopilotMonitor.Agent.V2.Core.csproj",
"Agent/AutopilotMonitor.SummaryDialog/AutopilotMonitor.SummaryDialog.csproj",
"Backend/AutopilotMonitor.Functions/AutopilotMonitor.Functions.csproj",
"Shared/AutopilotMonitor.DecisionCore/AutopilotMonitor.DecisionCore.csproj",
};
private static readonly Regex NamespaceUse = new(@"\bNewtonsoft\.Json\b", RegexOptions.Compiled);
private static readonly Regex PackageReference = new(
@"<PackageReference\s+Include\s*=\s*""Newtonsoft\.Json""", RegexOptions.Compiled | RegexOptions.IgnoreCase);
[Fact]
public void Newtonsoft_use_is_frozen_per_file()
{
var actual = ShippedSources()
.Where(s => UsesNewtonsoft(s.Text))
.Select(s => s.Relative)
.ToHashSet(StringComparer.OrdinalIgnoreCase);
var violations = new List<string>();
foreach (var file in actual.OrderBy(f => f, StringComparer.Ordinal))
{
if (!Baseline.ContainsKey(file))
violations.Add($"{file}: NEW use of Newtonsoft.Json — read and write JSON with System.Text.Json; the Newtonsoft baseline is frozen (D-420).");
}
foreach (var file in Baseline.Keys.OrderBy(f => f, StringComparer.Ordinal))
{
if (!actual.Contains(file))
violations.Add($"{file}: on the baseline but no longer uses Newtonsoft.Json (or is gone) — remove its entry (ratchet down).");
}
Assert.True(violations.Count == 0, "Newtonsoft.Json baseline violated:\n " + string.Join("\n ", violations));
}
[Fact]
public void Newtonsoft_package_only_in_known_projects()
{
var srcRoot = Path.Combine(FindRepoRoot(), "src");
var actual = SourceFiles(srcRoot, "*.csproj", includeTestProjects: true)
.Where(f => PackageReference.IsMatch(File.ReadAllText(f)))
.Select(f => Relative(srcRoot, f))
.ToHashSet(StringComparer.OrdinalIgnoreCase);
var violations = actual.Except(ProjectsWithPackage, StringComparer.OrdinalIgnoreCase)
.Select(p => $"{p}: NEW Newtonsoft.Json package reference — use System.Text.Json (D-420).")
.Concat(ProjectsWithPackage.Except(actual, StringComparer.OrdinalIgnoreCase)
.Select(p => $"{p}: listed but no longer references Newtonsoft.Json — remove it from ProjectsWithPackage (ratchet down)."))
.OrderBy(v => v, StringComparer.Ordinal)
.ToList();
Assert.True(violations.Count == 0, "Newtonsoft.Json package references violated:\n " + string.Join("\n ", violations));
}
[Theory]
[InlineData("using Newtonsoft.Json;", true)]
[InlineData("using Newtonsoft.Json.Linq;", true)]
[InlineData("using JsonConvert = Newtonsoft.Json.JsonConvert;", true)]
[InlineData(" catch (Newtonsoft.Json.JsonException) { }", true)]
[InlineData("var dll = Path.Combine(dir, \"Newtonsoft.Json.dll\");", true)]
[InlineData("var url = \"https://x\"; Newtonsoft.Json.Linq.JObject.Parse(s); // trailing", true)]
[InlineData("var x = 1; // Newtonsoft.Json is not used here", false)]
[InlineData(" /// <summary>Newtonsoft.Json defaults on both sides.</summary>", false)]
[InlineData("// Newtonsoft.Json", false)]
[InlineData(" /* Newtonsoft.Json */", false)]
[InlineData(" * Newtonsoft.Json in a block comment", false)]
[InlineData("var rule = await RequestBody.ReadNewtonsoftAsync<AnalyzeRule>(req);", false)]
public void Use_detector_sees_code_but_not_comments(string line, bool expected)
=> Assert.Equal(expected, UsesNewtonsoft(line));
private static bool UsesNewtonsoft(string text)
{
foreach (var raw in text.Split('\n'))
{
var trimmed = raw.TrimStart();
if (trimmed.StartsWith("//", StringComparison.Ordinal) || trimmed.StartsWith("/*", StringComparison.Ordinal) || trimmed.StartsWith('*'))
continue;
var line = raw;
var comment = line.IndexOf("//", StringComparison.Ordinal);
if (comment >= 0 && !line[..comment].Contains('"'))
line = line[..comment];
if (NamespaceUse.IsMatch(line))
return true;
}
return false;
}
private static IEnumerable<(string Relative, string Text)> ShippedSources()
{
var srcRoot = Path.Combine(FindRepoRoot(), "src");
return SourceFiles(srcRoot, "*.cs", includeTestProjects: false)
.Select(f => (Relative(srcRoot, f), File.ReadAllText(f)));
}
/// <summary>
/// Walks <paramref name="root"/> without entering build output or package folders: the web and MCP
/// node_modules alone would make a plain recursive enumeration take tens of seconds.
/// </summary>
private static IEnumerable<string> SourceFiles(string root, string pattern, bool includeTestProjects)
{
var pending = new Stack<string>();
pending.Push(root);
while (pending.Count > 0)
{
var dir = pending.Pop();
foreach (var file in Directory.EnumerateFiles(dir, pattern))
yield return file;
foreach (var sub in Directory.EnumerateDirectories(dir))
{
var name = Path.GetFileName(sub);
if (SkippedFolders.Contains(name) || (!includeTestProjects && name.EndsWith(".Tests", StringComparison.OrdinalIgnoreCase)))
continue;
pending.Push(sub);
}
}
}
private static readonly HashSet<string> SkippedFolders = new(StringComparer.OrdinalIgnoreCase) { "bin", "obj", "node_modules", ".next" };
private static string Relative(string root, string path)
=> Path.GetRelativePath(root, path).Replace(Path.DirectorySeparatorChar, '/');
private static string FindRepoRoot()
{
var dir = new DirectoryInfo(AppContext.BaseDirectory);
while (dir != null && !File.Exists(Path.Combine(dir.FullName, "AutopilotMonitor.sln")))
dir = dir.Parent;
Assert.NotNull(dir);
return dir!.FullName;
}
}

Some files were not shown because too many files have changed in this diff Show More