Compare commits

...

23 Commits

Author SHA1 Message Date
Oliver Kieselbach fa31872903 fix(agent,engine,web): keep the due time as the deadline stamp; draw timeout verdicts hollow in the Network Timeline (D-238 revised)
Revises 14b185db after the pre-release review. The fleet measurement (30 days,
all tenants) showed 87 of 821 sessions with a sleep episode had their verdict
inside the episode — 59 of them one tenant's self-deploying devices closed two
minutes before the device-only detection came due and reopened 5–7 days later.
Stamping the firing clock would have turned those outages into session
duration and pushed the tenant's mean duration from minutes to days.

- OnDeadlineFired posts OccurredAtUtc = DueAtUtc again; the due time stays in the
  payload and the two stale-fire guards keep reading it (any stamp stays safe).
- Network Timeline: a timeout verdict (helloOutcome timeout, device-only detection
  window) is drawn as a hollow marker "Completed (timeout)" with a legend line and a
  plain-language tooltip — a wait expired, nothing observed on the device; the
  Asleep block is never split at it. finalizing_grace alone is not an indicator.
- Session Info standby note clips to the two WhiteGlove spans when the card shows
  the combined WhiteGlove duration; the dedup key is consumed only by a usable
  observation (review findings).
- Stale comments describing the firing-clock contract corrected.

Tests: DeadlineFireTimeStampTests (reducer stays correct for any stamp),
EnrollmentOrchestratorTests (due-time stamp + payload), networkTimelineModel
timeout markers (3), standby windows, WhiteGlove windows.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-10 01:55:31 +02:00
Oliver Kieselbach b08b79eafe test(mcp): revert_tenant_config backupId is required — schema and description pin (D-240 review)
Left out of e43d916c's explicit file list by mistake; part of the same change.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-10 01:47:31 +02:00
Oliver Kieselbach e43d916c24 fix(mcp): spec gates, secret-safe error text, enforced response cap, payload-coupled pageSize, client cancellation (D-239, D-240)
Request gates: an Origin other than the server's own is refused with 403 before any token
work (spec MUST); a token the backend rejects is answered 401 + WWW-Authenticate
error="invalid_token" instead of a final 403. The auth.ts header now names the
backend-audience token forwarding as a deliberate deviation (D-239) instead of calling
it spec-conformant.

Secrets: the per-argument echo policy travels in the tool-call context, so toolError's
"Parameters used" block masks update_tenant_config.fields the same way the log line
does. revert_tenant_config requires backupId (a retried revert without one restored the
snapshot the previous revert had just created). /oauth/token relays Entra errors through
an allowlist (error, capped description, error_codes). OAuthStateSigningKey is required
in production (B-uba).

Results: toolResultText enforces the response cap — a page above it is refused with an
overflow answer naming the pageSize that fits (from this page's bytes per row), never
rows or a nextLink; the telemetry logs the size the page would have had (B-zhp).
query_raw_events with DataJson in the effective projection defaults to 50 rows and
refuses more than 100 before the backend runs (30-day measurement: p90 3.3 KB, outliers
21-29 KB per row) (B-s2y). The caller context carries the request's cancellation signal:
apiFetch, the retry wait and the timeout fallback stop when the client goes away, and the
tool_call line logs cancelled instead of an error.

Tests: 9 new files (origin guard both eras over HTTP, 401 + cancellation, apiFetch abort,
arg policy in error text, signing key, token error body, overflow, raw-events pageSize,
telemetry overflow/cancelled); vitest 844 green, tsc 0.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-10 01:47:10 +02:00
Oliver Kieselbach 14b185db35 fix(agent,engine,web): a deadline decision is stamped with the firing clock, never the due time (D-238)
A HelloSafety deadline due during Modern Standby fired after wake but was stamped
with its due time, so enrollment_complete and CompletedAt landed inside the sleep
window: the Network Timeline drew "Completed" in the middle of the Asleep block
and three views named three different standby durations.

- OnDeadlineFired posts OccurredAtUtc = FiredAtUtc and carries the due time under
  SignalPayloadKeys.DeadlineDueAtUtc; the stale-fire guards (RealmJoin re-arm,
  SelfDeploying guard C) identify the incarnation via DecisionEngine.DeadlineDueAtUtc,
  which falls back to the signal time for pre-key signal logs.
- SignalSerializer renders Date-tokenized payload strings as ISO-8601 round-trip text
  instead of the culture-formatted JValue.ToString() (a replayed deadlineDueAtUtc came
  back as "4/20/2026 9:55:00 AM").
- Web: the Session Info standby note is clipped to the same window as the duration
  next to it (lib/standby.ts) and printed with seconds, matching the attribution chip.

Tests: DeadlineFireTimeStampTests (late HelloSafety fire, guard C, RealmJoin re-arm,
helper fallback), SerializationTests date-like payload round-trip,
EnrollmentOrchestratorTests late fire, lib/__tests__/standby.test.ts.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-10 01:05:16 +02:00
Oliver Kieselbach baa51102fd feat(web,backend,mcp): app rows without a terminal state become Incomplete instead of running forever (D-237)
An app still installing when the session's observation ended has no terminal
event and never will. The session page ticked Date.now() - startedAt for it
("11h 39m" on a session that finished hours ago), and its AppInstallSummaries
row stayed InProgress forever - ranked behind failures in the app's session
list and counted in totalInstalls with no named bucket.

Web: applyObservationEnd marks such rows Incomplete once the session is
terminal (isTerminalStatus), bounded by session.lastEventAt; the panel shows a
slate Incomplete badge and the watched span as a lower bound, the "active"
pill excludes them, and the download panel carries the parallel flag. Covers
every historic session without a backfill.

Backend: CloseOpenAppInstallsForSessionAsync closes InProgress rows without a
CompletedAt as Incomplete - at the terminal seam, again on the ingest batch
that carries agent_shutting_down for a terminal session (rows opened after
the verdict), and from the 30-day sweep. The sticky-status reconcile keeps
Incomplete against a late progress-only batch and lets a real terminal win.
App metrics and app analytics disclose the bucket (incomplete,
totalIncomplete) outside the failure rate; manifest and wire types
regenerated.

MCP: get_session_summary coverage gains an apps block and a gaps line naming
the apps the agent's last app_tracking_summary still listed as installing or
downloading, terminal sessions only.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-10 00:02:24 +02:00
Oliver Kieselbach 5577f5e7e5 feat(rules): rule submissions — retention (withdrawn 30d, declined 90d), contact email, pending-first tenant list, operator hard delete (D-236 amended)
Closed submissions leave through the daily maintenance sweep (RuleSubmissionRetention, one place for rule and test); pending/approved/published never. The submit dialog takes an optional contact email (a UPN is not always a mailbox), stored for the reviewer and never published. The tenant list shows pending rows by default with the rest behind Show all, and the contribute button shows for every writer, also before the first custom rule exists. DELETE global/rule-submissions/{id} (GlobalAdminOnly, MCP delete_rule_submission) removes test/demo rows for operator and tenant alike. Bumps internal and .claude/commands gitlinks.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-09 23:27:25 +02:00
Oliver Kieselbach 61892592e4 feat(rules): community rule submissions — submit custom rules from the portal, review via GA page or MCP, publish by repo commit + reseed (D-236)
Tenant admins submit references to their own gather/analyze rules; the server freezes the rule, records pre-flight findings and fire stats, and stores it under a 12-character id (RuleSubmissions, SessionReports layout). Attribution is the submitter's frozen choice (anonymous by default) and becomes the published author. Review (approve with reserved id / decline with comment) through /admin/reports/rule-submissions or the MCP tools list_rule_submissions, get_rule_submission, review_rule_submission, reseed_rules_from_github; published is derived from the global catalog, never stored. Analyze rules now get the same server-side author stamp as gather rules; ANALYZE-ID-001 carries author Community. Privacy page names the credit; bumps internal and .claude/commands gitlinks.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-09 22:53:32 +02:00
Oliver Kieselbach 1e2ca46946 chore: bump internal gitlink (ESP-004 released, B-kfu)
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 17:40:23 +02:00
Oliver Kieselbach 8224c8f1a8 fix(rules,engine,agent): ESP-004 gates on the esp_apps_timeout verdict; not_exists absence gate; Shell-Core failure inherits settle detail (D-234, D-235)
ANALYZE-ESP-004 fired on every ESP terminal failure of a Continue-anyway
profile and rendered the configured FirstSync limit as elapsed time — the
mayHaveContinuedAnyway flag only says the profile has the button. The rule
now requires the agent's own verdict (app_install_failed with
failureType=esp_apps_timeout), names that app via a same-event filter, reads
failedSubcategory from esp_failure_settle_started and words the limit as a
limit. Verified with test_analyze_rule: cb7036a6 fires, 683f1eff (0x80070652
after 19 min) stays silent.

Rule engine: not_exists with a dataField on event_type/event_data
conditions matches when no event of the type carries a non-empty value —
including an absent type — instead of being dead behind the fieldValue null
short-circuit. Schema and MCP authoring guide say so.

Agent: a Shell-Core 62407 failure that lands inside the provisioning
tracker's 30-s settle window (a third of all ESP terminal failures) now
inherits the pending errorCode / failedSubcategory / category /
likelyCulpritApps, so enrollment_failed, Sessions.FailureReason and the
termination-time app classification see the HRESULT the registry had
already named. failureType stays the Shell-Core value.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 17:20:24 +02:00
Oliver Kieselbach d7f39895f5 fix(web): omit the two default field values from the browser catalog (D-233)
The Entra family (D-231) pushed utils/error-codes.json to 123026 bytes against
the 120000-byte client-bundle budget, breaking the Web CI job.

Raising the cap would have been the wrong repair -- it was set three days ago
with the v2 catalog, and a guard that gets widened whenever content grows is not
a guard. The bytes were elsewhere: confidence "high" holds for 562 of 641 rows
and source "msdoc" for about half, ~19 KB of bundle spent repeating two
constants. The sync now omits them and errorCodeMap restores them while building
the map, so every consumer still sees a complete entry and errorCodeTooltip
renders exactly as before. 123026 -> 102399 bytes, cap unchanged, ~17 KB of
headroom left.

Dropping the fields outright was rejected: the tooltip renders both, so they are
provenance a customer sees. The vocabulary test now asserts on the resolved
entry via getErrorCodeEntry rather than the raw file -- a default changed on one
side only would otherwise make tooltips lie about provenance silently.
2026-09-09 15:26:29 +02:00
Oliver Kieselbach 790bd35385 small gather rule description change 2026-09-09 14:59:56 +02:00
Oliver Kieselbach 34c9fd42fe chore: bump internal and .claude/commands gitlinks
internal: D-231/D-232, the plan with its review, backlog B-y5d and B-s2y.
.claude/commands: the platform-health marker-catalog corrections from the
2026-09-09 health pass (weekday vs weekend ingest baseline, CAS retried scales
with load, WhatsNewNotificationSent is not proof of a run).
2026-09-09 14:55:30 +02:00
Oliver Kieselbach 19a336870c fix(mcp): put the catalog pointer on the parameter, not only the tool (D-232)
Seven of 44 tool errors in the 7-day telemetry were invented catalog values, and
in every case the tool description already said the right thing while the
parameter description was bare or contradicted it.

update_tenant_config is the clean proof: its description says "Call
get_tenant_config_schema FIRST", but the fields parameter said "Use
get_tenant_config for current values and exact field names" -- and over 30 days
the model called get_tenant_config 12 times and get_tenant_config_schema once.
The text next to the argument wins, and get_tenant_config cannot answer what it
was pointed at: it shows only the fields this tenant has set, with no type,
writability or nullability.

Also: get_session_events.eventType (event_types catalog, matching the pointer
search_sessions_by_event.eventType already carries), query_table (list_tables)
and test_analyze_rule.rule (rule_schemas, validate_rule first).
2026-09-09 14:55:22 +02:00
Oliver Kieselbach 5ba5942d0b feat(error-codes): parse the Entra device-registration family (D-231)
The catalog held 2 of 607 entries in entra-join, while the 0x801Cxxxx DSREG
family is what an enrollment meets during hybrid join and the ESP account-setup
phase. The Windows Hello PIN error page is the only MS table that documents it;
both of its tables are now parsed, restricted to 0x801c* (607 -> 641 entries).

The block runs after PROSE_ENTRIES so the Autopilot-specific text for 0x801c03ea
keeps precedence over the generic one. The Mitigation column is not carried --
the catalog describes codes, it does not advise. A "SYMBOL: text" cell yields a
symbol (0x801c004d -> DSREG_NO_DEFAULT_ACCOUNT). The run fails below 30 keys,
because parseTables drops non-matching rows silently and a reshaped page would
otherwise look like a clean run.

decode() now strips zero-width and bidi marks: the page carries U+200B in one
hex cell and four description cells, JS \s does not match it, and such a hex
cell fails every ^0x...$ test. Placed in decode() rather than in the new source
so the next parsed page cannot walk into it -- regeneration shows 34 added,
0 changed.

0x801C044F, the zero-hit lookup that started this, is on none of the three MS
pages and deliberately stays unknown.
2026-09-09 14:55:11 +02:00
Oliver Kieselbach aa20d9102c fix(backend): show the freshly published agent version, not the previous one (D-230)
The What's new panel prints "Latest agent version" under the release
entries, and the session list draws its outdated badges from the same
endpoint — but the value was cached 12h in each Function instance and 1h
in the browser, so the panel announced the previous release for up to 13h
and two instances could disagree.

- LatestVersionsService: TTL 12h -> 5 min; keep the last successful result
  and serve it when the blob read fails, so the shorter TTL cannot blank
  the version line on a transient hiccup (failure marker 5 min -> 1 min).
- GetLatestVersions: Cache-Control max-age 3600 -> 60.
- No refresh callback from build-agent.yml: the cache is per instance, a
  warm-up request would leave every other instance stale.

The origin is a ~200-byte no-cache blob behind the download alias that
Front Door does not cache, so a warm instance now reads it at most 12x/h.

Backend deploy (workflow_dispatch) pending — B-uq7.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 12:26:03 +02:00
Oliver Kieselbach 097be1700b chore: bump internal gitlink
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 12:10:52 +02:00
Oliver Kieselbach f1457d823d chore: bump .claude/commands gitlink 2026-09-09 12:02:05 +02:00
Oliver Kieselbach 12e66299e6 feat(rules): allow-list folders under the signed-in user's profile (D-228, D-229)
Gather rules and admin-configured diagnostics paths could never reach a
folder below a user profile. The %LOGGED_ON_USER_PROFILE% token lifts the
C:\Users hard block for AppData\Local and AppData\Roaming, but lifting is
not admitting: the path then fell into filePrefixes, which is matched
literally against the already-expanded path, and the profile name is not
known when that list is authored. The exception only ever worked in
unrestricted mode, and no agent test passed a non-null userProfilePath.

D-228 introduces userProfileFilePrefixes, holding entries relative to the
profile root (AppData\Local\RealmJoin). Both guards resolve them against
the detected profile and match segment-bounded; entries that are rooted,
contain "..", or sit outside AppData\Local / AppData\Roaming are dropped at
load, so configuration can only narrow the hard block's exception, never
widen it. The allowlist is anchored to the detected profile, so a rule
cannot reach another user's AppData. The AppData subdirectory list existed
in both guard classes with the GatherRuleGuards copy unused; it is now one
list and DiagnosticsPathGuards delegates. filePrefixes additionally gains
C:\ProgramData\RealmJoin\choco\logs.

D-229 fixes the pre-flight validators, which must only ever reject what the
agent rejects:
- the portal returned "allowed" on the lifted hard block without consulting
  the allowlist, so a rule the agent refuses passed the enable gate and then
  failed silently on the device with a security_warning;
- the MCP validator offered logparser the diagnosticsPathPrefixes list that
  no collector consults (four paths reported allowed that the agent blocks);
- the MCP validator did not expand environment variables at all, reporting
  %ProgramData% targets as blocked although the device reads them.

Measured before changing the portal: no rule in any tenant used the token,
so nothing that was working gets disabled.

Verified: solution build 0 warnings, agent 2897 tests, web 1257 + tsc +
eslint 0, MCP 779, guardrails.json validates against its schema, rules/dist
regenerates without drift. The six new agent tests were green against the
unchanged guard first, which is what proves the exception was inert.

Takes effect on devices only after an agent release: guardrails.json is an
EmbeddedResource in the agent assembly.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 11:54:36 +02:00
Oliver Kieselbach e9a01de9da chore: bump .claude/commands gitlink
Event reference in /ux-insights completed and live-verified.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 10:06:20 +02:00
Oliver Kieselbach 5f793ea01a chore: bump .claude/commands gitlink
Marker-catalog rows for the What's new panel events and the digest timer.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-09 09:58:50 +02:00
Oliver Kieselbach e86f7efed3 feat(bootstrap): verify the publisher of the extracted agent binaries before --install (D-227)
The SHA-256 check proves the ZIP is the one version.json names, but that
manifest lives in the same container as the ZIP: it cannot outlive a
compromise of the download host. The expected publisher travels inside this
script, which the loader verified before running it, so the chain from the
file an administrator assigns to the process that starts is publisher-anchored
end to end.

Install-AutopilotMonitor.ps1 v2.4 -> v2.5:
- Get-UnverifiedAgentBinaries checks every AutopilotMonitor.*.exe/.dll in the
  extracted payload for status Valid and the same subject pin the loader
  carries; the gate runs immediately before --install and throws on any
  rejection, exactly like the hash check.
- Third-party assemblies keep their own publisher's signature and are not
  checked: System.Management.Automation.dll ships unsigned, so a gate over all
  files would refuse the live payload.
- An extracted folder with no binary of ours is a rejection, not a pass.
- The SHA-256 manifest check is unchanged and still runs first: it proves the
  bytes, the signature proves the author.

Verified against the live payload 2.0.1454 (all five of our PEs Valid and
glueckkanja AG, gate passes); appending one byte to AutopilotMonitor.Shared.dll
makes it reject. Pester 55/55.

The portal privacy and about pages carried the pre-signing wording and are
corrected in the same change.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-08 23:11:16 +02:00
Oliver Kieselbach 78bfad0ec6 web: the portal What's new panel names the currently published agent version
A quiet third line in the panel header ("Latest agent version 2.0.1452",
faint, the number monospaced) reads from the existing config/latest-versions
endpoint. The monospaced string is the same one the session list shows in its
"Agent Version" column, so a reader can tell at a glance whether their fleet
runs the latest agent.

Portal and signed-in only: the endpoint is AuthenticatedUser, and the public
site has no session list to compare against. The gate sits on the mount of the
small component, so the landing page never even issues the request; a missing
version renders nothing.
2026-09-08 22:37:29 +02:00
Oliver Kieselbach f5efadfd07 ci: pin every third-party action to a commit SHA, gated and Dependabot-maintained (D-226)
A tag is a mutable pointer owned by the action's publisher. These jobs are not
ordinary CI: they hold the code-signing Key Vault token (D-223), the federated
storage credentials (D-222), and combine-rules.yml holds a contents:write token
that pushes to main. Whoever could repoint v7 would run code with all of that.

azure/login and Azure/functions-action were already pinned; the actions/* and
github/codeql-action references were not, on the usual argument that GitHub owns
them and shares the runner's trust boundary. That argument does not survive the
fact that they run in the same jobs as the signing identity. All seven are now
pinned by SHA with the version in a trailing comment -- the comment is what keeps
the line reviewable, and Dependabot rewrites both together.

action-pins.yml is the guard: pins nobody enforces rot, and no review reliably
catches one @v4 added to a 200-line workflow. It lives in its own workflow because
ci.yml deliberately ignores changes to the other workflow files, so a job placed
there would stay silent for exactly the commits it must inspect. Like CI it reports
rather than blocks -- main is unprotected; making it binding would mean adding it
as a required status check, which is a branch-protection decision.

Verified both directions: 49 references pass against the repo, and a fixture with
@v7, @main and a bare SHA fails with three annotations while the local reusable
workflow refs are skipped.

Two floating tool versions closed while here. wix went from the range 5.* to 5.0.2
-- it writes the bytes of the MSI customers install, where AzureSignTool only signs
them. ajv was the worse one: unpinned, and npm runs lifecycle scripts at install,
so a hijacked release would have executed with the push token before a single rule
was validated; now exact versions with --ignore-scripts.

Line endings: sed -i rewrote the workflow files as LF. Git normalises on commit, so
the content diff is unaffected and indexnow-notify.yml carries no change at all.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-08 22:14:15 +02:00
177 changed files with 9274 additions and 460 deletions
+4
View File
@@ -55,6 +55,10 @@ updates:
- dependency-name: '*'
update-types: ['version-update:semver-major']
# Every action is referenced by commit SHA with the version in a trailing comment;
# action-pins.yml fails any workflow change that reintroduces a mutable tag. Dependabot
# is what keeps those pins current: it rewrites the SHA and the comment together, so the
# pins are reviewed in a PR instead of drifting silently or being bumped by hand.
- package-ecosystem: github-actions
directory: /
schedule:
+70
View File
@@ -0,0 +1,70 @@
name: Action Pin Gate
# Every third-party action must be referenced by a full commit SHA, never by a tag.
# Tags are mutable: whoever controls an action repository can repoint v4 at new code,
# and that code runs inside jobs that hold the code-signing identity, the storage
# credentials and a token that can push to main. A SHA is the only reference an
# upstream owner cannot change under us.
#
# Lives in its own workflow rather than in ci.yml: CI deliberately ignores changes to
# the other workflow files, so a guard placed there would stay silent for exactly the
# commits it needs to inspect.
#
# Like CI, this reports rather than blocks: main is deliberately unprotected, so a red
# run is a signal to act on, not a merge barrier. Making it binding means adding
# 'Verify action pins' as a required status check -- a branch-protection decision, not
# something this file can assert.
#
# The pins are not maintained by hand — .github/dependabot.yml opens a monthly grouped
# PR that rewrites both the SHA and the trailing version comment. The comment is
# therefore required too: it is what makes a pinned line reviewable.
on:
push:
branches: [main]
paths: ['.github/workflows/**']
pull_request:
branches: [main]
paths: ['.github/workflows/**']
workflow_dispatch:
permissions:
contents: read
jobs:
verify-pins:
name: Verify action pins
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- name: Every third-party action is pinned to a SHA
run: |
set -uo pipefail
failed=0
while IFS=: read -r file line ref; do
# Reusable workflows from this repository move with the commit that calls
# them, so there is nothing to pin.
case "$ref" in ./*) continue ;; esac
if [[ "$ref" =~ ^[^@]+@[0-9a-f]{40}[[:space:]]+#[[:space:]]*[^[:space:]] ]]; then
printf 'ok %s:%s %s\n' "$file" "$line" "$ref"
continue
fi
if [[ "$ref" =~ ^[^@]+@[0-9a-f]{40}[[:space:]]*$ ]]; then
echo "::error file=$file,line=$line::Pinned but the version comment is missing: '$ref'. Write 'owner/action@<sha> # vN' so the line stays reviewable."
else
echo "::error file=$file,line=$line::Action '$ref' is not pinned to a commit SHA. Tags are mutable -- resolve it with: gh api repos/<owner>/<action>/git/ref/tags/<tag>"
fi
failed=1
# -H is load-bearing: with a single matching file grep omits the name, the
# fields shift by one and every diagnostic points at nothing.
done < <(grep -nHE '^[[:space:]]*(-[[:space:]]+)?uses:' .github/workflows/*.yml \
| sed -E 's/^([^:]+):([0-9]+):[[:space:]]*(-[[:space:]]+)?uses:[[:space:]]*/\1:\2:/')
if [ "$failed" -ne 0 ]; then
echo "::error::Unpinned action references found -- fix them before this reaches main."
exit 1
fi
echo "All action references are pinned to commit SHAs."
+1 -1
View File
@@ -18,7 +18,7 @@ jobs:
name: Bootstrap guard tests (PS 5.1)
runs-on: windows-latest
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- name: Install Pester 5+
shell: powershell
+5 -5
View File
@@ -72,7 +72,7 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v7
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
# Every released build is signed; a missing variable stops the run before a build
# number is burnt.
@@ -122,7 +122,7 @@ jobs:
# SDK 10 = single build toolchain (parity with local build.ps1 / global.json).
- name: Setup .NET
uses: actions/setup-dotnet@v6
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6
with:
dotnet-version: '10.0.x'
@@ -462,7 +462,7 @@ jobs:
# Skipped on runs that publish nothing -- no log entry for bytes nobody receives.
- name: Attest build provenance
if: inputs.upload_blob || inputs.create_release
uses: actions/attest-build-provenance@v4
uses: actions/attest-build-provenance@4d101475d8b20a2381f78447822ac1eab6504dd8 # v4
with:
subject-path: |
${{ steps.artifact.outputs.versioned_zip_release }}
@@ -470,13 +470,13 @@ jobs:
staging/agent/AutopilotMonitor.SummaryDialog.exe
- name: Upload build artifact
uses: actions/upload-artifact@v7
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: AutopilotMonitor-Agent-v${{ steps.version.outputs.version }}
path: ${{ steps.artifact.outputs.versioned_zip_release }}
- name: Upload version metadata
uses: actions/upload-artifact@v7
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: version-metadata
path: ${{ env.MANIFEST_NAME }}
+7 -4
View File
@@ -40,7 +40,7 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v7
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
# The loader executes as SYSTEM on every enrolling device — a parse error or
# non-ASCII mojibake (PS 5.1 codepage roulette) must fail the build, not the fleet.
@@ -111,8 +111,11 @@ jobs:
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
# Exact version, not a "5.*" range: wix writes the bytes of the MSI that customers
# install, so a compromised or simply broken point release must not flow into a build
# unnoticed. Bumping is a reviewed commit.
- name: Install WiX toolset
run: dotnet tool install --global wix --version "5.*"
run: dotnet tool install --global wix --version 5.0.2
# Version pinned; roll-forward because the tool targets an older runtime than the SDK.
- name: Install AzureSignTool
@@ -235,12 +238,12 @@ jobs:
# gh attestation verify AutopilotMonitor-Bootstrap.msi --repo okieselbach/AutopilotMonitor
- name: Attest build provenance (MSI)
if: inputs.upload_blob
uses: actions/attest-build-provenance@v4
uses: actions/attest-build-provenance@4d101475d8b20a2381f78447822ac1eab6504dd8 # v4
with:
subject-path: ${{ env.STABLE_MSI }}
- name: Upload build artifact
uses: actions/upload-artifact@v7
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: AutopilotMonitor-Bootstrap-v${{ steps.version.outputs.version }}
path: ${{ env.STABLE_MSI }}
+13 -11
View File
@@ -35,6 +35,7 @@ on:
# Every other workflow: nothing here builds or tests anything CI covers. paths-ignore
# cannot negate, so they are listed one by one; ci.yml itself stays out of the list
# so a change to CI runs CI. A new workflow file is opt-in — add it here too.
- '.github/workflows/action-pins.yml'
- '.github/workflows/bootstrap-script-gates.yml'
- '.github/workflows/build-agent.yml'
- '.github/workflows/build-msi.yml'
@@ -67,6 +68,7 @@ on:
# Every other workflow: nothing here builds or tests anything CI covers. paths-ignore
# cannot negate, so they are listed one by one; ci.yml itself stays out of the list
# so a change to CI runs CI. A new workflow file is opt-in — add it here too.
- '.github/workflows/action-pins.yml'
- '.github/workflows/bootstrap-script-gates.yml'
- '.github/workflows/build-agent.yml'
- '.github/workflows/build-msi.yml'
@@ -94,9 +96,9 @@ jobs:
# windows-latest is required: the agent test projects target net48.
runs-on: windows-latest
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- uses: actions/setup-dotnet@v6
- uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6
with:
dotnet-version: '10.0.x'
@@ -125,9 +127,9 @@ jobs:
run:
working-directory: src/Web/autopilot-monitor-web
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- uses: actions/setup-node@v7
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '22'
cache: npm
@@ -159,9 +161,9 @@ jobs:
run:
working-directory: src/McpServer/autopilot-monitor-mcp
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- uses: actions/setup-node@v7
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '22'
cache: npm
@@ -179,7 +181,7 @@ jobs:
# (run 31252869254). Persist the model across runs instead; HF_CACHE_DIR
# is honored by vector-search-provider.ts.
- name: Cache embedding model
uses: actions/cache@v6
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6
with:
path: ${{ github.workspace }}/.hf-cache
key: hf-model-Xenova-all-MiniLM-L6-v2
@@ -193,9 +195,9 @@ jobs:
name: Generated guardrails match rules/guardrails.json
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- uses: actions/setup-node@v7
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '22'
@@ -214,9 +216,9 @@ jobs:
name: Generated wire types match shared-manifests.json
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- uses: actions/setup-node@v7
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '22'
+4 -4
View File
@@ -102,15 +102,15 @@ jobs:
build-mode: none
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- uses: actions/setup-dotnet@v6
- uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6
if: matrix.language == 'csharp'
with:
dotnet-version: '10.0.x'
- name: Initialize CodeQL
uses: github/codeql-action/init@v4.37.9
uses: github/codeql-action/init@cdf488f595d80d6e07e03d4674febd5ab45fa938 # v4.37.9
with:
languages: ${{ matrix.language }}
build-mode: ${{ matrix.build-mode }}
@@ -121,6 +121,6 @@ jobs:
run: dotnet build AutopilotMonitor.sln --configuration Release
- name: Analyze
uses: github/codeql-action/analyze@v4.37.9
uses: github/codeql-action/analyze@cdf488f595d80d6e07e03d4674febd5ab45fa938 # v4.37.9
with:
category: /language:${{ matrix.language }}
+6 -3
View File
@@ -24,14 +24,17 @@ jobs:
permissions:
contents: write
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- uses: actions/setup-node@v7
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '22'
# Exact versions and no lifecycle scripts: this job holds contents:write and pushes to
# main, so an install-time script from a hijacked package would run with a token that
# can rewrite the repository. ajv is pure JS and needs no install hooks.
- name: Install ajv-cli
run: npm install -g ajv-cli ajv-formats
run: npm install -g --ignore-scripts ajv-cli@5.0.0 ajv-formats@3.0.1
- name: Validate Gather Rules
run: |
+2 -2
View File
@@ -19,7 +19,7 @@ jobs:
name: Build and Deploy Backend
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- name: Login to Azure (OIDC)
uses: azure/login@7ddb5af1ef8758cf1353cf3b42f940aee27ba21c # v3
@@ -29,7 +29,7 @@ jobs:
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
- name: Setup .NET 10
uses: actions/setup-dotnet@v6
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6
with:
dotnet-version: '10.0.x'
+2 -2
View File
@@ -26,7 +26,7 @@ jobs:
name: Build and Deploy MCP Server
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
# The published customer documentation lives in its own PUBLIC repo and is
# baked into the image as the search_docs corpus (see the Dockerfile). No
@@ -36,7 +36,7 @@ jobs:
# re-run actually rolls a new revision). /health reports the SHA captured
# below so that staleness is checkable.
- name: Check out documentation bundle
uses: actions/checkout@v7
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
repository: autopilotmonitor/autopilotmonitor-docs
path: mcp-docs
+5 -5
View File
@@ -35,7 +35,7 @@ jobs:
runs-on: ubuntu-latest
name: Build and Deploy Job
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
lfs: false
fetch-depth: 0 # Full history needed for git-based sitemap lastmod dates
@@ -56,7 +56,7 @@ jobs:
# workflow runs again (push under src/Web/** or a manual dispatch); versions/web.json
# records which docs commit is live.
- name: Check out documentation bundle
uses: actions/checkout@v7
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
repository: autopilotmonitor/autopilotmonitor-docs
path: whats-new-docs
@@ -66,7 +66,7 @@ jobs:
id: docs
run: echo "sha=$(git -C whats-new-docs rev-parse HEAD)" >> "$GITHUB_OUTPUT"
- uses: actions/setup-node@v7
- uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7
with:
node-version: '22'
cache: npm
@@ -114,12 +114,12 @@ jobs:
# commit, workflow file) in a public transparency log.
# Verify: gh attestation verify portal-<sha>.tar.gz --repo okieselbach/AutopilotMonitor
- name: Attest build provenance (portal export)
uses: actions/attest-build-provenance@v4
uses: actions/attest-build-provenance@4d101475d8b20a2381f78447822ac1eab6504dd8 # v4
with:
subject-path: ${{ steps.package.outputs.archive }}
- name: Upload build artifact
uses: actions/upload-artifact@v7
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: portal-${{ github.sha }}
path: ${{ steps.package.outputs.archive }}
+2 -2
View File
@@ -54,7 +54,7 @@ jobs:
needs: gates
runs-on: windows-latest
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
- name: Check code-signing configuration
shell: pwsh
@@ -127,7 +127,7 @@ jobs:
# when someone wants to look at the file.
- name: Upload signed scripts
if: always()
uses: actions/upload-artifact@v7
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
name: signed-scripts
path: ${{ runner.temp }}/signed-scripts
+1 -1
Submodule infra updated: 55a8eaf929...742249e7e3
+31 -19
View File
@@ -1,11 +1,11 @@
{
"$schema": "../schema/analyze-rule.schema.json",
"ruleId": "ANALYZE-ESP-004",
"title": "ESP Timeout with 'Continue Anyway' (Soft Failure)",
"description": "Detects an ESP terminal failure on a profile that allows 'Continue anyway'. The enrollment is reported as failed, but the user most likely dismissed the error screen and reached the desktop — a soft failure rather than an unusable device.",
"title": "ESP Gave Up on a Blocking App with 'Continue Anyway' (Soft Failure)",
"description": "Detects an ESP terminal failure where the ESP gave up while a blocking app was still installing (the agent's own esp_apps_timeout verdict — no per-app HRESULT was reported) on a profile that allows 'Continue anyway'. The enrollment is reported as failed, but the user most likely dismissed the error screen and reached the desktop — a soft failure rather than an unusable device. An ESP failure that carries a specific error code (a failed installer, a detection mismatch) is a different case and stays with the rule that explains that code.",
"severity": "warning",
"category": "esp",
"version": "1.0.1",
"version": "1.1.0",
"enabled": true,
"baseConfidence": 80,
"conditions": [
@@ -26,6 +26,27 @@
"value": "true",
"required": true
},
{
"signal": "esp_gave_up_on_app",
"source": "event_type",
"eventType": "app_install_failed",
"dataField": "failureType",
"operator": "equals",
"value": "esp_apps_timeout",
"required": true
},
{
"signal": "appName",
"source": "event_data",
"eventType": "app_install_failed",
"dataField": "appName",
"operator": "exists",
"value": "",
"filterField": "failureType",
"filterOperator": "equals",
"filterValue": "esp_apps_timeout",
"required": false
},
{
"signal": "espSyncFailureTimeoutMinutes",
"source": "event_type",
@@ -38,34 +59,25 @@
{
"signal": "failedSubcategory",
"source": "event_type",
"eventType": "enrollment_failed",
"eventType": "esp_failure_settle_started",
"dataField": "failedSubcategory",
"operator": "exists",
"value": "",
"required": false
},
{
"signal": "appName",
"source": "event_type",
"eventType": "app_install_failed",
"dataField": "appName",
"operator": "exists",
"value": "",
"required": false
}
],
"confidenceFactors": [
{ "signal": "appName", "condition": "exists", "weight": 10 }
{ "signal": "failedSubcategory", "condition": "exists", "weight": 10 }
],
"explanation": "This enrollment was reported as **failed** because the Enrollment Status Page reached its configured terminal timeout (`{{espSyncFailureTimeoutMinutes}} min`) before all blocking items finished. The ESP profile, however, allows **'Continue anyway'** — so the user most likely dismissed the error screen and reached the desktop with a working, though not fully provisioned, device.\n\nThe agent only observes the ESP terminal failure on the device side; it cannot see what the user did after the failure screen. Treat this as a **soft failure**: the device may well be in productive use, while at least one blocking item (`{{failedSubcategory}}` subcategory / app `{{appName}}`) did not complete inside the ESP window.\n\nA cluster of these across a tenant almost always points at one slow blocking app holding the whole fleet at the ESP timeout wall, not at broken devices. Any field still shown as a literal `{{…}}` placeholder was simply not recorded for this session (e.g. a certificate-only failure has no failed app).",
"explanation": "This enrollment was reported as **failed** because the Enrollment Status Page gave up while the blocking app **{{appName}}** was still installing — the agent recorded no per-app error code, only that the app never finished inside the ESP window (the profile's configured limit is `{{espSyncFailureTimeoutMinutes}} min`; the ESP may have stopped earlier than that). The ESP profile, however, allows **'Continue anyway'** — so the user most likely dismissed the error screen and reached the desktop with a working, though not fully provisioned, device.\n\nThe agent only observes the ESP terminal failure on the device side; it cannot see what the user did after the failure screen. Treat this as a **soft failure**: the device may well be in productive use, while the `{{failedSubcategory}}` subcategory did not complete inside the ESP window.\n\nA cluster of these across a tenant almost always points at one slow blocking app holding the whole fleet at the ESP limit, not at broken devices. This rule deliberately stays silent when the failed app reported a specific error code — a failed installer or a detection mismatch is explained by the rule for that code, and 'Continue anyway' does not make it a timing problem. Any field still shown as a literal `{{…}}` placeholder was simply not recorded for this session.",
"remediation": [
{
"title": "Relieve ESP pressure so enrollments finish inside the window",
"steps": [
"Identify the slow blocking app (`{{appName}}`) and either remove it from the ESP 'block device use until these required apps are installed' list, or raise the ESP installation timeout (currently {{espSyncFailureTimeoutMinutes}} min).",
"If the app legitimately needs longer than the ESP allows, make it non-blocking and let it install after the desktop arrives.",
"Verify the app's detection rule matches after install — an app that installs but fails detection times out the ESP on every device (see ANALYZE-APP-013).",
"If a subcategory such as Certificates is reported under '{{failedSubcategory}}', confirm the certificate/connector actually delivers — 'Continue anyway' hides a missing certificate, it does not fix it."
"Look at how long `{{appName}}` takes on a device that completes: if it legitimately needs longer than the ESP allows, make it non-blocking (remove it from 'block device use until these required apps are installed') and let it install after the desktop arrives.",
"If the app must stay blocking, raise the ESP setting 'Show error when installation takes longer than' (configured at {{espSyncFailureTimeoutMinutes}} min) — a limit, not a target; it only helps when the app reliably finishes within the new value.",
"Check the app's dependencies and install order: a blocking app waiting on a large dependency download (Delivery Optimization, proxy throughput) is the usual reason it never finishes in time.",
"If the ESP reported a non-Apps subcategory under '{{failedSubcategory}}', confirm the certificate/connector actually delivers — 'Continue anyway' hides a missing certificate, it does not fix it."
]
}
],
+1
View File
@@ -5,6 +5,7 @@
"description": "Detects when a certificate with the configured subject is missing from the local machine personal store (LocalMachine\\My). Requires the gather rule GATHER-ID-002 (machine cert store inventory) to be enabled — the check runs against its gather_machine_cert_store output. A missing certificate may indicate that MDM enrollment certificate provisioning or SCEP certificate deployment failed.",
"severity": "warning",
"category": "identity",
"author": "Community",
"isCommunity": true,
"enabled": false,
"evaluateOn": [
+32 -19
View File
@@ -2496,11 +2496,11 @@
},
{
"ruleId": "ANALYZE-ESP-004",
"title": "ESP Timeout with 'Continue Anyway' (Soft Failure)",
"description": "Detects an ESP terminal failure on a profile that allows 'Continue anyway'. The enrollment is reported as failed, but the user most likely dismissed the error screen and reached the desktop — a soft failure rather than an unusable device.",
"title": "ESP Gave Up on a Blocking App with 'Continue Anyway' (Soft Failure)",
"description": "Detects an ESP terminal failure where the ESP gave up while a blocking app was still installing (the agent's own esp_apps_timeout verdict — no per-app HRESULT was reported) on a profile that allows 'Continue anyway'. The enrollment is reported as failed, but the user most likely dismissed the error screen and reached the desktop — a soft failure rather than an unusable device. An ESP failure that carries a specific error code (a failed installer, a detection mismatch) is a different case and stays with the rule that explains that code.",
"severity": "warning",
"category": "esp",
"version": "1.0.1",
"version": "1.1.0",
"enabled": true,
"baseConfidence": 80,
"conditions": [
@@ -2521,6 +2521,27 @@
"value": "true",
"required": true
},
{
"signal": "esp_gave_up_on_app",
"source": "event_type",
"eventType": "app_install_failed",
"dataField": "failureType",
"operator": "equals",
"value": "esp_apps_timeout",
"required": true
},
{
"signal": "appName",
"source": "event_data",
"eventType": "app_install_failed",
"dataField": "appName",
"operator": "exists",
"value": "",
"filterField": "failureType",
"filterOperator": "equals",
"filterValue": "esp_apps_timeout",
"required": false
},
{
"signal": "espSyncFailureTimeoutMinutes",
"source": "event_type",
@@ -2533,38 +2554,29 @@
{
"signal": "failedSubcategory",
"source": "event_type",
"eventType": "enrollment_failed",
"eventType": "esp_failure_settle_started",
"dataField": "failedSubcategory",
"operator": "exists",
"value": "",
"required": false
},
{
"signal": "appName",
"source": "event_type",
"eventType": "app_install_failed",
"dataField": "appName",
"operator": "exists",
"value": "",
"required": false
}
],
"confidenceFactors": [
{
"signal": "appName",
"signal": "failedSubcategory",
"condition": "exists",
"weight": 10
}
],
"explanation": "This enrollment was reported as **failed** because the Enrollment Status Page reached its configured terminal timeout (`{{espSyncFailureTimeoutMinutes}} min`) before all blocking items finished. The ESP profile, however, allows **'Continue anyway'** — so the user most likely dismissed the error screen and reached the desktop with a working, though not fully provisioned, device.\n\nThe agent only observes the ESP terminal failure on the device side; it cannot see what the user did after the failure screen. Treat this as a **soft failure**: the device may well be in productive use, while at least one blocking item (`{{failedSubcategory}}` subcategory / app `{{appName}}`) did not complete inside the ESP window.\n\nA cluster of these across a tenant almost always points at one slow blocking app holding the whole fleet at the ESP timeout wall, not at broken devices. Any field still shown as a literal `{{…}}` placeholder was simply not recorded for this session (e.g. a certificate-only failure has no failed app).",
"explanation": "This enrollment was reported as **failed** because the Enrollment Status Page gave up while the blocking app **{{appName}}** was still installing — the agent recorded no per-app error code, only that the app never finished inside the ESP window (the profile's configured limit is `{{espSyncFailureTimeoutMinutes}} min`; the ESP may have stopped earlier than that). The ESP profile, however, allows **'Continue anyway'** — so the user most likely dismissed the error screen and reached the desktop with a working, though not fully provisioned, device.\n\nThe agent only observes the ESP terminal failure on the device side; it cannot see what the user did after the failure screen. Treat this as a **soft failure**: the device may well be in productive use, while the `{{failedSubcategory}}` subcategory did not complete inside the ESP window.\n\nA cluster of these across a tenant almost always points at one slow blocking app holding the whole fleet at the ESP limit, not at broken devices. This rule deliberately stays silent when the failed app reported a specific error code — a failed installer or a detection mismatch is explained by the rule for that code, and 'Continue anyway' does not make it a timing problem. Any field still shown as a literal `{{…}}` placeholder was simply not recorded for this session.",
"remediation": [
{
"title": "Relieve ESP pressure so enrollments finish inside the window",
"steps": [
"Identify the slow blocking app (`{{appName}}`) and either remove it from the ESP 'block device use until these required apps are installed' list, or raise the ESP installation timeout (currently {{espSyncFailureTimeoutMinutes}} min).",
"If the app legitimately needs longer than the ESP allows, make it non-blocking and let it install after the desktop arrives.",
"Verify the app's detection rule matches after install — an app that installs but fails detection times out the ESP on every device (see ANALYZE-APP-013).",
"If a subcategory such as Certificates is reported under '{{failedSubcategory}}', confirm the certificate/connector actually delivers — 'Continue anyway' hides a missing certificate, it does not fix it."
"Look at how long `{{appName}}` takes on a device that completes: if it legitimately needs longer than the ESP allows, make it non-blocking (remove it from 'block device use until these required apps are installed') and let it install after the desktop arrives.",
"If the app must stay blocking, raise the ESP setting 'Show error when installation takes longer than' (configured at {{espSyncFailureTimeoutMinutes}} min) — a limit, not a target; it only helps when the app reliably finishes within the new value.",
"Check the app's dependencies and install order: a blocking app waiting on a large dependency download (Delivery Optimization, proxy throughput) is the usual reason it never finishes in time.",
"If the ESP reported a non-Apps subcategory under '{{failedSubcategory}}', confirm the certificate/connector actually delivers — 'Continue anyway' hides a missing certificate, it does not fix it."
]
}
],
@@ -2794,6 +2806,7 @@
"description": "Detects when a certificate with the configured subject is missing from the local machine personal store (LocalMachine\\My). Requires the gather rule GATHER-ID-002 (machine cert store inventory) to be enabled — the check runs against its gather_machine_cert_store output. A missing certificate may indicate that MDM enrollment certificate provisioning or SCEP certificate deployment failed.",
"severity": "warning",
"category": "identity",
"author": "Community",
"isCommunity": true,
"enabled": false,
"evaluateOn": [
+5 -1
View File
@@ -94,7 +94,11 @@
"C:\\Windows\\Panther",
"C:\\Windows\\SetupDiag",
"C:\\ProgramData\\Microsoft\\DiagnosticLogCSP",
"C:\\Windows\\SoftwareDistribution\\ReportingEvents.log"
"C:\\Windows\\SoftwareDistribution\\ReportingEvents.log",
"C:\\ProgramData\\RealmJoin\\choco\\logs"
],
"userProfileFilePrefixes": [
"AppData\\Local\\RealmJoin"
],
"wmiQueryPrefixes": [
"SELECT * FROM Win32_OperatingSystem",
+1 -1
View File
@@ -190,7 +190,7 @@
},
"operator": {
"type": "string",
"description": "Comparison operator.",
"description": "Comparison operator. exists/not_exists with a dataField test whether ANY event of the type carries a non-empty value at that field: not_exists matches when no event does — including when the event type is absent altogether — so a rule can gate on a missing field (e.g. an ESP failure without an HRESULT). Without a dataField they test only the presence of the event type.",
"enum": ["equals", "not_equals", "contains", "not_contains", "regex", "not_regex", "gt", "lt", "gte", "lte", "exists", "not_exists", "count_gte", "count_per_group_gte", "in", "not_in"]
},
"value": {
+10
View File
@@ -8,6 +8,16 @@
"$schema": { "type": "string" },
"registryPrefixes": { "$ref": "#/$defs/categorizedList" },
"filePrefixes": { "$ref": "#/$defs/stringList" },
"userProfileFilePrefixes": {
"description": "Folders under the signed-in user's profile that file collectors and diagnostics paths may read, RELATIVE to the profile root (e.g. \"AppData\\\\Local\\\\Vendor\"). Resolved against %LOGGED_ON_USER_PROFILE% at match time. Entries outside AppData\\Local / AppData\\Roaming are dropped at load: the C:\\Users hard block never admits them, so this list can only ever narrow what the block's exception already permits.",
"type": "array",
"items": {
"allOf": [
{ "$ref": "#/$defs/safeString" },
{ "pattern": "^AppData\\\\(Local|Roaming)(\\\\|$)" }
]
}
},
"wmiQueryPrefixes": { "$ref": "#/$defs/stringList" },
"eventLogChannels": { "$ref": "#/$defs/categorizedList" },
"blockedEventLogChannels": { "$ref": "#/$defs/stringList" },
+8
View File
@@ -208,6 +208,14 @@ export const ALLOWED_FILE_PREFIXES: readonly string[] = [
${flatArray(guardrails.filePrefixes)}
];
// Folders under the signed-in user's profile, RELATIVE to the profile root. The agent
// resolves %LOGGED_ON_USER_PROFILE% at runtime; the portal validates against a placeholder
// profile. These cannot live in ALLOWED_FILE_PREFIXES — that list is matched literally
// against the already-expanded path, where the user name is unknown at authoring time.
export const USER_PROFILE_FILE_PREFIXES: readonly string[] = [
${flatArray(guardrails.userProfileFilePrefixes ?? [])}
];
export const ALLOWED_WMI_QUERY_PREFIXES: readonly string[] = [
${flatArray(guardrails.wmiQueryPrefixes)}
];
@@ -14,6 +14,22 @@
BeforeAll {
. (Join-Path $PSScriptRoot 'Install-AutopilotMonitor.ps1')
function New-FakeSignature {
param([string]$Status, [string]$Subject)
$cert = if ($Subject) {
[pscustomobject]@{ Subject = $Subject; Thumbprint = '0123456789ABCDEF' }
} else { $null }
return [pscustomobject]@{ Status = $Status; SignerCertificate = $cert }
}
function New-FakePayload {
param([string[]]$Files)
$dir = Join-Path $TestDrive ([guid]::NewGuid().ToString())
New-Item -ItemType Directory -Path $dir -Force | Out-Null
foreach ($f in $Files) { Set-Content -Path (Join-Path $dir $f) -Value 'x' }
return $dir
}
function New-FakeProfile {
param([string]$Name, [double]$AgeMinutes)
$p = Join-Path $TestDrive $Name
@@ -305,3 +321,93 @@ Describe 'logging purity' {
Get-Content $LogFile -Raw | Should -Match 'SKIP: Agent was previously deployed'
}
}
Describe 'Get-UnverifiedAgentBinaries' {
# The publisher gate on the extracted payload. What matters is the DECISION: which
# payload is accepted, which is refused, and which files are looked at at all.
BeforeEach {
Mock Write-Log { }
$script:ours = 'CN=glueckkanja AG, O=glueckkanja AG, C=DE'
}
It 'accepts a payload where every binary of ours is validly signed by us' {
$dir = New-FakePayload -Files @('AutopilotMonitor.Agent.exe', 'AutopilotMonitor.Shared.dll')
Mock Get-AuthenticodeSignature { New-FakeSignature -Status 'Valid' -Subject $script:ours }
Get-UnverifiedAgentBinaries -Path $dir | Should -BeNullOrEmpty
}
It 'checks the binaries we author and leaves third-party assemblies alone' {
$dir = New-FakePayload -Files @(
'AutopilotMonitor.Agent.exe',
'AutopilotMonitor.Agent.exe.config',
'AutopilotMonitor.Shared.dll',
'Newtonsoft.Json.dll',
'System.Management.Automation.dll'
)
$script:checked = @()
Mock Get-AuthenticodeSignature {
$script:checked += (Split-Path $FilePath -Leaf)
New-FakeSignature -Status 'Valid' -Subject $script:ours
}
Get-UnverifiedAgentBinaries -Path $dir | Should -BeNullOrEmpty
$script:checked | Should -Be @('AutopilotMonitor.Agent.exe', 'AutopilotMonitor.Shared.dll')
}
It 'refuses an unsigned agent executable' {
$dir = New-FakePayload -Files @('AutopilotMonitor.Agent.exe')
Mock Get-AuthenticodeSignature { New-FakeSignature -Status 'NotSigned' -Subject $null }
(Get-UnverifiedAgentBinaries -Path $dir).Count | Should -Be 1
}
It 'refuses a tampered binary (hash mismatch)' {
$dir = New-FakePayload -Files @('AutopilotMonitor.Agent.exe')
Mock Get-AuthenticodeSignature { New-FakeSignature -Status 'HashMismatch' -Subject $script:ours }
(Get-UnverifiedAgentBinaries -Path $dir).Count | Should -Be 1
}
It 'refuses a signature whose chain does not validate' {
$dir = New-FakePayload -Files @('AutopilotMonitor.Agent.exe')
Mock Get-AuthenticodeSignature { New-FakeSignature -Status 'UnknownError' -Subject $script:ours }
(Get-UnverifiedAgentBinaries -Path $dir).Count | Should -Be 1
}
It 'refuses a validly signed binary from a different publisher' {
$dir = New-FakePayload -Files @('AutopilotMonitor.Agent.exe')
Mock Get-AuthenticodeSignature { New-FakeSignature -Status 'Valid' -Subject 'CN=Somebody Else, O=Somebody Else Ltd, C=US' }
(Get-UnverifiedAgentBinaries -Path $dir).Count | Should -Be 1
}
It 'refuses the whole payload when a single DLL of ours is swapped' {
$dir = New-FakePayload -Files @('AutopilotMonitor.Agent.exe', 'AutopilotMonitor.Shared.dll')
Mock Get-AuthenticodeSignature {
if ((Split-Path $FilePath -Leaf) -eq 'AutopilotMonitor.Shared.dll') {
New-FakeSignature -Status 'Valid' -Subject 'CN=Somebody Else, O=Somebody Else Ltd, C=US'
} else {
New-FakeSignature -Status 'Valid' -Subject $script:ours
}
}
$rejected = Get-UnverifiedAgentBinaries -Path $dir
$rejected.Count | Should -Be 1
$rejected[0] | Should -BeLike 'AutopilotMonitor.Shared.dll*'
}
It 'refuses when the signature check itself throws' {
$dir = New-FakePayload -Files @('AutopilotMonitor.Agent.exe')
Mock Get-AuthenticodeSignature { throw 'access denied' }
(Get-UnverifiedAgentBinaries -Path $dir).Count | Should -Be 1
}
It 'refuses an empty payload instead of passing it' {
$dir = New-FakePayload -Files @('Newtonsoft.Json.dll')
Mock Get-AuthenticodeSignature { New-FakeSignature -Status 'Valid' -Subject $script:ours }
(Get-UnverifiedAgentBinaries -Path $dir).Count | Should -Be 1
}
}
Describe 'publisher pin' {
It 'pins the expected publisher by subject, not by thumbprint' {
$ExpectedPublisher | Should -Be '*O=glueckkanja AG*'
$ExpectedPublisher | Should -Not -Match '^[0-9A-Fa-f]{40}$'
}
}
+78 -3
View File
@@ -12,8 +12,9 @@
2. Downloads the monitoring agent ZIP from Azure Blob Storage
3. Verifies integrity via SHA-256 hash from the version manifest (mandatory)
4. Extracts the agent into %ProgramData%\AutopilotMonitor\Agent
5. Runs the agent in --install mode (registers Scheduled Task, spawns the runtime)
6. Verifies the runtime process actually launched
5. Verifies the Authenticode signature and publisher of every binary we author
6. Runs the agent in --install mode (registers Scheduled Task, spawns the runtime)
7. Verifies the runtime process actually launched
Agent self-destructs when enrollment completes.
Relax flow (guards 2+3): a real user profile (or a real LastLoggedOnUser)
@@ -76,6 +77,11 @@
PowerShell 5.1 (IME) reads scripts without BOM as ANSI, corrupting multi-byte chars.
.CHANGELOG
2026-09-08 v2.5 Publisher gate: every AutopilotMonitor binary in the extracted
payload must carry a valid Authenticode signature from the
expected publisher before --install runs. The SHA-256 manifest
check stays and is unchanged; it proves the bytes, the signature
proves the author.
2026-08-08 v2.3 Windows 365 Cloud PC support: a positively identified Cloud PC
(Windows365 registry key AND CloudManagedDesktopExtension
service) now triggers the guard 2+3 relax alongside OOBE
@@ -128,7 +134,12 @@ param(
)
# Script version (bump on meaningful changes; see .CHANGELOG above)
$ScriptVersion = "2.4"
$ScriptVersion = "2.5"
# The publisher every binary we author must carry. A -like pattern on the subject, NOT a
# thumbprint: certificates are renewed, deployed copies of this script are not. Same value
# the loader pins for this script.
$ExpectedPublisher = "*O=glueckkanja AG*"
# Configuration - Everything in ProgramData for easy cleanup
$AgentBasePath = "$env:ProgramData\AutopilotMonitor"
@@ -329,6 +340,56 @@ function Get-BootstrapDecision {
return [pscustomobject]@{ Install = $true; ReasonCode = $null; RelaxActive = $relax.Active }
}
# Returns the list of reasons why the extracted payload is not ours; an empty result means
# every binary we author carries a valid Authenticode signature from the expected publisher.
# Third-party assemblies keep their own publisher's signature and are not checked here.
# Any error is a rejection: an unreadable signature is an unverified binary.
function Get-UnverifiedAgentBinaries {
param([string]$Path)
$rejected = @()
$ourBinaries = @(
Get-ChildItem -Path $Path -Filter 'AutopilotMonitor.*' -File -ErrorAction SilentlyContinue |
Where-Object { $_.Extension -in @('.exe', '.dll') }
)
# An empty set is a rejection, not a pass: it means the extraction produced nothing we
# recognise, and the alternative would be a gate that silently approves an empty folder.
# The comma keeps a single rejection an ARRAY: PowerShell unrolls a one-element result to
# a bare string, and the caller reads .Count and indexes into it.
if ($ourBinaries.Count -eq 0) {
return , @("no AutopilotMonitor binaries found in $Path")
}
foreach ($binary in $ourBinaries) {
try {
$sig = Get-AuthenticodeSignature -FilePath $binary.FullName -ErrorAction Stop
}
catch {
$rejected += "$($binary.Name): signature check failed to run ($($_.Exception.Message))"
continue
}
if ($null -eq $sig) {
$rejected += "$($binary.Name): signature check returned nothing"
continue
}
$subject = if ($sig.SignerCertificate) { $sig.SignerCertificate.Subject } else { '<unsigned>' }
if ($sig.Status -ne 'Valid') {
$rejected += "$($binary.Name): signature status $($sig.Status)"
continue
}
if ($subject -notlike $ExpectedPublisher) {
$rejected += "$($binary.Name): unexpected publisher $subject"
continue
}
}
return , $rejected
}
# Main bootstrap flow. Only invoked when the script is run directly (see entry guard
# at the bottom); never on dot-source.
function Invoke-Bootstrap {
@@ -445,6 +506,20 @@ function Invoke-Bootstrap {
}
}
# Publisher gate. The SHA-256 above proves the ZIP is the one the manifest names, but
# that manifest lives in the same container as the ZIP and cannot outlive a compromise
# of the download host. The expected publisher travels inside THIS script, which the
# loader verified before running it, so the chain from the file an administrator
# assigns to the process that starts here stays publisher-anchored end to end.
# Fail-closed, exactly like the hash check: running unverified code as SYSTEM is the
# risk being removed.
Write-Log "Verifying Authenticode signatures of the agent binaries..."
$unverified = Get-UnverifiedAgentBinaries -Path $AgentBinPath
if ($unverified.Count -gt 0) {
throw "Authenticode verification FAILED ($($unverified -join '; ')). Refusing to run an agent that is not signed by the expected publisher."
}
Write-Log "Authenticode verification passed (publisher pin: $ExpectedPublisher)"
Write-Log "Calling agent install mode (--install)..."
& $agentExePath --install
$installExitCode = $LASTEXITCODE
@@ -0,0 +1,132 @@
using System;
using System.Collections.Generic;
using System.Linq;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals;
using AutopilotMonitor.Agent.V2.Core.Orchestration;
using AutopilotMonitor.Agent.V2.Core.SignalAdapters;
using AutopilotMonitor.Agent.V2.Core.Tests.Harness;
using AutopilotMonitor.Agent.V2.Core.Tests.Orchestration;
using AutopilotMonitor.DecisionCore.Signals;
using Xunit;
namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring
{
/// <summary>
/// Session 683f1eff — a Shell-Core 62407 failure (<c>WhiteGlove_Failed</c>) arrived four
/// seconds into the provisioning tracker's 30-s settle window and terminalised the session
/// with nothing but its failure type: the HRESULT (0x80070652) and the failed subcategory
/// (Apps) the registry had already named never reached the terminal event, the backend
/// FailureReason or the termination-time app classification. The coordinator now inherits
/// the pending settle detail onto the Shell-Core args and records the terminal-failure
/// snapshot from it.
/// </summary>
public sealed class EspAndHelloTrackerShellCoreFailureInheritanceTests
{
private static readonly DateTime Fixed = new DateTime(2026, 9, 8, 18, 11, 6, DateTimeKind.Utc);
private sealed class Fixture : IDisposable
{
public TempDirectory Tmp { get; } = new TempDirectory();
public AgentLogger Logger { get; }
public FakeSignalIngressSink Ingress { get; } = new FakeSignalIngressSink();
public FakeSignalIngressSink TrackerPostSink { get; } = new FakeSignalIngressSink();
public VirtualClock Clock { get; } = new VirtualClock(Fixed);
public List<EspFailureDetectedEventArgs> Forwarded { get; } = new List<EspFailureDetectedEventArgs>();
public Fixture() { Logger = new AgentLogger(Tmp.Path, AgentLogLevel.Debug); }
public EspAndHelloTracker BuildCoordinator(Func<EspFailureDetectedEventArgs?> pendingProbe)
{
var coordinator = new EspAndHelloTracker(
sessionId: "S1",
tenantId: "T1",
post: new InformationalEventPost(TrackerPostSink, Clock),
logger: Logger,
skipConfigProbe: () => ((bool?)false, (bool?)false),
accountSetupActivityProbe: () => false,
pendingEspFailureProbe: pendingProbe);
coordinator.EspFailureDetected += (_, args) => Forwarded.Add(args);
return coordinator;
}
public FakeSignalIngressSink.PostedSignal TerminalSignal() =>
Assert.Single(Ingress.Posted, p => p.Kind == DecisionSignalKind.EspTerminalFailure);
public void Dispose() { Tmp.Dispose(); }
}
private static EspFailureDetectedEventArgs PendingAppsFailure() => new EspFailureDetectedEventArgs(
failureType: "Provisioning_DeviceSetup_Apps_Failed",
errorCode: "0x80070652",
failedSubcategory: "Apps",
category: "DeviceSetup",
likelyCulpritApps: new[] { "ESP Finalizer US" });
[Fact]
public void ShellCore_failure_inside_the_settle_window_inherits_the_registry_detail()
{
using var f = new Fixture();
using var coordinator = f.BuildCoordinator(PendingAppsFailure);
using var adapter = new EspAndHelloTrackerAdapter(coordinator, f.Ingress, f.Clock);
coordinator.TriggerShellCoreEspFailureForTest("WhiteGlove_Failed");
var args = Assert.Single(f.Forwarded);
Assert.Equal("WhiteGlove_Failed", args.FailureType); // the signal that terminalised
Assert.Equal("0x80070652", args.ErrorCode);
Assert.Equal("Apps", args.FailedSubcategory);
Assert.Equal("DeviceSetup", args.Category);
Assert.Equal(new[] { "ESP Finalizer US" }, args.LikelyCulpritApps);
// Wire-through: the EspTerminalFailure signal payload carries the detail the
// DecisionEngine copies onto enrollment_failed.
var signal = f.TerminalSignal();
Assert.Equal("WhiteGlove_Failed", signal.Payload!["failureType"]);
Assert.Equal("0x80070652", signal.Payload["errorCode"]);
Assert.Equal("Apps", signal.Payload["failedSubcategory"]);
Assert.Equal("DeviceSetup", signal.Payload["category"]);
Assert.Equal("ESP Finalizer US", signal.Payload["likelyCulpritApps"]);
// Termination-time classification reads the same context.
Assert.NotNull(coordinator.LastEspTerminalFailure);
Assert.Equal("0x80070652", coordinator.LastEspTerminalFailure.ErrorCode);
Assert.True(coordinator.LastEspTerminalFailure.IsAppsSubcategory);
}
[Fact]
public void ShellCore_failure_without_a_pending_window_stays_bare()
{
using var f = new Fixture();
using var coordinator = f.BuildCoordinator(() => null);
using var adapter = new EspAndHelloTrackerAdapter(coordinator, f.Ingress, f.Clock);
coordinator.TriggerShellCoreEspFailureForTest("ESPProgress_Timeout");
var args = Assert.Single(f.Forwarded);
Assert.Equal("ESPProgress_Timeout", args.FailureType);
Assert.Null(args.ErrorCode);
Assert.Null(args.FailedSubcategory);
Assert.Null(args.Category);
Assert.Empty(args.LikelyCulpritApps);
Assert.Null(coordinator.LastEspTerminalFailure);
var signal = f.TerminalSignal();
Assert.False(signal.Payload!.ContainsKey("errorCode"));
Assert.False(signal.Payload.ContainsKey("failedSubcategory"));
}
[Fact]
public void A_throwing_probe_degrades_to_the_bare_failure()
{
using var f = new Fixture();
using var coordinator = f.BuildCoordinator(() => throw new InvalidOperationException("probe"));
coordinator.TriggerShellCoreEspFailureForTest("WhiteGlove_Failed");
var args = Assert.Single(f.Forwarded);
Assert.Equal("WhiteGlove_Failed", args.FailureType);
Assert.Null(args.ErrorCode);
}
}
}
@@ -456,5 +456,124 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Gather
SingleSecurityWarning();
}
// -------------------------------------------------------------------
// %LOGGED_ON_USER_PROFILE% exception (userProfilePath overload)
//
// The token lifts the C:\Users hard block for AppData\Local and
// AppData\Roaming — and nothing more. The allowlist still decides,
// which is what the cases below pin down: the exception is a gate the
// allowlist has to open, never an allowance of its own.
// -------------------------------------------------------------------
private const string TestProfile = @"C:\Users\TestUser";
[Fact]
public void UserProfile_AppDataPath_WithoutAllowlistEntry_IsStillBlocked()
{
// The lifted hard block alone admits nothing: without a matching
// userProfileFilePrefixes entry the path falls through to the
// allowlist and is refused there.
Assert.False(GatherRuleGuards.IsFilePathAllowed(
TestProfile + @"\AppData\Local\UnlistedVendor\app.log",
unrestrictedMode: false, userProfilePath: TestProfile));
}
[Fact]
public void UserProfile_OutsideAppData_IsBlockedByTheHardBlock()
{
foreach (var target in new[] { @"\Desktop\secret.txt", @"\Documents\notes.txt", @"\ntuser.dat" })
{
Assert.False(GatherRuleGuards.IsFilePathAllowed(
TestProfile + target, unrestrictedMode: false, userProfilePath: TestProfile));
}
}
[Fact]
public void UserProfile_NullProfile_KeepsTheUsersHardBlock()
{
// No interactive user detected — the exception cannot apply and the
// path stays under the plain C:\Users block.
Assert.False(GatherRuleGuards.IsFilePathAllowed(
@"C:\Users\TestUser\AppData\Local\UnlistedVendor\app.log",
unrestrictedMode: false, userProfilePath: null));
}
[Fact]
public void UserProfile_TraversalOutOfAppData_IsBlocked()
{
// Spelling Documents as a traversal out of AppData must not survive
// Path.GetFullPath normalisation.
const string traversal = @"C:\Users\TestUser\AppData\Local\..\..\Documents\secret.txt";
Assert.Equal(@"C:\Users\TestUser\Documents\secret.txt", Path.GetFullPath(traversal));
Assert.False(GatherRuleGuards.IsFilePathAllowed(
traversal, unrestrictedMode: false, userProfilePath: TestProfile));
}
[Fact]
public void UserProfile_ForeignProfile_IsBlockedEvenUnderAppData()
{
// The exception is scoped to the DETECTED profile — a rule must not
// reach a second user's AppData by spelling the path out.
Assert.False(GatherRuleGuards.IsFilePathAllowed(
@"C:\Users\OtherUser\AppData\Local\UnlistedVendor\app.log",
unrestrictedMode: false, userProfilePath: TestProfile));
}
[Fact]
public void UserProfile_AllowlistedVendorFolder_IsAllowed()
{
// AppData\Local\RealmJoin is on userProfileFilePrefixes: the file itself, a
// subfolder below it, and the folder itself all pass.
foreach (var target in new[] { @"\tray.log", @"\Logs\rj.log", "" })
{
Assert.True(GatherRuleGuards.IsFilePathAllowed(
TestProfile + @"\AppData\Local\RealmJoin" + target,
unrestrictedMode: false, userProfilePath: TestProfile),
$"expected allowed: ...\\RealmJoin{target}");
}
}
[Fact]
public void UserProfile_SiblingOfAnAllowlistedVendorFolder_IsBlocked()
{
// Segment-bounded: "RealmJoin" must not admit "RealmJoinSomethingElse".
Assert.False(GatherRuleGuards.IsFilePathAllowed(
TestProfile + @"\AppData\Local\RealmJoinSomethingElse\tray.log",
unrestrictedMode: false, userProfilePath: TestProfile));
}
[Fact]
public void UserProfile_AllowlistedVendorFolder_InAForeignProfile_IsBlocked()
{
// The allowlist is anchored to the DETECTED profile, not to C:\Users\*.
Assert.False(GatherRuleGuards.IsFilePathAllowed(
@"C:\Users\OtherUser\AppData\Local\RealmJoin\tray.log",
unrestrictedMode: false, userProfilePath: TestProfile));
}
[Fact]
public void UserProfile_AllowlistedVendorFolder_WithoutADetectedUser_IsBlocked()
{
Assert.False(GatherRuleGuards.IsFilePathAllowed(
@"C:\Users\TestUser\AppData\Local\RealmJoin\tray.log",
unrestrictedMode: false, userProfilePath: null));
}
[Fact]
public void UserProfile_AppDataPath_IsAllowedInUnrestrictedMode()
{
// Where the exception does bite today: unrestricted mode returns
// before the allowlist, so the lifted hard block is the whole story.
Assert.True(GatherRuleGuards.IsFilePathAllowed(
TestProfile + @"\AppData\Local\UnlistedVendor\app.log",
unrestrictedMode: true, userProfilePath: TestProfile));
// ...but only under AppData — Documents stays blocked even there.
Assert.False(GatherRuleGuards.IsFilePathAllowed(
TestProfile + @"\Documents\secret.txt",
unrestrictedMode: true, userProfilePath: TestProfile));
}
}
}
@@ -0,0 +1,92 @@
using System;
using AutopilotMonitor.Agent.V2.Core.Logging;
using AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals;
using AutopilotMonitor.Agent.V2.Core.Orchestration;
using AutopilotMonitor.Agent.V2.Core.Tests.Harness;
using AutopilotMonitor.Agent.V2.Core.Tests.Orchestration;
using Xunit;
namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.SystemSignals
{
/// <summary>
/// <see cref="ProvisioningStatusTracker.TryGetPendingFailureArgs"/> exposes the registry
/// failure detail while its settle window is open and nothing once the window has fired —
/// the coordinator reads it when a Shell-Core failure terminalises first (session 683f1eff).
/// </summary>
public sealed class ProvisioningStatusTrackerPendingFailureTests
{
private static readonly DateTime Fixed = new DateTime(2026, 9, 8, 18, 11, 2, DateTimeKind.Utc);
private const string InProgressJson = @"{
""categorySucceeded"": null,
""AppsSubcategory"": {""subcategoryState"":""inProgress"",""subcategoryStatusText"":""Apps (Working)""}
}";
private const string AppsFailedJson = @"{
""categorySucceeded"": null,
""AppsSubcategory"": {""subcategoryState"":""failed"",""subcategoryStatusText"":""Apps (0x80070652)""}
}";
private sealed class Fixture : IDisposable
{
public TempDirectory Tmp { get; } = new TempDirectory();
public ProvisioningStatusTracker Tracker { get; }
public Fixture()
{
var post = new InformationalEventPost(new FakeSignalIngressSink(), new VirtualClock(Fixed));
var logger = new AgentLogger(Tmp.Path, AgentLogLevel.Info);
Tracker = new ProvisioningStatusTracker(
sessionId: "S1",
tenantId: "T1",
post: post,
logger: logger,
appxScanner: new FakeAppxDeploymentFailureScanner(),
backgroundDispatcher: action => action());
}
public void Dispose()
{
Tracker.Dispose();
Tmp.Dispose();
}
}
[Fact]
public void Nothing_pending_before_any_failure()
{
using var f = new Fixture();
Assert.Null(f.Tracker.TryGetPendingFailureArgs());
f.Tracker.ProcessCategoryStatusForTest("DeviceSetupCategory.Status", InProgressJson);
Assert.Null(f.Tracker.TryGetPendingFailureArgs());
}
[Fact]
public void Armed_settle_window_exposes_the_registry_detail()
{
using var f = new Fixture();
f.Tracker.ProcessCategoryStatusForTest("DeviceSetupCategory.Status", InProgressJson);
f.Tracker.ProcessCategoryStatusForTest("DeviceSetupCategory.Status", AppsFailedJson);
var pending = f.Tracker.TryGetPendingFailureArgs();
Assert.NotNull(pending);
Assert.Equal("Provisioning_DeviceSetup_Apps_Failed", pending!.FailureType);
Assert.Equal("0x80070652", pending.ErrorCode);
Assert.Equal("Apps", pending.FailedSubcategory);
Assert.Equal("DeviceSetup", pending.Category);
}
[Fact]
public void Expired_settle_window_leaves_nothing_pending()
{
using var f = new Fixture();
f.Tracker.ProcessCategoryStatusForTest("DeviceSetupCategory.Status", InProgressJson);
f.Tracker.ProcessCategoryStatusForTest("DeviceSetupCategory.Status", AppsFailedJson);
f.Tracker.TriggerSettleTimerForTest("DeviceSetupCategory.Status");
Assert.Null(f.Tracker.TryGetPendingFailureArgs());
}
}
}
@@ -56,6 +56,31 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Telemetry.Gather
LoadEmbeddedGuardrails()["maxCommandLength"]!.Value<int>());
}
[Fact]
public void User_profile_prefixes_are_all_accepted_by_the_loader()
{
// The loader drops entries outside AppData\Local / AppData\Roaming (the hard block
// would never release them anyway). A dropped entry is invisible at runtime — it
// just never matches — so a typo in the JSON must fail here instead.
var json = LoadEmbeddedGuardrails()["userProfileFilePrefixes"]?.ToObject<string[]>()
?? new string[0];
Assert.Equal(
json.Select(p => p.Trim().TrimEnd('\\')).OrderBy(p => p),
GatherRuleGuards.AllowedUserProfileFilePrefixes.OrderBy(p => p));
}
[Fact]
public void User_profile_prefixes_stay_under_the_hard_blocks_exception()
{
Assert.All(
GatherRuleGuards.AllowedUserProfileFilePrefixes,
prefix => Assert.Contains(
GatherRuleGuards.AllowedUserProfileSubdirs,
subdir => prefix.StartsWith(subdir, System.StringComparison.OrdinalIgnoreCase) &&
(prefix.Length == subdir.Length || prefix[subdir.Length] == '\\')));
}
[Fact]
public void Blocked_event_log_channels_match_code_constants()
{
@@ -265,6 +265,42 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Orchestration
sut.Stop();
}
[Fact]
public void Deadline_fired_late_keeps_the_due_time_as_stamp_and_carries_it_in_the_payload()
{
// A deadline that was due while the device slept (or the agent was down) fires only
// afterwards. The signal keeps the due time as OccurredAtUtc (D-238: the outage must not
// become session duration) and repeats it in the payload so the stale-fire guards
// identify the incarnation independently of the stamp.
using var rig = new EnrollmentOrchestratorRig(At);
var sut = rig.Build();
sut.Start();
var dueAt = At.AddMinutes(-5);
var scheduler = GetScheduler(sut);
scheduler.Schedule(new ActiveDeadline(
name: "hello_safety",
dueAtUtc: dueAt,
firesSignalKind: DecisionSignalKind.DeadlineFired,
firesPayload: new Dictionary<string, string> { [SignalPayloadKeys.Deadline] = "hello_safety" }));
var signalLog = GetSignalLog(sut);
Assert.True(SpinWait.SpinUntil(() => ContainsDeadlineFired(signalLog), 3000));
DecisionSignal? fired = null;
foreach (var sig in signalLog.ReadAll())
{
if (sig.Kind == DecisionSignalKind.DeadlineFired) { fired = sig; break; }
}
Assert.NotNull(fired);
Assert.Equal(dueAt, fired!.OccurredAtUtc);
Assert.NotNull(fired.Payload);
Assert.Equal("hello_safety", fired.Payload![SignalPayloadKeys.Deadline]);
Assert.Equal(dueAt.ToString("O"), fired.Payload[SignalPayloadKeys.DeadlineDueAtUtc]);
sut.Stop();
}
// ========================================================================= Quarantine
[Fact]
@@ -44,6 +44,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
private readonly Func<bool> _userEspAppsSettledProbe;
private readonly Func<System.Collections.Generic.IReadOnlyList<Ime.AppPackageState>> _starvedUserEspAppsProbe;
private readonly Func<System.Collections.Generic.IReadOnlyList<Ime.AppPackageState>> _packageStatesProbe;
// Session 683f1eff: registry failure detail still sitting in an open settle window,
// consulted when a Shell-Core failure terminalises first (see OnShellCoreEspFailureDetected).
private readonly Func<EspFailureDetectedEventArgs> _pendingEspFailureProbe;
// Session caa6cf50 gate-starvation fix (2026-06-11) — fire-once guard for the
// user-ESP-apps-settled AccountSetup synthesis (see MaybeSynthesizeAccountSetupComplete).
@@ -174,8 +177,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
/// late "Installing-→-Error" promotion can classify the failure correctly
/// AND refuse to promote when the failure originated outside the Apps
/// subcategory (a non-Apps HRESULT does not describe per-app outcome).
/// Null when no HRESULT-carrying ESP failure has fired (or all observed
/// failures came from ShellCoreTracker, which has no HRESULT surface).
/// Null when no registry-derived failure detail has been observed — neither from
/// a settle window that expired nor from one a Shell-Core failure inherited.
/// </summary>
public Termination.EspTerminalFailureSnapshot LastEspTerminalFailure { get; private set; }
@@ -243,7 +246,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
Func<bool> accountSetupActivityProbe = null,
Func<bool> userEspAppsSettledProbe = null,
Func<System.Collections.Generic.IReadOnlyList<Ime.AppPackageState>> starvedUserEspAppsProbe = null,
Func<System.Collections.Generic.IReadOnlyList<Ime.AppPackageState>> packageStatesProbe = null)
Func<System.Collections.Generic.IReadOnlyList<Ime.AppPackageState>> packageStatesProbe = null,
Func<EspFailureDetectedEventArgs> pendingEspFailureProbe = null)
{
_sessionId = sessionId ?? throw new ArgumentNullException(nameof(sessionId));
_tenantId = tenantId ?? throw new ArgumentNullException(nameof(tenantId));
@@ -277,6 +281,10 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
// provisioning tracker name not-completed apps on an Apps-subcategory failure.
_packageStatesProbe = packageStatesProbe
?? (() => Array.Empty<Ime.AppPackageState>());
// Test seam: defaults to the provisioning tracker's open settle window (null when
// none is armed or the tracker is not running, e.g. Device Preparation).
_pendingEspFailureProbe = pendingEspFailureProbe
?? (() => _provisioningTracker?.TryGetPendingFailureArgs());
}
/// <summary>
@@ -658,6 +666,11 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
internal void TriggerEspExitedForTest(DateTime occurredAtUtc) =>
OnEspExited(this, new EspExitedEventArgs(occurredAtUtc));
// Test seam for a Shell-Core 62407 failure — drives the coordinator forwarder including
// the pending-settle inheritance, without a real ShellCoreTracker.
internal void TriggerShellCoreEspFailureForTest(string failureType) =>
OnShellCoreEspFailureDetected(this, failureType);
// Test seam for HelloWizardStarted — same contract as TriggerEspExitedForTest.
internal void TriggerHelloWizardStartedForTest(DateTime occurredAtUtc) =>
OnHelloWizardStarted(this, new HelloWizardStartedEventArgs(occurredAtUtc));
@@ -673,33 +686,56 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
// Forwarder for ShellCoreTracker (event-log-derived ESP failures, e.g. Shell-Core 62407
// failure descriptions). Source-event timestamp is mirrored so the adapter can stamp the
// DecisionSignal with the historical instant on backfill. ShellCoreTracker has no HRESULT
// surface, so only FailureType is set on the args.
// surface; the registry detail is inherited from an open settle window (see below).
private void OnShellCoreEspFailureDetected(object sender, string failureType)
{
LastEventOccurredAtUtc = (sender as ShellCoreTracker)?.LastEventOccurredAtUtc;
try
{
EspFailureDetected?.Invoke(this, new EspFailureDetectedEventArgs(failureType));
EspFailureDetected?.Invoke(this, BuildShellCoreFailureArgs(failureType));
}
catch (Exception ex) { _logger.Error($"Error forwarding ShellCore EspFailureDetected for '{failureType}'", ex); }
finally { LastEventOccurredAtUtc = null; }
}
// Forwarder for ProvisioningStatusTracker (registry-derived ESP failures). Args carry the
// full failure detail (FailureType, ErrorCode, FailedSubcategory, Category) extracted
// from the failed subcategory's statusText. Provisioning has no source-event timestamp
// surfaced today, so the adapter falls back to clock.
private void OnProvisioningEspFailureDetected(object sender, EspFailureDetectedEventArgs args)
// Session 683f1eff: the Shell-Core 62407 failure usually lands INSIDE the provisioning
// tracker's 30-s settle window — after the registry named the failed subcategory and its
// HRESULT, before the settle timer would have forwarded them. The engine terminalises on
// the first EspTerminalFailure and the agent stops seconds later, so whatever this signal
// carries is all the terminal event, the backend FailureReason and the termination-time
// app classification ever see (a third of all ESP terminal failures took this path). The
// pending detail is inherited here; FailureType stays the Shell-Core value because that
// is the signal that actually terminalised.
private EspFailureDetectedEventArgs BuildShellCoreFailureArgs(string failureType)
{
EspFailureDetectedEventArgs pending = null;
try { pending = _pendingEspFailureProbe(); }
catch (Exception ex) { _logger.Warning($"EspAndHelloTracker: pending ESP failure probe threw: {ex.Message}"); }
if (pending == null)
return new EspFailureDetectedEventArgs(failureType);
RecordTerminalFailureSnapshot(pending);
_logger.Info(
$"EspAndHelloTracker: Shell-Core failure '{failureType}' inherits the pending provisioning failure detail " +
$"(category={pending.Category ?? "n/a"}, failedSubcategory={pending.FailedSubcategory ?? "n/a"}, " +
$"errorCode={pending.ErrorCode ?? "n/a"})");
return new EspFailureDetectedEventArgs(
failureType,
errorCode: pending.ErrorCode,
failedSubcategory: pending.FailedSubcategory,
category: pending.Category,
likelyCulpritApps: pending.LikelyCulpritApps);
}
// Session 080edee9 follow-up + Codex review (P2/P3) — snapshot the full failure context
// (HRESULT + failedSubcategory + category) so EnrollmentTerminationHandler can read it on
// the terminal-failure pathway. Only update when the args carry at least one of the three
// fields, so a bare Shell-Core failure cannot wipe out the registry snapshot. Deliberately
// NOT gated on ErrorCode alone — a non-Apps subcategory failure without HRESULT is still
// useful for downstream "should we promote?" gating.
private void RecordTerminalFailureSnapshot(EspFailureDetectedEventArgs args)
{
LastEventOccurredAtUtc = null;
// Session 080edee9 follow-up + Codex review (P2/P3) — snapshot the full
// failure context (HRESULT + failedSubcategory + category) before
// forwarding so EnrollmentTerminationHandler can read it on the terminal-
// failure pathway. Only update when the args carry at least one of the
// three fields, so a later ShellCore-derived failure (which has none of
// them) cannot wipe out the registry snapshot. We deliberately do NOT
// gate on ErrorCode alone — a non-Apps subcategory failure without
// HRESULT is still useful for downstream "should we promote?" gating.
if (!string.IsNullOrEmpty(args?.ErrorCode)
|| !string.IsNullOrEmpty(args?.FailedSubcategory)
|| !string.IsNullOrEmpty(args?.Category))
@@ -709,6 +745,16 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
failedSubcategory: args.FailedSubcategory,
category: args.Category);
}
}
// Forwarder for ProvisioningStatusTracker (registry-derived ESP failures). Args carry the
// full failure detail (FailureType, ErrorCode, FailedSubcategory, Category) extracted
// from the failed subcategory's statusText. Provisioning has no source-event timestamp
// surfaced today, so the adapter falls back to clock.
private void OnProvisioningEspFailureDetected(object sender, EspFailureDetectedEventArgs args)
{
LastEventOccurredAtUtc = null;
RecordTerminalFailureSnapshot(args);
try
{
EspFailureDetected?.Invoke(this, args);
@@ -80,6 +80,14 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
"AccountSetupCategory.Status"
};
// Order in which TryGetPendingFailureArgs resolves concurrently armed settle windows.
private static readonly string[] PendingFailurePreference =
{
"DeviceSetupCategory.Status",
"AccountSetupCategory.Status",
"DevicePreparationCategory.Status"
};
private readonly AgentLogger _logger;
private readonly string _sessionId;
private readonly string _tenantId;
@@ -1711,6 +1719,29 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
internal void TriggerSettleTimerForTest(string categoryName)
=> OnProvisioningFailureSettleExpired(categoryName);
/// <summary>
/// The registry-derived failure detail of a settle window that is still open (armed,
/// not yet expired or retracted) — null when none is pending. Read by the coordinator
/// when a Shell-Core 62407 failure arrives inside the window, so the terminal signal
/// inherits HRESULT / failed subcategory / category instead of racing them away
/// (session 683f1eff). Windows fail one category at a time, but should two be armed
/// the device-phase category wins: it is the one the ESP page reports.
/// </summary>
internal EspFailureDetectedEventArgs TryGetPendingFailureArgs()
{
lock (_stateLock)
{
if (_provisioningFailureSettleArgs == null || _provisioningFailureSettleArgs.Count == 0)
return null;
foreach (var category in PendingFailurePreference)
{
if (_provisioningFailureSettleArgs.TryGetValue(category, out var args) && args != null)
return args;
}
return null;
}
}
private bool HasCategorySucceededChanged(string categoryName, bool? newValue)
{
if (!_lastCategorySucceeded.TryGetValue(categoryName, out var oldValue))
@@ -70,12 +70,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Gather
@"C:\Windows\System32\config", // SAM, SECURITY, SYSTEM hives
};
// Allowed subdirectories under a user profile (used with %LOGGED_ON_USER_PROFILE% token)
private static readonly string[] AllowedUserProfileSubdirs = new[]
{
@"AppData\Local",
@"AppData\Roaming",
};
// The allowed user-profile subdirectories and the vendor allowlist under them live in
// GatherRuleGuards, which owns the embedded guardrails.json — one copy for both guards.
/// <summary>
/// Returns true if the given path is allowed for diagnostics collection.
@@ -135,7 +131,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Gather
(normalizedDir.Length == BlockedUsersPrefix.Length ||
normalizedDir[BlockedUsersPrefix.Length] == Path.DirectorySeparatorChar))
{
if (!IsUserProfileSubpathAllowed(normalizedDir, userProfilePath))
if (!GatherRuleGuards.IsUserProfileSubpathAllowed(normalizedDir, userProfilePath))
return false;
}
@@ -169,7 +165,10 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Gather
}
}
return false;
// Vendor folders under the signed-in user's profile — same allowlist the file
// collectors use, since it answers the same question: which folders below a
// profile carry enrollment-relevant logs rather than the user's own data.
return GatherRuleGuards.IsUserProfilePathOnAllowlist(normalizedDir, userProfilePath);
}
catch
{
@@ -178,38 +177,6 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Gather
}
}
/// <summary>
/// Returns true if the normalized path falls under one of the allowed subdirectories
/// of the detected user profile (AppData\Local, AppData\Roaming).
/// Only applies when %LOGGED_ON_USER_PROFILE% was used to resolve the path.
/// </summary>
internal static bool IsUserProfileSubpathAllowed(string normalizedPath, string userProfilePath)
{
if (string.IsNullOrEmpty(userProfilePath))
return false;
try
{
var normalizedProfile = Path.GetFullPath(userProfilePath);
foreach (var subdir in AllowedUserProfileSubdirs)
{
var allowedPrefix = Path.GetFullPath(Path.Combine(normalizedProfile, subdir));
if (normalizedPath.StartsWith(allowedPrefix, StringComparison.OrdinalIgnoreCase) &&
(normalizedPath.Length == allowedPrefix.Length ||
normalizedPath[allowedPrefix.Length] == Path.DirectorySeparatorChar))
{
return true;
}
}
}
catch
{
// Path normalization failure — deny
}
return false;
}
/// <summary>
/// Checks whether any component of the path (directories or file) is a symlink,
/// junction, or other reparse point. Returns true if a reparse point is detected.
@@ -32,6 +32,16 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Gather
// -----------------------------------------------------------------------
public static readonly IReadOnlyList<string> AllowedRegistryPrefixes;
public static readonly IReadOnlyList<string> AllowedFilePrefixes;
/// <summary>
/// Folders under the signed-in user's profile that file collectors and
/// admin-configured diagnostics paths may read, RELATIVE to the profile root
/// (e.g. <c>AppData\Local\Vendor</c>). Resolved against the path
/// %LOGGED_ON_USER_PROFILE% produced, at match time — the profile name is not
/// known when the list is authored, which is why these entries cannot live in
/// <see cref="AllowedFilePrefixes"/> (matched literally against the expanded path).
/// </summary>
public static readonly IReadOnlyList<string> AllowedUserProfileFilePrefixes;
public static readonly IReadOnlyList<string> AllowedWmiQueryPrefixes;
public static readonly IReadOnlyCollection<string> AllowedCommands;
public static readonly IReadOnlyList<string> AllowedEventLogChannels;
@@ -63,8 +73,10 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Gather
Path.GetFullPath(@"C:\Windows\System32\config"), // SAM, SECURITY, SYSTEM hives
};
// Allowed subdirectories under a user profile (used with %LOGGED_ON_USER_PROFILE% token)
private static readonly string[] AllowedUserProfileSubdirs = new[]
// The only subdirectories of a user profile the C:\Users hard block will ever
// release (used with %LOGGED_ON_USER_PROFILE%). Single copy for both guards —
// DiagnosticsPathGuards delegates here.
internal static readonly string[] AllowedUserProfileSubdirs = new[]
{
@"AppData\Local",
@"AppData\Roaming",
@@ -118,6 +130,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Gather
AllowedRegistryPrefixes = FlattenCategorized(obj, "registryPrefixes", "prefixes");
AllowedFilePrefixes = obj["filePrefixes"]?.ToObject<List<string>>() ?? new List<string>();
AllowedUserProfileFilePrefixes = LoadUserProfilePrefixes(obj);
AllowedWmiQueryPrefixes = obj["wmiQueryPrefixes"]?.ToObject<List<string>>() ?? new List<string>();
var commands = FlattenCategorized(obj, "allowedCommands", "commands");
@@ -136,6 +149,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Gather
AllowedRegistryPrefixes = new List<string>();
AllowedFilePrefixes = new List<string>();
AllowedUserProfileFilePrefixes = new List<string>();
AllowedWmiQueryPrefixes = new List<string>();
AllowedCommands = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
AllowedEventLogChannels = new List<string>();
@@ -143,6 +157,43 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Gather
ResidualWmiPrefixes = new List<string>();
}
/// <summary>
/// Reads <c>userProfileFilePrefixes</c> and drops every entry that is rooted, carries a
/// traversal, or does not sit under one of <see cref="AllowedUserProfileSubdirs"/>.
/// The C:\Users hard block releases nothing outside AppData, so such an entry could only
/// ever be dead text — dropping it at load keeps the list honest instead of silently
/// ineffective, and no configuration can widen the hard block's exception.
/// </summary>
private static List<string> LoadUserProfilePrefixes(JObject obj)
{
var raw = obj["userProfileFilePrefixes"]?.ToObject<List<string>>() ?? new List<string>();
var result = new List<string>();
foreach (var entry in raw)
{
if (string.IsNullOrWhiteSpace(entry))
continue;
var trimmed = entry.Trim().TrimEnd('\\');
if (Path.IsPathRooted(trimmed))
continue;
if (trimmed.IndexOf("..", StringComparison.Ordinal) >= 0)
continue;
foreach (var subdir in AllowedUserProfileSubdirs)
{
if (trimmed.StartsWith(subdir, StringComparison.OrdinalIgnoreCase) &&
(trimmed.Length == subdir.Length || trimmed[subdir.Length] == '\\'))
{
result.Add(trimmed);
break;
}
}
}
return result;
}
private static void DeriveWmiClassAllowlist(
IReadOnlyList<string> entries,
out HashSet<string> classes,
@@ -265,12 +316,13 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Gather
// C:\Users block always applies (even in unrestricted mode)
// Exception: paths under <userProfilePath>\AppData\Local or AppData\Roaming
// are allowed when the %LOGGED_ON_USER_PROFILE% token was used.
// are allowed when the %LOGGED_ON_USER_PROFILE% token was used. The exception
// only LIFTS the block — in restricted mode the allowlist below still decides.
if (normalizedPath.StartsWith(BlockedUsersPrefix, StringComparison.OrdinalIgnoreCase) &&
(normalizedPath.Length == BlockedUsersPrefix.Length ||
normalizedPath[BlockedUsersPrefix.Length] == Path.DirectorySeparatorChar))
{
if (!DiagnosticsPathGuards.IsUserProfileSubpathAllowed(normalizedPath, userProfilePath))
if (!IsUserProfileSubpathAllowed(normalizedPath, userProfilePath))
return false;
}
@@ -288,9 +340,61 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Gather
if (unrestrictedMode)
return true;
return AllowedFilePrefixes.Any(prefix =>
if (AllowedFilePrefixes.Any(prefix =>
normalizedPath.StartsWith(prefix, StringComparison.OrdinalIgnoreCase) &&
(normalizedPath.Length == prefix.Length || normalizedPath[prefix.Length] == '\\'));
(normalizedPath.Length == prefix.Length || normalizedPath[prefix.Length] == '\\')))
{
return true;
}
// Vendor folders under the signed-in user's profile. Only reachable when the rule
// spelled %LOGGED_ON_USER_PROFILE% and the resolver found an interactive user —
// a null profile denies, so a machine with nobody signed in cannot widen anything.
return IsUserProfilePathOnAllowlist(normalizedPath, userProfilePath);
}
/// <summary>
/// True when the normalized path sits under one of <see cref="AllowedUserProfileSubdirs"/>
/// of the detected user profile. This is the C:\Users hard block's only exception; it
/// releases the block and nothing else. A null profile denies.
/// </summary>
internal static bool IsUserProfileSubpathAllowed(string normalizedPath, string userProfilePath)
=> AllowedUserProfileSubdirs.Any(subdir =>
MatchesProfileRelativePrefix(normalizedPath, userProfilePath, subdir));
/// <summary>
/// True when the normalized path is admitted by an entry of
/// <see cref="AllowedUserProfileFilePrefixes"/> under the detected user profile.
/// </summary>
internal static bool IsUserProfilePathOnAllowlist(string normalizedPath, string userProfilePath)
=> AllowedUserProfileFilePrefixes.Any(prefix =>
MatchesProfileRelativePrefix(normalizedPath, userProfilePath, prefix));
/// <summary>
/// Segment-bounded match of <paramref name="normalizedPath"/> against
/// &lt;profile&gt;\&lt;relativePrefix&gt;. Both sides go through Path.GetFullPath, so a
/// traversal spelled into either one cannot slip past the boundary check.
/// </summary>
private static bool MatchesProfileRelativePrefix(
string normalizedPath, string userProfilePath, string relativePrefix)
{
if (string.IsNullOrEmpty(normalizedPath) || string.IsNullOrEmpty(userProfilePath))
return false;
try
{
var allowedPrefix = Path.GetFullPath(
Path.Combine(Path.GetFullPath(userProfilePath), relativePrefix));
return normalizedPath.StartsWith(allowedPrefix, StringComparison.OrdinalIgnoreCase) &&
(normalizedPath.Length == allowedPrefix.Length ||
normalizedPath[allowedPrefix.Length] == Path.DirectorySeparatorChar);
}
catch
{
// Path normalization failure — deny.
return false;
}
}
/// <summary>
@@ -9,9 +9,11 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
/// <para>
/// The orchestrator consumes this event and translates it into a synthetic
/// <c>DeadlineFired</c>-<see cref="AutopilotMonitor.DecisionCore.Signals.DecisionSignal"/>
/// whose <c>OccurredAtUtc</c> equals the deadline's <see cref="ActiveDeadline.DueAtUtc"/>,
/// not the wall-clock firing time — so replay stays deterministic even if the agent
/// restarts long after the deadline has passed.
/// whose <c>OccurredAtUtc</c> equals the deadline's <see cref="ActiveDeadline.DueAtUtc"/>
/// (the policy instant the wait expired), with the due time repeated in the payload. The
/// firing clock is deliberately NOT the stamp: a timer due during Modern Standby or a
/// reboot fires only afterwards, and the outage would otherwise become session duration
/// (D-238).
/// </para>
/// </summary>
public sealed class DeadlineFiredEventArgs : EventArgs
@@ -1,6 +1,7 @@
#nullable enable
using System;
using System.Collections.Generic;
using System.Globalization;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
@@ -1159,7 +1160,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
var evidence = new Evidence(
kind: EvidenceKind.Synthetic,
identifier: e.Deadline.Name,
summary: $"deadline '{e.Deadline.Name}' fired at {e.Deadline.DueAtUtc:O}");
summary: $"deadline '{e.Deadline.Name}' due {e.Deadline.DueAtUtc:O} fired at {e.FiredAtUtc:O}");
// The reducer reads the deadline name under SignalPayloadKeys.Deadline
// (see HandleDeadlineFiredV1 in DecisionEngine.Shared). Forward the
@@ -1180,7 +1181,15 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
payload[SignalPayloadKeys.Deadline] = e.Deadline.Name;
}
// OccurredAtUtc = DueAtUtc (not firedAt) — replay-determinism per DeadlineFiredEventArgs doc.
// OccurredAtUtc = DueAtUtc, not the firing clock (D-238). Every effect of the
// resulting step (phase_transition, enrollment_complete) is stamped with the signal
// time; a timer that came due during Modern Standby or a reboot fires only afterwards,
// and the firing clock would make the verdict — and the session duration — grow by
// the whole outage (measured: days for devices closed right after provisioning).
// The due time also travels in the payload so the stale-fire guards identify the
// deadline incarnation independently of the stamp.
payload[SignalPayloadKeys.DeadlineDueAtUtc] = e.Deadline.DueAtUtc.ToString("O", CultureInfo.InvariantCulture);
_ingress.Post(
kind: DecisionSignalKind.DeadlineFired,
occurredAtUtc: e.Deadline.DueAtUtc,
@@ -39,7 +39,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
/// <summary>
/// Wird vom Timer-Thread geraised, wenn ein Deadline fällig wird. Subscriber
/// ist typischerweise der Orchestrator, der daraus ein synthetisches
/// <c>DeadlineFired</c>-Signal mit <c>OccurredAtUtc = deadline.DueAtUtc</c> erzeugt.
/// <c>DeadlineFired</c>-Signal mit <c>OccurredAtUtc = deadline.DueAtUtc</c> erzeugt; die
/// Fälligkeit reist zusätzlich im Payload (<c>SignalPayloadKeys.DeadlineDueAtUtc</c>).
/// </summary>
event EventHandler<DeadlineFiredEventArgs>? Fired;
@@ -0,0 +1,191 @@
using System;
using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using AutopilotMonitor.DecisionCore.Engine;
using AutopilotMonitor.DecisionCore.Signals;
using AutopilotMonitor.DecisionCore.State;
using Xunit;
namespace AutopilotMonitor.DecisionCore.Tests
{
/// <summary>
/// The reducer identifies a deadline incarnation through the due time carried in the
/// payload (<see cref="SignalPayloadKeys.DeadlineDueAtUtc"/>), never through the signal
/// time: the host stamps <c>DeadlineFired</c> with the due time (D-238), but the guards
/// must stay correct for any stamp — a late fire after Modern Standby or a restart, a
/// replayed signal, or a future switch to the firing clock. Without the key they fall back
/// to the signal time (pre-key signal logs, where the two were equal by contract).
/// </summary>
public sealed class DeadlineFireTimeStampTests
{
private static readonly DateTime T0 = new DateTime(2026, 9, 9, 6, 31, 0, DateTimeKind.Utc);
private static DecisionSignal MakeSignal(
long ordinal,
DecisionSignalKind kind,
DateTime occurredAtUtc,
IReadOnlyDictionary<string, string>? payload = null) =>
new DecisionSignal(
sessionSignalOrdinal: ordinal,
sessionTraceOrdinal: ordinal,
kind: kind,
kindSchemaVersion: 1,
occurredAtUtc: occurredAtUtc,
sourceOrigin: "test",
evidence: new Evidence(EvidenceKind.Synthetic, $"t-{kind}-{ordinal}", $"synthetic {kind}"),
payload: payload);
/// <summary>What the host posts: name plus due time, OccurredAtUtc = firing clock.</summary>
private static Dictionary<string, string> FiredPayload(string deadlineName, DateTime dueAtUtc) =>
new Dictionary<string, string>
{
[SignalPayloadKeys.Deadline] = deadlineName,
[SignalPayloadKeys.DeadlineDueAtUtc] = dueAtUtc.ToString("O", CultureInfo.InvariantCulture),
};
// ============================================================== helper
[Fact]
public void DeadlineDueAtUtc_reads_the_payload_and_falls_back_to_the_signal_time()
{
var due = T0.AddMinutes(5);
var fired = T0.AddMinutes(9);
var withKey = MakeSignal(1, DecisionSignalKind.DeadlineFired, fired, FiredPayload(DeadlineNames.HelloSafety, due));
Assert.Equal(due, DecisionEngine.DeadlineDueAtUtc(withKey));
Assert.Equal(DateTimeKind.Utc, DecisionEngine.DeadlineDueAtUtc(withKey).Kind);
var withoutKey = MakeSignal(2, DecisionSignalKind.DeadlineFired, fired,
new Dictionary<string, string> { [SignalPayloadKeys.Deadline] = DeadlineNames.HelloSafety });
Assert.Equal(fired, DecisionEngine.DeadlineDueAtUtc(withoutKey));
var garbage = MakeSignal(3, DecisionSignalKind.DeadlineFired, fired,
new Dictionary<string, string> { [SignalPayloadKeys.DeadlineDueAtUtc] = "not-a-time" });
Assert.Equal(fired, DecisionEngine.DeadlineDueAtUtc(garbage));
}
// ============================================================== Classic: standby at the Hello prompt
[Fact]
public void Late_HelloSafety_fire_stamps_the_resolution_and_the_grace_window_from_the_firing_clock()
{
// Session ac5660b8 shape: ESP exits, the user leaves the device at the Hello prompt, it
// enters Modern Standby, HelloSafety is due during the sleep and fires ~3 min late after
// wake. Fed with the firing clock as signal time, the reducer must stamp the Hello
// timeout fact, the Finalizing step and the FinalizingGrace due time from that time —
// the stamp policy is the host's choice (D-238), the reducer follows the signal.
var engine = new DecisionEngine();
var state = DecisionState.CreateInitial("sess-standby", "tenant", T0);
state = engine.Reduce(state, MakeSignal(0, DecisionSignalKind.SessionStarted, T0)).NewState;
state = engine.Reduce(state, MakeSignal(1, DecisionSignalKind.EspPhaseChanged, T0.AddMinutes(1),
new Dictionary<string, string> { [SignalPayloadKeys.EspPhase] = "AccountSetup" })).NewState;
state = engine.Reduce(state, MakeSignal(2, DecisionSignalKind.AccountSetupProvisioningComplete, T0.AddMinutes(2))).NewState;
state = engine.Reduce(state, MakeSignal(3, DecisionSignalKind.DesktopArrived, T0.AddMinutes(3))).NewState;
var espExit = T0.AddMinutes(6).AddSeconds(50.2144855);
state = engine.Reduce(state, MakeSignal(4, DecisionSignalKind.EspExiting, espExit)).NewState;
var helloSafety = Assert.Single(state.Deadlines, d => d.Name == DeadlineNames.HelloSafety);
Assert.Equal(espExit.AddSeconds(300), helloSafety.DueAtUtc);
// Timer fires after wake, 2m 54s past due.
var firedAt = helloSafety.DueAtUtc.AddSeconds(174);
var finalizing = engine.Reduce(state, MakeSignal(5, DecisionSignalKind.DeadlineFired, firedAt,
FiredPayload(DeadlineNames.HelloSafety, helloSafety.DueAtUtc)));
Assert.True(finalizing.Transition.Taken);
Assert.Equal(SessionStage.Finalizing, finalizing.NewState.Stage);
Assert.Equal("Timeout", finalizing.NewState.HelloOutcome!.Value);
Assert.Equal(firedAt, finalizing.NewState.HelloResolvedUtc!.Value);
var grace = Assert.Single(finalizing.NewState.Deadlines, d => d.Name == DeadlineNames.FinalizingGrace);
Assert.Equal(firedAt.AddSeconds(5), grace.DueAtUtc);
// The chained grace fires on time and completes; nothing carries the old due time.
var completed = engine.Reduce(finalizing.NewState, MakeSignal(6, DecisionSignalKind.DeadlineFired, grace.DueAtUtc,
FiredPayload(DeadlineNames.FinalizingGrace, grace.DueAtUtc)));
Assert.Equal(SessionStage.Completed, completed.NewState.Stage);
Assert.Equal(SessionOutcome.EnrollmentComplete, completed.NewState.Outcome);
Assert.Contains(completed.Effects, e =>
e.Kind == DecisionEffectKind.EmitEventTimelineEntry
&& e.Parameters != null
&& e.Parameters.TryGetValue("eventType", out var et) && et == "enrollment_complete");
}
// ============================================================== SelfDeploying guard C
[Fact]
public void SelfDeploying_guard_C_matches_the_incarnation_by_payload_due_time_not_by_firing_clock()
{
var engine = new DecisionEngine();
var state = DecisionState.CreateInitial("sd-late", "t", T0);
state = engine.Reduce(state, MakeSignal(0, DecisionSignalKind.SessionStarted, T0)).NewState;
state = engine.Reduce(state, MakeSignal(1, DecisionSignalKind.EspPhaseChanged, T0.AddMinutes(1),
new Dictionary<string, string> { [SignalPayloadKeys.EspPhase] = "DeviceSetup" })).NewState;
state = engine.Reduce(state, MakeSignal(2, DecisionSignalKind.DeviceSetupProvisioningComplete, T0.AddMinutes(3))).NewState;
var armed = Assert.Single(state.Deadlines, d => d.Name == DeadlineNames.DeviceOnlyEspDetection);
Assert.Equal(T0.AddMinutes(8), armed.DueAtUtc);
// A stale fire of an OLDER incarnation (due T+5) arriving late: dead-end, deadline kept.
var stale = engine.Reduce(state, MakeSignal(3, DecisionSignalKind.DeadlineFired, T0.AddMinutes(12),
FiredPayload(DeadlineNames.DeviceOnlyEspDetection, T0.AddMinutes(5))));
Assert.False(stale.Transition.Taken);
Assert.Equal("device_only_esp_detection_stale_due_at_mismatch", stale.Transition.DeadEndReason);
Assert.Single(stale.NewState.Deadlines, d => d.Name == DeadlineNames.DeviceOnlyEspDetection);
// The real fire, 4 min late (standby), carries the armed due time: terminal.
var real = engine.Reduce(stale.NewState, MakeSignal(4, DecisionSignalKind.DeadlineFired, T0.AddMinutes(12),
FiredPayload(DeadlineNames.DeviceOnlyEspDetection, armed.DueAtUtc)));
Assert.True(real.Transition.Taken);
Assert.Equal(SessionStage.Completed, real.NewState.Stage);
}
// ============================================================== RealmJoin re-arm guard
[Fact]
public void RealmJoin_rearm_guard_compares_the_payload_due_time_not_the_firing_clock()
{
var engine = new DecisionEngine();
var state = DecisionState.CreateInitial("rj-late", "t", T0);
state = engine.Reduce(state, MakeSignal(0, DecisionSignalKind.SessionStarted, T0)).NewState;
state = engine.Reduce(state, MakeSignal(1, DecisionSignalKind.EspPhaseChanged, T0.AddMinutes(1),
new Dictionary<string, string> { [SignalPayloadKeys.EspPhase] = "DeviceSetup" })).NewState;
state = engine.Reduce(state, MakeSignal(2, DecisionSignalKind.EspPhaseChanged, T0.AddMinutes(2),
new Dictionary<string, string> { [SignalPayloadKeys.EspPhase] = "AccountSetup" })).NewState;
state = engine.Reduce(state, MakeSignal(3, DecisionSignalKind.EspExiting, T0.AddMinutes(3))).NewState;
state = engine.Reduce(state, MakeSignal(4, DecisionSignalKind.HelloResolved, T0.AddMinutes(4),
new Dictionary<string, string> { [SignalPayloadKeys.HelloOutcome] = "Success" })).NewState;
state = engine.Reduce(state, MakeSignal(5, DecisionSignalKind.RealmJoinDetected, T0.AddMinutes(5),
new Dictionary<string, string> { [DecisionEngine.RealmJoinPayloadKeys.DeploymentPhase] = "100" })).NewState;
state = engine.Reduce(state, MakeSignal(6, DecisionSignalKind.DesktopArrived, T0.AddMinutes(6))).NewState;
var first = Assert.Single(state.Deadlines, d => d.Name == DeadlineNames.RealmJoinTimeout);
// Simulate the activity-based re-arm: the armed incarnation is now due later.
var rearmedDue = first.DueAtUtc.AddMinutes(25);
var rearmed = state.ToBuilder()
.CancelDeadline(DeadlineNames.RealmJoinTimeout)
.AddDeadline(new ActiveDeadline(
name: DeadlineNames.RealmJoinTimeout,
dueAtUtc: rearmedDue,
firesSignalKind: DecisionSignalKind.DeadlineFired,
firesPayload: new Dictionary<string, string> { [SignalPayloadKeys.Deadline] = DeadlineNames.RealmJoinTimeout }))
.Build();
// The OLD incarnation's fire arrives late — after the re-armed due time on the clock.
// Only the payload due time identifies it as superseded.
var firedAt = rearmedDue.AddMinutes(1);
var stale = engine.Reduce(rearmed, MakeSignal(7, DecisionSignalKind.DeadlineFired, firedAt,
FiredPayload(DeadlineNames.RealmJoinTimeout, first.DueAtUtc)));
Assert.False(stale.Transition.Taken);
Assert.Equal("realmjoin_timeout_stale_superseded_by_rearm", stale.Transition.DeadEndReason);
Assert.Null(stale.NewState.RealmJoinFacts.Outcome);
// The re-armed incarnation's own fire, same firing clock: timeout is applied.
var real = engine.Reduce(stale.NewState, MakeSignal(8, DecisionSignalKind.DeadlineFired, firedAt,
FiredPayload(DeadlineNames.RealmJoinTimeout, rearmedDue)));
Assert.True(real.Transition.Taken);
Assert.Equal("Timeout", real.NewState.RealmJoinFacts.Outcome!.Value);
Assert.Equal(SessionStage.Finalizing, real.NewState.Stage);
}
}
}
@@ -706,7 +706,7 @@ namespace AutopilotMonitor.DecisionCore.Tests
var deadline = Assert.Single(signalStep.NewState.Deadlines, d => d.Name == DeadlineNames.DeviceOnlyEspDetection);
Assert.Equal(T0.AddMinutes(7), deadline.DueAtUtc);
// DeadlineFired (OccurredAtUtc = DueAtUtc per scheduler contract) → terminal.
// DeadlineFired at the due time (no payload due key → helper falls back to the signal time) → terminal.
var step = engine.Reduce(signalStep.NewState, MakeSignal(3, DecisionSignalKind.DeadlineFired, T0.AddMinutes(7),
new Dictionary<string, string> { [SignalPayloadKeys.Deadline] = DeadlineNames.DeviceOnlyEspDetection }));
@@ -443,8 +443,9 @@ namespace AutopilotMonitor.DecisionCore.Tests
{
// Cancel-then-rearm race: old deadline (DueAt=T+8) fires queued; before processing,
// DeviceSetupProvisioningComplete arrives (signal at T+10) → cancel+rearm to DueAt=T+15.
// The queued OLD fire (OccurredAtUtc=T+8) arrives. Guard C must dead-end WITHOUT
// cancelling the new deadline.
// The queued OLD fire arrives carrying its due time T+8 (no payload key here, so the
// helper falls back to the signal time). Guard C must dead-end WITHOUT cancelling the
// new deadline.
var engine = new DecisionEngine();
var state = PrimeDeviceSetup(engine, DecisionState.CreateInitial("sd-11", "t", T0));
@@ -467,7 +468,7 @@ namespace AutopilotMonitor.DecisionCore.Tests
firesPayload: new Dictionary<string, string> { [SignalPayloadKeys.Deadline] = DeadlineNames.DeviceOnlyEspDetection }));
state = rearmedBuilder.Build();
// OLD queued fire arrives with OccurredAtUtc=T+8 — mismatches new deadline at T+15.
// OLD queued fire arrives with due time T+8 — mismatches the new deadline at T+15.
var step = engine.Reduce(state, MakeSignal(99, DecisionSignalKind.DeadlineFired, T0.AddMinutes(8),
new Dictionary<string, string> { [SignalPayloadKeys.Deadline] = DeadlineNames.DeviceOnlyEspDetection }));
@@ -54,6 +54,37 @@ namespace AutopilotMonitor.DecisionCore.Tests
Assert.Equal("AccountSetup", roundtripped.Payload!["phase"]);
}
[Fact]
public void SignalSerializer_roundtrip_keeps_date_like_payload_strings_verbatim()
{
// The shared reader tokenizes ISO-8601 strings as dates; the string dictionaries must
// still come back as the round-trip text the writer produced, never culture-formatted
// (the DeadlineFired due time is parsed back with the "o" format on replay).
var due = new DateTime(2026, 4, 20, 9, 55, 0, DateTimeKind.Utc);
var original = new DecisionSignal(
sessionSignalOrdinal: 7,
sessionTraceOrdinal: 7,
kind: DecisionSignalKind.DeadlineFired,
kindSchemaVersion: 1,
occurredAtUtc: due.AddMinutes(5),
sourceOrigin: "DeadlineScheduler",
evidence: new Evidence(
kind: EvidenceKind.Synthetic,
identifier: "hello_safety",
summary: "deadline fired",
derivationInputs: new Dictionary<string, string> { ["armedAt"] = "2026-04-20T09:50:00.0000000Z" }),
payload: new Dictionary<string, string>
{
["deadline"] = "hello_safety",
["deadlineDueAtUtc"] = due.ToString("O"),
});
var roundtripped = SignalSerializer.Deserialize(SignalSerializer.Serialize(original));
Assert.Equal("2026-04-20T09:55:00.0000000Z", roundtripped.Payload!["deadlineDueAtUtc"]);
Assert.Equal("2026-04-20T09:50:00.0000000Z", roundtripped.Evidence.DerivationInputs!["armedAt"]);
}
[Fact]
public void SignalSerializer_Deserialize_MissingEvidence_throws()
{
@@ -0,0 +1,206 @@
using System.Net;
using System.Security.Claims;
using System.Text;
using AutopilotMonitor.Functions.Functions.Rules;
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Functions.Services;
using AutopilotMonitor.Shared.DataAccess;
using AutopilotMonitor.Shared.Models;
using Azure.Core.Serialization;
using Microsoft.Azure.Functions.Worker;
using Microsoft.Azure.Functions.Worker.Http;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
using Newtonsoft.Json;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// Analyze twin of <see cref="GatherRulesFunctionAuthorEndpointTests"/>: the rule Author is
/// stamped from the caller's JWT on create, on a PUT-upsert of an unknown rule and on the
/// template copy, and a true update keeps the original creator over editor and body.
/// Before this pin, custom analyze rules were created as "Autopilot Monitor" and the edit
/// path let the browser choose the author.
/// </summary>
public class AnalyzeRulesFunctionAuthorEndpointTests
{
private const string TenantId = "a1b2c3d4-e5f6-7890-abcd-ef1234567890";
private const string RuleId = "ANALYZE-CUSTOM-777";
private const string TemplateRuleId = "ANALYZE-SEC-004";
private sealed class FakeHttpResponseData : HttpResponseData
{
public FakeHttpResponseData(FunctionContext context) : base(context) { }
public override HttpStatusCode StatusCode { get; set; } = HttpStatusCode.OK;
public override HttpHeadersCollection Headers { get; set; } = new();
public override Stream Body { get; set; } = new MemoryStream();
public override HttpCookies Cookies { get; } = new Mock<HttpCookies>().Object;
}
private static FunctionContext BuildContext(ClaimsPrincipal? principal)
{
var services = new ServiceCollection();
services.AddOptions();
services.Configure<WorkerOptions>(o => o.Serializer =
new JsonObjectSerializer(ApiJsonOptions.Create()));
var provider = services.BuildServiceProvider();
var items = new Dictionary<object, object>();
if (principal != null)
{
items["ClaimsPrincipal"] = principal;
}
var context = new Mock<FunctionContext>();
context.SetupGet(c => c.Items).Returns(items);
context.SetupGet(c => c.InstanceServices).Returns(provider);
return context.Object;
}
private static HttpRequestData BuildRequest(ClaimsPrincipal? principal, object body)
{
var context = BuildContext(principal);
var req = new Mock<HttpRequestData>(context);
req.SetupGet(r => r.Headers).Returns(new HttpHeadersCollection());
req.SetupGet(r => r.Body).Returns(
new MemoryStream(Encoding.UTF8.GetBytes(JsonConvert.SerializeObject(body))));
req.Setup(r => r.CreateResponse()).Returns(() => new FakeHttpResponseData(context));
return req.Object;
}
private static ClaimsPrincipal Principal(params (string Type, string Value)[] claims)
=> new(new ClaimsIdentity(claims.Select(c => new Claim(c.Type, c.Value)), "TestAuth"));
private static ClaimsPrincipal AlicePrincipal()
=> Principal(("tid", TenantId), ("name", "Alice Admin"), ("upn", "alice@contoso.com"));
private static (AnalyzeRulesFunction function, List<AnalyzeRule> stored) BuildFunction(
AnalyzeRule? existingTenantRule = null, AnalyzeRule? globalRule = null)
{
var repo = new Mock<IRuleRepository>(MockBehavior.Loose);
var stored = new List<AnalyzeRule>();
repo.Setup(r => r.AnalyzeRuleExistsAsync(It.IsAny<string>(), It.IsAny<string>())).ReturnsAsync(false);
repo.Setup(r => r.GetAnalyzeRulesAsync("global")).ReturnsAsync(
globalRule == null ? new List<AnalyzeRule>() : new List<AnalyzeRule> { globalRule });
repo.Setup(r => r.GetAnalyzeRulesAsync(TenantId)).ReturnsAsync(
existingTenantRule == null ? new List<AnalyzeRule>() : new List<AnalyzeRule> { existingTenantRule });
repo.Setup(r => r.GetRuleStatesAsync(TenantId)).ReturnsAsync(new Dictionary<string, RuleState>());
repo.Setup(r => r.StoreRuleStateAsync(TenantId, It.IsAny<string>(), It.IsAny<RuleState>())).ReturnsAsync(true);
repo.Setup(r => r.StoreAnalyzeRuleAsync(It.IsAny<AnalyzeRule>(), TenantId))
.Callback<AnalyzeRule, string>((rule, _) => stored.Add(rule))
.ReturnsAsync(true);
var service = new AnalyzeRuleService(repo.Object, NullLogger<AnalyzeRuleService>.Instance);
return (new AnalyzeRulesFunction(NullLogger<AnalyzeRulesFunction>.Instance, service), stored);
}
private static AnalyzeRule SpoofedPayload() => new()
{
RuleId = RuleId,
Title = "Proxy PAC unreachable",
Description = "Custom",
Severity = "warning",
Category = "network",
Explanation = "The PAC file could not be fetched.",
IsBuiltIn = false,
IsCommunity = false,
Enabled = true,
Author = "Spoofed Author",
Conditions = new List<RuleCondition>
{
new() { Signal = "pac_failed", Source = "event_type", EventType = "network_pac_failed", Required = true }
},
};
[Fact]
public async Task CreateRule_stamps_author_from_jwt_not_from_body()
{
var (function, stored) = BuildFunction();
var req = BuildRequest(AlicePrincipal(), SpoofedPayload());
var response = await function.CreateRule(req);
Assert.Equal(HttpStatusCode.Created, response.StatusCode);
var written = Assert.Single(stored);
Assert.Equal("Alice Admin", written.Author);
}
[Fact]
public async Task CreateRule_falls_back_to_product_name_without_identifying_claims()
{
var (function, stored) = BuildFunction();
var req = BuildRequest(Principal(("tid", TenantId)), SpoofedPayload());
var response = await function.CreateRule(req);
Assert.Equal(HttpStatusCode.Created, response.StatusCode);
var written = Assert.Single(stored);
Assert.Equal("Autopilot Monitor", written.Author);
}
[Fact]
public async Task UpdateRule_upsert_of_unknown_rule_stamps_author_from_jwt()
{
var (function, stored) = BuildFunction(existingTenantRule: null);
var req = BuildRequest(AlicePrincipal(), SpoofedPayload());
var response = await function.UpdateRule(req, RuleId);
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
var written = Assert.Single(stored);
Assert.Equal("Alice Admin", written.Author);
}
[Fact]
public async Task UpdateRule_true_update_keeps_original_author_over_editor_and_body()
{
var existing = SpoofedPayload();
existing.Author = "Original Creator";
existing.CreatedAt = new DateTime(2026, 1, 2, 3, 4, 5, DateTimeKind.Utc);
var (function, stored) = BuildFunction(existing);
var req = BuildRequest(
Principal(("tid", TenantId), ("name", "Bob Editor")), SpoofedPayload());
var response = await function.UpdateRule(req, RuleId);
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
var written = Assert.Single(stored);
Assert.Equal("Original Creator", written.Author);
Assert.Equal(existing.CreatedAt, written.CreatedAt);
}
[Fact]
public async Task CreateFromTemplate_stamps_the_copying_admin_not_the_template_author()
{
var template = new AnalyzeRule
{
RuleId = TemplateRuleId,
Title = "AutoLogon enabled for an unexpected user",
Description = "Template",
Severity = "warning",
Category = "security",
Explanation = "Template",
IsBuiltIn = true,
Author = "Autopilot Monitor",
Conditions = new List<RuleCondition>
{
new() { Signal = "autologon", Source = "event_type", EventType = "autologon_analysis", Operator = "equals", Value = "PLACEHOLDER", Required = true }
},
TemplateVariables = new List<TemplateVariable>
{
new() { Name = "allowed", Label = "Allowed", ConditionIndex = 0, Field = "value" }
},
};
var (function, stored) = BuildFunction(globalRule: template);
var req = BuildRequest(AlicePrincipal(), new { variables = new Dictionary<string, string> { ["allowed"] = "KIOSK-1" } });
var response = await function.CreateFromTemplate(req, TemplateRuleId);
Assert.Equal(HttpStatusCode.Created, response.StatusCode);
var written = Assert.Single(stored);
Assert.Equal("Alice Admin", written.Author);
Assert.Equal(TemplateRuleId, written.DerivedFromTemplateRuleId);
}
}
@@ -0,0 +1,63 @@
using Azure.Data.Tables;
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Functions.Services;
using AutopilotMonitor.Shared.Models;
using Xunit;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// Observation-end closure of app rows: a row still InProgress when the session's observation
/// ended becomes "Incomplete" (terminal, non-failure, outcome unknown). Pins the pure per-row
/// predicate behind <see cref="TableStorageService.CloseOpenAppInstallsForSessionAsync"/> and
/// the disclosed bucket in the app-metrics payload.
/// </summary>
public class AppInstallIncompleteCloseTests
{
private static TableEntity Row(string? status, DateTimeOffset? completedAt = null)
{
var row = new TableEntity("tenant", "session_App");
if (status != null) row["Status"] = status;
if (completedAt.HasValue) row["CompletedAt"] = completedAt.Value;
return row;
}
[Theory]
[InlineData("InProgress")]
[InlineData("")]
[InlineData(null)]
public void ShouldClose_OpenRow(string? status)
=> Assert.True(TableStorageService.ShouldCloseAsIncomplete(Row(status)));
[Theory]
[InlineData("Succeeded")]
[InlineData("Failed")]
[InlineData("Incomplete")]
public void ShouldClose_LeavesTerminalRowsAlone(string status)
=> Assert.False(TableStorageService.ShouldCloseAsIncomplete(Row(status)));
[Fact]
public void ShouldClose_NeverClosesARowWithAnEnd()
{
// Out-of-order arrival can leave a CompletedAt on a row whose status batch is late —
// an end is an end.
Assert.False(TableStorageService.ShouldCloseAsIncomplete(Row("InProgress", DateTimeOffset.UtcNow)));
}
[Fact]
public void AppMetrics_DisclosesIncompleteOutsideTheRate()
{
var payload = MetricsMath.BuildAppMetricsPayload(new[]
{
new AppInstallSummary { AppName = "App", Status = "Succeeded", TerminalState = "Installed", DurationSeconds = 30 },
new AppInstallSummary { AppName = "App", Status = "Failed", TerminalState = "Error", DurationSeconds = 30 },
new AppInstallSummary { AppName = "App", Status = "Incomplete" },
});
var group = Assert.Single(payload.TopFailingApps);
Assert.Equal(3, group.TotalInstalls);
Assert.Equal(1, group.Incomplete);
Assert.Equal(50.0, group.FailureRate);
Assert.Equal(1, payload.TotalIncomplete);
}
}
@@ -155,6 +155,30 @@ public class AppInstallTerminalStateAndReconcileTests
Assert.Equal("Succeeded", summary.Status);
}
[Fact]
public void Reconcile_IncompleteIsSticky_AgainstLateProgressBatch()
{
// Closed by the observation-end step; a straggling started/progress batch must not reopen it.
var existing = new TableEntity("tenant", "session_App") { ["Status"] = "Incomplete" };
var summary = new AppInstallSummary { AppName = "App", Status = "InProgress", StartedAt = T0 };
TableStorageService.ReconcileAppInstallSummaryWithExisting(summary, existing);
Assert.Equal("Incomplete", summary.Status);
}
[Fact]
public void Reconcile_RealTerminalOverridesIncomplete()
{
// The completion arrived after the close step: real evidence beats the hedge.
var existing = new TableEntity("tenant", "session_App") { ["Status"] = "Incomplete" };
var summary = new AppInstallSummary { AppName = "App", Status = "Succeeded", StartedAt = T0 };
TableStorageService.ReconcileAppInstallSummaryWithExisting(summary, existing);
Assert.Equal("Succeeded", summary.Status);
}
[Fact]
public void Reconcile_Q4Guard_DoesNotFireWithoutStoredCompletedAt()
{
@@ -10,7 +10,7 @@ using Microsoft.Extensions.Logging.Abstractions;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// Tests for <see cref="LatestVersionsService"/> — the 12h-cached reader for the
/// Tests for <see cref="LatestVersionsService"/> — the short-TTL reader for the
/// public <c>version.json</c> blob. Verifies cache hit/miss, forceRefresh bypass,
/// and failure fallback without hammering the blob on every call.
/// </summary>
@@ -140,6 +140,28 @@ public class LatestVersionsServiceTests
Assert.Equal(1, handler.CallCount);
}
[Fact]
public async Task GetAsync_HttpFailure_AfterSuccess_ServesLastKnownGood()
{
var (svc, handler, _) = Create();
await svc.GetAsync(forceRefresh: false, CancellationToken.None);
handler.Responder = _ => new HttpResponseMessage(HttpStatusCode.InternalServerError);
// The refresh fails, but the version line must not blank out: the last good
// value stands until the blob answers again.
var afterFailure = await svc.GetAsync(forceRefresh: true, CancellationToken.None);
Assert.NotNull(afterFailure);
Assert.Equal("1.0.706", afterFailure!.AgentVersion);
Assert.True(afterFailure.FromCache);
// ...and it is what the short failure cache serves to the next callers, too.
var next = await svc.GetAsync(forceRefresh: false, CancellationToken.None);
Assert.Equal("1.0.706", next!.AgentVersion);
Assert.Equal(2, handler.CallCount);
}
[Fact]
public async Task GetAsync_MalformedJson_ReturnsNull()
{
@@ -7,19 +7,21 @@ using Moq;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// Pins ANALYZE-ESP-004 ("ESP Timeout with 'Continue Anyway' — Soft Failure").
/// Pins ANALYZE-ESP-004 ("ESP Gave Up on a Blocking App with 'Continue Anyway' — Soft Failure").
///
/// Background (tenant c9787ba2, session cb7036a6): a slow blocking app (Encompass
/// Hybrid Installer) does not finish inside the 30-min Device-ESP window, so the ESP
/// fails terminally in DeviceSetup. The profile allows "Continue anyway", so the user
/// most likely dismissed the failure screen and reached the desktop — but the agent
/// only ever sees the terminal failure and the session is recorded as Failed. The
/// DecisionEngine already stamps the enrollment_failed event with
/// <c>mayHaveContinuedAnyway=true</c>; this rule turns that into a customer-visible
/// "soft failure" advisory with the root-cause remediation.
/// only ever sees the terminal failure and the session is recorded as Failed.
///
/// The rule keys ONLY on <c>mayHaveContinuedAnyway==true</c> (set exclusively on the
/// ESP terminal-failure path), so an ordinary hard failure must not trip it.
/// The rule needs THREE facts: the terminal enrollment_failed, the DecisionEngine's
/// <c>mayHaveContinuedAnyway=true</c> stamp (profile allows the button), and the agent's own
/// timeout verdict — an app_install_failed promoted with <c>failureType=esp_apps_timeout</c>
/// (ESP gave up while the app was still installing, no per-app HRESULT). Session 683f1eff:
/// an ESP failure with a real HRESULT (0x80070652, installer collision) on a Continue-anyway
/// profile fired the rule and rendered the configured 90-min limit as if it had elapsed —
/// the continue-anyway flag alone proves nothing about timing.
/// </summary>
public class RuleEngineEspSoftFailureTests
{
@@ -37,8 +39,9 @@ public class RuleEngineEspSoftFailureTests
var events = new List<EnrollmentEvent>
{
SettleStartedEvent(errorCode: null),
EnrollmentFailedEvent(mayHaveContinuedAnyway: "true"),
AppInstallFailed(),
AppInstallFailed(failureType: "esp_apps_timeout"),
};
var outcome = await RunAsync(rule, events);
@@ -47,13 +50,15 @@ public class RuleEngineEspSoftFailureTests
Assert.Equal("ANALYZE-ESP-004", result.RuleId);
Assert.Equal("warning", result.Severity);
// Required gate matched on the continue-anyway flag.
// Required gates: the continue-anyway flag AND the agent's timeout verdict.
var gate = AsDict(result.MatchedConditions["may_have_continued"]);
Assert.Equal("true", AsString(gate["value"]));
var verdict = AsDict(result.MatchedConditions["esp_gave_up_on_app"]);
Assert.Equal("esp_apps_timeout", AsString(verdict["value"]));
// Interpolation material for the explanation / remediation templates is present:
// {{espSyncFailureTimeoutMinutes}}, {{failedSubcategory}} (from enrollment_failed)
// and {{appName}} (from app_install_failed).
// Interpolation material: {{espSyncFailureTimeoutMinutes}} (enrollment_failed),
// {{failedSubcategory}} (esp_failure_settle_started — the terminal event drops it when
// the Shell-Core failure wins the race) and {{appName}} (the promoted app).
var timeout = AsDict(result.MatchedConditions["espSyncFailureTimeoutMinutes"]);
Assert.Equal("30", AsString(timeout["value"]));
@@ -65,6 +70,48 @@ public class RuleEngineEspSoftFailureTests
Assert.Equal(FailedAppName, AsString(failedApp["value"]));
}
[Fact]
public async Task ANALYZE_ESP_004_stays_silent_on_a_hard_failure_with_continue_anyway()
{
// Session 683f1eff: continue-anyway profile, but the ESP failed on a real installer
// error (0x80070652 / MSI 1618) after 19 minutes. The failed app carries no
// esp_apps_timeout verdict — the rule must not turn an installer collision into
// "the ESP reached its 90-min timeout".
var rule = BuiltInAnalyzeRules.GetAll().First(r => r.RuleId == "ANALYZE-ESP-004");
var events = new List<EnrollmentEvent>
{
SettleStartedEvent(errorCode: "0x80070652"),
EnrollmentFailedEvent(mayHaveContinuedAnyway: "true"),
AppInstallFailed(failureType: null, exitCodeClass: "Retry"),
};
var outcome = await RunAsync(rule, events);
Assert.Empty(outcome.Results);
}
[Fact]
public async Task ANALYZE_ESP_004_names_the_timed_out_app_not_another_failed_one()
{
// Two failed apps: one hard installer failure earlier in the run, one promoted
// esp_apps_timeout at the terminal. {{appName}} must be the timed-out app.
var rule = BuiltInAnalyzeRules.GetAll().First(r => r.RuleId == "ANALYZE-ESP-004");
var events = new List<EnrollmentEvent>
{
AppInstallFailed(failureType: null, exitCodeClass: "Failed", appName: "Contoso Agent", sequence: 100),
SettleStartedEvent(errorCode: null),
EnrollmentFailedEvent(mayHaveContinuedAnyway: "true"),
AppInstallFailed(failureType: "esp_apps_timeout"),
};
var outcome = await RunAsync(rule, events);
var result = Assert.Single(outcome.Results);
var failedApp = AsDict(result.MatchedConditions["appName"]);
Assert.Equal(FailedAppName, AsString(failedApp["value"]));
}
[Fact]
public async Task ANALYZE_ESP_004_does_not_fire_when_continue_anyway_is_false()
{
@@ -75,7 +122,7 @@ public class RuleEngineEspSoftFailureTests
var events = new List<EnrollmentEvent>
{
EnrollmentFailedEvent(mayHaveContinuedAnyway: "false"),
AppInstallFailed(),
AppInstallFailed(failureType: "esp_apps_timeout"),
};
var outcome = await RunAsync(rule, events);
@@ -92,7 +139,7 @@ public class RuleEngineEspSoftFailureTests
var events = new List<EnrollmentEvent>
{
EnrollmentFailedEvent(mayHaveContinuedAnyway: null),
AppInstallFailed(),
AppInstallFailed(failureType: "esp_apps_timeout"),
};
var outcome = await RunAsync(rule, events);
@@ -132,23 +179,61 @@ public class RuleEngineEspSoftFailureTests
return data;
}
private static EnrollmentEvent AppInstallFailed() => new()
private static EnrollmentEvent SettleStartedEvent(string? errorCode)
{
EventId = Guid.NewGuid().ToString(),
TenantId = TenantId,
SessionId = SessionId,
EventType = "app_install_failed",
Timestamp = DateTime.UtcNow,
Sequence = 220,
Data = new Dictionary<string, object>
var data = new Dictionary<string, object>
{
["appName"] = FailedAppName,
["category"] = "DeviceSetup",
["failedSubcategory"] = "Certificates",
["failureType"] = "Provisioning_DeviceSetup_Certificates_Failed",
["settleSeconds"] = 30,
["reason"] = "wait_for_late_ime_signals",
};
if (errorCode != null)
data["errorCode"] = errorCode;
return new EnrollmentEvent
{
EventId = Guid.NewGuid().ToString(),
TenantId = TenantId,
SessionId = SessionId,
EventType = "esp_failure_settle_started",
Timestamp = DateTime.UtcNow,
Sequence = 212,
Data = data,
};
}
private static EnrollmentEvent AppInstallFailed(
string? failureType,
string? exitCodeClass = null,
string appName = FailedAppName,
int sequence = 220)
{
var data = new Dictionary<string, object>
{
["appName"] = appName,
["state"] = "Error",
["targeted"] = "Device",
["failureType"] = "esp_apps_timeout",
["errorDetail"] = "Install status unconfirmed — ESP gave up while this app was still installing.",
};
if (failureType != null)
{
data["failureType"] = failureType;
data["confidence"] = "presumed";
data["errorDetail"] = "Install status unconfirmed — ESP gave up while this app was still installing.";
}
};
if (exitCodeClass != null)
data["exitCodeClass"] = exitCodeClass;
return new EnrollmentEvent
{
EventId = Guid.NewGuid().ToString(),
TenantId = TenantId,
SessionId = SessionId,
EventType = "app_install_failed",
Timestamp = DateTime.UtcNow,
Sequence = sequence,
Data = data,
};
}
private static Dictionary<string, object> AsDict(object o)
{
@@ -7,12 +7,17 @@ using Moq;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// Pins the absence gate on <c>event_type</c> conditions: <c>not_exists</c> without a
/// <c>dataField</c> matches when no event of that type occurs in the session and is disproved by
/// a single such event. Before this branch an absent type always evaluated false, so a required
/// "must not have happened" condition could never be expressed (ANALYZE-ID-004 v2 relies on it).
/// The dataField variant keeps its historical meaning (some event of the type has an empty field)
/// and is not touched here.
/// Pins the absence gates on conditions.
///
/// Without a <c>dataField</c>, <c>not_exists</c> matches when no event of that type occurs in
/// the session and is disproved by a single such event (ANALYZE-ID-004 v2 relies on it).
///
/// With a <c>dataField</c>, <c>not_exists</c> matches when no event of the type carries a
/// non-empty value at that field — including when the type is absent — and is disproved by a
/// single non-empty value; on <c>event_data</c> the same-event filter narrows the inspected set
/// first. Before this the per-event loop's null short-circuit rejected a missing field before
/// the operator ever ran, so "the ESP failure carried no HRESULT" (session 683f1eff) could not be
/// expressed at all, while the precondition gate already had the absence semantics.
/// </summary>
public class RuleEngineEventTypeNotExistsTests
{
@@ -24,7 +29,7 @@ public class RuleEngineEventTypeNotExistsTests
{
var events = new List<EnrollmentEvent> { Event("marker_seen", 1) };
var outcome = await RunAsync(Rule(), events);
var outcome = await RunAsync(TypeAbsenceRule(), events);
var result = Assert.Single(outcome.Results);
var evidence = Assert.IsType<Dictionary<string, object>>(result.MatchedConditions["disproof_absent"]);
@@ -37,12 +42,111 @@ public class RuleEngineEventTypeNotExistsTests
{
var events = new List<EnrollmentEvent> { Event("marker_seen", 1), Event("disproof", 2) };
var outcome = await RunAsync(Rule(), events);
var outcome = await RunAsync(TypeAbsenceRule(), events);
Assert.Empty(outcome.Results);
}
private static AnalyzeRule Rule() => new()
[Fact]
public async Task Field_not_exists_matches_when_no_event_carries_the_field()
{
// The event type is present, the field is not — the shape of an ESP failure without an
// HRESULT (esp_failure_settle_started without errorCode).
var events = new List<EnrollmentEvent> { Event("marker_seen", 1), Event("disproof", 2) };
var outcome = await RunAsync(FieldAbsenceRule("event_type"), events);
var result = Assert.Single(outcome.Results);
var evidence = Assert.IsType<Dictionary<string, object>>(result.MatchedConditions["code_absent"]);
Assert.Equal("disproof", evidence["eventType"]);
Assert.Equal("errorCode", evidence["field"]);
Assert.Equal(1, evidence["count"]);
}
[Fact]
public async Task Field_not_exists_matches_when_the_event_type_is_absent()
{
var events = new List<EnrollmentEvent> { Event("marker_seen", 1) };
var outcome = await RunAsync(FieldAbsenceRule("event_type"), events);
var result = Assert.Single(outcome.Results);
var evidence = Assert.IsType<Dictionary<string, object>>(result.MatchedConditions["code_absent"]);
Assert.Equal(0, evidence["count"]);
}
[Theory]
[InlineData("event_type")]
[InlineData("event_data")]
public async Task A_non_empty_value_on_any_event_vetoes_a_required_field_not_exists(string source)
{
var events = new List<EnrollmentEvent>
{
Event("marker_seen", 1),
Event("disproof", 2),
Event("disproof", 3, ("errorCode", "0x80070652")),
};
var outcome = await RunAsync(FieldAbsenceRule(source), events);
Assert.Empty(outcome.Results);
}
[Fact]
public async Task An_empty_string_does_not_count_as_a_carried_value()
{
var events = new List<EnrollmentEvent> { Event("marker_seen", 1), Event("disproof", 2, ("errorCode", "")) };
var outcome = await RunAsync(FieldAbsenceRule("event_type"), events);
Assert.Single(outcome.Results);
}
[Fact]
public async Task Event_data_field_not_exists_inspects_only_the_filtered_events()
{
// The carrier of the field is filtered out (kind=a); among kind=b events nobody carries it.
var events = new List<EnrollmentEvent>
{
Event("marker_seen", 1),
Event("disproof", 2, ("kind", "a"), ("errorCode", "0x80070652")),
Event("disproof", 3, ("kind", "b")),
};
var matched = await RunAsync(FieldAbsenceRule("event_data", filterKind: "b"), events);
var result = Assert.Single(matched.Results);
var evidence = Assert.IsType<Dictionary<string, object>>(result.MatchedConditions["code_absent"]);
Assert.Equal(1, evidence["count"]);
var vetoed = await RunAsync(FieldAbsenceRule("event_data", filterKind: "a"), events);
Assert.Empty(vetoed.Results);
}
private static AnalyzeRule TypeAbsenceRule() => Rule(
new RuleCondition { Signal = "disproof_absent", Source = "event_type", EventType = "disproof", Operator = "not_exists", Value = "", Required = true });
private static AnalyzeRule FieldAbsenceRule(string source, string? filterKind = null)
{
var absence = new RuleCondition
{
Signal = "code_absent",
Source = source,
EventType = "disproof",
DataField = "errorCode",
Operator = "not_exists",
Value = "",
Required = true,
};
if (filterKind != null)
{
absence.FilterField = "kind";
absence.FilterOperator = "equals";
absence.FilterValue = filterKind;
}
return Rule(absence);
}
private static AnalyzeRule Rule(RuleCondition absence) => new()
{
// Custom-namespace rule: a built-in ID outside the live catalog is hidden by the
// sunset filter in AnalyzeRuleService (IsBuiltIn defaults to true).
@@ -58,11 +162,11 @@ public class RuleEngineEventTypeNotExistsTests
Conditions = new List<RuleCondition>
{
new() { Signal = "marker", Source = "event_type", EventType = "marker_seen", Operator = "exists", Value = "", Required = true },
new() { Signal = "disproof_absent", Source = "event_type", EventType = "disproof", Operator = "not_exists", Value = "", Required = true },
absence,
},
};
private static EnrollmentEvent Event(string eventType, int sequence) => new()
private static EnrollmentEvent Event(string eventType, int sequence, params (string key, string value)[] data) => new()
{
EventId = Guid.NewGuid().ToString(),
TenantId = TenantId,
@@ -70,7 +174,7 @@ public class RuleEngineEventTypeNotExistsTests
EventType = eventType,
Timestamp = DateTime.UtcNow.AddMinutes(sequence),
Sequence = sequence,
Data = new Dictionary<string, object>(),
Data = data.ToDictionary(d => d.key, d => (object)d.value),
};
private static async Task<AnalysisOutcome> RunAsync(AnalyzeRule rule, List<EnrollmentEvent> events)
@@ -0,0 +1,530 @@
using System.Text.Json;
using System.Text.Json.Nodes;
using AutopilotMonitor.Functions.Services;
using AutopilotMonitor.Shared.DataAccess;
using AutopilotMonitor.Shared.Models;
using AutopilotMonitor.Shared.Pagination;
using Microsoft.Extensions.Caching.Memory;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// The pure pieces of <see cref="RuleSubmissionService"/> (id suggestion, repo file, snapshot
/// stripping, attribution shape) and the review state machine against mocked repositories.
/// </summary>
public class RuleSubmissionServiceTests
{
private const string TenantId = "11111111-1111-1111-1111-111111111111";
// ── id suggestion ───────────────────────────────────────────────────────
[Fact]
public void Suggest_is_max_plus_one_and_never_fills_a_gap()
{
// 001 and 003 exist, 002 is a retired id — the next is 004, not 002.
var taken = new[] { "ANALYZE-NET-001", "ANALYZE-NET-003", "ANALYZE-APP-018", "GATHER-NET-009" };
Assert.Equal("ANALYZE-NET-004", RuleSubmissionService.SuggestPublishedRuleId("analyze", "network", taken));
}
[Fact]
public void Suggest_starts_at_001_for_an_empty_category_and_maps_the_kind_convention()
{
Assert.Equal("ANALYZE-NET-001", RuleSubmissionService.SuggestPublishedRuleId("analyze", "network", Array.Empty<string>()));
Assert.Equal("GATHER-DEVICE-001", RuleSubmissionService.SuggestPublishedRuleId("gather", "device", Array.Empty<string>()));
Assert.Equal("ANALYZE-DEV-001", RuleSubmissionService.SuggestPublishedRuleId("analyze", "device", Array.Empty<string>()));
Assert.Equal("ANALYZE-ENRL-001", RuleSubmissionService.SuggestPublishedRuleId("analyze", "enrollment", Array.Empty<string>()));
Assert.Equal("GATHER-ENROLL-001", RuleSubmissionService.SuggestPublishedRuleId("gather", "enrollment", Array.Empty<string>()));
}
[Fact]
public void Suggest_is_case_insensitive_over_taken_ids()
{
Assert.Equal("ANALYZE-SEC-008", RuleSubmissionService.SuggestPublishedRuleId("analyze", "security", new[] { "analyze-sec-007" }));
}
[Fact]
public void Suggest_falls_back_to_the_upper_cased_category_when_unmapped()
{
Assert.Equal("ANALYZE-OFFICE-001", RuleSubmissionService.SuggestPublishedRuleId("analyze", "office", Array.Empty<string>()));
}
// ── freeze + repo file ──────────────────────────────────────────────────
private static AnalyzeRule CustomAnalyzeRule() => new()
{
RuleId = "ANALYZE-CUSTOM-003",
Title = "Proxy PAC unreachable",
Description = "PAC download fails",
Severity = "warning",
Category = "network",
Version = "1.2.0",
Author = "Alice Admin",
Enabled = false,
IsBuiltIn = false,
IsCommunity = false,
Provenance = "embedded",
MarkSessionAsFailed = true,
Notify = true,
NotifyChannelIds = new List<string> { "chan-1" },
DerivedFromTemplateRuleId = "ANALYZE-SEC-004",
Explanation = "The PAC file could not be fetched.",
Conditions = new List<RuleCondition>
{
new() { Signal = "pac_failed", Source = "event_type", EventType = "network_pac_failed", Required = true },
},
CreatedAt = new DateTime(2026, 1, 1, 0, 0, 0, DateTimeKind.Utc),
UpdatedAt = new DateTime(2026, 2, 1, 0, 0, 0, DateTimeKind.Utc),
};
[Fact]
public void Freeze_strips_server_and_tenant_fields_and_keeps_the_rule()
{
var json = RuleSubmissionService.FreezeRule(CustomAnalyzeRule());
var node = JsonNode.Parse(json)!.AsObject();
foreach (var stripped in new[] { "isBuiltIn", "provenance", "createdAt", "updatedAt", "markSessionAsFailed", "notifyDefault", "notify", "notifyChannelIds" })
Assert.False(node.ContainsKey(stripped), $"{stripped} must not be frozen");
Assert.Equal("ANALYZE-CUSTOM-003", node["ruleId"]!.GetValue<string>());
Assert.Equal("Alice Admin", node["author"]!.GetValue<string>());
Assert.Equal("ANALYZE-SEC-004", node["derivedFromTemplateRuleId"]!.GetValue<string>());
Assert.Single(node["conditions"]!.AsArray());
}
[Fact]
public void RepoFile_carries_schema_pointer_assigned_id_credit_and_community_flag_in_repo_order()
{
var s = new RuleSubmission
{
RuleKind = RuleSubmissionKinds.Analyze,
RuleJson = RuleSubmissionService.FreezeRule(CustomAnalyzeRule()),
AttributionName = RuleAttributionModes.AnonymousAuthor,
};
var file = RuleSubmissionService.BuildRepoFile(s, "ANALYZE-NET-002");
Assert.Equal("rules/analyze/ANALYZE-NET-002.json", file.Path);
Assert.EndsWith("\n", file.Content);
var node = JsonNode.Parse(file.Content)!.AsObject();
var keys = node.Select(kv => kv.Key).ToList();
Assert.Equal(new[] { "$schema", "ruleId", "title", "description", "severity", "category", "version", "author", "enabled", "isCommunity" }, keys.Take(10));
Assert.Equal("../schema/analyze-rule.schema.json", node["$schema"]!.GetValue<string>());
Assert.Equal("ANALYZE-NET-002", node["ruleId"]!.GetValue<string>());
Assert.Equal("Community contribution", node["author"]!.GetValue<string>());
Assert.True(node["isCommunity"]!.GetValue<bool>());
// Analyze rules ship enabled — the tenant's own toggle state does not travel.
Assert.True(node["enabled"]!.GetValue<bool>());
Assert.False(node.ContainsKey("derivedFromTemplateRuleId"));
Assert.False(node.ContainsKey("isBuiltIn"));
Assert.Contains("\"explanation\": \"The PAC file could not be fetched.\"", file.Content);
}
[Fact]
public void RepoFile_for_a_gather_rule_ships_disabled_and_without_severity()
{
var gather = new GatherRule
{
RuleId = "GATHER-CUSTOM-001",
Title = "BIOS config",
Description = "Reads the BIOS registry block",
Category = "device",
Enabled = true,
IsBuiltIn = false,
CollectorType = "registry",
Target = "HKLM\\SOFTWARE\\Vendor\\BIOS",
Trigger = "startup",
OutputEventType = "gather_bios_config",
};
var s = new RuleSubmission
{
RuleKind = RuleSubmissionKinds.Gather,
RuleJson = RuleSubmissionService.FreezeRule(gather),
AttributionName = "Contoso IT",
};
var file = RuleSubmissionService.BuildRepoFile(s, "GATHER-DEVICE-009");
Assert.Equal("rules/gather/GATHER-DEVICE-009.json", file.Path);
var node = JsonNode.Parse(file.Content)!.AsObject();
Assert.Equal("../schema/gather-rule.schema.json", node["$schema"]!.GetValue<string>());
Assert.False(node["enabled"]!.GetValue<bool>());
Assert.Equal("Contoso IT", node["author"]!.GetValue<string>());
Assert.False(node.ContainsKey("severity"));
// No \u escaping of the backslash-heavy registry path beyond JSON's own rules.
Assert.Contains("HKLM\\\\SOFTWARE\\\\Vendor\\\\BIOS", file.Content);
}
// ── attribution ─────────────────────────────────────────────────────────
[Theory]
[InlineData("Alice A.")]
[InlineData("Contoso IT & Ops (EMEA)")]
[InlineData("Zoë Müller-Lüdenscheidt")]
public void AttributionName_accepts_names(string name)
=> Assert.Equal(name, RuleSubmissionService.ValidateAttributionName(name));
[Theory]
[InlineData("")]
[InlineData("<script>")]
[InlineData("https://example.com")]
[InlineData("line\nbreak")]
public void AttributionName_rejects_markup_urls_and_control_characters(string name)
=> Assert.Throws<ArgumentException>(() => RuleSubmissionService.ValidateAttributionName(name));
[Theory]
[InlineData(null, null)]
[InlineData("", null)]
[InlineData(" alice@contoso.com ", "alice@contoso.com")]
public void Email_is_trimmed_or_null(string? input, string? expected)
=> Assert.Equal(expected, RuleSubmissionService.NormalizeEmail(input));
[Theory]
[InlineData("alice")]
[InlineData("@contoso.com")]
[InlineData("alice@")]
[InlineData("a@b@c")]
[InlineData("alice @contoso.com")]
public void Email_rejects_non_addresses(string input)
=> Assert.Throws<ArgumentException>(() => RuleSubmissionService.NormalizeEmail(input));
// ── review state machine ────────────────────────────────────────────────
private static (RuleSubmissionService service, Mock<IRuleSubmissionRepository> repo) Build(
RuleSubmission row, IEnumerable<string>? globalAnalyzeIds = null, IEnumerable<string>? reservedIds = null)
{
var repo = new Mock<IRuleSubmissionRepository>(MockBehavior.Loose);
repo.Setup(r => r.GetAsync(row.SubmissionId)).ReturnsAsync(row);
repo.Setup(r => r.UpdateAsync(It.IsAny<RuleSubmission>())).ReturnsAsync(true);
repo.Setup(r => r.GetReservedPublishedRuleIdsAsync())
.ReturnsAsync(new HashSet<string>(reservedIds ?? Array.Empty<string>(), StringComparer.OrdinalIgnoreCase));
var rules = new Mock<IRuleRepository>(MockBehavior.Loose);
rules.Setup(r => r.GetAnalyzeRulesAsync("global")).ReturnsAsync(
(globalAnalyzeIds ?? Array.Empty<string>()).Select(id => new AnalyzeRule { RuleId = id, IsBuiltIn = true }).ToList());
rules.Setup(r => r.GetGatherRulesAsync("global")).ReturnsAsync(new List<GatherRule>());
var metrics = new Mock<IMetricsRepository>(MockBehavior.Loose);
var config = new Mock<TenantConfigurationService>(MockBehavior.Loose,
Mock.Of<IConfigRepository>(), NullLogger<TenantConfigurationService>.Instance, new MemoryCache(new MemoryCacheOptions()));
var service = new RuleSubmissionService(repo.Object, rules.Object, metrics.Object, config.Object,
NullLogger<RuleSubmissionService>.Instance);
return (service, repo);
}
private static RuleSubmission PendingRow() => new()
{
SubmissionId = "a1b2c3d4e5f6",
BatchId = "b",
TenantId = TenantId,
RuleKind = RuleSubmissionKinds.Analyze,
SourceRuleId = "ANALYZE-CUSTOM-003",
Title = "Proxy PAC unreachable",
Category = "network",
RuleJson = RuleSubmissionService.FreezeRule(CustomAnalyzeRule()),
SubmittedBy = "alice@contoso.com",
SubmittedByName = "Alice Admin",
SubmittedAt = DateTime.UtcNow,
Status = RuleSubmissionStatuses.Pending,
};
[Fact]
public async Task Approve_requires_a_reserved_id_of_the_same_kind()
{
var (service, _) = Build(PendingRow());
await Assert.ThrowsAsync<ArgumentException>(() => service.ReviewAsync("a1b2c3d4e5f6",
new ReviewRuleSubmissionRequest { Decision = "approve" }, "ga@example.com"));
await Assert.ThrowsAsync<ArgumentException>(() => service.ReviewAsync("a1b2c3d4e5f6",
new ReviewRuleSubmissionRequest { Decision = "approve", PublishedRuleId = "ANALYZE-CUSTOM-009" }, "ga@example.com"));
await Assert.ThrowsAsync<ArgumentException>(() => service.ReviewAsync("a1b2c3d4e5f6",
new ReviewRuleSubmissionRequest { Decision = "approve", PublishedRuleId = "GATHER-NET-002" }, "ga@example.com"));
}
[Fact]
public async Task Approve_refuses_an_id_taken_by_the_catalog_or_another_approval()
{
var (service, _) = Build(PendingRow(), globalAnalyzeIds: new[] { "ANALYZE-NET-001" }, reservedIds: new[] { "ANALYZE-NET-002" });
await Assert.ThrowsAsync<InvalidOperationException>(() => service.ReviewAsync("a1b2c3d4e5f6",
new ReviewRuleSubmissionRequest { Decision = "approve", PublishedRuleId = "ANALYZE-NET-001" }, "ga@example.com"));
await Assert.ThrowsAsync<InvalidOperationException>(() => service.ReviewAsync("a1b2c3d4e5f6",
new ReviewRuleSubmissionRequest { Decision = "approve", PublishedRuleId = "ANALYZE-NET-002" }, "ga@example.com"));
}
[Fact]
public async Task Approve_stores_id_comment_adaptation_flag_and_reviewer()
{
var (service, repo) = Build(PendingRow());
RuleSubmission? written = null;
repo.Setup(r => r.UpdateAsync(It.IsAny<RuleSubmission>())).Callback<RuleSubmission>(s => written = s).ReturnsAsync(true);
var result = await service.ReviewAsync("a1b2c3d4e5f6",
new ReviewRuleSubmissionRequest { Decision = "approve", PublishedRuleId = "ANALYZE-NET-003", ReviewComment = "Taken, will generalise the title.", WillBeAdapted = true },
"ga@example.com");
Assert.Same(result, written);
Assert.Equal(RuleSubmissionStatuses.Approved, result.Status);
Assert.Equal("ANALYZE-NET-003", result.PublishedRuleId);
Assert.True(result.WillBeAdapted);
Assert.Equal("Taken, will generalise the title.", result.ReviewComment);
Assert.Equal("ga@example.com", result.ReviewedBy);
Assert.NotNull(result.ReviewedAt);
}
[Fact]
public async Task Decline_requires_a_comment_and_clears_the_published_id()
{
var row = PendingRow();
row.Status = RuleSubmissionStatuses.Approved;
row.PublishedRuleId = "ANALYZE-NET-003";
var (service, _) = Build(row);
await Assert.ThrowsAsync<ArgumentException>(() => service.ReviewAsync("a1b2c3d4e5f6",
new ReviewRuleSubmissionRequest { Decision = "decline" }, "ga@example.com"));
var result = await service.ReviewAsync("a1b2c3d4e5f6",
new ReviewRuleSubmissionRequest { Decision = "decline", ReviewComment = "Too tenant-specific." }, "ga@example.com");
Assert.Equal(RuleSubmissionStatuses.Declined, result.Status);
Assert.Null(result.PublishedRuleId);
Assert.False(result.WillBeAdapted);
}
[Fact]
public async Task Published_is_derived_and_final()
{
var row = PendingRow();
row.Status = RuleSubmissionStatuses.Approved;
row.PublishedRuleId = "ANALYZE-NET-003";
var (service, _) = Build(row, globalAnalyzeIds: new[] { "ANALYZE-NET-003" });
var items = await service.ToItemsAsync(new[] { row });
Assert.Equal(RuleSubmissionStatuses.Published, items[0].Status);
Assert.Equal(RuleSubmissionStatuses.Approved, row.Status);
await Assert.ThrowsAsync<InvalidOperationException>(() => service.ReviewAsync("a1b2c3d4e5f6",
new ReviewRuleSubmissionRequest { Decision = "decline", ReviewComment = "too late" }, "ga@example.com"));
}
[Fact]
public async Task Approved_but_unpublished_stays_approved_on_the_wire()
{
var row = PendingRow();
row.Status = RuleSubmissionStatuses.Approved;
row.PublishedRuleId = "ANALYZE-NET-003";
var (service, _) = Build(row, globalAnalyzeIds: new[] { "ANALYZE-NET-001" });
var items = await service.ToItemsAsync(new[] { row });
Assert.Equal(RuleSubmissionStatuses.Approved, items[0].Status);
}
[Fact]
public async Task Withdraw_only_pending_and_only_own_tenant()
{
var row = PendingRow();
var (service, _) = Build(row);
Assert.False(await service.WithdrawAsync("22222222-2222-2222-2222-222222222222", "a1b2c3d4e5f6", crossTenantAllowed: false));
Assert.True(await service.WithdrawAsync(TenantId, "a1b2c3d4e5f6", crossTenantAllowed: false));
Assert.Equal(RuleSubmissionStatuses.Withdrawn, row.Status);
await Assert.ThrowsAsync<InvalidOperationException>(() => service.WithdrawAsync(TenantId, "a1b2c3d4e5f6", crossTenantAllowed: false));
await Assert.ThrowsAsync<InvalidOperationException>(() => service.ReviewAsync("a1b2c3d4e5f6",
new ReviewRuleSubmissionRequest { Decision = "approve", PublishedRuleId = "ANALYZE-NET-003" }, "ga@example.com"));
}
[Fact]
public async Task Operator_delete_passes_through_to_the_repository()
{
var (service, repo) = Build(PendingRow());
repo.Setup(r => r.DeleteAsync("a1b2c3d4e5f6")).ReturnsAsync(true);
Assert.True(await service.DeleteAsync("a1b2c3d4e5f6"));
repo.Verify(r => r.DeleteAsync("a1b2c3d4e5f6"), Times.Once);
}
[Fact]
public async Task Unknown_decision_is_a_bad_request()
{
var (service, _) = Build(PendingRow());
await Assert.ThrowsAsync<ArgumentException>(() => service.ReviewAsync("a1b2c3d4e5f6",
new ReviewRuleSubmissionRequest { Decision = "maybe" }, "ga@example.com"));
}
[Fact]
public async Task Detail_returns_the_typed_rule_suggested_id_and_repo_file()
{
var (service, _) = Build(PendingRow(), globalAnalyzeIds: new[] { "ANALYZE-NET-001" });
var detail = await service.GetDetailAsync("a1b2c3d4e5f6");
Assert.NotNull(detail);
Assert.NotNull(detail!.AnalyzeRule);
Assert.Null(detail.GatherRule);
Assert.Equal("ANALYZE-CUSTOM-003", detail.AnalyzeRule!.RuleId);
Assert.False(detail.AnalyzeRule.IsBuiltIn);
Assert.Equal("ANALYZE-NET-002", detail.SuggestedPublishedRuleId);
Assert.Equal("rules/analyze/ANALYZE-NET-002.json", detail.RepoFile!.Path);
}
// ── submit ──────────────────────────────────────────────────────────────
private static (RuleSubmissionService service, List<RuleSubmission> stored) BuildForSubmit(
List<AnalyzeRule> tenantAnalyze, List<RuleSubmission>? existing = null, TenantConfiguration? config = null)
{
var stored = new List<RuleSubmission>();
var repo = new Mock<IRuleSubmissionRepository>(MockBehavior.Loose);
repo.Setup(r => r.GetForTenantAsync(TenantId)).ReturnsAsync(existing ?? new List<RuleSubmission>());
repo.Setup(r => r.AddAsync(It.IsAny<RuleSubmission>())).Callback<RuleSubmission>(stored.Add).ReturnsAsync(true);
repo.Setup(r => r.GetReservedPublishedRuleIdsAsync()).ReturnsAsync(new HashSet<string>());
var rules = new Mock<IRuleRepository>(MockBehavior.Loose);
rules.Setup(r => r.GetAnalyzeRulesAsync(TenantId)).ReturnsAsync(tenantAnalyze);
rules.Setup(r => r.GetGatherRulesAsync(TenantId)).ReturnsAsync(new List<GatherRule>());
rules.Setup(r => r.GetAnalyzeRulesAsync("global")).ReturnsAsync(new List<AnalyzeRule>());
rules.Setup(r => r.GetGatherRulesAsync("global")).ReturnsAsync(new List<GatherRule>());
var metrics = new Mock<IMetricsRepository>(MockBehavior.Loose);
metrics.Setup(m => m.GetRuleStatsAsync(TenantId, It.IsAny<string?>(), It.IsAny<string?>(), It.IsAny<string?>(), It.IsAny<int>()))
.ReturnsAsync(new List<RuleStatsEntry>
{
new() { RuleId = "ANALYZE-CUSTOM-003", FireCount = 4, SessionsEvaluated = 40, EvaluationCount = 41 },
new() { RuleId = "ANALYZE-CUSTOM-003", FireCount = 1, SessionsEvaluated = 10, EvaluationCount = 10 },
new() { RuleId = "ANALYZE-CUSTOM-999", FireCount = 99, SessionsEvaluated = 99, EvaluationCount = 99 },
});
var configRepo = new Mock<IConfigRepository>(MockBehavior.Loose);
var configService = new Mock<TenantConfigurationService>(MockBehavior.Loose, configRepo.Object,
NullLogger<TenantConfigurationService>.Instance, new MemoryCache(new MemoryCacheOptions()));
configService.Setup(c => c.GetConfigurationIfExistsAsync(TenantId)).ReturnsAsync(config);
var service = new RuleSubmissionService(repo.Object, rules.Object, metrics.Object, configService.Object,
NullLogger<RuleSubmissionService>.Instance);
return (service, stored);
}
private static SubmitRuleSubmissionsRequest Request(params string[] ruleIds) => new()
{
TenantId = TenantId,
Items = ruleIds.Select(id => new RuleSubmissionItemRef { Kind = "analyze", RuleId = id }).ToList(),
Comment = "Fires when the PAC download fails during ESP.",
AttributionMode = RuleAttributionModes.Anonymous,
};
[Fact]
public async Task Submit_freezes_the_tenant_rule_records_findings_and_fire_stats()
{
var (service, stored) = BuildForSubmit(new List<AnalyzeRule> { CustomAnalyzeRule() });
var created = await service.SubmitAsync(TenantId, Request("ANALYZE-CUSTOM-003"), "alice@contoso.com", "Alice Admin");
var s = Assert.Single(created);
Assert.Same(s, Assert.Single(stored));
Assert.Equal(12, s.SubmissionId.Length);
Assert.Equal(12, s.BatchId.Length);
Assert.Equal(RuleSubmissionStatuses.Pending, s.Status);
Assert.Equal("Community contribution", s.AttributionName);
Assert.Null(s.ContactEmail);
Assert.Equal("Proxy PAC unreachable", s.Title);
Assert.Equal("network", s.Category);
Assert.Equal("ANALYZE-SEC-004", s.DerivedFromTemplateRuleId);
Assert.Contains(s.ValidationFindings, f => f.Level == "info" && f.Message.Contains("ANALYZE-SEC-004"));
Assert.DoesNotContain(s.ValidationFindings, f => f.Level == "error");
Assert.Equal(5, s.SourceFireStats!.FireCount);
Assert.Equal(50, s.SourceFireStats.SessionsEvaluated);
Assert.DoesNotContain("isBuiltIn", s.RuleJson);
}
[Fact]
public async Task Submit_rejects_built_in_and_unknown_rules_without_storing_anything()
{
var builtIn = CustomAnalyzeRule();
builtIn.RuleId = "ANALYZE-NET-001";
builtIn.IsBuiltIn = true;
var (service, stored) = BuildForSubmit(new List<AnalyzeRule> { CustomAnalyzeRule(), builtIn });
var ex = await Assert.ThrowsAsync<ArgumentException>(() =>
service.SubmitAsync(TenantId, Request("ANALYZE-CUSTOM-003", "ANALYZE-NET-001", "ANALYZE-CUSTOM-404"), "alice@contoso.com", "Alice Admin"));
Assert.Contains("ANALYZE-NET-001", ex.Message);
Assert.Contains("ANALYZE-CUSTOM-404", ex.Message);
Assert.Empty(stored);
}
[Fact]
public async Task Submit_rejects_a_rule_whose_draft_validation_fails()
{
var broken = CustomAnalyzeRule();
broken.Conditions = new List<RuleCondition>();
var (service, stored) = BuildForSubmit(new List<AnalyzeRule> { broken });
var ex = await Assert.ThrowsAsync<ArgumentException>(() =>
service.SubmitAsync(TenantId, Request("ANALYZE-CUSTOM-003"), "alice@contoso.com", "Alice Admin"));
Assert.Contains("at least one condition", ex.Message);
Assert.Empty(stored);
}
[Fact]
public async Task Submit_refuses_a_second_pending_submission_of_the_same_rule()
{
var (service, _) = BuildForSubmit(new List<AnalyzeRule> { CustomAnalyzeRule() }, existing: new List<RuleSubmission> { PendingRow() });
await Assert.ThrowsAsync<InvalidOperationException>(() =>
service.SubmitAsync(TenantId, Request("ANALYZE-CUSTOM-003"), "alice@contoso.com", "Alice Admin"));
}
[Fact]
public async Task Submit_enforces_the_daily_cap()
{
var existing = Enumerable.Range(0, RuleSubmissionService.MaxSubmissionsPerTenantPerDay)
.Select(i => { var r = PendingRow(); r.SourceRuleId = $"OTHER-{i}"; r.Status = RuleSubmissionStatuses.Declined; return r; })
.ToList();
var (service, _) = BuildForSubmit(new List<AnalyzeRule> { CustomAnalyzeRule() }, existing);
await Assert.ThrowsAsync<InvalidOperationException>(() =>
service.SubmitAsync(TenantId, Request("ANALYZE-CUSTOM-003"), "alice@contoso.com", "Alice Admin"));
}
[Fact]
public async Task Submit_organization_attribution_uses_the_company_name_and_fails_without_one()
{
var withName = new TenantConfiguration { TenantId = TenantId, DomainName = "contoso.example", CompanyName = "Contoso Ltd." };
var (service, _) = BuildForSubmit(new List<AnalyzeRule> { CustomAnalyzeRule() }, config: withName);
var request = Request("ANALYZE-CUSTOM-003");
request.AttributionMode = RuleAttributionModes.Organization;
var created = await service.SubmitAsync(TenantId, request, "alice@contoso.com", "Alice Admin");
Assert.Equal("Contoso Ltd.", created[0].AttributionName);
var (noConfig, _) = BuildForSubmit(new List<AnalyzeRule> { CustomAnalyzeRule() }, config: null);
await Assert.ThrowsAsync<ArgumentException>(() => noConfig.SubmitAsync(TenantId, request, "alice@contoso.com", "Alice Admin"));
}
[Fact]
public async Task Submit_stores_the_contact_email_when_given()
{
var (service, _) = BuildForSubmit(new List<AnalyzeRule> { CustomAnalyzeRule() });
var request = Request("ANALYZE-CUSTOM-003");
request.Email = " alice.reply@contoso.com ";
var created = await service.SubmitAsync(TenantId, request, "alice@contoso.com", "Alice Admin");
Assert.Equal("alice.reply@contoso.com", created[0].ContactEmail);
}
[Fact]
public async Task Submit_person_attribution_freezes_the_requested_name()
{
var (service, _) = BuildForSubmit(new List<AnalyzeRule> { CustomAnalyzeRule() });
var request = Request("ANALYZE-CUSTOM-003");
request.AttributionMode = RuleAttributionModes.Person;
request.AttributionName = " Alice A. ";
var created = await service.SubmitAsync(TenantId, request, "alice@contoso.com", "Alice Admin");
Assert.Equal("Alice A.", created[0].AttributionName);
Assert.Equal(RuleAttributionModes.Person, created[0].AttributionMode);
}
}
@@ -0,0 +1,136 @@
using AutopilotMonitor.Shared.Models;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// Wire pins for the rule-submission responses (typed from the start — the anonymous side is
/// the literal a client sees, so a reordered or renamed property fails here first).
/// </summary>
public class RuleSubmissionsWireParityTests
{
private static readonly DateTime T0 = new(2026, 9, 9, 10, 30, 0, DateTimeKind.Utc);
private static RuleSubmissionItem Item() => new()
{
SubmissionId = "a1b2c3d4e5f6",
BatchId = "0f0e0d0c0b0a",
TenantId = "11111111-1111-1111-1111-111111111111",
RuleKind = "analyze",
SourceRuleId = "ANALYZE-CUSTOM-003",
Title = "Proxy PAC unreachable",
Category = "network",
Comment = "Fires when the PAC download fails.",
SubmittedBy = "alice@contoso.com",
SubmittedByName = "Alice Admin",
ContactEmail = "alice.reply@contoso.com",
AttributionMode = "anonymous",
AttributionName = "Community contribution",
SubmittedAt = T0,
Status = "approved",
ValidationFindings = new List<RuleSubmissionFinding> { new() { Level = "info", Message = "Derived from template ANALYZE-SEC-004" } },
SourceFireStats = new RuleSubmissionFireStats { Days = 30, FireCount = 42, SessionsEvaluated = 310, EvaluationCount = 312 },
ReviewedBy = "ga@example.com",
ReviewedAt = T0.AddDays(1),
ReviewComment = "Taken.",
WillBeAdapted = true,
PublishedRuleId = "ANALYZE-NET-002",
DerivedFromTemplateRuleId = "ANALYZE-SEC-004",
};
private static object ItemLiteral() => new
{
submissionId = "a1b2c3d4e5f6",
batchId = "0f0e0d0c0b0a",
tenantId = "11111111-1111-1111-1111-111111111111",
ruleKind = "analyze",
sourceRuleId = "ANALYZE-CUSTOM-003",
title = "Proxy PAC unreachable",
category = "network",
comment = "Fires when the PAC download fails.",
submittedBy = "alice@contoso.com",
submittedByName = "Alice Admin",
contactEmail = "alice.reply@contoso.com",
attributionMode = "anonymous",
attributionName = "Community contribution",
submittedAt = T0,
status = "approved",
validationFindings = new List<object> { new { level = "info", message = "Derived from template ANALYZE-SEC-004" } },
sourceFireStats = new { days = 30, fireCount = 42, sessionsEvaluated = 310, evaluationCount = 312 },
reviewedBy = "ga@example.com",
reviewedAt = T0.AddDays(1),
reviewComment = "Taken.",
willBeAdapted = true,
publishedRuleId = "ANALYZE-NET-002",
derivedFromTemplateRuleId = "ANALYZE-SEC-004",
};
[Fact]
public void Submit_response_shape()
{
ApiResponseWireParityTests.AssertWireIdentical(
new { success = true, message = "Rule submitted for review.", batchId = "0f0e0d0c0b0a", submissions = new List<object> { ItemLiteral() } },
new SubmitRuleSubmissionsResponse { Success = true, Message = "Rule submitted for review.", BatchId = "0f0e0d0c0b0a", Submissions = new List<RuleSubmissionItem> { Item() } });
}
[Fact]
public void List_nonPaged_has_no_nextLink_key()
{
ApiResponseWireParityTests.AssertWireIdentical(
new { success = true, count = 1, submissions = new List<object> { ItemLiteral() } },
new RuleSubmissionListResponse { Success = true, Count = 1, Submissions = new List<RuleSubmissionItem> { Item() } });
}
[Fact]
public void List_paged_carries_nextLink()
{
ApiResponseWireParityTests.AssertWireIdentical(
new { success = true, count = 1, submissions = new List<object> { ItemLiteral() }, nextLink = "/api/global/rule-submissions?pageSize=20&continuation=abc" },
new RuleSubmissionListResponse { Success = true, Count = 1, Submissions = new List<RuleSubmissionItem> { Item() }, NextLink = "/api/global/rule-submissions?pageSize=20&continuation=abc" });
}
[Fact]
public void List_last_page_drops_the_nextLink_key()
{
ApiResponseWireParityTests.AssertWireIdentical(
new { success = true, count = 0, submissions = new List<object>() },
new RuleSubmissionListResponse { Success = true, Count = 0, Submissions = new List<RuleSubmissionItem>(), NextLink = null });
}
[Fact]
public void Detail_shape_with_analyze_rule_omits_the_gather_slot()
{
var rule = new AnalyzeRule
{
RuleId = "ANALYZE-CUSTOM-003", Title = "Proxy PAC unreachable", Description = "d", Severity = "warning", Category = "network",
Explanation = "e", IsBuiltIn = false, Conditions = new List<RuleCondition>(),
};
var typed = new RuleSubmissionDetailResponse
{
Success = true,
Submission = Item(),
AnalyzeRule = rule,
LiveFireStats = new RuleSubmissionFireStats { Days = 30, FireCount = 1, SessionsEvaluated = 2, EvaluationCount = 3 },
SuggestedPublishedRuleId = "ANALYZE-NET-002",
RepoFile = new RuleSubmissionRepoFile { Path = "rules/analyze/ANALYZE-NET-002.json", Content = "{}\n" },
};
ApiResponseWireParityTests.AssertWireIdentical(
new
{
success = true,
submission = ItemLiteral(),
analyzeRule = rule,
liveFireStats = new { days = 30, fireCount = 1, sessionsEvaluated = 2, evaluationCount = 3 },
suggestedPublishedRuleId = "ANALYZE-NET-002",
repoFile = new { path = "rules/analyze/ANALYZE-NET-002.json", content = "{}\n" },
},
typed);
}
[Fact]
public void Review_response_shape()
{
ApiResponseWireParityTests.AssertWireIdentical(
new { success = true, message = "Submission approved.", submission = ItemLiteral() },
new ReviewRuleSubmissionResponse { Success = true, Message = "Submission approved.", Submission = Item() });
}
}
@@ -88,6 +88,12 @@ public sealed class SharedManifestParityTests
["webhookProviderTypes"] = EnumMap<WebhookProviderType>(),
["annotationLanes"] = AnnotationLanes.All,
["annotationVerdicts"] = AnnotationVerdicts.All,
// Community rule submissions: kinds, effective statuses (incl. the derived "published"),
// attribution modes and reviewer decisions — the MCP tool schemas enumerate these.
["ruleSubmissionKinds"] = RuleSubmissionKinds.All,
["ruleSubmissionStatuses"] = RuleSubmissionStatuses.All,
["ruleAttributionModes"] = RuleAttributionModes.All,
["ruleSubmissionDecisions"] = RuleSubmissionDecisions.All,
// Ops vocabularies. Declaration order kept for severities — it IS the ladder
// (Info < Warning < Error < Critical), and the MCP renders it in that order.
["opsEventCategories"] = ConstStrings(typeof(OpsEventCategory)),
@@ -0,0 +1,195 @@
using AutopilotMonitor.Functions.DataAccess.TableStorage;
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Shared.Models;
namespace AutopilotMonitor.Functions.Tests;
/// <summary>
/// Round-trip pins for the RuleSubmissions Store/Map pair (memory:
/// feedback_table_storage_serialization — every new field in <see cref="RuleSubmission"/>
/// MUST be exercised in Store+Map so silent drops surface here), plus the key and filter shapes.
/// </summary>
public class TableRuleSubmissionRepositoryTests
{
private const string TenantId = "11111111-1111-1111-1111-111111111111";
private static RuleSubmission Full() => new()
{
SubmissionId = "a1b2c3d4e5f6",
BatchId = "0f0e0d0c0b0a",
TenantId = TenantId,
RuleKind = RuleSubmissionKinds.Analyze,
SourceRuleId = "ANALYZE-CUSTOM-003",
Title = "Proxy PAC unreachable",
Category = "network",
RuleJson = "{\"ruleId\":\"ANALYZE-CUSTOM-003\",\"title\":\"Proxy PAC unreachable\"}",
Comment = "Fires when the PAC download fails during ESP.",
SubmittedBy = "alice@contoso.com",
SubmittedByName = "Alice Admin",
ContactEmail = "alice.reply@contoso.com",
AttributionMode = RuleAttributionModes.Person,
AttributionName = "Alice A.",
SubmittedAt = new DateTime(2026, 9, 9, 10, 30, 0, DateTimeKind.Utc),
Status = RuleSubmissionStatuses.Approved,
ValidationFindings = new List<RuleSubmissionFinding>
{
new() { Level = "info", Message = "Derived from template ANALYZE-SEC-004" },
},
SourceFireStats = new RuleSubmissionFireStats { Days = 30, FireCount = 42, SessionsEvaluated = 310, EvaluationCount = 312 },
ReviewedBy = "ga@example.com",
ReviewedAt = new DateTime(2026, 9, 10, 8, 0, 0, DateTimeKind.Utc),
ReviewComment = "Taken, generalised for the community.",
WillBeAdapted = true,
PublishedRuleId = "ANALYZE-NET-002",
DerivedFromTemplateRuleId = "ANALYZE-SEC-004",
};
[Fact]
public void Roundtrip_all_fields_survive_store_and_map()
{
var original = Full();
var mapped = TableRuleSubmissionRepository.MapSubmission(
TableRuleSubmissionRepository.StoreSubmission(original));
Assert.Equal(original.SubmissionId, mapped.SubmissionId);
Assert.Equal(original.BatchId, mapped.BatchId);
Assert.Equal(original.TenantId, mapped.TenantId);
Assert.Equal(original.RuleKind, mapped.RuleKind);
Assert.Equal(original.SourceRuleId, mapped.SourceRuleId);
Assert.Equal(original.Title, mapped.Title);
Assert.Equal(original.Category, mapped.Category);
Assert.Equal(original.RuleJson, mapped.RuleJson);
Assert.Equal(original.Comment, mapped.Comment);
Assert.Equal(original.SubmittedBy, mapped.SubmittedBy);
Assert.Equal(original.SubmittedByName, mapped.SubmittedByName);
Assert.Equal(original.ContactEmail, mapped.ContactEmail);
Assert.Equal(original.AttributionMode, mapped.AttributionMode);
Assert.Equal(original.AttributionName, mapped.AttributionName);
Assert.Equal(original.SubmittedAt, mapped.SubmittedAt);
Assert.Equal(original.Status, mapped.Status);
Assert.Single(mapped.ValidationFindings);
Assert.Equal("info", mapped.ValidationFindings[0].Level);
Assert.Equal(original.ValidationFindings[0].Message, mapped.ValidationFindings[0].Message);
Assert.NotNull(mapped.SourceFireStats);
Assert.Equal(42, mapped.SourceFireStats!.FireCount);
Assert.Equal(310, mapped.SourceFireStats.SessionsEvaluated);
Assert.Equal(312, mapped.SourceFireStats.EvaluationCount);
Assert.Equal(30, mapped.SourceFireStats.Days);
Assert.Equal(original.ReviewedBy, mapped.ReviewedBy);
Assert.Equal(original.ReviewedAt, mapped.ReviewedAt);
Assert.Equal(original.ReviewComment, mapped.ReviewComment);
Assert.True(mapped.WillBeAdapted);
Assert.Equal(original.PublishedRuleId, mapped.PublishedRuleId);
Assert.Equal(original.DerivedFromTemplateRuleId, mapped.DerivedFromTemplateRuleId);
}
[Fact]
public void Roundtrip_pending_row_keeps_nulls_null()
{
var original = Full();
original.Status = RuleSubmissionStatuses.Pending;
original.Comment = null;
original.ContactEmail = null;
original.SourceFireStats = null;
original.ValidationFindings = new List<RuleSubmissionFinding>();
original.ReviewedBy = null;
original.ReviewedAt = null;
original.ReviewComment = null;
original.WillBeAdapted = false;
original.PublishedRuleId = null;
original.DerivedFromTemplateRuleId = null;
var mapped = TableRuleSubmissionRepository.MapSubmission(
TableRuleSubmissionRepository.StoreSubmission(original));
Assert.Null(mapped.Comment);
Assert.Null(mapped.ContactEmail);
Assert.Null(mapped.SourceFireStats);
Assert.Empty(mapped.ValidationFindings);
Assert.Null(mapped.ReviewedBy);
Assert.Null(mapped.ReviewedAt);
Assert.Null(mapped.ReviewComment);
Assert.False(mapped.WillBeAdapted);
Assert.Null(mapped.PublishedRuleId);
Assert.Null(mapped.DerivedFromTemplateRuleId);
}
[Fact]
public void Store_uses_the_single_partition_and_an_inverted_tick_row_key()
{
var s = Full();
var entity = TableRuleSubmissionRepository.StoreSubmission(s);
Assert.Equal("submissions", entity.PartitionKey);
Assert.Equal($"{RowKeyCodec.InvertedTicks(s.SubmittedAt)}_{s.SubmissionId}", entity.RowKey);
}
[Fact]
public void Newer_submission_sorts_first()
{
var older = Full();
var newer = Full();
newer.SubmittedAt = older.SubmittedAt.AddMinutes(5);
var olderKey = TableRuleSubmissionRepository.StoreSubmission(older).RowKey;
var newerKey = TableRuleSubmissionRepository.StoreSubmission(newer).RowKey;
Assert.True(string.CompareOrdinal(newerKey, olderKey) < 0);
}
[Fact]
public void Map_tolerates_a_corrupt_json_column()
{
var entity = TableRuleSubmissionRepository.StoreSubmission(Full());
entity["ValidationFindingsJson"] = "{not json";
entity["SourceFireStatsJson"] = "[]";
var mapped = TableRuleSubmissionRepository.MapSubmission(entity);
Assert.Empty(mapped.ValidationFindings);
Assert.Null(mapped.SourceFireStats);
}
// ── retention rule (shared by the sweep and this pin) ──
private static readonly DateTime Now = new(2026, 12, 1, 12, 0, 0, DateTimeKind.Utc);
[Theory]
[InlineData("withdrawn", 29, false)]
[InlineData("withdrawn", 30, true)]
[InlineData("declined", 89, false)]
[InlineData("declined", 90, true)]
[InlineData("pending", 400, false)]
[InlineData("approved", 400, false)]
public void Retention_expires_only_closed_rows_at_their_window(string status, int ageDays, bool expired)
{
var s = Full();
s.Status = status;
s.SubmittedAt = Now.AddDays(-ageDays);
s.ReviewedAt = status == "declined" ? Now.AddDays(-ageDays) : null;
Assert.Equal(expired, RuleSubmissionRetention.IsExpired(s, Now));
}
[Fact]
public void Retention_of_a_declined_row_counts_from_the_decision_not_the_submission()
{
var s = Full();
s.Status = RuleSubmissionStatuses.Declined;
s.SubmittedAt = Now.AddDays(-200);
s.ReviewedAt = Now.AddDays(-10);
Assert.False(RuleSubmissionRetention.IsExpired(s, Now));
}
[Theory]
[InlineData(null, null, "PartitionKey eq 'submissions'")]
[InlineData("t'1", null, "PartitionKey eq 'submissions' and TenantId eq 't''1'")]
[InlineData(null, "pending", "PartitionKey eq 'submissions' and Status eq 'pending'")]
[InlineData("t1", "approved", "PartitionKey eq 'submissions' and TenantId eq 't1' and Status eq 'approved'")]
public void Filter_escapes_and_composes(string? tenantId, string? status, string expected)
{
Assert.Equal(expected, TableRuleSubmissionRepository.BuildFilter(tenantId, status));
}
}
@@ -184,6 +184,7 @@ public class TypedContractCompletionWireParityTests
totalInstalls = 4,
totalSkipped = 1,
totalUnmeasured = 1,
totalIncomplete = 0,
totalCollisionExcluded = 0,
slowestApps = new[]
{
@@ -195,6 +196,7 @@ public class TypedContractCompletionWireParityTests
skipped = 1,
unmeasured = 1,
failed = 1,
incomplete = 0,
failureRate = 33.3,
avgDurationSeconds = 120.0,
maxDurationSeconds = 240,
@@ -225,6 +227,7 @@ public class TypedContractCompletionWireParityTests
TotalInstalls = 4,
TotalSkipped = 1,
TotalUnmeasured = 1,
TotalIncomplete = 0,
TotalCollisionExcluded = 0,
SlowestApps = new[]
{
@@ -236,6 +239,7 @@ public class TypedContractCompletionWireParityTests
Skipped = 1,
Unmeasured = 1,
Failed = 1,
Incomplete = 0,
FailureRate = 33.3,
AvgDurationSeconds = 120.0,
MaxDurationSeconds = 240,
@@ -684,6 +688,7 @@ public class TypedContractCompletionWireParityTests
skipped = 0,
unmeasured = 0,
failed = 0,
incomplete = 0,
failureRate = 0.0,
avgDurationSeconds = 0.0,
p95DurationSeconds = 0,
@@ -715,6 +720,7 @@ public class TypedContractCompletionWireParityTests
Skipped = 0,
Unmeasured = 0,
Failed = 0,
Incomplete = 0,
FailureRate = 0.0,
AvgDurationSeconds = 0.0,
P95DurationSeconds = 0,
@@ -34,6 +34,7 @@ namespace AutopilotMonitor.Functions.DataAccess
services.AddSingleton<ISessionAnnotationRepository, TableSessionAnnotationRepository>();
services.AddSingleton<IBootstrapRepository, TableBootstrapRepository>();
services.AddSingleton<INotificationRepository, TableNotificationRepository>();
services.AddSingleton<IRuleSubmissionRepository, TableRuleSubmissionRepository>();
services.AddSingleton<ITenantNotificationRepository, TableTenantNotificationRepository>();
services.AddSingleton<ISlaTenantStatusRepository, TableSlaTenantStatusRepository>();
// What's new notifier watermark (single platform row in the AdminConfiguration table).
@@ -142,6 +142,9 @@ namespace AutopilotMonitor.Functions.DataAccess.TableStorage
public Task ResolveEspBlockingForSessionAsync(string tenantId, string sessionId)
=> _storage.ResolveEspBlockingForSessionAsync(tenantId, sessionId);
public Task<int> CloseOpenAppInstallsForSessionAsync(string tenantId, string sessionId)
=> _storage.CloseOpenAppInstallsForSessionAsync(tenantId, sessionId);
public Task<bool> SaveTimeAttributionAggregateAsync(TimeAttributionDailyAggregate aggregate)
=> _storage.SaveTimeAttributionAggregateAsync(aggregate);
@@ -0,0 +1,294 @@
using System;
using System.Collections.Generic;
using System.Text.Json;
using System.Threading.Tasks;
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Functions.Pagination;
using AutopilotMonitor.Functions.Services;
using AutopilotMonitor.Shared;
using AutopilotMonitor.Shared.DataAccess;
using AutopilotMonitor.Shared.Models;
using AutopilotMonitor.Shared.Pagination;
using Azure;
using Azure.Data.Tables;
using Microsoft.Extensions.Logging;
namespace AutopilotMonitor.Functions.DataAccess.TableStorage
{
/// <summary>
/// Table-storage implementation of <see cref="IRuleSubmissionRepository"/>.
/// PK = <see cref="PartitionKey"/> for every tenant, RK = inverted ticks + id (newest first).
/// </summary>
public class TableRuleSubmissionRepository : IRuleSubmissionRepository
{
internal const string PartitionKey = "submissions";
private readonly TableClient _tableClient;
private readonly ILogger<TableRuleSubmissionRepository> _logger;
public TableRuleSubmissionRepository(TableStorageService storage, ILogger<TableRuleSubmissionRepository> logger)
{
_tableClient = storage.GetTableClient(Constants.TableNames.RuleSubmissions);
_logger = logger;
}
public async Task<bool> AddAsync(RuleSubmission submission)
{
try
{
await _tableClient.AddEntityAsync(StoreSubmission(submission));
return true;
}
catch (Exception ex)
{
_logger.LogError(ex, "Failed to store rule submission {SubmissionId}", submission.SubmissionId);
return false;
}
}
public async Task<RuleSubmission?> GetAsync(string submissionId)
{
var entity = await FindEntityAsync(submissionId);
return entity == null ? null : MapSubmission(entity);
}
public async Task<List<RuleSubmission>> GetForTenantAsync(string tenantId)
{
var results = new List<RuleSubmission>();
try
{
await foreach (var entity in _tableClient.QueryAsync<TableEntity>(filter: BuildFilter(tenantId, status: null)))
{
results.Add(MapSubmission(entity));
}
}
catch (RequestFailedException ex) when (ex.Status == 404)
{
_logger.LogDebug("RuleSubmissions table does not exist yet, returning empty list");
}
return results;
}
public async Task<RawPage<RuleSubmission>> GetPageAsync(string? tenantId, string? status, int pageSize, string? continuation)
{
if (pageSize < 1) throw new ArgumentOutOfRangeException(nameof(pageSize));
try
{
var (entities, nextRawToken) = await AzureTablesPaginator.FetchPageAsync<TableEntity>(
client: _tableClient,
filter: BuildFilter(tenantId, status),
pageSize: pageSize,
continuation: continuation);
var page = new List<RuleSubmission>(entities.Count);
foreach (var entity in entities) page.Add(MapSubmission(entity));
// RowKey is the inverted tick of SubmittedAt — newest first by construction.
return new RawPage<RuleSubmission>(page, nextRawToken);
}
catch (RequestFailedException ex) when (ex.Status == 404)
{
_logger.LogDebug("RuleSubmissions table does not exist yet, returning empty page");
return RawPage<RuleSubmission>.Empty;
}
}
public async Task<bool> UpdateAsync(RuleSubmission submission)
{
var existing = await FindEntityAsync(submission.SubmissionId);
if (existing == null)
{
_logger.LogWarning("UpdateAsync: rule submission {SubmissionId} not found", submission.SubmissionId);
return false;
}
var entity = StoreSubmission(submission);
entity.RowKey = existing.RowKey;
entity.ETag = existing.ETag;
try
{
// If-Match on the ETag: two reviewers deciding the same submission cannot both win.
await _tableClient.UpdateEntityAsync(entity, existing.ETag, TableUpdateMode.Replace);
return true;
}
catch (RequestFailedException ex) when (ex.Status == 412)
{
_logger.LogWarning("UpdateAsync: rule submission {SubmissionId} changed underneath the reviewer", submission.SubmissionId);
return false;
}
}
public async Task<HashSet<string>> GetReservedPublishedRuleIdsAsync()
{
var ids = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
try
{
await foreach (var entity in _tableClient.QueryAsync<TableEntity>(
filter: BuildFilter(tenantId: null, status: RuleSubmissionStatuses.Approved),
select: new[] { "PublishedRuleId" }))
{
var id = entity.GetString("PublishedRuleId");
if (!string.IsNullOrEmpty(id)) ids.Add(id!);
}
}
catch (RequestFailedException ex) when (ex.Status == 404)
{
_logger.LogDebug("RuleSubmissions table does not exist yet");
}
return ids;
}
public async Task<int> DeleteExpiredAsync(DateTime nowUtc)
{
var deleted = 0;
try
{
// The expiry rule is the shared RuleSubmissionRetention, so the sweep and its
// test cannot disagree; only the two closed statuses are scanned.
foreach (var status in new[] { RuleSubmissionStatuses.Withdrawn, RuleSubmissionStatuses.Declined })
{
var expired = new List<TableEntity>();
await foreach (var entity in _tableClient.QueryAsync<TableEntity>(filter: BuildFilter(tenantId: null, status)))
{
if (RuleSubmissionRetention.IsExpired(MapSubmission(entity), nowUtc)) expired.Add(entity);
}
foreach (var entity in expired)
{
try
{
await _tableClient.DeleteEntityAsync(entity.PartitionKey, entity.RowKey);
deleted++;
}
catch (RequestFailedException ex) when (ex.Status == 404)
{
// Already gone — a parallel sweep or a tenant offboarding won the race.
}
}
}
}
catch (RequestFailedException ex) when (ex.Status == 404)
{
_logger.LogDebug("RuleSubmissions table does not exist yet");
}
return deleted;
}
public async Task<bool> DeleteAsync(string submissionId)
{
var existing = await FindEntityAsync(submissionId);
if (existing == null) return false;
try
{
await _tableClient.DeleteEntityAsync(existing.PartitionKey, existing.RowKey);
return true;
}
catch (RequestFailedException ex) when (ex.Status == 404)
{
return false;
}
}
private async Task<TableEntity?> FindEntityAsync(string submissionId)
{
try
{
await foreach (var entity in _tableClient.QueryAsync<TableEntity>(
filter: $"PartitionKey eq '{PartitionKey}' and SubmissionId eq '{Escape(submissionId)}'"))
{
return entity;
}
}
catch (RequestFailedException ex) when (ex.Status == 404)
{
_logger.LogDebug("RuleSubmissions table does not exist yet");
}
return null;
}
internal static string BuildFilter(string? tenantId, string? status)
{
var filter = $"PartitionKey eq '{PartitionKey}'";
if (!string.IsNullOrEmpty(tenantId)) filter += $" and TenantId eq '{Escape(tenantId!)}'";
if (!string.IsNullOrEmpty(status)) filter += $" and Status eq '{Escape(status!)}'";
return filter;
}
private static string Escape(string value) => value.Replace("'", "''");
// ── Store / Map ─────────────────────────────────────────────────────────
// internal static: pinned by round-trip unit tests — every property must survive
// Store→Map, so any new field lands in BOTH methods plus the test.
internal static TableEntity StoreSubmission(RuleSubmission s) =>
new(PartitionKey, $"{RowKeyCodec.InvertedTicks(s.SubmittedAt)}_{s.SubmissionId}")
{
["SubmissionId"] = s.SubmissionId,
["BatchId"] = s.BatchId,
["TenantId"] = s.TenantId,
["RuleKind"] = s.RuleKind,
["SourceRuleId"] = s.SourceRuleId,
["Title"] = s.Title,
["Category"] = s.Category,
["RuleJson"] = s.RuleJson,
["Comment"] = s.Comment ?? string.Empty,
["SubmittedBy"] = s.SubmittedBy,
["SubmittedByName"] = s.SubmittedByName,
["ContactEmail"] = s.ContactEmail ?? string.Empty,
["AttributionMode"] = s.AttributionMode,
["AttributionName"] = s.AttributionName,
["SubmittedAt"] = s.SubmittedAt,
["Status"] = s.Status,
["ValidationFindingsJson"] = JsonSerializer.Serialize(s.ValidationFindings),
["SourceFireStatsJson"] = s.SourceFireStats == null ? string.Empty : JsonSerializer.Serialize(s.SourceFireStats),
["ReviewedBy"] = s.ReviewedBy ?? string.Empty,
["ReviewedAt"] = s.ReviewedAt,
["ReviewComment"] = s.ReviewComment ?? string.Empty,
["WillBeAdapted"] = s.WillBeAdapted,
["PublishedRuleId"] = s.PublishedRuleId ?? string.Empty,
["DerivedFromTemplateRuleId"] = s.DerivedFromTemplateRuleId ?? string.Empty,
};
internal static RuleSubmission MapSubmission(TableEntity e) => new()
{
SubmissionId = e.GetString("SubmissionId") ?? string.Empty,
BatchId = e.GetString("BatchId") ?? string.Empty,
TenantId = e.GetString("TenantId") ?? string.Empty,
RuleKind = e.GetString("RuleKind") ?? string.Empty,
SourceRuleId = e.GetString("SourceRuleId") ?? string.Empty,
Title = e.GetString("Title") ?? string.Empty,
Category = e.GetString("Category") ?? string.Empty,
RuleJson = e.GetString("RuleJson") ?? string.Empty,
Comment = NullIfEmpty(e.GetString("Comment")),
SubmittedBy = e.GetString("SubmittedBy") ?? string.Empty,
SubmittedByName = e.GetString("SubmittedByName") ?? string.Empty,
ContactEmail = NullIfEmpty(e.GetString("ContactEmail")),
AttributionMode = e.GetString("AttributionMode") ?? RuleAttributionModes.Anonymous,
AttributionName = e.GetString("AttributionName") ?? RuleAttributionModes.AnonymousAuthor,
SubmittedAt = e.GetDateTimeOffset("SubmittedAt")?.UtcDateTime ?? DateTime.MinValue,
Status = e.GetString("Status") ?? RuleSubmissionStatuses.Pending,
ValidationFindings = DeserializeOrDefault<List<RuleSubmissionFinding>>(e.GetString("ValidationFindingsJson")) ?? new List<RuleSubmissionFinding>(),
SourceFireStats = DeserializeOrDefault<RuleSubmissionFireStats>(e.GetString("SourceFireStatsJson")),
ReviewedBy = NullIfEmpty(e.GetString("ReviewedBy")),
ReviewedAt = e.GetDateTimeOffset("ReviewedAt")?.UtcDateTime,
ReviewComment = NullIfEmpty(e.GetString("ReviewComment")),
WillBeAdapted = e.GetBoolean("WillBeAdapted") ?? false,
PublishedRuleId = NullIfEmpty(e.GetString("PublishedRuleId")),
DerivedFromTemplateRuleId = NullIfEmpty(e.GetString("DerivedFromTemplateRuleId")),
};
private static T? DeserializeOrDefault<T>(string? json) where T : class
{
if (string.IsNullOrEmpty(json)) return null;
try
{
return JsonSerializer.Deserialize<T>(json!);
}
catch (JsonException)
{
// A corrupt column must not hide the submission itself.
return null;
}
}
private static string? NullIfEmpty(string? value) => string.IsNullOrEmpty(value) ? null : value;
}
}
@@ -101,6 +101,13 @@ namespace AutopilotMonitor.Functions.DataAccess.TableStorage
// complete. Positive evidence only (listed ⇒ EspBlocking=true, absent ⇒ stays
// unknown). Idempotent + fail-soft like the counter reconcile above.
await _storage.ResolveEspBlockingForSessionAsync(tenantId, sessionId);
// Observation end: app rows still InProgress on a terminal session never get a
// terminal event — close them as Incomplete (outcome unknown, not a failure).
// Early for the ingest path (verdict batch, the agent may still be watching),
// never wrong in the end state: a real terminal arriving later still wins via
// the sticky-status reconcile, and the shutdown batch re-runs the close for rows
// opened after the verdict. Idempotent + fail-soft.
await _storage.CloseOpenAppInstallsForSessionAsync(tenantId, sessionId);
// F1 PR2: compute + persist the time-attribution breakdown once, now that the
// terminal write stamped CompletedAt/DurationSeconds and the event stream is
@@ -291,6 +291,7 @@ namespace AutopilotMonitor.Functions.Functions.Apps
var measured = installed.Where(MetricsMath.HasMeasuredDuration).ToList();
var succeeded = installed.Count;
var failed = summaries.Count(s => s.Status == "Failed");
var incomplete = summaries.Count(s => s.Status == "Incomplete");
var failureRate = MetricsMath.TerminalFailureRatePct(failed, succeeded);
var avgDurationSeconds = measured.Count > 0 ? Math.Round(measured.Average(s => s.DurationSeconds), 0) : 0;
var p95DurationSeconds = Percentile(measured.Select(s => s.DurationSeconds).ToList(), 0.95);
@@ -423,6 +424,7 @@ namespace AutopilotMonitor.Functions.Functions.Apps
Skipped = skipped,
Unmeasured = installed.Count - measured.Count,
Failed = failed,
Incomplete = incomplete,
FailureRate = failureRate,
AvgDurationSeconds = avgDurationSeconds,
P95DurationSeconds = p95DurationSeconds,
@@ -13,7 +13,7 @@ namespace AutopilotMonitor.Functions.Functions.Config
{
/// <summary>
/// Returns the latest published agent + bootstrap script versions.
/// Cached in-memory for 12h; supports <c>?refresh=true</c> to bypass the cache.
/// Cached in-memory for a few minutes; supports <c>?refresh=true</c> to bypass the cache.
/// Authenticated users only (read-only metadata).
/// </summary>
public class GetLatestVersionsFunction
@@ -44,15 +44,18 @@ namespace AutopilotMonitor.Functions.Functions.Config
var response = req.CreateResponse(HttpStatusCode.OK);
// Force-refresh responses MUST NOT be browser-cached.
// Normal cached responses may be stored for up to 1h (aligns with 12h backend cache).
// Force-refresh responses MUST NOT be browser-cached. Normal responses are
// held for a minute only: the portal announces this number as "Latest agent
// version" right after a release, and a browser cache measured in hours would
// keep showing the previous release long after the backend refreshed. The
// payload is a few dozen bytes, so revalidating often is free.
if (forceRefresh)
{
response.Headers.Add("Cache-Control", "no-store");
}
else
{
response.Headers.Add("Cache-Control", "public, max-age=3600");
response.Headers.Add("Cache-Control", "public, max-age=60");
}
await response.WriteAsJsonAsync(new GetLatestVersionsResponse
@@ -55,6 +55,10 @@ namespace AutopilotMonitor.Functions.Functions.Rules
return await req.BadRequestAsync("Invalid rule data");
}
// Author is stamped from the creator's token, never from the payload
// (anti-spoof), and stays immutable through every later update.
rule.Author = TenantHelper.GetUserDisplayName(req) ?? "Autopilot Monitor";
try
{
var success = await _ruleService.CreateRuleAsync(tenantId, rule);
@@ -88,6 +92,11 @@ namespace AutopilotMonitor.Functions.Functions.Rules
rule.RuleId = ruleId;
// Same anti-spoof stamp as CreateRule: on a true update the service replaces
// this with the original author (immutable attribution), but a full-payload PUT
// that upserts a rule with no existing row must not store the payload's author.
rule.Author = TenantHelper.GetUserDisplayName(req) ?? "Autopilot Monitor";
try
{
var success = await _ruleService.UpdateRuleAsync(tenantId, rule);
@@ -124,7 +133,8 @@ namespace AutopilotMonitor.Functions.Functions.Rules
try
{
var newRule = await _ruleService.CreateFromTemplateAsync(tenantId, ruleId, variables);
var author = TenantHelper.GetUserDisplayName(req) ?? "Autopilot Monitor";
var newRule = await _ruleService.CreateFromTemplateAsync(tenantId, ruleId, variables, author);
var response = req.CreateResponse(HttpStatusCode.Created);
await response.WriteAsJsonAsync(new CreateAnalyzeRuleFromTemplateResponse { Success = true, Rule = newRule, Message = "Custom rule created from template" });
@@ -0,0 +1,52 @@
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Functions.Services;
using AutopilotMonitor.Shared.Models;
using Microsoft.Azure.Functions.Worker;
using Microsoft.Azure.Functions.Worker.Http;
using Microsoft.Extensions.Logging;
namespace AutopilotMonitor.Functions.Functions.Rules.Submissions
{
/// <summary>
/// Operator hard delete of a submission (test/demo rows, or a tenant's request). The row
/// vanishes from both lists; a published rule in the repo is untouched.
/// </summary>
public class DeleteGlobalRuleSubmissionFunction
{
private readonly ILogger<DeleteGlobalRuleSubmissionFunction> _logger;
private readonly RuleSubmissionService _service;
public DeleteGlobalRuleSubmissionFunction(ILogger<DeleteGlobalRuleSubmissionFunction> logger, RuleSubmissionService service)
{
_logger = logger;
_service = service;
}
[Function("DeleteGlobalRuleSubmission")]
public async Task<HttpResponseData> Run(
[HttpTrigger(AuthorizationLevel.Anonymous, "delete", Route = "global/rule-submissions/{submissionId}")] HttpRequestData req,
string submissionId)
{
try
{
// Authentication + GlobalAdminOnly authorization enforced by PolicyEnforcementMiddleware
var user = TenantHelper.GetUserIdentifier(req);
if (string.IsNullOrWhiteSpace(submissionId)) return await req.BadRequestAsync("submissionId is required.");
var existing = await _service.GetAsync(submissionId);
if (existing == null) return await req.NotFoundAsync("Submission not found.");
if (!await _service.DeleteAsync(submissionId)) return await req.NotFoundAsync("Submission not found.");
// Warning on purpose: an operator delete is rare and must be visible in App Insights.
_logger.LogWarning("Rule submission {SubmissionId} ({RuleId}, tenant {TenantId}, status {Status}) deleted by {User}",
submissionId, existing.SourceRuleId, existing.TenantId, existing.Status, user);
return await req.OkAsync(new SuccessMessageResponse { Success = true, Message = "Submission deleted." });
}
catch (Exception ex)
{
return await req.InternalServerErrorAsync(_logger, ex, "DeleteGlobalRuleSubmission");
}
}
}
}
@@ -0,0 +1,41 @@
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Functions.Services;
using Microsoft.Azure.Functions.Worker;
using Microsoft.Azure.Functions.Worker.Http;
using Microsoft.Extensions.Logging;
namespace AutopilotMonitor.Functions.Functions.Rules.Submissions
{
/// <summary>One submission with the frozen rule, live fire stats, the suggested id and the repo file.</summary>
public class GetGlobalRuleSubmissionFunction
{
private readonly ILogger<GetGlobalRuleSubmissionFunction> _logger;
private readonly RuleSubmissionService _service;
public GetGlobalRuleSubmissionFunction(ILogger<GetGlobalRuleSubmissionFunction> logger, RuleSubmissionService service)
{
_logger = logger;
_service = service;
}
[Function("GetGlobalRuleSubmission")]
public async Task<HttpResponseData> Run(
[HttpTrigger(AuthorizationLevel.Anonymous, "get", Route = "global/rule-submissions/{submissionId}")] HttpRequestData req,
string submissionId)
{
try
{
// Authentication + GlobalReadOrAdmin authorization enforced by PolicyEnforcementMiddleware
if (string.IsNullOrWhiteSpace(submissionId)) return await req.BadRequestAsync("submissionId is required.");
var detail = await _service.GetDetailAsync(submissionId);
if (detail == null) return await req.NotFoundAsync("Submission not found.");
return await req.OkAsync(detail);
}
catch (Exception ex)
{
return await req.InternalServerErrorAsync(_logger, ex, "GetGlobalRuleSubmission");
}
}
}
}
@@ -0,0 +1,77 @@
using System.Web;
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Functions.Pagination;
using AutopilotMonitor.Functions.Services;
using AutopilotMonitor.Shared.Models;
using AutopilotMonitor.Shared.Pagination;
using Microsoft.Azure.Functions.Worker;
using Microsoft.Azure.Functions.Worker.Http;
using Microsoft.Extensions.Logging;
namespace AutopilotMonitor.Functions.Functions.Rules.Submissions
{
/// <summary>Operator list across tenants: <c>?tenantId=</c> and <c>?status=</c> are server-side filters, paging as for session reports.</summary>
public class GetGlobalRuleSubmissionsFunction
{
private readonly ILogger<GetGlobalRuleSubmissionsFunction> _logger;
private readonly RuleSubmissionService _service;
public GetGlobalRuleSubmissionsFunction(ILogger<GetGlobalRuleSubmissionsFunction> logger, RuleSubmissionService service)
{
_logger = logger;
_service = service;
}
[Function("GetGlobalRuleSubmissions")]
public async Task<HttpResponseData> Run(
[HttpTrigger(AuthorizationLevel.Anonymous, "get", Route = "global/rule-submissions")] HttpRequestData req)
{
try
{
// Authentication + GlobalReadOrAdmin authorization enforced by PolicyEnforcementMiddleware
var callerTenantId = TenantHelper.GetTenantId(req);
var query = HttpUtility.ParseQueryString(req.Url.Query ?? string.Empty);
var parsed = RuleSubmissionsPagination.ParseQuery(query);
if (parsed.Error != null) return await req.BadRequestAsync(parsed.Error);
var pageSize = parsed.PageSize ?? RuleSubmissionsPagination.DefaultPageSize;
string? azureToken = null;
if (parsed.Continuation != null)
{
if (!RuleSubmissionsPagination.TryAcceptContinuation(
parsed.Continuation, callerTenantId, parsed.FilterTenantId, parsed.FilterStatus,
out azureToken, out var rejectReason))
{
_logger.LogWarning("GetGlobalRuleSubmissions: continuation rejected ({Reason})", rejectReason);
return await req.BadRequestAsync($"Invalid continuation token ({rejectReason}). Restart pagination from the first page.");
}
}
var page = await _service.GetPageAsync(parsed.FilterTenantId, parsed.FilterStatus, pageSize, azureToken);
var items = await _service.ToItemsAsync(page.Items);
string? nextLink = null;
if (!string.IsNullOrEmpty(page.NextRawToken))
{
var fp = RuleSubmissionsPagination.Fingerprint(callerTenantId, parsed.FilterTenantId, parsed.FilterStatus);
var wireToken = ContinuationToken.Encode(page.NextRawToken!, callerTenantId, fp);
nextLink = RuleSubmissionsPagination.BuildNextLink(pageSize, wireToken, parsed.FilterTenantId, parsed.FilterStatus);
}
return await req.OkAsync(new RuleSubmissionListResponse
{
Success = true,
Count = items.Count,
Submissions = items,
NextLink = nextLink,
});
}
catch (Exception ex)
{
return await req.InternalServerErrorAsync(_logger, ex, "GetGlobalRuleSubmissions");
}
}
}
}
@@ -0,0 +1,41 @@
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Functions.Services;
using AutopilotMonitor.Shared.Models;
using Microsoft.Azure.Functions.Worker;
using Microsoft.Azure.Functions.Worker.Http;
using Microsoft.Extensions.Logging;
namespace AutopilotMonitor.Functions.Functions.Rules.Submissions
{
/// <summary>The submitting tenant's own submissions, newest first, with the effective status.</summary>
public class GetRuleSubmissionsFunction
{
private readonly ILogger<GetRuleSubmissionsFunction> _logger;
private readonly RuleSubmissionService _service;
public GetRuleSubmissionsFunction(ILogger<GetRuleSubmissionsFunction> logger, RuleSubmissionService service)
{
_logger = logger;
_service = service;
}
[Function("GetRuleSubmissions")]
public async Task<HttpResponseData> Run(
[HttpTrigger(AuthorizationLevel.Anonymous, "get", Route = "rules/submissions")] HttpRequestData req)
{
try
{
// Authentication + TenantAdminOrGA authorization enforced by PolicyEnforcementMiddleware.
// Always the JWT tenant — a GA reads foreign tenants through global/rule-submissions?tenantId=.
var tenantId = req.GetRequestContext().TenantId;
var rows = await _service.GetForTenantAsync(tenantId);
var items = await _service.ToItemsAsync(rows);
return await req.OkAsync(new RuleSubmissionListResponse { Success = true, Count = items.Count, Submissions = items });
}
catch (Exception ex)
{
return await req.InternalServerErrorAsync(_logger, ex, "GetRuleSubmissions");
}
}
}
}
@@ -0,0 +1,92 @@
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Functions.Services;
using AutopilotMonitor.Shared.Models;
using Microsoft.Azure.Functions.Worker;
using Microsoft.Azure.Functions.Worker.Http;
using Microsoft.Extensions.Logging;
namespace AutopilotMonitor.Functions.Functions.Rules.Submissions
{
/// <summary>The reviewer's decision (portal or MCP). The submitter is told through a tenant notification.</summary>
public class ReviewRuleSubmissionFunction
{
private readonly ILogger<ReviewRuleSubmissionFunction> _logger;
private readonly RuleSubmissionService _service;
private readonly TenantNotificationService _tenantNotifications;
public ReviewRuleSubmissionFunction(
ILogger<ReviewRuleSubmissionFunction> logger,
RuleSubmissionService service,
TenantNotificationService tenantNotifications)
{
_logger = logger;
_service = service;
_tenantNotifications = tenantNotifications;
}
[Function("ReviewRuleSubmission")]
public async Task<HttpResponseData> Run(
[HttpTrigger(AuthorizationLevel.Anonymous, "patch", Route = "global/rule-submissions/{submissionId}")] HttpRequestData req,
string submissionId)
{
try
{
// Authentication + GlobalAdminOnly authorization enforced by PolicyEnforcementMiddleware
var reviewer = TenantHelper.GetUserIdentifier(req);
if (string.IsNullOrWhiteSpace(submissionId)) return await req.BadRequestAsync("submissionId is required.");
var read = await req.ReadAsync<ReviewRuleSubmissionRequest>();
if (read.Error != null) return read.Error;
RuleSubmission updated;
try
{
updated = await _service.ReviewAsync(submissionId, read.Value!, reviewer);
}
catch (KeyNotFoundException ex)
{
return await req.NotFoundAsync(ex.Message);
}
catch (ArgumentException ex)
{
return await req.BadRequestAsync(ex.Message);
}
catch (InvalidOperationException ex)
{
return await req.ConflictAsync(ex.Message);
}
var approved = updated.Status == RuleSubmissionStatuses.Approved;
var title = approved
? $"Rule submission approved: {updated.SourceRuleId}"
: $"Rule submission declined: {updated.SourceRuleId}";
var message = approved
? (updated.WillBeAdapted
? $"\"{updated.Title}\" will be published as {updated.PublishedRuleId} after a small adaptation for the community."
: $"\"{updated.Title}\" will be published as {updated.PublishedRuleId}.")
: $"\"{updated.Title}\" was not accepted for the community pool.";
if (!string.IsNullOrEmpty(updated.ReviewComment)) message += $" Reviewer: {updated.ReviewComment}";
// Best effort; the submissions list carries the same facts.
_ = _tenantNotifications.CreateNotificationAsync(
updated.TenantId, "rule_submission_decided", title, message,
href: updated.RuleKind == RuleSubmissionKinds.Analyze ? "/analyze-rules" : "/gather-rules");
_logger.LogInformation("Rule submission {SubmissionId} {Status} by {Reviewer} (published id {PublishedRuleId})",
submissionId, updated.Status, reviewer, updated.PublishedRuleId ?? "-");
var item = (await _service.ToItemsAsync(new[] { updated }))[0];
return await req.OkAsync(new ReviewRuleSubmissionResponse
{
Success = true,
Message = approved ? "Submission approved." : "Submission declined.",
Submission = item,
});
}
catch (Exception ex)
{
return await req.InternalServerErrorAsync(_logger, ex, "ReviewRuleSubmission");
}
}
}
}
@@ -0,0 +1,137 @@
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Functions.Security;
using AutopilotMonitor.Functions.Services;
using AutopilotMonitor.Shared.DataAccess;
using AutopilotMonitor.Shared.Models;
using Microsoft.Azure.Functions.Worker;
using Microsoft.Azure.Functions.Worker.Http;
using Microsoft.Extensions.Logging;
namespace AutopilotMonitor.Functions.Functions.Rules.Submissions
{
/// <summary>
/// A tenant admin submits one or more of the tenant's custom rules for the community pool.
/// The body carries only rule references; the service freezes the rules server-side.
/// </summary>
public class SubmitRuleSubmissionsFunction
{
private readonly ILogger<SubmitRuleSubmissionsFunction> _logger;
private readonly RuleSubmissionService _service;
private readonly IMaintenanceRepository _maintenanceRepo;
private readonly TelegramNotificationService _telegram;
private readonly GlobalNotificationService _globalNotifications;
public SubmitRuleSubmissionsFunction(
ILogger<SubmitRuleSubmissionsFunction> logger,
RuleSubmissionService service,
IMaintenanceRepository maintenanceRepo,
TelegramNotificationService telegram,
GlobalNotificationService globalNotifications)
{
_logger = logger;
_service = service;
_maintenanceRepo = maintenanceRepo;
_telegram = telegram;
_globalNotifications = globalNotifications;
}
[Function("SubmitRuleSubmissions")]
public async Task<HttpResponseData> Run(
[HttpTrigger(AuthorizationLevel.Anonymous, "post", Route = "rules/submissions")] HttpRequestData req)
{
try
{
// Authentication + TenantAdminOrGA authorization enforced by PolicyEnforcementMiddleware
var requestCtx = req.GetRequestContext();
var tenantId = requestCtx.TenantId;
var userIdentifier = requestCtx.UserPrincipalName;
var read = await req.ReadAsync<SubmitRuleSubmissionsRequest>(262_144);
if (read.Error != null) return read.Error;
var request = read.Value!;
// Same tenant-tamper gate as the session report: non-GAs submit for their JWT
// tenant only; a GA may submit on behalf of a foreign tenant and must name it.
if (!requestCtx.IsGlobalAdmin)
{
if (!string.IsNullOrEmpty(request.TenantId)
&& !string.Equals(request.TenantId, tenantId, StringComparison.OrdinalIgnoreCase))
{
_logger.LogWarning(
"SubmitRuleSubmissions: BLOCKED cross-tenant body for non-GA user={User} jwtTenant={JwtTenant} bodyTenant={BodyTenant}",
userIdentifier, tenantId, request.TenantId);
return await req.ForbiddenAsync("Body tenantId must match your authenticated tenant.");
}
request.TenantId = tenantId;
}
else if (string.IsNullOrEmpty(request.TenantId))
{
return await req.BadRequestAsync("tenantId is required in body for Global Admin submissions.");
}
if (!SecurityValidator.IsValidGuid(request.TenantId))
return await req.BadRequestAsync("Invalid tenantId.");
var displayName = TenantHelper.GetUserDisplayName(req) ?? userIdentifier;
List<RuleSubmission> created;
try
{
created = await _service.SubmitAsync(request.TenantId, request, userIdentifier, displayName);
}
catch (ArgumentException ex)
{
return await req.BadRequestAsync(ex.Message);
}
catch (InvalidOperationException ex)
{
return await req.ConflictAsync(ex.Message);
}
if (!requestCtx.IsGlobalAdmin)
{
foreach (var s in created)
{
await _maintenanceRepo.LogAuditEntryAsync(
request.TenantId, "CREATE", "RuleSubmission", s.SubmissionId, userIdentifier,
new Dictionary<string, string>
{
{ "Action", "SubmitRuleSubmission" },
{ "RuleKind", s.RuleKind },
{ "RuleId", s.SourceRuleId },
{ "BatchId", s.BatchId },
{ "AttributionMode", s.AttributionMode },
{ "HasComment", (s.Comment != null).ToString() },
});
}
}
// Operator notifications — best effort, one per rule so every id has its own deep link.
foreach (var s in created)
{
_ = _telegram.SendRuleSubmissionAsync(s.SubmissionId, request.TenantId, userIdentifier, s.RuleKind, s.SourceRuleId, s.Title, s.Comment ?? string.Empty);
_ = _globalNotifications.CreateNotificationAsync(
"rule_submission",
$"Rule submission {s.SubmissionId}",
$"{s.SourceRuleId} \"{s.Title}\" ({s.RuleKind}) — {userIdentifier} (Tenant: {request.TenantId})",
href: $"/admin/reports/rule-submissions?submissionId={Uri.EscapeDataString(s.SubmissionId)}");
}
_logger.LogInformation("Rule submissions stored: {Count} rule(s), batch {BatchId}, tenant {TenantId}, by {User}",
created.Count, created[0].BatchId, request.TenantId, userIdentifier);
var items = await _service.ToItemsAsync(created);
return await req.OkAsync(new SubmitRuleSubmissionsResponse
{
Success = true,
Message = created.Count == 1 ? "Rule submitted for review." : $"{created.Count} rules submitted for review.",
BatchId = created[0].BatchId,
Submissions = items,
});
}
catch (Exception ex)
{
return await req.InternalServerErrorAsync(_logger, ex, "SubmitRuleSubmissions");
}
}
}
}
@@ -0,0 +1,55 @@
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Functions.Services;
using AutopilotMonitor.Shared.Models;
using Microsoft.Azure.Functions.Worker;
using Microsoft.Azure.Functions.Worker.Http;
using Microsoft.Extensions.Logging;
namespace AutopilotMonitor.Functions.Functions.Rules.Submissions
{
/// <summary>The submitter takes a pending submission back. The row stays (status withdrawn) for the audit trail.</summary>
public class WithdrawRuleSubmissionFunction
{
private readonly ILogger<WithdrawRuleSubmissionFunction> _logger;
private readonly RuleSubmissionService _service;
public WithdrawRuleSubmissionFunction(ILogger<WithdrawRuleSubmissionFunction> logger, RuleSubmissionService service)
{
_logger = logger;
_service = service;
}
[Function("WithdrawRuleSubmission")]
public async Task<HttpResponseData> Run(
[HttpTrigger(AuthorizationLevel.Anonymous, "delete", Route = "rules/submissions/{submissionId}")] HttpRequestData req,
string submissionId)
{
try
{
// Authentication + TenantAdminOrGA authorization enforced by PolicyEnforcementMiddleware
var requestCtx = req.GetRequestContext();
if (string.IsNullOrWhiteSpace(submissionId)) return await req.BadRequestAsync("submissionId is required.");
bool withdrawn;
try
{
// A foreign tenant's submission answers 404 for a non-GA — the row's existence is not theirs to learn.
withdrawn = await _service.WithdrawAsync(requestCtx.TenantId, submissionId, crossTenantAllowed: requestCtx.IsGlobalAdmin);
}
catch (InvalidOperationException ex)
{
return await req.ConflictAsync(ex.Message);
}
if (!withdrawn) return await req.NotFoundAsync("Submission not found.");
_logger.LogInformation("Rule submission {SubmissionId} withdrawn by {User}", submissionId, requestCtx.UserPrincipalName);
return await req.OkAsync(new SuccessMessageResponse { Success = true, Message = "Submission withdrawn." });
}
catch (Exception ex)
{
return await req.InternalServerErrorAsync(_logger, ex, "WithdrawRuleSubmission");
}
}
}
}
@@ -10,8 +10,8 @@ public static class MetricsMath
/// <summary>
/// App-install failure rate over finished installs only: Failed / (Failed + Succeeded), one
/// decimal, 0 when nothing finished. The same outcome-quota convention as the enrollment
/// success rate — "InProgress" rows (still installing, or orphaned by a session that died
/// mid-install) never dilute the rate. Shared by the app-metrics payload and the Apps
/// success rate — "InProgress" rows (still installing) and "Incomplete" rows (observation
/// ended before any outcome) never dilute the rate. Shared by the app-metrics payload and the Apps
/// dashboard aggregations so the definition can't drift between panes.
/// </summary>
public static double TerminalFailureRatePct(int failed, int succeeded)
@@ -94,6 +94,8 @@ public static class MetricsMath
var installed = succeededAll.Where(s => !IsSkipTerminalState(s)).ToList();
var measured = installed.Where(HasMeasuredDuration).ToList();
var failed = g.Where(s => s.Status == "Failed").ToList();
// Observation ended before any outcome — disclosed, outside the rate and the durations.
var incomplete = g.Count(s => s.Status == "Incomplete");
var total = g.Count();
// DoAggregator is the single source for the DO rollup: it filters rows that actually
@@ -109,6 +111,7 @@ public static class MetricsMath
Skipped = skipped.Count,
Unmeasured = installed.Count - measured.Count,
Failed = failed.Count,
Incomplete = incomplete,
// Skips leave the rate (they are not attempts); legacy rows stay in it.
FailureRate = TerminalFailureRatePct(failed.Count, installed.Count),
AvgDurationSeconds = measured.Count > 0 ? Math.Round(measured.Average(s => s.DurationSeconds), 0) : 0,
@@ -151,6 +154,7 @@ public static class MetricsMath
TotalInstalls = summaryList.Count,
TotalSkipped = appGroups.Sum(a => a.Skipped),
TotalUnmeasured = appGroups.Sum(a => a.Unmeasured),
TotalIncomplete = appGroups.Sum(a => a.Incomplete),
TotalCollisionExcluded = totalCollisionExcluded,
SlowestApps = slowestApps,
TopFailingApps = topFailingApps,
@@ -0,0 +1,92 @@
using System.Collections.Generic;
using System.Collections.Specialized;
using System.Globalization;
using System.Text;
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Shared.Pagination;
namespace AutopilotMonitor.Functions.Pagination
{
/// <summary>
/// Pure helpers for the <c>GET /api/global/rule-submissions</c> pagination surface — the
/// SessionReportsPagination contract with a second server-side filter (<c>status</c>). Both
/// filters are bound into the continuation fingerprint so a token issued for one view cannot
/// resume another.
/// </summary>
public static class RuleSubmissionsPagination
{
public const int DefaultPageSize = 200;
public static string Fingerprint(string callerTenantId, string? filterTenantId, string? filterStatus) =>
ContinuationToken.ComputeFingerprint(new[]
{
new KeyValuePair<string, string?>("scope", "rule-submissions"),
new KeyValuePair<string, string?>("tenantId", callerTenantId),
new KeyValuePair<string, string?>("filterTenantId", filterTenantId),
new KeyValuePair<string, string?>("filterStatus", filterStatus),
});
public sealed class Parsed
{
public string? FilterTenantId { get; init; }
public string? FilterStatus { get; init; }
public int? PageSize { get; init; }
public string? Continuation { get; init; }
public string? Error { get; init; }
}
public static Parsed ParseQuery(NameValueCollection? query)
{
var filterTenantIdRaw = query?["tenantId"];
var filterStatusRaw = query?["status"];
var pageSizeRaw = query?["pageSize"];
var continuationRaw = query?["continuation"];
if (!QueryParams.TryPageSize(pageSizeRaw, out var pageSize, out var pageSizeError))
return new Parsed { Error = pageSizeError };
if (!string.IsNullOrEmpty(filterStatusRaw)
&& System.Array.IndexOf(Shared.Models.RuleSubmissionStatuses.Stored, filterStatusRaw) < 0)
{
return new Parsed { Error = $"status must be one of: {string.Join(", ", Shared.Models.RuleSubmissionStatuses.Stored)}" };
}
var continuation = pageSize.HasValue && !string.IsNullOrEmpty(continuationRaw)
? continuationRaw
: null;
return new Parsed
{
FilterTenantId = string.IsNullOrEmpty(filterTenantIdRaw) ? null : filterTenantIdRaw,
FilterStatus = string.IsNullOrEmpty(filterStatusRaw) ? null : filterStatusRaw,
PageSize = pageSize,
Continuation = continuation,
};
}
public static bool TryAcceptContinuation(
string raw,
string callerTenantId,
string? filterTenantId,
string? filterStatus,
out string azureToken,
out string? rejectReason)
{
var fp = Fingerprint(callerTenantId, filterTenantId, filterStatus);
return ContinuationToken.TryDecode(raw, callerTenantId, fp, out azureToken, out rejectReason);
}
public static string BuildNextLink(int pageSize, string wireContinuation, string? filterTenantId, string? filterStatus)
{
var sb = new StringBuilder("/api/global/rule-submissions");
sb.Append('?');
sb.Append("pageSize=").Append(pageSize.ToString(CultureInfo.InvariantCulture));
sb.Append("&continuation=").Append(System.Uri.EscapeDataString(wireContinuation));
if (!string.IsNullOrEmpty(filterTenantId))
sb.Append("&tenantId=").Append(System.Uri.EscapeDataString(filterTenantId!));
if (!string.IsNullOrEmpty(filterStatus))
sb.Append("&status=").Append(System.Uri.EscapeDataString(filterStatus!));
return sb.ToString();
}
}
}
@@ -318,6 +318,7 @@ builder.Services.AddSingleton<AutopilotMonitor.Functions.Services.Diagnostics.Di
builder.Services.AddSingleton<AutopilotMonitor.Functions.Services.Diagnostics.DiagnosticsBlobCascadeDeleter>();
builder.Services.AddSingleton<AutopilotMonitor.Functions.Services.Diagnostics.SessionReportDiagnosticsArchiveCopier>();
builder.Services.AddSingleton<SessionReportService>();
builder.Services.AddSingleton<RuleSubmissionService>();
builder.Services.AddSingleton<BootstrapSessionService>();
// Queue producers + handlers. Consumers are [QueueTrigger] functions under Functions/Queue/
@@ -354,6 +354,11 @@ public static class EndpointAccessPolicyCatalog
// troubleshooting action, not a config change — a support-driven Operator may use it.
// Viewer and the read-only Global Reader stay excluded (the tier admits no Viewer/Reader).
new("POST", "diagnostics/files", EndpointPolicy.TenantAdminOrOperator),
// Community rule submissions: the tenant admin submits references to own custom rules
// (frozen server-side), lists and withdraws them for the JWT tenant only.
new("POST", "rules/submissions", EndpointPolicy.TenantAdminOrGA),
new("GET", "rules/submissions", EndpointPolicy.TenantAdminOrGA),
new("DELETE", "rules/submissions/{submissionId}", EndpointPolicy.TenantAdminOrGA),
new("DELETE", "sessions/{sessionId}", EndpointPolicy.TenantAdminOrGA, TenantScoping.QueryParam),
new("GET", "tenants/{tenantId}/admins", EndpointPolicy.TenantAdminOrGA, TenantScoping.RouteParam),
new("POST", "tenants/{tenantId}/admins", EndpointPolicy.TenantAdminOrGA, TenantScoping.RouteParam),
@@ -513,6 +518,11 @@ public static class EndpointAccessPolicyCatalog
new("POST", "global/session-reports/download-ticket", EndpointPolicy.GlobalReadOrAdmin),
new("GET", "global/session-reports/download-url", EndpointPolicy.GlobalReadOrAdmin),
new("PATCH", "global/session-reports/{reportId}/note", EndpointPolicy.GlobalAdminOnly),
// Community rule submissions, operator side: cross-tenant read (Global Reader included), decision GA-only.
new("GET", "global/rule-submissions", EndpointPolicy.GlobalReadOrAdmin, TenantScoping.QueryParam),
new("GET", "global/rule-submissions/{submissionId}", EndpointPolicy.GlobalReadOrAdmin),
new("PATCH", "global/rule-submissions/{submissionId}", EndpointPolicy.GlobalAdminOnly),
new("DELETE", "global/rule-submissions/{submissionId}", EndpointPolicy.GlobalAdminOnly),
// Flywheel evaluation stream: all annotation lanes across tenants (verdict/rule filters).
new("GET", "global/session-annotations", EndpointPolicy.GlobalReadOrAdmin, TenantScoping.QueryParam),
new("GET", "global/rules/gather", EndpointPolicy.GlobalReadOrAdmin, TenantScoping.QueryParam),
@@ -322,6 +322,16 @@ namespace AutopilotMonitor.Functions.Services
rule.Notify = null;
}
var existing = (await _ruleRepo.GetAnalyzeRulesAsync(tenantId))
.FirstOrDefault(r => r.RuleId == rule.RuleId && !r.IsBuiltIn && !r.IsCommunity);
if (existing != null)
{
rule.CreatedAt = existing.CreatedAt;
// Author is stamped from the creator's token at create time and is
// immutable afterwards — updates (incl. cross-tenant GA edits) keep it.
rule.Author = existing.Author;
}
rule.UpdatedAt = DateTime.UtcNow;
return await _ruleRepo.StoreAnalyzeRuleAsync(rule, tenantId);
}
@@ -333,7 +343,8 @@ namespace AutopilotMonitor.Functions.Services
public async Task<AnalyzeRule> CreateFromTemplateAsync(
string tenantId,
string templateRuleId,
Dictionary<string, string> variableValues)
Dictionary<string, string> variableValues,
string? author = null)
{
var allRules = await GetAllRulesForTenantAsync(tenantId);
var template = allRules.FirstOrDefault(r => r.RuleId == templateRuleId);
@@ -370,6 +381,8 @@ namespace AutopilotMonitor.Functions.Services
customRule.RuleId = $"{templateRuleId}-CUSTOM";
customRule.IsBuiltIn = false;
customRule.IsCommunity = false;
// The copy is the tenant's rule, not the template author's.
customRule.Author = string.IsNullOrWhiteSpace(author) ? "Autopilot Monitor" : author!;
customRule.Enabled = true;
customRule.DerivedFromTemplateRuleId = templateRuleId;
customRule.TemplateVariables = new List<TemplateVariable>();
@@ -92,6 +92,9 @@ namespace AutopilotMonitor.Functions.Services
classification.HasCompletionEvidenceCandidate = true;
break;
case "agent_shutting_down":
// Every shutdown ends this agent run's observation; the max-lifetime
// flavour additionally carries the verdict mapping below.
classification.AgentShutdownEvent = evt;
if (IsMaxLifetimeAgentShutdown(evt))
classification.AgentMaxLifetimeShutdownEvent = evt;
break;
@@ -705,6 +708,14 @@ namespace AutopilotMonitor.Functions.Services
public EnrollmentEvent? EspFailureEvent { get; set; }
public EnrollmentEvent? SessionStalledEvent { get; set; }
/// <summary>
/// Any <c>agent_shutting_down</c> in the batch — the agent's last word for this run.
/// After the status write, a terminal session closes its still-open app rows on this
/// batch: apps that started after the verdict (the agent keeps watching after
/// enrollment_complete) got their row only after the terminal seam had already run.
/// </summary>
public EnrollmentEvent? AgentShutdownEvent { get; set; }
/// <summary>
/// <c>agent_shutting_down</c> with <c>Data.reason == "max_lifetime"</c> — the V2
/// watchdog shutdown that deliberately carries no enrollment verdict. Mapped to a
@@ -276,6 +276,21 @@ namespace AutopilotMonitor.Functions.Services
updatedSession?.AgentVersion, skewScan);
}
// Observation end: the batch carrying agent_shutting_down is the agent's last word.
// On a terminal session an app row still InProgress now will never get a terminal
// event — close it as Incomplete. The terminal seam already did this on the verdict
// batch; this re-run catches rows opened after the verdict (the IME keeps installing
// and the agent keeps watching after enrollment_complete). Non-terminal sessions
// (reboot shutdown, WhiteGlove part 1) keep their rows open. Idempotent + fail-soft.
if (classification.AgentShutdownEvent != null
&& updatedSession != null
&& (updatedSession.Status == SessionStatus.Succeeded
|| updatedSession.Status == SessionStatus.Failed
|| updatedSession.Status == SessionStatus.Incomplete))
{
await _metricsRepo.CloseOpenAppInstallsForSessionAsync(request.TenantId, request.SessionId);
}
// Auto-analyze fan-out: enqueue a queue message instead of running fire-and-forget
// Task.Run inside the function. The previous in-function approach could be killed
// mid-flight by Functions scale-in (HTTP 200 returned → worker unloaded → rules
@@ -11,8 +11,14 @@ namespace AutopilotMonitor.Functions.Services
{
/// <summary>
/// Exposes the latest published agent/bootstrap versions as read from the
/// public <c>version.json</c> blob. Caches the result in memory for 12h
/// (short TTL on transient failures). Admin endpoint can force-refresh.
/// public <c>version.json</c> blob. The TTL is deliberately short: this number is
/// what the portal announces right after a release ("Latest agent version" in the
/// What's new panel), so a long cache shows the previous release for hours — and
/// because the cache is per Function instance, different instances would announce
/// different versions at the same time. The origin is a 200-byte no-cache blob
/// behind the download alias, so refetching it every few minutes costs nothing.
/// On a fetch failure the last known good value is kept rather than blanking the
/// display. Admin endpoint can force-refresh.
/// </summary>
public interface ILatestVersionsService
{
@@ -33,13 +39,19 @@ namespace AutopilotMonitor.Functions.Services
// it could silently serve a stale version while the release pipeline is green.
public const string VersionJsonUrl = Constants.AgentDownloadBaseUrl + "/" + Constants.AgentVersionFileName;
private const string CacheKey = "latest-versions";
private static readonly TimeSpan CacheDuration = TimeSpan.FromHours(12);
private static readonly TimeSpan FailureCacheDuration = TimeSpan.FromMinutes(5);
private static readonly TimeSpan CacheDuration = TimeSpan.FromMinutes(5);
private static readonly TimeSpan FailureCacheDuration = TimeSpan.FromMinutes(1);
private readonly IHttpClientFactory _httpClientFactory;
private readonly IMemoryCache _cache;
private readonly ILogger<LatestVersionsService> _logger;
/// <summary>
/// Survives cache expiry: served when the blob read fails so a transient hiccup
/// hides the version line for at most one request instead of a full failure TTL.
/// </summary>
private volatile LatestVersions? _lastGood;
public LatestVersionsService(
IHttpClientFactory httpClientFactory,
IMemoryCache cache,
@@ -85,15 +97,22 @@ namespace AutopilotMonitor.Functions.Services
FromCache: false);
_cache.Set(CacheKey, result, CacheDuration);
_lastGood = result;
_logger.LogInformation("LatestVersions refreshed: agent={AgentVersion}, bootstrap={BootstrapVersion}", version, bootstrapVersion);
return result;
}
catch (Exception ex)
{
_logger.LogWarning(ex, "Failed to fetch {Url}; caching null for {Minutes}m", VersionJsonUrl, FailureCacheDuration.TotalMinutes);
// Cache failure briefly to avoid hammering blob on repeated calls
_cache.Set(CacheKey, (LatestVersions?)null, FailureCacheDuration);
return null;
var lastGood = _lastGood;
_logger.LogWarning(
ex,
"Failed to fetch {Url}; serving {Fallback} for {Minutes}m",
VersionJsonUrl,
lastGood == null ? "nothing" : $"the value fetched at {lastGood.FetchedAtUtc:O}",
FailureCacheDuration.TotalMinutes);
// Cache the outcome briefly to avoid hammering the blob on repeated calls.
_cache.Set(CacheKey, lastGood, FailureCacheDuration);
return lastGood == null ? null : lastGood with { FromCache = true };
}
}
}
@@ -328,7 +328,12 @@ namespace AutopilotMonitor.Functions.Services
// Idempotent, positive-evidence-only; also heals sessions that went
// terminal before the resolution seam existed (hadNoRow backfill).
if (eventCountMoved || hadNoRow)
{
await _metricsRepo.ResolveEspBlockingForSessionAsync(session.TenantId, session.SessionId);
// Same late-batch reasoning: an app row opened after the agent's
// shutdown batch was never closed — the sweep is its self-heal.
await _metricsRepo.CloseOpenAppInstallsForSessionAsync(session.TenantId, session.SessionId);
}
}
if (breakdown == null)
@@ -1045,6 +1050,20 @@ namespace AutopilotMonitor.Functions.Services
_logger.LogWarning(ex, "Failed to cleanup old tenant notifications");
}
try
{
// Closed community rule submissions: withdrawn 30d, declined 90d (RuleSubmissionRetention);
// pending/approved/published rows are never swept.
var deleted = await _ruleSubmissionRepo.DeleteExpiredAsync(now);
if (deleted > 0)
_logger.LogInformation("Rule submissions cleanup: deleted {Count} closed rows (withdrawn {WithdrawnDays}d / declined {DeclinedDays}d)",
deleted, RuleSubmissionRetention.WithdrawnDays, RuleSubmissionRetention.DeclinedDays);
}
catch (Exception ex)
{
_logger.LogWarning(ex, "Failed to cleanup closed rule submissions");
}
try
{
var deleted = await _hardwareRejectionTracker.DeleteOlderThanAsync(now.AddDays(-hardwareRejectionRetentionDays));
@@ -41,6 +41,7 @@ namespace AutopilotMonitor.Functions.Services
private readonly INotificationRepository _notificationRepo;
private readonly ITenantNotificationRepository _tenantNotificationRepo;
private readonly IHardwareRejectionNotificationTracker _hardwareRejectionTracker;
private readonly IRuleSubmissionRepository _ruleSubmissionRepo;
private readonly IDelegationInvitationRepository _delegationInvitationRepo;
private readonly DataAccess.TableStorage.BackupJobsRepository _backupJobsRepo;
private readonly OpsEventService _opsEventService;
@@ -75,6 +76,7 @@ namespace AutopilotMonitor.Functions.Services
INotificationRepository notificationRepo,
ITenantNotificationRepository tenantNotificationRepo,
IHardwareRejectionNotificationTracker hardwareRejectionTracker,
IRuleSubmissionRepository ruleSubmissionRepo,
IDelegationInvitationRepository delegationInvitationRepo,
DataAccess.TableStorage.BackupJobsRepository backupJobsRepo,
OpsEventService opsEventService,
@@ -103,6 +105,7 @@ namespace AutopilotMonitor.Functions.Services
_opsEventRepo = opsEventRepo;
_notificationRepo = notificationRepo;
_tenantNotificationRepo = tenantNotificationRepo;
_ruleSubmissionRepo = ruleSubmissionRepo;
_hardwareRejectionTracker = hardwareRejectionTracker;
_delegationInvitationRepo = delegationInvitationRepo;
_backupJobsRepo = backupJobsRepo;
@@ -141,6 +141,7 @@ namespace AutopilotMonitor.Functions.Services.Offboarding
{
(Constants.TableNames.BootstrapSessions, "CodeLookup"),
(Constants.TableNames.SessionReports, "reports"),
(Constants.TableNames.RuleSubmissions, "submissions"),
};
// Plan §6.3.2 — Variant C (TenantId property only).
@@ -127,6 +127,18 @@ namespace AutopilotMonitor.Functions.Services
});
}
// Field-absence gate: not_exists WITH a dataField matches when no event of the type
// carries a non-empty value at that field — including when the type is absent — the
// same semantics as the precondition gate. Must run before the "no matching events"
// veto and the per-event loop below, whose null short-circuit could never express
// "the field is missing" (session 683f1eff: "esp_failure_settle_started.errorCode
// not_exists" was silently dead).
if (!string.IsNullOrEmpty(condition.DataField)
&& string.Equals(condition.Operator, "not_exists", StringComparison.OrdinalIgnoreCase))
{
return EvaluateFieldAbsence(condition, matchingEvents);
}
if (!matchingEvents.Any())
return (false, "no matching events");
@@ -206,6 +218,11 @@ namespace AutopilotMonitor.Functions.Services
{
var matchingEvents = ApplyValueFilter(condition, events.Where(e => MatchesEventType(e, condition.EventType)).ToList());
// Field-absence gate — see EvaluateEventTypeCondition; here it applies to the
// filtered event set, so "no event with filterField=x carries dataField" is expressible.
if (string.Equals(condition.Operator, "not_exists", StringComparison.OrdinalIgnoreCase))
return EvaluateFieldAbsence(condition, matchingEvents);
foreach (var evt in matchingEvents)
{
var fieldValue = GetDataFieldValue(evt, condition.DataField);
@@ -227,6 +244,26 @@ namespace AutopilotMonitor.Functions.Services
return (false, "no matching data");
}
/// <summary>
/// <c>not_exists</c> with a dataField: true when none of <paramref name="matchingEvents"/>
/// carries a non-empty value at the field (an empty set counts as absent). A single
/// non-empty value disproves it. Evidence names the type, the field and how many events
/// of the type were inspected, so a finding can say "0 esp_failure_settle_started events
/// carried errorCode" rather than pointing at one event.
/// </summary>
private static (bool matched, object evidence) EvaluateFieldAbsence(RuleCondition condition, List<EnrollmentEvent> matchingEvents)
{
if (matchingEvents.Any(e => !string.IsNullOrEmpty(GetDataFieldValue(e, condition.DataField))))
return (false, "data field present");
return (true, new Dictionary<string, object>
{
["eventType"] = condition.EventType,
["field"] = condition.DataField,
["count"] = matchingEvents.Count
});
}
/// <summary>
/// Evidence values feed the finding UI and {{token}} interpolation, both of which
/// render via ToString() — a raw List would surface as its .NET type name
@@ -0,0 +1,559 @@
using System;
using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using System.Text.Encodings.Web;
using System.Text.Json;
using System.Text.Json.Nodes;
using System.Text.RegularExpressions;
using System.Threading.Tasks;
using AutopilotMonitor.Functions.Functions.Rules;
using AutopilotMonitor.Functions.Helpers;
using AutopilotMonitor.Shared.DataAccess;
using AutopilotMonitor.Shared.Models;
using AutopilotMonitor.Shared.Pagination;
using Microsoft.Extensions.Logging;
namespace AutopilotMonitor.Functions.Services
{
/// <summary>
/// Community rule submissions: freezes a tenant's custom rule at submit time, records the
/// pre-flight findings and fire telemetry, and carries the review through to the repo file.
/// Publishing itself is a repository commit plus reseed — this service never writes the
/// global rule partition; <c>published</c> is derived from the catalog on every read.
/// </summary>
public class RuleSubmissionService
{
public const int MaxRuleJsonLength = 32_000;
public const int MaxSubmissionsPerTenantPerDay = 10;
public const int FireStatsDays = 30;
/// <summary>The credit text is published in the repo, so it is a name and nothing else.</summary>
private static readonly Regex AttributionNameShape = new(@"^[\p{L}\p{N} .,'&()\-]{1,64}$", RegexOptions.CultureInvariant);
/// <summary>Rule fields that belong to the server or the tenant, never to a frozen or published rule.</summary>
private static readonly string[] StrippedFields =
{
"isBuiltIn", "provenance", "createdAt", "updatedAt",
"markSessionAsFailed", "notifyDefault", "notify", "notifyChannelIds",
};
private static readonly JsonSerializerOptions RepoFileOptions = new()
{
WriteIndented = true,
Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,
};
// The dominant convention per kind in rules/ (ANALYZE-APP vs GATHER-APPS …); an unmapped
// category falls back to its upper-cased name, which the reviewer can overrule.
private static readonly Dictionary<string, string> AnalyzeCategoryCodes = new(StringComparer.OrdinalIgnoreCase)
{
["apps"] = "APP", ["device"] = "DEV", ["enrollment"] = "ENRL", ["esp"] = "ESP",
["identity"] = "ID", ["network"] = "NET", ["security"] = "SEC",
};
private static readonly Dictionary<string, string> GatherCategoryCodes = new(StringComparer.OrdinalIgnoreCase)
{
["apps"] = "APPS", ["device"] = "DEVICE", ["enrollment"] = "ENROLL", ["esp"] = "ESP",
["identity"] = "ID", ["network"] = "NET",
};
private readonly IRuleSubmissionRepository _submissions;
private readonly IRuleRepository _ruleRepo;
private readonly IMetricsRepository _metricsRepo;
private readonly TenantConfigurationService _configService;
private readonly ILogger<RuleSubmissionService> _logger;
public RuleSubmissionService(
IRuleSubmissionRepository submissions,
IRuleRepository ruleRepo,
IMetricsRepository metricsRepo,
TenantConfigurationService configService,
ILogger<RuleSubmissionService> logger)
{
_submissions = submissions;
_ruleRepo = ruleRepo;
_metricsRepo = metricsRepo;
_configService = configService;
_logger = logger;
}
// ── Submit ──────────────────────────────────────────────────────────────
/// <summary>
/// Freezes and stores every referenced rule. All-or-nothing: a pre-flight error on any
/// item rejects the whole batch (<see cref="ArgumentException"/>), so a tenant never ends
/// up with half a submission. <see cref="InvalidOperationException"/> = conflict (open
/// duplicate, daily cap).
/// </summary>
public async Task<List<RuleSubmission>> SubmitAsync(
string tenantId, SubmitRuleSubmissionsRequest request, string submittedBy, string submittedByName)
{
if (request.Items == null || request.Items.Count == 0)
throw new ArgumentException("At least one rule is required.");
if (request.Items.Count > SubmitRuleSubmissionsRequest.MaxItems)
throw new ArgumentException($"At most {SubmitRuleSubmissionsRequest.MaxItems} rules per submission.");
if (request.Comment != null && request.Comment.Length > SubmitRuleSubmissionsRequest.MaxCommentLength)
throw new ArgumentException($"Comment exceeds {SubmitRuleSubmissionsRequest.MaxCommentLength} characters.");
var attributionName = await ResolveAttributionNameAsync(tenantId, request.AttributionMode, request.AttributionName);
var contactEmail = NormalizeEmail(request.Email);
var distinct = request.Items
.Select(i => (Kind: i.Kind?.Trim().ToLowerInvariant() ?? string.Empty, RuleId: i.RuleId?.Trim() ?? string.Empty))
.Distinct()
.ToList();
foreach (var (kind, ruleId) in distinct)
{
if (!RuleSubmissionKinds.IsKnown(kind))
throw new ArgumentException($"Unknown rule kind '{kind}'.");
if (string.IsNullOrEmpty(ruleId))
throw new ArgumentException("ruleId is required for every item.");
}
var existing = await _submissions.GetForTenantAsync(tenantId);
var since = DateTime.UtcNow.AddDays(-1);
if (existing.Count(s => s.SubmittedAt >= since) + distinct.Count > MaxSubmissionsPerTenantPerDay)
throw new InvalidOperationException($"At most {MaxSubmissionsPerTenantPerDay} rule submissions per tenant and day.");
var analyzeRules = distinct.Any(d => d.Kind == RuleSubmissionKinds.Analyze)
? await _ruleRepo.GetAnalyzeRulesAsync(tenantId) : new List<AnalyzeRule>();
var gatherRules = distinct.Any(d => d.Kind == RuleSubmissionKinds.Gather)
? await _ruleRepo.GetGatherRulesAsync(tenantId) : new List<GatherRule>();
var now = DateTime.UtcNow;
var batchId = NewId();
var prepared = new List<RuleSubmission>(distinct.Count);
var errors = new List<string>();
foreach (var (kind, ruleId) in distinct)
{
if (existing.Any(s => s.Status == RuleSubmissionStatuses.Pending
&& s.RuleKind == kind
&& string.Equals(s.SourceRuleId, ruleId, StringComparison.OrdinalIgnoreCase)))
throw new InvalidOperationException($"Rule '{ruleId}' already has a pending submission.");
var submission = new RuleSubmission
{
SubmissionId = NewId(),
BatchId = batchId,
TenantId = tenantId,
RuleKind = kind,
SourceRuleId = ruleId,
Comment = string.IsNullOrWhiteSpace(request.Comment) ? null : request.Comment!.Trim(),
SubmittedBy = submittedBy,
SubmittedByName = submittedByName,
ContactEmail = contactEmail,
AttributionMode = request.AttributionMode,
AttributionName = attributionName,
SubmittedAt = now,
Status = RuleSubmissionStatuses.Pending,
};
var findings = new List<RuleSubmissionFinding>();
if (kind == RuleSubmissionKinds.Analyze)
{
var rule = analyzeRules.FirstOrDefault(r => string.Equals(r.RuleId, ruleId, StringComparison.OrdinalIgnoreCase)
&& !r.IsBuiltIn && !r.IsCommunity);
if (rule == null) { errors.Add($"{ruleId}: not a custom analyze rule of this tenant."); continue; }
submission.Title = rule.Title ?? string.Empty;
submission.Category = rule.Category ?? string.Empty;
submission.DerivedFromTemplateRuleId = rule.DerivedFromTemplateRuleId;
submission.RuleJson = FreezeRule(rule);
foreach (var e in DryRunAnalyzeRuleFunction.ValidateDraftRule(rule))
findings.Add(new RuleSubmissionFinding { Level = "error", Message = e });
if (!string.IsNullOrEmpty(rule.DerivedFromTemplateRuleId))
findings.Add(new RuleSubmissionFinding { Level = "info", Message = $"Derived from template {rule.DerivedFromTemplateRuleId} — usually a filled-in copy rather than a new detection." });
}
else
{
var rule = gatherRules.FirstOrDefault(r => string.Equals(r.RuleId, ruleId, StringComparison.OrdinalIgnoreCase)
&& !r.IsBuiltIn && !r.IsCommunity);
if (rule == null) { errors.Add($"{ruleId}: not a custom gather rule of this tenant."); continue; }
submission.Title = rule.Title ?? string.Empty;
submission.Category = rule.Category ?? string.Empty;
submission.RuleJson = FreezeRule(rule);
if (string.IsNullOrWhiteSpace(rule.CollectorType)) findings.Add(new RuleSubmissionFinding { Level = "error", Message = "collectorType is required" });
if (string.IsNullOrWhiteSpace(rule.Target)) findings.Add(new RuleSubmissionFinding { Level = "error", Message = "target is required" });
if (string.IsNullOrWhiteSpace(rule.Trigger)) findings.Add(new RuleSubmissionFinding { Level = "error", Message = "trigger is required" });
if (string.IsNullOrWhiteSpace(rule.OutputEventType)) findings.Add(new RuleSubmissionFinding { Level = "error", Message = "outputEventType is required" });
var scopeError = GatherRulesFunction.ValidateScopeAndEmitMode(rule);
if (scopeError != null) findings.Add(new RuleSubmissionFinding { Level = "error", Message = scopeError });
findings.Add(new RuleSubmissionFinding { Level = "info", Message = "Collector guardrails are enforced on the device; the full allowlist check runs in the MCP validate_rule tool." });
}
if (submission.RuleJson.Length > MaxRuleJsonLength)
findings.Add(new RuleSubmissionFinding { Level = "error", Message = $"rule document exceeds {MaxRuleJsonLength} characters" });
var itemErrors = findings.Where(f => f.Level == "error").Select(f => $"{ruleId}: {f.Message}").ToList();
if (itemErrors.Count > 0) { errors.AddRange(itemErrors); continue; }
submission.ValidationFindings = findings;
submission.SourceFireStats = await GetFireStatsAsync(tenantId, kind, ruleId);
prepared.Add(submission);
}
if (errors.Count > 0)
throw new ArgumentException("Submission rejected: " + string.Join(" | ", errors));
foreach (var submission in prepared)
{
if (!await _submissions.AddAsync(submission))
throw new InvalidOperationException("Failed to store the submission.");
}
return prepared;
}
private async Task<string> ResolveAttributionNameAsync(string tenantId, string? mode, string? requestedName)
{
switch (mode)
{
case RuleAttributionModes.Anonymous:
return RuleAttributionModes.AnonymousAuthor;
case RuleAttributionModes.Organization:
{
var config = await _configService.GetConfigurationIfExistsAsync(tenantId);
var name = config?.CompanyName;
if (string.IsNullOrWhiteSpace(name)) name = config?.DomainName;
if (string.IsNullOrWhiteSpace(name))
throw new ArgumentException("No organization name is known for this tenant — set the company name in the tenant settings or choose another attribution.");
return ValidateAttributionName(name!.Trim());
}
case RuleAttributionModes.Person:
if (string.IsNullOrWhiteSpace(requestedName))
throw new ArgumentException("attributionName is required for the person attribution.");
return ValidateAttributionName(requestedName!.Trim());
default:
throw new ArgumentException($"attributionMode must be one of: {string.Join(", ", RuleAttributionModes.All)}.");
}
}
/// <summary>Trimmed, or null when empty; the shape check is deliberately loose (exactly one @ with something on both sides, no whitespace, at most 254 characters).</summary>
internal static string? NormalizeEmail(string? email)
{
var trimmed = email?.Trim();
if (string.IsNullOrEmpty(trimmed)) return null;
var at = trimmed!.IndexOf('@');
if (trimmed.Length > SubmitRuleSubmissionsRequest.MaxEmailLength
|| at <= 0
|| at != trimmed.LastIndexOf('@')
|| at == trimmed.Length - 1
|| trimmed.Any(char.IsWhiteSpace))
throw new ArgumentException("email is not a valid address.");
return trimmed;
}
internal static string ValidateAttributionName(string name)
{
if (!AttributionNameShape.IsMatch(name))
throw new ArgumentException("attributionName may only contain letters, digits, spaces and . , ' & ( ) - (1–64 characters).");
return name;
}
/// <summary>Wire JSON of the rule minus server and tenant fields — what the reviewer sees and what ships.</summary>
internal static string FreezeRule<T>(T rule)
{
var node = JsonSerializer.SerializeToNode(rule, ApiJsonOptions.Create()) as JsonObject
?? throw new InvalidOperationException("Rule did not serialize to an object.");
foreach (var field in StrippedFields) node.Remove(field);
return node.ToJsonString();
}
private async Task<RuleSubmissionFireStats?> GetFireStatsAsync(string tenantId, string kind, string ruleId)
{
try
{
var end = DateTime.UtcNow;
var start = end.AddDays(-FireStatsDays);
var entries = await _metricsRepo.GetRuleStatsAsync(
tenantId, start.ToString("yyyy-MM-dd", CultureInfo.InvariantCulture),
end.ToString("yyyy-MM-dd", CultureInfo.InvariantCulture), kind);
var mine = entries.Where(e => string.Equals(e.RuleId, ruleId, StringComparison.OrdinalIgnoreCase)).ToList();
return new RuleSubmissionFireStats
{
Days = FireStatsDays,
FireCount = mine.Sum(e => e.FireCount),
SessionsEvaluated = mine.Sum(e => e.SessionsEvaluated),
EvaluationCount = mine.Sum(e => e.EvaluationCount),
};
}
catch (Exception ex)
{
_logger.LogWarning(ex, "Fire stats unavailable for {RuleId} (tenant {TenantId})", ruleId, tenantId);
return null;
}
}
// ── Read ────────────────────────────────────────────────────────────────
public Task<RuleSubmission?> GetAsync(string submissionId) => _submissions.GetAsync(submissionId);
public Task<List<RuleSubmission>> GetForTenantAsync(string tenantId) => _submissions.GetForTenantAsync(tenantId);
public Task<RawPage<RuleSubmission>> GetPageAsync(string? tenantId, string? status, int pageSize, string? continuation)
=> _submissions.GetPageAsync(tenantId, status, pageSize, continuation);
/// <summary>Projects rows to the wire shape with the effective status (<c>published</c> derived from the catalog).</summary>
public async Task<List<RuleSubmissionItem>> ToItemsAsync(IEnumerable<RuleSubmission> rows)
{
var list = rows.ToList();
HashSet<string>? globalAnalyze = null, globalGather = null;
if (list.Any(s => s.Status == RuleSubmissionStatuses.Approved && !string.IsNullOrEmpty(s.PublishedRuleId)))
{
globalAnalyze = (await _ruleRepo.GetAnalyzeRulesAsync("global")).Select(r => r.RuleId).ToHashSet(StringComparer.OrdinalIgnoreCase);
globalGather = (await _ruleRepo.GetGatherRulesAsync("global")).Select(r => r.RuleId).ToHashSet(StringComparer.OrdinalIgnoreCase);
}
return list.Select(s => ToItem(s, IsPublished(s, globalAnalyze, globalGather))).ToList();
}
private static bool IsPublished(RuleSubmission s, HashSet<string>? globalAnalyze, HashSet<string>? globalGather)
{
if (s.Status != RuleSubmissionStatuses.Approved || string.IsNullOrEmpty(s.PublishedRuleId)) return false;
var set = s.RuleKind == RuleSubmissionKinds.Analyze ? globalAnalyze : globalGather;
return set != null && set.Contains(s.PublishedRuleId!);
}
internal static RuleSubmissionItem ToItem(RuleSubmission s, bool published) => new()
{
SubmissionId = s.SubmissionId,
BatchId = s.BatchId,
TenantId = s.TenantId,
RuleKind = s.RuleKind,
SourceRuleId = s.SourceRuleId,
Title = s.Title,
Category = s.Category,
Comment = s.Comment,
SubmittedBy = s.SubmittedBy,
SubmittedByName = s.SubmittedByName,
ContactEmail = s.ContactEmail,
AttributionMode = s.AttributionMode,
AttributionName = s.AttributionName,
SubmittedAt = s.SubmittedAt,
Status = published ? RuleSubmissionStatuses.Published : s.Status,
ValidationFindings = s.ValidationFindings,
SourceFireStats = s.SourceFireStats,
ReviewedBy = s.ReviewedBy,
ReviewedAt = s.ReviewedAt,
ReviewComment = s.ReviewComment,
WillBeAdapted = s.WillBeAdapted,
PublishedRuleId = s.PublishedRuleId,
DerivedFromTemplateRuleId = s.DerivedFromTemplateRuleId,
};
/// <summary>Everything the reviewer (human or AI) needs for one submission.</summary>
public async Task<RuleSubmissionDetailResponse?> GetDetailAsync(string submissionId)
{
var s = await _submissions.GetAsync(submissionId);
if (s == null) return null;
var item = (await ToItemsAsync(new[] { s }))[0];
var response = new RuleSubmissionDetailResponse { Success = true, Submission = item };
if (s.RuleKind == RuleSubmissionKinds.Analyze)
{
var rule = JsonSerializer.Deserialize<AnalyzeRule>(s.RuleJson, ApiJsonOptions.Read);
if (rule != null) { rule.IsBuiltIn = false; rule.IsCommunity = false; }
response.AnalyzeRule = rule;
}
else
{
var rule = JsonSerializer.Deserialize<GatherRule>(s.RuleJson, ApiJsonOptions.Read);
if (rule != null) { rule.IsBuiltIn = false; rule.IsCommunity = false; }
response.GatherRule = rule;
}
response.LiveFireStats = await GetFireStatsAsync(s.TenantId, s.RuleKind, s.SourceRuleId);
response.SuggestedPublishedRuleId = s.PublishedRuleId ?? await SuggestPublishedRuleIdAsync(s.RuleKind, s.Category);
var fileId = s.PublishedRuleId ?? response.SuggestedPublishedRuleId;
if (!string.IsNullOrEmpty(fileId))
response.RepoFile = BuildRepoFile(s, fileId!);
return response;
}
// ── Review ──────────────────────────────────────────────────────────────
/// <summary>
/// Applies a reviewer decision. Transitions: pending → approved | declined; approved → declined
/// while not yet published. <see cref="KeyNotFoundException"/> = unknown id,
/// <see cref="ArgumentException"/> = bad input, <see cref="InvalidOperationException"/> = conflict.
/// </summary>
public async Task<RuleSubmission> ReviewAsync(string submissionId, ReviewRuleSubmissionRequest request, string reviewedBy)
{
var s = await _submissions.GetAsync(submissionId) ?? throw new KeyNotFoundException("Submission not found.");
var comment = string.IsNullOrWhiteSpace(request.ReviewComment) ? null : request.ReviewComment!.Trim();
if (comment != null && comment.Length > ReviewRuleSubmissionRequest.MaxReviewCommentLength)
throw new ArgumentException($"reviewComment exceeds {ReviewRuleSubmissionRequest.MaxReviewCommentLength} characters.");
var published = (await ToItemsAsync(new[] { s }))[0].Status == RuleSubmissionStatuses.Published;
if (published)
throw new InvalidOperationException("The rule is already published; the submission is final.");
if (s.Status == RuleSubmissionStatuses.Withdrawn)
throw new InvalidOperationException("The submitter withdrew this submission.");
switch (request.Decision)
{
case RuleSubmissionDecisions.Approve:
{
if (s.Status != RuleSubmissionStatuses.Pending)
throw new InvalidOperationException($"Only a pending submission can be approved (status: {s.Status}).");
var publishedRuleId = request.PublishedRuleId?.Trim();
if (string.IsNullOrEmpty(publishedRuleId))
throw new ArgumentException("publishedRuleId is required to approve.");
await ValidatePublishedRuleIdAsync(s, publishedRuleId!);
s.Status = RuleSubmissionStatuses.Approved;
s.PublishedRuleId = publishedRuleId;
s.WillBeAdapted = request.WillBeAdapted ?? false;
break;
}
case RuleSubmissionDecisions.Decline:
{
if (s.Status != RuleSubmissionStatuses.Pending && s.Status != RuleSubmissionStatuses.Approved)
throw new InvalidOperationException($"Cannot decline a submission in status {s.Status}.");
if (comment == null)
throw new ArgumentException("reviewComment is required to decline — the submitter sees it.");
s.Status = RuleSubmissionStatuses.Declined;
s.PublishedRuleId = null;
s.WillBeAdapted = false;
break;
}
default:
throw new ArgumentException($"decision must be one of: {string.Join(", ", RuleSubmissionDecisions.All)}.");
}
s.ReviewComment = comment;
s.ReviewedBy = reviewedBy;
s.ReviewedAt = DateTime.UtcNow;
if (!await _submissions.UpdateAsync(s))
throw new InvalidOperationException("The submission changed underneath this review; reload and retry.");
return s;
}
private async Task ValidatePublishedRuleIdAsync(RuleSubmission s, string publishedRuleId)
{
var kindPrefix = s.RuleKind == RuleSubmissionKinds.Analyze ? "ANALYZE-" : "GATHER-";
if (!RuleIdPolicy.IsReservedBuiltInId(publishedRuleId)
|| !publishedRuleId.StartsWith(kindPrefix, StringComparison.OrdinalIgnoreCase)
|| !Regex.IsMatch(publishedRuleId, @"^[A-Z]+-[A-Z]+-\d{3}$"))
throw new ArgumentException($"publishedRuleId must be {kindPrefix}<CATEGORY>-<NNN> in the reserved built-in namespace (upper case, three digits).");
var taken = await GetTakenIdsAsync(s.RuleKind);
if (taken.Contains(publishedRuleId))
throw new InvalidOperationException($"Rule id '{publishedRuleId}' is already taken (catalog, global partition or another approved submission).");
}
/// <summary>Tenant-side withdrawal; only while pending. False when there is nothing to withdraw.</summary>
public async Task<bool> WithdrawAsync(string tenantId, string submissionId, bool crossTenantAllowed)
{
var s = await _submissions.GetAsync(submissionId);
if (s == null) return false;
if (!crossTenantAllowed && !string.Equals(s.TenantId, tenantId, StringComparison.OrdinalIgnoreCase)) return false;
if (s.Status != RuleSubmissionStatuses.Pending)
throw new InvalidOperationException($"Only a pending submission can be withdrawn (status: {s.Status}).");
s.Status = RuleSubmissionStatuses.Withdrawn;
return await _submissions.UpdateAsync(s);
}
/// <summary>
/// Operator hard delete — the row disappears from the operator list and the tenant's list
/// alike. Not part of normal operations: for test and demo submissions, or on a tenant's request.
/// </summary>
public Task<bool> DeleteAsync(string submissionId) => _submissions.DeleteAsync(submissionId);
/// <summary>Daily retention sweep of closed submissions (see <see cref="RuleSubmissionRetention"/>).</summary>
public Task<int> SweepExpiredAsync(DateTime nowUtc) => _submissions.DeleteExpiredAsync(nowUtc);
// ── Id suggestion + repo file ───────────────────────────────────────────
private async Task<HashSet<string>> GetTakenIdsAsync(string kind)
{
var taken = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
if (kind == RuleSubmissionKinds.Analyze)
{
foreach (var r in BuiltInAnalyzeRules.GetAll()) taken.Add(r.RuleId);
foreach (var r in await _ruleRepo.GetAnalyzeRulesAsync("global")) taken.Add(r.RuleId);
}
else
{
foreach (var r in BuiltInGatherRules.GetAll()) taken.Add(r.RuleId);
foreach (var r in await _ruleRepo.GetGatherRulesAsync("global")) taken.Add(r.RuleId);
}
foreach (var id in await _submissions.GetReservedPublishedRuleIdsAsync()) taken.Add(id);
return taken;
}
public async Task<string> SuggestPublishedRuleIdAsync(string kind, string category)
=> SuggestPublishedRuleId(kind, category, await GetTakenIdsAsync(kind));
/// <summary>
/// Max + 1 within <c>{KIND}-{CODE}-</c> over every taken id. Gaps are retired ids that may
/// return (RuleIdPolicy) and are never reused.
/// </summary>
internal static string SuggestPublishedRuleId(string kind, string category, IEnumerable<string> takenIds)
{
var codes = kind == RuleSubmissionKinds.Analyze ? AnalyzeCategoryCodes : GatherCategoryCodes;
var code = codes.TryGetValue(category ?? string.Empty, out var mapped)
? mapped
: Regex.Replace((category ?? "MISC").ToUpperInvariant(), "[^A-Z]", "");
if (code.Length == 0) code = "MISC";
var prefix = (kind == RuleSubmissionKinds.Analyze ? "ANALYZE-" : "GATHER-") + code + "-";
var max = 0;
foreach (var id in takenIds)
{
if (!id.StartsWith(prefix, StringComparison.OrdinalIgnoreCase)) continue;
if (int.TryParse(id.Substring(prefix.Length), NumberStyles.None, CultureInfo.InvariantCulture, out var n) && n > max)
max = n;
}
return prefix + (max + 1).ToString("D3", CultureInfo.InvariantCulture);
}
/// <summary>
/// The file that ships the rule: schema pointer first, the assigned id, the chosen credit,
/// <c>isCommunity</c>, and <c>enabled</c> after the built-in convention (analyze rules ship
/// on, gather rules opt-in because they cost device work). Lineage to the tenant's template
/// copy is dropped.
/// </summary>
internal static RuleSubmissionRepoFile BuildRepoFile(RuleSubmission s, string publishedRuleId)
{
var frozen = JsonNode.Parse(s.RuleJson) as JsonObject
?? throw new InvalidOperationException("Frozen rule is not an object.");
var isAnalyze = s.RuleKind == RuleSubmissionKinds.Analyze;
var ordered = new JsonObject
{
["$schema"] = isAnalyze ? "../schema/analyze-rule.schema.json" : "../schema/gather-rule.schema.json",
["ruleId"] = publishedRuleId,
};
foreach (var head in isAnalyze
? new[] { "title", "description", "severity", "category", "version" }
: new[] { "title", "description", "category", "version" })
{
if (frozen.TryGetPropertyValue(head, out var value)) ordered[head] = value?.DeepClone();
}
ordered["author"] = s.AttributionName;
ordered["enabled"] = isAnalyze;
ordered["isCommunity"] = true;
foreach (var kv in frozen)
{
if (ordered.ContainsKey(kv.Key)) continue;
if (kv.Key == "derivedFromTemplateRuleId") continue;
if (Array.IndexOf(StrippedFields, kv.Key) >= 0) continue;
ordered[kv.Key] = kv.Value?.DeepClone();
}
var folder = isAnalyze ? "analyze" : "gather";
return new RuleSubmissionRepoFile
{
Path = $"rules/{folder}/{publishedRuleId}.json",
Content = ordered.ToJsonString(RepoFileOptions) + "\n",
};
}
private static string NewId() => Guid.NewGuid().ToString("N").Substring(0, 12);
}
}
@@ -253,9 +253,11 @@ namespace AutopilotMonitor.Functions.Services
// Status "InProgress" — a real (non-sentinel) value that Merge-mode would
// happily write over a row the terminal batch already closed. Only another
// terminal observation may change a terminal status (Failed→Succeeded on a
// successful retry stays legal).
// successful retry stays legal). Incomplete (observation-end close step) is
// terminal for the same purpose: a straggling progress-only batch must not
// reopen it, while a real terminal observation still wins.
var existingStatus = existing.GetString("Status");
if ((existingStatus == "Succeeded" || existingStatus == "Failed") &&
if ((existingStatus == "Succeeded" || existingStatus == "Failed" || existingStatus == "Incomplete") &&
summary.Status != "Succeeded" && summary.Status != "Failed")
{
summary.Status = existingStatus;
@@ -525,6 +527,66 @@ namespace AutopilotMonitor.Functions.Services
return sets.Contains(appId);
}
/// <summary>
/// Closes the session's app rows that never reached a terminal state: Status
/// "InProgress" (or missing) with no CompletedAt becomes "Incomplete" — terminal,
/// non-failure, outcome unknown. Runs at the terminal seam, again after the batch that
/// carries the agent's shutdown (rows opened after the verdict), and from the 30-day
/// sweep. Idempotent + fail-soft; a real terminal arriving later still wins through the
/// sticky-status reconcile. Returns the number of rows closed.
/// </summary>
public async Task<int> CloseOpenAppInstallsForSessionAsync(string tenantId, string sessionId)
{
try
{
SecurityValidator.EnsureValidGuid(tenantId, nameof(tenantId));
SecurityValidator.EnsureValidGuid(sessionId, nameof(sessionId));
var tableClient = _tableServiceClient.GetTableClient(Constants.TableNames.AppInstallSummaries);
var filter = $"PartitionKey eq '{tenantId}' and RowKey ge '{sessionId}_' and RowKey lt '{sessionId}`'";
var query = tableClient.QueryAsync<TableEntity>(
filter: filter,
select: new[] { "PartitionKey", "RowKey", "Status", "CompletedAt" });
var closed = 0;
await foreach (var row in query)
{
if (!ShouldCloseAsIncomplete(row)) continue;
var update = new TableEntity(row.PartitionKey, row.RowKey)
{
["Status"] = "Incomplete"
};
await tableClient.UpsertEntityAsync(update, TableUpdateMode.Merge);
closed++;
}
if (closed > 0)
_logger.LogInformation(
"Session {SessionId}: closed {Count} app rows as Incomplete (no terminal state when observation ended)",
sessionId, closed);
return closed;
}
catch (Exception ex)
{
_logger.LogWarning(ex, "Closing open app rows failed for session {SessionId} (fail-soft)", sessionId);
return 0;
}
}
/// <summary>
/// Pure per-row predicate behind <see cref="CloseOpenAppInstallsForSessionAsync"/> —
/// internal static so the contract is pinned by unit tests: only a row that is still
/// open (Status missing, empty or "InProgress", no CompletedAt) closes; every terminal
/// row, including an already-closed Incomplete one, is left alone (idempotency).
/// </summary>
internal static bool ShouldCloseAsIncomplete(TableEntity row)
{
if (row.GetDateTimeOffset("CompletedAt").HasValue) return false;
var status = row.GetString("Status");
return string.IsNullOrEmpty(status) || status == "InProgress";
}
/// <summary>
/// Gets app install summaries for a tenant (fleet-level metrics). When <paramref name="sinceUtc"/>
/// is supplied, a server-side <c>StartedAt ge</c> filter is applied so a windowed view (e.g. the
@@ -104,6 +104,42 @@ namespace AutopilotMonitor.Functions.Services
}
}
/// <summary>
/// Sends a Telegram notification when a tenant admin submits a custom rule for the
/// community pool. The submission id comes first — it is the handle for the review.
/// Best-effort — silently no-ops if the webhook URL is not configured.
/// </summary>
public async Task SendRuleSubmissionAsync(string submissionId, string tenantId, string submittedBy, string ruleKind, string ruleId, string title, string comment)
{
try
{
var webhookUrl = await GetWebhookUrlAsync();
if (string.IsNullOrWhiteSpace(webhookUrl))
{
_logger.LogDebug("Telegram webhook URL not configured — skipping rule submission notification");
return;
}
var commentLine = string.IsNullOrWhiteSpace(comment) ? "" : $"\nComment: {comment}";
var payload = new
{
chat_id = "-1003632442830",
text = $"New Rule Submission {submissionId}\nRule: {ruleId} \"{title}\" ({ruleKind})\nTenantID: {tenantId}\nBy: {submittedBy}{commentLine}"
};
var json = JsonConvert.SerializeObject(payload);
var content = new StringContent(json, Encoding.UTF8, "application/json");
var response = await _http.PostAsync(webhookUrl, content);
if (response.IsSuccessStatusCode)
_logger.LogInformation("Telegram rule submission notification sent for {SubmissionId}", submissionId);
}
catch (Exception ex)
{
_logger.LogWarning(ex, "Failed to send Telegram rule submission notification for {SubmissionId}", submissionId);
}
}
/// <summary>
/// Sends a Telegram notification when a tenant admin submits a diag-files-only report
/// (no session context). Best-effort — silently no-ops if the webhook URL is not configured.
@@ -35,6 +35,8 @@ public static class TenantNotificationAudienceCatalog
["rule_frequency_regression"] = NotificationAudience.Admin,
// App-version duration regression radar: packaging/rollout is an admin concern.
["app_version_duration_regression"] = NotificationAudience.Admin,
// Community rule submission decided (approved/declined): only admins submit, only admins act.
["rule_submission_decided"] = NotificationAudience.Admin,
};
public static NotificationAudience Resolve(string? type)
@@ -0,0 +1,139 @@
/**
* Two request-gate contracts (2026-09-10):
* - a token the backend refuses (401) is answered 401 + WWW-Authenticate error="invalid_token"
* (spec: invalid or expired tokens MUST receive 401), cached like a deny, never 403 "not enabled";
* - the caller context carries a cancellation signal that fires when the client closes the request
* before the response is written (Streamable HTTP: closing the response stream cancels the request).
*/
import { describe, it, expect, vi, afterEach } from 'vitest';
import type { Request, Response, NextFunction } from 'express';
import { accessGuard } from '../access-guard.js';
import { getCallerSignal } from '../client.js';
function makeToken(claims: Record<string, unknown>): string {
const header = Buffer.from(JSON.stringify({ alg: 'none', typ: 'JWT' })).toString('base64url');
const payload = Buffer.from(JSON.stringify(claims)).toString('base64url');
return `${header}.${payload}.sig`;
}
let seed = 0;
/** A fresh, unexpired token per call — the guard caches verdicts per UPN+token. */
function request(): Request {
seed += 1;
const token = makeToken({ upn: `user${seed}@contoso.com`, exp: Math.floor(Date.now() / 1000) + 3600 });
return {
headers: { host: 'mcp.example.com', authorization: `Bearer ${token}` },
protocol: 'https',
body: { jsonrpc: '2.0', method: 'tools/list', id: 1 },
} as unknown as Request;
}
interface Outcome {
nextCalled: boolean;
status: number | null;
body: unknown;
headers: Record<string, string>;
/** The caller context's signal, read INSIDE next(). */
signal?: AbortSignal;
res: { writableFinished: boolean };
/** Emits the response's 'close' event the way Node does when the socket goes away. */
close: () => void;
}
function run(req: Request): Promise<Outcome> {
return new Promise((resolve) => {
const headers: Record<string, string> = {};
const closeHandlers: Array<() => void> = [];
let status: number | null = null;
let settled = false;
const state = { writableFinished: false };
const close = () => closeHandlers.forEach((h) => h());
const finish = (o: Omit<Outcome, 'res' | 'close'>) => {
if (settled) return;
settled = true;
resolve({ ...o, res: state, close });
};
const res = {
get writableFinished() { return state.writableFinished; },
setHeader(name: string, value: string) { headers[name] = String(value); return this; },
status(code: number) { status = code; return this; },
json(payload: unknown) { finish({ nextCalled: false, status, body: payload, headers }); return this; },
on(event: string, handler: () => void) { if (event === 'close') closeHandlers.push(handler); return this; },
} as unknown as Response;
const next: NextFunction = () => finish({ nextCalled: true, status, body: undefined, headers, signal: getCallerSignal() });
accessGuard(req, res, next);
setTimeout(() => finish({ nextCalled: false, status, body: undefined, headers }), 2_000);
});
}
function stubBackend(status: number, body: unknown) {
const fn = vi.fn(async () => ({ status, text: async () => JSON.stringify(body) } as unknown as Response));
vi.stubGlobal('fetch', fn);
return fn;
}
afterEach(() => {
vi.unstubAllGlobals();
vi.restoreAllMocks();
});
describe('accessGuard — a backend 401 becomes 401 + challenge', () => {
it('answers 401 with error="invalid_token" and the backend reason, not 403', async () => {
vi.spyOn(console, 'error').mockImplementation(() => {});
stubBackend(401, { error: 'Token signature is invalid', code: 'unauthorized' });
const out = await run(request());
expect(out.nextCalled).toBe(false);
expect(out.status).toBe(401);
expect(out.headers['WWW-Authenticate']).toContain('error="invalid_token"');
expect(out.headers['WWW-Authenticate']).toContain('oauth-protected-resource/mcp');
expect(out.body).toMatchObject({ error: 'Invalid token', reason: 'Token signature is invalid' });
});
it('caches the rejection per token: a replay costs no second backend call and stays 401', async () => {
vi.spyOn(console, 'error').mockImplementation(() => {});
const fetchMock = stubBackend(401, { error: 'Token expired' });
const req = request();
const first = await run(req);
const second = await run(req);
expect(first.status).toBe(401);
expect(second.status).toBe(401);
expect(second.headers['WWW-Authenticate']).toContain('error="invalid_token"');
expect(fetchMock).toHaveBeenCalledTimes(1);
});
it('keeps a 401 without an envelope body at 401 with a generic reason', async () => {
vi.spyOn(console, 'error').mockImplementation(() => {});
stubBackend(401, 'Unauthorized');
const out = await run(request());
expect(out.status).toBe(401);
expect(out.body).toMatchObject({ reason: 'The backend rejected the token' });
});
it('keeps a genuine authorization deny (200, allowed:false) at 403 without a challenge', async () => {
vi.spyOn(console, 'error').mockImplementation(() => {});
stubBackend(200, { allowed: false, upn: 'x', accessGrant: '', reason: 'not on the MCP allowlist' });
const out = await run(request());
expect(out.status).toBe(403);
expect(out.headers['WWW-Authenticate']).toBeUndefined();
});
});
describe('accessGuard — cancellation signal', () => {
it('hands the caller context a signal that fires when the client closes the request early', async () => {
stubBackend(200, { allowed: true, upn: 'x', accessGrant: 'ok' });
const out = await run(request());
expect(out.nextCalled).toBe(true);
expect(out.signal).toBeInstanceOf(AbortSignal);
expect(out.signal?.aborted).toBe(false);
out.close();
expect(out.signal?.aborted).toBe(true);
});
it('does not fire when the response completed normally before the socket closed', async () => {
stubBackend(200, { allowed: true, upn: 'x', accessGrant: 'ok' });
const out = await run(request());
out.res.writableFinished = true;
out.close();
expect(out.signal?.aborted).toBe(false);
});
});
@@ -45,6 +45,7 @@ function runGuard(req: Request): Promise<Outcome> {
setHeader() { return this as Response; },
status(code: number) { statusCode = code; return this as Response; },
json() { done({ nextCalled: false, status: statusCode }); return this as Response; },
on() { return this as Response; },
};
const next: NextFunction = () => done({ nextCalled: true, status: statusCode });
accessGuard(req, res as Response, next);
@@ -68,6 +68,10 @@ function mockRes(): CapturedRes {
captured.body = payload;
return this as Response;
},
// The guard subscribes to 'close' for the cancellation signal; nothing here ever emits it.
on() {
return this as Response;
},
};
captured.res = res as Response;
return captured;
@@ -0,0 +1,59 @@
/**
* Client cancellation reaches the backend: the caller context's signal (aborted by the access
* guard when the client closes the request) is folded into every apiFetch attempt and into the
* automatic 429/503 retry wait, so an abandoned tool call stops its backend work at once.
*/
import { describe, it, expect, vi, afterEach } from 'vitest';
import { apiFetch, runWithCaller } from '../client.js';
afterEach(() => vi.restoreAllMocks());
function caller(signal: AbortSignal) {
return { token: 'test-token', isGlobalAdmin: true, isGlobalReader: false, signal };
}
describe('apiFetch — caller cancellation', () => {
it("aborts the in-flight backend fetch when the caller's signal fires", async () => {
let seen: AbortSignal | undefined;
vi.spyOn(globalThis, 'fetch').mockImplementation((_url, init) => new Promise<Response>((_resolve, reject) => {
seen = init?.signal ?? undefined;
seen?.addEventListener('abort', () => reject(seen?.reason), { once: true });
}));
const controller = new AbortController();
const pending = runWithCaller(caller(controller.signal), () => apiFetch<unknown>('/api/sessions'));
expect(seen).toBeDefined();
expect(seen?.aborted).toBe(false);
controller.abort();
await expect(pending).rejects.toMatchObject({ name: 'AbortError' });
expect(seen?.aborted).toBe(true);
});
it('ends the automatic retry wait at once on cancellation instead of sleeping out Retry-After', async () => {
const fetchMock = vi.spyOn(globalThis, 'fetch').mockResolvedValue({
ok: false,
status: 429,
headers: { get: (name: string) => (name.toLowerCase() === 'retry-after' ? '5' : null) },
text: async () => '',
} as unknown as Response);
const controller = new AbortController();
const started = Date.now();
const pending = runWithCaller(caller(controller.signal), () => apiFetch<unknown>('/api/sessions'));
setTimeout(() => controller.abort(), 20);
await expect(pending).rejects.toMatchObject({ name: 'AbortError' });
expect(Date.now() - started).toBeLessThan(2000);
expect(fetchMock).toHaveBeenCalledTimes(1);
});
it('keeps the plain per-attempt timeout when the caller context carries no signal', async () => {
let seen: AbortSignal | undefined;
vi.spyOn(globalThis, 'fetch').mockImplementation(async (_url, init) => {
seen = init?.signal ?? undefined;
return { ok: true, status: 200, headers: { get: () => null }, text: async () => '{"ok":true}' } as unknown as Response;
});
await runWithCaller({ token: 'test-token', isGlobalAdmin: true }, () => apiFetch<unknown>('/api/sessions'));
expect(seen).toBeDefined();
expect(seen?.aborted).toBe(false);
});
});
@@ -0,0 +1,49 @@
/**
* The per-argument echo policy a tool declares at its withToolTelemetry call site governs BOTH
* sinks that quote the arguments: the tool_call log line and the "Parameters used" block of an
* error result (whose first lines the log quotes). Without this, a clear-text config value masked
* in the args summary still reached the container log through the error text.
*/
import { describe, it, expect } from 'vitest';
import { toolError } from '../tools/error-handler.js';
import { createToolCallContext, runWithToolCallContext } from '../client.js';
const TENANT = 'a1b2c3d4-e5f6-7890-abcd-ef1234567890';
const SECRET = 'https://hooks.example/services/secret-token-123';
function errorText(result: unknown): string {
return (result as { content: Array<{ text: string }> }).content[0].text;
}
describe('toolError — parameter echo honours the call\'s ArgPolicy', () => {
it("renders only the field NAMES of a 'keys' argument, so no config value enters the error text", () => {
const args = { tenantId: TENANT, fields: { teamsWebhookUrl: SECRET, dataRetentionDays: 4242 }, reason: 'rotate' };
const result = runWithToolCallContext(
createToolCallContext('update_tenant_config', 'cid', { fields: 'keys' }),
() => toolError('update_tenant_config', args, new Error('boom')),
);
const text = errorText(result);
expect(text).toContain('**Parameters used**');
expect(text).toContain('fields: teamsWebhookUrl,dataRetentionDays');
expect(text).toContain('reason: rotate');
expect(text).not.toContain(SECRET);
expect(text).not.toContain('4242');
});
it("omits a 'drop' argument entirely", () => {
const result = runWithToolCallContext(
createToolCallContext('t', 'cid', { secret: 'drop' }),
() => toolError('t', { secret: 'hunter2', q: 'x' }, new Error('boom')),
);
expect(errorText(result)).not.toContain('hunter2');
expect(errorText(result)).not.toContain('secret');
expect(errorText(result)).toContain('q: x');
});
it('renders values verbatim (size-capped) without a policy — the pre-existing behaviour', () => {
const text = errorText(toolError('search_sessions', { status: 'failed', pageSize: 50, days: null }, new Error('boom')));
expect(text).toContain('status: failed');
expect(text).toContain('pageSize: 50');
expect(text).not.toContain('days');
});
});
@@ -101,6 +101,7 @@ describe('revert_tenant_config — request shape', () => {
apiFetchMock.mockResolvedValueOnce({ success: true });
await captureToolHandlers(true, true).revert_tenant_config({
tenantId: TENANT,
backupId: '20260910T000000Z_abcd1234',
reason: 'undo bad change',
});
@@ -108,7 +109,7 @@ describe('revert_tenant_config — request shape', () => {
expect(path).toBe(`/api/config/${TENANT}/revert`);
expect(options.method).toBe('POST');
expect(JSON.parse(options.body as string)).toEqual({
backupId: undefined,
backupId: '20260910T000000Z_abcd1234',
includeProtectedFields: false,
reason: 'undo bad change',
});
@@ -0,0 +1,97 @@
/**
* The Origin gate in front of the dual-era MCP entry, driven over loopback HTTP the way index.ts
* mounts it (express.json → originGuard → handler): a foreign Origin is refused with 403 on a 2025
* initialize and on a 2026-07-28 request alike; the server's own origin and no Origin pass.
*/
import { describe, it, expect, beforeAll, afterAll, vi, afterEach } from 'vitest';
import express from 'express';
import type { Server } from 'node:http';
import { createMcpRequestHandler } from '../mcp-http.js';
import { createServerForCaller, type ServerDeps } from '../mcp-server-factory.js';
import { runWithCaller } from '../client.js';
import { originGuard } from '../origin-guard.js';
const DEPS: ServerDeps = { serverVersion: '0.0.0-test', knowledgeBase: undefined, eventTypeIndex: undefined, docs: undefined };
let httpServer: Server;
let url: URL;
beforeAll(async () => {
const app = express();
app.use('/mcp', express.json({ limit: '256kb' }));
app.use('/mcp', originGuard);
const handler = createMcpRequestHandler(() => createServerForCaller(DEPS), {});
app.post('/mcp', (req, res) =>
runWithCaller({ token: 'test-token', isGlobalAdmin: true, isGlobalReader: false, upn: 'caller@contoso.com' }, () => handler(req, res)),
);
await new Promise<void>((resolve) => {
httpServer = app.listen(0, '127.0.0.1', () => resolve());
});
const addr = httpServer.address();
if (typeof addr !== 'object' || addr === null) throw new Error('no address');
url = new URL(`http://127.0.0.1:${addr.port}/mcp`);
});
afterAll(async () => {
await new Promise<void>((resolve) => httpServer.close(() => resolve()));
});
afterEach(() => vi.restoreAllMocks());
const LEGACY_INITIALIZE = {
jsonrpc: '2.0',
id: 1,
method: 'initialize',
params: { protocolVersion: '2025-11-25', capabilities: {}, clientInfo: { name: 'origin-test', version: '1.0.0' } },
};
const MODERN_TOOLS_LIST = {
jsonrpc: '2.0',
id: 1,
method: 'tools/list',
params: {
_meta: {
'io.modelcontextprotocol/protocolVersion': '2026-07-28',
'io.modelcontextprotocol/clientInfo': { name: 'origin-test', version: '1.0.0' },
'io.modelcontextprotocol/clientCapabilities': {},
},
},
};
function post(body: unknown, headers: Record<string, string>): Promise<Response> {
return fetch(url, {
method: 'POST',
headers: { 'content-type': 'application/json', accept: 'application/json, text/event-stream', ...headers },
body: JSON.stringify(body),
});
}
describe('Origin gate on /mcp — both protocol eras', () => {
it('refuses a foreign Origin on a 2025 initialize: 403 + JSON-RPC error without id, and a log line', async () => {
const log = vi.spyOn(console, 'error').mockImplementation(() => {});
const res = await post(LEGACY_INITIALIZE, { origin: 'https://attacker.example' });
expect(res.status).toBe(403);
expect(await res.json()).toMatchObject({ jsonrpc: '2.0', error: { code: -32600 }, id: null });
expect(log).toHaveBeenCalledWith(expect.stringContaining('403 origin-rejected origin=https://attacker.example method=initialize'));
});
it('refuses a foreign Origin on a 2026-07-28 request', async () => {
vi.spyOn(console, 'error').mockImplementation(() => {});
const res = await post(MODERN_TOOLS_LIST, {
origin: 'https://attacker.example',
'mcp-protocol-version': '2026-07-28',
'mcp-method': 'tools/list',
});
expect(res.status).toBe(403);
});
it("serves the server's own origin", async () => {
const res = await post(LEGACY_INITIALIZE, { origin: url.origin, 'mcp-protocol-version': '2025-11-25' });
expect(res.status).toBe(200);
});
it('serves a request without Origin (every non-browser client)', async () => {
const res = await post(LEGACY_INITIALIZE, { 'mcp-protocol-version': '2025-11-25' });
expect(res.status).toBe(200);
});
});
@@ -0,0 +1,36 @@
/**
* OAuthStateSigningKey boot guard: production refuses to boot without the key (the signed
* client_ids and the OAuth state derive from it and must survive restarts and replicas); the
* per-process random fallback exists for development and tests only; a short key fails everywhere.
*/
import { describe, it, expect } from 'vitest';
// oauth.ts throws at import unless the Entra client id is present.
process.env.AUTOPILOT_ENTRA_CLIENT_ID ??= '00000000-0000-0000-0000-000000000000';
const { loadSigningKey } = await import('../oauth.js');
const KEY = Buffer.alloc(32, 7).toString('base64');
describe('loadSigningKey', () => {
it('decodes a valid base64 key of 32+ bytes in production', () => {
expect(loadSigningKey(KEY, 'production').length).toBe(32);
});
it('refuses to boot in production without a key', () => {
expect(() => loadSigningKey(undefined, 'production')).toThrow('OAuthStateSigningKey is not set');
expect(() => loadSigningKey('', 'production')).toThrow('OAuthStateSigningKey is not set');
});
it('falls back to a fresh random key outside production', () => {
const a = loadSigningKey(undefined, 'test');
const b = loadSigningKey(undefined, undefined);
expect(a.length).toBe(32);
expect(b.length).toBe(32);
expect(a.equals(b)).toBe(false);
});
it('rejects a key shorter than 32 bytes in every environment', () => {
expect(() => loadSigningKey(Buffer.alloc(16).toString('base64'), 'test')).toThrow('32 bytes');
expect(() => loadSigningKey('not base64 at all', 'production')).toThrow('32 bytes');
});
});
@@ -0,0 +1,61 @@
/**
* /oauth/token relays Entra's error body through an allowlist: the OAuth error code, the human
* message (cut before the trace-id tail, capped) and the numeric AADSTS codes. Trace, correlation,
* timestamp, error_uri and claims never reach an unauthenticated caller (review R-5).
*/
import { describe, it, expect } from 'vitest';
// oauth.ts throws at import unless the Entra client id is present.
process.env.AUTOPILOT_ENTRA_CLIENT_ID ??= '00000000-0000-0000-0000-000000000000';
const { sanitizeTokenErrorBody } = await import('../oauth.js');
const ENTRA_INVALID_GRANT = {
error: 'invalid_grant',
error_description:
'AADSTS70008: The provided authorization code or refresh token has expired due to inactivity. ' +
'Send a new interactive authorization request for this user and resource. Trace ID: 5d1a2b3c-0000-4000-8000-000000000000\r\n' +
'Correlation ID: 7e9f0a1b-0000-4000-8000-000000000000\r\nTimestamp: 2026-09-10 00:00:00Z',
error_codes: [70008],
timestamp: '2026-09-10 00:00:00Z',
trace_id: '5d1a2b3c-0000-4000-8000-000000000000',
correlation_id: '7e9f0a1b-0000-4000-8000-000000000000',
error_uri: 'https://login.microsoftonline.com/error?code=70008',
claims: '{"access_token":{"capolids":{"essential":true,"values":["x"]}}}',
};
describe('sanitizeTokenErrorBody', () => {
it('keeps the OAuth error, the message before the trace tail, and the numeric codes only', () => {
expect(sanitizeTokenErrorBody(ENTRA_INVALID_GRANT)).toEqual({
error: 'invalid_grant',
error_description:
'AADSTS70008: The provided authorization code or refresh token has expired due to inactivity. ' +
'Send a new interactive authorization request for this user and resource.',
error_codes: [70008],
});
});
it('never carries trace, correlation, timestamp, error_uri or claims', () => {
const out = sanitizeTokenErrorBody(ENTRA_INVALID_GRANT);
for (const key of ['trace_id', 'correlation_id', 'timestamp', 'error_uri', 'claims']) expect(out).not.toHaveProperty(key);
expect(JSON.stringify(out)).not.toContain('5d1a2b3c');
expect(JSON.stringify(out)).not.toContain('7e9f0a1b');
});
it('maps an unknown error code to invalid_request', () => {
expect(sanitizeTokenErrorBody({ error: 'something_entra_specific', error_description: 'x' }).error).toBe('invalid_request');
});
it('caps a long description', () => {
const out = sanitizeTokenErrorBody({ error: 'invalid_request', error_description: 'y'.repeat(1000) });
expect((out.error_description as string).length).toBe(303);
expect(out.error_description as string).toMatch(/\.\.\.$/);
});
it('tolerates a non-object body and non-numeric codes', () => {
expect(sanitizeTokenErrorBody('not json')).toEqual({ error: 'invalid_request' });
expect(sanitizeTokenErrorBody({ error: 'invalid_client', error_codes: ['7000218', 7000218] })).toEqual({
error: 'invalid_client',
error_codes: [7000218],
});
});
});
@@ -0,0 +1,91 @@
/**
* Origin gate on /mcp (spec 2026-07-28 Streamable HTTP "Security & Endpoint": a present, invalid
* Origin MUST be answered 403). Non-browser clients send no Origin and pass; only the server's own
* origin passes with one; everything else — foreign hosts, scheme downgrades, suffix tricks, the
* opaque `null` — is refused before any token work.
*/
import { describe, it, expect, vi, afterEach } from 'vitest';
import type { Request, Response } from 'express';
import { isAllowedOrigin, originGuard } from '../origin-guard.js';
const SELF = 'https://mcp.example.com';
describe('isAllowedOrigin', () => {
it('passes a request without Origin (every non-browser MCP client)', () => {
expect(isAllowedOrigin(undefined, SELF)).toBe(true);
});
it("accepts the server's own origin, port-normalised and case-insensitive on the host", () => {
expect(isAllowedOrigin('https://mcp.example.com', SELF)).toBe(true);
expect(isAllowedOrigin('https://MCP.example.com:443', SELF)).toBe(true);
});
it.each([
'https://evil.example',
'http://mcp.example.com',
'https://mcp.example.com.evil.example',
'https://mcp.example.com:8443',
'null',
'not a url',
'',
])('rejects a present, invalid Origin: %j', (origin) => {
expect(isAllowedOrigin(origin, SELF)).toBe(false);
});
});
describe('originGuard middleware', () => {
afterEach(() => vi.restoreAllMocks());
function run(origin?: string) {
const req = {
headers: { host: 'mcp.example.com', ...(origin !== undefined ? { origin } : {}) },
protocol: 'https',
body: { jsonrpc: '2.0', method: 'tools/list', id: 1 },
} as unknown as Request;
let status: number | null = null;
let body: unknown;
const res = {
status(code: number) { status = code; return this; },
json(payload: unknown) { body = payload; return this; },
} as unknown as Response;
const next = vi.fn();
originGuard(req, res, next);
return { status: status as number | null, body, next };
}
it('lets a request without Origin through untouched', () => {
const { status, next } = run();
expect(next).toHaveBeenCalledOnce();
expect(status).toBeNull();
});
it("lets the server's own origin through", () => {
const { status, next } = run('https://mcp.example.com');
expect(next).toHaveBeenCalledOnce();
expect(status).toBeNull();
});
it('answers 403 with a JSON-RPC error without id for a foreign origin, and logs it', () => {
const log = vi.spyOn(console, 'error').mockImplementation(() => {});
const { status, body, next } = run('https://attacker.example');
expect(next).not.toHaveBeenCalled();
expect(status).toBe(403);
expect(body).toEqual({ jsonrpc: '2.0', error: { code: -32600, message: 'Origin not allowed' }, id: null });
expect(log).toHaveBeenCalledWith(expect.stringContaining('[mcp-auth] 403 origin-rejected origin=https://attacker.example method=tools/list'));
});
it('treats the opaque "null" origin as present and invalid', () => {
vi.spyOn(console, 'error').mockImplementation(() => {});
const { status, next } = run('null');
expect(next).not.toHaveBeenCalled();
expect(status).toBe(403);
});
it('renders a hostile origin value log-safe (control characters replaced, length capped)', () => {
const log = vi.spyOn(console, 'error').mockImplementation(() => {});
run('https://x.example/\r\nINJECTED' + 'a'.repeat(500));
const line = log.mock.calls[0][0] as string;
expect(line).not.toContain('\n');
expect(line.length).toBeLessThan(320);
});
});
@@ -0,0 +1,123 @@
/**
* query_raw_events pageSize follows the effective projection: a page that carries DataJson is
* bounded by rows × payload (measured p90 3.3 KB, outliers 21-29 KB per row), so it gets a
* smaller default and a ceiling of 100, refused BEFORE the backend does the work; a lean page
* keeps the schema's 1000. A nextLink is judged by its echoed fields.
*
* The handler reaches the backend through scanWithTimeoutFallback (client.ts), so that is the
* seam the test observes: its first argument is the path the backend would receive.
*/
import { describe, it, expect, beforeEach, vi } from 'vitest';
const { scanMock } = vi.hoisted(() => ({ scanMock: vi.fn() }));
vi.mock('../client.js', async (importOriginal) => {
const actual = await importOriginal<typeof import('../client.js')>();
return { ...actual, scanWithTimeoutFallback: scanMock };
});
import { registerAdminTools, rawEventsPayloadIncluded, RAW_EVENTS_PAYLOAD_PAGE_DEFAULT, RAW_EVENTS_PAYLOAD_PAGE_MAX } from '../tools/admin.js';
import { DEFAULT_FIRST_PAGE_SIZE } from '../client.js';
type Handler = (args: Record<string, unknown>) => Promise<{ content: Array<{ text: string }>; isError?: boolean }>;
function queryRawEvents(): Handler {
const handlers: Record<string, Handler> = {};
const fake = { registerTool: (name: string, _def: unknown, handler: Handler) => { handlers[name] = handler; } };
registerAdminTools(fake as never, true, true, false);
return handlers.query_raw_events;
}
const PAGE = { count: 1, events: [{ EventType: 'app_install_failed' }] };
function sentPath(): string {
return scanMock.mock.calls[0][0] as string;
}
function sentPageSize(): string | null {
const path = sentPath();
return new URLSearchParams(path.slice(path.indexOf('?') + 1)).get('pageSize');
}
const FULL_ROWS_NEXTLINK = '/api/raw/events?eventType=app_install_failed&pageSize=1000&continuation=c1';
const LEAN_NEXTLINK = '/api/raw/events?eventType=app_install_failed&fields=EventType%2CSeverity%2COccurredUtc&pageSize=1000&continuation=c1';
describe('rawEventsPayloadIncluded', () => {
it('follows an explicit fields list, case-insensitively', () => {
expect(rawEventsPayloadIncluded('PartitionKey,DataJson', undefined, false)).toBe(true);
expect(rawEventsPayloadIncluded('EventType, datajson', undefined, false)).toBe(true);
expect(rawEventsPayloadIncluded('EventType,Message', undefined, true)).toBe(false);
});
it('a filtered first page without fields carries the payload; an unfiltered one is lean by default', () => {
expect(rawEventsPayloadIncluded(undefined, undefined, true)).toBe(true);
expect(rawEventsPayloadIncluded(undefined, undefined, false)).toBe(false);
});
it('judges a nextLink by its echoed fields — none echoed means full rows', () => {
expect(rawEventsPayloadIncluded(undefined, FULL_ROWS_NEXTLINK, false)).toBe(true);
expect(rawEventsPayloadIncluded(undefined, LEAN_NEXTLINK, false)).toBe(false);
expect(rawEventsPayloadIncluded(undefined, '/api/raw/events?fields=EventType%2CDataJson&continuation=c1', false)).toBe(true);
});
});
describe('query_raw_events — pageSize follows the payload projection', () => {
beforeEach(() => {
scanMock.mockReset();
scanMock.mockResolvedValue(PAGE);
});
it('refuses pageSize 1000 on a filtered read (full rows) before any backend call', async () => {
const result = await queryRawEvents()({ eventType: 'app_install_failed', pageSize: 1000 });
expect(result.isError).toBe(true);
expect(result.content[0].text).toContain(`exceeds the maximum of ${RAW_EVENTS_PAYLOAD_PAGE_MAX}`);
expect(scanMock).not.toHaveBeenCalled();
});
it('refuses an explicit DataJson projection above the ceiling', async () => {
const result = await queryRawEvents()({ fields: 'EventType,DataJson', pageSize: RAW_EVENTS_PAYLOAD_PAGE_MAX + 1 });
expect(result.isError).toBe(true);
expect(scanMock).not.toHaveBeenCalled();
});
it('accepts the ceiling itself with the payload', async () => {
const result = await queryRawEvents()({ eventType: 'app_install_failed', pageSize: RAW_EVENTS_PAYLOAD_PAGE_MAX });
expect(result.isError).toBeUndefined();
expect(sentPageSize()).toBe(String(RAW_EVENTS_PAYLOAD_PAGE_MAX));
});
it('keeps the large page for a lean projection', async () => {
const result = await queryRawEvents()({ eventType: 'app_install_failed', fields: 'EventType,Severity,OccurredUtc', pageSize: 1000 });
expect(result.isError).toBeUndefined();
expect(sentPageSize()).toBe('1000');
});
it('defaults a payload page to the smaller size and a lean page to the tool default', async () => {
await queryRawEvents()({ eventType: 'app_install_failed' });
expect(sentPageSize()).toBe(String(RAW_EVENTS_PAYLOAD_PAGE_DEFAULT));
scanMock.mockClear();
await queryRawEvents()({});
expect(sentPageSize()).toBe(String(DEFAULT_FIRST_PAGE_SIZE));
});
it('refuses a nextLink whose embedded pageSize exceeds the ceiling for full rows', async () => {
const result = await queryRawEvents()({ continuation: FULL_ROWS_NEXTLINK });
expect(result.isError).toBe(true);
expect(result.content[0].text).toContain('overrides the value embedded in a nextLink');
expect(scanMock).not.toHaveBeenCalled();
});
it('lets an explicit smaller pageSize override the nextLink and pass', async () => {
const result = await queryRawEvents()({ continuation: FULL_ROWS_NEXTLINK, pageSize: RAW_EVENTS_PAYLOAD_PAGE_MAX });
expect(result.isError).toBeUndefined();
expect(sentPath()).toContain('continuation=c1');
expect(sentPageSize()).toBe(String(RAW_EVENTS_PAYLOAD_PAGE_MAX));
});
it('keeps the embedded 1000 of a lean nextLink', async () => {
const result = await queryRawEvents()({ continuation: LEAN_NEXTLINK });
expect(result.isError).toBeUndefined();
expect(sentPageSize()).toBe('1000');
});
});
@@ -0,0 +1,41 @@
/**
* revert_tenant_config takes an explicit backupId — no "latest" default. Every revert snapshots
* the current state first, so a retried revert without an id would restore the snapshot the
* previous revert had just created and undo it. With a fixed id the same call is a no-op twice.
*/
import { describe, it, expect, vi } from 'vitest';
import { z } from 'zod';
vi.mock('../client.js', async (importOriginal) => ({
...(await importOriginal<typeof import('../client.js')>()),
apiFetch: vi.fn(),
}));
import { registerAdminTools } from '../tools/admin.js';
interface ToolDef { description: string; inputSchema: Record<string, z.ZodTypeAny> }
function definitionOf(tool: string): ToolDef {
let found: ToolDef | undefined;
const fake = { registerTool: (name: string, def: ToolDef) => { if (name === tool) found = def; } };
registerAdminTools(fake as never, true, true, false);
if (!found) throw new Error(`${tool} not registered`);
return found;
}
const TENANT = 'a1b2c3d4-e5f6-7890-abcd-ef1234567890';
describe('revert_tenant_config — backupId is required', () => {
it('rejects a revert without backupId or with an empty one; accepts a named snapshot', () => {
const schema = z.object(definitionOf('revert_tenant_config').inputSchema);
expect(schema.safeParse({ tenantId: TENANT, reason: 'undo' }).success).toBe(false);
expect(schema.safeParse({ tenantId: TENANT, reason: 'undo', backupId: '' }).success).toBe(false);
expect(schema.safeParse({ tenantId: TENANT, reason: 'undo', backupId: '20260910T000000Z_abcd1234' }).success).toBe(true);
});
it('explains the rule in the description and no longer advertises a latest default', () => {
const { description } = definitionOf('revert_tenant_config');
expect(description).toContain('backupId is required');
expect(description).not.toContain('latest by default');
});
});
@@ -113,6 +113,58 @@ describe('gather guardrails (agent matching semantics)', () => {
expect(errors(validateRuleDraft(bad).findings).some((m) => m.includes('hard-blocked'))).toBe(true);
});
// %LOGGED_ON_USER_PROFILE% releases the C:\Users hard block for AppData\Local and
// AppData\Roaming — and only releases it. The allowlist still decides, which is what
// the agent does (GatherRuleGuards.IsFilePathAllowed) and what the portal shows.
it('accepts a userProfileFilePrefixes folder below %LOGGED_ON_USER_PROFILE%', () => {
const ok = validGather();
ok.collectorType = 'logparser';
ok.target = '%LOGGED_ON_USER_PROFILE%\\AppData\\Local\\RealmJoin\\tray*.log';
ok.parameters = { pattern: '(?<msg>SSO)', format: 'text' };
expect(errors(validateRuleDraft(ok).findings).some((m) => m.includes('guardrails'))).toBe(false);
});
it('rejects an unlisted vendor folder below %LOGGED_ON_USER_PROFILE%\\AppData', () => {
const bad = validGather();
bad.collectorType = 'file';
bad.target = '%LOGGED_ON_USER_PROFILE%\\AppData\\Local\\SomeApp\\data.json';
expect(errors(validateRuleDraft(bad).findings).some((m) => m.includes('not under any allowed file prefix'))).toBe(true);
});
it('rejects %LOGGED_ON_USER_PROFILE% outside AppData as hard-blocked', () => {
const bad = validGather();
bad.collectorType = 'file';
bad.target = '%LOGGED_ON_USER_PROFILE%\\Documents\\secret.txt';
expect(errors(validateRuleDraft(bad).findings).some((m) => m.includes('hard-blocked'))).toBe(true);
});
it('rejects a sibling of a userProfileFilePrefixes folder (segment boundary)', () => {
const bad = validGather();
bad.collectorType = 'file';
bad.target = '%LOGGED_ON_USER_PROFILE%\\AppData\\Local\\RealmJoinEvil\\tray.log';
expect(validateRuleDraft(bad).valid).toBe(false);
});
// The agent expands environment variables before guarding, so a target spelled with
// %ProgramData% must not be reported as blocked — there are live rules doing this.
it('accepts an allow-listed path spelled with %ProgramData%', () => {
const ok = validGather();
ok.collectorType = 'logparser';
ok.target = '%ProgramData%\\Microsoft\\IntuneManagementExtension\\Logs\\HPReports\\HP Image Assistant.log';
ok.parameters = { pattern: '(?<msg>x)', format: 'text' };
expect(errors(validateRuleDraft(ok).findings).some((m) => m.includes('guardrails'))).toBe(false);
});
// diagnosticsPathPrefixes governs admin-configured diagnostics paths, not collectors:
// the agent guards logparser against filePrefixes alone.
it('rejects a logparser target that only diagnosticsPathPrefixes would allow', () => {
const bad = validGather();
bad.collectorType = 'logparser';
bad.target = 'C:\\Install\\Log\\setup.log';
bad.parameters = { pattern: '(?<msg>x)', format: 'text' };
expect(errors(validateRuleDraft(bad).findings).some((m) => m.includes('not under any allowed file prefix'))).toBe(true);
});
it('rejects the registry-hive store path (System32\\config) as hard-blocked', () => {
const bad = validGather();
bad.collectorType = 'file';
@@ -254,6 +254,36 @@ describe('buildSessionCoverage — diagnostics package', () => {
});
});
describe('buildSessionCoverage — apps without a terminal state', () => {
// The shutdown emit of the termination handler: what was still in flight when the agent left.
const shutdownSummary = ev('app_tracking_summary', 900, { installingNames: ['Suite'], downloadingNames: [], pendingNames: ['Other'] });
it("names the apps still in flight in the agent's last summary on a terminal session", () => {
const c = buildSessionCoverage({ startedAt: at(0), status: 'Succeeded' }, [
ev('agent_started', 5),
ev('app_tracking_summary', 300, { installingNames: ['Early'], downloadingNames: ['Later'] }),
shutdownSummary,
]);
expect(c.apps).toEqual({ stillInstalling: ['Suite'], stillDownloading: [] });
expect(c.gaps).toEqual([expect.stringContaining('1 app(s) still installing when the agent stopped observing (Suite)')]);
});
it('reports nothing while the session is still live, even with apps in flight', () => {
const c = buildSessionCoverage({ startedAt: at(0), status: 'InProgress' }, [ev('agent_started', 5), shutdownSummary]);
expect(c.apps).toEqual({ stillInstalling: [], stillDownloading: [] });
expect(c.gaps).toEqual([]);
});
it("stays silent when the last summary has nothing in flight (apps that never started are the starved rule's finding)", () => {
const c = buildSessionCoverage({ startedAt: at(0), status: 'Failed' }, [
ev('agent_started', 5),
ev('app_tracking_summary', 900, { installingNames: [], pendingNames: ['Other'] }),
]);
expect(c.apps).toEqual({ stillInstalling: [], stillDownloading: [] });
expect(c.gaps).toEqual([]);
});
});
describe('coverage wiring', () => {
it('SUMMARY_EVENT_FIELDS carries every coverage slice, as data.<key> entries only', () => {
const fields = SUMMARY_EVENT_FIELDS.split(',');
@@ -271,6 +301,7 @@ describe('coverage wiring', () => {
'agent_started', 'agent_late_start', 'historic_ime_replay_detected', 'ime_tracker_degraded', 'ime_pattern_hits',
'collector_degraded', 'spool_pressure_detected', 'telemetry_upload_poisoned', 'telemetry_upload_blocked',
'ingress_backpressure', 'disk_space_low', 'diagnostics_collecting', 'diagnostics_uploaded', 'diagnostics_upload_failed',
'app_tracking_summary',
];
expect([...COVERAGE_EVENT_TYPES].sort()).toEqual([...consulted].sort());
});
@@ -0,0 +1,66 @@
/**
* The tool_call line under the two 2026-09-10 result contracts: an overflow answer (page refused
* by toolResultText) is logged at the size the page WOULD have had and as overCap; a call the
* client abandoned is logged as cancelled, never as an error.
*/
import { describe, it, expect, vi, afterEach } from 'vitest';
async function loadTelemetry() {
vi.resetModules();
vi.stubEnv('MCP_TOOL_LOGGING', 'true');
return await import('../telemetry.js');
}
function lastLoggedJson(spy: ReturnType<typeof vi.spyOn>): Record<string, unknown> {
expect(spy).toHaveBeenCalled();
return JSON.parse(spy.mock.calls[spy.mock.calls.length - 1][0] as string) as Record<string, unknown>;
}
afterEach(() => {
vi.unstubAllEnvs();
vi.restoreAllMocks();
});
describe('withToolTelemetry — overflow and cancellation', () => {
it('logs an overflow answer at the size the page would have had, as overCap and isError', async () => {
const { withToolTelemetry } = await loadTelemetry();
const { toolResultText } = await import('../tools/shared.js');
const spy = vi.spyOn(console, 'error').mockImplementation(() => {});
const page = { events: Array.from({ length: 50 }, (_, i) => ({ i, payload: 'x'.repeat(200) })) };
const result = await withToolTelemetry('query_raw_events', { eventType: 'x' }, () => toolResultText(page, 1_000));
expect(result.isError).toBe(true);
const line = lastLoggedJson(spy);
expect(line.overCap).toBe(true);
expect(line.isError).toBe(true);
expect(line.resultChars).toBe(JSON.stringify(page).length);
expect(String(line.errorMessage)).toContain('"overflow":true');
});
it('logs a call the client abandoned as cancelled, not as an error', async () => {
const { withToolTelemetry } = await loadTelemetry();
const { runWithCaller } = await import('../client.js');
const spy = vi.spyOn(console, 'error').mockImplementation(() => {});
const controller = new AbortController();
await runWithCaller({ token: 't', isGlobalAdmin: true, signal: controller.signal }, () =>
withToolTelemetry('get_session', { sessionId: 's' }, () => {
controller.abort();
return { isError: true, content: [{ type: 'text', text: '**Timeout in get_session**' }] };
}),
);
const line = lastLoggedJson(spy);
expect(line.cancelled).toBe(true);
expect(line.isError).toBe(false);
expect(line.errorMessage).toBeUndefined();
});
it('leaves a completed call without a cancelled field', async () => {
const { withToolTelemetry } = await loadTelemetry();
const spy = vi.spyOn(console, 'error').mockImplementation(() => {});
await withToolTelemetry('get_session', { sessionId: 's' }, () => ({ content: [{ type: 'text', text: '{}' }] }));
expect(lastLoggedJson(spy)).not.toHaveProperty('cancelled');
});
});
@@ -0,0 +1,83 @@
/**
* The response-size cap is enforced, not advisory: a page above the tool's cap is never sent —
* the answer is an error naming what the page held and the exact pageSize that fits, computed from
* THIS page's bytes per row. The oversized page's nextLink is withheld (following it would skip
* rows), and the telemetry marker carries the size the page would have had.
*/
import { describe, it, expect } from 'vitest';
import { toolResultText, OVERFLOW_META_KEY } from '../tools/shared.js';
const CAP = 10_000;
function rows(n: number, payloadChars: number): Array<{ id: number; payload: string }> {
return Array.from({ length: n }, (_, i) => ({ id: i, payload: 'x'.repeat(payloadChars) }));
}
function bodyOf(result: { content: Array<{ text: string }> }): Record<string, unknown> {
return JSON.parse(result.content[0].text) as Record<string, unknown>;
}
describe('toolResultText — hard cap', () => {
it('sends a page under the cap unchanged, with the size hint and no overflow marker', () => {
const data = { count: 3, events: rows(3, 100), nextLink: '/api/x?continuation=abc' };
const r = toolResultText(data, CAP);
expect(r.isError).toBeUndefined();
expect(bodyOf(r)).toEqual(data);
expect(r._meta['anthropic/maxResultSizeChars']).toBe(CAP);
expect(r._meta[OVERFLOW_META_KEY]).toBeUndefined();
});
it('refuses a page over the cap: no rows, no nextLink, the pageSize that fits, the marker', () => {
const data = { count: 100, events: rows(100, 500), nextLink: '/api/x?continuation=abc' };
const chars = JSON.stringify(data).length;
const r = toolResultText(data, CAP);
expect(r.isError).toBe(true);
const body = bodyOf(r);
expect(body.overflow).toBe(true);
expect(body.responseChars).toBe(chars);
expect(body.maxResultSizeChars).toBe(CAP);
expect(body.rowsField).toBe('events');
expect(body.rowsFetched).toBe(100);
expect(body.rowsThatFit).toBe(Math.floor((CAP * 0.9) / (chars / 100)));
expect(body.rowsThatFit as number).toBeGreaterThanOrEqual(1);
expect(body.rowsThatFit as number).toBeLessThan(100);
expect(body.events).toBeUndefined();
expect(body.nextLink).toBeUndefined();
expect(body.advice).toContain(`pageSize=${body.rowsThatFit}`);
expect(r.content[0].text.length).toBeLessThan(CAP);
expect(r._meta[OVERFLOW_META_KEY]).toEqual({ responseChars: chars });
expect(r._meta['anthropic/maxResultSizeChars']).toBe(CAP);
});
it('gives an honest advice: a re-send at rowsThatFit lands under the cap', () => {
const fit = bodyOf(toolResultText({ events: rows(100, 500) }, CAP)).rowsThatFit as number;
const again = toolResultText({ events: rows(fit, 500) }, CAP);
expect(again.isError).toBeUndefined();
});
it('never advises fewer than one row', () => {
const body = bodyOf(toolResultText({ events: rows(2, CAP) }, CAP));
expect(body.rowsThatFit).toBe(1);
});
it('gives only narrowing advice when the page carries no list', () => {
const body = bodyOf(toolResultText({ blob: 'x'.repeat(CAP + 1) }, CAP));
expect(body.overflow).toBe(true);
expect(body.rowsThatFit).toBeUndefined();
expect(body.rowsField).toBeUndefined();
expect(body.advice).toContain('Narrow the query');
});
it('does not project a pageSize from a one-element list (the KQL tables[] shape)', () => {
const body = bodyOf(toolResultText({ tables: [{ name: 'PrimaryResult', rows: rows(50, 300) }] }, CAP));
expect(body.overflow).toBe(true);
expect(body.rowsThatFit).toBeUndefined();
});
it('picks the largest top-level list when a page carries several', () => {
const body = bodyOf(toolResultText({ warnings: ['a', 'b'], sessions: rows(60, 400) }, CAP));
expect(body.rowsField).toBe('sessions');
expect(body.rowsFetched).toBe(60);
});
});
@@ -110,6 +110,8 @@ describe('role catalog snapshot — privilege-leak guard', () => {
// fails — that failure is the deliberate prompt to decide its role placement.
const GA_FULL = [
'annotate_session',
// Community rule submission write surface (strictGa): operator hard delete.
'delete_rule_submission',
'get_agent_efficiency_metrics',
'get_api_usage',
'get_app_install_metrics',
@@ -132,6 +134,8 @@ describe('role catalog snapshot — privilege-leak guard', () => {
'get_platform_metrics',
'get_resource',
'get_rule_stats',
// Platform scope (GA + Global Reader): one community rule submission with its frozen rule.
'get_rule_submission',
'get_session',
'get_session_diagnostics',
'get_session_events',
@@ -151,6 +155,8 @@ describe('role catalog snapshot — privilege-leak guard', () => {
'get_verdict_calibration',
'get_vulnerability_summary',
'list_blocked_devices',
// Platform scope (GA + Global Reader): community rule submissions across tenants.
'list_rule_submissions',
'list_session_annotations',
'list_session_reports',
'list_tables',
@@ -162,7 +168,10 @@ describe('role catalog snapshot — privilege-leak guard', () => {
'query_raw_events',
'query_raw_sessions',
'query_table',
// Community rule submission write surface (strictGa): the publish step and the decision.
'reseed_rules_from_github',
'revert_tenant_config',
'review_rule_submission',
'search_events',
'search_knowledge',
'search_sessions',
@@ -200,12 +209,17 @@ describe('role catalog snapshot — privilege-leak guard', () => {
// reads annotations (list_session_annotations) but never writes the GA lane.
const ANNOTATION_WRITE_GA_STRICT = ['annotate_session'];
// Community rule submission write surface: strictGa only — a read-only Global Reader
// lists and reads submissions but never decides one or triggers the reseed that publishes.
const RULE_SUBMISSION_WRITE_GA_STRICT = ['delete_rule_submission', 'reseed_rules_from_github', 'review_rule_submission'];
// Platform-only tools: a non-platform caller (tenant or delegated) gets no
// cross-fleet aggregate surface at all. Superset of RAW_GA_STRICT and
// CONFIG_WRITE_GA_STRICT (those are also platform-only) plus the curated
// cross-tenant aggregates.
const PLATFORM_ONLY = [
'annotate_session',
'delete_rule_submission',
'get_agent_efficiency_metrics',
'get_api_usage',
'get_deployment_state',
@@ -213,11 +227,13 @@ describe('role catalog snapshot — privilege-leak guard', () => {
'get_ime_pattern_health',
'get_ops_events',
'get_platform_metrics',
'get_rule_submission',
'get_session_report_download',
'get_tenant_config',
'get_tenant_config_schema',
'get_verdict_calibration',
'list_blocked_devices',
'list_rule_submissions',
'list_session_annotations',
'list_session_reports',
'list_tables',
@@ -225,7 +241,9 @@ describe('role catalog snapshot — privilege-leak guard', () => {
'list_tenants',
'query_backend_logs',
'query_table',
'reseed_rules_from_github',
'revert_tenant_config',
'review_rule_submission',
'update_tenant_config',
];
@@ -246,7 +264,7 @@ describe('role catalog snapshot — privilege-leak guard', () => {
it('Global Reader = GA minus the secret-bearing raw tools, the config-write surface and the annotation write (strictGa split)', () => {
expect(registeredToolNames(true, false)).toEqual(
without(GA_FULL, [...RAW_GA_STRICT, ...CONFIG_WRITE_GA_STRICT, ...ANNOTATION_WRITE_GA_STRICT]));
without(GA_FULL, [...RAW_GA_STRICT, ...CONFIG_WRITE_GA_STRICT, ...ANNOTATION_WRITE_GA_STRICT, ...RULE_SUBMISSION_WRITE_GA_STRICT]));
});
it('tenant user = GA minus all platform-only tools', () => {
@@ -265,6 +283,7 @@ describe('role catalog snapshot — privilege-leak guard', () => {
['RAW_GA_STRICT', RAW_GA_STRICT],
['CONFIG_WRITE_GA_STRICT', CONFIG_WRITE_GA_STRICT],
['ANNOTATION_WRITE_GA_STRICT', ANNOTATION_WRITE_GA_STRICT],
['RULE_SUBMISSION_WRITE_GA_STRICT', RULE_SUBMISSION_WRITE_GA_STRICT],
['PLATFORM_ONLY', PLATFORM_ONLY],
['DELEGATED_HIDDEN', DELEGATED_HIDDEN],
['DELEGATED_ADDED', DELEGATED_ADDED],
@@ -282,7 +301,7 @@ describe('role catalog snapshot — privilege-leak guard', () => {
const registeredDiff = registeredToolNames(true, true).filter((n) => !readerNames.includes(n)).sort();
expect([...GA_STRICT_TOOL_NAMES].sort()).toEqual(registeredDiff);
expect([...GA_STRICT_TOOL_NAMES].sort()).toEqual(
[...RAW_GA_STRICT, ...CONFIG_WRITE_GA_STRICT, ...ANNOTATION_WRITE_GA_STRICT].sort());
[...RAW_GA_STRICT, ...CONFIG_WRITE_GA_STRICT, ...ANNOTATION_WRITE_GA_STRICT, ...RULE_SUBMISSION_WRITE_GA_STRICT].sort());
});
it('the secret-bearing raw tools are a subset of the platform-only tools', () => {
@@ -89,6 +89,9 @@ interface AccessCacheEntry {
// scope and downgrade the caller to home-tenant-only routing.
delegatedTenantIds?: string[];
delegatedRole?: string;
// The backend refused the TOKEN itself (401) — cached like a deny so a replayed bad token costs
// one backend call per TTL, but answered 401 + challenge, never "not enabled".
unauthenticated?: boolean;
expiresAt: number;
}
@@ -109,6 +112,11 @@ interface AccessCheckResult {
// routing bounded to this set; every delegated tool call must name one of these tenants.
delegatedTenantIds?: string[];
delegatedRole?: string;
// The backend — the only party holding the JWKS — rejected the token (signature, issuer,
// audience, lifetime). That is "invalid token": the spec says it MUST be answered 401 with a
// WWW-Authenticate challenge so the client re-authenticates, not 403 ("insufficient
// permissions"), which a client reads as final.
unauthenticated?: boolean;
// Distinguishes a genuine authorization denial (the backend reached a verdict
// and said "no" — e.g. user not on the MCP whitelist) from an infrastructure
// failure (backend unreachable / malformed response). Both fail closed, but
@@ -161,6 +169,7 @@ async function checkAccess(upn: string, token: string, clientIp: string): Promis
isGlobalReader: cached.isGlobalReader,
delegatedTenantIds: cached.delegatedTenantIds,
delegatedRole: cached.delegatedRole,
unauthenticated: cached.unauthenticated,
// Only genuine backend verdicts are ever cached (infra errors return early
// below without caching), so a cache hit is never an infra error.
infraError: false,
@@ -183,6 +192,22 @@ async function checkAccess(upn: string, token: string, clientIp: string): Promis
});
const text = await res.text();
if (res.status === 401) {
// The token itself was refused (see AccessCheckResult.unauthenticated). The envelope's
// message names the cause (expired, wrong audience, bad signature) for the log line.
let reason = 'The backend rejected the token';
try {
const parsed = JSON.parse(text) as Partial<ApiErrorResponse>;
if (typeof parsed.error === 'string' && parsed.error) reason = parsed.error;
} catch {
/* not an error envelope */
}
boundedSet(accessCache, cacheKey, {
allowed: false, reason, isGlobalAdmin: false, isGlobalReader: false, unauthenticated: true,
expiresAt: Date.now() + ACCESS_CACHE_TTL_MS,
}, MAX_ACCESS_CACHE_ENTRIES);
return { allowed: false, reason, isGlobalAdmin: false, isGlobalReader: false, infraError: false, unauthenticated: true };
}
if (!text) {
console.error(`[access-guard] Backend returned empty body for ${upn} (status=${res.status})`);
return { allowed: false, reason: `Backend returned ${res.status} with empty body`, isGlobalAdmin: false, isGlobalReader: false, infraError: true };
@@ -451,6 +476,14 @@ export function accessGuard(req: Request, res: Response, next: NextFunction): vo
return;
}
if (!result.allowed) {
if (result.unauthenticated) {
// Spec: an invalid or expired token MUST get 401 with a challenge, so the client
// re-authenticates instead of reading a final "forbidden".
console.error(`[mcp-auth] 401 backend-rejected-token (method=${rpcMethod}, upn=${upn})`);
res.setHeader('WWW-Authenticate', `Bearer resource_metadata="${resourceMetadataUrl}", error="invalid_token"`);
res.status(401).json({ error: 'Invalid token', reason: result.reason });
return;
}
if (result.infraError) {
// Backend could not reach a verdict (unreachable / malformed). Fail
// closed, but do NOT tell the user they are "not whitelisted" — it is
@@ -484,12 +517,21 @@ export function accessGuard(req: Request, res: Response, next: NextFunction): vo
return;
}
// Cancellation (Streamable HTTP: closing the response stream cancels the request): the
// caller context carries a signal that fires when the client goes away before the
// response is written, so the backend work of an abandoned call stops (client.ts apiFetch).
const cancellation = new AbortController();
res.on('close', () => {
if (!res.writableFinished) cancellation.abort();
});
// Scope the caller context (token + platform role) to this async context
// so concurrent sessions cannot overwrite each other on the event loop,
// and so tools can route based on role without re-checking the JWT.
runWithCaller(
{
token,
signal: cancellation.signal,
isGlobalAdmin: result.isGlobalAdmin,
isGlobalReader: result.isGlobalReader,
delegatedTenantIds: result.delegatedTenantIds,
+19 -15
View File
@@ -1,12 +1,20 @@
/**
* Auth module for the remote MCP server.
*
* In remote mode, the Claude Code client handles OAuth and sends a Bearer token
* with each MCP request. This module provides helpers for token validation and
* extracting user info from the JWT claims.
* The MCP client obtains a Bearer token through this server's OAuth proxy (oauth.ts) and sends it
* with each MCP request. This module reads the JWT claims; the token itself is validated by the
* backend.
*
* The user's token is passed through to the backend API (access_as_user scope),
* so no service principal or separate credentials are needed.
* Token model — a DELIBERATE deviation from the MCP authorization spec, recorded as a decision in
* the internal decision register: the token's audience is the backend API app (access_as_user),
* not this server, and the same token is forwarded to the backend. The spec requires an MCP
* server to accept only tokens issued for itself and never to transit them downstream. The
* compensations: the backend validates signature, issuer, audience and lifetime on EVERY
* forwarded call (this server never treats a token as valid on its own), /api/auth/mcp decides
* MCP eligibility per principal, and every tool reaches only its own backend path (followNextLink
* basePath pinning). Audience separation would need a second app registration with consent in
* every customer tenant plus an on-behalf-of exchange, and would break the app-only
* service-principal path — not built until a reviewer requires it.
*/
import { createDecoder } from './jwt-decode.js';
@@ -30,16 +38,12 @@ export interface TokenClaims {
/** Calling application's client id on a v2.0 token. */
azp?: string;
/**
* Audience. Parsed for observability/diagnostics but intentionally NOT
* validated here — the same Bearer token is passed through to the backend
* API, which enforces the audience cryptographically alongside the
* signature/issuer/lifetime checks. See
* `src/Backend/AutopilotMonitor.Functions/Middleware/AuthenticationMiddleware.cs:200`
* (`ValidateAudience = true`, `ValidAudiences = { clientId, api://clientId }`).
* Duplicating that gate here would only add a second, drift-prone copy of the
* accepted-audience list (RFC 8707 resource indicators are honored by the
* backend, not the proxy). This is spec-conformant token pass-through: the
* user's token is forwarded to the resource it was issued for.
* Audience. Parsed for observability/diagnostics but intentionally NOT validated here — the
* backend enforces it cryptographically alongside the signature/issuer/lifetime checks
* (`AuthenticationMiddleware.cs`: `ValidateAudience = true`, `ValidAudiences = { clientId,
* api://clientId }`); duplicating that gate here would only add a second, drift-prone copy of
* the accepted-audience list. The audience is the backend API, not this server — see the
* module header for why that deviation from the MCP spec is deliberate.
*/
aud?: string;
}

Some files were not shown because too many files have changed in this diff Show More