Don't log retransmission error if the associated xgress is closed

This commit is contained in:
Paul Lorenz
2021-01-27 10:43:41 -05:00
parent 40091b50e9
commit 38b628fa4a
+7 -2
View File
@@ -140,8 +140,13 @@ func (retransmitter *Retransmitter) retransmitSender() {
case retransmit := <-retransmitter.retransmitSend:
if !retransmit.isAcked() {
if err := retransmitter.forwarder.ForwardPayload(retransmit.x.address, retransmit.payload); err != nil {
logger.WithError(err).Errorf("unexpected error while retransmitting payload from %v", retransmit.x.address)
retransmissionFailures.Mark(1)
// if xgress is closed, don't log the error. We still want to try retransmitting in case we're re-sending end of session
if !retransmit.x.closed.Get() {
logger.WithError(err).Errorf("unexpected error while retransmitting payload from %v", retransmit.x.address)
retransmissionFailures.Mark(1)
} else {
logger.WithError(err).Tracef("unexpected error while retransmitting payload from %v", retransmit.x.address)
}
} else {
retransmit.markSent()
retransmissions.Mark(1)