frontend: fix Analysis chart overflow + gate the Live card

- Live card no longer streams on mount: a "Go live"/"Pause" toggle starts/stops
  the 1s simulation, so the page stays idle by default (perf). Widen the live
  chart's left margin so the y-axis values sit inside the card.
- Weekly-appointments bar chart: drop the misused <BarYAxis>, which printed the
  weekday categories down the left and overflowed the card (vertical bars only
  need the x-axis).
- Patient-growth area chart: one x tick per month so every point is labelled.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Khalid Abdi
2026-06-14 19:41:49 +03:00
parent 91fbe4129f
commit db20359b25
3 changed files with 73 additions and 20 deletions
@@ -8,7 +8,6 @@ import { Area, AreaChart } from "@/components/charts/area-chart";
import { Bar } from "@/components/charts/bar";
import { BarChart } from "@/components/charts/bar-chart";
import { BarXAxis } from "@/components/charts/bar-x-axis";
import { BarYAxis } from "@/components/charts/bar-y-axis";
import { Grid } from "@/components/charts/grid";
import { ChartTooltip } from "@/components/charts/tooltip";
import { XAxis } from "@/components/charts/x-axis";
@@ -196,7 +195,8 @@ export function AnalysisView() {
<AreaChart aspectRatio="2 / 1" data={monthData}>
<Grid horizontal />
<Area dataKey="patients" fill="var(--chart-line-primary)" />
<XAxis tickMode="data" />
{/* One tick per month so every point is labelled. */}
<XAxis numTicks={Math.max(monthData.length, 2)} tickMode="data" />
<ChartTooltip showDatePill={false} />
</AreaChart>
</ChartCard>
@@ -207,8 +207,9 @@ export function AnalysisView() {
<BarChart aspectRatio="2 / 1" data={weekdayData}>
<Grid horizontal />
<Bar dataKey="appointments" fill="var(--chart-line-primary)" />
{/* Vertical bars: weekdays live on the x-axis only. (A BarYAxis
here printed the categories down the left, overflowing the card.) */}
<BarXAxis />
<BarYAxis />
<ChartTooltip showDatePill={false} />
</BarChart>
</ChartCard>
@@ -1,6 +1,8 @@
"use client";
import { Pause, Play } from "lucide-react";
import { useEffect, useRef, useState } from "react";
import { useTranslation } from "react-i18next";
import {
LiveLineChart,
@@ -9,24 +11,34 @@ import {
import { LiveLine } from "@/components/charts/live-line";
import { LiveYAxis } from "@/components/charts/live-y-axis";
import { ChartTooltip } from "@/components/charts/tooltip";
import { Button } from "@/components/ui/button";
// temetro has no real-time telemetry feed yet, so the "Live" panel simulates a
// hospital signal (patients currently in the building) as a bounded random walk
// that updates once a second. Swap `tick()` for a WebSocket/poll when a real
// feed exists — the chart contract (append { time, value }) stays the same.
//
// The simulation (a 1s interval + an rAF animation loop) only runs while the
// clinician has explicitly toggled it on, so the Analysis page stays idle by
// default instead of animating in the background.
const BASELINE = 48;
const MIN = 24;
const MAX = 90;
const WINDOW_SECONDS = 30;
export function LiveHospitalChart() {
const { t } = useTranslation();
const [live, setLive] = useState(false);
const [data, setData] = useState<LiveLinePoint[]>([]);
const [value, setValue] = useState(BASELINE);
const valueRef = useRef(BASELINE);
useEffect(() => {
// Seed a short history so the line is drawn immediately on mount.
if (!live) return;
// Seed a short history so the line is drawn immediately on start.
const now = Date.now() / 1000;
valueRef.current = BASELINE;
setValue(BASELINE);
setData(
Array.from({ length: WINDOW_SECONDS }, (_, i) => ({
time: now - (WINDOW_SECONDS - i),
@@ -45,23 +57,60 @@ export function LiveHospitalChart() {
]);
}, 1000);
return () => clearInterval(id);
}, []);
}, [live]);
return (
<div className="h-56 w-full">
<LiveLineChart data={data} value={value} window={WINDOW_SECONDS}>
<LiveLine
dataKey="value"
formatValue={(v) => String(Math.round(v))}
momentumColors={{
up: "var(--color-emerald-500)",
down: "var(--color-red-500)",
flat: "var(--chart-line-primary)",
}}
/>
<LiveYAxis formatValue={(v) => String(Math.round(v))} position="left" />
<ChartTooltip showDatePill={false} />
</LiveLineChart>
<div className="flex flex-col gap-3">
<div className="flex items-center justify-end">
<Button
onClick={() => setLive((v) => !v)}
size="sm"
type="button"
variant={live ? "outline" : "default"}
>
{live ? (
<>
<Pause className="size-4" />
{t("analysis.live.pause")}
</>
) : (
<>
<Play className="size-4" />
{t("analysis.live.start")}
</>
)}
</Button>
</div>
{live ? (
<div className="h-56 w-full">
<LiveLineChart
data={data}
margin={{ left: 44 }}
value={value}
window={WINDOW_SECONDS}
>
<LiveLine
dataKey="value"
formatValue={(v) => String(Math.round(v))}
momentumColors={{
up: "var(--color-emerald-500)",
down: "var(--color-red-500)",
flat: "var(--chart-line-primary)",
}}
/>
<LiveYAxis
formatValue={(v) => String(Math.round(v))}
position="left"
/>
<ChartTooltip showDatePill={false} />
</LiveLineChart>
</div>
) : (
<div className="flex h-56 w-full items-center justify-center rounded-2xl border border-dashed bg-card/20 text-center text-muted-foreground text-sm">
{t("analysis.live.idle")}
</div>
)}
</div>
);
}
@@ -556,7 +556,10 @@
"live": {
"title": "Live",
"subtitle": "Patients currently in the building, updating in real time.",
"label": "In the building now"
"label": "In the building now",
"start": "Go live",
"pause": "Pause",
"idle": "Live stream paused — press Go live to start."
},
"patientVolume": {
"title": "Patient volume",