gsadmin/ssh.net
1
0
Fork 0
mirror of https://github.com/sshnet/SSH.NET.git synced 2026-09-10 09:15:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use OS-agnostic socket error codes to allow tests run on different OSes (#1179)

Browse Source 
SocketErrorCode is OS agnostic, ErrorCode is OS specific.

On Windows ErrorCode = (int) SocketErrorCode, but on Mac and Unix it is not.

For example ExitCode for HostNotFound (11001) on Windows is 11001, on Mac & Unix is -131073. So testing for ExitCode == 11001 fails on Mac & Unix.

Co-authored-by: Wojciech Nagórski <wojtpl2@gmail.com>
This commit is contained in:
Dmitry Tsarevich
2023-09-26 22:29:45 +03:00
committed by GitHub
parent 4ba591ee0b
commit dd2e55209b
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Renci.SshNet.Tests/Classes/SftpClientTest.Connect.cs
+2 -2
View File
@@ -20,7 +20,7 @@ namespace Renci.SshNet.Tests.Classes
}
catch (SocketException ex)
{
Assert.IsTrue(ex.ErrorCode is (int) SocketError.HostNotFound or (int) SocketError.TryAgain);
Assert.IsTrue(ex.SocketErrorCode is SocketError.HostNotFound or SocketError.TryAgain);
}
}
@@ -38,7 +38,7 @@ namespace Renci.SshNet.Tests.Classes
}
catch (SocketException ex)
{
Assert.IsTrue(ex.ErrorCode is (int) SocketError.HostNotFound or (int) SocketError.TryAgain);
Assert.IsTrue(ex.SocketErrorCode is SocketError.HostNotFound or SocketError.TryAgain);
}
}
}