test(iam): account for UpdateUser as named by bare name

UpdateUser addresses its user by bare name, so the cross-tenant ARN table
cannot target another account; list it with the other byName IAM actions.
Add a focused test that a rename stays within the caller's account.

docs/coverage/README.md

@@ -17,7 +17,7 @@ tags:
 
 ## Overview
 
-The platform serves **405 operations** across the AWS APIs below. Every page names the operations its service implements from the pinned model, generated from the dispatch tables on each build rather than written by hand.
+The platform serves **406 operations** across the AWS APIs below. Every page names the operations its service implements from the pinned model, generated from the dispatch tables on each build rather than written by hand.
 
 | Service | Operations |
 |---|---:|
@@ -27,9 +27,9 @@ The platform serves **405 operations** across the AWS APIs below. Every page nam
 | [ECS](/coverage/ecs) | 31 |
 | [EKS](/coverage/eks) | 27 |
 | [ELBv2](/coverage/elbv2) | 36 |
-| [IAM](/coverage/iam) | 81 |
+| [IAM](/coverage/iam) | 82 |
 | [RDS](/coverage/rds) | 27 |
 | [Route 53](/coverage/route53) | 13 |
 | [S3](/coverage/s3) | 26 |
 | [STS](/coverage/sts) | 5 |
-| **Total** | **405** |
+| **Total** | **406** |

docs/coverage/coverage.json

@@ -2938,7 +2938,8 @@
           "UpdateAccessKey",
           "UpdateAssumeRolePolicy",
           "UpdateRole",
-          "UpdateRoleDescription"
+          "UpdateRoleDescription",
+          "UpdateUser"
         ],
         "implemented": [
           "AddRoleToInstanceProfile",
@@ -3021,7 +3022,8 @@
           "UpdateAccessKey",
           "UpdateAssumeRolePolicy",
           "UpdateRole",
-          "UpdateRoleDescription"
+          "UpdateRoleDescription",
+          "UpdateUser"
         ],
         "stubbed": [],
         "unsupported": [],
@@ -3121,7 +3123,6 @@
           "UpdateServerCertificate",
           "UpdateServiceSpecificCredential",
           "UpdateSigningCertificate",
-          "UpdateUser",
           "UploadSSHPublicKey",
           "UploadServerCertificate",
           "UploadSigningCertificate"

docs/coverage/iam/README.md

@@ -18,7 +18,7 @@ tags:
 
 ## Overview
 
-Spinifex implements **81 operations** in the IAM `2010-05-08` API model.
+Spinifex implements **82 operations** in the IAM `2010-05-08` API model.
 
 ### Scope
 
@@ -109,3 +109,4 @@ All IAM operations are account-scoped. The root user of an account bypasses poli
 | `UpdateAssumeRolePolicy` |
 | `UpdateRole` |
 | `UpdateRoleDescription` |
+| `UpdateUser` |

docs/coverage/internal-report.md

@@ -987,7 +987,7 @@ spot-price: On owned hardware there is no spot-to-on-demand price differential,
 
 ## iam
 
-`2010-05-08` — 81 of 180 modelled operations implemented (45.0%), 0 stubbed, 19 not applicable, 0 registered outside the pinned model.
+`2010-05-08` — 82 of 180 modelled operations implemented (45.6%), 0 stubbed, 19 not applicable, 0 registered outside the pinned model.
 
 ### Not implemented
 
@@ -1069,7 +1069,6 @@ spot-price: On owned hardware there is no spot-to-on-demand price differential,
 - `UpdateOpenIDConnectProviderThumbprint`
 - `UpdateSAMLProvider`
 - `UpdateServerCertificate`
-- `UpdateUser`
 - `UploadServerCertificate`
 
 ### Not applicable — do not build

spinifex/domains/ec2/awsapi/instance/IamInstanceProfileAssociation.go

@@ -35,7 +35,7 @@ func resolveAndAuthorizeProfile(spec *ec2.IamInstanceProfileSpecification, iamSv
 	}
 	profile, err := iamSvc.ResolveInstanceProfile(accountID, nameOrARN)
 	if err != nil {
-		if err.Error() == awserrors.ErrorIAMNoSuchEntity {
+		if code, _ := awserrors.ResolveErrorCode(err); code == awserrors.ErrorIAMNoSuchEntity {
 			return nil, errors.New(awserrors.ErrorInvalidIamInstanceProfileNotFound)
 		}
 		return nil, err

spinifex/domains/ec2/awsapi/instance/IamInstanceProfileAssociation_test.go

@@ -45,7 +45,7 @@ func (f *fakeIAMService) ResolveInstanceProfile(accountID, nameOrARN string) (*i
 	if f.resolveFn != nil {
 		return f.resolveFn(accountID, nameOrARN)
 	}
-	return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+	return nil, awserrors.Errorf(awserrors.ErrorIAMNoSuchEntity, "Instance Profile %s cannot be found.", nameOrARN)
 }
 
 func (f *fakeIAMService) CanonicalResourceARN(accountID string, kind arn.IAMResourceType, name string) (string, error) {

spinifex/domains/ec2/guestmetadata/metadata.go

@@ -738,7 +738,7 @@ func (s *IMDSServiceImpl) profileFor(ctx context.Context, eni *eniFacts) (*resol
 	}
 	profile, err := s.iam.ResolveInstanceProfile(ctx, eni.iamAccountID(), inst.iamInstanceProfileArn)
 	if err != nil {
-		if err.Error() == awserrors.ErrorIAMNoSuchEntity {
+		if code, _ := awserrors.ResolveErrorCode(err); code == awserrors.ErrorIAMNoSuchEntity {
 			return nil, roleMissProfileDeleted, nil // profile deleted; treat as no role
 		}
 		slog.ErrorContext(ctx, "IMDS: resolve instance profile failed", "account_id", eni.iamAccountID(), "arn", inst.iamInstanceProfileArn, "err", err)

spinifex/domains/ec2/guestmetadata/metadata_test.go

@@ -1152,7 +1152,7 @@ func TestHTTP_SecurityCredentialsListBackendError500(t *testing.T) {
 // genuine backend error (TestHTTP_*BackendError500) is a 500.
 func TestHTTP_IAMInfoDeletedProfile404(t *testing.T) {
 	res := &fakeResolver{eni: testENI(), inst: &instanceFacts{iamInstanceProfileArn: "arn:aws:iam::111122223333:instance-profile/gone"}}
-	svc, _ := newTestService(res, &fakeIAM{profileErr: errors.New(awserrors.ErrorIAMNoSuchEntity)}, &fakeAssumer{})
+	svc, _ := newTestService(res, &fakeIAM{profileErr: awserrors.Errorf(awserrors.ErrorIAMNoSuchEntity, "Instance Profile gone cannot be found.")}, &fakeAssumer{})
 	h := withTapENI(svc.httpHandler(), testENI())
 	token := issueToken(t, h)
 	rec := get(t, h, prefixMetaData+"iam/info", token)

spinifex/domains/eks/cluster/nodegroup.go

@@ -886,7 +886,7 @@ func (s *EKSServiceImpl) ensureNodeInstanceProfile(accountID, nodeRoleARN string
 		return s.attachRoleToProfile(accountID, profileName, roleName,
 			aws.StringValue(out.InstanceProfile.Arn), len(out.InstanceProfile.Roles) > 0)
 	}
-	if err.Error() != awserrors.ErrorIAMNoSuchEntity {
+	if code, _ := awserrors.ResolveErrorCode(err); code != awserrors.ErrorIAMNoSuchEntity {
 		return "", fmt.Errorf("get instance profile %q: %w", profileName, err)
 	}
 
@@ -895,7 +895,7 @@ func (s *EKSServiceImpl) ensureNodeInstanceProfile(accountID, nodeRoleARN string
 	})
 	if err != nil {
 		// A racing worker launch may have created it first; re-read and converge.
-		if err.Error() != awserrors.ErrorIAMEntityAlreadyExists {
+		if code, _ := awserrors.ResolveErrorCode(err); code != awserrors.ErrorIAMEntityAlreadyExists {
 			return "", fmt.Errorf("create instance profile %q: %w", profileName, err)
 		}
 		got, gerr := s.iamEnsurer().GetInstanceProfile(accountID, &iam.GetInstanceProfileInput{
@@ -922,7 +922,7 @@ func (s *EKSServiceImpl) attachRoleToProfile(accountID, profileName, roleName, p
 		InstanceProfileName: aws.String(profileName),
 		RoleName:            aws.String(roleName),
 	})
-	if err != nil && err.Error() != awserrors.ErrorIAMLimitExceeded {
+	if code, _ := awserrors.ResolveErrorCode(err); err != nil && code != awserrors.ErrorIAMLimitExceeded {
 		return "", fmt.Errorf("add role %q to instance profile %q: %w", roleName, profileName, err)
 	}
 	return profileARN, nil

spinifex/domains/iam/awsapi/authz.go

@@ -48,6 +48,7 @@ var iamScopes = map[string]resourceScope{
 	"CreateUser":               createScope(arn.IAMUser, "UserName"),
 	"GetUser":                  existingScope(arn.IAMUser, "UserName"),
 	"DeleteUser":               existingScope(arn.IAMUser, "UserName"),
+	"UpdateUser":               existingScope(arn.IAMUser, "UserName"),
 	"CreateAccessKey":          existingScope(arn.IAMUser, "UserName"),
 	"ListAccessKeys":           existingScope(arn.IAMUser, "UserName"),
 	"DeleteAccessKey":          existingScope(arn.IAMUser, "UserName"),
@@ -284,7 +285,7 @@ func lookupResult(t lookupTarget, resource string, err error) (string, error) {
 		}
 		return resource, nil
 	}
-	if err.Error() == awserrors.ErrorIAMNoSuchEntity {
+	if code, _ := awserrors.ResolveErrorCode(err); code == awserrors.ErrorIAMNoSuchEntity {
 		// Authorization widens to "*", so a Deny scoped to the real target
 		// will not fire. Without this line that widening leaves no trace.
 		slog.Warn("IAM authz: target not found, authorizing account-wide",

spinifex/domains/iam/awsapi/authz_test.go

@@ -33,7 +33,7 @@ func (s *resolverService) CanonicalResourceARN(_ string, kind arn.IAMResourceTyp
 			return resource, nil
 		}
 	}
-	return "", errors.New(awserrors.ErrorIAMNoSuchEntity)
+	return "", awserrors.Errorf(awserrors.ErrorIAMNoSuchEntity, "The %s with name %s cannot be found.", kind, name)
 }
 
 func (s *resolverService) LookupAccessKey(_ string) (*iamdomain.AccessKey, error) {

spinifex/domains/iam/awsapi/registration.go

@@ -96,6 +96,9 @@ var actions = map[string]action{
 	"DeleteUser": handler(func(accountID string, input *iam.DeleteUserInput, d Deps) (any, error) {
 		return DeleteUser(accountID, input, d.IAM)
 	}),
+	"UpdateUser": handler(func(accountID string, input *iam.UpdateUserInput, d Deps) (any, error) {
+		return UpdateUser(accountID, input, d.IAM)
+	}),
 	"CreateAccessKey": handler(func(accountID string, input *iam.CreateAccessKeyInput, d Deps) (any, error) {
 		return CreateAccessKey(accountID, input, d.IAM)
 	}),

spinifex/domains/iam/awsapi/registration_test.go

@@ -26,6 +26,7 @@ type regService struct {
 
 	getUserName   string
 	getUserCalls  int
+	updateUser    *iam.UpdateUserInput
 	addRoleCalls  int
 	canonicalARN  string
 	canonicalErr  error
@@ -41,6 +42,11 @@ func (s *regService) GetUser(_ string, in *iam.GetUserInput) (*iam.GetUserOutput
 	return &iam.GetUserOutput{}, nil
 }
 
+func (s *regService) UpdateUser(_ string, in *iam.UpdateUserInput) (*iam.UpdateUserOutput, error) {
+	s.updateUser = in
+	return &iam.UpdateUserOutput{}, nil
+}
+
 func (s *regService) AddRoleToInstanceProfile(_ string, _ *iam.AddRoleToInstanceProfileInput) (*iam.AddRoleToInstanceProfileOutput, error) {
 	s.addRoleCalls++
 	return &iam.AddRoleToInstanceProfileOutput{}, nil
@@ -268,6 +274,23 @@ func TestRegistration_AddRoleToInstanceProfilePassRole(t *testing.T) {
 	})
 }
 
+func TestRegistration_UpdateUser(t *testing.T) {
+	svc := &regService{}
+	w, calls, err := invoke(t, Deps{IAM: svc}, testAccountID, dispatch.Actor{}, nil, url.Values{
+		"Action": {"UpdateUser"}, "UserName": {"alice"}, "NewUserName": {"alicia"}, "NewPath": {"/eng/"},
+	})
+	require.NoError(t, err)
+	require.Len(t, calls, 1)
+	assert.Equal(t, []string{"arn:aws:iam::" + testAccountID + ":user/alice"}, calls[0].resources)
+	assert.Contains(t, w.Body.String(), "UpdateUserResponse")
+	require.NotNil(t, svc.updateUser)
+	assert.Equal(t, "alicia", *svc.updateUser.NewUserName)
+	assert.Equal(t, "/eng/", *svc.updateUser.NewPath)
+
+	_, _, err = invoke(t, Deps{IAM: svc}, testAccountID, dispatch.Actor{}, nil, url.Values{"Action": {"UpdateUser"}})
+	assert.True(t, awserrors.IsErrorCode(err, awserrors.ErrorMissingParameter), "got %v", err)
+}
+
 func TestActionNames_SortedAndInventory(t *testing.T) {
 	names := ActionNames()
 	require.NotEmpty(t, names)

spinifex/domains/iam/awsapi/user.go

@@ -78,6 +78,15 @@ func DeleteUser(accountID string, input *iam.DeleteUserInput, svc iamdomain.IAMS
 	return svc.DeleteUser(accountID, input)
 }
 
+// UpdateUser implements the IAM UpdateUser action, renaming a user or changing its path. It
+// returns MissingParameter when UserName is absent, then calls the IAM service for accountID.
+func UpdateUser(accountID string, input *iam.UpdateUserInput, svc iamdomain.IAMService) (*iam.UpdateUserOutput, error) {
+	if input.UserName == nil || *input.UserName == "" {
+		return nil, errors.New(awserrors.ErrorMissingParameter)
+	}
+	return svc.UpdateUser(accountID, input)
+}
+
 // PutUserPolicy implements the IAM PutUserPolicy action, adding or replacing a user inline
 // policy. It returns MissingParameter when UserName, PolicyName or PolicyDocument is absent, then
 // calls the IAM service for accountID.

spinifex/domains/iam/error_messages_test.go

@@ -0,0 +1,186 @@
+package iam
+
+import (
+	"testing"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/service/iam"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+// TestEntityErrorMessages pins the per-case text AWS returns for NoSuchEntity,
+// EntityAlreadyExists, DeleteConflict and LimitExceeded, as recorded against
+// real IAM, so a client sees which entity is missing or in conflict.
+func TestEntityErrorMessages(t *testing.T) {
+	svc := setupTestIAMService(t)
+	acct := testAccountID
+
+	createTestUser(t, svc, "u1")
+	createTestRole(t, svc, "r1")
+	createTestRole(t, svc, "r2")
+	createTestGroup(t, svc, "g1")
+	createTestInstanceProfile(t, svc, "ip1")
+	policy := createTestPolicy(t, svc, "p1")
+	policyARN := aws.StringValue(policy.Arn)
+	missingPolicyARN := "arn:aws:iam::" + acct + ":policy/p1-nope"
+	_, err := svc.CreateOpenIDConnectProvider(acct, &iam.CreateOpenIDConnectProviderInput{
+		Url: aws.String(testIssuer), ClientIDList: aws.StringSlice([]string{"sts.amazonaws.com"}),
+	})
+	require.NoError(t, err)
+	missingOIDCARN := "arn:aws:iam::" + acct + ":oidc-provider/oidc.nope.example.com"
+
+	// Conflict fixtures: a user holding a key, a role with a managed policy, a
+	// role and profile linked to each other, and a group with a member.
+	createTestUser(t, svc, "u-key")
+	_, err = svc.CreateAccessKey(acct, &iam.CreateAccessKeyInput{UserName: aws.String("u-key")})
+	require.NoError(t, err)
+	createTestRole(t, svc, "r-pol")
+	_, err = svc.AttachRolePolicy(acct, &iam.AttachRolePolicyInput{RoleName: aws.String("r-pol"), PolicyArn: aws.String(policyARN)})
+	require.NoError(t, err)
+	createTestRole(t, svc, "r-ip")
+	createTestInstanceProfile(t, svc, "ip-r")
+	_, err = svc.AddRoleToInstanceProfile(acct, &iam.AddRoleToInstanceProfileInput{InstanceProfileName: aws.String("ip-r"), RoleName: aws.String("r-ip")})
+	require.NoError(t, err)
+	createTestGroup(t, svc, "g-mem")
+	_, err = svc.AddUserToGroup(acct, &iam.AddUserToGroupInput{GroupName: aws.String("g-mem"), UserName: aws.String("u1")})
+	require.NoError(t, err)
+
+	cases := []struct {
+		name     string
+		call     func() error
+		wantCode string
+		wantMsg  string
+	}{
+		{"GetUser missing", func() error {
+			_, err := svc.GetUser(acct, &iam.GetUserInput{UserName: aws.String("nope")})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "The user with name nope cannot be found."},
+		{"TagUser missing", func() error {
+			_, err := svc.TagUser(acct, &iam.TagUserInput{UserName: aws.String("nope"), Tags: []*iam.Tag{{Key: aws.String("k"), Value: aws.String("v")}}})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "The user with name nope cannot be found."},
+		{"AddUserToGroup missing user", func() error {
+			_, err := svc.AddUserToGroup(acct, &iam.AddUserToGroupInput{GroupName: aws.String("g1"), UserName: aws.String("nope")})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "The user with name nope cannot be found."},
+		{"GetRole missing", func() error {
+			_, err := svc.GetRole(acct, &iam.GetRoleInput{RoleName: aws.String("nope")})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "The role with name nope cannot be found."},
+		{"TagRole missing", func() error {
+			_, err := svc.TagRole(acct, &iam.TagRoleInput{RoleName: aws.String("nope"), Tags: []*iam.Tag{{Key: aws.String("k"), Value: aws.String("v")}}})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "The role with name nope cannot be found."},
+		{"DeleteGroup missing", func() error {
+			_, err := svc.DeleteGroup(acct, &iam.DeleteGroupInput{GroupName: aws.String("nope")})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "The group with name nope cannot be found."},
+		{"GetPolicy missing", func() error {
+			_, err := svc.GetPolicy(acct, &iam.GetPolicyInput{PolicyArn: aws.String(missingPolicyARN)})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "Policy " + missingPolicyARN + " was not found."},
+		{"DeletePolicy missing", func() error {
+			_, err := svc.DeletePolicy(acct, &iam.DeletePolicyInput{PolicyArn: aws.String(missingPolicyARN)})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "Policy " + missingPolicyARN + " was not found."},
+		{"DetachUserPolicy not attached", func() error {
+			_, err := svc.DetachUserPolicy(acct, &iam.DetachUserPolicyInput{UserName: aws.String("u1"), PolicyArn: aws.String(policyARN)})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "Policy " + policyARN + " was not found."},
+		{"AttachRolePolicy missing policy", func() error {
+			_, err := svc.AttachRolePolicy(acct, &iam.AttachRolePolicyInput{RoleName: aws.String("r1"), PolicyArn: aws.String(missingPolicyARN)})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "Policy " + missingPolicyARN + " does not exist or is not attachable."},
+		{"GetInstanceProfile missing", func() error {
+			_, err := svc.GetInstanceProfile(acct, &iam.GetInstanceProfileInput{InstanceProfileName: aws.String("nope")})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "Instance Profile nope cannot be found."},
+		{"RemoveRoleFromInstanceProfile not in profile", func() error {
+			_, err := svc.RemoveRoleFromInstanceProfile(acct, &iam.RemoveRoleFromInstanceProfileInput{InstanceProfileName: aws.String("ip1"), RoleName: aws.String("r2")})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "Role r2 in Instance Profile ip1 cannot be found."},
+		{"GetOpenIDConnectProvider missing", func() error {
+			_, err := svc.GetOpenIDConnectProvider(acct, &iam.GetOpenIDConnectProviderInput{OpenIDConnectProviderArn: aws.String(missingOIDCARN)})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "OpenIDConnect Provider not found for arn " + missingOIDCARN},
+		{"GetUserPolicy missing", func() error {
+			_, err := svc.GetUserPolicy(acct, &iam.GetUserPolicyInput{UserName: aws.String("u1"), PolicyName: aws.String("inl")})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "The user policy with name inl cannot be found."},
+		{"DeleteRolePolicy missing", func() error {
+			_, err := svc.DeleteRolePolicy(acct, &iam.DeleteRolePolicyInput{RoleName: aws.String("r1"), PolicyName: aws.String("rinl")})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "The role policy with name rinl cannot be found."},
+		{"DeleteAccessKey missing", func() error {
+			_, err := svc.DeleteAccessKey(acct, &iam.DeleteAccessKeyInput{UserName: aws.String("u1"), AccessKeyId: aws.String("AKIANOPE")})
+			return err
+		}, awserrors.ErrorIAMNoSuchEntity, "The Access Key with id AKIANOPE cannot be found."},
+
+		{"CreateUser duplicate", func() error {
+			_, err := svc.CreateUser(acct, &iam.CreateUserInput{UserName: aws.String("u1")})
+			return err
+		}, awserrors.ErrorIAMEntityAlreadyExists, "User with name u1 already exists."},
+		{"CreateRole duplicate", func() error {
+			_, err := svc.CreateRole(acct, &iam.CreateRoleInput{RoleName: aws.String("r1"), AssumeRolePolicyDocument: aws.String(validTrustPolicy())})
+			return err
+		}, awserrors.ErrorIAMEntityAlreadyExists, "Role with name r1 already exists."},
+		{"CreateGroup duplicate", func() error {
+			_, err := svc.CreateGroup(acct, &iam.CreateGroupInput{GroupName: aws.String("g1")})
+			return err
+		}, awserrors.ErrorIAMEntityAlreadyExists, "Group with name g1 already exists."},
+		{"CreatePolicy duplicate", func() error {
+			_, err := svc.CreatePolicy(acct, &iam.CreatePolicyInput{PolicyName: aws.String("p1"), PolicyDocument: aws.String(validPolicyDocument())})
+			return err
+		}, awserrors.ErrorIAMEntityAlreadyExists, "A policy called p1 already exists. Duplicate names are not allowed."},
+		{"CreateInstanceProfile duplicate", func() error {
+			_, err := svc.CreateInstanceProfile(acct, &iam.CreateInstanceProfileInput{InstanceProfileName: aws.String("ip1")})
+			return err
+		}, awserrors.ErrorIAMEntityAlreadyExists, "Instance Profile ip1 already exists."},
+		{"CreateOpenIDConnectProvider duplicate", func() error {
+			_, err := svc.CreateOpenIDConnectProvider(acct, &iam.CreateOpenIDConnectProviderInput{
+				Url: aws.String(testIssuer), ClientIDList: aws.StringSlice([]string{"sts.amazonaws.com"}),
+			})
+			return err
+		}, awserrors.ErrorIAMEntityAlreadyExists, "Provider with url " + testIssuer + " already exists."},
+
+		{"DeleteUser with access key", func() error {
+			_, err := svc.DeleteUser(acct, &iam.DeleteUserInput{UserName: aws.String("u-key")})
+			return err
+		}, awserrors.ErrorIAMDeleteConflict, "Cannot delete entity, must delete access keys first."},
+		{"DeleteRole with attached policy", func() error {
+			_, err := svc.DeleteRole(acct, &iam.DeleteRoleInput{RoleName: aws.String("r-pol")})
+			return err
+		}, awserrors.ErrorIAMDeleteConflict, "Cannot delete entity, must detach all policies first."},
+		{"DeleteRole in instance profile", func() error {
+			_, err := svc.DeleteRole(acct, &iam.DeleteRoleInput{RoleName: aws.String("r-ip")})
+			return err
+		}, awserrors.ErrorIAMDeleteConflict, "Cannot delete entity, must remove roles from instance profile first."},
+		{"DeleteInstanceProfile with role", func() error {
+			_, err := svc.DeleteInstanceProfile(acct, &iam.DeleteInstanceProfileInput{InstanceProfileName: aws.String("ip-r")})
+			return err
+		}, awserrors.ErrorIAMDeleteConflict, "Cannot delete entity, must remove roles from instance profile first."},
+		{"DeleteGroup with member", func() error {
+			_, err := svc.DeleteGroup(acct, &iam.DeleteGroupInput{GroupName: aws.String("g-mem")})
+			return err
+		}, awserrors.ErrorIAMDeleteConflict, "Cannot delete entity, must remove users from group first."},
+		{"DeletePolicy attached", func() error {
+			_, err := svc.DeletePolicy(acct, &iam.DeletePolicyInput{PolicyArn: aws.String(policyARN)})
+			return err
+		}, awserrors.ErrorIAMDeleteConflict, "Cannot delete a policy attached to entities."},
+
+		{"AddRoleToInstanceProfile second role", func() error {
+			_, err := svc.AddRoleToInstanceProfile(acct, &iam.AddRoleToInstanceProfileInput{InstanceProfileName: aws.String("ip-r"), RoleName: aws.String("r2")})
+			return err
+		}, awserrors.ErrorIAMLimitExceeded, "Cannot exceed quota for InstanceSessionsPerInstanceProfile: 1"},
+	}
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			code, msg, ok := awserrors.ResolveErrorDetail(tc.call())
+			require.True(t, ok, "error carries no AWS code")
+			assert.Equal(t, tc.wantCode, code)
+			assert.Equal(t, tc.wantMsg, msg)
+		})
+	}
+}

spinifex/domains/iam/groups.go

@@ -65,7 +65,7 @@ func (s *IAMServiceImpl) CreateGroup(accountID string, input *iam.CreateGroupInp
 	kvKey := accountID + "." + groupName
 	if _, err := s.groupsBucket.Create(ctx, kvKey, data); err != nil {
 		if errors.Is(err, jetstream.ErrKeyExists) {
-			return nil, errors.New(awserrors.ErrorIAMEntityAlreadyExists)
+			return nil, awserrors.Errorf(awserrors.ErrorIAMEntityAlreadyExists, "Group with name %s already exists.", groupName)
 		}
 		return nil, fmt.Errorf("store group: %w", err)
 	}
@@ -175,11 +175,11 @@ func (s *IAMServiceImpl) DeleteGroup(accountID string, input *iam.DeleteGroupInp
 	}
 
 	if len(group.AttachedPolicies) > 0 {
-		return nil, errors.New(awserrors.ErrorIAMDeleteConflict)
+		return nil, errDetachPoliciesFirst
 	}
 
 	if len(group.InlinePolicies) > 0 {
-		return nil, errors.New(awserrors.ErrorIAMDeleteConflict)
+		return nil, errDeletePoliciesFirst
 	}
 
 	members, err := s.findGroupMembers(ctx, accountID, groupName)
@@ -187,7 +187,7 @@ func (s *IAMServiceImpl) DeleteGroup(accountID string, input *iam.DeleteGroupInp
 		return nil, fmt.Errorf("check group members: %w", err)
 	}
 	if len(members) > 0 {
-		return nil, errors.New(awserrors.ErrorIAMDeleteConflict)
+		return nil, awserrors.Errorf(awserrors.ErrorIAMDeleteConflict, "Cannot delete entity, must remove users from group first.")
 	}
 
 	if err := s.groupsBucket.Delete(ctx, accountID+"."+groupName); err != nil {
@@ -234,19 +234,28 @@ func (s *IAMServiceImpl) RemoveUserFromGroup(accountID string, input *iam.Remove
 	groupName := *input.GroupName
 	userName := *input.UserName
 
-	// Operate purely on the membership reference so a dangling pointer to an
-	// already-deleted group is still cleanable; never fetch the group here.
+	// Remove the membership reference without fetching the group, so a dangling
+	// pointer to an already-deleted group is still cleanable.
+	removed := false
 	err := s.updateUserCAS(ctx, accountID, userName, func(u *User) (bool, error) {
 		idx := slices.Index(u.Groups, groupName)
 		if idx < 0 {
-			return false, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return false, nil
 		}
 		u.Groups = slices.Delete(u.Groups, idx, idx+1)
+		removed = true
 		return true, nil
 	})
 	if err != nil {
 		return nil, err
 	}
+	// AWS answers success for a non-member when the group exists.
+	if !removed {
+		if _, err := s.getGroup(ctx, accountID, groupName); err != nil {
+			return nil, err
+		}
+		return &iam.RemoveUserFromGroupOutput{}, nil
+	}
 
 	slog.Info("IAM user removed from group", "accountID", accountID, "userName", userName, "groupName", groupName)
 	return &iam.RemoveUserFromGroupOutput{}, nil
@@ -265,7 +274,7 @@ func (s *IAMServiceImpl) ListGroupsForUser(accountID string, input *iam.ListGrou
 	for _, name := range user.Groups {
 		group, err := s.getGroup(ctx, accountID, name)
 		if err != nil {
-			if err.Error() == awserrors.ErrorIAMNoSuchEntity {
+			if code, _ := awserrors.ResolveErrorCode(err); code == awserrors.ErrorIAMNoSuchEntity {
 				// A dangling pointer to a vanished group is inert; skip it.
 				// Mirrors GetUserPolicies — transient/corrupt errors fail closed.
 				slog.Warn("ListGroupsForUser: member references missing group; skipping",
@@ -294,7 +303,7 @@ func (s *IAMServiceImpl) AttachGroupPolicy(accountID string, input *iam.AttachGr
 
 	// AWS-managed ARNs are stored opaquely (like roles); customer-managed ARNs must exist.
 	if !iamarn.IsAWSManagedPolicyARN(policyARN) {
-		if _, err := s.getPolicyByARN(ctx, accountID, policyARN); err != nil {
+		if err := s.attachablePolicy(ctx, accountID, policyARN); err != nil {
 			return nil, err
 		}
 	}
@@ -322,7 +331,7 @@ func (s *IAMServiceImpl) DetachGroupPolicy(accountID string, input *iam.DetachGr
 	err := s.updateGroupCAS(ctx, accountID, groupName, func(g *Group) (bool, error) {
 		idx := slices.Index(g.AttachedPolicies, policyARN)
 		if idx < 0 {
-			return false, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return false, policyNotFound(policyARN)
 		}
 		g.AttachedPolicies = slices.Delete(g.AttachedPolicies, idx, idx+1)
 		return true, nil
@@ -408,7 +417,7 @@ func (s *IAMServiceImpl) GetGroupPolicy(accountID string, input *iam.GetGroupPol
 
 	doc, ok := group.InlinePolicies[policyName]
 	if !ok {
-		return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+		return nil, noSuchEntity("group policy", policyName)
 	}
 
 	return &iam.GetGroupPolicyOutput{
@@ -427,7 +436,7 @@ func (s *IAMServiceImpl) DeleteGroupPolicy(accountID string, input *iam.DeleteGr
 
 	err := s.updateGroupCAS(ctx, accountID, groupName, func(g *Group) (bool, error) {
 		if _, ok := g.InlinePolicies[policyName]; !ok {
-			return false, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return false, noSuchEntity("group policy", policyName)
 		}
 		delete(g.InlinePolicies, policyName)
 		return true, nil
@@ -470,7 +479,7 @@ func (s *IAMServiceImpl) getGroup(ctx context.Context, accountID, groupName stri
 	entry, err := s.groupsBucket.Get(ctx, accountID+"."+groupName)
 	if err != nil {
 		if errors.Is(err, jetstream.ErrKeyNotFound) {
-			return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return nil, noSuchEntity("group", groupName)
 		}
 		return nil, fmt.Errorf("get group: %w", err)
 	}

spinifex/domains/iam/groups_test.go

@@ -409,6 +409,18 @@ func TestRemoveUserFromGroup_NotMember(t *testing.T) {
 		GroupName: aws.String("team"),
 		UserName:  aws.String("erin"),
 	})
+	require.NoError(t, err)
+}
+
+func TestRemoveUserFromGroup_GroupNotFound(t *testing.T) {
+	t.Parallel()
+	svc := setupTestIAMService(t)
+	createTestUser(t, svc, "erin")
+
+	_, err := svc.RemoveUserFromGroup(testAccountID, &iam.RemoveUserFromGroupInput{
+		GroupName: aws.String("ghost"),
+		UserName:  aws.String("erin"),
+	})
 	assert.Error(t, err)
 	assert.Contains(t, err.Error(), awserrors.ErrorIAMNoSuchEntity)
 }

spinifex/domains/iam/instance_profiles.go

@@ -66,7 +66,7 @@ func (s *IAMServiceImpl) CreateInstanceProfile(accountID string, input *iam.Crea
 
 	if _, err := s.instanceProfilesBucket.Create(ctx, accountID+"."+profileName, data); err != nil {
 		if errors.Is(err, jetstream.ErrKeyExists) {
-			return nil, errors.New(awserrors.ErrorIAMEntityAlreadyExists)
+			return nil, awserrors.Errorf(awserrors.ErrorIAMEntityAlreadyExists, "Instance Profile %s already exists.", profileName)
 		}
 		return nil, fmt.Errorf("store instance profile: %w", err)
 	}
@@ -172,7 +172,7 @@ func (s *IAMServiceImpl) DeleteInstanceProfile(accountID string, input *iam.Dele
 	_, err := kvutil.DeleteIf(ctx, s.instanceProfilesBucket, accountID+"."+profileName, s.instanceProfileCASConfig(accountID, profileName),
 		func(p *InstanceProfile) error {
 			if p.RoleName != "" {
-				return errors.New(awserrors.ErrorIAMDeleteConflict)
+				return awserrors.Errorf(awserrors.ErrorIAMDeleteConflict, "Cannot delete entity, must remove roles from instance profile first.")
 			}
 			return nil
 		})
@@ -195,7 +195,7 @@ func (s *IAMServiceImpl) AddRoleToInstanceProfile(accountID string, input *iam.A
 
 	err := s.updateInstanceProfileCAS(ctx, accountID, profileName, func(p *InstanceProfile) (bool, error) {
 		if p.RoleName != "" {
-			return false, errors.New(awserrors.ErrorIAMLimitExceeded)
+			return false, awserrors.Errorf(awserrors.ErrorIAMLimitExceeded, "Cannot exceed quota for InstanceSessionsPerInstanceProfile: 1")
 		}
 		p.RoleName = roleName
 		return true, nil
@@ -216,7 +216,7 @@ func (s *IAMServiceImpl) RemoveRoleFromInstanceProfile(accountID string, input *
 
 	err := s.updateInstanceProfileCAS(ctx, accountID, profileName, func(p *InstanceProfile) (bool, error) {
 		if p.RoleName == "" || p.RoleName != roleName {
-			return false, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return false, awserrors.Errorf(awserrors.ErrorIAMNoSuchEntity, "Role %s in Instance Profile %s cannot be found.", roleName, profileName)
 		}
 		p.RoleName = ""
 		return true, nil
@@ -357,11 +357,16 @@ func (s *IAMServiceImpl) ListInstanceProfileTags(accountID string, input *iam.Li
 	}, nil
 }
 
+// instanceProfileNotFound is NoSuchEntity with AWS's message for a missing instance profile.
+func instanceProfileNotFound(profileName string) error {
+	return awserrors.Errorf(awserrors.ErrorIAMNoSuchEntity, "Instance Profile %s cannot be found.", profileName)
+}
+
 func (s *IAMServiceImpl) getInstanceProfile(ctx context.Context, accountID, profileName string) (*InstanceProfile, error) {
 	entry, err := s.instanceProfilesBucket.Get(ctx, accountID+"."+profileName)
 	if err != nil {
 		if errors.Is(err, jetstream.ErrKeyNotFound) {
-			return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return nil, instanceProfileNotFound(profileName)
 		}
 		return nil, fmt.Errorf("get instance profile: %w", err)
 	}
@@ -385,7 +390,7 @@ func (s *IAMServiceImpl) updateInstanceProfileCAS(ctx context.Context, accountID
 func (s *IAMServiceImpl) instanceProfileCASConfig(accountID, profileName string) kvutil.CASConfig {
 	return kvutil.CASConfig{
 		Attempts: instanceProfileCASMaxRetries,
-		NotFound: errors.New(awserrors.ErrorIAMNoSuchEntity),
+		NotFound: instanceProfileNotFound(profileName),
 		Exhausted: func(string, int) error {
 			slog.Warn("IAM instance profile CAS exhausted retries",
 				"accountID", accountID, "instanceProfileName", profileName, "attempts", instanceProfileCASMaxRetries)

spinifex/domains/iam/instance_profiles_test.go

@@ -778,7 +778,7 @@ func TestResolveInstanceProfile_NonCanonicalARNRejected(t *testing.T) {
 		_, err := svc.ResolveInstanceProfile(testAccountID, arn)
 		require.Error(t, err, arn)
 		// The EC2 gateway maps this to InvalidIamInstanceProfile.NotFound by exact match.
-		assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, err.Error(), arn)
+		assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, awserrors.ValidErrorCodeFromError(err), arn)
 	}
 }
 

spinifex/domains/iam/mock/mock.go

@@ -90,7 +90,7 @@ func (e *SystemInstanceRoleEnsurer) GetRole(_ string, in *iam.GetRoleInput) (*ia
 
 	r, ok := e.Roles[aws.StringValue(in.RoleName)]
 	if !ok {
-		return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+		return nil, awserrors.Errorf(awserrors.ErrorIAMNoSuchEntity, "The role with name %s cannot be found.", aws.StringValue(in.RoleName))
 	}
 	return &iam.GetRoleOutput{Role: copyRole(r)}, nil
 }
@@ -104,7 +104,7 @@ func (e *SystemInstanceRoleEnsurer) CreateRole(accountID string, in *iam.CreateR
 	e.LastRoleAcct = accountID
 	name := aws.StringValue(in.RoleName)
 	if _, ok := e.Roles[name]; ok {
-		return nil, errors.New(awserrors.ErrorIAMEntityAlreadyExists)
+		return nil, awserrors.Errorf(awserrors.ErrorIAMEntityAlreadyExists, "Role with name %s already exists.", name)
 	}
 	r := &iam.Role{
 		RoleName: aws.String(name),
@@ -132,7 +132,7 @@ func (e *SystemInstanceRoleEnsurer) GetInstanceProfile(_ string, in *iam.GetInst
 
 	p, ok := e.Profiles[aws.StringValue(in.InstanceProfileName)]
 	if !ok {
-		return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+		return nil, awserrors.Errorf(awserrors.ErrorIAMNoSuchEntity, "Instance Profile %s cannot be found.", aws.StringValue(in.InstanceProfileName))
 	}
 	return &iam.GetInstanceProfileOutput{InstanceProfile: copyProfile(p)}, nil
 }
@@ -148,7 +148,7 @@ func (e *SystemInstanceRoleEnsurer) CreateInstanceProfile(accountID string, in *
 	}
 	name := aws.StringValue(in.InstanceProfileName)
 	if _, ok := e.Profiles[name]; ok {
-		return nil, errors.New(awserrors.ErrorIAMEntityAlreadyExists)
+		return nil, awserrors.Errorf(awserrors.ErrorIAMEntityAlreadyExists, "Instance Profile %s already exists.", name)
 	}
 	arn := "arn:aws:iam::" + accountID + ":instance-profile/" + name
 	if e.EmptyInstanceProfileARN {
@@ -176,7 +176,7 @@ func (e *SystemInstanceRoleEnsurer) AddRoleToInstanceProfile(_ string, in *iam.A
 		return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
 	}
 	if len(p.Roles) > 0 {
-		return nil, errors.New(awserrors.ErrorIAMLimitExceeded)
+		return nil, awserrors.Errorf(awserrors.ErrorIAMLimitExceeded, "Cannot exceed quota for InstanceSessionsPerInstanceProfile: 1")
 	}
 	p.Roles = []*iam.Role{{RoleName: in.RoleName}}
 	return &iam.AddRoleToInstanceProfileOutput{}, nil

spinifex/domains/iam/mock/mock_test.go

@@ -13,7 +13,7 @@ import (
 func TestGetRole_MissingReturnsNoSuchEntity(t *testing.T) {
 	e := mock.New()
 	_, err := e.GetRole("acct", &iam.GetRoleInput{RoleName: aws.String("r1")})
-	if err == nil || err.Error() != awserrors.ErrorIAMNoSuchEntity {
+	if err == nil || awserrors.ValidErrorCodeFromError(err) != awserrors.ErrorIAMNoSuchEntity {
 		t.Fatalf("err = %v, want ErrorIAMNoSuchEntity", err)
 	}
 }
@@ -24,7 +24,7 @@ func TestCreateRole_DuplicateReturnsEntityAlreadyExists(t *testing.T) {
 	if _, err := e.CreateRole("acct", in); err != nil {
 		t.Fatalf("first CreateRole: %v", err)
 	}
-	if _, err := e.CreateRole("acct", in); err == nil || err.Error() != awserrors.ErrorIAMEntityAlreadyExists {
+	if _, err := e.CreateRole("acct", in); err == nil || awserrors.ValidErrorCodeFromError(err) != awserrors.ErrorIAMEntityAlreadyExists {
 		t.Fatalf("second CreateRole err = %v, want EntityAlreadyExists", err)
 	}
 	if e.CreateRoleCalls != 2 {
@@ -48,7 +48,7 @@ func TestAddRoleToInstanceProfile_SecondAttachIsLimitExceeded(t *testing.T) {
 	if _, err := e.AddRoleToInstanceProfile("acct", in); err != nil {
 		t.Fatalf("first AddRoleToInstanceProfile: %v", err)
 	}
-	if _, err := e.AddRoleToInstanceProfile("acct", in); err == nil || err.Error() != awserrors.ErrorIAMLimitExceeded {
+	if _, err := e.AddRoleToInstanceProfile("acct", in); err == nil || awserrors.ValidErrorCodeFromError(err) != awserrors.ErrorIAMLimitExceeded {
 		t.Fatalf("second AddRoleToInstanceProfile err = %v, want LimitExceeded", err)
 	}
 }

spinifex/domains/iam/oidc_providers.go

@@ -178,7 +178,7 @@ func (s *IAMServiceImpl) CreateOpenIDConnectProvider(accountID string, input *ia
 
 	if _, err := kv.Create(ctx, OIDCProviderKey(issuer), data); err != nil {
 		if errors.Is(err, jetstream.ErrKeyExists) {
-			return nil, errors.New(awserrors.ErrorIAMEntityAlreadyExists)
+			return nil, awserrors.Errorf(awserrors.ErrorIAMEntityAlreadyExists, "Provider with url %s already exists.", issuer)
 		}
 		return nil, fmt.Errorf("store OIDC provider: %w", err)
 	}
@@ -268,7 +268,7 @@ func (s *IAMServiceImpl) DeleteOpenIDConnectProvider(accountID string, input *ia
 	kv, err := s.js.KeyValue(ctx, IAMAccountBucketName(accountID))
 	if err != nil {
 		if errors.Is(err, jetstream.ErrBucketNotFound) {
-			return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return nil, oidcProviderNotFound(arn)
 		}
 		return nil, fmt.Errorf("open IAM account bucket: %w", err)
 	}
@@ -276,7 +276,7 @@ func (s *IAMServiceImpl) DeleteOpenIDConnectProvider(accountID string, input *ia
 	key := OIDCProviderKey(issuer)
 	if _, err := kv.Get(ctx, key); err != nil {
 		if errors.Is(err, jetstream.ErrKeyNotFound) {
-			return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return nil, oidcProviderNotFound(arn)
 		}
 		return nil, fmt.Errorf("get OIDC provider: %w", err)
 	}
@@ -356,7 +356,7 @@ func (s *IAMServiceImpl) updateOIDCProviderCAS(ctx context.Context, accountID, a
 	kv, err := s.js.KeyValue(ctx, IAMAccountBucketName(accountID))
 	if err != nil {
 		if errors.Is(err, jetstream.ErrBucketNotFound) {
-			return errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return oidcProviderNotFound(arn)
 		}
 		return fmt.Errorf("open IAM account bucket: %w", err)
 	}
@@ -373,14 +373,14 @@ func (s *IAMServiceImpl) getOIDCProvider(ctx context.Context, accountID, arn str
 	kv, err := s.js.KeyValue(ctx, IAMAccountBucketName(accountID))
 	if err != nil {
 		if errors.Is(err, jetstream.ErrBucketNotFound) {
-			return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return nil, oidcProviderNotFound(arn)
 		}
 		return nil, fmt.Errorf("open IAM account bucket: %w", err)
 	}
 	entry, err := kv.Get(ctx, OIDCProviderKey(issuer))
 	if err != nil {
 		if errors.Is(err, jetstream.ErrKeyNotFound) {
-			return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return nil, oidcProviderNotFound(arn)
 		}
 		return nil, fmt.Errorf("get OIDC provider: %w", err)
 	}

spinifex/domains/iam/oidc_providers_test.go

@@ -50,7 +50,7 @@ func TestCreateOpenIDConnectProvider_Idempotent(t *testing.T) {
 		t.Fatalf("first create: %v", err)
 	}
 	_, err := svc.CreateOpenIDConnectProvider(acct, in)
-	if err == nil || err.Error() != awserrors.ErrorIAMEntityAlreadyExists {
+	if err == nil || awserrors.ValidErrorCodeFromError(err) != awserrors.ErrorIAMEntityAlreadyExists {
 		t.Fatalf("duplicate create err = %v, want EntityAlreadyExists", err)
 	}
 }
@@ -132,7 +132,7 @@ func TestGetOpenIDConnectProvider_NotFound(t *testing.T) {
 	_, err := svc.GetOpenIDConnectProvider("000000000001", &iam.GetOpenIDConnectProviderInput{
 		OpenIDConnectProviderArn: aws.String(OIDCProviderARN("000000000001", "10.0.0.1:9999/oidc/eks/x/y/z")),
 	})
-	if err == nil || err.Error() != awserrors.ErrorIAMNoSuchEntity {
+	if err == nil || awserrors.ValidErrorCodeFromError(err) != awserrors.ErrorIAMNoSuchEntity {
 		t.Fatalf("err = %v, want NoSuchEntity", err)
 	}
 }
@@ -195,7 +195,7 @@ func TestDeleteOpenIDConnectProvider(t *testing.T) {
 	_, err = svc.DeleteOpenIDConnectProvider(acct, &iam.DeleteOpenIDConnectProviderInput{
 		OpenIDConnectProviderArn: created.OpenIDConnectProviderArn,
 	})
-	if err == nil || err.Error() != awserrors.ErrorIAMNoSuchEntity {
+	if err == nil || awserrors.ValidErrorCodeFromError(err) != awserrors.ErrorIAMNoSuchEntity {
 		t.Fatalf("second delete err = %v, want NoSuchEntity", err)
 	}
 }

spinifex/domains/iam/policy_versions.go

@@ -111,11 +111,11 @@ func policyCASTarget(accountID, policyARN string) (string, kvutil.CASConfig, err
 	if err != nil {
 		slog.Debug("policyCASTarget: unparseable policy ARN",
 			"accountID", accountID, "policyArn", policyARN, "err", err)
-		return "", kvutil.CASConfig{}, errors.New(awserrors.ErrorIAMNoSuchEntity)
+		return "", kvutil.CASConfig{}, policyNotFound(policyARN)
 	}
 	return accountID + "." + policyName, kvutil.CASConfig{
 		Attempts: policyCASMaxRetries,
-		NotFound: errors.New(awserrors.ErrorIAMNoSuchEntity),
+		NotFound: policyNotFound(policyARN),
 		Exhausted: func(string, int) error {
 			slog.Error("IAM policy CAS retries exhausted under contention",
 				"accountID", accountID, "policyName", policyName, "attempts", policyCASMaxRetries)

spinifex/domains/iam/records_cas_test.go

@@ -224,11 +224,11 @@ func TestTagUser_DoesNotRecreateConcurrentlyDeletedUser(t *testing.T) {
 	close(gate.release)
 	err = <-done
 	require.Error(t, err)
-	assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, err.Error())
+	assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, awserrors.ValidErrorCodeFromError(err))
 
 	_, err = svc.getUser(t.Context(), testAccountID, *user.UserName)
 	require.Error(t, err)
-	assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, err.Error(), "the deleted user must stay deleted")
+	assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, awserrors.ValidErrorCodeFromError(err), "the deleted user must stay deleted")
 }
 
 // Every group writer that read the record before a DetachGroupPolicy and writes
@@ -376,7 +376,7 @@ func TestOIDCProviderTagWriters_DoNotRecreateDeletedProvider(t *testing.T) {
 			close(gate.release)
 			err = <-done
 			require.Error(t, err)
-			assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, err.Error())
+			assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, awserrors.ValidErrorCodeFromError(err))
 
 			_, err = kv.Get(t.Context(), OIDCProviderKey(testIssuer))
 			assert.ErrorIs(t, err, jetstream.ErrKeyNotFound, "the deleted provider must stay deleted")

spinifex/domains/iam/role_resolver.go

@@ -33,7 +33,7 @@ func (r *RoleResolver) ResolveRole(accountID, roleARN string) (passrole.Role, er
 	}
 	role, err := r.svc.getRole(context.Background(), accountID, name)
 	if err != nil {
-		if err.Error() == awserrors.ErrorIAMNoSuchEntity {
+		if code, _ := awserrors.ResolveErrorCode(err); code == awserrors.ErrorIAMNoSuchEntity {
 			return passrole.Role{}, passrole.ErrNotFound
 		}
 		return passrole.Role{}, err

spinifex/domains/iam/roles.go

@@ -106,7 +106,7 @@ func (s *IAMServiceImpl) CreateRole(accountID string, input *iam.CreateRoleInput
 	kvKey := accountID + "." + roleName
 	if _, err := s.rolesBucket.Create(ctx, kvKey, data); err != nil {
 		if errors.Is(err, jetstream.ErrKeyExists) {
-			return nil, errors.New(awserrors.ErrorIAMEntityAlreadyExists)
+			return nil, awserrors.Errorf(awserrors.ErrorIAMEntityAlreadyExists, "Role with name %s already exists.", roleName)
 		}
 		return nil, fmt.Errorf("store role: %w", err)
 	}
@@ -195,11 +195,11 @@ func (s *IAMServiceImpl) DeleteRole(accountID string, input *iam.DeleteRoleInput
 	}
 
 	if len(role.AttachedPolicies) > 0 {
-		return nil, errors.New(awserrors.ErrorIAMDeleteConflict)
+		return nil, errDetachPoliciesFirst
 	}
 
 	if len(role.InlinePolicies) > 0 {
-		return nil, errors.New(awserrors.ErrorIAMDeleteConflict)
+		return nil, errDeletePoliciesFirst
 	}
 
 	profiles, err := s.findInstanceProfilesForRole(ctx, accountID, roleName)
@@ -207,7 +207,7 @@ func (s *IAMServiceImpl) DeleteRole(accountID string, input *iam.DeleteRoleInput
 		return nil, fmt.Errorf("check role instance profiles: %w", err)
 	}
 	if len(profiles) > 0 {
-		return nil, errors.New(awserrors.ErrorIAMDeleteConflict)
+		return nil, awserrors.Errorf(awserrors.ErrorIAMDeleteConflict, "Cannot delete entity, must remove roles from instance profile first.")
 	}
 
 	if err := s.rolesBucket.Delete(ctx, accountID+"."+roleName); err != nil {
@@ -291,7 +291,7 @@ func (s *IAMServiceImpl) UpdateRoleDescription(accountID string, input *iam.Upda
 	}
 
 	slog.Info("IAM role description updated", "accountID", accountID, "roleName", roleName)
-	return &iam.UpdateRoleDescriptionOutput{Role: gotRoleToSDK(role)}, nil
+	return &iam.UpdateRoleDescriptionOutput{Role: describedRoleToSDK(role)}, nil
 }
 
 func (s *IAMServiceImpl) UpdateAssumeRolePolicy(accountID string, input *iam.UpdateAssumeRolePolicyInput) (*iam.UpdateAssumeRolePolicyOutput, error) {
@@ -326,7 +326,7 @@ func (s *IAMServiceImpl) AttachRolePolicy(accountID string, input *iam.AttachRol
 	// so ListAttachedRolePolicies / DescribeNodegroup round-trip instead of
 	// failing NoSuchEntity. Customer-managed ARNs must still exist.
 	if !iamarn.IsAWSManagedPolicyARN(policyARN) {
-		if _, err := s.getPolicyByARN(ctx, accountID, policyARN); err != nil {
+		if err := s.attachablePolicy(ctx, accountID, policyARN); err != nil {
 			return nil, err
 		}
 	}
@@ -354,7 +354,7 @@ func (s *IAMServiceImpl) DetachRolePolicy(accountID string, input *iam.DetachRol
 	err := s.updateRoleCAS(ctx, accountID, roleName, func(role *Role) (bool, error) {
 		idx := slices.Index(role.AttachedPolicies, policyARN)
 		if idx < 0 {
-			return false, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return false, policyNotFound(policyARN)
 		}
 		role.AttachedPolicies = slices.Delete(role.AttachedPolicies, idx, idx+1)
 		return true, nil
@@ -444,7 +444,7 @@ func (s *IAMServiceImpl) GetRolePolicy(accountID string, input *iam.GetRolePolic
 
 	doc, ok := role.InlinePolicies[policyName]
 	if !ok {
-		return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+		return nil, noSuchEntity("role policy", policyName)
 	}
 
 	return &iam.GetRolePolicyOutput{
@@ -463,7 +463,7 @@ func (s *IAMServiceImpl) DeleteRolePolicy(accountID string, input *iam.DeleteRol
 
 	err := s.updateRoleCAS(ctx, accountID, roleName, func(role *Role) (bool, error) {
 		if _, ok := role.InlinePolicies[policyName]; !ok {
-			return false, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return false, noSuchEntity("role policy", policyName)
 		}
 		delete(role.InlinePolicies, policyName)
 		return true, nil
@@ -600,7 +600,7 @@ func (s *IAMServiceImpl) getRole(ctx context.Context, accountID, roleName string
 	entry, err := s.rolesBucket.Get(ctx, accountID+"."+roleName)
 	if err != nil {
 		if errors.Is(err, jetstream.ErrKeyNotFound) {
-			return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return nil, noSuchEntity("role", roleName)
 		}
 		return nil, fmt.Errorf("get role: %w", err)
 	}
@@ -622,7 +622,7 @@ func (s *IAMServiceImpl) updateRoleCAS(ctx context.Context, accountID, roleName
 	defer s.recordLocks.lock("role/" + accountID + "." + roleName)()
 	_, err := kvutil.Update(ctx, s.rolesBucket, accountID+"."+roleName, kvutil.CASConfig{
 		Attempts: roleCASMaxRetries,
-		NotFound: errors.New(awserrors.ErrorIAMNoSuchEntity),
+		NotFound: noSuchEntity("role", roleName),
 		Exhausted: func(string, int) error {
 			// Only a CAS conflict reaches here, so the role is contended rather than
 			// broken; say so, or the caller's InternalError has no cause anywhere.
@@ -698,6 +698,16 @@ func createdRoleToSDK(r *Role) *iam.Role {
 	return out
 }
 
+// describedRoleToSDK is UpdateRoleDescription's shape, which carries no
+// MaxSessionDuration, Tags or RoleLastUsed.
+func describedRoleToSDK(r *Role) *iam.Role {
+	out := roleToSDK(r)
+	if r.Description != "" {
+		out.Description = aws.String(r.Description)
+	}
+	return out
+}
+
 // listedRoleToSDK is ListRoles' shape, which carries no Tags or RoleLastUsed.
 func listedRoleToSDK(r *Role) *iam.Role {
 	out := roleToSDK(r)

spinifex/domains/iam/roles_test.go

@@ -561,7 +561,13 @@ func TestUpdateRole_NotFound(t *testing.T) {
 func TestUpdateRoleDescription(t *testing.T) {
 	t.Parallel()
 	svc := setupTestIAMService(t)
-	createTestRole(t, svc, "desc-role")
+	_, err := svc.CreateRole(testAccountID, &iam.CreateRoleInput{
+		RoleName:                 aws.String("desc-role"),
+		AssumeRolePolicyDocument: aws.String(validTrustPolicy()),
+		MaxSessionDuration:       aws.Int64(7200),
+		Tags:                     []*iam.Tag{{Key: aws.String("team"), Value: aws.String("infra")}},
+	})
+	require.NoError(t, err)
 
 	out, err := svc.UpdateRoleDescription(testAccountID, &iam.UpdateRoleDescriptionInput{
 		RoleName:    aws.String("desc-role"),
@@ -571,7 +577,15 @@ func TestUpdateRoleDescription(t *testing.T) {
 	got, err := svc.GetRole(testAccountID, &iam.GetRoleInput{RoleName: aws.String("desc-role")})
 	require.NoError(t, err)
 	assert.Equal(t, "new description", *got.Role.Description)
-	assert.Equal(t, got.Role, out.Role, "output carries the role in the GetRole shape")
+	assert.Equal(t, &iam.Role{
+		Path:                     got.Role.Path,
+		RoleName:                 got.Role.RoleName,
+		RoleId:                   got.Role.RoleId,
+		Arn:                      got.Role.Arn,
+		CreateDate:               got.Role.CreateDate,
+		AssumeRolePolicyDocument: got.Role.AssumeRolePolicyDocument,
+		Description:              aws.String("new description"),
+	}, out.Role, "AWS omits MaxSessionDuration, Tags and RoleLastUsed from this output")
 
 	_, err = svc.UpdateRoleDescription(testAccountID, &iam.UpdateRoleDescriptionInput{
 		RoleName:    aws.String("desc-role"),

spinifex/domains/iam/service.go

@@ -15,6 +15,7 @@ type IAMService interface {
 	GetUser(accountID string, input *iam.GetUserInput) (*iam.GetUserOutput, error)
 	ListUsers(accountID string, input *iam.ListUsersInput) (*iam.ListUsersOutput, error)
 	DeleteUser(accountID string, input *iam.DeleteUserInput) (*iam.DeleteUserOutput, error)
+	UpdateUser(accountID string, input *iam.UpdateUserInput) (*iam.UpdateUserOutput, error)
 
 	// Access key lifecycle — account-scoped
 	CreateAccessKey(accountID string, input *iam.CreateAccessKeyInput) (*iam.CreateAccessKeyOutput, error)

spinifex/domains/iam/service_impl.go

@@ -467,7 +467,7 @@ func (s *IAMServiceImpl) CreateUser(accountID string, input *iam.CreateUserInput
 	// Atomic create — fails if key already exists (race-safe)
 	if _, err := s.usersBucket.Create(ctx, kvKey, data); err != nil {
 		if errors.Is(err, jetstream.ErrKeyExists) {
-			return nil, errors.New(awserrors.ErrorIAMEntityAlreadyExists)
+			return nil, awserrors.Errorf(awserrors.ErrorIAMEntityAlreadyExists, "User with name %s already exists.", userName)
 		}
 		return nil, fmt.Errorf("store user: %w", err)
 	}
@@ -587,7 +587,7 @@ func (s *IAMServiceImpl) DeleteUser(accountID string, input *iam.DeleteUserInput
 	// block the delete either; removing the user record drops it.
 	for _, keyID := range user.AccessKeys {
 		if _, err := s.accessKeysBucket.Get(ctx, keyID); err == nil {
-			return nil, errors.New(awserrors.ErrorIAMDeleteConflict)
+			return nil, awserrors.Errorf(awserrors.ErrorIAMDeleteConflict, "Cannot delete entity, must delete access keys first.")
 		} else if !errors.Is(err, jetstream.ErrKeyNotFound) {
 			return nil, fmt.Errorf("get access key: %w", err)
 		}
@@ -595,13 +595,13 @@ func (s *IAMServiceImpl) DeleteUser(accountID string, input *iam.DeleteUserInput
 			"accountID", accountID, "userName", userName, "accessKeyID", keyID)
 	}
 	if len(user.AttachedPolicies) > 0 {
-		return nil, errors.New(awserrors.ErrorIAMDeleteConflict)
+		return nil, errDetachPoliciesFirst
 	}
 	if len(user.Groups) > 0 {
 		return nil, errors.New(awserrors.ErrorIAMDeleteConflict)
 	}
 	if len(user.InlinePolicies) > 0 {
-		return nil, errors.New(awserrors.ErrorIAMDeleteConflict)
+		return nil, errDeletePoliciesFirst
 	}
 
 	if err := s.usersBucket.Delete(ctx, kvKey); err != nil {
@@ -625,6 +625,133 @@ func (s *IAMServiceImpl) DeleteUser(accountID string, input *iam.DeleteUserInput
 	return &iam.DeleteUserOutput{}, nil
 }
 
+// UpdateUser applies NewPath and NewUserName to a user. A rename moves the
+// record to its new key, keeping its ID, access keys, groups and policies.
+func (s *IAMServiceImpl) UpdateUser(accountID string, input *iam.UpdateUserInput) (*iam.UpdateUserOutput, error) {
+	ctx := context.Background()
+	userName := *input.UserName
+	if input.NewUserName != nil {
+		if err := validateIAMName("newUserName", *input.NewUserName, 64); err != nil {
+			return nil, err
+		}
+	}
+	if input.NewPath != nil {
+		if err := validatePath(*input.NewPath); err != nil {
+			return nil, err
+		}
+	}
+
+	newName := aws.StringValue(input.NewUserName)
+	var err error
+	if newName == "" || newName == userName {
+		err = s.updateUserCAS(ctx, accountID, userName, func(u *User) (bool, error) {
+			if input.NewPath == nil || *input.NewPath == u.Path {
+				return false, nil
+			}
+			u.Path = *input.NewPath
+			u.ARN = arn.FormatIAMPath(arn.IAMUser, accountID, u.Path, u.UserName)
+			return true, nil
+		})
+	} else {
+		err = s.renameUser(ctx, accountID, userName, newName, input.NewPath)
+	}
+	if err != nil {
+		return nil, err
+	}
+
+	slog.Info("IAM user updated", "accountID", accountID, "userName", userName, "newUserName", newName)
+	return &iam.UpdateUserOutput{}, nil
+}
+
+// renameUser writes the user under newName and repoints its access keys before
+// deleting the old record at the revision it read. A racing writer of the old
+// record makes that delete fail, so the rename is undone and retried.
+func (s *IAMServiceImpl) renameUser(ctx context.Context, accountID, oldName, newName string, newPath *string) error {
+	oldKey, newKey := accountID+"."+oldName, accountID+"."+newName
+	first, second := oldKey, newKey
+	if second < first {
+		first, second = second, first
+	}
+	defer s.recordLocks.lock("user/" + first)()
+	defer s.recordLocks.lock("user/" + second)()
+
+	for range roleCASMaxRetries {
+		entry, err := s.usersBucket.Get(ctx, oldKey)
+		if err != nil {
+			if errors.Is(err, jetstream.ErrKeyNotFound) {
+				return errors.New(awserrors.ErrorIAMNoSuchEntity)
+			}
+			return fmt.Errorf("get user: %w", err)
+		}
+		var user User
+		if err := json.Unmarshal(entry.Value(), &user); err != nil {
+			return fmt.Errorf("unmarshal user: %w", err)
+		}
+		user.UserName = newName
+		if newPath != nil {
+			user.Path = *newPath
+		}
+		user.ARN = arn.FormatIAMPath(arn.IAMUser, accountID, user.Path, newName)
+		data, err := json.Marshal(user)
+		if err != nil {
+			return fmt.Errorf("marshal user: %w", err)
+		}
+
+		newRev, err := s.usersBucket.Create(ctx, newKey, data)
+		if err != nil {
+			if errors.Is(err, jetstream.ErrKeyExists) {
+				return errors.New(awserrors.ErrorIAMEntityAlreadyExists)
+			}
+			return fmt.Errorf("store renamed user: %w", err)
+		}
+		err = s.setAccessKeysOwner(ctx, accountID, user.AccessKeys, newName)
+		if err == nil {
+			err = s.usersBucket.Delete(ctx, oldKey, jetstream.LastRevision(entry.Revision()))
+			if err == nil {
+				return nil
+			}
+		}
+		s.undoRenameUser(ctx, accountID, user.AccessKeys, oldName, newKey, newRev)
+		if !errors.Is(err, jetstream.ErrKeyRevisionMismatch) {
+			return fmt.Errorf("rename user: %w", err)
+		}
+	}
+	slog.Error("IAM user rename lost every revision race on the old record",
+		"accountID", accountID, "userName", oldName, "attempts", roleCASMaxRetries)
+	return errors.New(awserrors.ErrorServerInternal)
+}
+
+// setAccessKeysOwner points each access key at userName. A listed key with no
+// record is skipped, as ListAccessKeys skips it.
+func (s *IAMServiceImpl) setAccessKeysOwner(ctx context.Context, accountID string, keyIDs []string, userName string) error {
+	for _, keyID := range keyIDs {
+		cfg := iamRecordCASConfig("access key", accountID, keyID)
+		cfg.NotFound = nil
+		_, err := kvutil.Update(ctx, s.accessKeysBucket, keyID, cfg, func(ak *AccessKey) (bool, error) {
+			if ak.UserName == userName {
+				return false, nil
+			}
+			ak.UserName = userName
+			return true, nil
+		})
+		if err != nil && !errors.Is(err, jetstream.ErrKeyNotFound) {
+			return fmt.Errorf("repoint access key %s: %w", keyID, err)
+		}
+	}
+	return nil
+}
+
+// undoRenameUser returns the access keys to oldName and drops the record
+// written under the new name, unless a writer has changed it since.
+func (s *IAMServiceImpl) undoRenameUser(ctx context.Context, accountID string, keyIDs []string, oldName, newKey string, newRev uint64) {
+	if err := s.setAccessKeysOwner(ctx, accountID, keyIDs, oldName); err != nil {
+		slog.Error("Rollback failed: access keys left on renamed user", "accountID", accountID, "userName", oldName, "err", err)
+	}
+	if err := s.usersBucket.Delete(ctx, newKey, jetstream.LastRevision(newRev)); err != nil {
+		slog.Error("Rollback failed: renamed user record left behind", "accountID", accountID, "userName", oldName, "key", newKey, "err", err)
+	}
+}
+
 // ---------------------------------------------------------------------------
 // Access Key Lifecycle
 // ---------------------------------------------------------------------------
@@ -753,7 +880,7 @@ func (s *IAMServiceImpl) DeleteAccessKey(accountID string, input *iam.DeleteAcce
 	err := s.updateUserCAS(ctx, accountID, userName, func(u *User) (bool, error) {
 		idx := slices.Index(u.AccessKeys, accessKeyID)
 		if idx < 0 {
-			return false, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return false, awserrors.Errorf(awserrors.ErrorIAMNoSuchEntity, "The Access Key with id %s cannot be found.", accessKeyID)
 		}
 		u.AccessKeys = slices.Delete(u.AccessKeys, idx, idx+1)
 		return true, nil
@@ -1355,7 +1482,8 @@ func (s *IAMServiceImpl) CreatePolicy(accountID string, input *iam.CreatePolicyI
 
 	if _, err := s.policiesBucket.Create(ctx, kvKey, data); err != nil {
 		if errors.Is(err, jetstream.ErrKeyExists) {
-			return nil, errors.New(awserrors.ErrorIAMEntityAlreadyExists)
+			return nil, awserrors.Errorf(awserrors.ErrorIAMEntityAlreadyExists,
+				"A policy called %s already exists. Duplicate names are not allowed.", policyName)
 		}
 		return nil, fmt.Errorf("store policy: %w", err)
 	}
@@ -1502,7 +1630,7 @@ func (s *IAMServiceImpl) DeletePolicy(accountID string, input *iam.DeletePolicyI
 	// Revision-guarded, so a version created after the checks cannot be deleted unseen.
 	policy, err := kvutil.DeleteIf(ctx, s.policiesBucket, key, cfg, func(p *Policy) error {
 		if p.ARN != policyARN {
-			return errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return policyNotFound(policyARN)
 		}
 		if len(p.OtherVersions) > 0 {
 			return awserrors.Errorf(awserrors.ErrorIAMDeleteConflict,
@@ -1513,7 +1641,7 @@ func (s *IAMServiceImpl) DeletePolicy(accountID string, input *iam.DeletePolicyI
 			return fmt.Errorf("check policy attachments: %w", err)
 		}
 		if counts[p.ARN] > 0 {
-			return errors.New(awserrors.ErrorIAMDeleteConflict)
+			return awserrors.Errorf(awserrors.ErrorIAMDeleteConflict, "Cannot delete a policy attached to entities.")
 		}
 		return nil
 	})
@@ -1612,7 +1740,7 @@ func (s *IAMServiceImpl) AttachUserPolicy(accountID string, input *iam.AttachUse
 	// grant document is modeled in builtinManagedPolicyDoc and resolved at
 	// evaluation time. Customer-managed ARNs must still exist.
 	if !iamarn.IsAWSManagedPolicyARN(policyARN) {
-		if _, err := s.getPolicyByARN(ctx, accountID, policyARN); err != nil {
+		if err := s.attachablePolicy(ctx, accountID, policyARN); err != nil {
 			return nil, err
 		}
 	}
@@ -1640,7 +1768,7 @@ func (s *IAMServiceImpl) DetachUserPolicy(accountID string, input *iam.DetachUse
 	err := s.updateUserCAS(ctx, accountID, userName, func(u *User) (bool, error) {
 		idx := slices.Index(u.AttachedPolicies, policyARN)
 		if idx < 0 {
-			return false, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return false, policyNotFound(policyARN)
 		}
 		u.AttachedPolicies = slices.Delete(u.AttachedPolicies, idx, idx+1)
 		return true, nil
@@ -1774,7 +1902,7 @@ func (s *IAMServiceImpl) GetUserPolicy(accountID string, input *iam.GetUserPolic
 
 	doc, ok := user.InlinePolicies[policyName]
 	if !ok {
-		return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+		return nil, noSuchEntity("user policy", policyName)
 	}
 
 	return &iam.GetUserPolicyOutput{
@@ -1793,7 +1921,7 @@ func (s *IAMServiceImpl) DeleteUserPolicy(accountID string, input *iam.DeleteUse
 
 	err := s.updateUserCAS(ctx, accountID, userName, func(u *User) (bool, error) {
 		if _, ok := u.InlinePolicies[policyName]; !ok {
-			return false, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return false, noSuchEntity("user policy", policyName)
 		}
 		delete(u.InlinePolicies, policyName)
 		return true, nil
@@ -1984,7 +2112,7 @@ func (s *IAMServiceImpl) GetUserPolicies(accountID, userName string) ([]PolicyDo
 	for _, groupName := range user.Groups {
 		group, err := s.getGroup(ctx, accountID, groupName)
 		if err != nil {
-			if err.Error() == awserrors.ErrorIAMNoSuchEntity {
+			if code, _ := awserrors.ResolveErrorCode(err); code == awserrors.ErrorIAMNoSuchEntity {
 				slog.Warn("GetUserPolicies: member references missing group; skipping",
 					"accountID", accountID, "user", userName, "group", groupName)
 				continue
@@ -2025,7 +2153,7 @@ func (s *IAMServiceImpl) getPolicyByARN(ctx context.Context, accountID, policyAR
 		entry, err := s.policiesBucket.Get(ctx, kvKey)
 		if err != nil {
 			if errors.Is(err, jetstream.ErrKeyNotFound) {
-				return "", errors.New(awserrors.ErrorIAMNoSuchEntity)
+				return "", policyNotFound(policyARN)
 			}
 			return "", fmt.Errorf("get policy: %w", err)
 		}
@@ -2042,9 +2170,9 @@ func (s *IAMServiceImpl) getPolicyByARN(ctx context.Context, accountID, policyAR
 		// otherwise a malformed ARN is indistinguishable from a missing policy.
 		slog.Debug("getPolicyByARN: unparseable policy ARN",
 			"accountID", accountID, "policyArn", policyARN, "err", err)
-		return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+		return nil, policyNotFound(policyARN)
 	case errors.Is(err, iamarn.ErrPolicyARNMismatch):
-		return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+		return nil, policyNotFound(policyARN)
 	case err != nil:
 		return nil, err
 	}
@@ -2166,12 +2294,45 @@ func (s *IAMServiceImpl) buildAttachmentCounts(ctx context.Context, accountID st
 	return counts, nil
 }
 
+// noSuchEntity is NoSuchEntity with AWS's message naming the missing user,
+// role, group or inline policy, e.g. "The role with name X cannot be found.".
+func noSuchEntity(kind, name string) error {
+	return awserrors.Errorf(awserrors.ErrorIAMNoSuchEntity, "The %s with name %s cannot be found.", kind, name)
+}
+
+// policyNotFound is NoSuchEntity with AWS's message for a managed policy ARN
+// that names no stored policy, or none attached to the entity.
+func policyNotFound(policyARN string) error {
+	return awserrors.Errorf(awserrors.ErrorIAMNoSuchEntity, "Policy %s was not found.", policyARN)
+}
+
+// oidcProviderNotFound is NoSuchEntity with AWS's message for a missing OIDC provider.
+func oidcProviderNotFound(providerARN string) error {
+	return awserrors.Errorf(awserrors.ErrorIAMNoSuchEntity, "OpenIDConnect Provider not found for arn %s", providerARN)
+}
+
+// The DeleteConflict messages AWS shares across users, roles and groups.
+var (
+	errDetachPoliciesFirst = awserrors.Errorf(awserrors.ErrorIAMDeleteConflict, "Cannot delete entity, must detach all policies first.")
+	errDeletePoliciesFirst = awserrors.Errorf(awserrors.ErrorIAMDeleteConflict, "Cannot delete entity, must delete policies first.")
+)
+
+// attachablePolicy refuses a customer-managed policy ARN that names no stored
+// policy, with the message AWS gives on attach.
+func (s *IAMServiceImpl) attachablePolicy(ctx context.Context, accountID, policyARN string) error {
+	_, err := s.getPolicyByARN(ctx, accountID, policyARN)
+	if code, _ := awserrors.ResolveErrorCode(err); code == awserrors.ErrorIAMNoSuchEntity {
+		return awserrors.Errorf(awserrors.ErrorIAMNoSuchEntity, "Policy %s does not exist or is not attachable.", policyARN)
+	}
+	return err
+}
+
 func (s *IAMServiceImpl) getUser(ctx context.Context, accountID, userName string) (*User, error) {
 	kvKey := accountID + "." + userName
 	entry, err := s.usersBucket.Get(ctx, kvKey)
 	if err != nil {
 		if errors.Is(err, jetstream.ErrKeyNotFound) {
-			return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+			return nil, noSuchEntity("user", userName)
 		}
 		return nil, fmt.Errorf("get user: %w", err)
 	}
@@ -2195,9 +2356,13 @@ func (s *IAMServiceImpl) updateUserCAS(ctx context.Context, accountID, userName
 // iamRecordCASConfig is the CAS policy for an IAM user, group or OIDC provider
 // record: a missing record is NoSuchEntity and exhausted retries are logged.
 func iamRecordCASConfig(kind, accountID, name string) kvutil.CASConfig {
+	notFound := noSuchEntity(kind, name)
+	if kind == "oidc-provider" {
+		notFound = oidcProviderNotFound(name)
+	}
 	return kvutil.CASConfig{
 		Attempts: roleCASMaxRetries,
-		NotFound: errors.New(awserrors.ErrorIAMNoSuchEntity),
+		NotFound: notFound,
 		Exhausted: func(string, int) error {
 			slog.Error("IAM record CAS retries exhausted under contention",
 				"kind", kind, "accountID", accountID, "name", name, "attempts", roleCASMaxRetries)

spinifex/domains/iam/system_role.go

@@ -48,7 +48,7 @@ func EnsureSystemInstanceProfile(e SystemInstanceRoleEnsurer, accountID, roleNam
 // there draws credentials from it, so provisioning one would be unasked-for.
 func ConvergeSystemRolePolicy(e SystemInstanceRoleEnsurer, accountID, roleName, policyName, policyDoc string) error {
 	if _, err := e.GetRole(accountID, &iam.GetRoleInput{RoleName: aws.String(roleName)}); err != nil {
-		if err.Error() == awserrors.ErrorIAMNoSuchEntity {
+		if code, _ := awserrors.ResolveErrorCode(err); code == awserrors.ErrorIAMNoSuchEntity {
 			return nil
 		}
 		return fmt.Errorf("get role %q: %w", roleName, err)
@@ -68,7 +68,7 @@ func ConvergeSystemRolePolicy(e SystemInstanceRoleEnsurer, accountID, roleName,
 func ensureSystemRole(e SystemInstanceRoleEnsurer, accountID, roleName string) error {
 	if _, err := e.GetRole(accountID, &iam.GetRoleInput{RoleName: aws.String(roleName)}); err == nil {
 		return nil
-	} else if err.Error() != awserrors.ErrorIAMNoSuchEntity {
+	} else if code, _ := awserrors.ResolveErrorCode(err); code != awserrors.ErrorIAMNoSuchEntity {
 		return fmt.Errorf("get role %q: %w", roleName, err)
 	}
 
@@ -77,7 +77,7 @@ func ensureSystemRole(e SystemInstanceRoleEnsurer, accountID, roleName string) e
 		AssumeRolePolicyDocument: aws.String(EC2InstanceTrustPolicy),
 		Description:              aws.String("Spinifex-managed system instance role"),
 	})
-	if err == nil || err.Error() == awserrors.ErrorIAMEntityAlreadyExists {
+	if code, _ := awserrors.ResolveErrorCode(err); err == nil || code == awserrors.ErrorIAMEntityAlreadyExists {
 		return nil
 	}
 	return fmt.Errorf("create role %q: %w", roleName, err)
@@ -94,7 +94,7 @@ func ensureSystemInstanceProfile(e SystemInstanceRoleEnsurer, accountID, roleNam
 		return attachSystemRole(e, accountID, roleName,
 			aws.StringValue(out.InstanceProfile.Arn), len(out.InstanceProfile.Roles) > 0)
 	}
-	if err.Error() != awserrors.ErrorIAMNoSuchEntity {
+	if code, _ := awserrors.ResolveErrorCode(err); code != awserrors.ErrorIAMNoSuchEntity {
 		return "", fmt.Errorf("get instance profile %q: %w", roleName, err)
 	}
 
@@ -102,7 +102,7 @@ func ensureSystemInstanceProfile(e SystemInstanceRoleEnsurer, accountID, roleNam
 		InstanceProfileName: aws.String(roleName),
 	})
 	if err != nil {
-		if err.Error() != awserrors.ErrorIAMEntityAlreadyExists {
+		if code, _ := awserrors.ResolveErrorCode(err); code != awserrors.ErrorIAMEntityAlreadyExists {
 			return "", fmt.Errorf("create instance profile %q: %w", roleName, err)
 		}
 		got, gerr := e.GetInstanceProfile(accountID, &iam.GetInstanceProfileInput{
@@ -128,7 +128,7 @@ func attachSystemRole(e SystemInstanceRoleEnsurer, accountID, roleName, profileA
 		InstanceProfileName: aws.String(roleName),
 		RoleName:            aws.String(roleName),
 	})
-	if err != nil && err.Error() != awserrors.ErrorIAMLimitExceeded {
+	if code, _ := awserrors.ResolveErrorCode(err); err != nil && code != awserrors.ErrorIAMLimitExceeded {
 		return "", fmt.Errorf("add role %q to instance profile %q: %w", roleName, roleName, err)
 	}
 	return profileARN, nil

spinifex/domains/iam/tags_test.go

@@ -460,7 +460,7 @@ func TestCreate_InvalidTagsRefusedAndNotStored(t *testing.T) {
 
 				_, err = ops.list(svc, id)
 				require.Error(t, err)
-				assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, err.Error())
+				assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, awserrors.ValidErrorCodeFromError(err))
 			})
 		}
 	}
@@ -577,15 +577,15 @@ func TestResourceTagging_MissingEntity(t *testing.T) {
 
 			err := ops.tag(svc, ops.missingID, []*iam.Tag{sdkTag("env", "prod")})
 			require.Error(t, err)
-			assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, err.Error())
+			assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, awserrors.ValidErrorCodeFromError(err))
 
 			err = ops.untag(svc, ops.missingID, []*string{aws.String("env")})
 			require.Error(t, err)
-			assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, err.Error())
+			assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, awserrors.ValidErrorCodeFromError(err))
 
 			_, err = ops.list(svc, ops.missingID)
 			require.Error(t, err)
-			assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, err.Error())
+			assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, awserrors.ValidErrorCodeFromError(err))
 		})
 	}
 }
@@ -608,7 +608,7 @@ func TestTagUser_MergedLimitExceeded(t *testing.T) {
 		Tags:     []*iam.Tag{sdkTag("overflow", "v")},
 	})
 	require.Error(t, err)
-	assert.Equal(t, awserrors.ErrorIAMLimitExceeded, err.Error())
+	assert.Equal(t, awserrors.ErrorIAMLimitExceeded, awserrors.ValidErrorCodeFromError(err))
 
 	// Upserting an existing key does not grow the set and stays allowed.
 	_, err = svc.TagUser(testAccountID, &iam.TagUserInput{

spinifex/domains/iam/user_update_test.go

@@ -0,0 +1,203 @@
+package iam
+
+import (
+	"context"
+	"encoding/json"
+	"testing"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/service/iam"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+	"github.com/nats-io/nats.go/jetstream"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestUpdateUser_RenameKeepsRelationships(t *testing.T) {
+	t.Parallel()
+	svc := setupTestIAMService(t)
+	before := createTestUser(t, svc, "bob")
+	policy := createTestPolicy(t, svc, "bob-managed")
+	createTestGroup(t, svc, "devs")
+
+	_, err := svc.AttachUserPolicy(testAccountID, &iam.AttachUserPolicyInput{UserName: aws.String("bob"), PolicyArn: policy.Arn})
+	require.NoError(t, err)
+	_, err = svc.PutUserPolicy(testAccountID, &iam.PutUserPolicyInput{
+		UserName: aws.String("bob"), PolicyName: aws.String("inline"), PolicyDocument: aws.String(validPolicyDocument()),
+	})
+	require.NoError(t, err)
+	_, err = svc.AddUserToGroup(testAccountID, &iam.AddUserToGroupInput{UserName: aws.String("bob"), GroupName: aws.String("devs")})
+	require.NoError(t, err)
+	key, err := svc.CreateAccessKey(testAccountID, &iam.CreateAccessKeyInput{UserName: aws.String("bob")})
+	require.NoError(t, err)
+
+	out, err := svc.UpdateUser(testAccountID, &iam.UpdateUserInput{
+		UserName: aws.String("bob"), NewUserName: aws.String("robert"), NewPath: aws.String("/eng/"),
+	})
+	require.NoError(t, err)
+	assert.Equal(t, &iam.UpdateUserOutput{}, out)
+
+	_, err = svc.GetUser(testAccountID, &iam.GetUserInput{UserName: aws.String("bob")})
+	require.Error(t, err)
+	code, ok := awserrors.ResolveErrorCode(err)
+	require.True(t, ok, "no AWS code on %v", err)
+	assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, code)
+
+	got, err := svc.GetUser(testAccountID, &iam.GetUserInput{UserName: aws.String("robert")})
+	require.NoError(t, err)
+	assert.Equal(t, *before.UserId, *got.User.UserId)
+	assert.Equal(t, "/eng/", *got.User.Path)
+	assert.Equal(t, "arn:aws:iam::"+testAccountID+":user/eng/robert", *got.User.Arn)
+
+	ak, err := svc.LookupAccessKey(*key.AccessKey.AccessKeyId)
+	require.NoError(t, err)
+	assert.Equal(t, "robert", ak.UserName)
+	keys, err := svc.ListAccessKeys(testAccountID, &iam.ListAccessKeysInput{UserName: aws.String("robert")})
+	require.NoError(t, err)
+	require.Len(t, keys.AccessKeyMetadata, 1)
+	assert.Equal(t, *key.AccessKey.AccessKeyId, *keys.AccessKeyMetadata[0].AccessKeyId)
+
+	attached, err := svc.ListAttachedUserPolicies(testAccountID, &iam.ListAttachedUserPoliciesInput{UserName: aws.String("robert")})
+	require.NoError(t, err)
+	require.Len(t, attached.AttachedPolicies, 1)
+	assert.Equal(t, *policy.Arn, *attached.AttachedPolicies[0].PolicyArn)
+
+	inline, err := svc.ListUserPolicies(testAccountID, &iam.ListUserPoliciesInput{UserName: aws.String("robert")})
+	require.NoError(t, err)
+	assert.Equal(t, []*string{aws.String("inline")}, inline.PolicyNames)
+
+	groups, err := svc.ListGroupsForUser(testAccountID, &iam.ListGroupsForUserInput{UserName: aws.String("robert")})
+	require.NoError(t, err)
+	require.Len(t, groups.Groups, 1)
+	assert.Equal(t, "devs", *groups.Groups[0].GroupName)
+
+	members, err := svc.GetGroup(testAccountID, &iam.GetGroupInput{GroupName: aws.String("devs")})
+	require.NoError(t, err)
+	require.Len(t, members.Users, 1)
+	assert.Equal(t, "robert", *members.Users[0].UserName)
+}
+
+func TestUpdateUser_PathOnly(t *testing.T) {
+	t.Parallel()
+	svc := setupTestIAMService(t)
+	createTestUser(t, svc, "carol")
+
+	_, err := svc.UpdateUser(testAccountID, &iam.UpdateUserInput{UserName: aws.String("carol"), NewPath: aws.String("/ops/")})
+	require.NoError(t, err)
+
+	got, err := svc.GetUser(testAccountID, &iam.GetUserInput{UserName: aws.String("carol")})
+	require.NoError(t, err)
+	assert.Equal(t, "/ops/", *got.User.Path)
+	assert.Equal(t, "arn:aws:iam::"+testAccountID+":user/ops/carol", *got.User.Arn)
+}
+
+func TestUpdateUser_Errors(t *testing.T) {
+	t.Parallel()
+	svc := setupTestIAMService(t)
+	createTestUser(t, svc, "dave")
+	createTestUser(t, svc, "erin")
+
+	tests := []struct {
+		name  string
+		input *iam.UpdateUserInput
+		want  string
+	}{
+		{"missing user", &iam.UpdateUserInput{UserName: aws.String("ghost"), NewPath: aws.String("/x/")}, awserrors.ErrorIAMNoSuchEntity},
+		{"missing user rename", &iam.UpdateUserInput{UserName: aws.String("ghost"), NewUserName: aws.String("ghost2")}, awserrors.ErrorIAMNoSuchEntity},
+		{"taken name", &iam.UpdateUserInput{UserName: aws.String("dave"), NewUserName: aws.String("erin")}, awserrors.ErrorIAMEntityAlreadyExists},
+		{"bad name", &iam.UpdateUserInput{UserName: aws.String("dave"), NewUserName: aws.String("no spaces")}, awserrors.ErrorValidationError},
+		{"bad path", &iam.UpdateUserInput{UserName: aws.String("dave"), NewPath: aws.String("noslash")}, awserrors.ErrorValidationError},
+	}
+	for _, tc := range tests {
+		_, err := svc.UpdateUser(testAccountID, tc.input)
+		require.Error(t, err, tc.name)
+		assert.True(t, awserrors.IsErrorCode(err, tc.want), "%s: got %v want %s", tc.name, err, tc.want)
+	}
+
+	got, err := svc.GetUser(testAccountID, &iam.GetUserInput{UserName: aws.String("dave")})
+	require.NoError(t, err)
+	assert.Equal(t, "/", *got.User.Path, "a refused update leaves the user unchanged")
+}
+
+// racingUsersKV writes the old user record once, right after the renamed
+// record is created, as a concurrent AttachUserPolicy on another node would.
+type racingUsersKV struct {
+	jetstream.KeyValue
+
+	oldKey string
+	raced  bool
+}
+
+func (k *racingUsersKV) Create(ctx context.Context, key string, value []byte, opts ...jetstream.KVCreateOpt) (uint64, error) {
+	rev, err := k.KeyValue.Create(ctx, key, value, opts...)
+	if err != nil || k.raced {
+		return rev, err
+	}
+	k.raced = true
+	entry, gerr := k.Get(ctx, k.oldKey)
+	if gerr != nil {
+		return rev, gerr
+	}
+	var u User
+	if uerr := json.Unmarshal(entry.Value(), &u); uerr != nil {
+		return rev, uerr
+	}
+	u.AttachedPolicies = append(u.AttachedPolicies, "arn:aws:iam::"+testAccountID+":policy/raced")
+	data, _ := json.Marshal(u)
+	if _, perr := k.Update(ctx, k.oldKey, data, entry.Revision()); perr != nil {
+		return rev, perr
+	}
+	return rev, nil
+}
+
+func TestUpdateUser_RenameRetriesAfterRacingWrite(t *testing.T) {
+	t.Parallel()
+	svc := setupTestIAMService(t)
+	createTestUser(t, svc, "frank")
+	key, err := svc.CreateAccessKey(testAccountID, &iam.CreateAccessKeyInput{UserName: aws.String("frank")})
+	require.NoError(t, err)
+	svc.usersBucket = &racingUsersKV{KeyValue: svc.usersBucket, oldKey: testAccountID + ".frank"}
+
+	_, err = svc.UpdateUser(testAccountID, &iam.UpdateUserInput{UserName: aws.String("frank"), NewUserName: aws.String("franklin")})
+	require.NoError(t, err)
+
+	user, err := svc.getUser(t.Context(), testAccountID, "franklin")
+	require.NoError(t, err)
+	assert.Equal(t, []string{"arn:aws:iam::" + testAccountID + ":policy/raced"}, user.AttachedPolicies,
+		"the racing write survives the rename")
+	_, err = svc.getUser(t.Context(), testAccountID, "frank")
+	code, ok := awserrors.ResolveErrorCode(err)
+	require.True(t, ok, "no AWS code on %v", err)
+	assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, code)
+	ak, err := svc.LookupAccessKey(*key.AccessKey.AccessKeyId)
+	require.NoError(t, err)
+	assert.Equal(t, "franklin", ak.UserName)
+}
+
+// UpdateUser names its user by bare name, so the caller's account is the only
+// scope: a rename must never reach a same-named user in another account.
+func TestUpdateUser_ScopedToCallerAccount(t *testing.T) {
+	t.Parallel()
+	svc := setupTestIAMService(t)
+	const other = "999988887777"
+	mine := createTestUser(t, svc, "bob")
+	theirs, err := svc.CreateUser(other, &iam.CreateUserInput{UserName: aws.String("bob")})
+	require.NoError(t, err)
+	_, err = svc.CreateUser(other, &iam.CreateUserInput{UserName: aws.String("carol")})
+	require.NoError(t, err)
+
+	_, err = svc.UpdateUser(testAccountID, &iam.UpdateUserInput{UserName: aws.String("bob"), NewUserName: aws.String("robert")})
+	require.NoError(t, err)
+	got, err := svc.GetUser(other, &iam.GetUserInput{UserName: aws.String("bob")})
+	require.NoError(t, err)
+	assert.Equal(t, *theirs.User.UserId, *got.User.UserId)
+	assert.NotEqual(t, *mine.UserId, *got.User.UserId)
+
+	_, err = svc.UpdateUser(testAccountID, &iam.UpdateUserInput{UserName: aws.String("carol"), NewUserName: aws.String("caroline")})
+	require.Error(t, err)
+	code, ok := awserrors.ResolveErrorCode(err)
+	require.True(t, ok, "no AWS code on %v", err)
+	assert.Equal(t, awserrors.ErrorIAMNoSuchEntity, code)
+	_, err = svc.GetUser(other, &iam.GetUserInput{UserName: aws.String("carol")})
+	require.NoError(t, err)
+}

spinifex/domains/lambda/awsapi/create.go

@@ -0,0 +1,168 @@
+package awsapi
+
+import (
+	"context"
+	"crypto/rand"
+	"encoding/base64"
+	"encoding/hex"
+	"fmt"
+	"log/slog"
+	"net/http"
+	"strconv"
+	"time"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/service/lambda"
+	"github.com/mulgadc/spinifex/spinifex/domains/lambda/codestore"
+	"github.com/mulgadc/spinifex/spinifex/domains/lambda/function"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/arn"
+	awserrors "github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+)
+
+const (
+	rollbackDeadline = 10 * time.Second
+	lastModifiedFmt  = "2006-01-02T15:04:05.000-0700"
+)
+
+func randomID() (string, error) {
+	b := make([]byte, 16)
+	if _, err := rand.Read(b); err != nil {
+		return "", err
+	}
+	return hex.EncodeToString(b), nil
+}
+
+func serviceError(msg string) error {
+	return awserrors.Errorf(awserrors.ErrorServiceException, "%s", msg)
+}
+
+// createFunction implements CreateFunction. The name is claimed first, the code
+// copy written second, and the claim completed last, so a failure at any point
+// leaves either a free name or a claim that expires on its own.
+func (d Deps) createFunction(ctx context.Context, c *call) (reply, error) {
+	p, err := validateCreate(c.Create)
+	if err != nil {
+		return reply{}, err
+	}
+	functionID, err := randomID()
+	if err != nil {
+		return reply{}, serviceError("could not generate a function identifier")
+	}
+	revisionID, err := randomID()
+	if err != nil {
+		return reply{}, serviceError("could not generate a revision identifier")
+	}
+	var envCipher string
+	if len(p.Env) > 0 {
+		if d.AEAD == nil {
+			return reply{}, serviceError("environment encryption is unavailable")
+		}
+		if envCipher, err = function.SealEnv(d.AEAD, c.AccountID, functionID, p.Env); err != nil {
+			slog.ErrorContext(ctx, "Lambda: seal environment failed", "function_id", functionID, "err", err)
+			return reply{}, serviceError("could not protect the function environment")
+		}
+	}
+
+	rec := function.Record{
+		FormatVersion: function.FormatVersion,
+		FunctionID:    functionID,
+		AccountID:     c.AccountID,
+		Region:        c.Region,
+		FunctionName:  p.Name,
+		Role:          p.Role,
+		Runtime:       supportedRuntime,
+		Handler:       p.Handler,
+		Description:   p.Description,
+		Timeout:       p.TimeoutSec,
+		MemorySize:    p.MemorySize,
+		EnvCipher:     envCipher,
+		State:         function.StatePending,
+		Code:          function.Code{RevisionID: revisionID, State: function.CodeStoring},
+	}
+	createRev, err := d.Meta.Create(ctx, c.AccountID, c.Region, rec)
+	if err != nil {
+		return reply{}, err
+	}
+
+	ref := codestore.Ref{AccountID: c.AccountID, FunctionID: functionID, RevisionID: revisionID}
+	store, err := d.Codes(ctx)
+	if err != nil {
+		d.rollback(ctx, c, p.Name, createRev, ref, "code store unavailable", err)
+		return reply{}, serviceError("the function code could not be stored")
+	}
+	sha, err := store.Put(ctx, ref, p.Code)
+	if err != nil {
+		d.rollback(ctx, c, p.Name, createRev, ref, "code write failed", err)
+		return reply{}, serviceError("the function code could not be stored")
+	}
+	stored, storedRev, err := d.Meta.CodeStored(ctx, c.AccountID, c.Region, p.Name, createRev, sha, int64(len(p.Code)))
+	if err != nil {
+		d.rollback(ctx, c, p.Name, createRev, ref, "code-stored was not recorded", err)
+		return reply{}, serviceError("the function could not be completed")
+	}
+
+	cfg, err := configuration(stored, storedRev, p.Env)
+	if err != nil {
+		return reply{}, serviceError("could not build the function configuration")
+	}
+	return reply{Status: http.StatusCreated, Body: cfg}, nil
+}
+
+// rollback makes one compare-and-swap attempt to free the name. It cannot undo
+// a create that completed, because the revision it holds has moved on. The code
+// object, if one landed, is left in place and recorded as a cleanup obligation.
+func (d Deps) rollback(ctx context.Context, c *call, name string, createRev uint64, ref codestore.Ref, why string, cause error) {
+	slog.ErrorContext(ctx, "Lambda: create did not complete", "reason", why, "function_name", name,
+		"function_id", ref.FunctionID, "err", cause)
+	rctx, cancel := context.WithTimeout(context.WithoutCancel(ctx), rollbackDeadline)
+	defer cancel()
+	if err := d.Meta.RollbackCreate(rctx, c.AccountID, c.Region, name, createRev); err != nil {
+		slog.WarnContext(ctx, "Lambda: rollback of the name claim failed; it expires on its own",
+			"function_name", name, "function_id", ref.FunctionID, "err", err)
+	}
+	slog.WarnContext(ctx, "Lambda: code object cleanup is owed",
+		"account_id", ref.AccountID, "function_id", ref.FunctionID, "revision_id", ref.RevisionID)
+}
+
+// configuration renders the record as a FunctionConfiguration.
+func configuration(rec function.Record, revision uint64, env map[string]string) (*lambda.FunctionConfiguration, error) {
+	cfg := &lambda.FunctionConfiguration{
+		FunctionName:     aws.String(rec.FunctionName),
+		FunctionArn:      aws.String(arn.FormatLambdaFunction(rec.Region, rec.AccountID, rec.FunctionName)),
+		Runtime:          aws.String(rec.Runtime),
+		Role:             aws.String(rec.Role),
+		Handler:          aws.String(rec.Handler),
+		Description:      aws.String(rec.Description),
+		Timeout:          aws.Int64(rec.Timeout),
+		MemorySize:       aws.Int64(rec.MemorySize),
+		LastModified:     aws.String(rec.LastModified.UTC().Format(lastModifiedFmt)),
+		Version:          aws.String("$LATEST"),
+		State:            aws.String(rec.State),
+		PackageType:      aws.String(lambda.PackageTypeZip),
+		Architectures:    aws.StringSlice([]string{lambda.ArchitectureX8664}),
+		RevisionId:       aws.String(strconv.FormatUint(revision, 10)),
+		LastUpdateStatus: aws.String(lambda.LastUpdateStatusSuccessful),
+		EphemeralStorage: &lambda.EphemeralStorage{Size: aws.Int64(512)},
+		LoggingConfig:    &lambda.LoggingConfig{LogFormat: aws.String(lambda.LogFormatText), LogGroup: aws.String(logGroup(rec.FunctionName))},
+	}
+	if rec.StateReason != "" {
+		cfg.StateReason = aws.String(rec.StateReason)
+		cfg.StateReasonCode = aws.String(rec.StateReasonCode)
+	}
+	if rec.Code.State == function.CodeStored {
+		raw, err := hex.DecodeString(rec.Code.SHA256)
+		if err != nil {
+			return nil, fmt.Errorf("stored digest is not hex: %w", err)
+		}
+		cfg.CodeSha256 = aws.String(base64.StdEncoding.EncodeToString(raw))
+		cfg.CodeSize = aws.Int64(rec.Code.Size)
+	}
+	if len(env) > 0 {
+		vars := make(map[string]*string, len(env))
+		for k, v := range env {
+			vars[k] = aws.String(v)
+		}
+		cfg.Environment = &lambda.EnvironmentResponse{Variables: vars}
+	}
+	return cfg, nil
+}

spinifex/domains/lambda/awsapi/get.go

@@ -0,0 +1,82 @@
+package awsapi
+
+import (
+	"context"
+	"errors"
+	"log/slog"
+	"net/http"
+	"time"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/service/lambda"
+	"github.com/mulgadc/spinifex/spinifex/domains/lambda/codestore"
+	"github.com/mulgadc/spinifex/spinifex/domains/lambda/function"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/arn"
+	awserrors "github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+)
+
+// codeURLTTL is how long the presigned code location stays valid.
+const codeURLTTL = 10 * time.Minute
+
+func notFound(region, accountID, name string) error {
+	return awserrors.Errorf(awserrors.ErrorResourceNotFoundException, "Function not found: %s",
+		arn.FormatLambdaFunction(region, accountID, name))
+}
+
+// getFunction implements GetFunction for the $LATEST version.
+func (d Deps) getFunction(ctx context.Context, c *call) (reply, error) {
+	name, q, err := resolveFunctionName(c.Region, c.AccountID, c.Params[0])
+	if err != nil {
+		return reply{}, err
+	}
+	if query := c.Query.Get("Qualifier"); query != "" {
+		if q != "" && q != query {
+			return reply{}, invalid("The derived qualifier from the function name does not match the specified qualifier.")
+		}
+		q = query
+	}
+	if q != "" && q != "$LATEST" {
+		return reply{}, notFound(c.Region, c.AccountID, name+":"+q)
+	}
+	rec, revision, err := d.Meta.Get(ctx, c.AccountID, c.Region, name)
+	if errors.Is(err, function.ErrNotFound) {
+		return reply{}, notFound(c.Region, c.AccountID, name)
+	}
+	if err != nil {
+		return reply{}, err
+	}
+
+	var env map[string]string
+	if rec.EnvCipher != "" {
+		if d.AEAD == nil {
+			return reply{}, serviceError("environment decryption is unavailable")
+		}
+		if env, err = function.OpenEnv(d.AEAD, rec.AccountID, rec.FunctionID, rec.EnvCipher); err != nil {
+			slog.ErrorContext(ctx, "Lambda: open environment failed", "function_id", rec.FunctionID, "err", err)
+			return reply{}, serviceError("could not read the function environment")
+		}
+	}
+	cfg, err := configuration(rec, revision, env)
+	if err != nil {
+		return reply{}, serviceError("could not build the function configuration")
+	}
+	out := &lambda.GetFunctionOutput{
+		Configuration: cfg,
+		Code:          &lambda.FunctionCodeLocation{RepositoryType: aws.String("S3")},
+	}
+	if rec.Code.State == function.CodeStored {
+		store, err := d.Codes(ctx)
+		if err != nil {
+			slog.ErrorContext(ctx, "Lambda: code store unavailable for GetFunction", "function_id", rec.FunctionID, "err", err)
+			return reply{}, serviceError("the function code location is unavailable")
+		}
+		ref := codestore.Ref{AccountID: rec.AccountID, FunctionID: rec.FunctionID, RevisionID: rec.Code.RevisionID}
+		location, err := store.PresignGet(ctx, ref, rec.Code.SHA256, codeURLTTL)
+		if err != nil {
+			slog.ErrorContext(ctx, "Lambda: presign code location failed", "function_id", rec.FunctionID, "err", err)
+			return reply{}, serviceError("the function code location is unavailable")
+		}
+		out.Code.Location = aws.String(location)
+	}
+	return reply{Status: http.StatusOK, Body: out}, nil
+}

spinifex/domains/lambda/awsapi/handler_test.go

@@ -0,0 +1,669 @@
+package awsapi_test
+
+import (
+	"archive/zip"
+	"bytes"
+	"context"
+	"crypto/sha256"
+	"encoding/base64"
+	"encoding/hex"
+	"encoding/json"
+	"errors"
+	"net/http"
+	"net/http/httptest"
+	"runtime"
+	"strings"
+	"sync"
+	"testing"
+	"time"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/service/lambda"
+	"github.com/mulgadc/bluebottle/pkg/auth"
+	"github.com/mulgadc/bluebottle/pkg/masterkey"
+	"github.com/mulgadc/spinifex/internal/testkit"
+	"github.com/mulgadc/spinifex/internal/testkit/gwtest"
+	iamdomain "github.com/mulgadc/spinifex/spinifex/domains/iam"
+	"github.com/mulgadc/spinifex/spinifex/domains/lambda/awsapi"
+	"github.com/mulgadc/spinifex/spinifex/domains/lambda/codestore"
+	"github.com/mulgadc/spinifex/spinifex/domains/lambda/function"
+	awserrors "github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/passrole"
+	"github.com/nats-io/nats.go/jetstream"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+const (
+	roleARN        = "arn:aws:iam::" + gwtest.AccountID + ":role/lambda-exec"
+	foreignRoleARN = "arn:aws:iam::999999999999:role/lambda-exec"
+)
+
+// localClient reaches a real MetaService without NATS.
+type localClient struct {
+	svc *function.MetaService
+
+	mu             sync.Mutex
+	failCodeStored bool
+	passOwnerClock bool
+	rollbacks      int
+}
+
+var _ function.Client = (*localClient)(nil)
+
+func (c *localClient) Create(ctx context.Context, account, region string, rec function.Record) (uint64, error) {
+	r, err := c.svc.Create(ctx, &function.CreateRequest{Region: region, Record: rec}, account)
+	if err != nil {
+		return 0, err
+	}
+	return r.Revision, nil
+}
+
+func (c *localClient) Get(ctx context.Context, account, region, name string) (function.Record, uint64, error) {
+	r, err := c.svc.Get(ctx, &function.GetRequest{Region: region, FunctionName: name}, account)
+	if err != nil {
+		return function.Record{}, 0, err
+	}
+	if !r.Found {
+		return function.Record{}, 0, function.ErrNotFound
+	}
+	return r.Record, r.Revision, nil
+}
+
+func (c *localClient) CodeStored(ctx context.Context, account, region, name string, rev uint64, sha string, size int64) (function.Record, uint64, error) {
+	c.mu.Lock()
+	fail, passClock := c.failCodeStored, c.passOwnerClock
+	c.mu.Unlock()
+	if fail {
+		return function.Record{}, 0, errors.New("nats: timeout")
+	}
+	r, err := c.svc.CodeStored(ctx, &function.CodeStoredRequest{Region: region, FunctionName: name, Revision: rev, SHA256: sha, Size: size}, account)
+	if err != nil {
+		return function.Record{}, 0, err
+	}
+	// Let the wall clock pass the owner's millisecond, so a timestamp the
+	// gateway reads for itself would differ from the stored one.
+	for passClock && !time.Now().Truncate(time.Millisecond).After(r.Record.LastModified.Truncate(time.Millisecond)) {
+		runtime.Gosched()
+	}
+	return r.Record, r.Revision, nil
+}
+
+func (c *localClient) RollbackCreate(ctx context.Context, account, region, name string, rev uint64) error {
+	c.mu.Lock()
+	c.rollbacks++
+	c.mu.Unlock()
+	_, err := c.svc.RollbackCreate(ctx, &function.RollbackCreateRequest{Region: region, FunctionName: name, Revision: rev}, account)
+	return err
+}
+
+// memStore is an in-memory code store; objects is keyed by Ref.
+type memStore struct {
+	mu      sync.Mutex
+	objects map[codestore.Ref][]byte
+	putErr  error
+	urlErr  error
+}
+
+var _ awsapi.CodeStore = (*memStore)(nil)
+
+func (m *memStore) Put(_ context.Context, ref codestore.Ref, code []byte) (string, error) {
+	m.mu.Lock()
+	defer m.mu.Unlock()
+	if m.putErr != nil {
+		return "", m.putErr
+	}
+	m.objects[ref] = append([]byte(nil), code...)
+	sum := sha256.Sum256(code)
+	return hex.EncodeToString(sum[:]), nil
+}
+
+func (m *memStore) PresignGet(_ context.Context, ref codestore.Ref, sha string, ttl time.Duration) (string, error) {
+	if m.urlErr != nil {
+		return "", m.urlErr
+	}
+	return "https://code.test/" + ref.FunctionID + "/" + sha + "?ttl=" + ttl.String(), nil
+}
+
+func (m *memStore) count() int {
+	m.mu.Lock()
+	defer m.mu.Unlock()
+	return len(m.objects)
+}
+
+type roleSet map[string]bool
+
+func (r roleSet) ResolveRole(accountID, arn string) (passrole.Role, error) {
+	acct, name, err := auth.ParseRoleARN(arn)
+	if err != nil {
+		return passrole.Role{}, passrole.ErrMalformed
+	}
+	if acct != accountID {
+		return passrole.Role{}, passrole.ErrForeignAccount
+	}
+	if !r[arn] {
+		return passrole.Role{}, passrole.ErrNotFound
+	}
+	return passrole.Role{ARN: arn, Name: name}, nil
+}
+
+func newHarness(t *testing.T, statements ...iamdomain.Statement) (*gwtest.Harness, *localClient, *memStore, func(*testing.T) jetstream.KeyValue, *masterkey.Key) {
+	t.Helper()
+	_, _, js := testutil.StartTestJetStream(t)
+	key, err := masterkey.New(make([]byte, 32))
+	require.NoError(t, err)
+	meta := &localClient{svc: function.NewMetaService(js)}
+	store := &memStore{objects: map[codestore.Ref][]byte{}}
+	kv := func(t *testing.T) jetstream.KeyValue {
+		t.Helper()
+		b, err := js.KeyValue(t.Context(), function.KVAccountBucket(gwtest.AccountID))
+		require.NoError(t, err)
+		return b
+	}
+	return gwtest.Scoped(statements...), meta, store, kv, key
+}
+
+type env struct {
+	h     *gwtest.Harness
+	meta  *localClient
+	store *memStore
+	kv    func(*testing.T) jetstream.KeyValue
+	deps  awsapi.Deps
+}
+
+func newEnv(t *testing.T, statements ...iamdomain.Statement) *env {
+	t.Helper()
+	if len(statements) == 0 {
+		statements = []iamdomain.Statement{gwtest.Statement("Allow", "*", "*")}
+	}
+	h, meta, store, kv, key := newHarness(t, statements...)
+	e := &env{h: h, meta: meta, store: store, kv: kv}
+	e.deps = awsapi.Deps{
+		Meta: meta,
+		Codes: func(context.Context) (awsapi.CodeStore, error) {
+			return store, nil
+		},
+		Roles:  roleSet{roleARN: true},
+		Trusts: func(string, string) (bool, error) { return true, nil },
+		AEAD:   key.AEAD,
+	}
+	return e
+}
+
+func (e *env) do(method, path string, body any) (*httptest.ResponseRecorder, error) {
+	var raw []byte
+	if body != nil {
+		raw, _ = json.Marshal(body)
+	}
+	rec := httptest.NewRecorder()
+	req := httptest.NewRequest(method, path, strings.NewReader(string(raw)))
+	err := e.h.Dispatch(awsapi.NewRegistration(e.deps), awsapi.ServiceName, rec, req)
+	return rec, err
+}
+
+var testZip = buildZip("hello")
+
+func buildZip(content string) []byte {
+	var buf bytes.Buffer
+	w := zip.NewWriter(&buf)
+	f, err := w.Create("bootstrap")
+	if err == nil {
+		_, err = f.Write([]byte(content))
+	}
+	if err == nil {
+		err = w.Close()
+	}
+	if err != nil {
+		panic(err)
+	}
+	return buf.Bytes()
+}
+
+func mustZip(t *testing.T, content string) []byte {
+	t.Helper()
+	return buildZip(content)
+}
+
+func createBody(name string, mutate func(map[string]any)) map[string]any {
+	b := map[string]any{
+		"FunctionName": name,
+		"Runtime":      "provided.al2023",
+		"Role":         roleARN,
+		"Handler":      "bootstrap",
+		"Code":         map[string]any{"ZipFile": testZip},
+	}
+	if mutate != nil {
+		mutate(b)
+	}
+	return b
+}
+
+func requireCode(t *testing.T, err error, code string) {
+	t.Helper()
+	require.Error(t, err)
+	got, ok := awserrors.ResolveErrorCode(err)
+	require.True(t, ok, "no AWS code on %v", err)
+	assert.Equal(t, code, got)
+}
+
+func TestCreateFunction_Success(t *testing.T) {
+	e := newEnv(t)
+	code := testZip
+	rec, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", func(b map[string]any) {
+		b["Environment"] = map[string]any{"Variables": map[string]string{"DB_PASSWORD": "hunter2"}}
+		b["Description"] = "demo"
+		b["Timeout"] = 30
+		b["MemorySize"] = 256
+	}))
+	require.NoError(t, err)
+	require.Equal(t, http.StatusCreated, rec.Code)
+
+	var cfg lambda.FunctionConfiguration
+	require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &cfg))
+	sum := sha256.Sum256(code)
+	assert.Equal(t, base64.StdEncoding.EncodeToString(sum[:]), *cfg.CodeSha256, "AWS reports base64 of the raw digest")
+	assert.Equal(t, int64(len(code)), *cfg.CodeSize)
+	assert.Equal(t, "Pending", *cfg.State)
+	assert.Equal(t, "Creating", *cfg.StateReasonCode)
+	assert.Equal(t, "arn:aws:lambda:"+gwtest.Region+":"+gwtest.AccountID+":function:hello", *cfg.FunctionArn)
+	assert.Equal(t, "$LATEST", *cfg.Version)
+	assert.Equal(t, "Zip", *cfg.PackageType)
+	assert.Equal(t, int64(30), *cfg.Timeout)
+	assert.Equal(t, int64(256), *cfg.MemorySize)
+	assert.Equal(t, "hunter2", *cfg.Environment.Variables["DB_PASSWORD"])
+	assert.Regexp(t, `^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}\.\d{3}\+0000$`, *cfg.LastModified)
+
+	require.Equal(t, 1, e.store.count())
+	for _, stored := range e.store.objects {
+		assert.Equal(t, code, stored, "the code copy is retrievable")
+	}
+
+	entry, err := e.kv(t).Get(t.Context(), function.KVFunctionKey(gwtest.Region, "hello"))
+	require.NoError(t, err)
+	assert.NotContains(t, string(entry.Value()), "hunter2", "the environment is never stored in plaintext")
+	assert.Contains(t, string(entry.Value()), "envCipher")
+}
+
+func TestCreateFunction_RendersTheStoredTimestamps(t *testing.T) {
+	e := newEnv(t)
+	e.meta.passOwnerClock = true
+	rec, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", nil))
+	require.NoError(t, err)
+	var created lambda.FunctionConfiguration
+	require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &created))
+
+	rec, err = e.do(http.MethodGet, "/2015-03-31/functions/hello", nil)
+	require.NoError(t, err)
+	var got lambda.GetFunctionOutput
+	require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &got))
+	assert.Equal(t, *got.Configuration.LastModified, *created.LastModified)
+	assert.Equal(t, *got.Configuration.RevisionId, *created.RevisionId)
+}
+
+func TestCreateFunction_DuplicateNameLeavesFirstUntouched(t *testing.T) {
+	e := newEnv(t)
+	_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", nil))
+	require.NoError(t, err)
+	first, _, err := e.meta.Get(t.Context(), gwtest.AccountID, gwtest.Region, "hello")
+	require.NoError(t, err)
+
+	_, err = e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", func(b map[string]any) {
+		b["Code"] = map[string]any{"ZipFile": mustZip(t, "different")}
+	}))
+	requireCode(t, err, awserrors.ErrorResourceConflictException)
+	assert.Contains(t, err.Error(), "Function already exist: hello")
+
+	assert.Equal(t, 1, e.store.count(), "the loser wrote no code")
+	after, _, err := e.meta.Get(t.Context(), gwtest.AccountID, gwtest.Region, "hello")
+	require.NoError(t, err)
+	assert.Equal(t, first, after)
+}
+
+func TestCreateFunction_CodePutFailureFreesTheName(t *testing.T) {
+	e := newEnv(t)
+	e.store.putErr = errors.New("predastore down")
+	_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", nil))
+	requireCode(t, err, awserrors.ErrorServiceException)
+	assert.NotContains(t, err.Error(), "predastore down")
+	assert.Equal(t, 1, e.meta.rollbacks)
+	_, _, err = e.meta.Get(t.Context(), gwtest.AccountID, gwtest.Region, "hello")
+	require.ErrorIs(t, err, function.ErrNotFound)
+
+	e.store.putErr = nil
+	rec, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", nil))
+	require.NoError(t, err)
+	assert.Equal(t, http.StatusCreated, rec.Code)
+}
+
+func TestCreateFunction_CodeStoredFailureRollsBackOnce(t *testing.T) {
+	e := newEnv(t)
+	e.meta.failCodeStored = true
+	_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", nil))
+	requireCode(t, err, awserrors.ErrorServiceException)
+	assert.Equal(t, 1, e.meta.rollbacks)
+	assert.Equal(t, 1, e.store.count(), "the code object is left in place, never deleted here")
+	_, _, err = e.meta.Get(t.Context(), gwtest.AccountID, gwtest.Region, "hello")
+	require.ErrorIs(t, err, function.ErrNotFound, "the still-storing claim was withdrawn")
+}
+
+func TestCreateFunction_RefusesUnsupportedInput(t *testing.T) {
+	cases := map[string]func(map[string]any){
+		"Code.S3Bucket":        func(b map[string]any) { b["Code"] = map[string]any{"S3Bucket": "b", "S3Key": "k"} },
+		"Code.S3Key":           func(b map[string]any) { b["Code"] = map[string]any{"ZipFile": []byte("x"), "S3Key": "k"} },
+		"Code.S3ObjectVersion": func(b map[string]any) { b["Code"] = map[string]any{"ZipFile": []byte("x"), "S3ObjectVersion": "v"} },
+		"Code.ImageUri":        func(b map[string]any) { b["Code"] = map[string]any{"ImageUri": "x"} },
+		"Code.SourceKMSKeyArn": func(b map[string]any) { b["Code"] = map[string]any{"ZipFile": []byte("x"), "SourceKMSKeyArn": "k"} },
+		"Layers":               func(b map[string]any) { b["Layers"] = []string{"arn:aws:lambda:r:1:layer:l:1"} },
+		"VpcConfig":            func(b map[string]any) { b["VpcConfig"] = map[string]any{"SubnetIds": []string{"subnet-1"}} },
+		"KMSKeyArn":            func(b map[string]any) { b["KMSKeyArn"] = "arn:aws:kms:r:1:key/k" },
+		"DeadLetterConfig":     func(b map[string]any) { b["DeadLetterConfig"] = map[string]any{"TargetArn": "arn:aws:sqs:r:1:q"} },
+		"TracingConfig":        func(b map[string]any) { b["TracingConfig"] = map[string]any{"Mode": "Active"} },
+		"FileSystemConfigs": func(b map[string]any) {
+			b["FileSystemConfigs"] = []map[string]any{{"Arn": "a", "LocalMountPath": "/mnt/x"}}
+		},
+		"ImageConfig":          func(b map[string]any) { b["ImageConfig"] = map[string]any{"Command": []string{"x"}} },
+		"Architectures":        func(b map[string]any) { b["Architectures"] = []string{"arm64"} },
+		"Publish":              func(b map[string]any) { b["Publish"] = true },
+		"SnapStart":            func(b map[string]any) { b["SnapStart"] = map[string]any{"ApplyOn": "PublishedVersions"} },
+		"EphemeralStorage":     func(b map[string]any) { b["EphemeralStorage"] = map[string]any{"Size": 1024} },
+		"CodeSigningConfigArn": func(b map[string]any) { b["CodeSigningConfigArn"] = "arn:aws:lambda:r:1:code-signing-config:c" },
+		"LoggingConfig":        func(b map[string]any) { b["LoggingConfig"] = map[string]any{"LogFormat": "JSON"} },
+		"Tags":                 func(b map[string]any) { b["Tags"] = map[string]string{"a": "b"} },
+		"TenancyConfig":        func(b map[string]any) { b["TenancyConfig"] = map[string]any{"TenantIsolationMode": "PER_TENANT"} },
+	}
+	for field, mutate := range cases {
+		t.Run(field, func(t *testing.T) {
+			e := newEnv(t)
+			_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", mutate))
+			requireCode(t, err, awserrors.ErrorInvalidParameterValueException)
+			assert.Zero(t, e.store.count())
+			_, _, getErr := e.meta.Get(t.Context(), gwtest.AccountID, gwtest.Region, "hello")
+			require.ErrorIs(t, getErr, function.ErrNotFound, "a refused request claims nothing")
+		})
+	}
+}
+
+func TestCreateFunction_AcceptsDefaultsEquivalentToAbsent(t *testing.T) {
+	e := newEnv(t)
+	rec, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", func(b map[string]any) {
+		b["Architectures"] = []string{"x86_64"}
+		b["Publish"] = false
+		b["EphemeralStorage"] = map[string]any{"Size": 512}
+		b["TracingConfig"] = map[string]any{"Mode": "PassThrough"}
+		b["PackageType"] = "Zip"
+		b["Layers"] = []string{}
+		b["Tags"] = map[string]string{}
+		b["LoggingConfig"] = map[string]any{"LogFormat": "Text", "LogGroup": "/aws/lambda/hello"}
+	}))
+	require.NoError(t, err)
+	assert.Equal(t, http.StatusCreated, rec.Code)
+}
+
+func TestCreateFunction_RefusesNonDefaultLoggingConfig(t *testing.T) {
+	for _, cfg := range []map[string]any{
+		{"LogGroup": "/custom/group"},
+		{"LogFormat": "Text", "LogGroup": "/aws/lambda/other"},
+		{"LogFormat": "Text", "ApplicationLogLevel": "DEBUG"},
+		{"SystemLogLevel": "WARN"},
+	} {
+		e := newEnv(t)
+		_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", func(b map[string]any) { b["LoggingConfig"] = cfg }))
+		requireCode(t, err, awserrors.ErrorInvalidParameterValueException)
+		_, _, getErr := e.meta.Get(t.Context(), gwtest.AccountID, gwtest.Region, "hello")
+		require.ErrorIs(t, getErr, function.ErrNotFound, "%v claims nothing", cfg)
+	}
+}
+
+func TestFunctionResponses_CarryTheDefaultLoggingConfig(t *testing.T) {
+	e := newEnv(t)
+	rec, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", nil))
+	require.NoError(t, err)
+	var created lambda.FunctionConfiguration
+	require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &created))
+	want := &lambda.LoggingConfig{LogFormat: aws.String("Text"), LogGroup: aws.String("/aws/lambda/hello")}
+	assert.Equal(t, want, created.LoggingConfig)
+
+	rec, err = e.do(http.MethodGet, "/2015-03-31/functions/hello", nil)
+	require.NoError(t, err)
+	var got lambda.GetFunctionOutput
+	require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &got))
+	assert.Equal(t, want, got.Configuration.LoggingConfig)
+}
+
+func TestCreateFunction_ParameterValidation(t *testing.T) {
+	cases := map[string]func(map[string]any){
+		"bad name":        func(b map[string]any) { b["FunctionName"] = "has space" },
+		"arn name":        func(b map[string]any) { b["FunctionName"] = "arn:aws:lambda:r:1:function:x" },
+		"long name":       func(b map[string]any) { b["FunctionName"] = strings.Repeat("a", 65) },
+		"runtime":         func(b map[string]any) { b["Runtime"] = "python3.12" },
+		"no runtime":      func(b map[string]any) { delete(b, "Runtime") },
+		"package type":    func(b map[string]any) { b["PackageType"] = "Image" },
+		"no code":         func(b map[string]any) { delete(b, "Code") },
+		"empty zip":       func(b map[string]any) { b["Code"] = map[string]any{"ZipFile": []byte{}} },
+		"no handler":      func(b map[string]any) { delete(b, "Handler") },
+		"no role":         func(b map[string]any) { delete(b, "Role") },
+		"timeout low":     func(b map[string]any) { b["Timeout"] = 0 },
+		"timeout high":    func(b map[string]any) { b["Timeout"] = 901 },
+		"memory low":      func(b map[string]any) { b["MemorySize"] = 64 },
+		"memory high":     func(b map[string]any) { b["MemorySize"] = 10241 },
+		"cross account":   func(b map[string]any) { b["Role"] = foreignRoleARN },
+		"missing role":    func(b map[string]any) { b["Role"] = "arn:aws:iam::" + gwtest.AccountID + ":role/ghost" },
+		"not a role arn":  func(b map[string]any) { b["Role"] = "arn:aws:iam::" + gwtest.AccountID + ":user/alice" },
+		"malformed body":  func(b map[string]any) { b["Timeout"] = "soon" },
+		"empty env name":  func(b map[string]any) { b["Environment"] = map[string]any{"Variables": map[string]string{"": "x"}} },
+		"description len": func(b map[string]any) { b["Description"] = strings.Repeat("d", 257) },
+	}
+	for name, mutate := range cases {
+		t.Run(name, func(t *testing.T) {
+			e := newEnv(t)
+			_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", mutate))
+			requireCode(t, err, awserrors.ErrorInvalidParameterValueException)
+			assert.Zero(t, e.store.count())
+		})
+	}
+}
+
+func TestCreateFunction_RoleErrorsDoNotLeakAcrossAccounts(t *testing.T) {
+	e := newEnv(t)
+	_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", func(b map[string]any) { b["Role"] = foreignRoleARN }))
+	requireCode(t, err, awserrors.ErrorInvalidParameterValueException)
+	assert.Contains(t, err.Error(), "cannot be assumed by Lambda")
+}
+
+func TestCreateFunction_RefusesBytesThatAreNotAZip(t *testing.T) {
+	e := newEnv(t)
+	_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", func(b map[string]any) {
+		b["Code"] = map[string]any{"ZipFile": []byte("PK\x03\x04 not really a zip")}
+	}))
+	requireCode(t, err, awserrors.ErrorInvalidParameterValueException)
+	assert.Contains(t, err.Error(), "Could not unzip uploaded file")
+	_, _, err = e.meta.Get(t.Context(), gwtest.AccountID, gwtest.Region, "hello")
+	require.ErrorIs(t, err, function.ErrNotFound)
+	assert.Empty(t, e.store.objects)
+}
+
+func TestCreateFunction_RoleLambdaCannotAssumeRecordsNothing(t *testing.T) {
+	e := newEnv(t)
+	e.deps.Trusts = func(string, string) (bool, error) { return false, nil }
+	_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", nil))
+	requireCode(t, err, awserrors.ErrorInvalidParameterValueException)
+	assert.Contains(t, err.Error(), "cannot be assumed by Lambda")
+	_, _, err = e.meta.Get(t.Context(), gwtest.AccountID, gwtest.Region, "hello")
+	require.ErrorIs(t, err, function.ErrNotFound)
+	assert.Empty(t, e.store.objects)
+}
+
+func TestCreateFunction_MissingRoleCheckFailsClosed(t *testing.T) {
+	for name, mutate := range map[string]func(*awsapi.Deps){
+		"no resolver":      func(d *awsapi.Deps) { d.Roles = nil },
+		"no trust checker": func(d *awsapi.Deps) { d.Trusts = nil },
+	} {
+		t.Run(name, func(t *testing.T) {
+			e := newEnv(t)
+			mutate(&e.deps)
+			_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", nil))
+			requireCode(t, err, awserrors.ErrorServiceException)
+			_, _, err = e.meta.Get(t.Context(), gwtest.AccountID, gwtest.Region, "hello")
+			require.ErrorIs(t, err, function.ErrNotFound)
+		})
+	}
+}
+
+func TestGetFunction_DecryptsEnvAndLocatesStoredCode(t *testing.T) {
+	e := newEnv(t)
+	_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", func(b map[string]any) {
+		b["Environment"] = map[string]any{"Variables": map[string]string{"MODE": "prod"}}
+	}))
+	require.NoError(t, err)
+
+	rec, err := e.do(http.MethodGet, "/2015-03-31/functions/hello", nil)
+	require.NoError(t, err)
+	require.Equal(t, http.StatusOK, rec.Code)
+	var out lambda.GetFunctionOutput
+	require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &out))
+	assert.Equal(t, "prod", *out.Configuration.Environment.Variables["MODE"])
+	assert.Equal(t, "S3", *out.Code.RepositoryType)
+	require.NotNil(t, out.Code.Location)
+	assert.Contains(t, *out.Code.Location, "https://code.test/")
+	assert.Contains(t, *out.Code.Location, "ttl=10m0s")
+
+	rec, err = e.do(http.MethodGet, "/2015-03-31/functions/hello?Qualifier=%24LATEST", nil)
+	require.NoError(t, err)
+	assert.Equal(t, http.StatusOK, rec.Code)
+	_, err = e.do(http.MethodGet, "/2015-03-31/functions/hello?Qualifier=3", nil)
+	requireCode(t, err, awserrors.ErrorResourceNotFoundException)
+}
+
+func TestGetFunction_AcceptsSameAccountARNForms(t *testing.T) {
+	e := newEnv(t)
+	_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", nil))
+	require.NoError(t, err)
+	full := "arn:aws:lambda:" + gwtest.Region + ":" + gwtest.AccountID + ":function:hello"
+	esc := func(s string) string { return strings.ReplaceAll(strings.ReplaceAll(s, ":", "%3A"), "$", "%24") }
+
+	for _, name := range []string{full, full + ":$LATEST", gwtest.AccountID + ":function:hello", "hello:$LATEST"} {
+		t.Run(name, func(t *testing.T) {
+			rec, err := e.do(http.MethodGet, "/2015-03-31/functions/"+esc(name), nil)
+			require.NoError(t, err)
+			require.Equal(t, http.StatusOK, rec.Code)
+			var out lambda.GetFunctionOutput
+			require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &out))
+			assert.Equal(t, full, *out.Configuration.FunctionArn)
+		})
+	}
+
+	notFound := map[string]string{
+		"other account":   "arn:aws:lambda:" + gwtest.Region + ":999999999999:function:hello",
+		"other region":    "arn:aws:lambda:us-west-2:" + gwtest.AccountID + ":function:hello",
+		"partial foreign": "999999999999:function:hello",
+		"version":         full + ":3",
+	}
+	for label, name := range notFound {
+		t.Run(label, func(t *testing.T) {
+			_, err := e.do(http.MethodGet, "/2015-03-31/functions/"+esc(name), nil)
+			requireCode(t, err, awserrors.ErrorResourceNotFoundException)
+		})
+	}
+
+	_, err = e.do(http.MethodGet, "/2015-03-31/functions/"+esc(full+":$LATEST")+"?Qualifier=3", nil)
+	requireCode(t, err, awserrors.ErrorInvalidParameterValueException)
+	_, err = e.do(http.MethodGet, "/2015-03-31/functions/"+esc("arn:aws:s3:::bucket"), nil)
+	requireCode(t, err, awserrors.ErrorInvalidParameterValueException)
+}
+
+func TestGetFunction_NoLocationUntilCodeIsStored(t *testing.T) {
+	e := newEnv(t)
+	_, err := e.meta.Create(t.Context(), gwtest.AccountID, gwtest.Region, function.Record{
+		FunctionID: "f1", FunctionName: "pending", Role: roleARN, Runtime: "provided.al2023", Handler: "h",
+		Timeout: 3, MemorySize: 128, Code: function.Code{RevisionID: "r1"},
+	})
+	require.NoError(t, err)
+
+	rec, err := e.do(http.MethodGet, "/2015-03-31/functions/pending", nil)
+	require.NoError(t, err)
+	var out lambda.GetFunctionOutput
+	require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &out))
+	assert.Nil(t, out.Code.Location)
+	assert.Nil(t, out.Configuration.CodeSha256)
+	assert.Equal(t, "Pending", *out.Configuration.State)
+}
+
+func TestGetFunction_FailsWithoutAnOffHostCodeURL(t *testing.T) {
+	e := newEnv(t)
+	_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", nil))
+	require.NoError(t, err)
+	e.store.urlErr = codestore.ErrNoPresignEndpoint
+
+	rec, err := e.do(http.MethodGet, "/2015-03-31/functions/hello", nil)
+	requireCode(t, err, awserrors.ErrorServiceException)
+	assert.NotContains(t, rec.Body.String(), "Location")
+}
+
+func TestGetFunction_NotFoundNamesTheARN(t *testing.T) {
+	e := newEnv(t)
+	_, err := e.do(http.MethodGet, "/2015-03-31/functions/ghost", nil)
+	requireCode(t, err, awserrors.ErrorResourceNotFoundException)
+	assert.Contains(t, err.Error(), "Function not found: arn:aws:lambda:"+gwtest.Region+":"+gwtest.AccountID+":function:ghost")
+}
+
+func TestGetFunction_FunctionsAreRegional(t *testing.T) {
+	e := newEnv(t)
+	_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", nil))
+	require.NoError(t, err)
+	e.h.Region = "us-west-2"
+	_, err = e.do(http.MethodGet, "/2015-03-31/functions/hello", nil)
+	requireCode(t, err, awserrors.ErrorResourceNotFoundException)
+}
+
+func TestAuthorization(t *testing.T) {
+	create := func(e *env) error {
+		_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", nil))
+		return err
+	}
+	get := func(e *env) error {
+		_, err := e.do(http.MethodGet, "/2015-03-31/functions/hello", nil)
+		return err
+	}
+
+	t.Run("create needs lambda:CreateFunction", func(t *testing.T) {
+		e := newEnv(t, gwtest.Statement("Allow", "lambda:GetFunction", "*"), gwtest.Statement("Allow", "iam:PassRole", "*"))
+		gwtest.AssertDenied(t, create(e))
+		assert.Zero(t, e.store.count())
+	})
+	t.Run("create needs iam:PassRole", func(t *testing.T) {
+		e := newEnv(t, gwtest.Statement("Allow", "lambda:*", "*"))
+		gwtest.AssertDenied(t, create(e))
+		assert.Zero(t, e.store.count())
+	})
+	t.Run("create is scoped to the function ARN", func(t *testing.T) {
+		arn := "arn:aws:lambda:" + gwtest.Region + ":" + gwtest.AccountID + ":function:hello"
+		e := newEnv(t,
+			gwtest.Statement("Allow", "lambda:*", "*"),
+			gwtest.Statement("Allow", "iam:PassRole", "*"),
+			gwtest.Statement("Deny", "lambda:CreateFunction", arn))
+		gwtest.AssertDenied(t, create(e))
+	})
+	t.Run("create passes with both grants", func(t *testing.T) {
+		e := newEnv(t, gwtest.Statement("Allow", "lambda:CreateFunction", "*"), gwtest.Statement("Allow", "iam:PassRole", "*"))
+		require.NoError(t, create(e))
+	})
+	t.Run("get needs lambda:GetFunction", func(t *testing.T) {
+		e := newEnv(t, gwtest.Statement("Allow", "lambda:CreateFunction", "*"))
+		gwtest.AssertDenied(t, get(e))
+	})
+	t.Run("a denied caller does not learn a role is absent", func(t *testing.T) {
+		e := newEnv(t, gwtest.Statement("Allow", "lambda:*", "*"))
+		_, err := e.do(http.MethodPost, "/2015-03-31/functions", createBody("hello", func(b map[string]any) {
+			b["Role"] = "arn:aws:iam::" + gwtest.AccountID + ":role/ghost"
+		}))
+		gwtest.AssertDenied(t, err)
+	})
+}
+
+func TestRegistration_ResolvesActionsAndInventory(t *testing.T) {
+	reg := awsapi.NewRegistration(awsapi.Deps{})
+	assert.Equal(t, []string{"CreateFunction", "GetFunction"}, reg.Inventory.Registered)
+	assert.Equal(t, "CreateFunction", reg.ResolveAction(httptest.NewRequest(http.MethodPost, "/2015-03-31/functions", nil)))
+	assert.Equal(t, "GetFunction", reg.ResolveAction(httptest.NewRequest(http.MethodGet, "/2015-03-31/functions/x", nil)))
+	assert.Empty(t, reg.ResolveAction(httptest.NewRequest(http.MethodDelete, "/2015-03-31/functions/x", nil)))
+}

spinifex/domains/lambda/awsapi/registration.go

@@ -0,0 +1,196 @@
+// Package awsapi serves the Lambda REST-JSON control plane (API version
+// 2015-03-31) for the actions this build supports.
+package awsapi
+
+import (
+	"context"
+	"crypto/cipher"
+	"errors"
+	"io"
+	"log/slog"
+	"net/http"
+	"time"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/private/protocol/json/jsonutil"
+	"github.com/mulgadc/spinifex/spinifex/domains/lambda/codestore"
+	"github.com/mulgadc/spinifex/spinifex/domains/lambda/function"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/arn"
+	awserrors "github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/passrole"
+	"github.com/mulgadc/spinifex/spinifex/ingress/aws/dispatch"
+	"github.com/mulgadc/spinifex/spinifex/ingress/aws/envelope"
+)
+
+// ServiceName is the SigV4 credential-scope service Lambda clients sign for.
+const ServiceName = "lambda"
+
+// servicePrincipal is the service a function execution role is passed to.
+const servicePrincipal = "lambda.amazonaws.com"
+
+// CodeStore is what the handlers need of the Regional code store.
+type CodeStore interface {
+	Put(ctx context.Context, ref codestore.Ref, code []byte) (string, error)
+	PresignGet(ctx context.Context, ref codestore.Ref, sha256Hex string, ttl time.Duration) (string, error)
+}
+
+var _ CodeStore = (*codestore.Store)(nil)
+
+// CodeStoreFunc opens the code store on first use; it fails while the store is
+// not ready.
+type CodeStoreFunc func(ctx context.Context) (CodeStore, error)
+
+// Deps are the composed capabilities the Lambda control plane dispatches to.
+type Deps struct {
+	Meta  function.Client
+	Codes CodeStoreFunc
+	Roles passrole.Resolver
+	// Trusts reports whether the role's trust policy lets Lambda assume it for
+	// the account; false is a refusal, an error an outage.
+	Trusts func(accountID, roleARN string) (bool, error)
+	// AEAD seals function environment variables; it is the master key's cipher.
+	AEAD cipher.AEAD
+}
+
+// NewRegistration returns the Lambda REST-JSON registration.
+func NewRegistration(deps Deps) dispatch.Registration {
+	return dispatch.Registration{
+		Service:       ServiceName,
+		ResolveAction: resolveAction,
+		Dispatch:      deps.dispatch,
+		Errors:        dispatch.ErrorEnvelopeRESTJSON,
+		Inventory:     dispatch.Inventory{Registered: actionNames()},
+	}
+}
+
+func resolveAction(r *http.Request) string {
+	action, _, _, _ := router.Lookup(r.Method, r.URL.EscapedPath())
+	return action
+}
+
+func readBody(r *http.Request) ([]byte, error) {
+	body, err := io.ReadAll(io.LimitReader(r.Body, maxBodyBytes+1))
+	if err != nil {
+		return nil, errors.New(awserrors.ErrorInvalidParameterValueException)
+	}
+	if len(body) > maxBodyBytes {
+		return nil, errors.New(awserrors.ErrorRequestEntityTooLarge)
+	}
+	return body, nil
+}
+
+// functionARN names the function the request is about, or "*" when the request
+// does not yet name a legal one, so a malformed request stays the handler's
+// validation fault rather than becoming an authorization failure.
+func functionARN(region, accountID, name string) string {
+	if region == "" || accountID == "" || !nameRE.MatchString(name) {
+		return "*"
+	}
+	return arn.FormatLambdaFunction(region, accountID, name)
+}
+
+// serve resolves the route, authorizes the request, then runs the action.
+func (d Deps) serve(w http.ResponseWriter, inv dispatch.Invocation) error {
+	r := inv.Request
+	action, params, handler, ok := router.Lookup(r.Method, r.URL.EscapedPath())
+	if !ok {
+		return errors.New(awserrors.ErrorInvalidAction)
+	}
+	if inv.AccountID == "" {
+		slog.ErrorContext(r.Context(), "Lambda dispatch: no account ID in auth context")
+		return errors.New(awserrors.ErrorInternalError)
+	}
+	body, err := readBody(r)
+	if err != nil {
+		return err
+	}
+	c := &call{AccountID: inv.AccountID, Region: inv.Region, Params: params, Query: r.URL.Query(), Body: body}
+
+	// The region is the gateway's own, never the caller-supplied credential
+	// scope, so a caller cannot sign for another region to slide out from
+	// under a Deny.
+	resource := "*"
+	var decodeErr error
+	switch action {
+	case "CreateFunction":
+		c.Create, decodeErr = decodeCreate(body)
+		if decodeErr == nil {
+			resource = functionARN(inv.Region, inv.AccountID, aws.StringValue(c.Create.FunctionName))
+		}
+	case "GetFunction":
+		if name, _, err := resolveFunctionName(inv.Region, inv.AccountID, params[0]); err == nil {
+			resource = functionARN(inv.Region, inv.AccountID, name)
+		}
+	}
+	if err := inv.Authorize(ServiceName, action, []string{resource}, nil); err != nil {
+		return err
+	}
+	if decodeErr != nil {
+		return decodeErr
+	}
+	if action == "CreateFunction" {
+		if err := d.checkPassRole(inv, aws.StringValue(c.Create.Role)); err != nil {
+			return err
+		}
+	}
+	if d.Meta == nil || d.Codes == nil {
+		return errors.New(awserrors.ErrorServiceException)
+	}
+
+	out, err := handler(r.Context(), d, c)
+	if err != nil {
+		return err
+	}
+	writeJSON(w, out)
+	return nil
+}
+
+func (d Deps) dispatch(w http.ResponseWriter, inv dispatch.Invocation) error {
+	return d.serve(w, inv)
+}
+
+// checkPassRole enforces iam:PassRole on the execution role and that its trust
+// policy admits Lambda. Only the exact stored ARN resolves, and a missing
+// resolver fails closed.
+func (d Deps) checkPassRole(inv dispatch.Invocation, roleARN string) error {
+	if roleARN == "" {
+		return nil
+	}
+	if d.Roles == nil || d.Trusts == nil {
+		return errors.New(awserrors.ErrorServiceException)
+	}
+	role, err := passrole.Check(d.Roles, passrole.AuthorizeFunc(inv.Authorize), inv.AccountID, roleARN, servicePrincipal)
+	switch {
+	case err == nil:
+		trusted, terr := d.Trusts(inv.AccountID, role.ARN)
+		if terr != nil {
+			return terr
+		}
+		if !trusted {
+			return invalid("The role defined for the function cannot be assumed by Lambda.")
+		}
+		return nil
+	case errors.Is(err, passrole.ErrMalformed), errors.Is(err, passrole.ErrForeignAccount):
+		return invalid("The role defined for the function cannot be assumed by Lambda.")
+	case errors.Is(err, passrole.ErrNotFound):
+		return invalid("The role defined for the function cannot be assumed by Lambda.")
+	default:
+		return err
+	}
+}
+
+func writeJSON(w http.ResponseWriter, out reply) {
+	body, err := jsonutil.BuildJSON(out.Body)
+	if err != nil {
+		slog.Error("Failed to marshal Lambda response", "err", err)
+		w.Header().Set("Content-Type", "application/json")
+		w.WriteHeader(http.StatusInternalServerError)
+		_, _ = w.Write(envelope.JSONBody(awserrors.ErrorServiceException, "failed to marshal response"))
+		return
+	}
+	w.Header().Set("Content-Type", "application/json")
+	w.WriteHeader(out.Status)
+	if _, err := w.Write(body); err != nil {
+		slog.Error("Failed to write Lambda response", "err", err)
+	}
+}

spinifex/domains/lambda/awsapi/routes.go

@@ -0,0 +1,56 @@
+package awsapi
+
+import (
+	"context"
+	"net/url"
+	"slices"
+
+	"github.com/aws/aws-sdk-go/service/lambda"
+	"github.com/mulgadc/spinifex/spinifex/ingress/aws/rest"
+)
+
+// call is one authorized request as a handler sees it.
+type call struct {
+	AccountID string
+	Region    string
+	Params    []string
+	Query     url.Values
+	Body      []byte
+	// Create is the decoded CreateFunction body, decoded once ahead of the
+	// authorization gate and the PassRole check that both read it.
+	Create *lambda.CreateFunctionInput
+}
+
+// reply is a handler's success: the HTTP status and the SDK shape to encode.
+type reply struct {
+	Status int
+	Body   any
+}
+
+type route = rest.Route[routeHandler]
+
+type routeHandler func(ctx context.Context, d Deps, c *call) (reply, error)
+
+// routes is the dispatch table. Lambda API version 2015-03-31.
+var routes = []route{
+	{Method: "POST", Pattern: "/2015-03-31/functions", Action: "CreateFunction",
+		Handler: func(ctx context.Context, d Deps, c *call) (reply, error) {
+			return d.createFunction(ctx, c)
+		}},
+	{Method: "GET", Pattern: "/2015-03-31/functions/{FunctionName}", Action: "GetFunction",
+		Handler: func(ctx context.Context, d Deps, c *call) (reply, error) {
+			return d.getFunction(ctx, c)
+		}},
+}
+
+// actionNames returns the distinct actions in routes in stable order.
+func actionNames() []string {
+	names := make([]string, 0, len(routes))
+	for _, r := range routes {
+		names = append(names, r.Action)
+	}
+	slices.Sort(names)
+	return slices.Compact(names)
+}
+
+var router = rest.NewRouter("lambda", routes)

spinifex/domains/lambda/awsapi/validate.go

@@ -0,0 +1,259 @@
+package awsapi
+
+import (
+	"archive/zip"
+	"bytes"
+	"encoding/json"
+	"reflect"
+	"regexp"
+	"strings"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/service/lambda"
+	"github.com/mulgadc/spinifex/spinifex/domains/lambda/codestore"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/arn"
+	awserrors "github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+)
+
+const (
+	supportedRuntime  = "provided.al2023"
+	defaultTimeout    = 3
+	maxTimeout        = 900
+	defaultMemory     = 128
+	maxMemory         = 10240
+	maxDescription    = 256
+	maxEnvironmentLen = 4096
+	// maxBodyBytes bounds a CreateFunction body: the base64 of the largest
+	// code copy plus room for the rest of the document.
+	maxBodyBytes = (codestore.MaxCodeBytes/3+1)*4 + 1<<20
+)
+
+var nameRE = regexp.MustCompile(`^[a-zA-Z0-9-_]{1,64}$`)
+
+func invalid(format string, args ...any) error {
+	return awserrors.Errorf(awserrors.ErrorInvalidParameterValueException, format, args...)
+}
+
+func unsupported(field string) error {
+	return invalid("%s is not supported", field)
+}
+
+// decodeCreate reads a CreateFunction body strictly: a member this build does
+// not model is refused rather than silently dropped.
+func decodeCreate(body []byte) (*lambda.CreateFunctionInput, error) {
+	in := new(lambda.CreateFunctionInput)
+	dec := json.NewDecoder(bytes.NewReader(body))
+	dec.DisallowUnknownFields()
+	if err := dec.Decode(in); err != nil {
+		return nil, invalid("the request body is not a valid CreateFunction document: %v", err)
+	}
+	return in, nil
+}
+
+// createParams is a CreateFunction request after validation, defaults applied.
+type createParams struct {
+	Name        string
+	Role        string
+	Handler     string
+	Description string
+	TimeoutSec  int64
+	MemorySize  int64
+	Code        []byte
+	Env         map[string]string
+}
+
+// isSet reports whether a modelled optional member carries anything: a non-nil
+// pointer to a non-zero value, a non-empty list or map, or a struct with any
+// such member.
+func isSet(v any) bool {
+	return valueSet(reflect.ValueOf(v))
+}
+
+func valueSet(v reflect.Value) bool {
+	switch v.Kind() {
+	case reflect.Pointer, reflect.Interface:
+		return !v.IsNil() && valueSet(v.Elem())
+	case reflect.Slice, reflect.Map:
+		return v.Len() > 0
+	case reflect.Struct:
+		for i := range v.NumField() {
+			if v.Type().Field(i).IsExported() && valueSet(v.Field(i)) {
+				return true
+			}
+		}
+		return false
+	case reflect.Invalid:
+		return false
+	default:
+		return !v.IsZero()
+	}
+}
+
+// refuseUnsupported names the first supplied member this build cannot honour.
+func refuseUnsupported(in *lambda.CreateFunctionInput) error {
+	checks := []struct {
+		field string
+		set   bool
+	}{
+		{"Code.S3Bucket", in.Code != nil && isSet(in.Code.S3Bucket)},
+		{"Code.S3Key", in.Code != nil && isSet(in.Code.S3Key)},
+		{"Code.S3ObjectVersion", in.Code != nil && isSet(in.Code.S3ObjectVersion)},
+		{"Code.ImageUri", in.Code != nil && isSet(in.Code.ImageUri)},
+		{"Layers", isSet(in.Layers)},
+		{"VpcConfig", isSet(in.VpcConfig)},
+		{"KMSKeyArn", isSet(in.KMSKeyArn)},
+		{"DeadLetterConfig", isSet(in.DeadLetterConfig)},
+		{"TracingConfig", in.TracingConfig != nil && aws.StringValue(in.TracingConfig.Mode) == lambda.TracingModeActive},
+		{"FileSystemConfigs", isSet(in.FileSystemConfigs)},
+		{"ImageConfig", isSet(in.ImageConfig)},
+		{"Architectures", isSet(in.Architectures) && (len(in.Architectures) != 1 || aws.StringValue(in.Architectures[0]) != lambda.ArchitectureX8664)},
+		{"Publish", aws.BoolValue(in.Publish)},
+		{"SnapStart", in.SnapStart != nil && aws.StringValue(in.SnapStart.ApplyOn) != "" && aws.StringValue(in.SnapStart.ApplyOn) != lambda.SnapStartApplyOnNone},
+		{"EphemeralStorage", in.EphemeralStorage != nil && in.EphemeralStorage.Size != nil && aws.Int64Value(in.EphemeralStorage.Size) != 512},
+		{"CodeSigningConfigArn", isSet(in.CodeSigningConfigArn)},
+		{"Tags", isSet(in.Tags)},
+	}
+	for _, c := range checks {
+		if c.set {
+			return unsupported(c.field)
+		}
+	}
+	return nil
+}
+
+// validateCreate checks a decoded CreateFunction and applies the defaults.
+// resolveFunctionName accepts the GetFunction forms AWS does: a name, a partial
+// ARN (account:function:name) or a full ARN, each with an optional qualifier.
+// Another account or Region is reported not found under the ARN it named.
+func resolveFunctionName(region, accountID, raw string) (name, qualifier string, err error) {
+	parts := strings.Split(raw, ":")
+	qualified := false
+	switch {
+	case len(parts) <= 2:
+		name = parts[0]
+		if len(parts) == 2 {
+			qualifier, qualified = parts[1], true
+		}
+	case len(parts) <= 4 && parts[1] == "function":
+		if parts[0] != accountID {
+			return "", "", awserrors.Errorf(awserrors.ErrorResourceNotFoundException, "Function not found: %s",
+				arn.FormatLambdaFunction(region, parts[0], strings.Join(parts[2:], ":")))
+		}
+		name = parts[2]
+		if len(parts) == 4 {
+			qualifier, qualified = parts[3], true
+		}
+	case len(parts) >= 7 && len(parts) <= 8 && parts[0] == "arn" && parts[2] == "lambda" && parts[5] == "function":
+		if parts[1] != "aws" || parts[3] != region || parts[4] != accountID {
+			return "", "", awserrors.Errorf(awserrors.ErrorResourceNotFoundException, "Function not found: %s", raw)
+		}
+		name = parts[6]
+		if len(parts) == 8 {
+			qualifier, qualified = parts[7], true
+		}
+	default:
+		return "", "", invalidFunctionName()
+	}
+	if !nameRE.MatchString(name) || (qualified && qualifier == "") {
+		return "", "", invalidFunctionName()
+	}
+	return name, qualifier, nil
+}
+
+func invalidFunctionName() error {
+	return invalid("1 validation error detected: Value at 'functionName' failed to satisfy constraint: Member must satisfy regular expression pattern: (arn:(aws[a-zA-Z-]*)?:lambda:)?([a-z]{2}(-gov)?-[a-z]+-\\d{1}:)?(\\d{12}:)?(function:)?([a-zA-Z0-9-_]+)(:(\\$LATEST|[a-zA-Z0-9-_]+))?")
+}
+
+// logGroup is the log group AWS names for a function by default.
+func logGroup(name string) string { return "/aws/lambda/" + name }
+
+// defaultLogging reports whether c is absent or spells AWS's default exactly;
+// without a logs capability any other value would be inert.
+func defaultLogging(c *lambda.LoggingConfig, name string) bool {
+	if c == nil {
+		return true
+	}
+	format, group := aws.StringValue(c.LogFormat), aws.StringValue(c.LogGroup)
+	return (format == "" || format == lambda.LogFormatText) && (group == "" || group == logGroup(name)) &&
+		c.ApplicationLogLevel == nil && c.SystemLogLevel == nil
+}
+
+func validateCreate(in *lambda.CreateFunctionInput) (*createParams, error) {
+	if err := refuseUnsupported(in); err != nil {
+		return nil, err
+	}
+	name := aws.StringValue(in.FunctionName)
+	if strings.HasPrefix(name, "arn:") || !nameRE.MatchString(name) {
+		return nil, invalid("1 validation error detected: Value at 'functionName' failed to satisfy constraint: Member must satisfy regular expression pattern: [a-zA-Z0-9-_]+ and have length 1 to 64")
+	}
+	if !defaultLogging(in.LoggingConfig, name) {
+		return nil, unsupported("A LoggingConfig other than LogFormat Text with log group " + logGroup(name))
+	}
+	if aws.StringValue(in.Runtime) != supportedRuntime {
+		return nil, invalid("Runtime must be %s", supportedRuntime)
+	}
+	if pt := aws.StringValue(in.PackageType); pt != "" && pt != lambda.PackageTypeZip {
+		return nil, invalid("PackageType must be %s", lambda.PackageTypeZip)
+	}
+	if in.Code == nil || len(in.Code.ZipFile) == 0 {
+		return nil, invalid("Code.ZipFile is required")
+	}
+	if len(in.Code.ZipFile) > codestore.MaxCodeBytes {
+		return nil, awserrors.Errorf(awserrors.ErrorRequestEntityTooLarge, "Code.ZipFile exceeds %d bytes", codestore.MaxCodeBytes)
+	}
+	if _, err := zip.NewReader(bytes.NewReader(in.Code.ZipFile), int64(len(in.Code.ZipFile))); err != nil {
+		return nil, invalid("Could not unzip uploaded file. Please check your file, then try to upload again.")
+	}
+	handler := aws.StringValue(in.Handler)
+	if handler == "" {
+		return nil, invalid("Handler is required")
+	}
+	role := aws.StringValue(in.Role)
+	if role == "" {
+		return nil, invalid("Role is required")
+	}
+	limit, memory := int64(defaultTimeout), int64(defaultMemory)
+	if in.Timeout != nil {
+		limit = *in.Timeout
+	}
+	if limit < 1 || limit > maxTimeout {
+		return nil, invalid("Timeout must be between 1 and %d", maxTimeout)
+	}
+	if in.MemorySize != nil {
+		memory = *in.MemorySize
+	}
+	if memory < 128 || memory > maxMemory {
+		return nil, invalid("MemorySize must be between 128 and %d", maxMemory)
+	}
+	desc := aws.StringValue(in.Description)
+	if len(desc) > maxDescription {
+		return nil, invalid("Description must be at most %d characters", maxDescription)
+	}
+	env, err := envVars(in.Environment)
+	if err != nil {
+		return nil, err
+	}
+	return &createParams{
+		Name: name, Role: role, Handler: handler, Description: desc,
+		TimeoutSec: limit, MemorySize: memory, Code: in.Code.ZipFile, Env: env,
+	}, nil
+}
+
+func envVars(e *lambda.Environment) (map[string]string, error) {
+	if e == nil || len(e.Variables) == 0 {
+		return nil, nil
+	}
+	vars := make(map[string]string, len(e.Variables))
+	size := 0
+	for k, v := range e.Variables {
+		if k == "" {
+			return nil, invalid("Environment variable names must not be empty")
+		}
+		vars[k] = aws.StringValue(v)
+		size += len(k) + len(vars[k])
+	}
+	if size > maxEnvironmentLen {
+		return nil, invalid("Environment variables exceed %d bytes", maxEnvironmentLen)
+	}
+	return vars, nil
+}

spinifex/domains/lambda/codestore/credentials.go

@@ -0,0 +1,113 @@
+package codestore
+
+import (
+	"errors"
+	"fmt"
+	"log/slog"
+	"sync"
+	"time"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/aws/credentials"
+	"github.com/aws/aws-sdk-go/service/sts"
+	telemetry "github.com/mulgadc/spinifex/spinifex/foundation/telemetry"
+)
+
+const (
+	// refreshMargin re-assumes this long before a session expires.
+	refreshMargin = 5 * time.Minute
+	// retryInterval spaces re-assume attempts while an old session is still valid.
+	retryInterval = 30 * time.Second
+)
+
+// AssumeFunc mints a code-store session. The composition layer binds it to the
+// in-process STS entry point for one Region.
+type AssumeFunc func() (*sts.AssumeRoleOutput, error)
+
+// sessionProvider re-assumes the role ahead of expiry. A failed re-assume keeps
+// the current session in use until it expires, then fails closed.
+type sessionProvider struct {
+	assume AssumeFunc
+	now    func() time.Time
+
+	mu        sync.Mutex
+	value     credentials.Value
+	expires   time.Time
+	lastError time.Time
+	// minRemaining makes the next Retrieve re-assume unless the session has at
+	// least this long left; it is cleared by that Retrieve.
+	minRemaining time.Duration
+}
+
+var (
+	_ credentials.Provider = (*sessionProvider)(nil)
+	_ credentials.Expirer  = (*sessionProvider)(nil)
+)
+
+func newSessionProvider(assume AssumeFunc, now func() time.Time) *sessionProvider {
+	return &sessionProvider{assume: assume, now: now}
+}
+
+func (p *sessionProvider) Retrieve() (credentials.Value, error) {
+	p.mu.Lock()
+	defer p.mu.Unlock()
+
+	now := p.now()
+	valid := p.value.AccessKeyID != "" && now.Before(p.expires)
+	need := p.minRemaining
+	p.minRemaining = 0
+	if need > 0 {
+		if valid && p.expires.Sub(now) >= need {
+			return p.value, nil
+		}
+	} else if valid && (now.Before(p.expires.Add(-refreshMargin)) || now.Before(p.lastError.Add(retryInterval))) {
+		return p.value, nil
+	}
+
+	out, err := p.assume()
+	if err == nil && (out == nil || out.Credentials == nil) {
+		err = errors.New("empty session")
+	}
+	if err != nil {
+		p.lastError = now
+		if valid {
+			slog.Warn("Lambda code store: re-assume failed; keeping current session",
+				"remaining_ms", telemetry.Millis(p.expires.Sub(now)), "err", err)
+			return p.value, nil
+		}
+		return credentials.Value{}, fmt.Errorf("assume code-store role: %w", err)
+	}
+
+	c := out.Credentials
+	p.value = credentials.Value{
+		AccessKeyID:     aws.StringValue(c.AccessKeyId),
+		SecretAccessKey: aws.StringValue(c.SecretAccessKey),
+		SessionToken:    aws.StringValue(c.SessionToken),
+		ProviderName:    "LambdaCodeStoreSession",
+	}
+	p.expires = aws.TimeValue(c.Expiration)
+	p.lastError = time.Time{}
+	return p.value, nil
+}
+
+// IsExpired reports true inside the refresh margin so the SDK calls Retrieve.
+func (p *sessionProvider) IsExpired() bool {
+	p.mu.Lock()
+	defer p.mu.Unlock()
+	return p.value.AccessKeyID == "" || !p.now().Before(p.expires.Add(-refreshMargin))
+}
+
+// ExpiresAt is when the current session stops working.
+func (p *sessionProvider) ExpiresAt() time.Time {
+	p.mu.Lock()
+	defer p.mu.Unlock()
+	return p.expires
+}
+
+// requireRemaining makes the next Retrieve draw a new session unless the
+// current one outlasts d.
+func (p *sessionProvider) requireRemaining(d time.Duration) {
+	p.mu.Lock()
+	defer p.mu.Unlock()
+	p.minRemaining = d
+}

spinifex/domains/lambda/codestore/credentials_test.go

@@ -0,0 +1,94 @@
+package codestore
+
+import (
+	"errors"
+	"testing"
+	"time"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/service/sts"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+type fakeAssume struct {
+	calls   int
+	err     error
+	expires time.Time
+}
+
+func (f *fakeAssume) assume() (*sts.AssumeRoleOutput, error) {
+	f.calls++
+	if f.err != nil {
+		return nil, f.err
+	}
+	return &sts.AssumeRoleOutput{Credentials: &sts.Credentials{
+		AccessKeyId:     aws.String("ASIA" + string(rune('A'+f.calls))),
+		SecretAccessKey: aws.String("secret"),
+		SessionToken:    aws.String("token"),
+		Expiration:      aws.Time(f.expires),
+	}}, nil
+}
+
+type clock struct{ t time.Time }
+
+func (c *clock) now() time.Time { return c.t }
+
+func TestSessionProvider_ReusesUntilRefreshMargin(t *testing.T) {
+	c := &clock{t: time.Unix(1_000_000, 0)}
+	a := &fakeAssume{expires: c.t.Add(time.Hour)}
+	p := newSessionProvider(a.assume, c.now)
+
+	first, err := p.Retrieve()
+	require.NoError(t, err)
+	c.t = c.t.Add(54 * time.Minute)
+	assert.False(t, p.IsExpired())
+	again, err := p.Retrieve()
+	require.NoError(t, err)
+	assert.Equal(t, first.AccessKeyID, again.AccessKeyID)
+	assert.Equal(t, 1, a.calls)
+
+	c.t = c.t.Add(2 * time.Minute)
+	a.expires = c.t.Add(time.Hour)
+	assert.True(t, p.IsExpired())
+	fresh, err := p.Retrieve()
+	require.NoError(t, err)
+	assert.NotEqual(t, first.AccessKeyID, fresh.AccessKeyID)
+	assert.Equal(t, 2, a.calls)
+}
+
+// A failed re-assume keeps the still-valid session, spaces retries, and fails
+// closed once the session has expired.
+func TestSessionProvider_KeepsSessionOnFailureUntilExpiry(t *testing.T) {
+	c := &clock{t: time.Unix(1_000_000, 0)}
+	a := &fakeAssume{expires: c.t.Add(time.Hour)}
+	p := newSessionProvider(a.assume, c.now)
+	first, err := p.Retrieve()
+	require.NoError(t, err)
+
+	a.err = errors.New("sts unavailable")
+	c.t = c.t.Add(58 * time.Minute)
+	kept, err := p.Retrieve()
+	require.NoError(t, err)
+	assert.Equal(t, first.AccessKeyID, kept.AccessKeyID)
+	assert.Equal(t, 2, a.calls)
+
+	c.t = c.t.Add(10 * time.Second)
+	_, err = p.Retrieve()
+	require.NoError(t, err)
+	assert.Equal(t, 2, a.calls, "no re-assume inside the retry interval")
+
+	c.t = c.t.Add(2 * time.Minute)
+	_, err = p.Retrieve()
+	require.Error(t, err)
+	assert.Equal(t, 3, a.calls)
+}
+
+func TestSessionProvider_FirstFailureFails(t *testing.T) {
+	a := &fakeAssume{err: errors.New("AccessDenied")}
+	p := newSessionProvider(a.assume, time.Now)
+
+	_, err := p.Retrieve()
+	require.Error(t, err)
+	assert.True(t, p.IsExpired())
+}

spinifex/domains/lambda/codestore/manager.go

@@ -0,0 +1,74 @@
+package codestore
+
+import (
+	"context"
+	"errors"
+	"fmt"
+	"log/slog"
+	"sync"
+	"time"
+
+	telemetry "github.com/mulgadc/spinifex/spinifex/foundation/telemetry"
+)
+
+// ErrNotReady means the code store is not provisioned or its role is not
+// assumable yet; callers report ServiceException.
+var ErrNotReady = errors.New("lambda code store not ready")
+
+const (
+	initialBackoff = time.Second
+	maxBackoff     = 5 * time.Minute
+)
+
+// Manager provisions and opens the store on first use, so a process that never
+// uses Lambda creates nothing. After a failure, calls inside the capped backoff
+// window fail fast with the last reason instead of retrying.
+type Manager struct {
+	provision func(context.Context) error
+	open      func() (*Store, error)
+	now       func() time.Time
+
+	mu      sync.Mutex
+	store   *Store
+	reason  error
+	backoff time.Duration
+	retryAt time.Time
+}
+
+// NewManager binds the bounded provisioning step and the scoped opener. It does
+// no I/O.
+func NewManager(provision func(context.Context) error, open func() (*Store, error)) *Manager {
+	return &Manager{provision: provision, open: open, now: time.Now}
+}
+
+// Store returns the opened store, initialising it on first use. An ErrNotOwned
+// refusal is retried after backoff, so an operator's fix takes effect without a
+// restart.
+func (m *Manager) Store(ctx context.Context) (*Store, error) {
+	m.mu.Lock()
+	defer m.mu.Unlock()
+	if m.store != nil {
+		return m.store, nil
+	}
+	if now := m.now(); now.Before(m.retryAt) {
+		return nil, fmt.Errorf("%w: %w", ErrNotReady, m.reason)
+	}
+
+	store, err := m.attempt(ctx)
+	if err == nil {
+		m.store, m.reason, m.backoff = store, nil, 0
+		slog.InfoContext(ctx, "Lambda code store ready")
+		return store, nil
+	}
+	m.backoff = min(max(m.backoff*2, initialBackoff), maxBackoff)
+	m.reason, m.retryAt = err, m.now().Add(m.backoff)
+	slog.WarnContext(ctx, "Lambda code store not ready", "err", err, "retry_ms", telemetry.Millis(m.backoff))
+	return nil, fmt.Errorf("%w: %w", ErrNotReady, err)
+}
+
+func (m *Manager) attempt(ctx context.Context) (*Store, error) {
+	if err := m.provision(ctx); err != nil {
+		return nil, err
+	}
+	return m.open()
+}

spinifex/domains/lambda/codestore/presign_test.go

@@ -0,0 +1,158 @@
+package codestore
+
+import (
+	"errors"
+	"net/url"
+	"strings"
+	"testing"
+	"time"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/aws/credentials"
+	"github.com/aws/aws-sdk-go/aws/session"
+	"github.com/aws/aws-sdk-go/service/s3"
+	ststypes "github.com/aws/aws-sdk-go/service/sts"
+	"github.com/mulgadc/spinifex/spinifex/providers/objectstore"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestStore_PresignGet(t *testing.T) {
+	sess, err := session.NewSession(&aws.Config{
+		Endpoint:         aws.String("https://predastore.test:8443"),
+		Region:           aws.String("ap-southeast-2"),
+		Credentials:      credentials.NewStaticCredentials("AKIATEST", "secret", "session-token"),
+		S3ForcePathStyle: aws.Bool(true),
+	})
+	require.NoError(t, err)
+	s := newStore(testRegion, objectstore.NewMemoryObjectStore())
+	s.presign = presignWith(s3.New(sess))
+	sum := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+
+	raw, err := s.PresignGet(t.Context(), testRef, sum, 10*time.Minute)
+	require.NoError(t, err)
+
+	u, err := url.Parse(raw)
+	require.NoError(t, err)
+	assert.Equal(t, "predastore.test:8443", u.Host)
+	assert.Equal(t, "/"+BucketName(testRegion)+"/"+copyKey(sum), u.Path)
+	q := u.Query()
+	assert.Equal(t, "600", q.Get("X-Amz-Expires"))
+	assert.Equal(t, "session-token", q.Get("X-Amz-Security-Token"))
+	assert.NotEmpty(t, q.Get("X-Amz-Signature"))
+}
+
+func TestStore_PresignGetRefusals(t *testing.T) {
+	s := newStore(testRegion, objectstore.NewMemoryObjectStore())
+	sum := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+
+	_, err := s.PresignGet(t.Context(), testRef, sum, time.Minute)
+	require.Error(t, err, "a store without a signer cannot presign")
+
+	s.presign = func(*s3.GetObjectInput, time.Duration) (string, error) { return "unused", nil }
+	_, err = s.PresignGet(t.Context(), testRef, "not-a-digest", time.Minute)
+	require.ErrorIs(t, err, ErrInvalidRef)
+}
+
+func presignStoreOn(t *testing.T, c *clock, a *fakeAssume) *Store {
+	t.Helper()
+	provider := newSessionProvider(a.assume, c.now)
+	creds := credentials.NewCredentials(provider)
+	sess, err := session.NewSession(&aws.Config{
+		Endpoint: aws.String("https://predastore.test:8443"), Region: aws.String("ap-southeast-2"),
+		Credentials: creds, S3ForcePathStyle: aws.Bool(true),
+	})
+	require.NoError(t, err)
+	s := newStore(testRegion, objectstore.NewMemoryObjectStore())
+	s.presign = presignWith(s3.New(sess))
+	s.creds, s.provider, s.now = creds, provider, c.now
+	return s
+}
+
+func signedKeyID(t *testing.T, raw string) string {
+	t.Helper()
+	u, err := url.Parse(raw)
+	require.NoError(t, err)
+	return strings.SplitN(u.Query().Get("X-Amz-Credential"), "/", 2)[0]
+}
+
+func TestStore_PresignGetRefreshesAShortSession(t *testing.T) {
+	sum := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+	c := &clock{t: time.Unix(1_000_000, 0)}
+	a := &fakeAssume{expires: c.t.Add(7 * time.Minute)}
+	s := presignStoreOn(t, c, a)
+	_, err := s.creds.Get()
+	require.NoError(t, err)
+	first := "ASIAB"
+	require.Equal(t, 1, a.calls)
+
+	a.expires = c.t.Add(time.Hour)
+	raw, err := s.PresignGet(t.Context(), testRef, sum, 10*time.Minute)
+	require.NoError(t, err)
+	assert.Equal(t, 2, a.calls, "a 7 minute session is re-assumed before a 10 minute signature")
+	assert.NotEqual(t, first, signedKeyID(t, raw))
+	assert.Equal(t, "ASIAC", signedKeyID(t, raw), "the URL is signed with the new session")
+
+	_, err = s.PresignGet(t.Context(), testRef, sum, 10*time.Minute)
+	require.NoError(t, err)
+	assert.Equal(t, 2, a.calls, "a long session is reused")
+}
+
+func TestStore_PresignGetRefusesWhenSessionStaysShort(t *testing.T) {
+	sum := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+	c := &clock{t: time.Unix(1_000_000, 0)}
+	a := &fakeAssume{expires: c.t.Add(7 * time.Minute)}
+	s := presignStoreOn(t, c, a)
+
+	_, err := s.PresignGet(t.Context(), testRef, sum, 10*time.Minute)
+	require.Error(t, err, "a re-assume that is still short signs nothing")
+	assert.Equal(t, 2, a.calls)
+
+	a.err = errors.New("AccessDenied")
+	_, err = s.PresignGet(t.Context(), testRef, sum, 10*time.Minute)
+	require.Error(t, err, "a failed re-assume does not fall back to the short session")
+}
+
+// Open signs download URLs for the off-host endpoint while its own reads and
+// writes keep the local one, so a client outside the node can fetch the copy.
+func TestOpen_PresignsForTheOffHostEndpoint(t *testing.T) {
+	assume := func() (*ststypes.AssumeRoleOutput, error) {
+		return &ststypes.AssumeRoleOutput{Credentials: &ststypes.Credentials{
+			AccessKeyId:     aws.String("ASIATEST"),
+			SecretAccessKey: aws.String("secret"),
+			SessionToken:    aws.String("session-token"),
+			Expiration:      aws.Time(time.Now().Add(time.Hour)),
+		}}, nil
+	}
+	s, err := Open(OpenConfig{
+		Region:          testRegion,
+		Endpoint:        "https://127.0.0.1:8443",
+		SigningRegion:   "ap-southeast-2",
+		Assume:          assume,
+		PresignEndpoint: "https://192.0.2.15:8443",
+	})
+	require.NoError(t, err)
+
+	raw, err := s.PresignGet(t.Context(), testRef, strings.Repeat("a", 64), 10*time.Minute)
+	require.NoError(t, err)
+	u, err := url.Parse(raw)
+	require.NoError(t, err)
+	assert.Equal(t, "192.0.2.15:8443", u.Host)
+}
+
+func TestOpen_NoOffHostEndpointRefusesDownloadURLs(t *testing.T) {
+	assume := func() (*ststypes.AssumeRoleOutput, error) {
+		return &ststypes.AssumeRoleOutput{Credentials: &ststypes.Credentials{
+			AccessKeyId:     aws.String("ASIATEST"),
+			SecretAccessKey: aws.String("secret"),
+			SessionToken:    aws.String("session-token"),
+			Expiration:      aws.Time(time.Now().Add(time.Hour)),
+		}}, nil
+	}
+	s, err := Open(OpenConfig{Region: testRegion, Endpoint: "https://127.0.0.1:8443", SigningRegion: "ap-southeast-2", Assume: assume})
+	require.NoError(t, err)
+
+	raw, err := s.PresignGet(t.Context(), testRef, strings.Repeat("a", 64), 10*time.Minute)
+	require.ErrorIs(t, err, ErrNoPresignEndpoint)
+	assert.Empty(t, raw)
+}

spinifex/domains/lambda/codestore/provision.go

@@ -0,0 +1,178 @@
+// Package codestore keeps Lambda code copies in the Region's system-account
+// bucket, reached only through a short-lived session of the Region's scoped
+// code-store role. The composition layer owns every privileged client.
+package codestore
+
+import (
+	"context"
+	"encoding/json"
+	"errors"
+	"fmt"
+	"reflect"
+)
+
+const (
+	// OwnerTagKey marks the role and bucket Lambda intends to own. It names the
+	// intended owner; any principal able to tag could also set it.
+	OwnerTagKey = "spinifex:owner"
+	// OwnerTagValue is the owner tag's value.
+	OwnerTagValue = "lambda-code-store"
+	// PolicyName is the role's only inline policy.
+	PolicyName = "lambda-code-store"
+)
+
+// TrustPolicy lets only the in-process lambda.amazonaws.com path assume the role.
+const TrustPolicy = `{"Version":"2012-10-17","Statement":[{"Effect":"Allow","Principal":{"Service":"lambda.amazonaws.com"},"Action":"sts:AssumeRole"}]}`
+
+var (
+	// ErrExists is returned by an admin Create when the resource already exists
+	// under the system account.
+	ErrExists = errors.New("already exists")
+	// ErrNotFound is returned by RoleAdmin.Describe for an absent role.
+	ErrNotFound = errors.New("not found")
+	// ErrOwnedElsewhere is returned by BucketAdmin.Create when another account
+	// owns the bucket name.
+	ErrOwnedElsewhere = errors.New("owned by another account")
+	// ErrNotOwned is a refusal that persists until an operator resolves it.
+	ErrNotOwned = errors.New("lambda code store: existing resource is not Lambda's")
+)
+
+// BucketName is the Region's code bucket in the system account.
+func BucketName(region string) string {
+	return "lambda-code-" + region
+}
+
+type policyStatement struct {
+	Effect   string   `json:"Effect"`
+	Action   []string `json:"Action"`
+	Resource string   `json:"Resource"`
+}
+
+type policyDocument struct {
+	Version   string            `json:"Version"`
+	Statement []policyStatement `json:"Statement"`
+}
+
+// RolePolicy grants object access to the Region's code bucket and nothing else.
+func RolePolicy(region string) (string, error) {
+	b := "arn:aws:s3:::" + BucketName(region)
+	doc, err := json.Marshal(policyDocument{
+		Version: "2012-10-17",
+		Statement: []policyStatement{
+			{Effect: "Allow", Action: []string{"s3:PutObject", "s3:GetObject", "s3:DeleteObject"}, Resource: b + "/*"},
+			{Effect: "Allow", Action: []string{"s3:ListBucket"}, Resource: b},
+		},
+	})
+	if err != nil {
+		return "", fmt.Errorf("lambda code store policy: %w", err)
+	}
+	return string(doc), nil
+}
+
+// RoleState is what provisioning reads back about an existing role.
+type RoleState struct {
+	TrustPolicy      string
+	Tags             map[string]string
+	InlinePolicies   []string
+	AttachedPolicies int
+}
+
+// RoleAdmin is bound by the composition layer to the one code-store role.
+type RoleAdmin interface {
+	Create(trustPolicy string, tags map[string]string) error
+	Describe() (*RoleState, error)
+	PutPolicy(name, document string) error
+}
+
+// BucketAdmin is bound by the composition layer to the one code bucket.
+// Create tags the bucket only when it created it, never an existing one.
+type BucketAdmin interface {
+	Create(ctx context.Context, tags map[string]string) error
+	Tags(ctx context.Context) (map[string]string, error)
+}
+
+func ownerTags() map[string]string {
+	return map[string]string{OwnerTagKey: OwnerTagValue}
+}
+
+// Provision creates or verifies the Region's role, policy and bucket. A retry
+// completes Lambda's own partial run; any state it cannot attribute to Lambda
+// is refused with ErrNotOwned and left untouched.
+func Provision(ctx context.Context, region string, role RoleAdmin, bucket BucketAdmin) error {
+	if err := ensureRole(role); err != nil {
+		return err
+	}
+	policy, err := RolePolicy(region)
+	if err != nil {
+		return err
+	}
+	if err := role.PutPolicy(PolicyName, policy); err != nil {
+		return fmt.Errorf("put code-store role policy: %w", err)
+	}
+	return ensureBucket(ctx, region, bucket)
+}
+
+func ensureRole(role RoleAdmin) error {
+	err := role.Create(TrustPolicy, ownerTags())
+	if err == nil {
+		return nil
+	}
+	if !errors.Is(err, ErrExists) {
+		return fmt.Errorf("create code-store role: %w", err)
+	}
+	st, err := role.Describe()
+	if err != nil {
+		return fmt.Errorf("describe code-store role: %w", err)
+	}
+	return checkRole(st)
+}
+
+// checkRole accepts only Lambda's own shape: owner tag, exact trust, no attached
+// policies, and no inline policy but Lambda's. No inline policy at all is the
+// state a crash between CreateRole and PutRolePolicy leaves, so it is retried.
+func checkRole(st *RoleState) error {
+	switch {
+	case st.Tags[OwnerTagKey] != OwnerTagValue:
+		return fmt.Errorf("%w: role has no %s=%s tag", ErrNotOwned, OwnerTagKey, OwnerTagValue)
+	case !sameJSON(st.TrustPolicy, TrustPolicy):
+		return fmt.Errorf("%w: role trust policy differs from the code-store trust policy", ErrNotOwned)
+	case st.AttachedPolicies > 0:
+		return fmt.Errorf("%w: role has %d attached managed policies", ErrNotOwned, st.AttachedPolicies)
+	}
+	for _, name := range st.InlinePolicies {
+		if name != PolicyName {
+			return fmt.Errorf("%w: role has inline policy %q", ErrNotOwned, name)
+		}
+	}
+	return nil
+}
+
+func ensureBucket(ctx context.Context, region string, bucket BucketAdmin) error {
+	err := bucket.Create(ctx, ownerTags())
+	if err == nil {
+		return nil
+	}
+	if errors.Is(err, ErrOwnedElsewhere) {
+		return fmt.Errorf("%w: bucket %s is owned by another account", ErrNotOwned, BucketName(region))
+	}
+	if !errors.Is(err, ErrExists) {
+		return fmt.Errorf("create code bucket: %w", err)
+	}
+	tags, err := bucket.Tags(ctx)
+	if err != nil {
+		return fmt.Errorf("read code bucket tags: %w", err)
+	}
+	if tags[OwnerTagKey] != OwnerTagValue {
+		return fmt.Errorf("%w: bucket %s exists without the %s=%s tag; an operator must tag or delete it",
+			ErrNotOwned, BucketName(region), OwnerTagKey, OwnerTagValue)
+	}
+	return nil
+}
+
+func sameJSON(a, b string) bool {
+	var x, y any
+	if json.Unmarshal([]byte(a), &x) != nil || json.Unmarshal([]byte(b), &y) != nil {
+		return false
+	}
+	return reflect.DeepEqual(x, y)
+}

spinifex/domains/lambda/codestore/provision_test.go

@@ -0,0 +1,165 @@
+package codestore
+
+import (
+	"context"
+	"errors"
+	"slices"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+const testRegion = "ap-southeast-2"
+
+type fakeRole struct {
+	state    *RoleState
+	created  int
+	policies map[string]string
+}
+
+func (f *fakeRole) Create(trust string, tags map[string]string) error {
+	if f.state != nil {
+		return ErrExists
+	}
+	f.created++
+	f.state = &RoleState{TrustPolicy: trust, Tags: tags}
+	return nil
+}
+
+func (f *fakeRole) Describe() (*RoleState, error) {
+	if f.state == nil {
+		return nil, ErrNotFound
+	}
+	return f.state, nil
+}
+
+func (f *fakeRole) PutPolicy(name, doc string) error {
+	if f.policies == nil {
+		f.policies = map[string]string{}
+	}
+	f.policies[name] = doc
+	if !slices.Contains(f.state.InlinePolicies, name) {
+		f.state.InlinePolicies = append(f.state.InlinePolicies, name)
+	}
+	return nil
+}
+
+type fakeBucket struct {
+	exists, foreign bool
+	tags            map[string]string
+	tagErr          error
+	tagWrites       int
+}
+
+func (f *fakeBucket) Create(_ context.Context, tags map[string]string) error {
+	switch {
+	case f.foreign:
+		return ErrOwnedElsewhere
+	case f.exists:
+		return ErrExists
+	}
+	f.exists = true
+	if f.tagErr != nil {
+		return f.tagErr
+	}
+	f.tagWrites++
+	f.tags = tags
+	return nil
+}
+
+func (f *fakeBucket) Tags(context.Context) (map[string]string, error) { return f.tags, nil }
+
+func mustPolicy(t *testing.T) string {
+	t.Helper()
+	p, err := RolePolicy(testRegion)
+	require.NoError(t, err)
+	return p
+}
+
+func ownRole(inline ...string) *fakeRole {
+	return &fakeRole{state: &RoleState{TrustPolicy: TrustPolicy, Tags: ownerTags(), InlinePolicies: inline}}
+}
+
+func TestProvision_FreshCreatesTaggedRolePolicyAndBucket(t *testing.T) {
+	role, bucket := &fakeRole{}, &fakeBucket{}
+
+	require.NoError(t, Provision(t.Context(), testRegion, role, bucket))
+
+	assert.Equal(t, 1, role.created)
+	assert.Equal(t, OwnerTagValue, role.state.Tags[OwnerTagKey])
+	assert.JSONEq(t, mustPolicy(t), role.policies[PolicyName])
+	assert.Equal(t, OwnerTagValue, bucket.tags[OwnerTagKey])
+}
+
+// A crash between CreateRole and PutRolePolicy leaves Lambda's tagged role with
+// no inline policy; the next run adds it.
+func TestProvision_RetriesOwnRoleWithoutPolicy(t *testing.T) {
+	role, bucket := ownRole(), &fakeBucket{}
+
+	require.NoError(t, Provision(t.Context(), testRegion, role, bucket))
+
+	assert.Zero(t, role.created)
+	assert.JSONEq(t, mustPolicy(t), role.policies[PolicyName])
+}
+
+func TestProvision_RestoresDriftedOwnPolicy(t *testing.T) {
+	role, bucket := ownRole(PolicyName), &fakeBucket{}
+	role.policies = map[string]string{PolicyName: `{"Version":"2012-10-17","Statement":[{"Effect":"Allow","Action":"s3:*","Resource":"*"}]}`}
+
+	require.NoError(t, Provision(t.Context(), testRegion, role, bucket))
+	assert.JSONEq(t, mustPolicy(t), role.policies[PolicyName])
+}
+
+func TestProvision_RefusesRoleNotLambdas(t *testing.T) {
+	cases := map[string]*RoleState{
+		"no owner tag":          {TrustPolicy: TrustPolicy},
+		"other trust":           {TrustPolicy: `{"Version":"2012-10-17","Statement":[{"Effect":"Allow","Principal":{"AWS":"arn:aws:iam::000000000000:root"},"Action":"sts:AssumeRole"}]}`, Tags: ownerTags()},
+		"attached policy":       {TrustPolicy: TrustPolicy, Tags: ownerTags(), AttachedPolicies: 1},
+		"foreign inline policy": {TrustPolicy: TrustPolicy, Tags: ownerTags(), InlinePolicies: []string{PolicyName, "admin"}},
+	}
+	for name, st := range cases {
+		t.Run(name, func(t *testing.T) {
+			role, bucket := &fakeRole{state: st}, &fakeBucket{}
+
+			err := Provision(t.Context(), testRegion, role, bucket)
+
+			require.ErrorIs(t, err, ErrNotOwned)
+			assert.Nil(t, role.policies, "no policy written to a role that is not Lambda's")
+			assert.False(t, bucket.exists, "provisioning stops before the bucket")
+		})
+	}
+}
+
+func TestProvision_AcceptsOwnTaggedBucket(t *testing.T) {
+	bucket := &fakeBucket{exists: true, tags: ownerTags()}
+
+	require.NoError(t, Provision(t.Context(), testRegion, &fakeRole{}, bucket))
+	assert.Zero(t, bucket.tagWrites)
+}
+
+// A crash after CreateBucket and before its tags leaves an untagged bucket that
+// cannot be told apart from another system component's, so it is refused.
+func TestProvision_RefusesUntaggedBucketAfterPartialCreate(t *testing.T) {
+	bucket := &fakeBucket{tagErr: errors.New("connection reset")}
+	require.Error(t, Provision(t.Context(), testRegion, &fakeRole{}, bucket))
+
+	bucket.tagErr = nil
+	err := Provision(t.Context(), testRegion, &fakeRole{}, bucket)
+
+	require.ErrorIs(t, err, ErrNotOwned)
+	assert.Contains(t, err.Error(), "lambda-code-ap-southeast-2 exists without the spinifex:owner=lambda-code-store tag")
+	assert.Zero(t, bucket.tagWrites, "an existing bucket is never tagged into use")
+}
+
+func TestProvision_RefusesBucketOwnedElsewhere(t *testing.T) {
+	err := Provision(t.Context(), testRegion, &fakeRole{}, &fakeBucket{foreign: true})
+	require.ErrorIs(t, err, ErrNotOwned)
+}
+
+func TestRolePolicy_ScopesToRegionalBucket(t *testing.T) {
+	assert.JSONEq(t, `{"Version":"2012-10-17","Statement":[
+		{"Effect":"Allow","Action":["s3:PutObject","s3:GetObject","s3:DeleteObject"],"Resource":"arn:aws:s3:::lambda-code-ap-southeast-2/*"},
+		{"Effect":"Allow","Action":["s3:ListBucket"],"Resource":"arn:aws:s3:::lambda-code-ap-southeast-2"}]}`,
+		mustPolicy(t))
+}

spinifex/domains/lambda/codestore/store.go

@@ -0,0 +1,297 @@
+package codestore
+
+import (
+	"bytes"
+	"context"
+	"crypto/sha256"
+	"encoding/hex"
+	"errors"
+	"fmt"
+	"io"
+	"net/http"
+	"regexp"
+	"time"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/aws/credentials"
+	"github.com/aws/aws-sdk-go/aws/session"
+	"github.com/aws/aws-sdk-go/service/s3"
+	"github.com/mulgadc/spinifex/spinifex/providers/objectstore"
+)
+
+// MaxCodeBytes bounds one stored code copy, AWS's direct-upload ZIP limit.
+const MaxCodeBytes = 50 << 20
+
+var (
+	// ErrCodeNotFound means no copy exists for the reference.
+	ErrCodeNotFound = errors.New("lambda code copy not found")
+	// ErrDigestMismatch means the stored bytes do not match the recorded SHA-256.
+	ErrDigestMismatch = errors.New("lambda code copy digest mismatch")
+	// ErrCodeTooLarge means the copy exceeds MaxCodeBytes.
+	ErrCodeTooLarge = errors.New("lambda code copy too large")
+	// ErrInvalidRef means a reference segment is empty or unsafe as a key segment.
+	ErrInvalidRef = errors.New("invalid lambda code reference")
+	// ErrNoPresignEndpoint means no off-host Predastore address is configured.
+	ErrNoPresignEndpoint = errors.New("lambda code store: no off-host endpoint for download URLs")
+)
+
+var (
+	refSegment = regexp.MustCompile(`^[A-Za-z0-9_-][A-Za-z0-9._-]{0,127}$`)
+	digestHex  = regexp.MustCompile(`^[0-9a-f]{64}$`)
+)
+
+// Ref names one code revision; keys group by account for S11 inventory.
+type Ref struct {
+	AccountID  string
+	FunctionID string
+	RevisionID string
+}
+
+func (r Ref) prefix() (string, error) {
+	for _, seg := range []string{r.AccountID, r.FunctionID, r.RevisionID} {
+		if !refSegment.MatchString(seg) {
+			return "", fmt.Errorf("%w: %q", ErrInvalidRef, seg)
+		}
+	}
+	return r.AccountID + "/" + r.FunctionID + "/" + r.RevisionID + "/", nil
+}
+
+// key names a copy by its digest, so different bytes for the same revision land
+// on a different object and can never replace the recorded copy.
+func (r Ref) key(sha256Hex string) (string, error) {
+	p, err := r.prefix()
+	if err != nil {
+		return "", err
+	}
+	if !digestHex.MatchString(sha256Hex) {
+		return "", fmt.Errorf("%w: digest %q", ErrInvalidRef, sha256Hex)
+	}
+	return p + sha256Hex + ".zip", nil
+}
+
+// Store reads and writes code copies in one Region's code bucket.
+type Store struct {
+	bucket  string
+	objects objectstore.ObjectStore
+	presign presignFunc
+
+	// creds and provider are the scoped session behind presign; nil on stores
+	// built without one.
+	creds    *credentials.Credentials
+	provider *sessionProvider
+	now      func() time.Time
+}
+
+// presignMargin is slack kept between a signed URL's end and its session's.
+const presignMargin = 30 * time.Second
+
+// presignFunc signs a GET for the input; nil on stores that cannot presign.
+type presignFunc func(in *s3.GetObjectInput, ttl time.Duration) (string, error)
+
+// presignWith signs GETs with the session credentials behind client.
+func presignWith(client *s3.S3) presignFunc {
+	return func(in *s3.GetObjectInput, ttl time.Duration) (string, error) {
+		req, _ := client.GetObjectRequest(in)
+		return req.Presign(ttl)
+	}
+}
+
+// OpenConfig is what the composition layer supplies to open the scoped store.
+type OpenConfig struct {
+	Region        string // Spinifex Region naming the bucket
+	Endpoint      string // Predastore URL
+	SigningRegion string // Predastore SigV4 Region
+	Assume        AssumeFunc
+	HTTPClient    *http.Client
+	now           func() time.Time
+	// PresignEndpoint is the Predastore URL off-host clients reach; download
+	// URLs are signed for it. Empty disables download URLs.
+	PresignEndpoint string
+}
+
+// Open builds the store on a refreshing code-store session and draws the first
+// session, so an unassumable role fails here rather than on first use.
+func Open(cfg OpenConfig) (*Store, error) {
+	if cfg.Region == "" || cfg.Endpoint == "" || cfg.Assume == nil {
+		return nil, errors.New("lambda code store: region, endpoint and assume are required")
+	}
+	now := cfg.now
+	if now == nil {
+		now = time.Now
+	}
+	client := cfg.HTTPClient
+	if client == nil {
+		client = &http.Client{Timeout: 120 * time.Second}
+	}
+	provider := newSessionProvider(cfg.Assume, now)
+	creds := credentials.NewCredentials(provider)
+	if _, err := creds.Get(); err != nil {
+		return nil, err
+	}
+	sess, err := session.NewSession(&aws.Config{
+		Endpoint:         aws.String(cfg.Endpoint),
+		Region:           aws.String(cfg.SigningRegion),
+		Credentials:      creds,
+		S3ForcePathStyle: aws.Bool(true),
+		HTTPClient:       client,
+	})
+	if err != nil {
+		return nil, fmt.Errorf("lambda code store session: %w", err)
+	}
+	s3Client := s3.New(sess)
+	store := newStore(cfg.Region, objectstore.NewS3ObjectStore(s3Client))
+	// Without an off-host address a download URL would name an internal one.
+	if cfg.PresignEndpoint != "" {
+		store.presign = presignWith(s3.New(sess, &aws.Config{Endpoint: aws.String(cfg.PresignEndpoint)}))
+	}
+	store.creds, store.provider, store.now = creds, provider, now
+	return store, nil
+}
+
+func newStore(region string, objects objectstore.ObjectStore) *Store {
+	return &Store{bucket: BucketName(region), objects: objects}
+}
+
+// Put stores code under its digest and returns the hex SHA-256 the revision
+// record keeps. A retry with the same bytes rewrites identical content.
+func (s *Store) Put(ctx context.Context, ref Ref, code []byte) (string, error) {
+	if len(code) > MaxCodeBytes {
+		return "", ErrCodeTooLarge
+	}
+	sum := sha256.Sum256(code)
+	digest := hex.EncodeToString(sum[:])
+	key, err := ref.key(digest)
+	if err != nil {
+		return "", err
+	}
+	if _, err := s.objects.PutObject(ctx, &s3.PutObjectInput{
+		Bucket:        aws.String(s.bucket),
+		Key:           aws.String(key),
+		Body:          bytes.NewReader(code),
+		ContentLength: aws.Int64(int64(len(code))),
+	}); err != nil {
+		return "", fmt.Errorf("put lambda code copy: %w", err)
+	}
+	return digest, nil
+}
+
+// Get returns the copy only if it matches wantSHA256, the recorded digest.
+func (s *Store) Get(ctx context.Context, ref Ref, wantSHA256 string) ([]byte, error) {
+	key, err := ref.key(wantSHA256)
+	if err != nil {
+		return nil, err
+	}
+	out, err := s.objects.GetObject(ctx, &s3.GetObjectInput{Bucket: aws.String(s.bucket), Key: aws.String(key)})
+	if err != nil {
+		if objectstore.IsNoSuchKeyError(err) {
+			return nil, ErrCodeNotFound
+		}
+		return nil, fmt.Errorf("get lambda code copy: %w", err)
+	}
+	defer out.Body.Close()
+	code, err := io.ReadAll(io.LimitReader(out.Body, MaxCodeBytes+1))
+	if err != nil {
+		return nil, fmt.Errorf("read lambda code copy: %w", err)
+	}
+	if len(code) > MaxCodeBytes {
+		return nil, ErrCodeTooLarge
+	}
+	sum := sha256.Sum256(code)
+	if hex.EncodeToString(sum[:]) != wantSHA256 {
+		return nil, ErrDigestMismatch
+	}
+	return code, nil
+}
+
+// ensureSession guarantees the signing session outlasts ttl, drawing a new one
+// if it does not, and fails rather than sign a URL that would outlive it.
+func (s *Store) ensureSession(ttl time.Duration) error {
+	if s.creds == nil || s.provider == nil {
+		return nil
+	}
+	need := ttl + presignMargin
+	if _, err := s.creds.Get(); err != nil {
+		return fmt.Errorf("lambda code store session: %w", err)
+	}
+	for attempt := range 2 {
+		exp, err := s.creds.ExpiresAt()
+		if err != nil {
+			return fmt.Errorf("lambda code store session expiry: %w", err)
+		}
+		if !exp.Before(s.now().Add(need)) {
+			return nil
+		}
+		if attempt == 1 {
+			break
+		}
+		s.provider.requireRemaining(need)
+		s.creds.Expire()
+		if _, err := s.creds.Get(); err != nil {
+			return fmt.Errorf("lambda code store session: %w", err)
+		}
+	}
+	return errors.New("lambda code store: session expires before the presigned URL would")
+}
+
+// PresignGet returns a time-limited GET URL for the copy with the recorded
+// digest, signed by a session that outlasts the URL.
+func (s *Store) PresignGet(ctx context.Context, ref Ref, sha256Hex string, ttl time.Duration) (string, error) {
+	if s.presign == nil {
+		return "", ErrNoPresignEndpoint
+	}
+	key, err := ref.key(sha256Hex)
+	if err != nil {
+		return "", err
+	}
+	if err := ctx.Err(); err != nil {
+		return "", err
+	}
+	if err := s.ensureSession(ttl); err != nil {
+		return "", err
+	}
+	url, err := s.presign(&s3.GetObjectInput{Bucket: aws.String(s.bucket), Key: aws.String(key)}, ttl)
+	if err != nil {
+		return "", fmt.Errorf("presign lambda code copy: %w", err)
+	}
+	return url, nil
+}
+
+// Delete removes the copy with the recorded digest; an absent copy is already
+// deleted.
+func (s *Store) Delete(ctx context.Context, ref Ref, sha256Hex string) error {
+	key, err := ref.key(sha256Hex)
+	if err != nil {
+		return err
+	}
+	return s.deleteKey(ctx, key)
+}
+
+// DeleteRevision removes every copy under the revision, including ones a failed
+// or superseded attempt left. Callers own the guarantee that no create or update
+// for the revision is still in progress.
+func (s *Store) DeleteRevision(ctx context.Context, ref Ref) error {
+	prefix, err := ref.prefix()
+	if err != nil {
+		return err
+	}
+	objects, _, err := objectstore.ListAll(ctx, s.objects, &s3.ListObjectsV2Input{
+		Bucket: aws.String(s.bucket), Prefix: aws.String(prefix),
+	})
+	if err != nil {
+		return fmt.Errorf("list lambda code copies: %w", err)
+	}
+	for _, o := range objects {
+		if err := s.deleteKey(ctx, aws.StringValue(o.Key)); err != nil {
+			return err
+		}
+	}
+	return nil
+}
+
+func (s *Store) deleteKey(ctx context.Context, key string) error {
+	_, err := s.objects.DeleteObject(ctx, &s3.DeleteObjectInput{Bucket: aws.String(s.bucket), Key: aws.String(key)})
+	if err != nil && !objectstore.IsNoSuchKeyError(err) {
+		return fmt.Errorf("delete lambda code copy: %w", err)
+	}
+	return nil
+}

spinifex/domains/lambda/codestore/store_test.go

@@ -0,0 +1,169 @@
+package codestore
+
+import (
+	"bytes"
+	"context"
+	"crypto/sha256"
+	"encoding/hex"
+	"errors"
+	"fmt"
+	"sync"
+	"testing"
+	"time"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/service/s3"
+	"github.com/aws/aws-sdk-go/service/sts"
+	"github.com/mulgadc/spinifex/spinifex/providers/objectstore"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+var testRef = Ref{AccountID: "000000000001", FunctionID: "fn-0123", RevisionID: "rev-1"}
+
+func copyKey(sum string) string { return "000000000001/fn-0123/rev-1/" + sum + ".zip" }
+
+func TestStore_PutGetDelete(t *testing.T) {
+	mem := objectstore.NewMemoryObjectStore()
+	s := newStore(testRegion, mem)
+	code := []byte("PK\x03\x04 zip bytes")
+
+	sum, err := s.Put(t.Context(), testRef, code)
+	require.NoError(t, err)
+	want := sha256.Sum256(code)
+	assert.Equal(t, hex.EncodeToString(want[:]), sum)
+
+	_, err = mem.HeadObject(t.Context(), &s3.HeadObjectInput{
+		Bucket: aws.String("lambda-code-ap-southeast-2"), Key: aws.String(copyKey(sum))})
+	require.NoError(t, err, "copy is keyed by account, function, revision and digest")
+
+	got, err := s.Get(t.Context(), testRef, sum)
+	require.NoError(t, err)
+	assert.Equal(t, code, got)
+
+	require.NoError(t, s.Delete(t.Context(), testRef, sum))
+	_, err = s.Get(t.Context(), testRef, sum)
+	require.ErrorIs(t, err, ErrCodeNotFound)
+	require.NoError(t, s.Delete(t.Context(), testRef, sum), "deleting an absent copy succeeds")
+}
+
+// A retry or a racing write with different bytes for the same revision lands on
+// its own digest key, so the recorded copy is never replaced.
+func TestStore_DifferentBytesNeverReplaceRecordedCopy(t *testing.T) {
+	s := newStore(testRegion, objectstore.NewMemoryObjectStore())
+	recorded, err := s.Put(t.Context(), testRef, []byte("first"))
+	require.NoError(t, err)
+
+	var wg sync.WaitGroup
+	others := make([]string, 8)
+	for i := range others {
+		wg.Go(func() {
+			sum, err := s.Put(t.Context(), testRef, []byte(fmt.Sprintf("other-%d", i)))
+			assert.NoError(t, err)
+			others[i] = sum
+		})
+	}
+	wg.Wait()
+
+	got, err := s.Get(t.Context(), testRef, recorded)
+	require.NoError(t, err)
+	assert.Equal(t, []byte("first"), got)
+	for i, sum := range others {
+		got, err := s.Get(t.Context(), testRef, sum)
+		require.NoError(t, err)
+		assert.Equal(t, []byte(fmt.Sprintf("other-%d", i)), got)
+	}
+}
+
+// DeleteRevision clears every copy of one revision, including a failed
+// attempt's, and leaves other revisions alone.
+func TestStore_DeleteRevisionRemovesAllCopiesOfThatRevisionOnly(t *testing.T) {
+	s := newStore(testRegion, objectstore.NewMemoryObjectStore())
+	a, err := s.Put(t.Context(), testRef, []byte("kept attempt"))
+	require.NoError(t, err)
+	b, err := s.Put(t.Context(), testRef, []byte("failed attempt"))
+	require.NoError(t, err)
+	sibling := Ref{AccountID: testRef.AccountID, FunctionID: testRef.FunctionID, RevisionID: "rev-10"}
+	c, err := s.Put(t.Context(), sibling, []byte("next revision"))
+	require.NoError(t, err)
+
+	require.NoError(t, s.DeleteRevision(t.Context(), testRef))
+
+	for _, sum := range []string{a, b} {
+		_, err := s.Get(t.Context(), testRef, sum)
+		require.ErrorIs(t, err, ErrCodeNotFound)
+	}
+	_, err = s.Get(t.Context(), sibling, c)
+	require.NoError(t, err, "rev-10 shares the rev-1 string prefix but not its key prefix")
+}
+
+func TestStore_GetRefusesDigestMismatch(t *testing.T) {
+	mem := objectstore.NewMemoryObjectStore()
+	s := newStore(testRegion, mem)
+	sum, err := s.Put(t.Context(), testRef, []byte("original"))
+	require.NoError(t, err)
+	_, err = mem.PutObject(t.Context(), &s3.PutObjectInput{
+		Bucket: aws.String(BucketName(testRegion)), Key: aws.String(copyKey(sum)),
+		Body: bytes.NewReader([]byte("replaced"))})
+	require.NoError(t, err)
+
+	_, err = s.Get(t.Context(), testRef, sum)
+	require.ErrorIs(t, err, ErrDigestMismatch)
+}
+
+func TestStore_RejectsUnsafeRefAndOversize(t *testing.T) {
+	s := newStore(testRegion, objectstore.NewMemoryObjectStore())
+	for _, ref := range []Ref{
+		{AccountID: "", FunctionID: "f", RevisionID: "r"},
+		{AccountID: "a", FunctionID: "..", RevisionID: "r"},
+		{AccountID: "a", FunctionID: "f/../../other", RevisionID: "r"},
+	} {
+		_, err := s.Put(t.Context(), ref, []byte("x"))
+		require.ErrorIs(t, err, ErrInvalidRef, "%+v", ref)
+	}
+	_, err := s.Put(t.Context(), testRef, make([]byte, MaxCodeBytes+1))
+	require.ErrorIs(t, err, ErrCodeTooLarge)
+	_, err = s.Get(t.Context(), testRef, "../../other")
+	require.ErrorIs(t, err, ErrInvalidRef, "a digest is never used as a raw key segment")
+}
+
+func TestOpen_FailsWhenRoleNotAssumable(t *testing.T) {
+	_, err := Open(OpenConfig{Region: testRegion, Endpoint: "https://127.0.0.1:1", SigningRegion: testRegion,
+		Assume: func() (*sts.AssumeRoleOutput, error) { return nil, errors.New("AccessDenied") }})
+	require.Error(t, err)
+}
+
+func TestManager_InitialisesOnFirstUseWithBackoff(t *testing.T) {
+	attempts := 0
+	m := NewManager(func(context.Context) error {
+		attempts++
+		if attempts < 3 {
+			return ErrNotOwned
+		}
+		return nil
+	}, func() (*Store, error) { return newStore(testRegion, objectstore.NewMemoryObjectStore()), nil })
+	now := time.Unix(1_000_000, 0)
+	m.now = func() time.Time { return now }
+	assert.Zero(t, attempts, "construction does no provisioning")
+
+	_, err := m.Store(t.Context())
+	require.ErrorIs(t, err, ErrNotReady)
+	require.ErrorIs(t, err, ErrNotOwned)
+	_, err = m.Store(t.Context())
+	require.ErrorIs(t, err, ErrNotReady)
+	assert.Equal(t, 1, attempts, "a call inside the backoff window does not retry")
+
+	now = now.Add(time.Second)
+	_, err = m.Store(t.Context())
+	require.ErrorIs(t, err, ErrNotReady)
+	now = now.Add(time.Second)
+	_, err = m.Store(t.Context())
+	require.ErrorIs(t, err, ErrNotReady, "backoff doubled to 2s")
+	now = now.Add(time.Second)
+	first, err := m.Store(t.Context())
+	require.NoError(t, err)
+	again, err := m.Store(t.Context())
+	require.NoError(t, err)
+	assert.Same(t, first, again)
+	assert.Equal(t, 3, attempts)
+}

spinifex/domains/lambda/function/client.go

@@ -0,0 +1,67 @@
+package function
+
+import (
+	"context"
+	"time"
+
+	natsmsg "github.com/mulgadc/spinifex/spinifex/foundation/messaging/nats"
+	"github.com/nats-io/nats.go"
+)
+
+const metaRequestTimeout = 30 * time.Second
+
+// Client is the gateway's view of the daemon-owned function records.
+type Client interface {
+	// Create binds the name and returns the KV revision.
+	Create(ctx context.Context, accountID, region string, rec Record) (uint64, error)
+	// Get returns the record and revision, or ErrNotFound.
+	Get(ctx context.Context, accountID, region, name string) (Record, uint64, error)
+	// CodeStored marks the code stored and returns the stored record and revision.
+	CodeStored(ctx context.Context, accountID, region, name string, revision uint64, sha256Hex string, size int64) (Record, uint64, error)
+	// RollbackCreate frees the name while the record is still storing at revision.
+	RollbackCreate(ctx context.Context, accountID, region, name string, revision uint64) error
+}
+
+// NATSClient is the Client over NATS request/reply to the daemon.
+type NATSClient struct {
+	conn *nats.Conn
+}
+
+var _ Client = (*NATSClient)(nil)
+
+// NewNATSClient builds a NATS-backed Client.
+func NewNATSClient(conn *nats.Conn) *NATSClient { return &NATSClient{conn: conn} }
+
+func (c *NATSClient) Create(ctx context.Context, accountID, region string, rec Record) (uint64, error) {
+	resp, err := natsmsg.NATSRequest[CreateResponse](ctx, c.conn, SubjectCreate, &CreateRequest{Region: region, Record: rec}, metaRequestTimeout, accountID)
+	if err != nil {
+		return 0, err
+	}
+	return resp.Revision, nil
+}
+
+func (c *NATSClient) Get(ctx context.Context, accountID, region, name string) (Record, uint64, error) {
+	resp, err := natsmsg.NATSRequest[GetResponse](ctx, c.conn, SubjectGet, &GetRequest{Region: region, FunctionName: name}, metaRequestTimeout, accountID)
+	if err != nil {
+		return Record{}, 0, err
+	}
+	if !resp.Found {
+		return Record{}, 0, ErrNotFound
+	}
+	return resp.Record, resp.Revision, nil
+}
+
+func (c *NATSClient) CodeStored(ctx context.Context, accountID, region, name string, revision uint64, sha256Hex string, size int64) (Record, uint64, error) {
+	resp, err := natsmsg.NATSRequest[CodeStoredResponse](ctx, c.conn, SubjectCodeStored,
+		&CodeStoredRequest{Region: region, FunctionName: name, Revision: revision, SHA256: sha256Hex, Size: size}, metaRequestTimeout, accountID)
+	if err != nil {
+		return Record{}, 0, err
+	}
+	return resp.Record, resp.Revision, nil
+}
+
+func (c *NATSClient) RollbackCreate(ctx context.Context, accountID, region, name string, revision uint64) error {
+	_, err := natsmsg.NATSRequest[RollbackCreateResponse](ctx, c.conn, SubjectRollbackCreate,
+		&RollbackCreateRequest{Region: region, FunctionName: name, Revision: revision}, metaRequestTimeout, accountID)
+	return err
+}

spinifex/domains/lambda/function/envcrypt.go

@@ -0,0 +1,56 @@
+package function
+
+import (
+	"crypto/cipher"
+	"crypto/rand"
+	"encoding/base64"
+	"encoding/json"
+	"errors"
+	"fmt"
+)
+
+func envAAD(accountID, functionID string) []byte {
+	return []byte("lambda-env/v1|" + accountID + "|" + functionID)
+}
+
+// SealEnv encrypts the variables as base64(nonce||ciphertext), bound to the
+// account and function. No variables yield "".
+func SealEnv(aead cipher.AEAD, accountID, functionID string, vars map[string]string) (string, error) {
+	if len(vars) == 0 {
+		return "", nil
+	}
+	plain, err := json.Marshal(vars)
+	if err != nil {
+		return "", fmt.Errorf("encode environment: %w", err)
+	}
+	nonce := make([]byte, aead.NonceSize())
+	if _, err := rand.Read(nonce); err != nil {
+		return "", fmt.Errorf("environment nonce: %w", err)
+	}
+	sealed := aead.Seal(nonce, nonce, plain, envAAD(accountID, functionID))
+	return base64.StdEncoding.EncodeToString(sealed), nil
+}
+
+// OpenEnv reverses SealEnv. A blob sealed for another account or function fails.
+func OpenEnv(aead cipher.AEAD, accountID, functionID, sealed string) (map[string]string, error) {
+	if sealed == "" {
+		return nil, nil
+	}
+	raw, err := base64.StdEncoding.DecodeString(sealed)
+	if err != nil {
+		return nil, fmt.Errorf("decode environment: %w", err)
+	}
+	n := aead.NonceSize()
+	if len(raw) < n+aead.Overhead() {
+		return nil, errors.New("environment blob too short")
+	}
+	plain, err := aead.Open(nil, raw[:n], raw[n:], envAAD(accountID, functionID))
+	if err != nil {
+		return nil, fmt.Errorf("open environment: %w", err)
+	}
+	var vars map[string]string
+	if err := json.Unmarshal(plain, &vars); err != nil {
+		return nil, fmt.Errorf("decode environment: %w", err)
+	}
+	return vars, nil
+}

spinifex/domains/lambda/function/envcrypt_test.go

@@ -0,0 +1,62 @@
+package function
+
+import (
+	"testing"
+
+	"github.com/mulgadc/bluebottle/pkg/masterkey"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func testAEAD(t *testing.T) *masterkey.Key {
+	t.Helper()
+	k, err := masterkey.New(make([]byte, 32))
+	require.NoError(t, err)
+	return k
+}
+
+func TestEnv_RoundTripAndNoPlaintext(t *testing.T) {
+	k := testAEAD(t)
+	vars := map[string]string{"DB_PASSWORD": "hunter2", "MODE": "prod"}
+
+	sealed, err := SealEnv(k.AEAD, "000000000001", "fn1", vars)
+	require.NoError(t, err)
+	assert.NotContains(t, sealed, "hunter2")
+
+	got, err := OpenEnv(k.AEAD, "000000000001", "fn1", sealed)
+	require.NoError(t, err)
+	assert.Equal(t, vars, got)
+
+	again, err := SealEnv(k.AEAD, "000000000001", "fn1", vars)
+	require.NoError(t, err)
+	assert.NotEqual(t, sealed, again, "each seal draws a fresh nonce")
+}
+
+func TestEnv_BoundToAccountAndFunction(t *testing.T) {
+	k := testAEAD(t)
+	sealed, err := SealEnv(k.AEAD, "000000000001", "fn1", map[string]string{"A": "b"})
+	require.NoError(t, err)
+
+	_, err = OpenEnv(k.AEAD, "000000000001", "fn2", sealed)
+	require.Error(t, err)
+	_, err = OpenEnv(k.AEAD, "000000000002", "fn1", sealed)
+	require.Error(t, err)
+	_, err = OpenEnv(k.AEAD, "000000000001", "fn1", "not base64 !!")
+	require.Error(t, err)
+	_, err = OpenEnv(k.AEAD, "000000000001", "fn1", "AAAA")
+	require.Error(t, err)
+}
+
+func TestEnv_EmptyIsEmpty(t *testing.T) {
+	k := testAEAD(t)
+	sealed, err := SealEnv(k.AEAD, "a", "f", nil)
+	require.NoError(t, err)
+	assert.Empty(t, sealed)
+	sealed, err = SealEnv(k.AEAD, "a", "f", map[string]string{})
+	require.NoError(t, err)
+	assert.Empty(t, sealed)
+
+	got, err := OpenEnv(k.AEAD, "a", "f", "")
+	require.NoError(t, err)
+	assert.Empty(t, got)
+}

spinifex/domains/lambda/function/meta.go

@@ -0,0 +1,259 @@
+package function
+
+import (
+	"context"
+	"encoding/json"
+	"errors"
+	"fmt"
+	"log/slog"
+	"regexp"
+	"sync"
+	"time"
+
+	awserrors "github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+	"github.com/mulgadc/spinifex/spinifex/foundation/state/kvutil"
+	"github.com/nats-io/nats.go/jetstream"
+)
+
+// ClaimTTL is how long a record still storing its code holds its name. It must
+// exceed the gateway request deadline plus the longest permitted code write.
+const ClaimTTL = 5 * time.Minute
+
+// ErrNotFound means no record is bound to the name.
+var ErrNotFound = errors.New("lambda function not found")
+
+var (
+	nameRE   = regexp.MustCompile(`^[a-zA-Z0-9-_]{1,64}$`)
+	regionRE = regexp.MustCompile(`^[a-z0-9-]{1,32}$`)
+	digestRE = regexp.MustCompile(`^[0-9a-f]{64}$`)
+)
+
+// ValidName reports whether name is a legal function name.
+func ValidName(name string) bool { return nameRE.MatchString(name) }
+
+func badRegion() error {
+	return awserrors.Errorf(awserrors.ErrorInvalidParameterValueException, "region is invalid")
+}
+
+// MetaService is the daemon-side owner of function records. Every update is a
+// compare-and-swap on the revision the caller read or was handed.
+type MetaService struct {
+	js  jetstream.JetStream
+	now func() time.Time
+
+	mu      sync.Mutex
+	buckets map[string]jetstream.KeyValue
+}
+
+// NewMetaService builds the service over a JetStream handle.
+func NewMetaService(js jetstream.JetStream) *MetaService {
+	return &MetaService{js: js, now: time.Now, buckets: make(map[string]jetstream.KeyValue)}
+}
+
+func (s *MetaService) bucket(ctx context.Context, accountID string) (jetstream.KeyValue, error) {
+	s.mu.Lock()
+	defer s.mu.Unlock()
+	if kv, ok := s.buckets[accountID]; ok {
+		return kv, nil
+	}
+	name := KVAccountBucket(accountID)
+	kv, err := kvutil.GetOrCreateBucket(ctx, s.js, name, KVBucketAccountHistory)
+	if err != nil {
+		return nil, fmt.Errorf("lambda: open account bucket %s: %w", name, err)
+	}
+	s.buckets[accountID] = kv
+	return kv, nil
+}
+
+func conflict(format string, args ...any) error {
+	return awserrors.Errorf(awserrors.ErrorResourceConflictException, format, args...)
+}
+
+func decode(data []byte) (Record, error) {
+	var rec Record
+	if err := json.Unmarshal(data, &rec); err != nil {
+		return Record{}, awserrors.Errorf(awserrors.ErrorServiceException, "function record is unreadable")
+	}
+	if rec.FormatVersion != FormatVersion {
+		return Record{}, awserrors.Errorf(awserrors.ErrorServiceException,
+			"function record has unsupported format version %d", rec.FormatVersion)
+	}
+	return rec, nil
+}
+
+// Create binds the name by writing the record with kv.Create. The record starts
+// Pending with its code storing and a claim that expires after ClaimTTL. A name
+// held only by an expired, still-storing claim is taken over once.
+//
+// Orphaned code objects from rolled-back or taken-over claims are not cleaned up yet.
+func (s *MetaService) Create(ctx context.Context, req *CreateRequest, accountID string) (*CreateResponse, error) {
+	rec := req.Record
+	if !regionRE.MatchString(req.Region) {
+		return nil, badRegion()
+	}
+	if !ValidName(rec.FunctionName) || rec.FunctionID == "" || rec.Code.RevisionID == "" || accountID == "" {
+		return nil, awserrors.Errorf(awserrors.ErrorInvalidParameterValueException, "function record is incomplete")
+	}
+	kv, err := s.bucket(ctx, accountID)
+	if err != nil {
+		return nil, err
+	}
+	now := s.now().UTC()
+	rec.FormatVersion = FormatVersion
+	rec.AccountID, rec.Region = accountID, req.Region
+	rec.State = StatePending
+	rec.StateReason, rec.StateReasonCode = "", ""
+	rec.Code = Code{RevisionID: rec.Code.RevisionID, State: CodeStoring}
+	rec.ClaimExpiresAt = now.Add(ClaimTTL)
+	rec.CreatedAt, rec.LastModified = now, now
+	data, err := json.Marshal(rec)
+	if err != nil {
+		return nil, err
+	}
+	key := KVFunctionKey(req.Region, rec.FunctionName)
+
+	rev, err := kv.Create(ctx, key, data)
+	if err == nil {
+		return &CreateResponse{Revision: rev}, nil
+	}
+	if !errors.Is(err, jetstream.ErrKeyExists) {
+		return nil, fmt.Errorf("lambda: create function record: %w", err)
+	}
+
+	exists := conflict("Function already exist: %s", rec.FunctionName)
+	entry, err := kv.Get(ctx, key)
+	if err != nil {
+		return nil, exists
+	}
+	old, err := decode(entry.Value())
+	if err != nil || old.Code.State != CodeStoring || !s.now().After(old.ClaimExpiresAt) {
+		return nil, exists
+	}
+	if err := kv.Delete(ctx, key, jetstream.LastRevision(entry.Revision())); err != nil {
+		return nil, exists
+	}
+	slog.WarnContext(ctx, "Lambda: took over an expired function name claim",
+		"function_name", rec.FunctionName, "old_function_id", old.FunctionID)
+	rev, err = kv.Create(ctx, key, data)
+	if err != nil {
+		if errors.Is(err, jetstream.ErrKeyExists) {
+			return nil, exists
+		}
+		return nil, fmt.Errorf("lambda: create function record: %w", err)
+	}
+	return &CreateResponse{Revision: rev}, nil
+}
+
+// Get returns the record, or Found false when the name is unbound.
+func (s *MetaService) Get(ctx context.Context, req *GetRequest, accountID string) (*GetResponse, error) {
+	if !regionRE.MatchString(req.Region) {
+		return nil, badRegion()
+	}
+	kv, err := s.bucket(ctx, accountID)
+	if err != nil {
+		return nil, err
+	}
+	entry, err := kv.Get(ctx, KVFunctionKey(req.Region, req.FunctionName))
+	if errors.Is(err, jetstream.ErrKeyNotFound) {
+		return &GetResponse{}, nil
+	}
+	if err != nil {
+		return nil, fmt.Errorf("lambda: get function record: %w", err)
+	}
+	rec, err := decode(entry.Value())
+	if err != nil {
+		return nil, err
+	}
+	return &GetResponse{Found: true, Record: rec, Revision: entry.Revision()}, nil
+}
+
+// readStoring loads the record and checks it is the one the caller created: the
+// revision matches and the code is still storing.
+func (s *MetaService) readStoring(ctx context.Context, kv jetstream.KeyValue, region, name string, revision uint64) (Record, error) {
+	entry, err := kv.Get(ctx, KVFunctionKey(region, name))
+	if errors.Is(err, jetstream.ErrKeyNotFound) {
+		return Record{}, ErrNotFound
+	}
+	if err != nil {
+		return Record{}, fmt.Errorf("lambda: get function record: %w", err)
+	}
+	if entry.Revision() != revision {
+		return Record{}, conflict("Function was modified by another request: %s", name)
+	}
+	rec, err := decode(entry.Value())
+	if err != nil {
+		return Record{}, err
+	}
+	if rec.Code.State != CodeStoring {
+		return Record{}, conflict("Function code is not being stored: %s", name)
+	}
+	return rec, nil
+}
+
+// CodeStored marks the code stored. It is refused, leaving the record unchanged,
+// when the revision moved, the code is not storing, or the claim has expired.
+func (s *MetaService) CodeStored(ctx context.Context, req *CodeStoredRequest, accountID string) (*CodeStoredResponse, error) {
+	if !regionRE.MatchString(req.Region) {
+		return nil, badRegion()
+	}
+	if !digestRE.MatchString(req.SHA256) || req.Size < 0 {
+		return nil, awserrors.Errorf(awserrors.ErrorInvalidParameterValueException, "code digest is invalid")
+	}
+	kv, err := s.bucket(ctx, accountID)
+	if err != nil {
+		return nil, err
+	}
+	rec, err := s.readStoring(ctx, kv, req.Region, req.FunctionName, req.Revision)
+	if errors.Is(err, ErrNotFound) {
+		return nil, awserrors.Errorf(awserrors.ErrorResourceNotFoundException, "Function not found: %s", req.FunctionName)
+	}
+	if err != nil {
+		return nil, err
+	}
+	now := s.now()
+	if now.After(rec.ClaimExpiresAt) {
+		return nil, conflict("Function creation claim expired: %s", req.FunctionName)
+	}
+	rec.Code.State, rec.Code.SHA256, rec.Code.Size = CodeStored, req.SHA256, req.Size
+	rec.State, rec.StateReasonCode, rec.StateReason = StatePending, ReasonCodeCreating, ReasonCreating
+	rec.LastModified = now.UTC()
+	data, err := json.Marshal(rec)
+	if err != nil {
+		return nil, err
+	}
+	rev, err := kv.Update(ctx, KVFunctionKey(req.Region, req.FunctionName), data, req.Revision)
+	if err != nil {
+		if errors.Is(err, jetstream.ErrKeyExists) {
+			return nil, conflict("Function was modified by another request: %s", req.FunctionName)
+		}
+		return nil, fmt.Errorf("lambda: update function record: %w", err)
+	}
+	return &CodeStoredResponse{Record: rec, Revision: rev}, nil
+}
+
+// RollbackCreate frees the name of a create whose own code write failed. It
+// deletes only a record still storing at exactly the revision create returned;
+// an already-absent name is success.
+func (s *MetaService) RollbackCreate(ctx context.Context, req *RollbackCreateRequest, accountID string) (*RollbackCreateResponse, error) {
+	if !regionRE.MatchString(req.Region) {
+		return nil, badRegion()
+	}
+	kv, err := s.bucket(ctx, accountID)
+	if err != nil {
+		return nil, err
+	}
+	_, err = s.readStoring(ctx, kv, req.Region, req.FunctionName, req.Revision)
+	if errors.Is(err, ErrNotFound) {
+		return &RollbackCreateResponse{}, nil
+	}
+	if err != nil {
+		return nil, err
+	}
+	if err := kv.Delete(ctx, KVFunctionKey(req.Region, req.FunctionName), jetstream.LastRevision(req.Revision)); err != nil {
+		if errors.Is(err, jetstream.ErrKeyExists) {
+			return nil, conflict("Function was modified by another request: %s", req.FunctionName)
+		}
+		return nil, fmt.Errorf("lambda: delete function record: %w", err)
+	}
+	return &RollbackCreateResponse{}, nil
+}

spinifex/domains/lambda/function/meta_test.go

@@ -0,0 +1,263 @@
+package function
+
+import (
+	"encoding/json"
+	"testing"
+	"time"
+
+	"github.com/mulgadc/spinifex/internal/testkit"
+	awserrors "github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+const (
+	testAccount = "000000000001"
+	testRegion  = "ap-southeast-2"
+	testDigest  = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+)
+
+type clock struct{ t time.Time }
+
+func (c *clock) now() time.Time { return c.t }
+
+func newTestService(t *testing.T) (*MetaService, *clock) {
+	t.Helper()
+	_, nc, _ := testutil.StartTestJetStream(t)
+	svc := NewMetaService(testutil.NewJetStream(t, nc))
+	c := &clock{t: time.Date(2026, 11, 2, 10, 0, 0, 0, time.UTC)}
+	svc.now = c.now
+	return svc, c
+}
+
+func createReq(name, functionID string) *CreateRequest {
+	return &CreateRequest{Region: testRegion, Record: Record{
+		FunctionID: functionID, FunctionName: name, Role: "arn:aws:iam::000000000001:role/r",
+		Runtime: "provided.al2023", Handler: "bootstrap", Timeout: 3, MemorySize: 128,
+		Code: Code{RevisionID: "rev-" + functionID},
+	}}
+}
+
+func mustCreate(t *testing.T, svc *MetaService, name, functionID string) uint64 {
+	t.Helper()
+	resp, err := svc.Create(t.Context(), createReq(name, functionID), testAccount)
+	require.NoError(t, err)
+	return resp.Revision
+}
+
+func mustGet(t *testing.T, svc *MetaService, name string) *GetResponse {
+	t.Helper()
+	resp, err := svc.Get(t.Context(), &GetRequest{Region: testRegion, FunctionName: name}, testAccount)
+	require.NoError(t, err)
+	return resp
+}
+
+func requireCode(t *testing.T, err error, code string) {
+	t.Helper()
+	require.Error(t, err)
+	got, ok := awserrors.ResolveErrorCode(err)
+	require.True(t, ok, "no AWS code on %v", err)
+	assert.Equal(t, code, got)
+}
+
+func TestMeta_CreateOwnsStateAndRejectsDuplicate(t *testing.T) {
+	svc, c := newTestService(t)
+	req := createReq("hello", "f1")
+	req.Record.State = StateActive
+	req.Record.Code.State = CodeStored
+	req.Record.AccountID = "someone-else"
+	resp, err := svc.Create(t.Context(), req, testAccount)
+	require.NoError(t, err)
+
+	got := mustGet(t, svc, "hello")
+	require.True(t, got.Found)
+	assert.Equal(t, resp.Revision, got.Revision)
+	assert.Equal(t, StatePending, got.Record.State, "the daemon owns state")
+	assert.Equal(t, CodeStoring, got.Record.Code.State)
+	assert.Equal(t, testAccount, got.Record.AccountID, "the account comes from the request header")
+	assert.Equal(t, FormatVersion, got.Record.FormatVersion)
+	assert.Equal(t, c.t.Add(ClaimTTL), got.Record.ClaimExpiresAt)
+
+	_, err = svc.Create(t.Context(), createReq("hello", "f2"), testAccount)
+	requireCode(t, err, awserrors.ErrorResourceConflictException)
+	assert.Equal(t, "f1", mustGet(t, svc, "hello").Record.FunctionID, "the first record is untouched")
+
+	other, err := svc.Create(t.Context(), createReq("hello", "f3"), "000000000002")
+	require.NoError(t, err, "names are per account")
+	assert.NotZero(t, other.Revision)
+}
+
+func TestMeta_CreateRefusesIncompleteRecords(t *testing.T) {
+	svc, _ := newTestService(t)
+	for name, mutate := range map[string]func(*Record){
+		"bad name":    func(r *Record) { r.FunctionName = "has space" },
+		"no id":       func(r *Record) { r.FunctionID = "" },
+		"no revision": func(r *Record) { r.Code.RevisionID = "" },
+	} {
+		t.Run(name, func(t *testing.T) {
+			req := createReq("ok", "f1")
+			mutate(&req.Record)
+			_, err := svc.Create(t.Context(), req, testAccount)
+			requireCode(t, err, awserrors.ErrorInvalidParameterValueException)
+		})
+	}
+}
+
+func TestMeta_CodeStoredUsesCAS(t *testing.T) {
+	svc, _ := newTestService(t)
+	rev := mustCreate(t, svc, "hello", "f1")
+
+	_, err := svc.CodeStored(t.Context(), &CodeStoredRequest{Region: testRegion, FunctionName: "hello", Revision: rev + 5, SHA256: testDigest, Size: 9}, testAccount)
+	requireCode(t, err, awserrors.ErrorResourceConflictException)
+	assert.Equal(t, CodeStoring, mustGet(t, svc, "hello").Record.Code.State, "a stale revision changes nothing")
+
+	_, err = svc.CodeStored(t.Context(), &CodeStoredRequest{Region: testRegion, FunctionName: "hello", Revision: rev, SHA256: "xyz", Size: 9}, testAccount)
+	requireCode(t, err, awserrors.ErrorInvalidParameterValueException)
+
+	resp, err := svc.CodeStored(t.Context(), &CodeStoredRequest{Region: testRegion, FunctionName: "hello", Revision: rev, SHA256: testDigest, Size: 9}, testAccount)
+	require.NoError(t, err)
+	got := mustGet(t, svc, "hello")
+	assert.Equal(t, resp.Revision, got.Revision)
+	assert.Equal(t, CodeStored, got.Record.Code.State)
+	assert.Equal(t, testDigest, got.Record.Code.SHA256)
+	assert.Equal(t, int64(9), got.Record.Code.Size)
+	assert.Equal(t, StatePending, got.Record.State)
+	assert.Equal(t, ReasonCodeCreating, got.Record.StateReasonCode)
+	assert.Equal(t, ReasonCreating, got.Record.StateReason)
+
+	_, err = svc.CodeStored(t.Context(), &CodeStoredRequest{Region: testRegion, FunctionName: "hello", Revision: resp.Revision, SHA256: testDigest, Size: 9}, testAccount)
+	requireCode(t, err, awserrors.ErrorResourceConflictException)
+
+	_, err = svc.CodeStored(t.Context(), &CodeStoredRequest{Region: testRegion, FunctionName: "ghost", Revision: 1, SHA256: testDigest}, testAccount)
+	requireCode(t, err, awserrors.ErrorResourceNotFoundException)
+}
+
+func TestMeta_RollbackDeletesOnlyStoringAtTheRightRevision(t *testing.T) {
+	svc, _ := newTestService(t)
+	rev := mustCreate(t, svc, "hello", "f1")
+
+	_, err := svc.RollbackCreate(t.Context(), &RollbackCreateRequest{Region: testRegion, FunctionName: "hello", Revision: rev + 1}, testAccount)
+	requireCode(t, err, awserrors.ErrorResourceConflictException)
+	require.True(t, mustGet(t, svc, "hello").Found)
+
+	_, err = svc.RollbackCreate(t.Context(), &RollbackCreateRequest{Region: testRegion, FunctionName: "hello", Revision: rev}, testAccount)
+	require.NoError(t, err)
+	assert.False(t, mustGet(t, svc, "hello").Found)
+	_, err = svc.RollbackCreate(t.Context(), &RollbackCreateRequest{Region: testRegion, FunctionName: "hello", Revision: rev}, testAccount)
+	require.NoError(t, err, "rolling back an absent name is success")
+	mustCreate(t, svc, "hello", "f2")
+	assert.Equal(t, "f2", mustGet(t, svc, "hello").Record.FunctionID, "the name is free again")
+
+	rev = mustGet(t, svc, "hello").Revision
+	stored, err := svc.CodeStored(t.Context(), &CodeStoredRequest{Region: testRegion, FunctionName: "hello", Revision: rev, SHA256: testDigest, Size: 1}, testAccount)
+	require.NoError(t, err)
+	_, err = svc.RollbackCreate(t.Context(), &RollbackCreateRequest{Region: testRegion, FunctionName: "hello", Revision: stored.Revision}, testAccount)
+	requireCode(t, err, awserrors.ErrorResourceConflictException)
+	assert.True(t, mustGet(t, svc, "hello").Found, "a stored record is never rolled back")
+}
+
+func TestMeta_GetMissingAndUnknownFormat(t *testing.T) {
+	svc, _ := newTestService(t)
+	assert.False(t, mustGet(t, svc, "ghost").Found)
+
+	kv, err := svc.bucket(t.Context(), testAccount)
+	require.NoError(t, err)
+	data, err := json.Marshal(Record{FormatVersion: 99, FunctionName: "future"})
+	require.NoError(t, err)
+	_, err = kv.Create(t.Context(), KVFunctionKey(testRegion, "future"), data)
+	require.NoError(t, err)
+
+	_, err = svc.Get(t.Context(), &GetRequest{Region: testRegion, FunctionName: "future"}, testAccount)
+	requireCode(t, err, awserrors.ErrorServiceException)
+	_, err = svc.Create(t.Context(), createReq("future", "f1"), testAccount)
+	requireCode(t, err, awserrors.ErrorResourceConflictException)
+	_, err = svc.RollbackCreate(t.Context(), &RollbackCreateRequest{Region: testRegion, FunctionName: "future", Revision: 1}, testAccount)
+	requireCode(t, err, awserrors.ErrorServiceException)
+}
+
+func TestMeta_ExpiredStoringClaimIsTakenOver(t *testing.T) {
+	svc, c := newTestService(t)
+	oldRev := mustCreate(t, svc, "hello", "old")
+
+	c.t = c.t.Add(ClaimTTL - time.Second)
+	_, err := svc.Create(t.Context(), createReq("hello", "new"), testAccount)
+	requireCode(t, err, awserrors.ErrorResourceConflictException)
+	assert.Equal(t, "old", mustGet(t, svc, "hello").Record.FunctionID, "an unexpired claim holds the name")
+
+	c.t = c.t.Add(2 * time.Second)
+	newRev := mustCreate(t, svc, "hello", "new")
+	got := mustGet(t, svc, "hello")
+	assert.Equal(t, "new", got.Record.FunctionID)
+	assert.Equal(t, "rev-new", got.Record.Code.RevisionID)
+	assert.Equal(t, newRev, got.Revision)
+	assert.Equal(t, c.t.Add(ClaimTTL), got.Record.ClaimExpiresAt)
+
+	_, err = svc.CodeStored(t.Context(), &CodeStoredRequest{Region: testRegion, FunctionName: "hello", Revision: oldRev, SHA256: testDigest, Size: 1}, testAccount)
+	requireCode(t, err, awserrors.ErrorResourceConflictException)
+	_, err = svc.RollbackCreate(t.Context(), &RollbackCreateRequest{Region: testRegion, FunctionName: "hello", Revision: oldRev}, testAccount)
+	requireCode(t, err, awserrors.ErrorResourceConflictException)
+	got = mustGet(t, svc, "hello")
+	assert.Equal(t, "new", got.Record.FunctionID, "the stale gateway cannot resurrect or free the old claim")
+	assert.Equal(t, CodeStoring, got.Record.Code.State)
+}
+
+func TestMeta_StoredRecordIsNeverTakenOver(t *testing.T) {
+	svc, c := newTestService(t)
+	rev := mustCreate(t, svc, "hello", "f1")
+	_, err := svc.CodeStored(t.Context(), &CodeStoredRequest{Region: testRegion, FunctionName: "hello", Revision: rev, SHA256: testDigest, Size: 1}, testAccount)
+	require.NoError(t, err)
+
+	c.t = c.t.Add(10 * ClaimTTL)
+	_, err = svc.Create(t.Context(), createReq("hello", "f2"), testAccount)
+	requireCode(t, err, awserrors.ErrorResourceConflictException)
+	assert.Equal(t, "f1", mustGet(t, svc, "hello").Record.FunctionID)
+}
+
+func TestMeta_CodeStoredAfterExpiryIsRefused(t *testing.T) {
+	svc, c := newTestService(t)
+	rev := mustCreate(t, svc, "hello", "f1")
+
+	c.t = c.t.Add(ClaimTTL + time.Second)
+	_, err := svc.CodeStored(t.Context(), &CodeStoredRequest{Region: testRegion, FunctionName: "hello", Revision: rev, SHA256: testDigest, Size: 1}, testAccount)
+	requireCode(t, err, awserrors.ErrorResourceConflictException)
+	got := mustGet(t, svc, "hello")
+	assert.Equal(t, CodeStoring, got.Record.Code.State, "a refused update leaves the record unchanged")
+	assert.Equal(t, rev, got.Revision)
+}
+
+func TestMeta_RegionsAreIndependent(t *testing.T) {
+	svc, _ := newTestService(t)
+	sydney := createReq("hello", "syd")
+	oregon := createReq("hello", "pdx")
+	oregon.Region = "us-west-2"
+	_, err := svc.Create(t.Context(), sydney, testAccount)
+	require.NoError(t, err)
+	_, err = svc.Create(t.Context(), oregon, testAccount)
+	require.NoError(t, err, "the same name in another Region is a different function")
+
+	got, err := svc.Get(t.Context(), &GetRequest{Region: "us-west-2", FunctionName: "hello"}, testAccount)
+	require.NoError(t, err)
+	assert.Equal(t, "pdx", got.Record.FunctionID)
+	assert.Equal(t, "us-west-2", got.Record.Region)
+	assert.Equal(t, "syd", mustGet(t, svc, "hello").Record.FunctionID)
+	assert.Equal(t, testRegion, mustGet(t, svc, "hello").Record.Region)
+
+	_, err = svc.Create(t.Context(), createReq("hello", "again"), testAccount)
+	requireCode(t, err, awserrors.ErrorResourceConflictException)
+}
+
+func TestMeta_RefusesBadRegion(t *testing.T) {
+	svc, _ := newTestService(t)
+	for _, region := range []string{"", "AP-SOUTH", "a.b", "a b", "x/y"} {
+		req := createReq("hello", "f1")
+		req.Region = region
+		_, err := svc.Create(t.Context(), req, testAccount)
+		requireCode(t, err, awserrors.ErrorInvalidParameterValueException)
+		_, err = svc.Get(t.Context(), &GetRequest{Region: region, FunctionName: "hello"}, testAccount)
+		requireCode(t, err, awserrors.ErrorInvalidParameterValueException)
+		_, err = svc.CodeStored(t.Context(), &CodeStoredRequest{Region: region, FunctionName: "hello", Revision: 1, SHA256: testDigest}, testAccount)
+		requireCode(t, err, awserrors.ErrorInvalidParameterValueException)
+		_, err = svc.RollbackCreate(t.Context(), &RollbackCreateRequest{Region: region, FunctionName: "hello", Revision: 1}, testAccount)
+		requireCode(t, err, awserrors.ErrorInvalidParameterValueException)
+	}
+}

spinifex/domains/lambda/function/record.go

@@ -0,0 +1,131 @@
+// Package function holds the Lambda function record and the daemon-owned
+// metadata service that creates and updates it.
+package function
+
+import "time"
+
+// FormatVersion is the only record layout this build reads or writes.
+const FormatVersion = 1
+
+// Function states and the code copy states.
+const (
+	StatePending = "Pending"
+	StateActive  = "Active"
+	StateFailed  = "Failed"
+
+	CodeStoring = "storing"
+	CodeStored  = "stored"
+	CodeFailed  = "failed"
+)
+
+// Reason reported while a function waits for a runtime image to exist.
+const (
+	ReasonCodeCreating = "Creating"
+	ReasonCreating     = "The function is waiting for its runtime image."
+)
+
+// Code describes the stored copy of a function's code.
+type Code struct {
+	RevisionID string `json:"revisionId"`
+	SHA256     string `json:"sha256,omitempty"`
+	Size       int64  `json:"size,omitempty"`
+	State      string `json:"state"`
+}
+
+// Record is one function. Its KV key both binds the name and holds it, so name
+// reservation and the record are a single atomic write.
+type Record struct {
+	FormatVersion   int    `json:"formatVersion"`
+	FunctionID      string `json:"functionId"`
+	AccountID       string `json:"accountId"`
+	Region          string `json:"region"`
+	FunctionName    string `json:"functionName"`
+	Role            string `json:"role"`
+	Runtime         string `json:"runtime"`
+	Handler         string `json:"handler"`
+	Description     string `json:"description,omitempty"`
+	Timeout         int64  `json:"timeout"`
+	MemorySize      int64  `json:"memorySize"`
+	EnvCipher       string `json:"envCipher,omitempty"`
+	State           string `json:"state"`
+	StateReason     string `json:"stateReason,omitempty"`
+	StateReasonCode string `json:"stateReasonCode,omitempty"`
+	Code            Code   `json:"code"`
+	// ClaimExpiresAt bounds how long a record still storing its code holds the name.
+	ClaimExpiresAt time.Time `json:"claimExpiresAt"`
+	CreatedAt      time.Time `json:"createdAt"`
+	LastModified   time.Time `json:"lastModified"`
+}
+
+// KV bucket and key layout. The bucket is per account and owned by the daemon.
+const (
+	KVBucketAccountPrefix  = "lambda-account-"
+	KVBucketAccountHistory = 1
+	kvFunctionKeyPrefix    = "fn."
+)
+
+// KVAccountBucket returns the per-account JetStream KV bucket name.
+func KVAccountBucket(accountID string) string { return KVBucketAccountPrefix + accountID }
+
+// KVFunctionKey returns the key that binds a function name in a Region and
+// holds its record. JetStream is shared across Regions, so the Region is part
+// of the key.
+func KVFunctionKey(region, name string) string { return kvFunctionKeyPrefix + region + "." + name }
+
+// NATS subjects served by the daemon's metadata service.
+const (
+	SubjectCreate         = "lambda.function.create"
+	SubjectGet            = "lambda.function.get"
+	SubjectCodeStored     = "lambda.function.code-stored"
+	SubjectRollbackCreate = "lambda.function.rollback-create"
+)
+
+// CreateRequest carries the record the gateway built; the daemon owns the
+// state, claim and timestamps and overwrites whatever the request holds there.
+type CreateRequest struct {
+	Region string `json:"region"`
+	Record Record `json:"record"`
+}
+
+// CreateResponse returns the KV revision the later steps must present.
+type CreateResponse struct {
+	Revision uint64 `json:"revision"`
+}
+
+// GetRequest names the function.
+type GetRequest struct {
+	Region       string `json:"region"`
+	FunctionName string `json:"functionName"`
+}
+
+// GetResponse holds the record when Found.
+type GetResponse struct {
+	Found    bool   `json:"found"`
+	Record   Record `json:"record"`
+	Revision uint64 `json:"revision"`
+}
+
+// CodeStoredRequest records that the code copy landed.
+type CodeStoredRequest struct {
+	Region       string `json:"region"`
+	FunctionName string `json:"functionName"`
+	Revision     uint64 `json:"revision"`
+	SHA256       string `json:"sha256"`
+	Size         int64  `json:"size"`
+}
+
+// CodeStoredResponse returns the record as stored and its revision.
+type CodeStoredResponse struct {
+	Record   Record `json:"record"`
+	Revision uint64 `json:"revision"`
+}
+
+// RollbackCreateRequest withdraws a create whose own code write failed.
+type RollbackCreateRequest struct {
+	Region       string `json:"region"`
+	FunctionName string `json:"functionName"`
+	Revision     uint64 `json:"revision"`
+}
+
+// RollbackCreateResponse is empty: success means the name is free.
+type RollbackCreateResponse struct{}

spinifex/domains/sts/assume_role.go

@@ -254,12 +254,6 @@ const assumeRoleConditionKeySourceAccount = "aws:SourceAccount"
 // Deny statements, second pass scans all Allows. A single-pass loop would skip a later
 // Deny and silently grant access.
 func evalTrustPolicy(docJSON, callerARN string, principalSources []string) error {
-	doc, err := iamdomain.ValidateTrustPolicyDocument(docJSON)
-	if err != nil {
-		// Docs are validated at write time; reaching here implies on-disk corruption.
-		return fmt.Errorf("stored trust policy invalid: %w", err)
-	}
-
 	// sourceAccount is the caller ARN's own account — available whenever the
 	// caller is an authenticated HTTPS SigV4 identity, and not caller-asserted.
 	// It is empty on the IMDS path, where principalSource is synthesised and
@@ -268,6 +262,15 @@ func evalTrustPolicy(docJSON, callerARN string, principalSources []string) error
 	if caller, ok := parsePrincipalARN(callerARN); ok {
 		sourceAccount = caller.account
 	}
+	return evalTrustPolicyFor(docJSON, callerARN, sourceAccount, principalSources)
+}
+
+func evalTrustPolicyFor(docJSON, callerARN, sourceAccount string, principalSources []string) error {
+	doc, err := iamdomain.ValidateTrustPolicyDocument(docJSON)
+	if err != nil {
+		// Docs are validated at write time; reaching here implies on-disk corruption.
+		return fmt.Errorf("stored trust policy invalid: %w", err)
+	}
 
 	for _, stmt := range doc.Statement {
 		if stmt.Effect != iamdomain.PolicyEffectDeny {

spinifex/domains/sts/code_store_role.go

@@ -0,0 +1,50 @@
+package sts
+
+import (
+	"context"
+	"errors"
+	"log/slog"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/service/sts"
+	awserrors "github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/identifiers"
+)
+
+// lambdaServicePrincipal is the principal the Lambda code-store role trusts.
+const lambdaServicePrincipal = "lambda.amazonaws.com"
+
+// CodeStoreRoleName names the Region's Lambda code-store role in the system account.
+func CodeStoreRoleName(region string) string {
+	return "lambda-code-store-" + region
+}
+
+// CodeStoreRoleARN is the only role AssumeCodeStoreRole will issue.
+func CodeStoreRoleARN(region string) string {
+	return "arn:aws:iam::" + identifiers.GlobalAccountID + ":role/" + CodeStoreRoleName(region)
+}
+
+// AssumeCodeStoreRole mints a session for the Region's Lambda code-store role.
+// In-process only: it is not on STSService, NATS or HTTPS, and takes no role
+// ARN, so a caller can never use it to issue any other role.
+func (s *STSServiceImpl) AssumeCodeStoreRole(region, sessionName string) (*sts.AssumeRoleOutput, error) {
+	if region == "" || sessionName == "" {
+		return nil, errors.New(awserrors.ErrorMissingParameter)
+	}
+	if !roleSessionNameRegex.MatchString(sessionName) || !roleSessionNameRegex.MatchString(region) {
+		return nil, errors.New(awserrors.ErrorValidationError)
+	}
+
+	roleARN := CodeStoreRoleARN(region)
+	out, err := s.assumeRoleForCaller(context.Background(), "", lambdaServicePrincipal, roleARN, sessionName, "", 0)
+	if err != nil {
+		return nil, err
+	}
+
+	slog.Info("AssumeCodeStoreRole success",
+		"role_arn", roleARN,
+		"session_name", sessionName,
+		"expires_at", aws.TimeValue(out.Credentials.Expiration),
+	)
+	return out, nil
+}

spinifex/domains/sts/code_store_role_test.go

@@ -0,0 +1,77 @@
+package sts
+
+import (
+	"testing"
+
+	"github.com/aws/aws-sdk-go/aws"
+	iamdomain "github.com/mulgadc/spinifex/spinifex/domains/iam"
+	awserrors "github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/identifiers"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+const (
+	testCodeStoreRegion  = "ap-southeast-2"
+	lambdaTrustPolicyDoc = `{"Version":"2012-10-17","Statement":[{"Effect":"Allow","Principal":{"Service":"lambda.amazonaws.com"},"Action":"sts:AssumeRole"}]}`
+)
+
+func newCodeStoreSetup(t *testing.T, trust string) *STSServiceImpl {
+	t.Helper()
+	svc, nc := newTestSetup(t)
+	putTestAccount(t, nc, identifiers.GlobalAccountID, iamdomain.AccountStatusActive)
+	createRoleInAccount(t, svc, identifiers.GlobalAccountID, CodeStoreRoleName(testCodeStoreRegion), trust)
+	return svc
+}
+
+func TestAssumeCodeStoreRole_IssuesRegionalSystemRole(t *testing.T) {
+	svc := newCodeStoreSetup(t, lambdaTrustPolicyDoc)
+
+	out, err := svc.AssumeCodeStoreRole(testCodeStoreRegion, "node-1")
+	require.NoError(t, err)
+
+	assert.Equal(t, "arn:aws:sts::000000000000:assumed-role/lambda-code-store-ap-southeast-2/node-1",
+		aws.StringValue(out.AssumedRoleUser.Arn))
+	stored, err := svc.LookupSessionCredential(aws.StringValue(out.Credentials.AccessKeyId))
+	require.NoError(t, err)
+	assert.Equal(t, identifiers.GlobalAccountID, stored.AccountID)
+}
+
+// The entry point asserts only lambda.amazonaws.com, so a role whose trust names
+// another principal is refused even though its name is the code-store name.
+func TestAssumeCodeStoreRole_RefusesOtherTrust(t *testing.T) {
+	svc := newCodeStoreSetup(t, trustPolicyAllowingEC2Service())
+
+	_, err := svc.AssumeCodeStoreRole(testCodeStoreRegion, "node-1")
+	assertErrorCode(t, err, awserrors.ErrorAccessDenied)
+}
+
+// No Region has a role yet, so another Region's name resolves to nothing.
+func TestAssumeCodeStoreRole_OtherRegionHasNoRole(t *testing.T) {
+	svc := newCodeStoreSetup(t, lambdaTrustPolicyDoc)
+
+	_, err := svc.AssumeCodeStoreRole("us-east-1", "node-1")
+	assertErrorCode(t, err, awserrors.ErrorAccessDenied)
+}
+
+// An HTTPS caller is never attributed lambda.amazonaws.com, so even a system
+// account principal cannot assume the code-store role over AssumeRole.
+func TestAssumeCodeStoreRole_HTTPSAssumeRoleCannotMatch(t *testing.T) {
+	svc := newCodeStoreSetup(t, lambdaTrustPolicyDoc)
+
+	caller := "arn:aws:iam::000000000000:user/operator"
+	_, err := svc.AssumeRole(identifiers.GlobalAccountID, caller, "AIDAOPERATOR",
+		basicAssumeRoleInput(CodeStoreRoleARN(testCodeStoreRegion), "s1"))
+	assertErrorCode(t, err, awserrors.ErrorAccessDenied)
+}
+
+func TestAssumeCodeStoreRole_ValidatesInputs(t *testing.T) {
+	svc := newCodeStoreSetup(t, lambdaTrustPolicyDoc)
+
+	_, err := svc.AssumeCodeStoreRole("", "node-1")
+	assertErrorCode(t, err, awserrors.ErrorMissingParameter)
+	_, err = svc.AssumeCodeStoreRole("ap/southeast", "node-1")
+	assertErrorCode(t, err, awserrors.ErrorValidationError)
+	_, err = svc.AssumeCodeStoreRole(testCodeStoreRegion, "bad name")
+	assertErrorCode(t, err, awserrors.ErrorValidationError)
+}

spinifex/domains/sts/service_trust.go

@@ -0,0 +1,37 @@
+package sts
+
+import (
+	"errors"
+
+	"github.com/aws/aws-sdk-go/aws"
+	awserrors "github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+)
+
+// ServiceTrusts reports whether trustDoc lets service assume the role on behalf
+// of sourceAccount, with the same deny-first evaluation AssumeRole uses. A nil
+// error means trusted; a refusal is AccessDenied.
+func ServiceTrusts(trustDoc, service, sourceAccount string) error {
+	return evalTrustPolicyFor(trustDoc, "", sourceAccount, []string{service})
+}
+
+// RoleTrusts evaluates a role's stored trust policy for service acting for an
+// account: false is a refusal (or no such role), an error an outage.
+func RoleTrusts(svc RoleGetter, service string) func(accountID, roleARN string) (bool, error) {
+	return func(accountID, roleARN string) (bool, error) {
+		_, role, err := ResolveRoleByARN(svc, roleARN)
+		if errors.Is(err, ErrRoleUnresolved) {
+			return false, nil
+		}
+		if err != nil {
+			return false, err
+		}
+		err = ServiceTrusts(aws.StringValue(role.AssumeRolePolicyDocument), service, accountID)
+		if err == nil {
+			return true, nil
+		}
+		if code, ok := awserrors.ResolveErrorCode(err); ok && code == awserrors.ErrorAccessDenied {
+			return false, nil
+		}
+		return false, err
+	}
+}

spinifex/foundation/aws/arn/lambda.go

@@ -0,0 +1,8 @@
+package arn
+
+import "fmt"
+
+// FormatLambdaFunction builds arn:aws:lambda:<region>:<account>:function:<name>.
+func FormatLambdaFunction(region, accountID, name string) string {
+	return fmt.Sprintf("arn:aws:lambda:%s:%s:function:%s", region, accountID, name)
+}

spinifex/foundation/aws/errors/awserrors.go

@@ -620,6 +620,9 @@ var (
 	ErrorMissingRequiredParameterException = "MissingRequiredParameterException"
 	ErrorSerializationException            = "SerializationException"
 	ErrorUnknownOperationException         = "UnknownOperationException"
+	// Lambda wire codes that no other service shares.
+	ErrorResourceConflictException = "ResourceConflictException"
+	ErrorServiceException          = "ServiceException"
 )
 
 // ValidErrorCode returns the error code if it exists in ErrorLookup,
@@ -1452,6 +1455,8 @@ var ErrorLookup = map[string]ErrorMessage{
 	ErrorMissingRequiredParameterException: {HTTPCode: 400, Message: "The request is missing a required parameter."},
 	ErrorSerializationException:            {HTTPCode: 400, Message: "The request body could not be deserialized."},
 	ErrorUnknownOperationException:         {HTTPCode: 400, Message: "The requested operation is not recognized."},
+	ErrorResourceConflictException:         {HTTPCode: 409, Message: "The resource already exists or is in a state that does not allow this operation."},
+	ErrorServiceException:                  {HTTPCode: 500, Message: "The Lambda service encountered an internal error."},
 
 	// Route 53.
 	ErrorNoSuchHostedZone:          {HTTPCode: 404, Message: "No hosted zone exists with the ID that you specified."},

spinifex/ingress/aws/pipeline/gwhelpers_test.go

@@ -781,6 +781,10 @@ func (svc *echoIAMService) UpdateAccessKey(accountID string, input *iam.UpdateAc
 	return echoIAMCall[iam.UpdateAccessKeyInput, iam.UpdateAccessKeyOutput](svc, accountID, input)
 }
 
+func (svc *echoIAMService) UpdateUser(accountID string, input *iam.UpdateUserInput) (*iam.UpdateUserOutput, error) {
+	return echoIAMCall[iam.UpdateUserInput, iam.UpdateUserOutput](svc, accountID, input)
+}
+
 func (svc *echoIAMService) UpdateAssumeRolePolicy(accountID string, input *iam.UpdateAssumeRolePolicyInput) (*iam.UpdateAssumeRolePolicyOutput, error) {
 	return echoIAMCall[iam.UpdateAssumeRolePolicyInput, iam.UpdateAssumeRolePolicyOutput](svc, accountID, input)
 }

spinifex/ingress/aws/pipeline/lambda_envelope_test.go

@@ -0,0 +1,34 @@
+package pipeline
+
+import (
+	"bytes"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+	"time"
+
+	"github.com/mulgadc/spinifex/internal/testkit/gwfix"
+	lambdaawsapi "github.com/mulgadc/spinifex/spinifex/domains/lambda/awsapi"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+// A refused CreateFunction leaves the real ingress in the REST-JSON shape the
+// Lambda SDK decodes: the code in X-Amzn-Errortype, Type and message in the body.
+func TestLambdaCreateFunctionErrorUsesRESTJSONEnvelope(t *testing.T) {
+	_, app := dispatchSeamApp(t, allowAllECRDocs(), lambdaawsapi.NewRegistration(lambdaawsapi.Deps{}))
+
+	body := []byte(`{"FunctionName":"hello","TenancyConfig":{}}`)
+	req := httptest.NewRequest(http.MethodPost, "/2015-03-31/functions", bytes.NewReader(body))
+	req.Host = "localhost:9999"
+	gwfix.SignRequestAs(t, req, body, gwfix.AccessKey, gwfix.SecretKey, lambdaawsapi.ServiceName, time.Now().UTC())
+	resp := doRequest(app, req)
+
+	assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
+	assert.Equal(t, "application/json", resp.Header.Get("Content-Type"))
+	assert.Equal(t, "InvalidParameterValueException", resp.Header.Get("X-Amzn-Errortype"))
+	assert.NotEmpty(t, resp.Header.Get("X-Amzn-Requestid"))
+	env := decodeJSONError(t, resp)
+	require.NotEmpty(t, env.Message)
+	assert.Empty(t, env.Type, "REST-JSON carries the code in the header, not __type")
+}

spinifex/runtime/daemon/daemon.go

@@ -67,6 +67,7 @@ import (
 	ekscluster "github.com/mulgadc/spinifex/spinifex/domains/eks/cluster"
 	elbv2domain "github.com/mulgadc/spinifex/spinifex/domains/elbv2"
 	iamdomain "github.com/mulgadc/spinifex/spinifex/domains/iam"
+	lambdafunction "github.com/mulgadc/spinifex/spinifex/domains/lambda/function"
 	"github.com/mulgadc/spinifex/spinifex/domains/network/external"
 	"github.com/mulgadc/spinifex/spinifex/domains/network/external/dhcp"
 	"github.com/mulgadc/spinifex/spinifex/domains/network/external/exonet"
@@ -186,6 +187,7 @@ type Daemon struct {
 	ochreAppliance        *ochrevector.Appliance
 	ochreBackupService    *ochrevector.BackupService
 	ecrMetaService        *ecr.MetaServiceImpl
+	lambdaMetaService     *lambdafunction.MetaService
 	routeTableService     *ec2routetable.RouteTableServiceImpl
 	natGatewayService     *ec2natgw.NatGatewayServiceImpl
 	externalIPAM          *ec2vpc.ExternalIPAM
@@ -1308,6 +1310,17 @@ func (d *Daemon) subscribeAll() error {
 		)
 	}
 
+	// Lambda gateway → daemon subscriptions. The daemon owns the per-account
+	// JetStream KV function records; code bytes never traverse these subjects.
+	if d.lambdaMetaService != nil {
+		subs = append(subs,
+			natsSub{lambdafunction.SubjectCreate, handleNATSRequest(d.node, d.lambdaMetaService.Create), "spinifex-workers"},
+			natsSub{lambdafunction.SubjectGet, handleNATSRequest(d.node, d.lambdaMetaService.Get), "spinifex-workers"},
+			natsSub{lambdafunction.SubjectCodeStored, handleNATSRequest(d.node, d.lambdaMetaService.CodeStored), "spinifex-workers"},
+			natsSub{lambdafunction.SubjectRollbackCreate, handleNATSRequest(d.node, d.lambdaMetaService.RollbackCreate), "spinifex-workers"},
+		)
+	}
+
 	// EIP handlers are always registered: without external IPAM d.eipService is
 	// the disabled stub, so reads return empty lists and mutations a clean
 	// UnsupportedOperation instead of a NATS timeout.
@@ -2408,6 +2421,7 @@ func (d *Daemon) startCluster() error {
 		slog.Warn("ECR metadata service disabled: JetStream unavailable", "err", jsErr)
 	} else {
 		d.ecrMetaService = ecr.NewKVMetaService(js)
+		d.lambdaMetaService = lambdafunction.NewMetaService(js)
 	}
 
 	if err := d.eksService.SpawnRegisteredReconcilers(); err != nil {

spinifex/runtime/daemon/daemon_sqs_worker_test.go

@@ -258,7 +258,7 @@ type fakeRoleIAM struct {
 
 func (f *fakeRoleIAM) GetRole(_ string, in *awsiam.GetRoleInput) (*awsiam.GetRoleOutput, error) {
 	if f.trust == "" {
-		return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+		return nil, awserrors.Errorf(awserrors.ErrorIAMNoSuchEntity, "The role with name %s cannot be found.", aws.StringValue(in.RoleName))
 	}
 	return &awsiam.GetRoleOutput{Role: &awsiam.Role{RoleName: in.RoleName, AssumeRolePolicyDocument: aws.String(f.trust)}}, nil
 }
@@ -267,7 +267,7 @@ func (f *fakeRoleIAM) CreateRole(_ string, in *awsiam.CreateRoleInput) (*awsiam.
 	f.writes = append(f.writes, "CreateRole")
 	if f.createdTrust != "" {
 		f.trust = f.createdTrust
-		return nil, errors.New(awserrors.ErrorIAMEntityAlreadyExists)
+		return nil, awserrors.Errorf(awserrors.ErrorIAMEntityAlreadyExists, "Role with name %s already exists.", aws.StringValue(in.RoleName))
 	}
 	f.trust = aws.StringValue(in.AssumeRolePolicyDocument)
 	return &awsiam.CreateRoleOutput{}, nil
@@ -279,9 +279,9 @@ func (f *fakeRoleIAM) PutRolePolicy(_ string, in *awsiam.PutRolePolicyInput) (*a
 	return &awsiam.PutRolePolicyOutput{}, nil
 }
 
-func (f *fakeRoleIAM) GetInstanceProfile(string, *awsiam.GetInstanceProfileInput) (*awsiam.GetInstanceProfileOutput, error) {
+func (f *fakeRoleIAM) GetInstanceProfile(_ string, in *awsiam.GetInstanceProfileInput) (*awsiam.GetInstanceProfileOutput, error) {
 	if f.profile == nil {
-		return nil, errors.New(awserrors.ErrorIAMNoSuchEntity)
+		return nil, awserrors.Errorf(awserrors.ErrorIAMNoSuchEntity, "Instance Profile %s cannot be found.", aws.StringValue(in.InstanceProfileName))
 	}
 	p := *f.profile
 	p.Roles = slices.Clone(f.profile.Roles)

spinifex/runtime/daemon/sqs_worker_deps.go

@@ -96,13 +96,13 @@ func ensureSQSRoleTrust(svc iamdomain.SystemInstanceRoleEnsurer, r sqsRole) erro
 	acct, name := awsidentifiers.GlobalAccountID, aws.String(r.name)
 	role, err := svc.GetRole(acct, &awsiam.GetRoleInput{RoleName: name})
 	if err != nil {
-		if err.Error() != awserrors.ErrorIAMNoSuchEntity {
+		if code, _ := awserrors.ResolveErrorCode(err); code != awserrors.ErrorIAMNoSuchEntity {
 			return fmt.Errorf("%s: read role: %w", r.label, err)
 		}
 		_, cerr := svc.CreateRole(acct, &awsiam.CreateRoleInput{RoleName: name,
 			AssumeRolePolicyDocument: aws.String(iamdomain.EC2InstanceTrustPolicy),
 			Description:              aws.String(r.description)})
-		if cerr != nil && cerr.Error() != awserrors.ErrorIAMEntityAlreadyExists {
+		if code, _ := awserrors.ResolveErrorCode(cerr); cerr != nil && code != awserrors.ErrorIAMEntityAlreadyExists {
 			return fmt.Errorf("%s: create role: %w", r.label, cerr)
 		}
 		if role, err = svc.GetRole(acct, &awsiam.GetRoleInput{RoleName: name}); err != nil {
@@ -132,11 +132,11 @@ func ensureSQSRoleInstanceProfile(svc iamdomain.SystemInstanceRoleEnsurer, r sqs
 	}
 	prof, err := get()
 	if err != nil {
-		if err.Error() != awserrors.ErrorIAMNoSuchEntity {
+		if code, _ := awserrors.ResolveErrorCode(err); code != awserrors.ErrorIAMNoSuchEntity {
 			return "", fmt.Errorf("%s: read instance profile: %w", r.label, err)
 		}
-		if _, cerr := svc.CreateInstanceProfile(acct, &awsiam.CreateInstanceProfileInput{InstanceProfileName: name}); cerr != nil &&
-			cerr.Error() != awserrors.ErrorIAMEntityAlreadyExists {
+		_, cerr := svc.CreateInstanceProfile(acct, &awsiam.CreateInstanceProfileInput{InstanceProfileName: name})
+		if code, _ := awserrors.ResolveErrorCode(cerr); cerr != nil && code != awserrors.ErrorIAMEntityAlreadyExists {
 			return "", fmt.Errorf("%s: create instance profile: %w", r.label, cerr)
 		}
 		if prof, err = get(); err != nil {
@@ -147,8 +147,8 @@ func ensureSQSRoleInstanceProfile(svc iamdomain.SystemInstanceRoleEnsurer, r sqs
 		return "", fmt.Errorf("%s: instance profile %s carries a role other than %s", r.label, r.name, r.name)
 	}
 	if len(prof.Roles) == 0 {
-		if _, aerr := svc.AddRoleToInstanceProfile(acct, &awsiam.AddRoleToInstanceProfileInput{
-			InstanceProfileName: name, RoleName: name}); aerr != nil && aerr.Error() != awserrors.ErrorIAMLimitExceeded {
+		_, aerr := svc.AddRoleToInstanceProfile(acct, &awsiam.AddRoleToInstanceProfileInput{InstanceProfileName: name, RoleName: name})
+		if code, _ := awserrors.ResolveErrorCode(aerr); aerr != nil && code != awserrors.ErrorIAMLimitExceeded {
 			return "", fmt.Errorf("%s: add role to instance profile: %w", r.label, aerr)
 		}
 		if prof, err = get(); err != nil {

spinifex/runtime/roles/awsgw/awsgw.go

@@ -41,6 +41,8 @@ import (
 	elbv2awsapi "github.com/mulgadc/spinifex/spinifex/domains/elbv2/awsapi"
 	iamdomain "github.com/mulgadc/spinifex/spinifex/domains/iam"
 	iamawsapi "github.com/mulgadc/spinifex/spinifex/domains/iam/awsapi"
+	lambdaawsapi "github.com/mulgadc/spinifex/spinifex/domains/lambda/awsapi"
+	lambdafunction "github.com/mulgadc/spinifex/spinifex/domains/lambda/function"
 	"github.com/mulgadc/spinifex/spinifex/domains/network/reconcile"
 	"github.com/mulgadc/spinifex/spinifex/domains/ochre"
 	ochreawsapi "github.com/mulgadc/spinifex/spinifex/domains/ochre/awsapi"
@@ -365,6 +367,39 @@ func launchService(config *config.ClusterConfig) error {
 		ecrRegistry, activeAccountIDs(iamService), ecrregistry.DefaultLifecycleSweepInterval)
 	go lifecycleSweeper.Run(janitorCtx)
 
+	// Lambda code copies live in a Regional system bucket reached through a
+	// scoped role session. Nothing is provisioned until the store is first used.
+	lambdaCodeStore, err := newLambdaCodeStore(codeStoreWiring{
+		Region:          nodeConfig.Region,
+		Node:            config.Node,
+		Endpoint:        netaddr.DialTarget(nodeConfig.Predastore.Host),
+		PresignEndpoint: lambdaPresignEndpoint(nodeConfig.Predastore.Host, nodeConfig.AdvertiseIP),
+		SigningRegion:   nodeConfig.Predastore.Region,
+		RootAccessKey:   nodeConfig.Predastore.AccessKey,
+		RootSecretKey:   nodeConfig.Predastore.SecretKey,
+	}, iamService, stsService)
+	if err != nil {
+		return err
+	}
+	lambdaKey, err := masterkey.New(masterKey)
+	if err != nil {
+		return fmt.Errorf("lambda environment key: %w", err)
+	}
+	// Built but not routed: Lambda stays out of the public router until its runtime image exists.
+	_ = lambdaawsapi.NewRegistration(lambdaawsapi.Deps{
+		Meta: lambdafunction.NewNATSClient(natsConn),
+		Codes: func(ctx context.Context) (lambdaawsapi.CodeStore, error) {
+			store, err := lambdaCodeStore.Store(ctx)
+			if err != nil {
+				return nil, err
+			}
+			return store, nil
+		},
+		Roles:  iamdomain.NewRoleResolver(iamService),
+		Trusts: lambdaRoleTrusts(iamService),
+		AEAD:   lambdaKey.AEAD,
+	})
+
 	// ECR auth bridge: load (or first-run create) the ES256 signing key from the
 	// cluster-replicated awsgw-keys KV bucket, then build the token issuer
 	// (GetAuthorizationToken) and verifier (/v2 Authorization). The bridge reads

spinifex/runtime/roles/awsgw/lambda_code_store.go

@@ -0,0 +1,217 @@
+package awsgw
+
+import (
+	"context"
+	"errors"
+	"fmt"
+	"net"
+	"net/http"
+	"time"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/aws/awserr"
+	"github.com/aws/aws-sdk-go/aws/credentials"
+	"github.com/aws/aws-sdk-go/aws/session"
+	"github.com/aws/aws-sdk-go/service/iam"
+	"github.com/aws/aws-sdk-go/service/s3"
+	"github.com/aws/aws-sdk-go/service/sts"
+	"github.com/mulgadc/spinifex/spinifex/domains/lambda/codestore"
+	stsdomain "github.com/mulgadc/spinifex/spinifex/domains/sts"
+	awserrors "github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/identifiers"
+)
+
+// codeStoreRoleIAM is the IAM surface the code-store role adapter uses.
+type codeStoreRoleIAM interface {
+	CreateRole(accountID string, input *iam.CreateRoleInput) (*iam.CreateRoleOutput, error)
+	GetRole(accountID string, input *iam.GetRoleInput) (*iam.GetRoleOutput, error)
+	ListRoleTags(accountID string, input *iam.ListRoleTagsInput) (*iam.ListRoleTagsOutput, error)
+	ListRolePolicies(accountID string, input *iam.ListRolePoliciesInput) (*iam.ListRolePoliciesOutput, error)
+	ListAttachedRolePolicies(accountID string, input *iam.ListAttachedRolePoliciesInput) (*iam.ListAttachedRolePoliciesOutput, error)
+	PutRolePolicy(accountID string, input *iam.PutRolePolicyInput) (*iam.PutRolePolicyOutput, error)
+}
+
+// codeStoreRole binds IAM to the one system-account code-store role, so the
+// Lambda domain never holds a general IAM client.
+type codeStoreRole struct {
+	iam  codeStoreRoleIAM
+	name string
+}
+
+var _ codestore.RoleAdmin = (*codeStoreRole)(nil)
+
+func (r *codeStoreRole) Create(trust string, tags map[string]string) error {
+	in := &iam.CreateRoleInput{
+		RoleName:                 aws.String(r.name),
+		AssumeRolePolicyDocument: aws.String(trust),
+		Description:              aws.String("Spinifex-managed Lambda code-store role"),
+	}
+	for k, v := range tags {
+		in.Tags = append(in.Tags, &iam.Tag{Key: aws.String(k), Value: aws.String(v)})
+	}
+	_, err := r.iam.CreateRole(identifiers.GlobalAccountID, in)
+	if code, _ := awserrors.ResolveErrorCode(err); code == awserrors.ErrorIAMEntityAlreadyExists {
+		return codestore.ErrExists
+	}
+	return err
+}
+
+func (r *codeStoreRole) Describe() (*codestore.RoleState, error) {
+	acct, name := identifiers.GlobalAccountID, aws.String(r.name)
+	got, err := r.iam.GetRole(acct, &iam.GetRoleInput{RoleName: name})
+	if err != nil {
+		if code, _ := awserrors.ResolveErrorCode(err); code == awserrors.ErrorIAMNoSuchEntity {
+			return nil, codestore.ErrNotFound
+		}
+		return nil, err
+	}
+	tags, err := r.iam.ListRoleTags(acct, &iam.ListRoleTagsInput{RoleName: name})
+	if err != nil {
+		return nil, err
+	}
+	inline, err := r.iam.ListRolePolicies(acct, &iam.ListRolePoliciesInput{RoleName: name})
+	if err != nil {
+		return nil, err
+	}
+	attached, err := r.iam.ListAttachedRolePolicies(acct, &iam.ListAttachedRolePoliciesInput{RoleName: name})
+	if err != nil {
+		return nil, err
+	}
+	if aws.BoolValue(tags.IsTruncated) || aws.BoolValue(inline.IsTruncated) || aws.BoolValue(attached.IsTruncated) {
+		return nil, errors.New("code-store role listing truncated")
+	}
+	st := &codestore.RoleState{
+		TrustPolicy:      aws.StringValue(got.Role.AssumeRolePolicyDocument),
+		Tags:             map[string]string{},
+		InlinePolicies:   aws.StringValueSlice(inline.PolicyNames),
+		AttachedPolicies: len(attached.AttachedPolicies),
+	}
+	for _, t := range tags.Tags {
+		st.Tags[aws.StringValue(t.Key)] = aws.StringValue(t.Value)
+	}
+	return st, nil
+}
+
+func (r *codeStoreRole) PutPolicy(name, doc string) error {
+	_, err := r.iam.PutRolePolicy(identifiers.GlobalAccountID, &iam.PutRolePolicyInput{
+		RoleName:       aws.String(r.name),
+		PolicyName:     aws.String(name),
+		PolicyDocument: aws.String(doc),
+	})
+	return err
+}
+
+// codeStoreBucket binds a system-root S3 client to the one code bucket. The
+// client stays in this adapter; the Lambda domain sees only Create and Tags.
+type codeStoreBucket struct {
+	s3   *s3.S3
+	name string
+}
+
+var _ codestore.BucketAdmin = (*codeStoreBucket)(nil)
+
+func (b *codeStoreBucket) Create(ctx context.Context, tags map[string]string) error {
+	_, err := b.s3.CreateBucketWithContext(ctx, &s3.CreateBucketInput{Bucket: aws.String(b.name)})
+	if err != nil {
+		if ae, ok := errors.AsType[awserr.Error](err); ok {
+			switch ae.Code() {
+			case s3.ErrCodeBucketAlreadyOwnedByYou:
+				return codestore.ErrExists
+			case s3.ErrCodeBucketAlreadyExists:
+				return codestore.ErrOwnedElsewhere
+			}
+		}
+		return err
+	}
+	set := &s3.Tagging{}
+	for k, v := range tags {
+		set.TagSet = append(set.TagSet, &s3.Tag{Key: aws.String(k), Value: aws.String(v)})
+	}
+	if _, err := b.s3.PutBucketTaggingWithContext(ctx, &s3.PutBucketTaggingInput{
+		Bucket: aws.String(b.name), Tagging: set,
+	}); err != nil {
+		return fmt.Errorf("tag new code bucket: %w", err)
+	}
+	return nil
+}
+
+func (b *codeStoreBucket) Tags(ctx context.Context) (map[string]string, error) {
+	out, err := b.s3.GetBucketTaggingWithContext(ctx, &s3.GetBucketTaggingInput{Bucket: aws.String(b.name)})
+	if err != nil {
+		if ae, ok := errors.AsType[awserr.Error](err); ok && ae.Code() == "NoSuchTagSet" {
+			return map[string]string{}, nil
+		}
+		return nil, err
+	}
+	tags := map[string]string{}
+	for _, t := range out.TagSet {
+		tags[aws.StringValue(t.Key)] = aws.StringValue(t.Value)
+	}
+	return tags, nil
+}
+
+// codeStoreAssumer is the in-process STS entry point the store's session uses.
+type codeStoreAssumer interface {
+	AssumeCodeStoreRole(region, sessionName string) (*sts.AssumeRoleOutput, error)
+}
+
+// codeStoreWiring is what the gateway composition root supplies.
+type codeStoreWiring struct {
+	Region        string
+	Node          string
+	Endpoint      string
+	SigningRegion string
+	RootAccessKey string
+	RootSecretKey string
+	// PresignEndpoint is the off-host Predastore URL download links name.
+	PresignEndpoint string
+}
+
+// newLambdaCodeStore composes the code store. The root client and root keys stay
+// here; Lambda gets the bound admins for provisioning and a scoped session.
+func newLambdaCodeStore(w codeStoreWiring, roles codeStoreRoleIAM, assumer codeStoreAssumer) (*codestore.Manager, error) {
+	sess, err := session.NewSession(&aws.Config{
+		Endpoint:         aws.String(w.Endpoint),
+		Region:           aws.String(w.SigningRegion),
+		Credentials:      credentials.NewStaticCredentials(w.RootAccessKey, w.RootSecretKey, ""),
+		S3ForcePathStyle: aws.Bool(true),
+		HTTPClient:       &http.Client{Timeout: 30 * time.Second},
+	})
+	if err != nil {
+		return nil, fmt.Errorf("lambda code store admin session: %w", err)
+	}
+	role := &codeStoreRole{iam: roles, name: stsdomain.CodeStoreRoleName(w.Region)}
+	bucket := &codeStoreBucket{s3: s3.New(sess), name: codestore.BucketName(w.Region)}
+	sessionName := "awsgw-" + w.Node
+
+	provision := func(ctx context.Context) error {
+		return codestore.Provision(ctx, w.Region, role, bucket)
+	}
+	open := func() (*codestore.Store, error) {
+		return codestore.Open(codestore.OpenConfig{
+			Region:          w.Region,
+			Endpoint:        w.Endpoint,
+			PresignEndpoint: w.PresignEndpoint,
+			SigningRegion:   w.SigningRegion,
+			Assume:          func() (*sts.AssumeRoleOutput, error) { return assumer.AssumeCodeStoreRole(w.Region, sessionName) },
+		})
+	}
+	return codestore.NewManager(provision, open), nil
+}
+
+// lambdaPresignEndpoint is the Predastore address an off-host client dials.
+// Config loading turns a wildcard listener into loopback, so loopback and
+// wildcard hosts use the advertise IP; empty when no off-host address is known.
+func lambdaPresignEndpoint(predastoreHost, advertiseIP string) string {
+	host, port, err := net.SplitHostPort(predastoreHost)
+	if err != nil {
+		return ""
+	}
+	if ip := net.ParseIP(host); host == "" || host == "localhost" || (ip != nil && (ip.IsLoopback() || ip.IsUnspecified())) {
+		host = advertiseIP
+	}
+	if host == "" {
+		return ""
+	}
+	return "https://" + net.JoinHostPort(host, port)
+}

spinifex/runtime/roles/awsgw/lambda_code_store_test.go

@@ -0,0 +1,197 @@
+package awsgw
+
+import (
+	"context"
+	"encoding/json"
+	"fmt"
+	"io"
+	"net/http"
+	"net/http/httptest"
+	"strconv"
+	"testing"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/aws/credentials"
+	"github.com/aws/aws-sdk-go/aws/session"
+	"github.com/aws/aws-sdk-go/service/iam"
+	"github.com/aws/aws-sdk-go/service/s3"
+	testutil "github.com/mulgadc/spinifex/internal/testkit"
+	iamdomain "github.com/mulgadc/spinifex/spinifex/domains/iam"
+	"github.com/mulgadc/spinifex/spinifex/domains/lambda/codestore"
+	stsdomain "github.com/mulgadc/spinifex/spinifex/domains/sts"
+	awserrors "github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/identifiers"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+const codeStoreTestRegion = "ap-southeast-2"
+
+type nopJWKS struct{}
+
+func (nopJWKS) LookupClusterJWKS(context.Context, string, string) ([]byte, bool, error) {
+	return nil, false, nil
+}
+
+// fakeCodeBucket stands in for Predastore so the role path runs on real IAM.
+type fakeCodeBucket struct{ tags map[string]string }
+
+func (f *fakeCodeBucket) Create(_ context.Context, tags map[string]string) error {
+	if f.tags != nil {
+		return codestore.ErrExists
+	}
+	f.tags = tags
+	return nil
+}
+
+func (f *fakeCodeBucket) Tags(context.Context) (map[string]string, error) { return f.tags, nil }
+
+func newCodeStoreIAM(t *testing.T) (*iamdomain.IAMServiceImpl, *stsdomain.STSServiceImpl) {
+	t.Helper()
+	_, nc, js := testutil.StartTestJetStream(t)
+	key, err := iamdomain.GenerateMasterKey()
+	require.NoError(t, err)
+	iamSvc, err := iamdomain.NewIAMServiceImpl(t.Context(), nc, key)
+	require.NoError(t, err)
+	stsSvc, err := stsdomain.NewSTSServiceImpl(t.Context(), nc, iamSvc, key, nopJWKS{})
+	require.NoError(t, err)
+
+	kv, err := js.KeyValue(t.Context(), iamdomain.KVBucketAccounts)
+	require.NoError(t, err)
+	acct, err := json.Marshal(iamdomain.Account{AccountID: identifiers.GlobalAccountID, AccountName: "system", Status: iamdomain.AccountStatusActive})
+	require.NoError(t, err)
+	_, err = kv.Put(t.Context(), identifiers.GlobalAccountID, acct)
+	require.NoError(t, err)
+	return iamSvc, stsSvc
+}
+
+// Provisioning through the real IAM adapter yields a role the in-process STS
+// entry point can assume, so the role name, trust and tags agree end to end.
+func TestLambdaCodeStoreRole_ProvisionThenAssume(t *testing.T) {
+	iamSvc, stsSvc := newCodeStoreIAM(t)
+	role := &codeStoreRole{iam: iamSvc, name: stsdomain.CodeStoreRoleName(codeStoreTestRegion)}
+
+	require.NoError(t, codestore.Provision(t.Context(), codeStoreTestRegion, role, &fakeCodeBucket{}))
+
+	st, err := role.Describe()
+	require.NoError(t, err)
+	assert.Equal(t, codestore.OwnerTagValue, st.Tags[codestore.OwnerTagKey])
+	assert.Equal(t, []string{codestore.PolicyName}, st.InlinePolicies)
+	_, err = stsSvc.AssumeCodeStoreRole(codeStoreTestRegion, "awsgw-node1")
+	require.NoError(t, err)
+}
+
+func TestLambdaCodeStoreRole_RetriesOwnCrashAndRefusesUntagged(t *testing.T) {
+	iamSvc, _ := newCodeStoreIAM(t)
+	name := stsdomain.CodeStoreRoleName(codeStoreTestRegion)
+	role := &codeStoreRole{iam: iamSvc, name: name}
+
+	// Lambda's own crash after CreateRole: tagged role, no inline policy.
+	require.NoError(t, role.Create(codestore.TrustPolicy, map[string]string{codestore.OwnerTagKey: codestore.OwnerTagValue}))
+	require.NoError(t, codestore.Provision(t.Context(), codeStoreTestRegion, role, &fakeCodeBucket{}))
+
+	other := &codeStoreRole{iam: iamSvc, name: stsdomain.CodeStoreRoleName("us-east-1")}
+	_, err := iamSvc.CreateRole(identifiers.GlobalAccountID, &iam.CreateRoleInput{
+		RoleName: aws.String(other.name), AssumeRolePolicyDocument: aws.String(codestore.TrustPolicy)})
+	require.NoError(t, err)
+	err = codestore.Provision(t.Context(), "us-east-1", other, &fakeCodeBucket{})
+	require.ErrorIs(t, err, codestore.ErrNotOwned)
+	policies, err := iamSvc.ListRolePolicies(identifiers.GlobalAccountID, &iam.ListRolePoliciesInput{RoleName: aws.String(other.name)})
+	require.NoError(t, err)
+	assert.Empty(t, policies.PolicyNames, "no policy written to an untagged role")
+}
+
+// s3Responder answers the bucket admin's requests with fixed S3 replies.
+func s3Responder(t *testing.T, create, tagging int, createCode string) (*codeStoreBucket, *[]string) {
+	t.Helper()
+	var calls []string
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		_, _ = io.Copy(io.Discard, r.Body)
+		_, isTagging := r.URL.Query()["tagging"]
+		calls = append(calls, r.Method+" tagging="+strconv.FormatBool(isTagging))
+		switch {
+		case r.Method == http.MethodPut && !isTagging:
+			w.WriteHeader(create)
+			if createCode != "" {
+				fmt.Fprintf(w, "<Error><Code>%s</Code></Error>", createCode)
+			}
+		case r.Method == http.MethodGet && isTagging:
+			w.WriteHeader(tagging)
+			if tagging == http.StatusNotFound {
+				_, _ = w.Write([]byte("<Error><Code>NoSuchTagSet</Code></Error>"))
+				return
+			}
+			_, _ = w.Write([]byte(`<Tagging><TagSet><Tag><Key>spinifex:owner</Key><Value>lambda-code-store</Value></Tag></TagSet></Tagging>`))
+		default:
+			w.WriteHeader(tagging)
+		}
+	}))
+	t.Cleanup(srv.Close)
+	sess := session.Must(session.NewSession(&aws.Config{
+		Endpoint: aws.String(srv.URL), Region: aws.String(codeStoreTestRegion), S3ForcePathStyle: aws.Bool(true),
+		Credentials: credentials.NewStaticCredentials("AKIA", "secret", ""), MaxRetries: aws.Int(0),
+	}))
+	return &codeStoreBucket{s3: s3.New(sess), name: codestore.BucketName(codeStoreTestRegion)}, &calls
+}
+
+func TestLambdaCodeStoreBucket_MapsCreateOutcomes(t *testing.T) {
+	ctx := t.Context()
+
+	b, calls := s3Responder(t, http.StatusOK, http.StatusOK, "")
+	require.NoError(t, b.Create(ctx, map[string]string{"k": "v"}))
+	assert.Equal(t, []string{"PUT tagging=false", "PUT tagging=true"}, *calls, "a new bucket is tagged")
+
+	b, calls = s3Responder(t, http.StatusConflict, http.StatusOK, "BucketAlreadyOwnedByYou")
+	require.ErrorIs(t, b.Create(ctx, nil), codestore.ErrExists)
+	assert.Len(t, *calls, 1, "an existing bucket is never tagged")
+
+	b, _ = s3Responder(t, http.StatusConflict, http.StatusOK, "BucketAlreadyExists")
+	require.ErrorIs(t, b.Create(ctx, nil), codestore.ErrOwnedElsewhere)
+}
+
+func TestLambdaCodeStoreBucket_ReadsTags(t *testing.T) {
+	b, _ := s3Responder(t, http.StatusOK, http.StatusOK, "")
+	tags, err := b.Tags(t.Context())
+	require.NoError(t, err)
+	assert.Equal(t, codestore.OwnerTagValue, tags[codestore.OwnerTagKey])
+
+	b, _ = s3Responder(t, http.StatusOK, http.StatusNotFound, "")
+	tags, err = b.Tags(t.Context())
+	require.NoError(t, err)
+	assert.Empty(t, tags)
+}
+
+// Composing the store at gateway start makes no IAM or S3 call; the first use
+// provisions the role and bucket and opens a session through the real STS path.
+func TestNewLambdaCodeStore_ProvisionsOnlyOnFirstUse(t *testing.T) {
+	iamSvc, stsSvc := newCodeStoreIAM(t)
+	var s3Calls []string
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		_, isTagging := r.URL.Query()["tagging"]
+		s3Calls = append(s3Calls, r.Method+" "+r.URL.Path+" tagging="+strconv.FormatBool(isTagging))
+		w.WriteHeader(http.StatusOK)
+	}))
+	t.Cleanup(srv.Close)
+
+	mgr, err := newLambdaCodeStore(codeStoreWiring{
+		Region: codeStoreTestRegion, Node: "node1", Endpoint: srv.URL, SigningRegion: codeStoreTestRegion,
+		RootAccessKey: "AKIAROOT", RootSecretKey: "root-secret",
+	}, iamSvc, stsSvc)
+	require.NoError(t, err)
+
+	roleName := aws.String(stsdomain.CodeStoreRoleName(codeStoreTestRegion))
+	_, err = iamSvc.GetRole(identifiers.GlobalAccountID, &iam.GetRoleInput{RoleName: roleName})
+	code, _ := awserrors.ResolveErrorCode(err)
+	require.Equal(t, awserrors.ErrorIAMNoSuchEntity, code, "no role before first use")
+	assert.Empty(t, s3Calls, "no bucket request before first use")
+
+	_, err = mgr.Store(t.Context())
+	require.NoError(t, err)
+
+	_, err = iamSvc.GetRole(identifiers.GlobalAccountID, &iam.GetRoleInput{RoleName: roleName})
+	require.NoError(t, err)
+	assert.Equal(t, []string{
+		"PUT /lambda-code-ap-southeast-2 tagging=false",
+		"PUT /lambda-code-ap-southeast-2 tagging=true",
+	}, s3Calls)
+}

spinifex/runtime/roles/awsgw/lambda_presign_endpoint_test.go

@@ -0,0 +1,24 @@
+package awsgw
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestLambdaPresignEndpoint(t *testing.T) {
+	cases := []struct{ name, host, advertise, want string }{
+		{"wildcard uses the advertise IP", "0.0.0.0:8443", "192.168.0.15", "https://192.168.0.15:8443"},
+		{"loaded wildcard (loopback) uses the advertise IP", "127.0.0.1:8443", "192.168.0.15", "https://192.168.0.15:8443"},
+		{"localhost uses the advertise IP", "localhost:8443", "192.168.0.15", "https://192.168.0.15:8443"},
+		{"concrete listen host is kept", "10.22.7.1:8443", "192.168.0.15", "https://10.22.7.1:8443"},
+		{"wildcard with no advertise IP is unknown", "0.0.0.0:8443", "", ""},
+		{"loopback with no advertise IP is unknown", "127.0.0.1:8443", "", ""},
+		{"no port is unknown", "192.168.0.15", "192.168.0.15", ""},
+	}
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			assert.Equal(t, tc.want, lambdaPresignEndpoint(tc.host, tc.advertise))
+		})
+	}
+}

spinifex/runtime/roles/awsgw/lambda_role_trust.go

@@ -0,0 +1,13 @@
+package awsgw
+
+import (
+	stsdomain "github.com/mulgadc/spinifex/spinifex/domains/sts"
+)
+
+const lambdaServicePrincipal = "lambda.amazonaws.com"
+
+// lambdaRoleTrusts evaluates an execution role's stored trust policy for
+// lambda.amazonaws.com acting for the function's account.
+func lambdaRoleTrusts(svc stsdomain.RoleGetter) func(accountID, roleARN string) (bool, error) {
+	return stsdomain.RoleTrusts(svc, lambdaServicePrincipal)
+}

spinifex/runtime/roles/awsgw/lambda_role_trust_test.go

@@ -0,0 +1,50 @@
+package awsgw
+
+import (
+	"testing"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/service/iam"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/identifiers"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+// The trust decision is the stored role's real trust policy evaluated for
+// lambda.amazonaws.com, so only a role Lambda could assume is accepted.
+func TestLambdaRoleTrusts_EvaluatesTheStoredTrustPolicy(t *testing.T) {
+	iamSvc, _ := newCodeStoreIAM(t)
+	acct := identifiers.GlobalAccountID
+	trusts := lambdaRoleTrusts(iamSvc)
+
+	allowLambda := `{"Effect":"Allow","Principal":{"Service":"lambda.amazonaws.com"},"Action":"sts:AssumeRole"}`
+	cases := []struct {
+		name, statements string
+		want             bool
+	}{
+		{"trusts lambda", allowLambda, true},
+		{"trusts only ec2", `{"Effect":"Allow","Principal":{"Service":"ec2.amazonaws.com"},"Action":"sts:AssumeRole"}`, false},
+		{"explicit deny wins", allowLambda + `,{"Effect":"Deny","Principal":{"Service":"lambda.amazonaws.com"},"Action":"sts:AssumeRole"}`, false},
+		{"source account matches", `{"Effect":"Allow","Principal":{"Service":"lambda.amazonaws.com"},"Action":"sts:AssumeRole","Condition":{"StringEquals":{"aws:SourceAccount":"` + acct + `"}}}`, true},
+		{"source account differs", `{"Effect":"Allow","Principal":{"Service":"lambda.amazonaws.com"},"Action":"sts:AssumeRole","Condition":{"StringEquals":{"aws:SourceAccount":"123456789012"}}}`, false},
+	}
+	for i, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			name := "exec-" + string(rune('a'+i))
+			out, err := iamSvc.CreateRole(acct, &iam.CreateRoleInput{
+				RoleName:                 aws.String(name),
+				AssumeRolePolicyDocument: aws.String(`{"Version":"2012-10-17","Statement":[` + tc.statements + `]}`),
+			})
+			require.NoError(t, err)
+			got, err := trusts(acct, aws.StringValue(out.Role.Arn))
+			require.NoError(t, err)
+			assert.Equal(t, tc.want, got)
+		})
+	}
+
+	t.Run("missing role is not trusted", func(t *testing.T) {
+		got, err := trusts(acct, "arn:aws:iam::"+acct+":role/absent")
+		require.NoError(t, err)
+		assert.False(t, got)
+	})
+}

tests/integration/cross_tenant_test.go

@@ -3,11 +3,11 @@
 package integration
 
 import (
-	"github.com/mulgadc/spinifex/internal/testkit/gwfix"
 	"bytes"
 	"encoding/json"
 	"encoding/xml"
 	"fmt"
+	"github.com/mulgadc/spinifex/internal/testkit/gwfix"
 	"io"
 	"net/http"
 	"net/url"
@@ -21,12 +21,12 @@ import (
 	"github.com/aws/aws-sdk-go/service/iam"
 	acmawsapi "github.com/mulgadc/spinifex/spinifex/domains/acm/awsapi"
 	awsapi "github.com/mulgadc/spinifex/spinifex/domains/ecr/awsapi"
-	"github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
-	"github.com/mulgadc/spinifex/spinifex/foundation/aws/policy"
 	ecsawsapi "github.com/mulgadc/spinifex/spinifex/domains/ecs/awsapi"
 	eksawsapi "github.com/mulgadc/spinifex/spinifex/domains/eks/awsapi"
 	elbv2awsapi "github.com/mulgadc/spinifex/spinifex/domains/elbv2/awsapi"
 	iamawsapi "github.com/mulgadc/spinifex/spinifex/domains/iam/awsapi"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/errors"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/policy"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
@@ -523,7 +523,7 @@ func iamUncased() map[string]string {
 		"PutGroupPolicy", "PutRolePolicy", "PutUserPolicy", "RemoveRoleFromInstanceProfile",
 		"RemoveUserFromGroup", "TagInstanceProfile", "TagRole", "TagUser",
 		"UntagInstanceProfile", "UntagRole", "UntagUser", "UpdateAccessKey",
-		"UpdateAssumeRolePolicy", "UpdateRole", "UpdateRoleDescription",
+		"UpdateAssumeRolePolicy", "UpdateRole", "UpdateRoleDescription", "UpdateUser",
 	} {
 		uncased[action] = byName
 	}

tests/integration/iam_groups_test.go

@@ -238,11 +238,16 @@ func TestIAMGroupsLifecycle(t *testing.T) {
 	_, err = iamCli.CreateUser(&iam.CreateUserInput{UserName: aws.String(grpLifecycleUser)})
 	require.NoError(t, err, "create-user")
 
-	// remove-user-from-group on a non-member surfaces NoSuchEntity (must not no-op).
+	// remove-user-from-group on a non-member of an existing group succeeds, as on AWS.
 	_, err = iamCli.RemoveUserFromGroup(&iam.RemoveUserFromGroupInput{
 		GroupName: aws.String(grpLifecycleGroup),
 		UserName:  aws.String(grpLifecycleUser),
 	})
+	require.NoError(t, err, "remove-user-from-group non-member")
+	_, err = iamCli.RemoveUserFromGroup(&iam.RemoveUserFromGroupInput{
+		GroupName: aws.String("ghost-group"),
+		UserName:  aws.String(grpLifecycleUser),
+	})
 	requireAWSErrorCode(t, err, "NoSuchEntity")
 
 	// Ghost-entity binds → NoSuchEntity. Group is validated before the user.

tests/integration/iam_roles_test.go

@@ -115,7 +115,7 @@ func TestIAMRolesAndProfiles(t *testing.T) {
 	})
 	require.NoError(t, err, "update-role-description")
 	require.Equal(t, "described", aws.StringValue(descOut.Role.Description))
-	require.Equal(t, int64(7200), aws.Int64Value(descOut.Role.MaxSessionDuration))
+	require.Nil(t, descOut.Role.MaxSessionDuration, "AWS omits MaxSessionDuration from update-role-description")
 	got, err = iamCli.GetRole(&iam.GetRoleInput{RoleName: aws.String(iamRoleAppName)})
 	require.NoError(t, err, "get-role after update-role-description")
 	require.Equal(t, "described", aws.StringValue(got.Role.Description))

tests/integration/lambda_test.go

@@ -0,0 +1,169 @@
+//go:build integration
+
+package integration
+
+import (
+	"archive/zip"
+	"bytes"
+	"context"
+	"crypto/rand"
+	"crypto/sha256"
+	"encoding/base64"
+	"errors"
+	"io"
+	"net/http"
+	"testing"
+	"time"
+
+	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/aws/awserr"
+	"github.com/aws/aws-sdk-go/aws/credentials"
+	"github.com/aws/aws-sdk-go/aws/session"
+	"github.com/aws/aws-sdk-go/service/iam"
+	"github.com/aws/aws-sdk-go/service/lambda"
+	"github.com/aws/aws-sdk-go/service/s3"
+	ststypes "github.com/aws/aws-sdk-go/service/sts"
+	"github.com/mulgadc/bluebottle/pkg/masterkey"
+	"github.com/mulgadc/spinifex/internal/testkit/gwfix"
+	iamdomain "github.com/mulgadc/spinifex/spinifex/domains/iam"
+	lambdaawsapi "github.com/mulgadc/spinifex/spinifex/domains/lambda/awsapi"
+	"github.com/mulgadc/spinifex/spinifex/domains/lambda/codestore"
+	lambdafunction "github.com/mulgadc/spinifex/spinifex/domains/lambda/function"
+	stsdomain "github.com/mulgadc/spinifex/spinifex/domains/sts"
+	"github.com/mulgadc/spinifex/spinifex/foundation/aws/passrole"
+	awsdispatch "github.com/mulgadc/spinifex/spinifex/ingress/aws/dispatch"
+	testpredastore "github.com/mulgadc/spinifex/tests/fixtures/predastore"
+	"github.com/nats-io/nats.go"
+	"github.com/nats-io/nats.go/jetstream"
+	"github.com/stretchr/testify/require"
+)
+
+const lambdaTrustPolicy = `{"Version":"2012-10-17","Statement":[{"Effect":"Allow","Principal":{"Service":"lambda.amazonaws.com"},"Action":"sts:AssumeRole"}]}`
+
+// The gateway's NATS connection and IAM service exist only once
+// StartGatewayWithServices has built them, after the registration list.
+type lateMeta struct{ lambdafunction.Client }
+
+type lateRoles struct{ passrole.Resolver }
+
+// startLambdaDaemonLite subscribes the production MetaService to the subjects
+// the gateway's Lambda client dials, on JetStream KV like the live daemon.
+func startLambdaDaemonLite(t *testing.T, nc *nats.Conn) {
+	t.Helper()
+	js, err := jetstream.New(nc)
+	require.NoError(t, err)
+	svc := lambdafunction.NewMetaService(js)
+	sub(t, nc, lambdafunction.SubjectCreate, func(m *nats.Msg) { dispatch(m, svc.Create) })
+	sub(t, nc, lambdafunction.SubjectGet, func(m *nats.Msg) { dispatch(m, svc.Get) })
+	sub(t, nc, lambdafunction.SubjectCodeStored, func(m *nats.Msg) { dispatch(m, svc.CodeStored) })
+	sub(t, nc, lambdafunction.SubjectRollbackCreate, func(m *nats.Msg) { dispatch(m, svc.RollbackCreate) })
+}
+
+// TestLambda_SignedCreateAndGetDownloadsTheStoredCode drives CreateFunction and
+// GetFunction through signed ingress, the NATS-owned function record and the
+// real code store on the Predastore fixture, then downloads Code.Location.
+// The fixture authenticates only its service key, so that key stands in for
+// the scoped code-store session; provisioning and session scoping are not here.
+func TestLambda_SignedCreateAndGetDownloadsTheStoredCode(t *testing.T) {
+	fixture := testpredastore.Start(t)
+	bucket := codestore.BucketName(testRegion)
+	if _, err := fixtureS3(t, fixture).CreateBucket(&s3.CreateBucketInput{Bucket: aws.String(bucket)}); err != nil {
+		var ae awserr.Error
+		require.True(t, errors.As(err, &ae) && ae.Code() == s3.ErrCodeBucketAlreadyOwnedByYou, "create %s: %v", bucket, err)
+	}
+	store, err := codestore.Open(codestore.OpenConfig{
+		Region:          testRegion,
+		Endpoint:        "https://" + fixture.Host,
+		PresignEndpoint: "https://" + fixture.Host,
+		SigningRegion:   fixture.Region,
+		Assume: func() (*ststypes.AssumeRoleOutput, error) {
+			return &ststypes.AssumeRoleOutput{Credentials: &ststypes.Credentials{
+				AccessKeyId:     aws.String(fixture.AccessKey),
+				SecretAccessKey: aws.String(fixture.SecretKey),
+				Expiration:      aws.Time(time.Now().Add(time.Hour)),
+			}}, nil
+		},
+	})
+	require.NoError(t, err)
+
+	keyBytes := make([]byte, 32)
+	_, err = rand.Read(keyBytes)
+	require.NoError(t, err)
+	envKey, err := masterkey.New(keyBytes)
+	require.NoError(t, err)
+
+	meta, roles := &lateMeta{}, &lateRoles{}
+	var trusts func(accountID, roleARN string) (bool, error)
+	gw := StartGatewayWithServices(t, []awsdispatch.Registration{lambdaawsapi.NewRegistration(lambdaawsapi.Deps{
+		Meta:   meta,
+		Codes:  func(context.Context) (lambdaawsapi.CodeStore, error) { return store, nil },
+		Roles:  roles,
+		Trusts: func(accountID, roleARN string) (bool, error) { return trusts(accountID, roleARN) },
+		AEAD:   envKey.AEAD,
+	})})
+	iamSvc, ok := gwfix.DepsOf(gw.Config).IAM.(*iamdomain.IAMServiceImpl)
+	require.True(t, ok, "harness IAM service type")
+	meta.Client = lambdafunction.NewNATSClient(gw.NATSConn)
+	roles.Resolver = iamdomain.NewRoleResolver(iamSvc)
+	trusts = stsdomain.RoleTrusts(iamSvc, "lambda.amazonaws.com")
+	startLambdaDaemonLite(t, gw.NATSConn)
+
+	role, err := gw.IAMClient(t).CreateRole(&iam.CreateRoleInput{
+		RoleName: aws.String("lambda-e2e-exec"), AssumeRolePolicyDocument: aws.String(lambdaTrustPolicy),
+	})
+	require.NoError(t, err)
+
+	code := lambdaTestZip(t)
+	sum := sha256.Sum256(code)
+	cli := lambda.New(gw.session(t))
+	created, err := cli.CreateFunction(&lambda.CreateFunctionInput{
+		FunctionName: aws.String("e2e-fn"),
+		Runtime:      aws.String("provided.al2023"),
+		Handler:      aws.String("bootstrap"),
+		Role:         role.Role.Arn,
+		Code:         &lambda.FunctionCode{ZipFile: code},
+		Environment:  &lambda.Environment{Variables: map[string]*string{"MODE": aws.String("e2e")}},
+	})
+	require.NoError(t, err)
+	require.Equal(t, base64.StdEncoding.EncodeToString(sum[:]), aws.StringValue(created.CodeSha256))
+
+	got, err := cli.GetFunction(&lambda.GetFunctionInput{FunctionName: aws.String("e2e-fn")})
+	require.NoError(t, err)
+	require.Equal(t, "e2e", aws.StringValue(got.Configuration.Environment.Variables["MODE"]))
+	require.NotNil(t, got.Code.Location)
+
+	// SSL_CERT_FILE (set by the fixture) makes the default client trust it.
+	resp, err := http.Get(aws.StringValue(got.Code.Location)) //nolint:gosec,noctx // URL is the presigned location under test
+	require.NoError(t, err)
+	defer func() { _ = resp.Body.Close() }()
+	require.Equal(t, http.StatusOK, resp.StatusCode)
+	downloaded, err := io.ReadAll(resp.Body)
+	require.NoError(t, err)
+	require.Equal(t, code, downloaded)
+}
+
+// fixtureS3 signs as the fixture's service key; the fixture's certificate is in
+// the process trust store via SSL_CERT_FILE.
+func fixtureS3(t *testing.T, fixture *testpredastore.Fixture) *s3.S3 {
+	t.Helper()
+	sess, err := session.NewSession(&aws.Config{
+		Region:           aws.String(fixture.Region),
+		Endpoint:         aws.String("https://" + fixture.Host),
+		Credentials:      credentials.NewStaticCredentials(fixture.AccessKey, fixture.SecretKey, ""),
+		S3ForcePathStyle: aws.Bool(true),
+	})
+	require.NoError(t, err)
+	return s3.New(sess)
+}
+
+func lambdaTestZip(t *testing.T) []byte {
+	t.Helper()
+	var buf bytes.Buffer
+	zw := zip.NewWriter(&buf)
+	w, err := zw.Create("bootstrap")
+	require.NoError(t, err)
+	_, err = w.Write([]byte("#!/bin/sh\necho e2e\n"))
+	require.NoError(t, err)
+	require.NoError(t, zw.Close())
+	return buf.Bytes()
+}