fix: ui test warnings

This commit is contained in:
Julian Sommer
2026-09-07 13:38:22 +10:00
parent b435b858e4
commit f9d72d9487
7 changed files with 19 additions and 13 deletions
+1 -1
View File
@@ -7,7 +7,7 @@
<link rel="icon" href="/favicon.svg" type="image/svg+xml" />
<meta name="theme-color" content="#000000" />
<meta name="description" content="Spinifex Control Panel" />
<script type="module" crossorigin src="/assets/index-Bq1MIPbB.js"></script>
<script type="module" crossorigin src="/assets/index-TqD6BsA2.js"></script>
<link rel="modulepreload" crossorigin href="/assets/compiler-runtime-BAC6wZ-W.js">
<link rel="modulepreload" crossorigin href="/assets/removable-CebS9mWh.js">
<link rel="modulepreload" crossorigin href="/assets/query-C_Z2CP1f.js">
@@ -561,7 +561,7 @@ export function SidebarMenuButton({
},
props,
),
render: tooltip ? TooltipTrigger : render,
render: tooltip ? <TooltipTrigger /> : render,
state: {
slot: "sidebar-menu-button",
sidebar: "menu-button",
@@ -4,6 +4,7 @@ import type {
} from "@aws-sdk/client-bedrock"
import { QueryClient, QueryClientProvider } from "@tanstack/react-query"
import { render, screen, waitFor } from "@testing-library/react"
import userEvent from "@testing-library/user-event"
import type { ReactNode } from "react"
import { describe, expect, it, vi } from "vitest"
@@ -174,12 +175,13 @@ describe("GuardrailDetailPage", () => {
it("deletes the guardrail and navigates back on confirm", async () => {
mockBedrockSend.mockResolvedValueOnce({})
const user = userEvent.setup()
renderSeeded(GUARDRAIL)
screen.getByRole("button", { name: "Delete" }).click()
await user.click(screen.getByRole("button", { name: "Delete" }))
await screen.findByText("Delete Guardrail")
const deleteButtons = screen.getAllByRole("button", { name: "Delete" })
deleteButtons.at(-1)?.click()
await user.click(deleteButtons.at(-1)!)
await waitFor(() => {
expect(mockBedrockSend).toHaveBeenCalled()
@@ -197,9 +199,10 @@ describe("GuardrailDetailPage", () => {
it("creates a new version for the guardrail", async () => {
mockBedrockSend.mockResolvedValueOnce({ version: "2" })
const user = userEvent.setup()
renderSeeded(GUARDRAIL)
screen.getByRole("button", { name: "Create version" }).click()
await user.click(screen.getByRole("button", { name: "Create version" }))
await waitFor(() => {
expect(mockBedrockSend).toHaveBeenCalled()
@@ -117,12 +117,13 @@ describe("KnowledgeBaseDetailPage", () => {
it("deletes the knowledge base and navigates back on confirm", async () => {
mockSend.mockResolvedValueOnce({})
const user = userEvent.setup()
renderSeeded([], KNOWLEDGE_BASE)
screen.getByRole("button", { name: "Delete" }).click()
await user.click(screen.getByRole("button", { name: "Delete" }))
await screen.findByText("Delete Knowledge Base")
const deleteButtons = screen.getAllByRole("button", { name: "Delete" })
deleteButtons.at(-1)?.click()
await user.click(deleteButtons.at(-1)!)
await waitFor(() => {
expect(mockSend).toHaveBeenCalled()
@@ -9,9 +9,9 @@ import {
} from "@/test/elbv2-integration"
vi.mock("@/lib/awsClient", () => ({
getEksClient: () => ({ send: vi.fn() }),
getEc2Client: () => ({ send: vi.fn() }),
getIamClient: () => ({ send: vi.fn() }),
getEksClient: () => ({ send: vi.fn().mockResolvedValue({}) }),
getEc2Client: () => ({ send: vi.fn().mockResolvedValue({}) }),
getIamClient: () => ({ send: vi.fn().mockResolvedValue({}) }),
}))
import { NodegroupsTab } from "./nodegroups-tab"
@@ -79,14 +79,16 @@ describe("CreateDBSubnetGroupPage", () => {
// resolveGroupSubnets refuses a group spanning two VPCs, so the second VPC
// has to go out of reach rather than stay selectable and fail at submit.
it("puts the other VPCs out of reach once a subnet is chosen", () => {
it("puts the other VPCs out of reach once a subnet is chosen", async () => {
renderWithClient(<CreateDBSubnetGroupPage />, seed())
expect(subnetCheckbox("subnet-b1")).toBeEnabled()
fireEvent.click(subnetCheckbox("subnet-a1"))
await waitFor(() => {
expect(subnetCheckbox("subnet-b1")).toBeDisabled()
})
expect(subnetCheckbox("subnet-a2")).toBeEnabled()
expect(subnetCheckbox("subnet-b1")).toBeDisabled()
expect(screen.getByText(/must span one VPC/)).toBeInTheDocument()
})