fix: enable last rules

spinifex/services/spinifexui/frontend/.oxlintrc.json

@@ -15,36 +15,33 @@
     "typeCheck": true
   },
   "rules": {
-    "@tanstack/router/create-route-property-order": "warn",
-    "@tanstack/router/route-param-names": "error",
     "@tanstack/query/exhaustive-deps": "error",
-    "@tanstack/query/stable-query-client": "error",
     "@tanstack/query/infinite-query-property-order": "error",
     "@tanstack/query/mutation-property-order": "error",
-    "@tanstack/query/no-rest-destructuring": "warn",
+    "@tanstack/query/no-rest-destructuring": "error",
     "@tanstack/query/no-unstable-deps": "error",
     "@tanstack/query/no-void-query-fn": "error",
+    "@tanstack/query/stable-query-client": "error",
+    "@tanstack/router/create-route-property-order": "error",
+    "@tanstack/router/route-param-names": "error",
     "eslint/complexity": "off",
     "eslint/func-style": "off",
-    "eslint/no-shadow": "off",
     "eslint/no-use-before-define": "off",
     "eslint/prefer-destructuring": "off",
     "eslint/sort-imports": "off",
     "eslint/sort-keys": "off",
     "eslint/sort-vars": "off",
     "import/consistent-type-specifier-style": "off",
-    "import/first": "off",
-    "react/jsx-handler-names": "off",
-    "react/no-unescaped-entities": "off",
     "promise/prefer-await-to-callbacks": "off",
+    "react/jsx-handler-names": "off",
     "react-perf/jsx-no-new-function-as-prop": "off",
     "typescript/no-confusing-void-expression": "off",
-    "typescript/return-await": "off",
     "typescript/no-floating-promises": "off",
-    "typescript/strict-boolean-expressions": "off",
     "typescript/no-misused-promises": "off",
     "typescript/only-throw-error": "off",
     "typescript/promise-function-async": "off",
+    "typescript/return-await": "off",
+    "typescript/strict-boolean-expressions": "off",
     "unicorn/filename-case": [
       "error",
       { "cases": { "kebabCase": true, "camelCase": true } }
@@ -57,6 +54,7 @@
         "**/__tests__/**/*.{ts,tsx,js,jsx}"
       ],
       "rules": {
+        "import/first": "off",
         "typescript/consistent-type-imports": "off",
         "typescript/no-unsafe-argument": "off",
         "typescript/no-unsafe-assignment": "off",

spinifex/services/spinifexui/frontend/src/components/ui/sidebar.tsx

@@ -90,7 +90,7 @@ export function SidebarProvider({
   // Helper to toggle the sidebar.
   const toggleSidebar = React.useCallback(
     () =>
-      isMobile ? setOpenMobile((open) => !open) : setOpen((open) => !open),
+      isMobile ? setOpenMobile((prev) => !prev) : setOpen((prev) => !prev),
     [isMobile, setOpen, setOpenMobile],
   )
 

spinifex/services/spinifexui/frontend/src/routes/_auth/ec2/(instances)/describe-instances/$id.tsx

@@ -359,8 +359,8 @@ function InstanceDetail() {
           <AlertDialogHeader>
             <AlertDialogTitle>Modify Instance</AlertDialogTitle>
             <AlertDialogDescription>
-              Select a new instance type for "{instance.InstanceId}". The
-              instance must be stopped to modify its attributes.
+              Select a new instance type for &quot;{instance.InstanceId}&quot;.
+              The instance must be stopped to modify its attributes.
             </AlertDialogDescription>
           </AlertDialogHeader>
           <Field>

spinifex/services/spinifexui/frontend/src/routes/_auth/ec2/(volumes)/describe-volumes/$id.tsx

@@ -371,8 +371,9 @@ function VolumeDetail() {
           <AlertDialogHeader>
             <AlertDialogTitle>Detach Volume</AlertDialogTitle>
             <AlertDialogDescription>
-              Are you sure you want to detach the volume "{volume.VolumeId}"
-              from instance "{volume.Attachments?.[0]?.InstanceId}"?
+              Are you sure you want to detach the volume &quot;{volume.VolumeId}
+              &quot; from instance &quot;{volume.Attachments?.[0]?.InstanceId}
+              &quot;?
             </AlertDialogDescription>
           </AlertDialogHeader>
           <label className="flex items-center gap-2 text-sm">

spinifex/services/spinifexui/frontend/src/routes/_auth/ec2/(volumes)/modify-volume/$id.tsx

@@ -43,7 +43,7 @@ function ModifyVolume() {
     formState: { errors, isSubmitting },
   } = useForm({
     resolver: zodResolver(
-      modifyVolumeSchema.refine((data) => data.size > currentSize, {
+      modifyVolumeSchema.refine((values) => values.size > currentSize, {
         message: `New size must be greater than current size (${currentSize} GiB)`,
         path: ["size"],
       }),
@@ -62,9 +62,9 @@ function ModifyVolume() {
     )
   }
 
-  const onSubmit = async (data: ModifyVolumeFormData) => {
+  const onSubmit = async (formData: ModifyVolumeFormData) => {
     await modifyMutation.mutateAsync({
-      ...data,
+      ...formData,
       volumeId,
     })
 

spinifex/services/spinifexui/frontend/src/routes/_auth/ec2/-components/private-key-modal.tsx

@@ -54,7 +54,7 @@ export function PrivateKeyModal({
           <AlertDialogDescription>
             This is your only chance to save the private key file for{" "}
             <strong>{keyName}</strong>. Please download or copy it now. You
-            won't be able to retrieve it again.
+            won&apos;t be able to retrieve it again.
           </AlertDialogDescription>
         </AlertDialogHeader>
 

spinifex/services/spinifexui/frontend/src/routes/_auth/iam/-components/access-key-modal.tsx

@@ -36,7 +36,7 @@ export function AccessKeyModal({
           <AlertDialogTitle>Save Your Access Key</AlertDialogTitle>
           <AlertDialogDescription>
             This is your only chance to view the secret access key. Please copy
-            it now. You won't be able to retrieve it again.
+            it now. You won&apos;t be able to retrieve it again.
           </AlertDialogDescription>
         </AlertDialogHeader>