docs: record why awsgw sets no WriteTimeout (#821)

http.Server.WriteTimeout is a total deadline rather than an idle one, so any
value below the RDS command channel's 20s long poll kills every poll mid-flight
and strands agents on a channel no command can reach. Nothing recorded that the
omission was load-bearing, leaving it one hardening pass away from removal.
This commit is contained in:
Josh Siviour
2026-08-18 09:35:38 +10:00
committed by GitHub
parent 7bae1bd957
commit ba7eb4d90f
+3
View File
@@ -519,6 +519,9 @@ func launchService(config *config.ClusterConfig) error {
return fmt.Errorf("load TLS cert: %w", err)
}
// WriteTimeout is deliberately absent: it is a total deadline rather than an
// idle one, so any value below the RDS command channel's 20s long poll kills
// every poll mid-flight and strands agents on a channel no command reaches.
server := &http.Server{
Addr: nodeConfig.AWSGW.Host,
Handler: handler,