gsadmin/spinifex
1
0
Fork 0
mirror of https://github.com/mulgadc/spinifex.git synced 2026-10-15 09:01:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: drop NeedDeps from the slog duration guard's package load

Browse Source 
The guard only reads types for the syntax it walks, which resolves from
dependency export data; NeedDeps type-checked the whole graph from source for
no extra coverage. Verified identical detection either way (160 packages, 993
files, 3684 slog call sites, and both violation classes still caught).
19.0s to 7.3s under -race.
This commit is contained in:
Julian Sommer
2026-09-01 11:48:30 +10:00
parent 481df170f5
commit 4abbab59af
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spinifex/otelsetup/duration_guard_test.go
+4 -1
View File
@@ -33,9 +33,12 @@ var logMethods = map[string]bool{
func TestSlogDurationConvention(t *testing.T) {
root := moduleRoot(t)
// No NeedDeps: the guard only reads types for the syntax it walks, which
// resolves from dependency export data. Asking for dependency syntax as
// well type-checks the whole graph from source for no extra coverage.
cfg := &packages.Config{
Mode: packages.NeedName | packages.NeedSyntax | packages.NeedTypes |
packages.NeedTypesInfo | packages.NeedDeps | packages.NeedImports,
packages.NeedTypesInfo | packages.NeedImports,
Dir: root,
}
pkgs, err := packages.Load(cfg, "./spinifex/...", "./cmd/...")