mirror of
https://github.com/Studio-Saelix/sencho.git
synced 2026-08-06 08:58:05 +00:00
e5e58ed932
When an E2E test flakes in CI, the backend and frontend stdout is gone the moment the step exits. That makes a failed run extremely hard to triage: you get the Playwright report but nothing from the services underneath it. Redirect both dev servers to files under the workspace's ci-logs/ directory and include that directory in the failure-case artifact upload, so the report and the service logs travel together. Log files live under $GITHUB_WORKSPACE rather than /tmp because actions/upload-artifact@v4+ computes a common parent directory across all path entries. Mixing repo-relative paths with /tmp paths makes '/' the common root, which v4+ then strips from the artifact, silently dropping the absolute entries. Keeping everything under the workspace avoids that footgun. `stdbuf -oL -eL` forces line-buffered output on both services. Node stdout is block-buffered when redirected to a regular file, so a crash or abort can lose the final few hundred lines - exactly the output you need when debugging a CI failure. Also remove the duplicated `E2E_USERNAME: admin` / `E2E_PASSWORD: password123` env blocks from the e2e and update-screenshots jobs. Those values were already the fallback defaults in e2e/helpers.ts (`process.env.E2E_USERNAME ?? 'admin'`), so the env blocks were doing nothing on the default path and created two sources of truth for the same literals. e2e/helpers.ts remains the canonical source; callers that want to override the creds still set E2E_USERNAME / E2E_PASSWORD as job-level env.
83 lines
2.4 KiB
YAML
83 lines
2.4 KiB
YAML
name: Start Sencho App
|
|
description: >
|
|
Shared setup for integration jobs: installs deps, builds backend,
|
|
starts backend + frontend dev servers, waits for readiness,
|
|
and installs Playwright browsers.
|
|
|
|
inputs:
|
|
jwt-secret:
|
|
required: false
|
|
default: 'ci-test-secret-key-not-for-production'
|
|
compose-dir:
|
|
required: false
|
|
default: '/tmp/compose'
|
|
port:
|
|
required: false
|
|
default: '3000'
|
|
|
|
runs:
|
|
using: composite
|
|
steps:
|
|
- name: Setup Node.js
|
|
uses: actions/setup-node@v6
|
|
with:
|
|
node-version: '20'
|
|
cache: 'npm'
|
|
cache-dependency-path: |
|
|
package-lock.json
|
|
backend/package-lock.json
|
|
frontend/package-lock.json
|
|
|
|
- name: Install root dependencies (Playwright)
|
|
shell: bash
|
|
run: npm ci
|
|
|
|
- name: Install backend dependencies
|
|
shell: bash
|
|
run: npm ci
|
|
working-directory: ./backend
|
|
|
|
- name: Build backend
|
|
shell: bash
|
|
run: npm run build
|
|
working-directory: ./backend
|
|
|
|
- name: Install frontend dependencies
|
|
shell: bash
|
|
run: npm ci
|
|
working-directory: ./frontend
|
|
|
|
- name: Create compose directory and log dir
|
|
shell: bash
|
|
run: |
|
|
mkdir -p ${{ inputs.compose-dir }}
|
|
mkdir -p "${{ github.workspace }}/ci-logs"
|
|
|
|
# Log files live under $GITHUB_WORKSPACE so actions/upload-artifact@v4+ can
|
|
# include them alongside repo-relative paths like e2e/report/. Mixing those
|
|
# with /tmp paths makes '/' the common root and v4+ strips the absolute
|
|
# entries from the artifact. `stdbuf -oL -eL` forces line-buffered output
|
|
# so a crash doesn't lose the final few hundred lines to block buffering.
|
|
- name: Start backend
|
|
shell: bash
|
|
run: stdbuf -oL -eL node dist/index.js > "${{ github.workspace }}/ci-logs/backend.log" 2>&1 &
|
|
working-directory: ./backend
|
|
env:
|
|
JWT_SECRET: ${{ inputs.jwt-secret }}
|
|
COMPOSE_DIR: ${{ inputs.compose-dir }}
|
|
PORT: ${{ inputs.port }}
|
|
NODE_ENV: test
|
|
|
|
- name: Start frontend dev server
|
|
shell: bash
|
|
run: stdbuf -oL -eL npm run dev > "${{ github.workspace }}/ci-logs/frontend.log" 2>&1 &
|
|
working-directory: ./frontend
|
|
|
|
- name: Wait for services to be ready
|
|
shell: bash
|
|
run: npx wait-on http://localhost:${{ inputs.port }}/api/health http://localhost:5173 --timeout 30000
|
|
|
|
- name: Install Playwright browsers
|
|
shell: bash
|
|
run: npx playwright install --with-deps chromium
|