mirror of
https://github.com/Studio-Saelix/sencho.git
synced 2026-07-26 20:00:08 +00:00
Anso
e5e58ed932
When an E2E test flakes in CI, the backend and frontend stdout is gone the moment the step exits. That makes a failed run extremely hard to triage: you get the Playwright report but nothing from the services underneath it. Redirect both dev servers to files under the workspace's ci-logs/ directory and include that directory in the failure-case artifact upload, so the report and the service logs travel together. Log files live under $GITHUB_WORKSPACE rather than /tmp because actions/upload-artifact@v4+ computes a common parent directory across all path entries. Mixing repo-relative paths with /tmp paths makes '/' the common root, which v4+ then strips from the artifact, silently dropping the absolute entries. Keeping everything under the workspace avoids that footgun. `stdbuf -oL -eL` forces line-buffered output on both services. Node stdout is block-buffered when redirected to a regular file, so a crash or abort can lose the final few hundred lines - exactly the output you need when debugging a CI failure. Also remove the duplicated `E2E_USERNAME: admin` / `E2E_PASSWORD: password123` env blocks from the e2e and update-screenshots jobs. Those values were already the fallback defaults in e2e/helpers.ts (`process.env.E2E_USERNAME ?? 'admin'`), so the env blocks were doing nothing on the default path and created two sources of truth for the same literals. e2e/helpers.ts remains the canonical source; callers that want to override the creds still set E2E_USERNAME / E2E_PASSWORD as job-level env.