gsadmin/sencho
1
0
Fork 0
mirror of https://github.com/Studio-Saelix/sencho.git synced 2026-07-26 11:49:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(backend): strip stale phase annotations from canonical-order comment (#753)

Browse Source 
The canonical middleware-order comment in app.ts carried historical
notes from the index.ts refactor ("before Phase 4 finishes", "moves to
routes/* in Phase 4", "moves here in Phase 5") that are no longer
active-voice descriptions of current state. Replace with plain
descriptions matching the final module layout. The 16-step enumeration
and the invariant paragraph about public routers (metaRouter, authRouter,
mfaRouter, ssoRouter) sitting before the auth gate are preserved.

No behavior change.
This commit is contained in:
Anso
2026-04-24 10:21:25 -04:00
committed by GitHub
parent 43a595905b
commit 3a20e37625
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/app.ts
+7 -7
View File
@@ -23,18 +23,18 @@ import './types/express';
* 7. pollingLimiter (at /api)
* 8. conditionalJsonParser
* 9. nodeContextMiddleware
* 10. authGate (at /api) -- registered in index.ts (before Phase 4 finishes)
* 10. authGate (at /api) -- registered in index.ts
* 11. auditLog (at /api) -- registered in index.ts
* 12. enforceApiTokenScope (at /api) -- registered in index.ts
* 13. createRemoteProxyMiddleware -- proxy/remoteNodeProxy.ts, registered in index.ts
* 14. routes -- registered in index.ts (moves to routes/* in Phase 4)
* 15. static serving + SPA fallback -- registered in index.ts (moves here in Phase 5)
* 14. routes -- registered in index.ts from routes/*
* 15. static serving + SPA fallback -- registered in index.ts
* 16. errorHandler -- registered in index.ts
*
* Steps 10-12 and 14 must run after the auth routes are registered so those
* routes can remain public (login, setup, MFA, SSO). Once all routes live in
* `routes/*.ts` routers and are mounted here in `createApp()`, every step
* collapses into this factory.
* Steps 10 to 12 and 14 must run after the public auth routers (meta, auth,
* mfa, sso) are registered so those routes stay reachable without a session
* cookie. index.ts mounts those public routers before step 10 to preserve
* that invariant.
*/
export function createApp(): express.Express {
const app = express();