gsadmin/rustguac
1
0
Fork 0
mirror of https://github.com/sol1/rustguac.git synced 2026-10-26 05:29:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

client: keep the fullscreen gesture press off the remote, release all input after the transition

Browse Source 
With fullscreen-on-connect, the first mousedown after CONNECTED is the
browser's fullscreen gesture, but Guacamole.Mouse forwarded it to guacd
as well, and the transition that followed swallowed its release. guacd
was left with the button held and the terminal selected text on every
pointer move; the same with a key press as the gesture.

Stop the gesture event before the display's handlers see it, and on
entering fullscreen release everything explicitly: keyboard.reset() and
a mouse state with no buttons at the last pointer position, so a release
lost for any other reason during the transition cannot stick either.

Fixes #256
This commit is contained in:
Jad Seifeddine
2026-10-11 07:00:08 +07:00
parent 04597c20cd
commit ee03b3e65c
1 changed files with 25 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
static/client.html
+25 -1
View File
@@ -1466,14 +1466,37 @@
if (x) { try { x.call(document); } catch (e) {} }
}
function rgArmFullscreenGesture() {
var fire = function() {
var fire = function(e) {
document.removeEventListener('mousedown', fire, true);
document.removeEventListener('keydown', fire, true);
// This press is the browser's fullscreen gesture, not
// input for the remote. The transition it starts re-lays
// out the display and swallows the matching release, and
// a press guacd never sees released turns every later
// pointer move into a drag selection (#256). Keep it from
// the display's handlers; rgReleaseAllInput() covers a
// release lost for any other reason once fullscreen lands.
e.stopPropagation();
e.preventDefault();
rgEnterFullscreen();
};
document.addEventListener('mousedown', fire, true);
document.addEventListener('keydown', fire, true);
}
// Tell the remote that nothing is held: every key the keyboard
// tracks as down, and all mouse buttons at the last pointer
// position. Used after a fullscreen transition, during which the
// browser may not deliver the releases to the display element.
function rgReleaseAllInput() {
try { if (keyboard) keyboard.reset(); } catch (e) {}
try {
if (!mouse || !mouse.currentState) return;
var st = new Guacamole.Mouse.State(mouse.currentState);
st.left = st.middle = st.right = st.up = st.down = false;
if (fillX !== 1 || fillY !== 1) { st.x /= fillX; st.y /= fillY; }
client.sendMouseState(st, true);
} catch (e) {}
}
function rgShowEscNoticeOnce() {
if (sessionStorage.getItem('rustguac_esc_notice_seen')) return;
sessionStorage.setItem('rustguac_esc_notice_seen', '1');
@@ -1526,6 +1549,7 @@
function rgOnFullscreenChange() {
var inFs = !!rgFullscreenEl();
var bar = document.getElementById('fs-bar');
if (inFs) rgReleaseAllInput();
if (bar) {
if (inFs) {
bar.classList.add('visible');