mirror of
https://github.com/rustfs/rustfs.git
synced 2026-09-06 03:59:14 +00:00
houseme
6e7909b75c
Use decimal boundary comparisons for ABBA ratio checks and cover exact documented p99, throughput, and P1 limits. Co-Authored-By: heihutu <heihutu@gmail.com> Co-Authored-By: zhi22915 <qiuzgang@gmail.com>
361 lines
18 KiB
Python
Executable File
361 lines
18 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
"""Synthetic adapter and failure-propagation tests; never start a RustFS server."""
|
|
|
|
import contextlib
|
|
import copy
|
|
import fcntl
|
|
import io
|
|
import json
|
|
import os
|
|
from pathlib import Path
|
|
import shlex
|
|
import signal
|
|
import subprocess
|
|
import sys
|
|
import tempfile
|
|
import time
|
|
import unittest
|
|
from unittest.mock import patch
|
|
|
|
import scanner_abba as harness
|
|
|
|
|
|
def fake_adapter():
|
|
action, request_path, output_path = sys.argv[1:]
|
|
request = harness.read_json(Path(request_path))
|
|
fault = os.environ.get("SCANNER_ABBA_TEST_FAULT", "")
|
|
if fault == "stubborn-child" and action in ("prepare", "measure"):
|
|
marker = Path(request_path).parent / "stubborn.pid"
|
|
if os.fork() == 0:
|
|
os.execv(sys.executable, [sys.executable, str(Path(__file__).resolve()), "--stubborn-worker", str(marker)])
|
|
wait_for_marker(marker)
|
|
if action == "measure":
|
|
time.sleep(60)
|
|
if action == "prepare":
|
|
result = {"ready": True}
|
|
elif action == "stop":
|
|
if fault == "stubborn-child":
|
|
reap_fixture(Path(request_path).parent / "stubborn.pid")
|
|
result = {"stopped": True}
|
|
elif action == "oracle":
|
|
if fault == "oracle-exit":
|
|
return 42
|
|
if fault == "missing-oracle":
|
|
return 0
|
|
result = {"complete": True, "errors": 0, "actual": request["expected_oracle"]}
|
|
if fault == "oracle-mismatch":
|
|
result["actual"]["bytes"] += 1
|
|
else:
|
|
if fault == "measure-exit":
|
|
return 42
|
|
result = {key: request[key] for key in ("evidence", "fixed", "build", "data_dir", "background")}
|
|
result.update({"sample_count": 10, "elapsed_seconds": request["duration_seconds"],
|
|
"metrics": dict.fromkeys(harness.METRICS, 10)})
|
|
baseline = request["comparison"] == "build" and request["leg"].startswith("A")
|
|
result["metrics"].update(p99_ms=10, throughput_ops=100, errors=0, requests=100,
|
|
walk_objects=100 if baseline else 20, cold_walk_objects=100 if baseline else 0,
|
|
healed_objects=request["expected_healed_objects"])
|
|
result["convergence"] = {"writes_stopped": True, "last_mutation_observed": True,
|
|
"first_complete_publication": True, "last_mutation_time": 1,
|
|
"last_mutation_observed_time": 2,
|
|
"writes_stopped_time": 2, "window_start": 2, "window_end": 3,
|
|
"budget_available_seconds": 1, "walk_objects": 110, "full_walk_objects": 100}
|
|
if fault == "zero-samples":
|
|
result["sample_count"] = 0
|
|
elif fault == "request-errors":
|
|
result["metrics"]["errors"] = 1
|
|
elif fault == "load-drift":
|
|
result["fixed"]["offered_load_ops"] += 1
|
|
elif fault == "noise" and request["leg"] == "A2":
|
|
result["metrics"]["p99_ms"] = 20
|
|
elif fault == "zero-requests":
|
|
result["metrics"]["requests"] = 0
|
|
elif fault == "no-publication":
|
|
result["convergence"]["first_complete_publication"] = False
|
|
elif fault == "p2-regression":
|
|
result["convergence"]["walk_objects"] = 121
|
|
elif fault == "latency-regression" and request["leg"].startswith("B"):
|
|
result["metrics"]["p99_ms"] = 12
|
|
elif fault == "exact-thresholds" and request["leg"].startswith("B"):
|
|
result["metrics"].update(p99_ms=10.5, throughput_ops=97)
|
|
elif fault == "just-over-threshold" and request["comparison"] == "build" and request["leg"].startswith("B"):
|
|
result["metrics"]["p99_ms"] = 10.500001
|
|
elif fault == "p1-regression" and not baseline:
|
|
result["metrics"]["walk_objects"] = 30
|
|
elif fault in ("p1-exact-fraction", "p1-over-fraction"):
|
|
result["metrics"].update(walk_objects=9 if baseline else 5 + (fault == "p1-over-fraction"),
|
|
cold_walk_objects=5 if baseline else 0)
|
|
elif fault == "missing-metric":
|
|
del result["metrics"]["save_bytes"]
|
|
elif fault == "incomplete-repair":
|
|
result["metrics"]["healed_objects"] = 0
|
|
harness.write_json(Path(output_path), result)
|
|
return 0
|
|
|
|
|
|
def wait_for_marker(marker):
|
|
deadline = time.monotonic() + 5
|
|
while time.monotonic() < deadline:
|
|
if marker.exists() and marker.stat().st_size:
|
|
return
|
|
time.sleep(0.01)
|
|
raise AssertionError("fixture child did not become ready")
|
|
|
|
|
|
def child_released(marker, timeout=1):
|
|
deadline = time.monotonic() + timeout
|
|
with marker.open("r+") as stream:
|
|
while True:
|
|
try:
|
|
fcntl.flock(stream, fcntl.LOCK_EX | fcntl.LOCK_NB)
|
|
return True
|
|
except BlockingIOError:
|
|
if time.monotonic() >= deadline:
|
|
return False
|
|
time.sleep(0.01)
|
|
|
|
|
|
def reap_fixture(marker):
|
|
if marker.exists() and marker.stat().st_size and not child_released(marker, timeout=0):
|
|
# The unique file lock proves the original fixture process still owns this PID.
|
|
os.kill(int(marker.read_text()), signal.SIGKILL)
|
|
if not child_released(marker, timeout=5):
|
|
raise AssertionError("fixture child did not release its process-owned lock")
|
|
|
|
|
|
class ScannerAbbaTest(unittest.TestCase):
|
|
def setUp(self):
|
|
self.temp = tempfile.TemporaryDirectory()
|
|
self.addCleanup(self.temp.cleanup)
|
|
self.root = Path(self.temp.name)
|
|
self.binary = Path(sys.executable).resolve()
|
|
self.adapter = Path(__file__).resolve()
|
|
self.manifest = {
|
|
"schema": 1, "evidence": "synthetic", "rounds": 3, "duration_seconds": 1, "min_free_bytes": 1,
|
|
"fixed": {"config_sha256": "1" * 64, "dataset_sha256": "2" * 64,
|
|
"release_flags": "--release", "durability": "drive-sync=on",
|
|
"disk_type": "synthetic", "cache_state": "cold", "load_command": "fake",
|
|
"topology": "EC8+4", "offered_load_ops": 100, "resource_isolation": "synthetic"},
|
|
"oracles": {s: {"objects": 10, "versions": 20, "bytes": 30, "sha256": "3" * 64} for s in harness.SCENARIOS},
|
|
"expected_healed_objects": {s: 10 for s in harness.SCENARIOS},
|
|
}
|
|
build = {"binary": str(self.binary), "sha256": harness.digest(self.binary), "revision": "a" * 40}
|
|
self.manifest.update(baseline=build.copy(), candidate=build.copy())
|
|
|
|
def run_harness(self, fault=""):
|
|
with patch.dict(os.environ, {"SCANNER_ABBA_TEST_FAULT": fault}), contextlib.redirect_stdout(io.StringIO()):
|
|
return harness.run(copy.deepcopy(self.manifest), self.adapter, self.root / "out", self.root / "data")
|
|
|
|
def test_adapter_timeout_reaps_group_after_parent_exits_on_term(self):
|
|
request = self.root / "request.json"
|
|
harness.write_json(request, {})
|
|
marker = self.root / "stubborn.pid"
|
|
try:
|
|
with patch.dict(os.environ, {"SCANNER_ABBA_TEST_FAULT": "stubborn-child"}):
|
|
with self.assertRaises(subprocess.TimeoutExpired):
|
|
harness.invoke(self.adapter, "measure", request, 3)
|
|
wait_for_marker(marker)
|
|
self.assertTrue(child_released(marker), "TERM-exited parent left its TERM-ignoring child alive")
|
|
finally:
|
|
reap_fixture(marker)
|
|
|
|
def test_collector_failure_reaps_group_after_parent_exits_on_term(self):
|
|
request = self.root / "request.json"
|
|
harness.write_json(request, {})
|
|
marker = self.root / "stubborn.pid"
|
|
collector = self.root / "run_scanner_validation_harness.sh"
|
|
command = [sys.executable, str(self.adapter), "measure", str(request), str(self.root / "unused.json")]
|
|
collector.write_text("#!/usr/bin/env bash\nexec " + shlex.join(command) + "\n")
|
|
|
|
def failed_measure(*_):
|
|
wait_for_marker(marker)
|
|
raise ValueError("injected measurement failure")
|
|
|
|
try:
|
|
with patch.dict(os.environ, {"SCANNER_ABBA_TEST_FAULT": "stubborn-child"}), \
|
|
patch.object(harness, "__file__", str(self.root / "scanner_abba.py")), \
|
|
patch.object(harness, "invoke", side_effect=failed_measure):
|
|
with self.assertRaisesRegex(ValueError, "injected measurement failure"):
|
|
harness.collect_live({"collector": {"alias": "fixture", "endpoint": "fixture", "metrics_endpoints": "fixture"}},
|
|
{"duration_seconds": 900}, request, self.adapter)
|
|
self.assertTrue(child_released(marker), "collector parent exit did not end its telemetry child")
|
|
finally:
|
|
reap_fixture(marker)
|
|
|
|
def test_successful_prepare_keeps_service_alive(self):
|
|
request = self.root / "request.json"
|
|
harness.write_json(request, {})
|
|
marker = self.root / "stubborn.pid"
|
|
try:
|
|
with patch.dict(os.environ, {"SCANNER_ABBA_TEST_FAULT": "stubborn-child"}):
|
|
self.assertEqual(harness.invoke(self.adapter, "prepare", request, 5), {"ready": True})
|
|
self.assertFalse(child_released(marker, timeout=0), "successful prepare must preserve its service")
|
|
self.assertEqual(harness.invoke(self.adapter, "stop", request, 5), {"stopped": True})
|
|
self.assertTrue(child_released(marker), "adapter stop must release its service")
|
|
finally:
|
|
reap_fixture(marker)
|
|
|
|
def test_reaped_owner_never_signals_a_reused_process_group(self):
|
|
with (self.root / "owner.log").open("wb") as log:
|
|
owner = harness.OwnedCommand([sys.executable, "-c", "pass"], log)
|
|
self.assertEqual(owner.wait(5), 0)
|
|
self.assertEqual(owner.finish(), 0)
|
|
with patch.object(harness.os, "killpg", side_effect=AssertionError("released PGID must not be signalled")):
|
|
self.assertEqual(owner.finish(terminate=True), 0)
|
|
|
|
def test_cleanup_interruption_still_kills_group_and_reaps_leader(self):
|
|
request = self.root / "request.json"
|
|
harness.write_json(request, {})
|
|
marker = self.root / "stubborn.pid"
|
|
original_sleep = time.sleep
|
|
interrupted = False
|
|
|
|
def interrupt_once(delay):
|
|
nonlocal interrupted
|
|
if not interrupted:
|
|
interrupted = True
|
|
raise KeyboardInterrupt
|
|
original_sleep(delay)
|
|
|
|
with (self.root / "interrupted.log").open("wb") as log:
|
|
with patch.dict(os.environ, {"SCANNER_ABBA_TEST_FAULT": "stubborn-child"}):
|
|
owner = harness.OwnedCommand([str(self.adapter), "measure", str(request), str(self.root / "unused.json")], log)
|
|
try:
|
|
wait_for_marker(marker)
|
|
with patch.object(harness.time, "sleep", side_effect=interrupt_once):
|
|
with self.assertRaises(KeyboardInterrupt):
|
|
owner.finish(terminate=True)
|
|
self.assertTrue(child_released(marker), "cleanup cancellation left its child alive")
|
|
self.assertIsNotNone(owner.process.returncode, "cleanup cancellation must reap its leader")
|
|
finally:
|
|
reap_fixture(marker)
|
|
owner.process.wait(timeout=5)
|
|
|
|
def test_constructor_failure_after_gate_release_kills_group(self):
|
|
request = self.root / "request.json"
|
|
harness.write_json(request, {})
|
|
marker = self.root / "stubborn.pid"
|
|
original_write = os.write
|
|
|
|
def release_then_fail(fd, data):
|
|
original_write(fd, data)
|
|
wait_for_marker(marker)
|
|
raise OSError("injected failure after gate release")
|
|
|
|
try:
|
|
with (self.root / "construction.log").open("wb") as log, \
|
|
patch.dict(os.environ, {"SCANNER_ABBA_TEST_FAULT": "stubborn-child"}), \
|
|
patch.object(harness.os, "write", side_effect=release_then_fail):
|
|
with self.assertRaisesRegex(OSError, "injected failure after gate release"):
|
|
harness.OwnedCommand([str(self.adapter), "measure", str(request), str(self.root / "unused.json")], log)
|
|
self.assertTrue(child_released(marker), "initialization failure left its child alive")
|
|
finally:
|
|
reap_fixture(marker)
|
|
|
|
def test_complete_synthetic_matrix_is_not_performance_evidence(self):
|
|
self.assertEqual(self.run_harness(), 0)
|
|
report = harness.read_json(self.root / "out/report.json")
|
|
self.assertEqual((report["status"], report["performance"], report["cells"]), ("synthetic_validated", "pending", 120))
|
|
requests = [harness.read_json(path) for path in (self.root / "out").glob("*/request.json")]
|
|
self.assertEqual(len({r["data_dir"] for r in requests}), 120)
|
|
for scenario in harness.SCENARIOS:
|
|
for comparison in ("build", "background"):
|
|
for round_id in (1, 2, 3):
|
|
legs = [r for r in requests if (r["scenario"], r["comparison"], r["round"]) == (scenario, comparison, round_id)]
|
|
self.assertEqual({r["leg"] for r in legs}, set(harness.LEGS))
|
|
self.assertTrue(all(c["p2_max_work_multiple"] == 1.2 for c in report["comparisons"]))
|
|
|
|
def test_fail_closed_adapter_and_data_errors(self):
|
|
for fault in ("measure-exit", "oracle-exit", "missing-oracle", "oracle-mismatch", "zero-samples",
|
|
"zero-requests", "request-errors", "load-drift", "missing-metric", "incomplete-repair"):
|
|
with self.subTest(fault=fault), tempfile.TemporaryDirectory() as directory:
|
|
self.root = Path(directory)
|
|
with self.assertRaises((ValueError, OSError, subprocess.SubprocessError)):
|
|
self.run_harness(fault)
|
|
report = harness.read_json(self.root / "out/report.json")
|
|
self.assertEqual(report["status"], "failed")
|
|
self.assertTrue(list((self.root / "out").glob("*/stop.json")))
|
|
|
|
def test_noise_is_inconclusive_and_nonzero(self):
|
|
with patch.object(harness, "SCENARIOS", ("cold-hot",)):
|
|
self.assertEqual(self.run_harness("noise"), 3)
|
|
self.assertEqual(harness.read_json(self.root / "out/report.json")["status"], "inconclusive")
|
|
|
|
def test_missing_first_publication_is_inconclusive(self):
|
|
with patch.object(harness, "SCENARIOS", ("cold-hot",)):
|
|
self.assertEqual(self.run_harness("no-publication"), 3)
|
|
|
|
def test_performance_regressions_fail(self):
|
|
for fault in ("p1-regression", "p2-regression", "latency-regression"):
|
|
with self.subTest(fault=fault), tempfile.TemporaryDirectory() as directory:
|
|
self.root = Path(directory)
|
|
with patch.object(harness, "SCENARIOS", ("cold-hot",)):
|
|
self.assertEqual(self.run_harness(fault), 1)
|
|
|
|
def test_exact_threshold_boundaries_pass(self):
|
|
with patch.object(harness, "SCENARIOS", ("cold-hot",)):
|
|
self.assertEqual(self.run_harness("exact-thresholds"), 0)
|
|
|
|
def test_just_over_threshold_fails(self):
|
|
with patch.object(harness, "SCENARIOS", ("cold-hot",)):
|
|
self.assertEqual(self.run_harness("just-over-threshold"), 1)
|
|
|
|
def test_p1_fractional_boundary(self):
|
|
for fault, expected in (("p1-exact-fraction", 0), ("p1-over-fraction", 1)):
|
|
with self.subTest(fault=fault), tempfile.TemporaryDirectory() as directory:
|
|
self.root = Path(directory)
|
|
with patch.object(harness, "SCENARIOS", ("cold-hot",)):
|
|
self.assertEqual(self.run_harness(fault), expected)
|
|
|
|
def test_manifest_rejects_missing_build_or_oracle(self):
|
|
for section, key in (("baseline", "binary"), ("oracles", "cold-hot")):
|
|
manifest = copy.deepcopy(self.manifest)
|
|
del manifest[section][key]
|
|
with self.subTest(section=section), self.assertRaises((ValueError, KeyError)):
|
|
harness.validate_manifest(manifest)
|
|
|
|
def test_short_measured_window_and_fewer_rounds_rejected(self):
|
|
self.manifest["evidence"] = "measured"
|
|
with self.assertRaisesRegex(ValueError, "duration_seconds"):
|
|
harness.validate_manifest(self.manifest)
|
|
self.manifest["duration_seconds"] = 900
|
|
self.manifest["rounds"] = 2
|
|
with self.assertRaisesRegex(ValueError, "rounds"):
|
|
harness.validate_manifest(self.manifest)
|
|
|
|
def test_existing_data_preserved(self):
|
|
(self.root / "data").mkdir()
|
|
marker = self.root / "data/keep"
|
|
marker.write_text("existing")
|
|
with self.assertRaisesRegex(ValueError, "preserved"):
|
|
self.run_harness()
|
|
self.assertEqual(marker.read_text(), "existing")
|
|
|
|
def test_invalid_or_live_write_window_does_not_claim_p2(self):
|
|
self.assertIsNone(harness.convergence({"convergence": {"writes_stopped": False}}))
|
|
with self.assertRaises(ValueError):
|
|
harness.convergence({"convergence": {"writes_stopped": True, "last_mutation_observed": True,
|
|
"first_complete_publication": True}})
|
|
|
|
def test_nan_and_oversized_samples_rejected(self):
|
|
with self.assertRaises(ValueError):
|
|
harness.number(float("nan"), "latency")
|
|
path = self.root / "oversized.json"
|
|
path.write_bytes(b" " * (harness.MAX_JSON_BYTES + 1))
|
|
with self.assertRaisesRegex(ValueError, "oversized"):
|
|
harness.read_json(path)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
if len(sys.argv) == 3 and sys.argv[1] == "--stubborn-worker":
|
|
signal.signal(signal.SIGTERM, signal.SIG_IGN)
|
|
with Path(sys.argv[2]).open("w+") as marker:
|
|
fcntl.flock(marker, fcntl.LOCK_EX)
|
|
marker.write(str(os.getpid()))
|
|
marker.flush()
|
|
while True:
|
|
time.sleep(1)
|
|
if len(sys.argv) == 4 and sys.argv[1] in ("prepare", "measure", "oracle", "stop"):
|
|
sys.exit(fake_adapter())
|
|
unittest.main()
|