mirror of
https://github.com/rustfs/rustfs.git
synced 2026-07-27 08:38:58 +00:00
Zhengchao An
7f19e9a465
docs/testing/security-regressions.md requires every fixed advisory to map to a named, greppable regression test. Rename the tests added with the fixes to carry their advisory id so `rg -i ghsa` finds them, and add the four rows to the advisory -> test map. Adds the FTPS MKD regression test that was missing. It primes the dummy backend with a successful create_bucket, so the assertion distinguishes "denied at the authorization boundary" from "backend refused" — without the queued success an unconfigured create_bucket fails on its own and the test would pass even with the authorization check removed. Verified it fails when the check is reverted. DummyBackend gains a Debug impl (FtpsDriver's trait bounds require it) and a queue_create_bucket_ok helper. Records in the CI-execution map why ghsa_g3vq_* runs in the default pass despite sitting behind the ftps feature: the rustfs crate defaults to ["ftps", "webdav"] and cargo unifies features across the workspace build, so the test executes there even though `cargo test -p rustfs-protocols` alone would skip it.
94 lines
8.5 KiB
Markdown
94 lines
8.5 KiB
Markdown
# Security Advisory Regression Tests
|
|
|
|
Every fixed RustFS GitHub Security Advisory (GHSA) should map to at least one
|
|
named, discoverable regression test. The convention is: name the test (or a
|
|
helper / doc comment on the exact assertion) after the advisory so that
|
|
|
|
```bash
|
|
rg -i "ghsa|3p3x|r5qv"
|
|
```
|
|
|
|
finds the guard for any advisory, and a future fix of a still-open advisory is
|
|
forced to update its pinned test (red -> green).
|
|
|
|
> This is the lightweight inventory. sec-14 (backlog#1151) formalizes the
|
|
> written admission policy in `AGENTS.md`; keep this file as the map.
|
|
|
|
## Advisory -> test mapping
|
|
|
|
| Advisory | Class | Fix PR | Named regression tests | Layer |
|
|
| --- | --- | --- | --- | --- |
|
|
| [GHSA-3p3x-734c-h5vx](https://github.com/rustfs/rustfs/security/advisories/GHSA-3p3x-734c-h5vx) | Constant-time secret comparison on WebDAV/FTPS password login | rustfs/rustfs#4403 | `assert_ftps_ghsa_3p3x_wrong_credentials_rejected` (`crates/e2e_test/src/protocols/ftps_core.rs`); `GHSA-3p3x` auth-failure block in `test_webdav_core_operations` (`crates/e2e_test/src/protocols/webdav_core.rs`) | e2e (protocols suite) |
|
|
| [GHSA-r5qv-rc46-hv8q](https://github.com/rustfs/rustfs/security/advisories/GHSA-r5qv-rc46-hv8q) | Internode RPC authentication must fail closed | rustfs/rustfs#4402 | `ghsa_r5qv_resolve_shared_secret_rejects_default_fallback`, `ghsa_r5qv_verify_rpc_signature_fails_closed_on_missing_or_invalid_auth` (`crates/ecstore/src/cluster/rpc/http_auth.rs`) | unit |
|
|
| [GHSA-m77q-r63m-pj89](https://github.com/rustfs/rustfs/security/advisories/GHSA-m77q-r63m-pj89) | STS JWTs signed with shared root secret (intentionally unfixed) | n/a | `test_ghsa_m77q_sts_session_token_signed_with_root_secret` (flow-level pin: signing key == root secret, root-only decode, authorizes) and `test_created_sts_credentials_authorize_with_session_token_claims` (`crates/iam/src/sys.rs`); `token_signing_key` doc (`crates/iam/src/root_credentials.rs`) — pin current by-design behavior; fixing m77q must update red -> green | unit |
|
|
| [GHSA-5354-r3w2-34m8](https://github.com/rustfs/rustfs/security/advisories/GHSA-5354-r3w2-34m8) | Service-account parent must stay within caller scope — a non-owner holding `CreateServiceAccountAdminAction` could parent a service account to the root credential and authenticate as owner | rustfs/rustfs#5141 | `ghsa_5354_non_owner_service_account_parent_confined_to_scope` and the `add_service_account_parent_within_scope` invariant it pins (`rustfs/src/admin/handlers/service_account.rs`) | unit |
|
|
| [GHSA-3ppv-fx5m-m749](https://github.com/rustfs/rustfs/security/advisories/GHSA-3ppv-fx5m-m749) | Versioned object reads must be authorized against `s3:GetObjectVersion`, not `s3:GetObject` (`get_object`, CopyObject source, UploadPartCopy source) | rustfs/rustfs#5142 | `ghsa_3ppv_versioned_read_selects_get_object_version_action` and the `versioned_read_action` helper it pins (`rustfs/src/storage/access.rs`) | unit |
|
|
| [GHSA-v9cp-qfw9-9pfp](https://github.com/rustfs/rustfs/security/advisories/GHSA-v9cp-qfw9-9pfp) | `ForAllValues:`/`ForAnyValue:` negated string operators were transposed — negation was applied to the aggregate quantified result instead of the per-value predicate | pending | `ghsa_v9cp_for_all_values_not_equals_partial_overlap`, `ghsa_v9cp_for_any_value_not_equals_partial_overlap` and the absent-key/positive-quantifier cases beside them (`crates/policy/tests/quantified_negation.rs`) — the value set must partially overlap the policy set, contained or disjoint sets cannot tell the two quantifiers apart | unit (crate test) |
|
|
| [GHSA-6r96-hmgc-726c](https://github.com/rustfs/rustfs/security/advisories/GHSA-6r96-hmgc-726c) | Request headers must not populate server-derived IAM condition keys (`userid`, `groups`, `jwt:`/`ldap:` claim names) | pending | `ghsa_6r96_identity_condition_keys_ignore_spoofed_headers`, `ghsa_6r96_claim_condition_keys_ignore_spoofed_headers`, and `test_request_headers_still_reach_conditions` which guards the reserved set from growing too broad (`rustfs/src/auth.rs`) | unit |
|
|
| [GHSA-x298-9x87-fvjq](https://github.com/rustfs/rustfs/security/advisories/GHSA-x298-9x87-fvjq) | The anonymous ListObjectVersions -> `s3:ListBucket` fallback must reach the same public-access gates as a direct grant | pending | `ghsa_x298_anonymous_list_object_versions_denied_when_restrict_public_buckets_enabled` (`crates/e2e_test/src/anonymous_access_test.rs`) — asserts 200 before the public-access block is applied so the test proves the gate rather than a broken fallback | e2e |
|
|
| [GHSA-g3vq-vv42-f647](https://github.com/rustfs/rustfs/security/advisories/GHSA-g3vq-vv42-f647) | FTPS `MKD` must clear the `s3:CreateBucket` authorization boundary before reaching the backend | pending | `ghsa_g3vq_mkd_denied_before_reaching_backend` (`crates/protocols/src/ftps/driver.rs`) — primes `create_bucket` to succeed so the assertion distinguishes "denied at authorization" from "backend refused" | unit |
|
|
|
|
## Where these run (CI-execution map)
|
|
|
|
Every security regression must land where CI actually runs it — a named test in
|
|
an unexecuted suite is theater. The suites split across three execution paths by
|
|
topology:
|
|
|
|
- **Unit tests** — `ghsa_r5qv_*` (`crates/ecstore`), the GHSA-m77q STS
|
|
pinning (`crates/iam`), `ghsa_5354_*` / `ghsa_3ppv_*` / `ghsa_6r96_*`
|
|
(`rustfs` lib), `ghsa_v9cp_*` (`crates/policy` crate test), and
|
|
`ghsa_g3vq_*` (`crates/protocols`) run automatically in the default CI pass
|
|
(`cargo nextest run --profile ci --all --exclude e2e_test`) — no special
|
|
wiring. This is the CI-executed regression for the RPC fail-closed (r5qv),
|
|
STS-signing (m77q), service-account parent-scope (5354), versioned-read
|
|
authorization (3ppv), condition-key injection (6r96), quantified-negation
|
|
(v9cp), and FTPS MKD authorization (g3vq) advisories.
|
|
|
|
`ghsa_g3vq_*` sits behind `rustfs-protocols`' `ftps` feature, which is off by
|
|
default for that crate alone. It still runs in the workspace pass because the
|
|
`rustfs` crate defaults to `["ftps", "webdav"]` and cargo unifies features
|
|
across the build. Running `cargo test -p rustfs-protocols` on its own silently
|
|
skips it — use `--features ftps` in that case. The `protocol-features` CI
|
|
matrix covers `swift` and `sftp` only, for the same reason: those are not in
|
|
any default feature set, so they need explicit jobs.
|
|
- **S3-API negative-auth e2e (e2e-smoke, PR-gated)** — the attacker-facing S3
|
|
auth-rejection suites run on every PR via the `e2e-smoke` nextest profile
|
|
(`.config/nextest.toml`), which each spawns its own server on a random port
|
|
and is parallel-safe:
|
|
- `negative_sigv4_test` — tampered/wrong-key/skewed header SigV4 (sec-1)
|
|
- `presigned_negative_test` — expired/tampered/wrong-key presigned URLs (sec-2)
|
|
- `admin_auth_test` — non-admin denial + root-credential lifecycle (sec-4)
|
|
|
|
A count-floor guard (`scripts/check_security_smoke_count.sh`, floor in
|
|
`.config/security-smoke-floor.txt`) runs in the `e2e-tests` CI job and fails if
|
|
a rename drops any of these out of the smoke filter (infra-12 mechanism). This
|
|
is the sec-5 wiring: those merged suites were dead weight until listed here.
|
|
- **Protocol e2e (WebDAV/FTPS constant-time login, GHSA-3p3x)** — lives in the
|
|
`e2e_test` protocols suite (`test_protocol_core_suite`), which binds **fixed
|
|
ports**, needs the `ftps,webdav` build features, and is `#[serial]`. Those
|
|
three properties make it **structurally incompatible** with the random-port,
|
|
default-feature, parallel `e2e-smoke` profile: it cannot be a filterset change,
|
|
so sec-5 (scoped to a filterset change, global ruling G5) does not wire it.
|
|
It runs manually today:
|
|
|
|
```bash
|
|
RUSTFS_BUILD_FEATURES=ftps,webdav cargo test --package e2e_test \
|
|
test_protocol_core_suite -- --test-threads=1 --nocapture
|
|
```
|
|
|
|
**Open gap:** GHSA-3p3x's *e2e* layer has no PR-gated CI execution. A protocols
|
|
e2e CI lane is a ci-domain concern (a new profile/job, not a filterset change);
|
|
it is deliberately out of sec-5's boundary and left as a follow-up.
|
|
|
|
## Adding a new advisory guard
|
|
|
|
1. Reproduce the advisory's bypass form as a focused negative test.
|
|
2. Name the test (or the helper/assertion) `ghsa_<id>_*`, or attach a
|
|
`GHSA-<id>` doc comment with the advisory URL and fix PR.
|
|
3. Add a row to the table above.
|
|
4. Land it where CI runs it (see the map above): a unit guard in the default CI
|
|
pass; an S3-API negative-auth e2e in the `e2e-smoke` filter (add the module to
|
|
`.config/nextest.toml` and bump `.config/security-smoke-floor.txt`); a
|
|
fixed-port protocol e2e in the protocols suite (still manual — see the open
|
|
gap above).
|