gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-07-26 08:18:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ecstore): keep local path startup fail-fast under Kubernetes (#4640)

Browse Source 
The startup topology convergence auto-detection (added in #4631) checked
Kubernetes before endpoint style, so a local path deployment (single or
multi-drive, non-distributed) running inside Kubernetes was classified as
orchestrated with an effectively unbounded wait window. Path-style
endpoints have no hostnames to resolve, so the wait never actually
triggers and runtime behavior is unchanged, but the startup log then
advertised mode=orchestrated / wait_timeout=MAX for a purely local
deployment, which is misleading and contradicts the documented policy
(local path endpoints -> fail-fast).

Order the auto-detection by endpoint style first: only distributed URL
endpoints, which resolve hostnames, pick orchestrated (Kubernetes) or
bounded (otherwise); local path endpoints stay fail-fast regardless of
the platform. Update the doc comment to match and add a policy case
locking Kubernetes + local path to fail-fast.

Co-authored-by: heihutu <heihutu@gmail.com>
This commit is contained in:
houseme
2026-07-10 09:34:10 +08:00
committed by GitHub
parent 24d0c09347
commit d1daa97ac5
2 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/config/src/constants/app.rs
+2 -2
View File
@@ -153,8 +153,8 @@ pub const DEFAULT_UNSAFE_BYPASS_DISK_CHECK: bool = false;
/// - `bounded`: wait for a finite window (see
/// `ENV_STARTUP_TOPOLOGY_WAIT_TIMEOUT`) then fail with an actionable error.
/// - `fail-fast`: fail on the first non-transient resolution error (CI/local).
/// - `auto`: Kubernetes -> orchestrated, distributed URL endpoints -> bounded,
/// local path endpoints -> fail-fast.
/// - `auto`: distributed URL endpoints use orchestrated on Kubernetes and
/// bounded otherwise; local path endpoints use fail-fast (no DNS to await).
pub const ENV_STARTUP_TOPOLOGY_WAIT_MODE: &str = "RUSTFS_STARTUP_TOPOLOGY_WAIT_MODE";
/// Environment variable bounding how long startup waits for topology/DNS
crates/ecstore/src/layout/endpoints.rs
+14 -5
View File
@@ -768,13 +768,16 @@ impl StartupTopologyPolicy {
Some("bounded") => StartupTopologyWaitMode::Bounded,
Some("fail-fast") | Some("failfast") | Some("strict") => StartupTopologyWaitMode::FailFast,
// "auto", unset, or unrecognized: derive from the environment.
// Only URL-style (distributed) endpoints resolve hostnames and need
// to wait for DNS/topology convergence; local path endpoints never
// do, so they fail fast regardless of the platform.
_ => {
if kubernetes {
StartupTopologyWaitMode::Orchestrated
} else if distributed {
StartupTopologyWaitMode::Bounded
} else {
if !distributed {
StartupTopologyWaitMode::FailFast
} else if kubernetes {
StartupTopologyWaitMode::Orchestrated
} else {
StartupTopologyWaitMode::Bounded
}
}
};
@@ -1351,6 +1354,12 @@ mod test {
let local = StartupTopologyPolicy::resolve_from(None, false, false, None, None);
assert_eq!(local.mode, StartupTopologyWaitMode::FailFast);
assert_eq!(local.wait_timeout, Duration::ZERO);
// Local path endpoints stay fail-fast even under Kubernetes: they have
// no hostnames to resolve, so there is nothing to wait for.
let k8s_local = StartupTopologyPolicy::resolve_from(None, true, false, None, None);
assert_eq!(k8s_local.mode, StartupTopologyWaitMode::FailFast);
assert_eq!(k8s_local.wait_timeout, Duration::ZERO);
}
#[test]