gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-09-06 12:09:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(admin): route recovery auth errors through gateway

Browse Source
This commit is contained in:
cxymds
2026-09-06 18:11:31 +08:00
parent 50a25adc45
commit b725f0344b
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rustfs/src/admin/handlers/ilm_transition.rs
+14 -1
View File
@@ -483,7 +483,7 @@ async fn authorize_transition_admin_request(req: &S3Request<Body>, action: Admin
async fn authorize_recovery_admin_request(req: &S3Request<Body>, action: AdminAction) -> S3Result<String> {
if req.credentials.is_none() {
return Err(s3_error!(InvalidRequest, "authentication required"));
return Err(admin_s3_error(AdminS3ErrorCode::InvalidRequest, "authentication required"));
}
let credentials = authorize_admin_request(req, vec![Action::AdminAction(action)]).await?;
Ok(recovery_actor_sha256(&credentials))
@@ -2481,6 +2481,19 @@ mod tests {
assert_eq!(err.message(), Some("authentication required"));
}
#[tokio::test]
async fn recovery_admin_gate_keeps_its_missing_credentials_response() {
let err = authorize_recovery_admin_request(
&manual_transition_job_request(Method::GET, "/rustfs/admin/v3/ilm/recovery/controls/control-123"),
AdminAction::ListTierAction,
)
.await
.expect_err("a recovery admin request without credentials must fail");
assert_eq!(err.code(), &S3ErrorCode::InvalidRequest);
assert_eq!(err.message(), Some("authentication required"));
}
#[test]
fn transition_admin_gate_routes_through_the_shared_gate() {
let production = include_str!("ilm_transition.rs")