gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-09-22 18:43:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow 127.0.0.0/8 as loopback addresses for binding (#7943)

Browse Source 
This is particularly useful for integration testing of services that use
an S3 API, as it lets many different instances bind a port on different
IPs.

Co-authored-by: Chris <anzhengchao@gmail.com>
Co-authored-by: Hauser <housemecn@gmail.com>
This commit is contained in:
Aria Stewart
2026-09-16 22:11:36 -04:00
committed by GitHub
parent 706ffdc9ac
commit 892d3ba3f7
1 changed files with 45 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/utils/src/net.rs
+45 -4
View File
@@ -208,10 +208,10 @@ pub fn is_local_host(host: Host<&str>, port: u16, local_port: u16) -> std::io::R
Host::Domain(domain) => {
let ips = resolve_domain(domain)?.into_iter().collect::<Vec<_>>();
ips.iter().any(|ip| local_set.contains(ip))
ips.iter().any(|ip| is_local_ip(&local_set, ip))
}
Host::Ipv4(ip) => local_set.contains(&IpAddr::V4(ip)),
Host::Ipv6(ip) => local_set.contains(&IpAddr::V6(ip)),
Host::Ipv4(ip) => is_local_ip(&local_set, &IpAddr::V4(ip)),
Host::Ipv6(ip) => is_local_ip(&local_set, &IpAddr::V6(ip)),
};
if port > 0 {
@@ -221,6 +221,31 @@ pub fn is_local_host(host: Host<&str>, port: u16, local_port: u16) -> std::io::R
Ok(is_local_host)
}
/// Whether `ip` belongs to this host: it is either configured on a local
/// interface or, where the platform routes the full loopback space, a loopback
/// address.
fn is_local_ip(local_set: &HashSet<IpAddr>, ip: &IpAddr) -> bool {
if local_set.contains(ip) {
return true;
}
is_loopback_local(ip)
}
#[cfg(not(windows))]
fn is_loopback_local(ip: &IpAddr) -> bool {
// Unix kernels route and bind the entire RFC 1122 loopback space
// (127.0.0.0/8 plus ::1), so any loopback address is reachable on this
// host even when only 127.0.0.1 is configured on `lo` (e.g. 127.0.5.9).
ip.is_loopback()
}
#[cfg(windows)]
fn is_loopback_local(_ip: &IpAddr) -> bool {
// Windows only allows 127.0.0.1 by default, so loopback acceptance there
// is limited to the interface-configured addresses already checked above.
false
}
fn get_custom_dns_resolver() -> Option<Arc<DynDnsResolver>> {
match CUSTOM_DNS_RESOLVER.read() {
Ok(guard) => guard.clone(),
@@ -516,7 +541,16 @@ mod test {
#[test]
fn test_check_local_server_addr() {
// Test valid local addresses
let valid_cases = ["localhost:54321", "127.0.0.1:9000", "0.0.0.0:9000", "[::1]:8080", "::1:8080"];
let valid_cases = [
"localhost:54321",
"127.0.0.1:9000",
"0.0.0.0:9000",
"[::1]:8080",
"::1:8080",
// Unix binds the whole 127.0.0.0/8 loopback range; Windows only allows 127.0.0.1.
#[cfg(not(windows))]
"127.0.5.9:9000",
];
for addr in valid_cases {
let result = check_local_server_addr(addr);
@@ -557,6 +591,13 @@ mod test {
let ipv4_loopback = Host::Ipv4(Ipv4Addr::new(127, 0, 0, 1));
assert!(is_local_host(ipv4_loopback, 0, 0).unwrap());
// Any 127.0.0.0/8 address is loopback on Unix; Windows only allows 127.0.0.1.
#[cfg(not(windows))]
{
let ipv4_loopback_octet = Host::Ipv4(Ipv4Addr::new(127, 0, 5, 9));
assert!(is_local_host(ipv4_loopback_octet, 0, 0).unwrap());
}
let ipv6_loopback = Host::Ipv6(Ipv6Addr::new(0, 0, 0, 0, 0, 0, 0, 1));
assert!(is_local_host(ipv6_loopback, 0, 0).unwrap());