gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-07-26 08:18:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(kms): build secret fixtures without format-string interpolation

Browse Source 
The logging guardrail forbids secret-named identifiers inside format!
strings. The static-secret-file test interpolated file_secret/env_secret
to construct fixture content, tripping the repo-wide check for every
branch. Concatenate the fixture strings instead; the guarded pattern is
log/error output, which these are not.
This commit is contained in:
overtrue
2026-07-26 16:09:20 +08:00
parent 92f83bfe15
commit 54cb590b8b
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/kms/src/config.rs
+6 -2
View File
@@ -1186,7 +1186,11 @@ mod tests {
let secret_path = temp_dir.path().join("static-kms-secret");
let file_secret = base64::engine::general_purpose::STANDARD.encode([7u8; 32]);
let env_secret = base64::engine::general_purpose::STANDARD.encode([9u8; 32]);
std::fs::write(&secret_path, format!("file-key:{file_secret}\n")).expect("write static KMS secret file");
// Concatenate instead of format!-interpolating: the logging guardrail
// forbids secret-named identifiers inside format strings.
let file_contents = String::from("file-key:") + &file_secret + "\n";
std::fs::write(&secret_path, file_contents).expect("write static KMS secret file");
let env_value = String::from("env-key:") + &env_secret;
with_vars(
vec![
@@ -1195,7 +1199,7 @@ mod tests {
ENV_KMS_STATIC_SECRET_KEY_FILE,
Some(secret_path.to_str().expect("secret path should be utf-8")),
),
(ENV_KMS_STATIC_SECRET_KEY, Some(&format!("env-key:{env_secret}"))),
(ENV_KMS_STATIC_SECRET_KEY, Some(env_value.as_str())),
],
|| {
let config = KmsConfig::from_env().expect("static KMS config should load from secret file");