Files
Sebastian Poxhofer 3412de84ce refactor(linters): enable oxlint rule prefer-named-capture-group (#44714)
* refactor(lint): enable oxlint prefer-named-capture-group at error

Numbered capture groups (m[1], $1) break silently when a regex is
edited and group order shifts. Named groups (?<name>...) make intent
explicit and accesses (m.groups.name) resilient to reordering.

This enables the built-in eslint rule prefer-named-capture-group,
surfacing 321 pre-existing unnamed-group violations across ~121
files to be burned down incrementally in follow-up commits.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(versioning): name capture groups for prefer-named-capture-group

Burns down all prefer-named-capture-group violations in
lib/modules/versioning/. Unused capture groups (only reachable via
.test() or whole-match) become non-capturing (?:...); groups whose
value is read become named (?<name>...), with accesses rewritten to
match.groups!.<name> (or destructured from .groups!) instead of
positional match[n]/$n so a future edit that reorders groups cannot
silently break the reader.

Two cases needed extra care to preserve behavior:
- semver/common.ts and poetry/patterns.ts split() on a regex whose
  capture group is relied upon by String.prototype.split to keep the
  separator in the output array; the group is kept capturing and
  named, not converted to non-capturing.
- hashicorp/convertor.ts's semverRegex is only ever embedded via
  .source into a named `(?<version>...)` group elsewhere and never
  matched directly, so its internal groups are safe to make
  non-capturing.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(datasource): name capture groups for prefer-named-capture-group

Burns down all prefer-named-capture-group violations under
lib/modules/datasource/. Same treatment as the versioning module:
unused groups become non-capturing, used groups get names, and
positional match[n] reads move to match.groups!.<name>.

docker/ecr.ts and pypi/common.ts keep their positional destructuring
(`const [, region] = ...`, `!!m &&`) working unchanged since a named
capture group is still addressable by its numeric index in
JavaScript — only pypi/common.ts's access was rewritten to
m.groups!.owner for clarity since it read a single group directly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(platform): name capture groups for prefer-named-capture-group

Burns down all prefer-named-capture-group violations under
lib/modules/platform/. Uses the repo's established idiom of
`match.groups?.<name>` after an optional-chained exec()/match() (see
bitbucket/index.ts hostnameWithoutApiPrefix, gerrit/utils.ts
extractSourceBranch) and `$<name>` in String.replace replacement
strings. Unused groups (markdown/HTML massaging regexes matched only
to be stripped) become non-capturing.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(manager): name capture groups in ansible-galaxy for prefer-named-capture-group

Burns down prefer-named-capture-group violations in
lib/modules/manager/ansible-galaxy/. newBlockRegEx and blockLineRegEx
dropped their unused outer wrapping group (only the inner key/value
groups were ever read) and named the key/value groups; nameMatchRegex's
remaining unused groups (protocol/user-info/port alternatives) become
non-capturing since only source/hostname/depName/version are read via
.groups. Accesses in collections.ts and roles.ts move from
lineMatch[2]/lineMatch[3] to lineMatch.groups!.key/value.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(manager): name capture groups for prefer-named-capture-group (batch 1)

Burns down prefer-named-capture-group violations across the first
alphabetical slice of lib/modules/manager/ (ansible through mix).
Used groups get names with accesses rewritten to match.groups!.<name>
(or $<name> in replacement strings); groups whose value is never read
become non-capturing (?:...). Two String.split() call sites
(git-submodules/extract.ts, meteor/extract.ts) keep the established
"named group still readable positionally from the split() result
array" idiom instead of restructuring the destructuring.

bazel/rules/go.ts and buildpacks/extract.ts dockerRef verified
byte-for-byte equivalent before/after via a quick node script since
several nested groups collapsed to non-capturing at once.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(manager): name capture groups for prefer-named-capture-group (batch 2)

Burns down prefer-named-capture-group violations across the remaining
alphabetical slice of lib/modules/manager/ (npm through terragrunt).
Same treatment as batch 1: used groups get names with accesses moved
to match.groups!.<name> or $<name> replacement strings; unused groups
(wrapping alternations, quantifier repetition groups only consumed via
.test(), or values never read from a match) become non-capturing.

terraform/extractors/others/modules.ts and terragrunt/modules.ts share
near-identical URL-parsing regexes (github/bitbucket/git/azure-devops
ref matchers) — the same set of always-unused `depth=`/`&depth=`
query-string groups is converted to non-capturing in both files.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(config): name capture groups for prefer-named-capture-group

Burns down prefer-named-capture-group violations in lib/config/.
Used groups get names with replacement strings switched from $1/$2 to
$<name>; the unused separator group in schedule-migration.ts's
afterBeforeRegex becomes non-capturing. presets/parse.ts keeps
assigning through the already-declared `repo` variable rather than
array-destructuring the exec() result, matching this file's existing
style for the other named-group regexes just above it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(util): name capture groups for prefer-named-capture-group

Burns down prefer-named-capture-group violations across lib/util/ and
lib/logger/. Same treatment as previous batches: named groups for
values that are read (via $<name> replacement strings, .groups!.<name>,
or destructured from .groups), non-capturing groups where nothing reads
the captured value (e.g. semantic.ts's angular-commit .test()-only
regex). www-authenticate.ts's tokenizer entries each get their own
named group but keep accessing the match generically via match[1],
since a positionally-indexed named group is still readable by index.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(workers): name capture groups for prefer-named-capture-group

Burns down prefer-named-capture-group violations in lib/workers/.
Used groups get names with $<name> replacement strings; unused
wrapper/alternation groups (e.g. semantic-commit-message.ts's optional
scope/issue wrappers, release-notes.ts's date-heading and
horizontal-rule matchers that are only probed with .search()/replaced
wholesale) become non-capturing.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(test,tools): name capture groups for prefer-named-capture-group

Finishes the prefer-named-capture-group burndown: test/, tools/, and
vitest.config.mts. Groups whose value is read get names ($<name>
replacement strings or .groups.<name> access); groups only used via
.test()/.search() or that feed a .match(/…/g) call (whose return value
is the array of whole matches, not captured groups) become
non-capturing.

This is the last remaining slice of pre-existing violations, so the
rule (already enabled at error repo-wide) now passes with zero
findings across the whole codebase.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* fix prettier failure

* refactor(lint): use a named capture group in `v8-ignore-no-count`

New rule from main trips the newly enabled `prefer-named-capture-group` oxlint rule.

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-09-03 09:54:40 +00:00

319 lines
9.9 KiB
TypeScript

// TODO: types (#22198)
import { GlobalConfig } from '../../../config/global.ts';
import { logger } from '../../../logger/index.ts';
import { detectPlatform } from '../../../util/common.ts';
import * as hostRules from '../../../util/host-rules.ts';
import { Http } from '../../../util/http/index.ts';
import { regEx } from '../../../util/regex.ts';
import {
parseUrl,
trimLeadingSlash,
trimTrailingSlash,
} from '../../../util/url.ts';
import { BitbucketTagsDatasource } from '../bitbucket-tags/index.ts';
import { ForgejoTagsDatasource } from '../forgejo-tags/index.ts';
import { GitTagsDatasource } from '../git-tags/index.ts';
import { GiteaTagsDatasource } from '../gitea-tags/index.ts';
import { GithubTagsDatasource } from '../github-tags/index.ts';
import { GitlabTagsDatasource } from '../gitlab-tags/index.ts';
import type { DataSource } from './types.ts';
// TODO: figure out class hierarchy (#10532)
export class BaseGoDatasource {
private static readonly gitlabHttpsRegExp = regEx(
/^(?<httpsRegExpUrl>https:\/\/[^/]*gitlab\.[^/]*)\/(?<httpsRegExpName>.+?)(?:\/v\d+)?[/]?$/,
);
private static readonly gitlabRegExp = regEx(
/^(?<regExpUrl>gitlab\.[^/]*)\/(?<regExpPath>.+?)(?:\/v\d+)?[/]?$/,
);
private static readonly gitVcsRegexp = regEx(
/^(?:[^/]+)\/(?<module>.*)\.git(?:$|\/)/,
);
private static readonly id = 'go';
private static readonly http = new Http(BaseGoDatasource.id);
static async getDatasource(goModule: string): Promise<DataSource | null> {
if (goModule.startsWith('gopkg.in/')) {
const [pkg] = goModule.replace('gopkg.in/', '').split('.');
const packageName = pkg.includes('/') ? pkg : `go-${pkg}/${pkg}`;
return {
datasource: GithubTagsDatasource.id,
packageName,
registryUrl: 'https://github.com',
};
}
if (goModule.startsWith('github.com/')) {
const split = goModule.split('/');
const packageName = `${split[1]}/${split[2]}`;
return {
datasource: GithubTagsDatasource.id,
packageName,
registryUrl: 'https://github.com',
};
}
if (goModule.startsWith('bitbucket.org/')) {
const split = goModule.split('/');
const packageName = `${split[1]}/${split[2]}`;
return {
datasource: BitbucketTagsDatasource.id,
packageName,
registryUrl: 'https://bitbucket.org',
};
}
if (goModule.startsWith('code.cloudfoundry.org/')) {
const packageName = goModule.replace(
'code.cloudfoundry.org',
'cloudfoundry',
);
return {
datasource: GithubTagsDatasource.id,
packageName,
registryUrl: 'https://github.com',
};
}
if (goModule.startsWith('dev.azure.com/')) {
const split = goModule.split('/');
if ((split.length > 4 && split[3] === '_git') || split.length > 3) {
const packageName = `https://dev.azure.com/${split[1]}/${split[2]}/_git/${(split[3] === '_git' ? split[4] : split[3]).replace(regEx(/\.git$/), '')}`;
return {
datasource: GitTagsDatasource.id,
packageName,
};
}
}
//#region known gitea compatible hosts
if (goModule.startsWith('gitea.com/')) {
const split = goModule.split('/');
const packageName = `${split[1]}/${split[2]}`;
return {
datasource: GiteaTagsDatasource.id,
packageName,
registryUrl: 'https://gitea.com',
};
}
if (goModule.startsWith('code.forgejo.org/')) {
const split = goModule.split('/');
const packageName = `${split[1]}/${split[2]}`;
return {
datasource: ForgejoTagsDatasource.id,
packageName,
registryUrl: 'https://code.forgejo.org',
};
}
if (goModule.startsWith('codeberg.org/')) {
const split = goModule.split('/');
const packageName = `${split[1]}/${split[2]}`;
return {
datasource: ForgejoTagsDatasource.id,
packageName,
registryUrl: 'https://codeberg.org',
};
}
//#endregion
return await BaseGoDatasource.goGetDatasource(goModule);
}
private static async goGetDatasource(
goModule: string,
): Promise<DataSource | null> {
const goModuleUrl = goModule.replace(regEx(/\.git(?:\/[a-z0-9/]*)?$/), '');
const pkgUrl = `https://${goModuleUrl}?go-get=1`;
const { body: html } = await BaseGoDatasource.http.getText(pkgUrl);
const goSourceHeader = BaseGoDatasource.goSourceHeader(html, goModule);
if (goSourceHeader) {
return goSourceHeader;
}
// GitHub Enterprise only returns a go-import meta
const goImport = BaseGoDatasource.goImportHeader(html, goModule);
if (goImport) {
return goImport;
}
logger.trace({ goModule }, 'No go-source or go-import header found');
return null;
}
private static goSourceHeader(
html: string,
goModule: string,
): DataSource | null {
const sourceMatchGroups = regEx(
/<meta\s+name="?go-source"?\s+content="(?<prefix>[^"\s]+)\s+(?<goSourceUrl>[^"\s]+)/,
).exec(html)?.groups;
if (!sourceMatchGroups) {
return null;
}
const { prefix, goSourceUrl } = sourceMatchGroups;
if (!goModule.startsWith(prefix)) {
logger.trace({ goModule }, 'go-source header prefix not match');
return null;
}
logger.debug(`Go lookup source url ${goSourceUrl} for module ${goModule}`);
return this.detectDatasource(goSourceUrl, goModule);
}
private static detectDatasource(
metadataUrl: string,
goModule: string,
): DataSource | null {
if (metadataUrl.startsWith('https://github.com/')) {
return {
datasource: GithubTagsDatasource.id,
packageName: metadataUrl
.replace('https://github.com/', '')
.replace(regEx(/\/$/), ''),
registryUrl: 'https://github.com',
};
}
const gitlabModuleName =
BaseGoDatasource.gitlabRegExp.exec(goModule)?.groups?.regExpPath;
const vcsIndicatedModule =
BaseGoDatasource.gitVcsRegexp.exec(goModule)?.groups?.module;
const metadataUrlMatchGroups =
BaseGoDatasource.gitlabHttpsRegExp.exec(metadataUrl)?.groups;
if (metadataUrlMatchGroups) {
const { httpsRegExpUrl, httpsRegExpName } = metadataUrlMatchGroups;
let packageName = vcsIndicatedModule ?? gitlabModuleName;
// Detect submodules in monorepos by comparing metadata path and module path
if (!vcsIndicatedModule && httpsRegExpName && gitlabModuleName) {
const metadataPath = httpsRegExpName;
const modulePath = gitlabModuleName;
if (modulePath.startsWith(`${metadataPath}/`)) {
packageName = metadataPath;
}
}
// If we still don't have a package name, fall back to the metadata URL path
packageName = packageName ?? httpsRegExpName;
return {
datasource: GitlabTagsDatasource.id,
registryUrl: httpsRegExpUrl,
packageName,
};
}
if (hostRules.hostType({ url: metadataUrl }) === 'gitlab') {
const parsedUrl = parseUrl(metadataUrl);
if (!parsedUrl) {
logger.trace({ goModule }, 'Could not parse go-source URL');
return null;
}
const endpoint = GlobalConfig.get('endpoint');
const endpointPrefix = regEx(
/https:\/\/[^/]+\/(?<prefix>.*?\/)(?:api\/v4\/?)?/,
).exec(endpoint)?.groups?.prefix;
let packageName =
// a .git path indicates a concrete git repository, which can be different from metadata returned by gitlab
vcsIndicatedModule ?? trimLeadingSlash(parsedUrl.pathname);
if (endpointPrefix && endpointPrefix !== 'api/') {
packageName = packageName.replace(endpointPrefix, '');
}
const registryUrl = endpointPrefix
? endpoint.replace(regEx(/\/api\/v4\/?$/), '/')
: `${parsedUrl.protocol}//${parsedUrl.host}`;
return {
datasource: GitlabTagsDatasource.id,
registryUrl,
packageName,
};
}
/* istanbul ignore next */
return null;
}
private static goImportHeader(
html: string,
goModule: string,
): DataSource | null {
const importMatchGroups = regEx(
/<meta\s+name="?go-import"?\s+content="(?<prefix>[^"\s]+)\s+(?<proto>[^"\s]+)\s+(?<goImportURL>[^"\s]+)/,
).exec(html)?.groups;
if (!importMatchGroups) {
logger.trace({ goModule }, 'No go-source or go-import header found');
return null;
}
const { prefix, proto, goImportURL } = importMatchGroups;
if (!goModule.startsWith(prefix)) {
logger.trace({ goModule }, 'go-import header prefix not match');
return null;
}
if (proto !== 'git') {
logger.trace({ goModule }, 'go-import header proto not git');
return null;
}
// get server base url from import url
const parsedUrl = parseUrl(goImportURL);
if (!parsedUrl) {
logger.trace({ goModule }, 'Could not parse go-import URL');
return null;
}
logger.debug(`Go module: ${goModule} lookup import url ${goImportURL}`);
const datasource = this.detectDatasource(
goImportURL.replace(regEx(/\.git$/), ''),
goModule,
);
if (datasource !== null) {
return datasource;
}
// fall back to old behavior if detection did not work
switch (detectPlatform(goImportURL)) {
case 'github': {
// split the go module from the URL: host/go/module -> go/module
// TODO: `parsedUrl.pathname` can be undefined
const packageName = trimTrailingSlash(`${parsedUrl.pathname}`)
.replace(regEx(/\.git$/), '')
.split('/')
.slice(-2)
.join('/');
return {
datasource: GithubTagsDatasource.id,
registryUrl: `${parsedUrl.protocol}//${parsedUrl.host}`,
packageName,
};
}
case 'azure': {
return {
datasource: GitTagsDatasource.id,
packageName: goImportURL.replace(regEx(/\.git$/), ''),
};
}
default: {
return {
datasource: GitTagsDatasource.id,
packageName: goImportURL,
};
}
}
}
}