mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-01 18:19:51 +00:00
3412de84ce
* refactor(lint): enable oxlint prefer-named-capture-group at error Numbered capture groups (m[1], $1) break silently when a regex is edited and group order shifts. Named groups (?<name>...) make intent explicit and accesses (m.groups.name) resilient to reordering. This enables the built-in eslint rule prefer-named-capture-group, surfacing 321 pre-existing unnamed-group violations across ~121 files to be burned down incrementally in follow-up commits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(versioning): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations in lib/modules/versioning/. Unused capture groups (only reachable via .test() or whole-match) become non-capturing (?:...); groups whose value is read become named (?<name>...), with accesses rewritten to match.groups!.<name> (or destructured from .groups!) instead of positional match[n]/$n so a future edit that reorders groups cannot silently break the reader. Two cases needed extra care to preserve behavior: - semver/common.ts and poetry/patterns.ts split() on a regex whose capture group is relied upon by String.prototype.split to keep the separator in the output array; the group is kept capturing and named, not converted to non-capturing. - hashicorp/convertor.ts's semverRegex is only ever embedded via .source into a named `(?<version>...)` group elsewhere and never matched directly, so its internal groups are safe to make non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(datasource): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations under lib/modules/datasource/. Same treatment as the versioning module: unused groups become non-capturing, used groups get names, and positional match[n] reads move to match.groups!.<name>. docker/ecr.ts and pypi/common.ts keep their positional destructuring (`const [, region] = ...`, `!!m &&`) working unchanged since a named capture group is still addressable by its numeric index in JavaScript — only pypi/common.ts's access was rewritten to m.groups!.owner for clarity since it read a single group directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(platform): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations under lib/modules/platform/. Uses the repo's established idiom of `match.groups?.<name>` after an optional-chained exec()/match() (see bitbucket/index.ts hostnameWithoutApiPrefix, gerrit/utils.ts extractSourceBranch) and `$<name>` in String.replace replacement strings. Unused groups (markdown/HTML massaging regexes matched only to be stripped) become non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups in ansible-galaxy for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/modules/manager/ansible-galaxy/. newBlockRegEx and blockLineRegEx dropped their unused outer wrapping group (only the inner key/value groups were ever read) and named the key/value groups; nameMatchRegex's remaining unused groups (protocol/user-info/port alternatives) become non-capturing since only source/hostname/depName/version are read via .groups. Accesses in collections.ts and roles.ts move from lineMatch[2]/lineMatch[3] to lineMatch.groups!.key/value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups for prefer-named-capture-group (batch 1) Burns down prefer-named-capture-group violations across the first alphabetical slice of lib/modules/manager/ (ansible through mix). Used groups get names with accesses rewritten to match.groups!.<name> (or $<name> in replacement strings); groups whose value is never read become non-capturing (?:...). Two String.split() call sites (git-submodules/extract.ts, meteor/extract.ts) keep the established "named group still readable positionally from the split() result array" idiom instead of restructuring the destructuring. bazel/rules/go.ts and buildpacks/extract.ts dockerRef verified byte-for-byte equivalent before/after via a quick node script since several nested groups collapsed to non-capturing at once. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups for prefer-named-capture-group (batch 2) Burns down prefer-named-capture-group violations across the remaining alphabetical slice of lib/modules/manager/ (npm through terragrunt). Same treatment as batch 1: used groups get names with accesses moved to match.groups!.<name> or $<name> replacement strings; unused groups (wrapping alternations, quantifier repetition groups only consumed via .test(), or values never read from a match) become non-capturing. terraform/extractors/others/modules.ts and terragrunt/modules.ts share near-identical URL-parsing regexes (github/bitbucket/git/azure-devops ref matchers) — the same set of always-unused `depth=`/`&depth=` query-string groups is converted to non-capturing in both files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(config): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/config/. Used groups get names with replacement strings switched from $1/$2 to $<name>; the unused separator group in schedule-migration.ts's afterBeforeRegex becomes non-capturing. presets/parse.ts keeps assigning through the already-declared `repo` variable rather than array-destructuring the exec() result, matching this file's existing style for the other named-group regexes just above it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(util): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations across lib/util/ and lib/logger/. Same treatment as previous batches: named groups for values that are read (via $<name> replacement strings, .groups!.<name>, or destructured from .groups), non-capturing groups where nothing reads the captured value (e.g. semantic.ts's angular-commit .test()-only regex). www-authenticate.ts's tokenizer entries each get their own named group but keep accessing the match generically via match[1], since a positionally-indexed named group is still readable by index. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(workers): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/workers/. Used groups get names with $<name> replacement strings; unused wrapper/alternation groups (e.g. semantic-commit-message.ts's optional scope/issue wrappers, release-notes.ts's date-heading and horizontal-rule matchers that are only probed with .search()/replaced wholesale) become non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(test,tools): name capture groups for prefer-named-capture-group Finishes the prefer-named-capture-group burndown: test/, tools/, and vitest.config.mts. Groups whose value is read get names ($<name> replacement strings or .groups.<name> access); groups only used via .test()/.search() or that feed a .match(/…/g) call (whose return value is the array of whole matches, not captured groups) become non-capturing. This is the last remaining slice of pre-existing violations, so the rule (already enabled at error repo-wide) now passes with zero findings across the whole codebase. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * fix prettier failure * refactor(lint): use a named capture group in `v8-ignore-no-count` New rule from main trips the newly enabled `prefer-named-capture-group` oxlint rule. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
222 lines
4.9 KiB
TypeScript
222 lines
4.9 KiB
TypeScript
import { Version, VersionSpec } from '@baszalmstra/rattler';
|
|
import type { SemVer } from 'semver';
|
|
|
|
import type { RangeStrategy } from '../../../types/versioning.ts';
|
|
import { regEx } from '../../../util/regex.ts';
|
|
import * as pep440 from '../pep440/index.ts';
|
|
import type { NewValueConfig, VersioningApi } from '../types.ts';
|
|
|
|
function parse(v: string): Version | null {
|
|
try {
|
|
return new Version(v);
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
export const id = 'conda';
|
|
export const displayName = 'conda';
|
|
export const urls = [
|
|
'[Conda package match specifications](https://docs.conda.io/projects/conda-build/en/stable/resources/package-spec.html#package-match-specifications)',
|
|
];
|
|
export const supportsRanges = true;
|
|
export const supportedRangeStrategies: RangeStrategy[] = [
|
|
'bump',
|
|
'widen',
|
|
'replace',
|
|
];
|
|
|
|
function isValidVersion(s: string): boolean {
|
|
try {
|
|
new Version(s);
|
|
return true;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
function isValidVersionSpec(s: string): boolean {
|
|
try {
|
|
new VersionSpec(s);
|
|
return true;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
function isValid(input: string): boolean {
|
|
return isValidVersion(input) || isValidVersionSpec(input);
|
|
}
|
|
|
|
function matches(version: string, range: string): boolean {
|
|
try {
|
|
return new VersionSpec(range).matches(new Version(version));
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
function isSingleVersion(input: string): boolean {
|
|
if (!input.startsWith('=')) {
|
|
return false;
|
|
}
|
|
|
|
return isValidVersion(input.replace(regEx(/^==/), '').trimStart());
|
|
}
|
|
|
|
function getPinnedValue(newVersion: string): string {
|
|
return `==${newVersion}`;
|
|
}
|
|
|
|
function getNewValue({
|
|
currentValue,
|
|
rangeStrategy,
|
|
currentVersion,
|
|
newVersion,
|
|
isReplacement,
|
|
}: NewValueConfig): string | null {
|
|
if (currentValue === '*') {
|
|
if (rangeStrategy === 'bump') {
|
|
return `>=${newVersion}`;
|
|
}
|
|
|
|
// don't think you can widen or replace `*`
|
|
return null;
|
|
}
|
|
|
|
const normalizedCurrentValue = new VersionSpec(currentValue).toString();
|
|
|
|
// it's valid range spec in conda to write `3.12.*`, translate to pep440 `==3.12.*`
|
|
if (regEx(/^(?:\d+\.)+\*$/).test(normalizedCurrentValue)) {
|
|
const newValue = pep440.api.getNewValue({
|
|
currentValue: `==${normalizedCurrentValue}`,
|
|
rangeStrategy,
|
|
currentVersion,
|
|
newVersion,
|
|
isReplacement,
|
|
});
|
|
|
|
return newValue?.replace(regEx(/^==/), '') ?? null;
|
|
}
|
|
|
|
return pep440.api.getNewValue({
|
|
currentValue: normalizedCurrentValue,
|
|
rangeStrategy,
|
|
currentVersion,
|
|
newVersion,
|
|
isReplacement,
|
|
});
|
|
}
|
|
|
|
function sortVersions(version: string, other: string): number {
|
|
return new Version(version).compare(new Version(other));
|
|
}
|
|
|
|
function equals(version: string, other: string): boolean {
|
|
const v2 = parse(other);
|
|
if (!v2) {
|
|
return false;
|
|
}
|
|
|
|
return parse(version)?.equals(v2) ?? false;
|
|
}
|
|
|
|
function isStable(version: string): boolean {
|
|
return !(parse(version)?.isDev ?? true);
|
|
}
|
|
|
|
function isCompatible(_version: string, _current?: string): boolean {
|
|
return true;
|
|
}
|
|
|
|
function getMajor(version: string | SemVer): null | number {
|
|
return parse(version as string)?.asMajorMinor?.()?.[0] ?? null;
|
|
}
|
|
function getMinor(version: string | SemVer): null | number {
|
|
return parse(version as string)?.asMajorMinor?.()?.[1] ?? null;
|
|
}
|
|
|
|
function getPatch(version: string | SemVer): null | number {
|
|
try {
|
|
return pep440.api.getPatch(version);
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
function isGreaterThan(version: string, other: string): boolean {
|
|
return sortVersions(version, other) > 0;
|
|
}
|
|
function getSatisfyingVersion(
|
|
versions: string[],
|
|
range: string,
|
|
): string | null {
|
|
const spec = new VersionSpec(range);
|
|
|
|
const satisfiedVersions = versions
|
|
.map((v) => {
|
|
return [new Version(v), v] as const;
|
|
})
|
|
.filter(([v, _raw]) => spec.matches(v))
|
|
.sort((a, b) => {
|
|
return a[0].compare(b[0]);
|
|
});
|
|
|
|
if (satisfiedVersions.length === 0) {
|
|
return null;
|
|
}
|
|
|
|
return satisfiedVersions.at(-1)![1];
|
|
}
|
|
|
|
function minSatisfyingVersion(
|
|
versions: string[],
|
|
range: string,
|
|
): string | null {
|
|
const spec = new VersionSpec(range);
|
|
|
|
const satisfiedVersions = versions
|
|
.map((v) => {
|
|
return [new Version(v), v] as const;
|
|
})
|
|
.filter(([v, _raw]) => spec.matches(v))
|
|
.sort((a, b) => {
|
|
return a[0].compare(b[0]);
|
|
});
|
|
|
|
if (satisfiedVersions.length === 0) {
|
|
return null;
|
|
}
|
|
|
|
return satisfiedVersions[0][1];
|
|
}
|
|
|
|
export const api = {
|
|
equals,
|
|
isValid,
|
|
isVersion: isValidVersion,
|
|
isSingleVersion,
|
|
|
|
// conda doesn't have stable version and non-stable version
|
|
// for example, tzdata has version 2024a but it's stable
|
|
isStable,
|
|
|
|
// conda use version are always compatible with each other.
|
|
isCompatible,
|
|
|
|
getMajor,
|
|
getMinor,
|
|
// sadly conda version doesn't have a concept of patch version
|
|
// so we try to use pep440 get a patch version.
|
|
getPatch,
|
|
|
|
isGreaterThan,
|
|
getSatisfyingVersion,
|
|
|
|
minSatisfyingVersion,
|
|
getNewValue,
|
|
getPinnedValue,
|
|
matches,
|
|
sortVersions,
|
|
} satisfies VersioningApi;
|