mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-01 18:19:51 +00:00
e0cec3dc95
feat(lint): add `types-location` rule and enable it for `lib/modules`
Reviewers consistently ask for exported types to be moved into a
colocated `types.ts`. Add a `renovate/types-location` oxlint rule that
reports `export interface` / `export type` declarations outside such a
file, and turn it on across `lib/modules`.
Re-exports (`export type { X }`, `export type *`), file-local types, and
values (enums, classes, functions) are left alone. `schema.ts` files and
`schema/` directories are excluded via config, matching how
`zod-schema-location` is configured — inferred types belong next to the
schema they are derived from.
Relocating the 87 existing violations means:
- new `types.ts` files for the modules that had none
- `terragrunt/common.ts` folded into its `types.ts`, as it held nothing
else
- `RangeBound` in `versioning/gradle/compare.ts` un-exported, since only
a file-local interface referenced it
- `bazel-module/parser/fragments.ts` split from its inferred types, which
now live in `parser/types.ts` and infer through a namespace import so
each schema keeps its merged name
107 lines
3.2 KiB
TypeScript
107 lines
3.2 KiB
TypeScript
import { logger } from '../../../logger/index.ts';
|
|
import { withCache } from '../../../util/cache/package/with-cache.ts';
|
|
import { asTimestamp } from '../../../util/timestamp.ts';
|
|
import * as rustVersioning from '../../versioning/rust-release-channel/index.ts';
|
|
import { Datasource } from '../datasource.ts';
|
|
import type { GetReleasesConfig, ReleaseResult } from '../types.ts';
|
|
import { parseManifestUrl } from './parse.ts';
|
|
import type { ParsedManifestUrl } from './types.ts';
|
|
|
|
export class RustVersionDatasource extends Datasource {
|
|
static readonly id = 'rust-version';
|
|
|
|
override readonly customRegistrySupport = false;
|
|
|
|
override readonly defaultRegistryUrls = ['https://static.rust-lang.org'];
|
|
|
|
override readonly defaultVersioning = rustVersioning.id;
|
|
|
|
override readonly releaseTimestampSupport = true;
|
|
override readonly releaseTimestampNote =
|
|
'The release timestamp is parsed from the release manifest URL.';
|
|
|
|
override readonly sourceUrlSupport = 'package';
|
|
|
|
override readonly caching = true;
|
|
|
|
constructor() {
|
|
super(RustVersionDatasource.id);
|
|
}
|
|
|
|
private async getManifests(url: URL): Promise<ParsedManifestUrl[]> {
|
|
const response = await this.http.getText(url);
|
|
const lines = response.body.split('\n');
|
|
|
|
const parsedResults = [];
|
|
for (const line of lines) {
|
|
// skip trailing empty element from .split('\n') upstream
|
|
if (!line.trim()) {
|
|
continue;
|
|
}
|
|
const parsed = parseManifestUrl(line);
|
|
if (parsed) {
|
|
parsedResults.push(parsed);
|
|
} else {
|
|
logger.warn({ line }, 'Failed to parse manifest URL');
|
|
}
|
|
}
|
|
|
|
return parsedResults;
|
|
}
|
|
|
|
async _getReleases({
|
|
registryUrl,
|
|
}: GetReleasesConfig): Promise<ReleaseResult | null> {
|
|
const url = new URL('manifests.txt', registryUrl);
|
|
|
|
let parsedResults: ParsedManifestUrl[];
|
|
try {
|
|
parsedResults = await this.getManifests(url);
|
|
} catch (err) {
|
|
this.handleGenericErrors(err);
|
|
}
|
|
|
|
// Filter out dated stable and beta channel releases
|
|
// (not supported by the `rust-release-channel` versioning)
|
|
const filteredResults = parsedResults.filter(
|
|
(result) => result.version !== 'stable' && result.version !== 'beta',
|
|
);
|
|
|
|
// Transform to version strings and deduplicate
|
|
const versionMap = new Map<string, string>();
|
|
for (const parsed of filteredResults) {
|
|
const version =
|
|
parsed.version === 'nightly'
|
|
? `nightly-${parsed.date}`
|
|
: parsed.version;
|
|
|
|
// Keep latest date for each version
|
|
versionMap.set(version, parsed.date);
|
|
}
|
|
|
|
const releaseResult: ReleaseResult = {
|
|
releases: [],
|
|
homepage: 'https://rust-lang.org/',
|
|
sourceUrl: 'https://github.com/rust-lang/rust',
|
|
changelogUrl: 'https://github.com/rust-lang/rust/blob/main/RELEASES.md',
|
|
};
|
|
|
|
for (const [version, date] of versionMap.entries()) {
|
|
const releaseTimestamp = asTimestamp(date);
|
|
releaseResult.releases.push({ version, releaseTimestamp });
|
|
}
|
|
|
|
return releaseResult;
|
|
}
|
|
|
|
getReleases(config: GetReleasesConfig): Promise<ReleaseResult | null> {
|
|
return withCache(
|
|
{
|
|
namespace: `datasource-${RustVersionDatasource.id}`,
|
|
key: config.registryUrl!,
|
|
},
|
|
() => this._getReleases(config),
|
|
);
|
|
}
|
|
}
|