mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-02 10:33:39 +00:00
Sebastian Poxhofer
97327c3d28
* refactor(linters): add prefer-coerce-array rule Refs #45217 `x ?? []` and `coerceArray(x)` say the same thing, but only the second one is searchable and consistent. The rule flags a `??` whose default is a bare `[]` literal; a non-empty default or an asserted `([] as Foo[])` still passes. Applying it across `lib/` surfaced three spots the helper cannot cover, which keep `?? []` with a disable comment or a narrower fix: - `package-files.ts` destructures a tuple, which `coerceArray()` widens - `generate.spec.ts` defaults `matchAll()`, an iterator rather than an array - `mise/upgradeable-tooling.ts` declares a `Record` return, so its `?? []` fallback was wrong to begin with and becomes `coerceObject()` * refactor(platform/github): hoist the GHE version header lookup `Object.entries(...).find()` returns a tuple, and defaulting it with `?? []` only to destructure the second element reads as an array default when it is not one. Name the found entry instead, which drops the `?? []` rather than routing a tuple through `coerceArray()`.
24 lines
689 B
TypeScript
24 lines
689 B
TypeScript
import { z } from 'zod/v4';
|
|
import { coerceArray } from '../../../util/array.ts';
|
|
|
|
export const BicepResourceVersionIndex = z
|
|
.object({
|
|
resources: z.record(z.string(), z.unknown()),
|
|
})
|
|
.transform(({ resources }) => {
|
|
const releaseMap = new Map<string, string[]>();
|
|
|
|
for (const resourceReference of Object.keys(resources)) {
|
|
const [type, version] = resourceReference.toLowerCase().split('@', 2);
|
|
const versions = coerceArray(releaseMap.get(type));
|
|
versions.push(version);
|
|
releaseMap.set(type, versions);
|
|
}
|
|
|
|
return Object.fromEntries(releaseMap);
|
|
});
|
|
|
|
export type BicepResourceVersionIndex = z.infer<
|
|
typeof BicepResourceVersionIndex
|
|
>;
|