mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-10-23 20:25:56 +00:00
rcourtman
92d946d057
With one vCenter, which most installs have, the vSphere hosts, health-signal and activity tables repeated its name on every row. The column told the user nothing and took room from the signal and activity text. On a phone, the health-signal table spent 66px on a clipped "Lab vC…". **What changes** - **When the column shows.** It appears only when the page's vSphere inventory spans more than one vCenter connection, and the header and cell drop together. - **How connections are counted.** From the page's whole vSphere inventory, never from the rows a search leaves. On Overview that includes the datastores and networks its health signals cover. A resource without a connection ID is matched to its connection by name or host, so one vCenter is never counted twice. - **Nothing lost.** Every row drawer still names the vCenter. - **Hosts table.** It now reads the connection name, as the other two tables do, instead of the raw vCenter host, which moves to the hover text. **Verification** - **One vCenter (the mock), live:** the column is gone from the Overview signals and hosts, the Health tab and Activity, and the Activity drawer still names the vCenter. - **Two vCenters:** I rewrote the resource API responses in the browser with the websocket held, which moved the Edge DC inventory to an "Edge vCenter" connection. The column returns with "Lab vCenter" and "Edge vCenter". - **Clip sweep against the pre-change run:** the health-signal table clips less at every narrow width. At 390px, Signal overflows by 92px instead of 116 and Started by 15px instead of 31. At 768px, Started overflows by 12px instead of 29. Activity gains about 50px for its sentences at 1440. - **Tests:** 1,811 frontend tests pass, including new single- and multi-vCenter tests for each table and for the connection count. - **Review:** a second reviewer found three issues: - Overview counting only hosts and VMs: fixed. - One vCenter counted twice when a resource had its name but not its ID: fixed. - An open drawer keeping the old column span if a vCenter is added or removed while it is open: left alone. It needs a change to the shared drawer-row component, which only re-measures on mount and resize, and the trigger is rare.