mirror of
https://github.com/rcourtman/Pulse.git
synced 2026-09-10 10:35:51 +00:00
rcourtman
72eaab444f
Schema v6 shipped audit_logging_persistent and audit_events_30d as Pro adoption signals. Neither discriminated. pkg/server installs the SQLite audit logger on every install for defense in depth and gates only the read/export endpoints, so the boolean was true on all 8 installs that had taken rc.8 and 0 rows in the retained table have ever had it false. The event count measured that background write volume: three of those eight unlicensed community installs were pegged at the receiver's 100000 clamp ceiling, with the rest between 4863 and 67509. Schema v7 replaces both with audit_reads_30d, a count of requests that cleared the license gate on an audit read or export surface. A read requires a human action, so unlike store presence or write volume it cannot settle into a constant. The recorder is wrapped INSIDE RequireLicenseFeature so unentitled requests never count, and the persisted marker carries a timestamp and a coarse activity class from a fixed allowlist. Query filters, actors, ranges, and every audit row read stay on the install. The retired columns are left in the live database. They hold real rc.8 rows and migrations only add, so dropping them would be a pointless risk; nothing writes them once the receiver struct loses the fields. Adds the guard this class needed. LicensedFeatureAdoptionFields registers every field that exists to measure licensed-feature adoption, and TestLicensedFeatureAdoptionFieldsDiscriminate builds an unused install through the real production snapshot paths, installs a real SQLite audit logger exactly as pkg/server does, records a baseline audit event, and fails if any registered field is non-zero. Pinning a console logger there would have made the guard pass while the payload lied, so it deliberately does not. The guard was verified by reintroducing the v6 sourcing and confirming it fails with the field named. A companion test pins the three retired fields so they cannot return under their old names. This is the third instance of one bug class. v6 removed pulse_intelligence_patrol_autofixes_30d, hardcoded to zero with no increment site, and then introduced two fields that were constant in the other direction. Three occurrences is a guard, not a habit. Verified end to end on a running unlicensed install: the payload that reported audit_logging_persistent true under v6 now reports audit_reads_30d 0, and seeding two in-window reads, one outside the window, and one with an invalid activity class yields 2.
44 lines
1.6 KiB
Go
44 lines
1.6 KiB
Go
package server
|
|
|
|
import (
|
|
"time"
|
|
|
|
"github.com/rcourtman/pulse-go-rewrite/internal/config"
|
|
"github.com/rcourtman/pulse-go-rewrite/internal/telemetry"
|
|
)
|
|
|
|
// applyLicensedFeatureConfigSnapshot adds content-free adoption counts for
|
|
// licensed features whose state lives in persisted config files.
|
|
//
|
|
// Counts only. Schedule names, delivery recipients, report scope, and profile
|
|
// names all stay on the install; the aggregate answers "how many are
|
|
// configured and how many ran", nothing about what they contain.
|
|
func applyLicensedFeatureConfigSnapshot(snap *telemetry.Snapshot, persistence *config.ConfigPersistence, now time.Time) {
|
|
if snap == nil || persistence == nil {
|
|
return
|
|
}
|
|
|
|
if store, err := persistence.LoadReportScheduleStore(); err == nil && store != nil {
|
|
since := now.Add(-telemetry.PulseIntelligenceTelemetryWindow)
|
|
for _, schedule := range store.Schedules {
|
|
snap.ReportSchedules++
|
|
if schedule.Enabled {
|
|
snap.ReportSchedulesEnabled++
|
|
}
|
|
if schedule.LastRunAt != nil && schedule.LastRunAt.After(since) {
|
|
snap.ReportSchedulesRun30d++
|
|
}
|
|
}
|
|
}
|
|
|
|
if profiles, err := persistence.LoadAgentProfiles(); err == nil {
|
|
snap.AgentProfiles = len(profiles)
|
|
}
|
|
|
|
// Audit adoption is a read count, not store presence: the SQLite audit
|
|
// logger is installed on every install for defense in depth, so only an
|
|
// operator reaching a license-gated read surface distinguishes an install
|
|
// that uses audit logging from one that merely has it.
|
|
snap.AuditReads30d = persistence.CountAuditReadActivitySince(now.Add(-telemetry.PulseIntelligenceTelemetryWindow))
|
|
}
|