Commit Graph

829 Commits

Author SHA1 Message Date
Pulse Monitor 33bfb27f9a enhance: improve mock data realism and alert system
- Add dynamic metric fluctuations for VMs and containers in mock data
- Fix alert acknowledgment to dim instead of hide alerts
- Implement unacknowledge functionality with backend persistence
- Simplify alert UI to single-click toggle (remove selection system)
- Add proper hysteresis for alert resolution when metrics drop
- Fix SVG icon boundaries in alert displays
- Add webhook disable toggles for testing without notifications
- Fix frontend directory duplication issue (addresses frontend-modern recreation)
- Improve alert sorting to show most recent first
- Make mock system generate realistic metric changes for proper alert lifecycle
2025-09-02 21:11:01 +00:00
Pulse Monitor 1812cd0375 improve: show node name with storage when grouped by storage
- removes redundant Node column from storage table
- when grouped by storage, shows node name in gray next to storage name
- when grouped by node, node name already shown in group header
- addresses confusion when multiple nodes have same storage names
2025-09-02 08:44:50 +00:00
Pulse Monitor 1a3489568a improve: enhance mobile responsiveness for Settings and Guest URLs pages
- Fix button overflow on Settings page by making layouts responsive
- Add responsive text sizing and button compacting for mobile
- Make Guest URLs input fields wider (300px min) with horizontal scroll
- Improve tab navigation scrolling on mobile devices
- Better utilize screen space on small devices
2025-09-02 07:33:29 +00:00
Pulse Monitor 58d4c4b6c8 docs: update CLAUDE.md with development notes 2025-09-01 22:59:32 +00:00
Pulse Monitor f19c7ea8f9 fix: increase API timeout to prevent deadline exceeded errors (addresses #408)
- Increased default HTTP client timeout from 30s to 60s
- Added CreateHTTPClientWithTimeout function to properly set custom timeouts
- Updated Proxmox and PBS clients to use configured timeout values
- Increased default connection timeout from 45s to 60s in config

This prevents "context deadline exceeded" errors when connecting to slow or overloaded Proxmox/PBS nodes.
2025-09-01 22:59:32 +00:00
Pulse Monitor 15a9158d58 docs: remove ProxmoxVE Helper Script references
The ProxmoxVE Helper Script is no longer the recommended installation method.
Users should use the official install.sh script instead, which supports
creating LXC containers directly on Proxmox hosts.

For existing users confused about updating (like in discussion #407), they
can use 'pct enter' from the Proxmox host to access their container as root.
2025-09-01 22:59:32 +00:00
Pulse Monitor 92ba0d334e fix: improve binary replacement reliability during updates (addresses #406)
- Add backup/restore mechanism for old binary during updates
- Add explicit error checking for binary copy operations
- Add version verification after installation to detect issues
- Force retry if version mismatch detected after update
- Ensure old binary is properly replaced, not just overwritten

This should resolve issues where updates appear to complete but the old version continues to run, particularly when the binary replacement fails silently.
2025-09-01 22:59:32 +00:00
Pulse Monitor 40351a3e95 docs: add Gotify and ntfy webhook documentation
- added complete setup instructions for Gotify webhooks
- added complete setup instructions for ntfy webhooks
- updated Telegram docs to reflect simplified template-based setup
- clarified that Pulse sends rich formatted notifications automatically
2025-09-01 22:59:32 +00:00
Pulse Monitor 7720f5e595 enhance: make Gotify and ntfy notifications as rich as Discord/Telegram
- added color-coded emoji indicators (🔴/🟡/🟢) for alert levels
- enriched message formatting with better structure and emojis
- improved titles to show resource name and alert type clearly
- ntfy now has dynamic headers for priority and tags based on alert level
- both services now match the detail level of Discord and Telegram
2025-09-01 22:59:32 +00:00
Pulse Monitor 7bf1c8a665 improve: enhance Gotify notification details and add ntfy to UI (addresses #228)
- improved Gotify template to include resource name and node in message body
- changed title to show resource name instead of generic "Pulse Alert"
- added ntfy service option to frontend webhook configuration UI
- ntfy template was already in backend but missing from frontend selection
2025-09-01 22:59:32 +00:00
Pulse Monitor 9554a8a19a fix: clarify update settings to indicate manual installation required (addresses #404)
The "Auto-Update" setting was misleading users into thinking Pulse would automatically install updates. Changed the UI text to clarify that:
- The setting only controls automatic checking for updates
- Installation is always manual based on deployment type (ProxmoxVE users type 'update', Docker users pull new image, etc.)
- This is by design for security reasons as documented in CLAUDE.md
2025-09-01 22:59:32 +00:00
Pulse Monitor d97cb6cce7 chore: remove temporary auth override used for testing 2025-09-01 22:59:32 +00:00
Pulse Monitor 22953a0747 fix: change password submit button not working (addresses #396)
- Changed button type from 'button' to 'submit' so it actually submits the form
- This was the root cause - the button looked clickable but had no onClick handler
- Now the form properly submits when clicking Change Password
2025-09-01 22:59:32 +00:00
Pulse Monitor 794e97d7bb fix: change password button not responding to clicks (addresses #396)
- Fixed condition for showing authentication section to include configured state
- Added proper event handling with preventDefault and stopPropagation
- Increased z-index of modal to ensure it appears above other elements
- Added debug logging to help diagnose issues
- Button now works when authentication is configured but not fully loaded
2025-09-01 22:59:32 +00:00
Pulse Monitor effa640fda feat: improve VM disk stats handling and documentation
- Add DiskStatusReason field to track why disk stats are unavailable
- Show helpful tooltips in UI explaining specific issues:
  - Proxmox 9 API token limitation (401 on guest agent endpoints)
  - Guest agent not installed/running
  - Special filesystems only (Live ISOs)
  - Permission issues
- Add comprehensive troubleshooting guide (docs/VM_DISK_STATS_TROUBLESHOOTING.md)
- Document that API tokens cannot access guest agent data on PVE 9
- Tested and confirmed: only password/cookie auth works for guest agent on PVE 9
- Update README with quick reference to VM disk stats issue

This addresses issues #348, #367, and #71 by clearly explaining the root cause
(Proxmox API limitation) and providing actionable guidance to users.
2025-09-01 10:16:02 +00:00
Pulse Monitor 96fa8e839a fix: improve node disk stats reliability when GetNodeStatus fails (addresses #402)
- Ensure disk metrics from /nodes endpoint are preserved when GetNodeStatus fails
- Add better fallback logic to prevent showing 0% or '-' for disk usage
- Improve logging to distinguish between rootfs and /nodes endpoint metrics
- Handle cases where neither rootfs nor valid node disk data is available

This fixes the regression introduced in v4.12.1 where disk stats would show as
'-' when GetNodeStatus failed due to network issues or rate limiting
2025-08-31 22:43:32 +00:00
Pulse Monitor 762277e361 chore: bump version to v4.12.1 2025-08-31 21:29:25 +00:00
Pulse Monitor be88faa9e0 fix: improve install script reliability in unprivileged containers (addresses #386)
- Add timeout command wrapper around all curl calls to prevent hanging
- Add multiple fallback mechanisms for GitHub API failures
- Use fallback to known stable version if all methods fail
- Add proper timeouts to prevent indefinite waiting
- Improve error handling to proceed when version verification fails

The script now handles network issues, rate limiting, and container
restrictions more gracefully, ensuring installation completes even
in restricted environments.
2025-08-31 20:34:09 +00:00
Pulse Monitor d0f20fc8cb docs: improve Telegram webhook documentation formatting
- Add proper JSON code block formatting for the template
- Keep all improvements from PR #401 by @rschoell
- Ensure consistent formatting throughout the document
2025-08-31 20:23:02 +00:00
Pulse Monitor 428b40d6d2 docs: update Telegram webhook configuration instructions (addresses #305)
- Remove chat_id from URL (should be in JSON payload)
- Add requirement to select 'Telegram Bot' service type
- Include custom payload template example
- Clarify that chat_id goes in the JSON body, not URL params
2025-08-31 20:22:37 +00:00
rcourtman 5f9614c203 Merge pull request #401 from rschoell/patch-1
Update WEBHOOKS.md
2025-08-31 21:22:26 +01:00
surfer2100 6cef3b9fdf Update WEBHOOKS.md
Relevant to #305
2025-08-31 21:26:58 +02:00
Pulse Monitor 6966cc3d3b fix: storage tab showing empty due to incorrect filtering of cluster storage
- Removed incorrect check that was skipping storage with Enabled==0 at cluster level
- Storage can be enabled at node level even if cluster config shows Enabled==0
- Now properly displays all storage and sets enabled/active flags for UI display
2025-08-31 19:01:36 +00:00
Pulse Monitor 634e0dd372 feat: implement parallel node polling for improved performance at scale (addresses #398)
- Added goroutine-based parallel fetching for VMs, containers, and storage across nodes
- Each node is now polled concurrently instead of sequentially
- Added detailed performance logging showing duration and success/failure counts
- Should significantly improve performance for deployments with 10+ nodes
- Maintains backwards compatibility with existing error handling and retry logic
2025-08-31 18:54:15 +00:00
Pulse Monitor e36e3cd380 fix: remove unused index parameter in Settings component 2025-08-31 18:15:18 +00:00
Pulse Monitor 1899e28e3a chore: bump version to v4.12.0 2025-08-31 18:13:10 +00:00
Pulse Monitor 345eca3750 fix: update sanitize function to handle new diagnostic fields
- Sanitize storage data (names, nodes)
- Sanitize backup information (PVE tasks, storage backups, PBS backups)
- Sanitize active alerts (node names, IP addresses in details)
- Ensure all sensitive information is properly redacted for GitHub sharing
2025-08-31 18:09:03 +00:00
Pulse Monitor 9a3c18245b improve: enhanced diagnostics export with comprehensive storage and backup information
- Added detailed storage information including type, status, content, and usage
- Added backup counts for PVE backup tasks, storage backups, and PBS backups
- Included sample backup data (first 10 entries) for debugging
- Added connection health status for all nodes
- Included performance metrics and API call statistics
- Added active alerts to help diagnose issues
- Shows whether each storage has backups associated with it
2025-08-31 18:06:28 +00:00
Pulse Monitor 248394d77e fix: tag indicators now only show for guests that actually have tags
- Added ToFrontend() method to StateSnapshot for proper data conversion
- Modified /api/state endpoint to use frontend-formatted data
- Enhanced WebSocket store to handle tag data transformation consistently
- Ensures tags are properly converted between backend strings and frontend arrays
2025-08-31 18:01:47 +00:00
Pulse Monitor 520b85c49c fix: prevent mock mode from wiping production node configuration
Mock mode was inadvertently clearing real node configuration when toggling.
Added protection to prevent SaveNodesConfig from modifying nodes.enc when
in mock mode. Mock and production data are now completely separated.
2025-08-31 16:48:52 +00:00
Pulse Monitor 12fbc12639 fix: properly handle alert IDs with special characters in acknowledge/clear endpoints (addresses #380)
Alert IDs like 'pve1:qemu/101-cpu' contain slashes which were breaking the URL path parsing.
Fixed by finding the /acknowledge or /clear suffix and extracting everything before it,
rather than trying to split by slashes.
2025-08-31 16:24:08 +00:00
Pulse Monitor 50c2506d9e fix: alert acknowledgement URL parsing (addresses #380)
The acknowledge and clear alert endpoints were incorrectly parsing the alert ID from the URL path, causing 404 errors. Fixed the path extraction logic to properly handle the /api/alerts/{id}/acknowledge pattern.
2025-08-31 16:16:36 +00:00
Pulse Monitor 532cde005e fix: ntfy webhook now sends plain text instead of JSON
- Modified generatePayloadFromTemplate to skip JSON validation for ntfy
- ntfy uses plain text body format, not JSON
- Messages now successfully delivered to ntfy topics
- Headers for title/priority/tags need dynamic templating support (future enhancement)
2025-08-31 16:07:42 +00:00
Pulse Monitor 71bc34504a feat: add ntfy.sh webhook support (addresses discussion #228)
- Added ntfy webhook template with proper payload format
- Updated frontend to include ntfy in service selection
- Supports both ntfy.sh cloud and self-hosted instances
- Uses priority levels, tags, and click actions for rich notifications
2025-08-31 15:51:29 +00:00
Pulse Monitor aadb43cf0c fix: improve node connection status tracking (addresses #385)
- nodes now properly show as disconnected when client creation fails
- all configured nodes are checked, not just ones with active clients
- connection health is tracked from the actual monitoring state
- added detailed logging when client creation fails to help diagnose issues
- storage and backup tabs should now properly reflect connection status

previously, if a node failed to create a client during initialization (due to auth issues, network problems, etc), it wouldn't be tracked at all, causing inconsistent UI state. now all configured nodes are properly tracked and their connection status is accurately reflected.
2025-08-31 15:26:32 +00:00
Pulse Monitor 900f8bb432 fix: improve VM disk usage detection from guest agent (addresses #367)
- Always attempt to get filesystem info from guest agent when cluster/resources or node APIs return 0 disk usage
- The Proxmox API often returns 0 for disk field even when guest agent has real data available
- More aggressively query guest agent for running VMs with 0 disk usage
- Improved logging to show when disk data is successfully retrieved from guest agent
2025-08-31 15:12:15 +00:00
Pulse Monitor e6253cfa3d fix: enable alert checking for mock mode data (addresses #399)
Mock mode was bypassing alert checking entirely, causing alerts not to trigger even when thresholds were exceeded. Added checkMockAlerts() function that processes mock VMs, containers, nodes and storage through the alert manager.
2025-08-31 15:03:09 +00:00
Pulse Monitor ad98491bf4 fix: add missing base64 import for password change handler 2025-08-31 08:50:48 +00:00
Pulse Monitor 52d91855ae chore: bump version to v4.11.0 2025-08-31 08:49:32 +00:00
Pulse Monitor 617b912d07 fix: prevent false positive alerts for powered-off VMs (addresses #397)
Fixed an issue where powered-off VMs were triggering CPU/RAM alerts.
Changes made:

1. Alert manager now skips ANY non-running VM (not just "stopped")
   - Handles all states: stopped, paused, suspended, etc.
   - Only checks thresholds for VMs with status="running"

2. Zero out metrics for non-running VMs/containers
   - Proxmox may report stale metrics for stopped VMs
   - Now explicitly sets CPU, memory, disk, network to 0 for non-running guests

3. Added debug logging to track VM states and metric handling

This ensures alerts only fire for actively running VMs and containers.
2025-08-31 08:44:18 +00:00
Pulse Monitor 401839620c improve: handle storage timeout errors more gracefully (addresses #389)
Storage operations on slow nodes were timing out after 30 seconds.
Made several improvements to handle this better:

- Increased default CONNECTION_TIMEOUT from 30s to 45s
- Added retry logic for storage queries that timeout
- Changed error logs to warnings for recoverable storage issues
- Storage polling now continues with other nodes if one fails

Users experiencing timeouts can also set CONNECTION_TIMEOUT env variable
to a higher value (e.g., CONNECTION_TIMEOUT=60s) if needed.
2025-08-31 08:40:22 +00:00
Pulse Monitor 2004042c27 fix: password change functionality now properly validates current password (addresses #396)
The change password feature was not working because the backend wasn't
actually verifying the current password before allowing changes. Fixed both
frontend and backend issues:

- Frontend now uses the correct username from localStorage
- Backend now properly validates the current password before allowing change
- Added proper security checks to prevent unauthorized password changes
2025-08-31 08:36:00 +00:00
Pulse Monitor bb505238c7 improve: enhance storage polling robustness and logging (addresses #385)
Storage polling now continues even if cluster-level storage config fails,
falling back to node-level storage data. Added comprehensive logging to
help diagnose storage/backup visibility issues.

Changes:
- Continue storage polling when cluster storage API fails
- Add detailed debug logging for storage operations
- Downgrade error to warning when API calls fail but can recover
- Better visibility into storage polling process
2025-08-31 08:31:31 +00:00
Pulse Monitor 54fc48b8d1 fix: clear custom payload when switching webhook types (addresses #378)
When switching from generic webhook to discord or other service types,
the custom payload template was persisting and being sent incorrectly.
Now clears the payload template when switching to non-generic services.
2025-08-31 08:21:30 +00:00
Pulse Monitor cf03e6f742 fix: broadcast state updates after alert acknowledgment (addresses #380)
- Add WebSocket hub reference to AlertHandlers
- Broadcast state after acknowledge, clear, and bulk operations
- Ensures UI acknowledgment counts update immediately without refresh
- Fixes issue where acknowledgment would disappear after 2 seconds
2025-08-31 06:58:10 +00:00
Pulse Monitor 120ae2bcbe fix: detect HTTPS protocol when behind reverse proxy for setup scripts
addresses #394 - setup script now correctly uses https:// in generated commands
when Pulse is running behind an HTTPS reverse proxy like Traefik by checking
the X-Forwarded-Proto header
2025-08-30 22:48:53 +00:00
Pulse Monitor 4a5086b378 improve: clarify CIDR notation requirement in installer IP prompt
addresses #392 - make it clear that static IP should include CIDR notation
2025-08-30 22:44:29 +00:00
Pulse Monitor 1156414f70 fix: enforce admin privileges for proxy auth users on write operations
addresses GHSA-wmgw-3g78-89xf - proxy authenticated non-admin users now properly receive 403 Forbidden when attempting write operations

- Added RequireAdmin middleware to check proxy auth admin role
- Applied admin checks to node add/update/delete operations
- Applied admin checks to system settings updates
- Applied admin checks to export/import operations
- Applied admin checks to API token regeneration
- Applied admin checks to password changes
- Non-admin proxy auth users now have proper read-only access as documented
2025-08-30 22:30:59 +00:00
Pulse Monitor 940a253dc8 fix: acknowledge alert button not updating count (addresses #380)
- Fixed reactivity issue with alertStats computation in SolidJS
- Properly access store values to ensure count updates when alerts are acknowledged
- Changed from Object.values() to mapping over keys for proper store reactivity
2025-08-30 17:12:33 +00:00
Pulse Monitor 76595e8865 fix: duplicate auto-update prompt when answering No (addresses #391)
- Set ENABLE_AUTO_UPDATES global variable when user responds in select_install_mode
- Only ask about auto-updates once during installation
- Fixed issue where answering No to auto-updates would prompt again later
2025-08-30 17:00:43 +00:00