gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-10 02:25:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(release): require explicit rollback targets in workflows

Browse Source
This commit is contained in:
rcourtman
2026-03-26 13:03:24 +00:00
parent 6bd0d3c401
commit f34ec16138
3 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/create-release.yml
+1 -1
View File
@@ -18,7 +18,7 @@ on:
type: string
rollback_version:
description: 'Required: prior stable version to pin for rollback (for example 5.1.14 or v5.1.14)'
required: false
required: true
type: string
ga_date:
description: 'First stable v6.0.0 GA only: exact GA publish date (YYYY-MM-DD)'
.github/workflows/release-dry-run.yml
+2 -2
View File
@@ -12,8 +12,8 @@ on:
required: false
type: string
rollback_version:
description: 'Optional rollback stable version to rehearse (for example 5.1.14 or v5.1.14)'
required: false
description: 'Required rollback stable version to rehearse (for example 5.1.14 or v5.1.14)'
required: true
type: string
ga_date:
description: 'Stable v6.0.0 rehearsal only: planned GA publish date (YYYY-MM-DD)'
scripts/release_control/release_promotion_policy_test.py
+6
View File
@@ -185,6 +185,12 @@ class ReleasePromotionPolicyTest(unittest.TestCase):
self.assertIn("Planned v5 end-of-support date", content)
self.assertIn("Stable v6.0.0 requires v5_eos_date in YYYY-MM-DD form", resolver)
self.assertIn("release_notes must include the Pulse v5 maintenance-only support notice", resolver)
dry_run_workflow = read(".github/workflows/release-dry-run.yml")
self.assertIn("Required rollback stable version to rehearse", dry_run_workflow)
self.assertIn("rollback_version:\n description: 'Required rollback stable version to rehearse", dry_run_workflow)
self.assertIn("required: true", dry_run_workflow)
self.assertIn("Required: prior stable version to pin for rollback", content)
self.assertIn("rollback_version:\n description: 'Required: prior stable version to pin for rollback", content)
self.assertIn("check-workflow-dispatch-inputs.py", helper)
self.assertIn('--branch "$CURRENT_BRANCH"', helper)
self.assertIn('--ref "$CURRENT_BRANCH"', helper)