gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-10-24 04:33:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bind backup read tests to cancellation and independent settlement

Browse Source 
The first exact-source proof passed 507 cases and rejected three stale test assumptions: the API now receives an AbortSignal, and a source failure notice may render before the other read has fulfilled. Assert the actual cancellation arguments and await independently readable rows without changing timeouts, runtime code or browser receipts.

Change-source: pulse-maintainer
This commit is contained in:
pulse-triage[bot]
2026-10-03 21:25:39 +01:00
parent d9292ef38c
commit d203eeb17a
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend-modern/src/features/proxmox/__tests__/ProxmoxBackupsTable.test.tsx
+9 -3
View File
@@ -343,8 +343,12 @@ describe('ProxmoxBackupsTable', () => {
for (const table of tables) {
expectCanonicalPlatformTableShell(table);
}
expect(apiFetchMock).toHaveBeenCalledWith('/api/backups/pbs');
expect(apiFetchMock).toHaveBeenCalledWith('/api/backups/pve');
expect(apiFetchMock).toHaveBeenCalledWith('/api/backups/pbs', {
signal: expect.any(AbortSignal),
});
expect(apiFetchMock).toHaveBeenCalledWith('/api/backups/pve', {
signal: expect.any(AbortSignal),
});
expect(apiFetchJSONMock).toHaveBeenCalledTimes(1);
const postureURL = new URL(apiFetchJSONMock.mock.calls[0][0], 'https://pulse.invalid');
expect(postureURL.pathname).toBe('/api/recovery/postures');
@@ -792,7 +796,9 @@ describe('independent Proxmox backup inventory reads', () => {
new RegExp(`${source.toUpperCase()} backup inventory is unavailable`),
);
expect(screen.queryByRole('alert')).not.toBeInTheDocument();
expect(recoverableRows()).toHaveLength(1);
// A failed source can now be actionable before the independent read
// settles. Wait for that read's evidence, not the failure notice.
await waitFor(() => expect(recoverableRows()).toHaveLength(1));
if (source === 'pbs') expect(serverTable()).toHaveTextContent('Unavailable');
const retry = screen.getByRole('button', { name: `Retry ${source.toUpperCase()} inventory` });
const pending = deferred<Response>();