gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-10 18:45:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix branch detection logic in install script

Browse Source 
Reorder the version check logic to prioritize branch/version specifications
over the up-to-date check. This ensures that --branch flag properly triggers
update mode instead of getting stuck in uptodate mode.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
courtmanr@gmail.com
2025-05-28 09:58:34 +01:00
parent bb640c17c2
commit d20170efcc
1 changed files with 22 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/install-pulse.sh
+22 -23
View File
@@ -366,36 +366,35 @@ check_installation_status_and_determine_action() {
print_info "Current installed version tag: ${current_tag:-Not on a tag}"
print_info "Latest available version tag: $latest_tag"
if [ -n "$current_tag" ] && [ "$current_tag" = "$latest_tag" ]; then
# Check for specific version/branch requests first
if [ -n "$SPECIFIED_VERSION_TAG" ]; then
if check_remote_tag_exists "$SPECIFIED_VERSION_TAG"; then
TARGET_TAG="$SPECIFIED_VERSION_TAG"
print_info "Will target specified version: $TARGET_TAG"
INSTALL_MODE="update"
else
INSTALL_MODE="error"; cd ..; return
fi
elif [ -n "$SPECIFIED_BRANCH" ]; then
print_info "Checking if remote branch '$SPECIFIED_BRANCH' exists..."
if sudo -u "$PULSE_USER" git ls-remote --heads origin "$SPECIFIED_BRANCH" | grep -q "$SPECIFIED_BRANCH"; then
TARGET_BRANCH="$SPECIFIED_BRANCH"
print_info "Will switch to branch: $TARGET_BRANCH"
INSTALL_MODE="update"
else
print_error "Remote branch '$SPECIFIED_BRANCH' not found."
INSTALL_MODE="error"; cd ..; return
fi
elif [ -n "$current_tag" ] && [ "$current_tag" = "$latest_tag" ]; then
print_info "Pulse is already installed and up-to-date with the latest release $latest_tag."
INSTALL_MODE="uptodate"
TARGET_TAG="$latest_tag"
else
print_warning "Pulse is installed, but an update to $latest_tag is available."
INSTALL_MODE="update"
TARGET_TAG="$latest_tag"
fi
fi
if [ -n "$SPECIFIED_VERSION_TAG" ]; then
if check_remote_tag_exists "$SPECIFIED_VERSION_TAG"; then
TARGET_TAG="$SPECIFIED_VERSION_TAG"
print_info "Will target specified version: $TARGET_TAG"
INSTALL_MODE="update"
else
INSTALL_MODE="error"; cd ..; return
fi
elif [ -n "$SPECIFIED_BRANCH" ]; then
print_info "Checking if remote branch '$SPECIFIED_BRANCH' exists..."
if sudo -u "$PULSE_USER" git ls-remote --heads origin "$SPECIFIED_BRANCH" | grep -q "$SPECIFIED_BRANCH"; then
TARGET_BRANCH="$SPECIFIED_BRANCH"
print_info "Will switch to branch: $TARGET_BRANCH"
INSTALL_MODE="update"
else
print_error "Remote branch '$SPECIFIED_BRANCH' not found."
INSTALL_MODE="error"; cd ..; return
fi
else
TARGET_TAG="$latest_tag"
fi
cd ..
if [ "$INSTALL_MODE" = "uptodate" ]; then