gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-25 04:33:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Link the real fix (agent connectivity + agent:exec scope) on discovery abstention

Browse Source
This commit is contained in:
rcourtman
2026-06-09 16:34:43 +01:00
parent 7234fbe71f
commit cfd7775a95
2 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend-modern/src/components/Discovery/DiscoveryTab.tsx
+10 -2
View File
@@ -713,10 +713,18 @@ export const DiscoveryTab: Component<DiscoveryTabProps> = (props) => {
{discovery()?.ai_reasoning ||
"Discovery completed but couldn't identify a known service."}
</p>
<Show when={discovery()?.ai_reasoning && props.commandsEnabled !== true}>
{/* The abstention only fires when command scanning is already
enabled, so the fix is agent connectivity + the agent:exec
token scope — link both entry points rather than telling the
user to enable a toggle that is already on. */}
<Show when={discovery()?.ai_reasoning}>
<p class="text-xs mt-2">
<a href={commandSettingsTarget.href} class="underline hover:no-underline">
Open {commandSettingsTarget.label}
{commandSettingsTarget.label}
</a>
{' · '}
<a href={apiAccessSettingsTarget.href} class="underline hover:no-underline">
{apiAccessSettingsTarget.label}
</a>
</p>
</Show>
frontend-modern/src/components/Discovery/__tests__/DiscoveryTab.test.tsx
+9 -4
View File
@@ -164,7 +164,7 @@ describe('DiscoveryTab', () => {
user_secrets: {},
confidence: 0,
ai_reasoning:
'Discovery could not run commands on this resource, so its service was not identified. Enable "Pulse Commands" for the host agent (Settings → Infrastructure) to run real discovery instead of guessing.',
'Discovery couldn\'t collect command output from inside this resource, so its service wasn\'t identified. Pulse Commands are enabled, but the host agent returned no results — make sure the host agent is connected and its API token has the "agent:exec" scope.',
discovered_at: '2026-06-09T00:00:00Z',
updated_at: '2026-06-09T00:00:00Z',
scan_duration: 0,
@@ -180,9 +180,14 @@ describe('DiscoveryTab', () => {
));
expect(await screen.findByText('Service not identified')).toBeInTheDocument();
expect(screen.getByText(/Discovery could not run commands on this resource/i)).toBeInTheDocument();
const settingsLink = screen.getByRole('link', { name: /Open Settings → Infrastructure/i });
expect(settingsLink).toHaveAttribute('href', '/settings/infrastructure');
// The abstention reason must be surfaced, and it must NOT tell the user to
// enable a command toggle that is already on.
expect(screen.getByText(/Pulse Commands are enabled, but the host agent returned no results/i)).toBeInTheDocument();
expect(screen.queryByText(/Enable "Pulse Commands"/i)).toBeNull();
const infraLink = screen.getByRole('link', { name: 'Settings → Infrastructure' });
expect(infraLink).toHaveAttribute('href', '/settings/infrastructure');
const apiAccessLink = screen.getByRole('link', { name: 'Settings → API Access' });
expect(apiAccessLink).toHaveAttribute('href', '/settings/security/api');
expect(
screen.queryByText("Discovery completed but couldn't identify a known service"),
).toBeNull();