test(notifications): verify ntfy recovery wire contract

Exercise UTF-8 titles and bodies across ordinary firing and recovery, with and without manager restart. Check each firing severity's priority and ensure recovery returns to default priority, as these headers affect phone interruption behaviour. Change-source: pulse-maintainer
2026-09-11 02:55:51 +00:00 · 2026-09-08 05:32:24 +01:00
parent 32654a0f93
commit cf7ea5f13e
1 changed files with 103 additions and 89 deletions
@@ -13,97 +13,111 @@ import (
 // Exercise normal notification entry points, not manually inserted queue jobs or
 // manufactured successful-delivery receipts. This is loopback source acceptance,
 // not installed alert-engine or real-provider qualification.
+// ntfy supports UTF-8 headers and gives priorities distinct phone behaviour:
+// https://docs.ntfy.sh/publish/#message-title
+// https://docs.ntfy.sh/publish/#message-priority
 func TestOrdinaryNotificationRecoveryUsesDeliveredReceipt(t *testing.T) {
-	for _, restart := range []bool{false, true} {
-		name := "same_process"
-		if restart {
-			name = "manager_restart"
-		}
-		t.Run(name, func(t *testing.T) {
-			type message struct{ title, body string }
-			received := make(chan message, 8)
-			server := newIPv4HTTPServer(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-				body, err := io.ReadAll(r.Body)
-				if err != nil {
-					t.Errorf("read notification: %v", err)
-				}
-				select {
-				case received <- message{r.Header.Get("Title"), string(body)}:
-				default:
-					t.Error("unexpected excess notifications")
-				}
-				w.WriteHeader(http.StatusAccepted)
-			}))
-			defer server.Close()
-			dir := t.TempDir()
-			webhook := WebhookConfig{ID: "ops", Name: "ops", URL: server.URL + "/topic", Enabled: true, Service: "ntfy"}
-			open := func() *NotificationManager {
-				m := NewNotificationManagerWithDataDir("", dir)
-				m.webhookClient = server.Client()
-				if err := m.UpdateAllowedPrivateCIDRs("127.0.0.1/32"); err != nil {
-					t.Fatal(err)
-				}
-				m.SetGroupingConfig(false, 0, false, false)
-				m.SetNotifyOnResolve(true)
-				m.AddWebhook(webhook)
-				t.Cleanup(m.Stop)
-				return m
-			}
-			m := open()
-			alert := &alerts.Alert{ID: "ordinary-cpu", ResourceName: "ordinary-node", Type: "cpu",
-				Level: alerts.AlertLevelCritical, Message: "CPU above threshold", StartTime: time.Now().Add(-time.Minute)}
-			recoveryJob := notificationDeliveryJob{Type: "webhook", Event: eventResolved, Alerts: []*alerts.Alert{alert}, WebhookConfig: &webhook}
-			waitReceipt := func(want bool) {
-				t.Helper()
-				deadline := time.Now().Add(10 * time.Second)
-				for {
-					got := len(m.filterResolvedJobsByDeliveryReceipt([]notificationDeliveryJob{recoveryJob})) == 1
-					if got == want {
-						return
-					}
-					if time.Now().After(deadline) {
-						t.Fatalf("recovery receipt present=%t, want %t", got, want)
-					}
-					time.Sleep(time.Millisecond)
-				}
-			}
-			next := func() message {
-				t.Helper()
-				select {
-				case msg := <-received:
-					return msg
-				case <-time.After(10 * time.Second):
-					t.Fatal("notification not received")
-					return message{}
-				}
-			}
-			m.SendAlert(alert)
-			firing := next()
-			if !strings.Contains(firing.title, alert.ResourceName) || !strings.Contains(firing.body, alert.Message) {
-				t.Fatalf("incorrect firing content: %+v", firing)
-			}
-			waitReceipt(true)
+	for _, severity := range []struct {
+		name     string
+		level    alerts.AlertLevel
+		priority string
+		label    string
+	}{
+		{"info", alerts.AlertLevelInfo, "default", "INFO"},
+		{"warning", alerts.AlertLevelWarning, "high", "WARNING"},
+		{"critical", alerts.AlertLevelCritical, "urgent", "CRITICAL"},
+	} {
+		for _, restart := range []bool{false, true} {
+			name := "same_process"
 			if restart {
-				m.Stop()
-				m = open()
+				name = "manager_restart"
+			}
+			t.Run(severity.name+"/"+name, func(t *testing.T) {
+				type message struct{ title, body, priority string }
+				received := make(chan message, 8)
+				server := newIPv4HTTPServer(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+					body, err := io.ReadAll(r.Body)
+					if err != nil {
+						t.Errorf("read notification: %v", err)
+					}
+					select {
+					case received <- message{r.Header.Get("Title"), string(body), r.Header.Get("Priority")}:
+					default:
+						t.Error("unexpected excess notifications")
+					}
+					w.WriteHeader(http.StatusAccepted)
+				}))
+				defer server.Close()
+				dir := t.TempDir()
+				webhook := WebhookConfig{ID: "ops", Name: "ops", URL: server.URL + "/topic", Enabled: true, Service: "ntfy"}
+				open := func() *NotificationManager {
+					m := NewNotificationManagerWithDataDir("", dir)
+					m.webhookClient = server.Client()
+					if err := m.UpdateAllowedPrivateCIDRs("127.0.0.1/32"); err != nil {
+						t.Fatal(err)
+					}
+					m.SetGroupingConfig(false, 0, false, false)
+					m.SetNotifyOnResolve(true)
+					m.AddWebhook(webhook)
+					t.Cleanup(m.Stop)
+					return m
+				}
+				m := open()
+				alert := &alerts.Alert{ID: "ordinary-cpu", ResourceName: "nœud-東京-🚨", Type: "cpu",
+					Level: severity.level, Message: "CPU above threshold — température élevée", StartTime: time.Now().Add(-time.Minute)}
+				recoveryJob := notificationDeliveryJob{Type: "webhook", Event: eventResolved, Alerts: []*alerts.Alert{alert}, WebhookConfig: &webhook}
+				waitReceipt := func(want bool) {
+					t.Helper()
+					deadline := time.Now().Add(10 * time.Second)
+					for {
+						got := len(m.filterResolvedJobsByDeliveryReceipt([]notificationDeliveryJob{recoveryJob})) == 1
+						if got == want {
+							return
+						}
+						if time.Now().After(deadline) {
+							t.Fatalf("recovery receipt present=%t, want %t", got, want)
+						}
+						time.Sleep(time.Millisecond)
+					}
+				}
+				next := func() message {
+					t.Helper()
+					select {
+					case msg := <-received:
+						return msg
+					case <-time.After(10 * time.Second):
+						t.Fatal("notification not received")
+						return message{}
+					}
+				}
+				m.SendAlert(alert)
+				firing := next()
+				if firing.title != severity.label+": "+alert.ResourceName || !strings.Contains(firing.body, alert.Message) || firing.priority != severity.priority {
+					t.Fatalf("incorrect firing content: %+v", firing)
+				}
 				waitReceipt(true)
-			}
-			// This is the cancellation gate used before ordinary recovery dispatch.
-			if m.CancelAlert(alert.ID) {
-				t.Fatal("delivered firing incorrectly treated as never delivered")
-			}
-			m.SendResolvedAlert(&alerts.ResolvedAlert{Alert: alert, ResolvedTime: time.Now()})
-			recovery := next()
-			if recovery.title != "RESOLVED: ordinary-node" || !strings.Contains(recovery.body, "is now healthy") {
-				t.Fatalf("incorrect recovery content: %+v", recovery)
-			}
-			waitReceipt(false)
-			m.Stop()
-			select {
-			case extra := <-received:
-				t.Fatalf("unexpected notification: %+v", extra)
-			default:
-			}
-		})
+				if restart {
+					m.Stop()
+					m = open()
+					waitReceipt(true)
+				}
+				// This is the cancellation gate used before ordinary recovery dispatch.
+				if m.CancelAlert(alert.ID) {
+					t.Fatal("delivered firing incorrectly treated as never delivered")
+				}
+				m.SendResolvedAlert(&alerts.ResolvedAlert{Alert: alert, ResolvedTime: time.Now()})
+				recovery := next()
+				if recovery.title != "RESOLVED: "+alert.ResourceName || !strings.Contains(recovery.body, alert.ResourceName) || !strings.Contains(recovery.body, "is now healthy") || recovery.priority != "default" {
+					t.Fatalf("incorrect recovery content: %+v", recovery)
+				}
+				waitReceipt(false)
+				m.Stop()
+				select {
+				case extra := <-received:
+					t.Fatalf("unexpected notification: %+v", extra)
+				default:
+				}
+			})
+		}
 	}
 }