gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-21 18:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: make individual node resource fetching non-blocking

Browse Source 
The smart cluster handling prevented endpoint duplication but individual
node resource fetching was still sequential and blocking. This adds:

- Promise.allSettled for parallel node resource fetching
- 8-second timeouts on individual resource requests
- Proper error handling for failed resources

This should completely eliminate dashboard freezes when nodes go offline.

Addresses issue #104 follow-up
This commit is contained in:
courtmanr@gmail.com
2025-06-04 20:42:18 +01:00
parent 6b0024f1ee
commit ccbb5c41c6
1 changed files with 21 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/dataFetcher.js
+21 -17
View File
@@ -129,7 +129,10 @@ async function initializePLimit() {
// Helper function to fetch data and handle common errors/warnings
async function fetchNodeResource(apiClient, endpointId, nodeName, resourcePath, resourceName, expectArray = false, transformFn = null) {
try {
const response = await apiClient.get(`/nodes/${nodeName}/${resourcePath}`);
// Add a short timeout for individual resource calls to fail fast
const response = await apiClient.get(`/nodes/${nodeName}/${resourcePath}`, {
timeout: 8000 // 8 second timeout per resource to prevent long blocks
});
const data = response.data?.data;
if (data) {
@@ -149,24 +152,25 @@ async function fetchNodeResource(apiClient, endpointId, nodeName, resourcePath,
}
async function fetchDataForNode(apiClient, endpointId, nodeName) {
const nodeStatus = await fetchNodeResource(apiClient, endpointId, nodeName, 'status', 'Node status');
const storage = await fetchNodeResource(apiClient, endpointId, nodeName, 'storage', 'Node storage', true);
const vms = await fetchNodeResource(
apiClient, endpointId, nodeName, 'qemu', 'VMs (qemu)', true,
(data) => data.map(vm => ({ ...vm, node: nodeName, endpointId: endpointId, type: 'qemu' }))
);
const containers = await fetchNodeResource(
apiClient, endpointId, nodeName, 'lxc', 'Containers (lxc)', true,
(data) => data.map(ct => ({ ...ct, node: nodeName, endpointId: endpointId, type: 'lxc' }))
);
// Make all node resource fetches parallel to prevent blocking when one node is down
const [nodeStatus, storage, vms, containers] = await Promise.allSettled([
fetchNodeResource(apiClient, endpointId, nodeName, 'status', 'Node status'),
fetchNodeResource(apiClient, endpointId, nodeName, 'storage', 'Node storage', true),
fetchNodeResource(
apiClient, endpointId, nodeName, 'qemu', 'VMs (qemu)', true,
(data) => data.map(vm => ({ ...vm, node: nodeName, endpointId: endpointId, type: 'qemu' }))
),
fetchNodeResource(
apiClient, endpointId, nodeName, 'lxc', 'Containers (lxc)', true,
(data) => data.map(ct => ({ ...ct, node: nodeName, endpointId: endpointId, type: 'lxc' }))
)
]);
return {
vms: vms || [],
containers: containers || [],
nodeStatus: nodeStatus || {},
storage: storage || [],
vms: (vms.status === 'fulfilled' ? vms.value : []) || [],
containers: (containers.status === 'fulfilled' ? containers.value : []) || [],
nodeStatus: (nodeStatus.status === 'fulfilled' ? nodeStatus.value : {}) || {},
storage: (storage.status === 'fulfilled' ? storage.value : []) || [],
};
}