gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-10 02:25:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge candidate 20260906T125520Z-core-runtime

Browse Source 
Change-source: pulse-maintainer
This commit is contained in:
pulse-triage[bot]
2026-09-06 14:16:35 +01:00
parent 35181d4c91 f5eba15cf6
commit bfd4ce6c85
1 changed files with 32 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/monitoring/monitor_pbs_coverage_test.go
+32 -2
View File
@@ -599,8 +599,9 @@ func TestPBSPolledCapacityRequiresObservedRecovery(t *testing.T) {
defer server.Close()
manager := alerts.NewManagerWithDataDir(t.TempDir())
defer manager.Stop()
manager.UpdateConfig(alerts.AlertConfig{Enabled: true, ActivationState: alerts.ActivationActive, MinimumDelta: 1,
TimeThresholds: map[string]int{"storage": 0}, StorageDefault: alerts.HysteresisThreshold{Trigger: 80, Clear: 70}})
basePolicy := alerts.AlertConfig{Enabled: true, ActivationState: alerts.ActivationActive, MinimumDelta: 1,
TimeThresholds: map[string]int{"storage": 0}, StorageDefault: alerts.HysteresisThreshold{Trigger: 80, Clear: 70}}
manager.UpdateConfig(basePolicy)
instance := config.PBSInstance{Name: "pbs-capacity", Host: server.URL, MonitorDatastores: true}
monitor := newPBSHealthAuthorityMonitor([]config.PBSInstance{instance})
monitor.alertManager = manager
@@ -614,6 +615,35 @@ func TestPBSPolledCapacityRequiresObservedRecovery(t *testing.T) {
monitor.syncUnifiedResourceAlertsToState(adapter.GetAll())
}
}
// Exercise the production poll-to-storage conversion, not just the
// manager's alias resolver: UI-written datastore policy must gate the
// new direct evaluation before it can create a capacity incident.
for _, policy := range []struct {
name string
configure func(*alerts.AlertConfig)
}{
{"alerts disabled", func(c *alerts.AlertConfig) { c.Enabled = false }},
{"storage disabled", func(c *alerts.AlertConfig) { c.DisableAllStorage = true }},
{"canonical datastore disabled", func(c *alerts.AlertConfig) {
c.Overrides = map[string]alerts.ThresholdConfig{"pbs-pbs-capacity/backups": {Disabled: true}}
}},
{"canonical datastore threshold", func(c *alerts.AlertConfig) {
c.Overrides = map[string]alerts.ThresholdConfig{"pbs-pbs-capacity/backups": {
Usage: &alerts.HysteresisThreshold{Trigger: 90, Clear: 80},
}}
}},
} {
t.Run(policy.name, func(t *testing.T) {
cfg := basePolicy
policy.configure(&cfg)
manager.UpdateConfig(cfg)
poll()
if active := manager.GetActiveAlerts(); len(active) != 0 {
t.Fatalf("poll bypassed capacity policy: %+v", active)
}
})
}
manager.UpdateConfig(basePolicy)
poll()
active := manager.GetActiveAlerts()
if len(active) != 1 || active[0].Type != "usage" || active[0].Value != 85 {