Revert "Auto-expand vSphere drawer section on platform pages"

This reverts commit 9008e5f45e.
This commit is contained in:
rcourtman
2026-05-22 21:41:44 +01:00
parent 9008e5f45e
commit ab5ed3ea6f
4 changed files with 1 additions and 16 deletions
@@ -21,7 +21,6 @@ interface ResourceDetailDrawerProps {
presentation?: ResourceDetailDrawerPresentation;
resolveResourceLabel?: (resourceId: string) => string | null | undefined;
initialShowTrueNASDetails?: boolean;
initialShowVMwareDetails?: boolean;
}
const TabAvailabilityNotice: Component<{ message: string }> = (props) => (
@@ -51,7 +50,6 @@ const DrawerContent: Component<ResourceDetailDrawerProps> = (props) => {
presentation: presentation(),
resolveResourceLabel: props.resolveResourceLabel,
initialShowTrueNASDetails: props.initialShowTrueNASDetails,
initialShowVMwareDetails: props.initialShowVMwareDetails,
});
const headingId = () => `resource-detail-drawer-heading-${props.resource.id}`;
@@ -275,7 +273,6 @@ export const ResourceDetailDrawer: Component<ResourceDetailDrawerProps> = (props
presentation={props.presentation}
resolveResourceLabel={props.resolveResourceLabel}
initialShowTrueNASDetails={props.initialShowTrueNASDetails}
initialShowVMwareDetails={props.initialShowVMwareDetails}
/>
);
};
@@ -1,5 +1,4 @@
import type {
Resource,
ResourceType,
ResourceVMwareBootDevice,
ResourceVMwareHardware,
@@ -755,6 +754,3 @@ export const buildVMwareDetailSections = (
return sections.filter((section) => hasRows(section.rows));
};
export const hasVMwareDetailSections = (resource: Resource): boolean =>
buildVMwareDetailSections(resource.type, resource.vmware).length > 0;
@@ -13,7 +13,6 @@ export interface UseResourceDetailDrawerStateOptions {
resolveResourceLabel?: (resourceId: string) => string | null | undefined;
presentation?: ResourceDetailDrawerPresentation;
initialShowTrueNASDetails?: boolean;
initialShowVMwareDetails?: boolean;
}
export const useResourceDetailDrawerState = (options: UseResourceDetailDrawerStateOptions) => {
@@ -28,9 +27,7 @@ export const useResourceDetailDrawerState = (options: UseResourceDetailDrawerSta
const [showDiscoveryContext, setShowDiscoveryContext] = createSignal(false);
const [showHostDetails, setShowHostDetails] = createSignal(false);
const [showServiceDetails, setShowServiceDetails] = createSignal(false);
const [showVMwareDetails, setShowVMwareDetails] = createSignal(
options.initialShowVMwareDetails === true,
);
const [showVMwareDetails, setShowVMwareDetails] = createSignal(false);
const [showTrueNASDetails, setShowTrueNASDetails] = createSignal(
options.initialShowTrueNASDetails === true,
);
@@ -1,7 +1,6 @@
import { Show, createSignal, type Component, type JSX } from 'solid-js';
import { ResourceDetailDrawer } from '@/components/Infrastructure/ResourceDetailDrawer';
import { hasTrueNASDetailSections } from '@/components/Infrastructure/resourceDetailDrawerTrueNASModel';
import { hasVMwareDetailSections } from '@/components/Infrastructure/resourceDetailDrawerVmwareModel';
import { TableCell, TableRow } from '@/components/shared/Table';
import type { Resource } from '@/types/resource';
import { getPreferredInfrastructureDisplayName } from '@/utils/resourceIdentity';
@@ -72,13 +71,10 @@ export const PlatformResourceDetailTableRow: Component<{
colSpan: number;
resolveResourceLabel?: (resourceId: string) => string | null | undefined;
initialShowTrueNASDetails?: boolean;
initialShowVMwareDetails?: boolean;
onClose?: () => void;
}> = (props) => {
const initialShowTrueNASDetails = () =>
props.initialShowTrueNASDetails ?? hasTrueNASDetailSections(props.resource);
const initialShowVMwareDetails = () =>
props.initialShowVMwareDetails ?? hasVMwareDetailSections(props.resource);
return (
<Show when={props.open}>
@@ -97,7 +93,6 @@ export const PlatformResourceDetailTableRow: Component<{
presentation="table-row"
resolveResourceLabel={props.resolveResourceLabel}
initialShowTrueNASDetails={initialShowTrueNASDetails()}
initialShowVMwareDetails={initialShowVMwareDetails()}
onClose={props.onClose}
/>
</div>