gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-10-15 08:33:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(#903): Add 2-minute timeout for pending config sync

Browse Source 
If an agent doesn't confirm the config change within 2 minutes (e.g., offline),
the sync indicator is cleared and a warning notification is shown. This prevents
the spinner from spinning forever when agents are unreachable.

The toggle returns to showing the agent-reported state after timeout, allowing
users to retry the toggle if needed.
This commit is contained in:
rcourtman
2025-12-25 08:19:43 +00:00
parent 0c7c6723c8
commit 974beeae48
1 changed files with 24 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend-modern/src/components/Settings/UnifiedAgents.tsx
+24 -8
View File
@@ -111,8 +111,8 @@ export const UnifiedAgents: Component = () => {
const [insecureMode, setInsecureMode] = createSignal(false); // For self-signed certificates (issue #806)
const [enableCommands, setEnableCommands] = createSignal(false); // Enable AI command execution (issue #903)
const [customAgentUrl, setCustomAgentUrl] = createSignal('');
// Track pending command config changes: hostId -> desired commandsEnabled value
const [pendingCommandConfig, setPendingCommandConfig] = createSignal<Record<string, boolean>>({});
// Track pending command config changes: hostId -> { desired value, timestamp }
const [pendingCommandConfig, setPendingCommandConfig] = createSignal<Record<string, { enabled: boolean; timestamp: number }>>({});
createEffect(() => {
if (requiresToken()) {
@@ -427,8 +427,11 @@ export const UnifiedAgents: Component = () => {
};
const handleToggleCommands = async (hostId: string, enabled: boolean) => {
// Set optimistic/pending state immediately
setPendingCommandConfig(prev => ({ ...prev, [hostId]: enabled }));
// Set optimistic/pending state immediately with timestamp
setPendingCommandConfig(prev => ({
...prev,
[hostId]: { enabled, timestamp: Date.now() }
}));
try {
await MonitoringAPI.updateHostAgentConfig(hostId, { commandsEnabled: enabled });
@@ -445,26 +448,39 @@ export const UnifiedAgents: Component = () => {
}
};
// Clear pending state when agent reports matching the expected value
// Clear pending state when agent reports matching the expected value, or after timeout
createEffect(() => {
const pending = pendingCommandConfig();
const hosts = state.hosts || [];
const now = Date.now();
const TIMEOUT_MS = 2 * 60 * 1000; // 2 minutes
// Check if any pending config now matches the reported state
// Check if any pending config now matches the reported state or has timed out
let updated = false;
const newPending = { ...pending };
const timedOut: string[] = [];
for (const hostId of Object.keys(pending)) {
const entry = pending[hostId];
const host = hosts.find(h => h.id === hostId);
if (host && host.commandsEnabled === pending[hostId]) {
if (host && host.commandsEnabled === entry.enabled) {
// Agent confirmed the change
delete newPending[hostId];
updated = true;
} else if (now - entry.timestamp > TIMEOUT_MS) {
// Timed out waiting for agent
delete newPending[hostId];
timedOut.push(host?.hostname || hostId);
updated = true;
}
}
if (updated) {
setPendingCommandConfig(newPending);
if (timedOut.length > 0) {
notificationStore.warning(`Config sync timed out for ${timedOut.join(', ')}. Agent may be offline.`);
}
}
});
@@ -953,7 +969,7 @@ export const UnifiedAgents: Component = () => {
// Use pending state if set, otherwise use agent-reported state
const pending = pendingCommandConfig();
const isPending = agent.id in pending;
const effectiveEnabled = isPending ? pending[agent.id] : agent.commandsEnabled;
const effectiveEnabled = isPending ? pending[agent.id].enabled : agent.commandsEnabled;
return (
<div class="flex items-center gap-2">