gsadmin/pulse
1
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-09-22 03:04:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: prioritize display names in node link resolution

Browse Source 
When custom node names are configured, the dashboard shows display names
but node links were failing because getHostUrl was checking actual node
names first. This fix reorders the lookup to check display names first,
ensuring that custom-named nodes have working links.

- Check display names before actual node names in getHostUrl
- Maintains backward compatibility for non-custom setups
- Fixes issue where clicking custom node names didn't open web interface

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
courtmanr@gmail.com
2025-05-31 22:56:56 +01:00
parent ff17a1786a
commit 8d838bb26e
1 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/public/js/utils.js
+21 -2
View File
@@ -326,6 +326,7 @@ PulseApp.utils = (() => {
function getHostUrl(nodeName) {
const endpoints = PulseApp.state.get('endpoints') || [];
const pbsConfigs = PulseApp.state.get('pbsConfigs') || [];
const nodesData = PulseApp.state.get('nodesData') || [];
// First check PBS configs for exact name match
for (const config of pbsConfigs) {
@@ -336,9 +337,18 @@ PulseApp.utils = (() => {
// For Proxmox nodes, we need to find which endpoint this node belongs to
// by looking at the nodes data from the API
const nodesData = PulseApp.state.get('nodesData') || [];
// Find the node in the API data to get its endpointId
// First check if nodeName matches a displayName (for nodes with custom names)
// This needs to be checked first because the UI shows displayName in headers
const nodeByDisplayName = nodesData.find(node => node.displayName === nodeName);
if (nodeByDisplayName && nodeByDisplayName.endpointId) {
const endpoint = endpoints.find(ep => ep.id === nodeByDisplayName.endpointId);
if (endpoint) {
return endpoint.host;
}
}
// Then find the node in the API data by actual node name
const nodeInfo = nodesData.find(node => node.node === nodeName);
if (nodeInfo && nodeInfo.endpointId) {
@@ -356,6 +366,15 @@ PulseApp.utils = (() => {
}
}
// Additional fallback: for standalone nodes, check if the endpoint name matches
// and there's only one node for that endpoint
for (const endpoint of endpoints) {
const endpointNodes = nodesData.filter(node => node.endpointId === endpoint.id);
if (endpointNodes.length === 1 && endpoint.name === nodeName) {
return endpoint.host;
}
}
return null;
}